diff options
| author | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2021-08-09 14:27:48 -0700 |
|---|---|---|
| committer | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2021-08-11 11:11:54 -0700 |
| commit | efff4a26916d1f0fa77bf43fdf57d5944e86f730 (patch) | |
| tree | 86f3cde582d5f4b514a8af0f7f8e275bd6174019 /CHANGES.md | |
| parent | 9a815fa0a22d39254d41fc2c98e9baffe7f31a4e (diff) | |
| download | thrift-efff4a26916d1f0fa77bf43fdf57d5944e86f730.tar.gz | |
THRIFT-5453: Defer DNS from NewTSocketConf to TSocket.Open
Client: go
We used to do DNS lookups in NewTSocketConf, without any timeout checks.
Stop doing that and do DNS lookups in TSocket.Open instead, which
already checks for ConnectTimeout set in TConfiguration.
Also remove the error return from NewTSocketConf.
Diffstat (limited to 'CHANGES.md')
| -rw-r--r-- | CHANGES.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/CHANGES.md b/CHANGES.md index a03204ba7..bfd8cb090 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -15,6 +15,7 @@ - [THRIFT-5381](https://issues.apache.org/jira/browse/THRIFT-5381) - possible collisions at VOID type with some 3rd-party libraries on Haxe cpp targets - [THRIFT-5396](https://issues.apache.org/jira/browse/THRIFT-5396) - deprecate netstd "Async" method postfix +- [THRIFT-5453](https://issues.apache.org/jira/browse/THRIFT-5453) - go: NewTSocketConf no longer returns an error ### AS3 @@ -78,6 +79,8 @@ - [THRIFT-5369](https://issues.apache.org/jira/browse/THRIFT-5369) - Malformed payload can still cause huge allocations - [THRIFT-5389](https://issues.apache.org/jira/browse/THRIFT-5389) - The compiler now generates correct go code with thrift constant defined on optional enum/typedef fields - [THRIFT-5404](https://issues.apache.org/jira/browse/THRIFT-5404) - TTransportException.Timeout would correctly return true when it's connect timeout during TSocket.Open call +- [THRIFT-4797](https://issues.apache.org/jira/browse/THRIFT-4797) - The compiler now correctly auto renames import thrift namespaces when they collide with system imports +- [THRIFT-5453](https://issues.apache.org/jira/browse/THRIFT-5453) - Defer DNS lookups from NewTSocketConf (without any timeout check) to TSocket.Open (subject to ConnectTimeout set in TConfiguration) ### Haskell |