summaryrefslogtreecommitdiff
path: root/build
diff options
context:
space:
mode:
authorubuntu <ubuntu@ubunu2004.linuxvmimagrs.local>2021-06-07 08:21:05 +0530
committerubuntu <ubuntu@ubunu2004.linuxvmimagrs.local>2021-06-07 08:21:05 +0530
commitad76a18db73b038f94e4e6f891abea6ee7b1876b (patch)
tree52560abd8c504c1af06b4beca4e7199ec8afdbad /build
parent323f0325edb387a447e5b5fedc852bb6971a0286 (diff)
downloadthrift-ad76a18db73b038f94e4e6f891abea6ee7b1876b.tar.gz
Add better unit tests and imbue C locale in floating point to_string
ToStringTest.cpp is a better place than JSONProtoTest.cpp for to_string tests. Move global locale-related unit tests there. Also imbue the C locale in the floating point to_string functions to avoid decimal number strings formatted with comma instead of decimal point. In Dockerfiles, install de_DE locale because it uses decimal comma.
Diffstat (limited to 'build')
-rw-r--r--build/docker/ubuntu-bionic/Dockerfile1
-rw-r--r--build/docker/ubuntu-disco/Dockerfile1
-rw-r--r--build/docker/ubuntu-xenial/Dockerfile1
3 files changed, 3 insertions, 0 deletions
diff --git a/build/docker/ubuntu-bionic/Dockerfile b/build/docker/ubuntu-bionic/Dockerfile
index 0407a6fff..a11e9bae0 100644
--- a/build/docker/ubuntu-bionic/Dockerfile
+++ b/build/docker/ubuntu-bionic/Dockerfile
@@ -258,6 +258,7 @@ RUN apt-get install -y --no-install-recommends \
`# Locale dependencies` \
locales && \
locale-gen en_US.UTF-8 && \
+ locale-gen de_DE.UTF-8 && \
update-locale
# cppcheck-1.82 has a nasty cpp parser bug, so we're using something newer
diff --git a/build/docker/ubuntu-disco/Dockerfile b/build/docker/ubuntu-disco/Dockerfile
index a175ed555..de99574f4 100644
--- a/build/docker/ubuntu-disco/Dockerfile
+++ b/build/docker/ubuntu-disco/Dockerfile
@@ -260,6 +260,7 @@ RUN apt-get install -y --no-install-recommends \
`# Locale dependencies` \
locales && \
locale-gen en_US.UTF-8 && \
+ locale-gen de_DE.UTF-8 && \
update-locale
# cppcheck-1.82 has a nasty cpp parser bug, so we're using something newer
diff --git a/build/docker/ubuntu-xenial/Dockerfile b/build/docker/ubuntu-xenial/Dockerfile
index 1c4373e44..441b6929b 100644
--- a/build/docker/ubuntu-xenial/Dockerfile
+++ b/build/docker/ubuntu-xenial/Dockerfile
@@ -240,6 +240,7 @@ RUN apt-get install -y --no-install-recommends \
`# Locale dependencies` \
locales && \
locale-gen en_US.UTF-8 && \
+ locale-gen de_DE.UTF-8 && \
update-locale
# Clean up