THRIFT-3067 C++ cppcheck performance related warnings

Patch: Arijit Chattopadhyay <arijitnit06@gmail.com>

This closes #444

3 files changed, 3 insertions, 4 deletions

diff --git a/contrib/fb303/TClientInfo.cpp b/contrib/fb303/TClientInfo.cpp
index 5959fb1fa..1fc661251 100644
--- a/contrib/fb303/TClientInfo.cpp
+++ b/contrib/fb303/TClientInfo.cpp
@@ -154,9 +154,8 @@ void TClientInfoServerHandler::getStatsStrings(vector<string>& result) {
     }
 
     timespec start;
-    double secs = 0.0;
     info->getTime(&start);
-    secs = (double)(now.tv_sec - start.tv_sec) + (now.tv_nsec - start.tv_nsec)*0.000000001;
+    double secs = (double)(now.tv_sec - start.tv_sec) + (now.tv_nsec - start.tv_nsec)*0.000000001;
 
     char buf[256];
     snprintf(buf, sizeof buf, "%d %s %s %.3f %llu", i, addrStr, callStr, secs,
diff --git a/contrib/fb303/cpp/FacebookBase.cpp b/contrib/fb303/cpp/FacebookBase.cpp
index 800334068..3c569759c 100644
--- a/contrib/fb303/cpp/FacebookBase.cpp
+++ b/contrib/fb303/cpp/FacebookBase.cpp
@@ -98,7 +98,7 @@ void FacebookBase::getCounters(std::map<std::string, int64_t>& _return) {
   // want our read/write structure to go over the wire
   counters_.acquireRead();
   for(ReadWriteCounterMap::iterator it = counters_.begin();
-      it != counters_.end(); it++)
+      it != counters_.end(); ++it)
   {
     _return[it->first] = it->second.value;
   }
diff --git a/contrib/fb303/cpp/ServiceTracker.cpp b/contrib/fb303/cpp/ServiceTracker.cpp
index 2914ff65a..7a61b21a9 100644
--- a/contrib/fb303/cpp/ServiceTracker.cpp
+++ b/contrib/fb303/cpp/ServiceTracker.cpp
@@ -251,7 +251,7 @@ ServiceTracker::reportCheckpoint()
   uint64_t count;
   for (iter = checkpointServiceDuration_.begin();
        iter != checkpointServiceDuration_.end();
-       iter++) {
+       ++iter) {
     count = iter->second.first;
     handler_->setCounter(string("checkpoint_count_") + iter->first, count);
     if (count == 0) {