summaryrefslogtreecommitdiff
path: root/lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java
diff options
context:
space:
mode:
authorDavid Reiss <dreiss@apache.org>2009-08-27 20:27:09 +0000
committerDavid Reiss <dreiss@apache.org>2009-08-27 20:27:09 +0000
commitaf81de0123c8d9920a25a27d28da66f9d00748cc (patch)
treea85adc2cfe4a3e5ae040f4b3eecb64e92f8013b8 /lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java
parent2c8cd944e50d4d69f00fde70ecee9c75ab924e2b (diff)
downloadthrift-af81de0123c8d9920a25a27d28da66f9d00748cc.tar.gz
Revert r806014 "THRIFT-562. java: Java is inconsistent ..."
- It changed the semantics of default-presence fields. - It messed up calls that accept exceptions. - Full details on issue. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@808609 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java')
-rwxr-xr-xlib/java/test/org/apache/thrift/test/TCompactProtocolTest.java6
1 files changed, 1 insertions, 5 deletions
diff --git a/lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java b/lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java
index 99173401e..5d1c3cba1 100755
--- a/lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java
+++ b/lib/java/test/org/apache/thrift/test/TCompactProtocolTest.java
@@ -324,11 +324,7 @@ public class TCompactProtocolTest {
T objRead = klass.newInstance();
objRead.read(proto);
- // TODO equals is broken when List<array> is involved, since AbstractList.equals(Object o)
- // calls o.equals, but for arrays that is just == which will never work when you are
- // comparing pre- and post- serialized versions. You need to use Arrays.equals instead.
- // So, here I have special-cased CPTS to avoid failing the test b/c of this bug.
- if (!obj.equals(objRead) && klass != CompactProtoTestStruct.class) {
+ if (!obj.equals(objRead)) {
System.out.println("Expected: " + obj.toString());
System.out.println("Actual: " + objRead.toString());
// System.out.println(buf.inspect());