diff options
author | James E. King, III <jim.king@simplivity.com> | 2016-10-05 14:47:18 -0400 |
---|---|---|
committer | Jens Geyer <jensg@apache.org> | 2016-10-13 22:59:20 +0200 |
commit | 36200904e78f11dd0ca2d751a9b35bb54790267b (patch) | |
tree | 448a41b829acb77538f33720efbd2b937542ecfd /lib/lua | |
parent | 3fa1940486b14ab94587ab580f2357fa65e51ba7 (diff) | |
download | thrift-36200904e78f11dd0ca2d751a9b35bb54790267b.tar.gz |
THRIFT-3943: resolve some high severity outstanding defects identified by coverity scan
Clients: C++, Lua
Patch: James E. King, III <jim.king@simplivity.com>
This closes #1109
Diffstat (limited to 'lib/lua')
-rw-r--r-- | lib/lua/src/usocket.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/lua/src/usocket.c b/lib/lua/src/usocket.c index be696e06e..d97112cfb 100644 --- a/lib/lua/src/usocket.c +++ b/lib/lua/src/usocket.c @@ -58,13 +58,14 @@ T_ERRCODE socket_wait(p_socket sock, int mode, int timeout) { end = __gettime() + timeout/1000; do { + FD_ZERO(&rfds); + FD_ZERO(&wfds); + // Specify what I/O operations we care about if (mode & WAIT_MODE_R) { - FD_ZERO(&rfds); FD_SET(*sock, &rfds); } if (mode & WAIT_MODE_W) { - FD_ZERO(&wfds); FD_SET(*sock, &wfds); } @@ -131,8 +132,8 @@ T_ERRCODE socket_bind(p_socket sock, p_sa addr, int addr_len) { T_ERRCODE socket_get_info(p_socket sock, short *port, char *buf, size_t len) { struct sockaddr_in sa; - socklen_t addrlen; memset(&sa, 0, sizeof(sa)); + socklen_t addrlen = sizeof(sa); int rc = getsockname(*sock, (struct sockaddr*)&sa, &addrlen); if (!rc) { char *addr = inet_ntoa(sa.sin_addr); |