diff options
author | Philip Frank <ich@philipfrank.de> | 2018-03-07 18:01:56 +0100 |
---|---|---|
committer | James E. King III <jking@apache.org> | 2018-03-08 11:55:08 -0500 |
commit | b963e286b4c847dd2692fdf8b025e35263b13e29 (patch) | |
tree | c062ca61aaec04aa092a6ebb2db1a8edfb24988a /lib/nodejs | |
parent | b4f22ff30119ea5cadf9b16e97afdcabefe06696 (diff) | |
download | thrift-b963e286b4c847dd2692fdf8b025e35263b13e29.tar.gz |
THRIFT-4509: remove nodejs browser test
Client: nodejs
This closes #1501
Diffstat (limited to 'lib/nodejs')
-rw-r--r-- | lib/nodejs/test/browser_client.js | 45 | ||||
-rwxr-xr-x | lib/nodejs/test/testAll.sh | 14 |
2 files changed, 0 insertions, 59 deletions
diff --git a/lib/nodejs/test/browser_client.js b/lib/nodejs/test/browser_client.js deleted file mode 100644 index 72fd8375b..000000000 --- a/lib/nodejs/test/browser_client.js +++ /dev/null @@ -1,45 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -var assert = require('assert'); -var thrift = require('thrift'); -var helpers = require('./helpers'); -var ThriftTest = require('./gen-nodejs/ThriftTest'); -var ThriftTestDriver = require('./test_driver').ThriftTestDriver; - -// createXHRConnection createWSConnection -var connection = thrift.createXHRConnection("localhost", 9090, { - transport: helpers.transports['buffered'], - protocol: helpers.protocols['json'], - path: '/test' -}); - -connection.on('error', function(err) { - assert(false, err); -}); - -// Uncomment the following line to start a websockets connection -// connection.open(); - -// createWSClient createXHRClient -var client = thrift.createXHRClient(ThriftTest, connection); - -ThriftTestDriver(client, function (status) { - console.log('Browser:', status); -}); diff --git a/lib/nodejs/test/testAll.sh b/lib/nodejs/test/testAll.sh index aae451a48..ac22b64e8 100755 --- a/lib/nodejs/test/testAll.sh +++ b/lib/nodejs/test/testAll.sh @@ -24,7 +24,6 @@ fi DIR="$( cd "$( dirname "$0" )" && pwd )" ISTANBUL="$DIR/../../../node_modules/istanbul/lib/cli.js" -RUNBROWSER="$DIR/../../../node_modules/run-browser/bin/cli.js" REPORT_PREFIX="${DIR}/../coverage/report" @@ -55,17 +54,6 @@ testServer() return $RET } -testBrowser() -{ - echo " Testing browser client with http server with json protocol and buffered transport"; - RET=0 - node ${DIR}/server.js --type http -p json -t buffered & - SERVERPID=$! - sleep 1 - ${RUNBROWSER} ${DIR}/browser_client.js --phantom || RET=1 - kill -2 $SERVERPID || RET=1 - return $RET -} TESTOK=0 @@ -96,8 +84,6 @@ do done done -# XHR only until phantomjs 2 is released. -# testBrowser if [ -n "${COVER}" ]; then ${ISTANBUL} report --dir "${DIR}/../coverage" --include "${DIR}/../coverage/report*/coverage.json" lcov cobertura html |