diff options
| author | James E. King III <jking@apache.org> | 2019-02-14 16:46:38 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-02-14 16:46:38 -0500 |
| commit | dbc1f8def5018ce5d85d38b9875c6c6b6b424478 (patch) | |
| tree | 0011127f2edd9221f973eb157438bbd11c0b74d2 /lib/nodejs | |
| parent | 3ca88065dfdb24c5bad6fbd1e3a7e01812628d3b (diff) | |
| download | thrift-dbc1f8def5018ce5d85d38b9875c6c6b6b424478.tar.gz | |
THRIFT-4024, THRIFT-4783: throw when skipping invalid type (#1742)
* THRIFT-4024: make c_glib throw on unsupported type when skipping
* THRIFT-4783: throw on invalid skip (py)
* THRIFT-4024: make cpp throw on unsupported type when skipping
* THRIFT-4024: uniform skip behavior on unsupported type
Diffstat (limited to 'lib/nodejs')
| -rw-r--r-- | lib/nodejs/lib/thrift/binary_protocol.js | 2 | ||||
| -rw-r--r-- | lib/nodejs/lib/thrift/compact_protocol.js | 2 | ||||
| -rw-r--r-- | lib/nodejs/lib/thrift/json_protocol.js | 2 |
3 files changed, 0 insertions, 6 deletions
diff --git a/lib/nodejs/lib/thrift/binary_protocol.js b/lib/nodejs/lib/thrift/binary_protocol.js index b57c8c576..6ab9c05a9 100644 --- a/lib/nodejs/lib/thrift/binary_protocol.js +++ b/lib/nodejs/lib/thrift/binary_protocol.js @@ -302,8 +302,6 @@ TBinaryProtocol.prototype.getTransport = function() { TBinaryProtocol.prototype.skip = function(type) { switch (type) { - case Type.STOP: - return; case Type.BOOL: this.readBool(); break; diff --git a/lib/nodejs/lib/thrift/compact_protocol.js b/lib/nodejs/lib/thrift/compact_protocol.js index 5c531e5d6..302a88d4d 100644 --- a/lib/nodejs/lib/thrift/compact_protocol.js +++ b/lib/nodejs/lib/thrift/compact_protocol.js @@ -854,8 +854,6 @@ TCompactProtocol.prototype.zigzagToI64 = function(n) { TCompactProtocol.prototype.skip = function(type) { switch (type) { - case Type.STOP: - return; case Type.BOOL: this.readBool(); break; diff --git a/lib/nodejs/lib/thrift/json_protocol.js b/lib/nodejs/lib/thrift/json_protocol.js index 727a3b2ff..7e2b7c908 100644 --- a/lib/nodejs/lib/thrift/json_protocol.js +++ b/lib/nodejs/lib/thrift/json_protocol.js @@ -738,8 +738,6 @@ TJSONProtocol.prototype.getTransport = function() { */ TJSONProtocol.prototype.skip = function(type) { switch (type) { - case Type.STOP: - return; case Type.BOOL: this.readBool(); break; |