diff options
| author | Jens Geyer <jensg@apache.org> | 2019-10-10 01:33:30 +0200 |
|---|---|---|
| committer | Jens Geyer <jensg@apache.org> | 2019-10-10 01:38:05 +0200 |
| commit | 85d8162dcbfd17db3bb8232a2dbb870dd9908cc4 (patch) | |
| tree | 3a814448be0df678dfa4650c32c454f9377b20d7 /test/AnnotationTest.thrift | |
| parent | 224b43ec7e916d2d588ad356762553fe2181aea5 (diff) | |
| download | thrift-85d8162dcbfd17db3bb8232a2dbb870dd9908cc4.tar.gz | |
Revert "THRIFT-4951: Remove senum from tests"
This reverts commit df8ef4b489e2b84ac6dbbf895be32d6fb2415c81.
The contributor confuses "deprecated" with "unsupported". Unless the feature as a whole is also removed, so essentially nothing is left to be tested. Regardless whether a particular feature is deprecated or not, removing a working test for it is NOT helpful. The only "achievement" of such efforts would be that the test coverage goes down, which is clearly not in our intention and only opens room for bugs and issues.
Diffstat (limited to 'test/AnnotationTest.thrift')
| -rw-r--r-- | test/AnnotationTest.thrift | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/test/AnnotationTest.thrift b/test/AnnotationTest.thrift index 6238395d4..7e24e1ccb 100644 --- a/test/AnnotationTest.thrift +++ b/test/AnnotationTest.thrift @@ -49,6 +49,14 @@ enum weekdays { SATURDAY ( weekend = "yes" ) } (foo.bar="baz") +/* Note that annotations on senum values are not supported. */ +senum seasons { + "Spring", + "Summer", + "Fall", + "Winter" +} ( foo = "bar" ) + struct ostr_default { 1: i32 bar; } |