| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
MSVC warning C4706: assignment within conditional expression
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The `PlatformSocket.h` defines some macros that reference
symbols in the libc without including the necessary headers.
Moreover, the headers are protected by config macros
(i.e. `#ifdef HAVE_UNISTD_H`). This makes header ordering
rather fragile.
Explicitly include `<thrift/config.h>` and conditionally
include `<unistd.h>` prior to referencing them.
A future improvement to reduce fragility would be to add
includes directly in `PlatformSocket.h`.
Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an equivalent implementation of `boost::numeric_cast`
written purely in standard c++.
The implementation is relatively trivial and reduces the
dependency on `boost`.
Adapted from
https://stackoverflow.com/a/49658950/5636218
Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The `<sys/poll.h>` header is not actually where `poll(2)` must be
defined according to the spec. However, it may be the case that
some random UNIX-like OS uses `<sys/poll.h>` instead.
Both use cases can be supported simply by including the proper
header, if it exists.
Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several build failures in Travis resulted from an include-order
problem in `TFileTransport.cpp`. It would probably be better to
simply include the right header files in `PlatformSocket.h`
but it's possible that might slow down compilation.
```
error: 'usleep' was not declared in this scope
..
# define THRIFT_SLEEP_USEC usleep
```
Also fixing the same (potential) problem in `TFDTransport.cpp`.
Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
|
|
|
|
|
|
| |
This avoids compiler warnings about inconsistent use
of `override`.
Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
|
|
|
|
|
|
|
| |
In Zephyr, optimize `TOutput::strerror_s` to minimize (stack)
space. The string error table is in ROM in any case, so string
values will not be overwritten (if they happen to be compiled-in).
Signed-off-by: Chris Friedt <cfriedt@fb.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Zephyr's byteorder is defined in
`<zephyr/sys/byteorder.h>`. However, the `bswap_xx`
macros are also defined there. They need to be `#undef`d
first when building for big-endian architectures, since
the Thrift byteorder macros are no-ops for little-endian
architectures.
Signed-off-by: Chris Friedt <cfriedt@fb.com>
|
|
|
|
|
|
|
|
| |
Manual runs of the autotools docker script were failing due to
`std::functional` not being a member of `std`. Similar error
messages for `std::ceil` and `std::log`.
Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
|
|
|
|
|
| |
Use of `std::placeholders::_1` requires `<functional>`.
Signed-off-by: Chris Friedt <cfriedt@fb.com>
|
|\
| |
| | |
THRIFT-5602: Use std::unique_ptr instead of boost::scoped_array
|
| |
| |
| |
| |
| |
| | |
Client: cpp
We can use std::unique_ptr because we require C++11 or later.
|
|/
|
|
| |
include
|
| |
|
| |
|
|
|
|
|
| |
set before
Only define and undefine NOMINMAX and WIN32_LEAN_AND_MEAN if they have not been set before.
|
|
|
|
| |
This warning can been seen when compiling generated code using Visual Studio 16.11.
|
|
|
|
| |
Client: C++
|
|
|
|
|
|
|
| |
CLient: cpp
Patch: Kevin Wojniak
This closes #2440
|
|\
| |
| | |
Minor cmake cleanup
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Client: cpp
Author: Rune Olesen
This closes #2287
|
|
|
|
|
|
|
|
|
|
|
| |
Client: cpp
Author: Benjamin Naecker
This closes #2380
Solaris-derived systems split some functionality that is usually found
in `sys/ioctl.h` into `sys/filio.h`. In this case, the `FIONREAD`
constant is in the latter file.
|
|
|
|
|
|
|
| |
Client: cpp
Patch: Ruslan <thgall@mail.ru>
This closes #2406
|
|\
| |
| | |
THRIFT-3840: C++ TJSONProtocol still using locale dependent formatting
|
| |
| |
| |
| |
| |
| |
| |
| | |
ToStringTest.cpp is a better place than JSONProtoTest.cpp for to_string
tests. Move global locale-related unit tests there.
Also imbue the C locale in the floating point to_string functions to avoid
decimal number strings formatted with comma instead of decimal point.
In Dockerfiles, install de_DE locale because it uses decimal comma.
|
| |
| |
| |
| | |
Install en_US.UTF-8 locale in Dockerfile
|
|/ |
|
|
|
|
|
|
|
|
|
| |
MessageSize after readEnd
Client: cpp
Patch: Irelian <240290942@qq.com>
This closes #2390
|
|
|
|
|
|
|
| |
Client: cpp
Patch: Triton <19377203+EnigmaTriton@users.noreply.github.com>
This closes #2305
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
TConfiguration class (cpp)
Client: cpp
Patch: Jens Geyer
Fixes an issue introduced with that ticket
|
| |
|
|
|
|
|
|
|
|
|
| |
Client: cpp
Patch: Riccardo Ghetta
This closes #2260
Signed-off-by: rglarix <rglarix@users.noreply.github.com>
|
|
|
|
|
|
|
| |
Client: cpp
Patch: Mario Emmenlauer
This closes #2281
|
|\
| |
| | |
Fix abstract unix socket name
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For the abstract unix socket address type, the string in the
'sun_path' field of the 'sockaddr_un' struct, is a not null-terminated
string (see unix(7)).
Fix the lentgh calculation of the 'sun_path' field to not add
the termination null byte.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
variable listening_)
Client: cpp
Patch: Mario Emmenlauer
This closes #2232
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
abstract domain socket paths
Client: cpp
Patch: Mario Emmenlauer
This closes #2233
|
|/
|
|
|
|
|
| |
Client: cpp
Patch: Mario Emmenlauer
This closes #2165
|