diff options
| author | ksourav <sourav.kir@gmail.com> | 2016-08-17 16:01:29 -0400 |
|---|---|---|
| committer | Steve Dickson <steved@redhat.com> | 2016-08-17 16:01:29 -0400 |
| commit | 4a8abc724adc6a8ad0d577d51e87098b73c8f480 (patch) | |
| tree | 4a1135676404123fb14b4b06a4ab91777eee6491 /src | |
| parent | 45ceae856f314f7367695e81e835ba4b306cd335 (diff) | |
| download | ti-rpc-4a8abc724adc6a8ad0d577d51e87098b73c8f480.tar.gz | |
getrpcport: Possible buffer overflow in memcpy
The if condition, when true, can result in memcpy
overflow as source sizecan become greater than the
destination in memcpy. Modified the if condition
to prevent memcoy overflow.
Signed-off-by: ksourav <sourav.kir@gmail.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/getrpcport.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/getrpcport.c b/src/getrpcport.c index b452c99..c28cd61 100644 --- a/src/getrpcport.c +++ b/src/getrpcport.c @@ -57,8 +57,8 @@ getrpcport(host, prognum, versnum, proto) memset(&addr, 0, sizeof(addr)); addr.sin_family = AF_INET; addr.sin_port = 0; - if (hp->h_length > sizeof(addr)) - hp->h_length = sizeof(addr); + if (hp->h_length > sizeof(addr.sin_addr.s_addr)) + hp->h_length = sizeof(addr.sin_addr.s_addr); memcpy(&addr.sin_addr.s_addr, hp->h_addr, (size_t)hp->h_length); /* Inconsistent interfaces need casts! :-( */ return (pmap_getport(&addr, (u_long)prognum, (u_long)versnum, |