diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2021-07-30 23:15:44 +0300 |
|---|---|---|
| committer | Bin Meng <bmeng.cn@gmail.com> | 2021-08-02 15:11:40 +0800 |
| commit | 46db4bbac3287a114ddf941ad3861381b795197b (patch) | |
| tree | 6e86cf8c56ced4667e0fcf04eeceb2a1bab99a4d | |
| parent | bd798eed5515ff435642b9b96f759aa0d7f2eb4c (diff) | |
| download | u-boot-46db4bbac3287a114ddf941ad3861381b795197b.tar.gz | |
x86: tangier: Fix DMA controller IRQ polarity in CSRT
IRQ polarity in CSRT has the same definition as by ACPI specification
chapter 19.6.64 "Interrupt (Interrupt Resource Descriptor Macro)", i.e.
ActiveHigh is 0, and ActiveLow is 1. On Intel Tangier the DMA controller
IRQ polarity is ActiveHigh.
Note, in DSDT (see southcluster.asl) it's described correctly.
Fixes: 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | arch/x86/cpu/tangier/acpi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c index 41bd177e09..82f4ce5a34 100644 --- a/arch/x86/cpu/tangier/acpi.c +++ b/arch/x86/cpu/tangier/acpi.c @@ -89,8 +89,8 @@ static u32 acpi_fill_csrt_dma(struct acpi_csrt_group *grp) si->mmio_base_low = 0xff192000; si->mmio_base_high = 0; si->gsi_interrupt = 32; - si->interrupt_polarity = 1; - si->interrupt_mode = 0; + si->interrupt_polarity = 0; /* Active High */ + si->interrupt_mode = 0; /* Level triggered */ si->num_channels = 8; si->dma_address_width = 32; si->base_request_line = 0; |