diff options
| author | Ramon Fried <ramon.fried@gmail.com> | 2018-06-08 20:53:27 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2018-06-18 14:02:04 -0400 |
| commit | e0212dfa1353310ab903263f8c737b8fb40b4fff (patch) | |
| tree | c149ff63395e448d8939f76ac3beb3ce43cec55e /common/iotrace.c | |
| parent | 501c89d33011e584b23e8e204e324512b4065948 (diff) | |
| download | u-boot-e0212dfa1353310ab903263f8c737b8fb40b4fff.tar.gz | |
iotrace: fix behaviour when buffer is full
Don't continue updating the offset when buffer is full.
When the buffer size exhausts and there's no space left to write
warn the user and update only the needed size and not both the
offset and needed size.
Add needed buffer size information in the iotrace command.
Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Diffstat (limited to 'common/iotrace.c')
| -rw-r--r-- | common/iotrace.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/common/iotrace.c b/common/iotrace.c index 83691b1dba..49bee3c92a 100644 --- a/common/iotrace.c +++ b/common/iotrace.c @@ -15,7 +15,8 @@ DECLARE_GLOBAL_DATA_PTR; * struct iotrace - current trace status and checksum * * @start: Start address of iotrace buffer - * @size: Size of iotrace buffer in bytes + * @size: Actual size of iotrace buffer in bytes + * @needed_size: Needed of iotrace buffer in bytes * @offset: Current write offset into iotrace buffer * @region_start: Address of IO region to trace * @region_size: Size of region to trace. if 0 will trace all address space @@ -25,6 +26,7 @@ DECLARE_GLOBAL_DATA_PTR; static struct iotrace { ulong start; ulong size; + ulong needed_size; ulong offset; ulong region_start; ulong region_size; @@ -55,7 +57,12 @@ static void add_record(int flags, const void *ptr, ulong value) rec = (struct iotrace_record *)map_sysmem( iotrace.start + iotrace.offset, sizeof(value)); + } else { + WARN_ONCE(1, "WARNING: iotrace buffer exhausted, please check needed length using \"iotrace stats\"\n"); + iotrace.needed_size += sizeof(struct iotrace_record); + return; } + rec->timestamp = timer_get_us(); rec->flags = flags; rec->addr = map_to_sysmem(ptr); @@ -65,6 +72,7 @@ static void add_record(int flags, const void *ptr, ulong value) iotrace.crc32 = crc32(iotrace.crc32, (unsigned char *)rec, sizeof(*rec)); + iotrace.needed_size += sizeof(struct iotrace_record); iotrace.offset += sizeof(struct iotrace_record); } @@ -162,10 +170,11 @@ void iotrace_set_buffer(ulong start, ulong size) iotrace.crc32 = 0; } -void iotrace_get_buffer(ulong *start, ulong *size, ulong *offset, ulong *count) +void iotrace_get_buffer(ulong *start, ulong *size, ulong *needed_size, ulong *offset, ulong *count) { *start = iotrace.start; *size = iotrace.size; + *needed_size = iotrace.needed_size; *offset = iotrace.offset; *count = iotrace.offset / sizeof(struct iotrace_record); } |