diff options
| author | Rico Tzschichholz <ricotz@ubuntu.com> | 2019-06-17 08:05:54 +0200 |
|---|---|---|
| committer | Rico Tzschichholz <ricotz@ubuntu.com> | 2019-06-17 08:08:32 +0200 |
| commit | e186c470fecc5f2d38a9711682be8b9fac1fdeca (patch) | |
| tree | 12a28af8b920b1d4e243d7ed2bc2687d9d816e38 /vala/valapropertyaccessor.vala | |
| parent | 86002f129c6bf2dded1953ffbe97f92bd236b65f (diff) | |
| download | vala-e186c470fecc5f2d38a9711682be8b9fac1fdeca.tar.gz | |
vala: Only warn about imcompatible type of external construct property
This is to reduce the initial fallout.
Fixes https://gitlab.gnome.org/GNOME/vala/issues/803
Diffstat (limited to 'vala/valapropertyaccessor.vala')
| -rw-r--r-- | vala/valapropertyaccessor.vala | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/vala/valapropertyaccessor.vala b/vala/valapropertyaccessor.vala index 3c826737b..7603a0492 100644 --- a/vala/valapropertyaccessor.vala +++ b/vala/valapropertyaccessor.vala @@ -206,9 +206,14 @@ public class Vala.PropertyAccessor : Subroutine { Report.error (source_reference, "construct properties require `GLib.Object'"); return false; } else if (construction && !context.analyzer.is_gobject_property (prop)) { - error = true; - Report.error (source_reference, "construct properties not supported for specified property type"); - return false; + //TODO Report an error for external property too + if (external_package) { + Report.warning (source_reference, "construct properties not supported for specified property type"); + } else { + error = true; + Report.error (source_reference, "construct properties not supported for specified property type"); + return false; + } } if (body != null && prop.is_abstract) { |