Warn if signal hides member in base class

1 files changed, 6 insertions, 0 deletions

diff --git a/vala/valasignal.vala b/vala/valasignal.vala
index c58e160e1..207d8f737 100644
--- a/vala/valasignal.vala
+++ b/vala/valasignal.vala
@@ -265,6 +265,12 @@ public class Vala.Signal : Member, Lockable {
 			cl.add_hidden_method (default_handler);
 			default_handler.check (analyzer);
 		}
+
+
+		if (!external_package && !hides && get_hidden_member () != null) {
+			Report.warning (source_reference, "%s hides inherited signal `%s'. Use the `new' keyword if hiding was intentional".printf (get_full_name (), get_hidden_member ().get_full_name ()));
+		}
+
 		return !error;
 	}
 }