summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* viewport: Remove mention of wl_surface.attach x/yKenny Levinsen2022-04-111-6/+0
| | | | | | | | | | | | | This paragraph contains an incomplete definition of how wl_surface.attach x/y arguments functions, and makes no reference to the similar wl_surface.offset. The paragraph states that there is no effect on the behavior of wl_surface.attach. Rather than elaborating on its definition and adding wl_surface.offset, remove the paragraph and let their definition be up to wl_surface itself. Signed-off-by: Kenny Levinsen <kl@kl.wtf>
* xdg-shell: clarify setting the parent to an unmapped toplevelKirill Primak2022-04-061-9/+9
| | | | Signed-off-by: Kirill Primak <vyivel@eclair.cafe>
* members: add Simon Zeni for wlroots/SwaySimon Ser2022-03-291-1/+2
| | | | | | Simon Zeni has stepped up as a member for wlroots/Sway. Signed-off-by: Simon Ser <contact@emersion.fr>
* text-input: Reword the interpretation of serials to be more specificCarlos Garnacho2022-03-291-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here's a long story. The serial is formerly described as: When the client receives a done event with a serial different than the number of past commit requests, it must proceed as normal, except it should not change the current state of the zwp_text_input_v3 object. Upon first reading it might be obvious to interpret "proceed as normal" as "apply the changes made by the done event" and "not change the current state" as "do not make requests on it until serial matches with expectations again". This would turn the serial into a flow control mechanism to avoid pushing state changes that we know might be stale. GTK however makes another outlandish interpretation, where "proceed as normal" means "ignore the changes made by the done event" and "not change state of the zwp_text_input_v3 object" is "not change client state". This makes the serial a full synchronization mechanism where IM commands that are deemed out of sync are symply ignored. This would seem a misinterpretation of the protocol, and I proceeded to change the behavior in GTK. Then some deja vu feeling struck me and I found https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/384#note_344864, this change was already done and discussed in the past. Not just that, it is the right interpretation. However, there's some notable disadvantages, there's 2 easy ways to completely break the synchronization between compositor and client: Having the IM push new state too often (i.e. multiple consecutive .done events), or having the client .commit too often. If any of both peers gets ahead of the other slightly, the end result is ignored input. More specifically, IBus has no provision for this kind of transactional behavior (probably other IMs too), so implementing "emit .done once after a set of changes" is not quite possible. Arguably, ignoring IM input is also a bad thing. IMs expect all commands to be respected and applied in order and might even rely on that in their own internal state. Since only state changes are flushed on .done events, partially ignoring IM commands will end up with the client IM state out of sync. The usecase described at that GNOME gitlab comment (edited text changes happening in parallel to IM interaction) trades the handling of an inherently racy corner case with the worst kind of mishandling (ignoring user input) if IM/client don't perfectly sync up. On the other hand, the flow control approach is more lenient with IMs and clients "getting a step ahead", and more importantly does not punish the user whenever either IM/client happens to do that. Double down on this (already intuitively correct) description, and specify further what it implies. Signed-off-by: Carlos Garnacho <carlosg@gnome.org>
* members: say goodbye to Drew DeVaultSimon Ser2022-03-251-2/+1
| | | | | | | | | Drew is no longer involved in Wayland development and has expressed interest in being removed from the wayland-protocols project. Thanks for all your contributions throughout the years, Drew! Signed-off-by: Simon Ser <contact@emersion.fr>
* staging/drm-lease: Annotate destructor eventTadeo Kondrak2022-02-251-1/+1
| | | | Signed-off-by: Tadeo Kondrak <me@tadeo.ca>
* linux-explicit-synchronization: Annotate destructor eventsTadeo Kondrak2020-06-111-2/+2
| | | | Signed-off-by: Tadeo Kondrak <me@tadeo.ca>
* fullscreen-shell: Annotate destructor eventsTadeo Kondrak2020-06-111-3/+3
| | | | Signed-off-by: Tadeo Kondrak <me@tadeo.ca>
* presentation-time: Annotate destructor eventsTadeo Kondrak2020-06-111-2/+2
| | | | Signed-off-by: Tadeo Kondrak <me@tadeo.ca>
* build: Bump wayland-scanner version to 1.20.0Tadeo Kondrak2022-02-251-1/+1
| | | | | | | Wayland 1.20.0 adds support for the type attribute to mark events as destructors. Signed-off-by: Tadeo Kondrak <me@tadeo.ca>
* ci: upgrade wayland to 1.20.0Simon Ser2022-02-232-2/+17
| | | | | | | This will be useful to use features introduced in wayland 1.20, e.g. event destructors. Signed-off-by: Simon Ser <contact@emersion.fr>
* ci: add meson-logs artifactsSimon Ser2022-02-231-0/+5
| | | | | | Makes it easier to investigate CI failures. Signed-off-by: Simon Ser <contact@emersion.fr>
* build: Bump version to 1.251.25Jonas Ådahl2022-01-261-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-shell: add invalid_resize_edge error valueIsaac Freund2022-01-191-6/+12
| | | | | | | | | The protocol states that the edges parameter of the resize request must be one of the values of the resize_edge enum but does not provide a protocol error value to handle the case where it is not. This commit adds that error value. Signed-off-by: Isaac Freund <mail@isaacfreund.com>
* xdg-shell: Add toplevel "bounds" configure eventJonas Ådahl2022-01-191-5/+29
| | | | | | | | | | | This aims to communicate the maximum size a surface should be created with, and loosely corresponds to the concept of "work area" in the X11 world. Closes: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/17 Signed-off-by: Jonas Ådahl <jadahl@gmail.com> Reviewed-by: Simon Ser <contact@emersion.fr>
* linux-dmabuf: fix typo in dev_t example codeSimon Ser2022-01-171-1/+1
| | | | | | dev_t is not a struct, it's a typedef. Signed-off-by: Simon Ser <contact@emersion.fr>
* ext-session-lock-v1: new protocolIsaac Freund2021-12-283-0/+287
| | | | | | | | | | | | | This protocol allows for a privileged Wayland client to lock the session and display arbitrary graphics while the session is locked. The client is responsible for performing authentication and informing the compositor when the session should be unlocked. If the client dies while the session is locked the session remains locked, possibly permanently depending on compositor policy. Signed-off-by: Isaac Freund <mail@isaacfreund.com> Reviewed-by: Simon Ser <contact@emersion.fr>
* xdg-shell: clarify conditions for remapping unmapped surfacesMax Ihlenfeldt2021-11-241-1/+2
| | | | Signed-off-by: Max Ihlenfeldt <mihlenfeldt@igalia.com>
* build: Bump version to 1.241.24Jonas Ådahl2021-11-231-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* linux-dmabuf: send protocol error on invalid format/modifierSimon Ser2021-11-231-4/+2
| | | | | | | | | Now that compositors must send INVALID to advertise support for implicit modifiers, we can make it a protocol error to add a DMA-BUF plane with an unsupported format + modifier pair. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Daniel Stone <daniels@collabora.com>
* unstable/linux-dmabuf: add wp_linux_dmabuf_feedbackSimon Ser2021-11-232-12/+444
| | | | | | | | | | | | | | | | | | | | | | | | | | On multi-GPU setups, multiple devices can be used for rendering. Clients need feedback about the device in use by the compositor. For instance, if they render on another GPU, then they need to make sure the memory is accessible between devices and that their buffers are not placed in hidden memory. This commit introduces a new wp_linux_dmabuf_feedback object. This object advertises a preferred main device, a set of preferred formats/modifiers and target devices. Each object is bound to a wl_surface and can dynamically update its feedback parameters. This enables fine-grained per-surface optimizations. For instance, when a surface is scanned out on a GPU the compositor isn't compositing with, the target device can be set to this GPU to avoid unnecessary roundtrips. A feedback object can also be standalone for clients that don't support per-surface feedback. Signed-off-by: Simon Ser <contact@emersion.fr> Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com> Reviewed-by: Daniel Stone <daniels@collabora.com> Closes: https://gitlab.freedesktop.org/wayland/wayland/issues/59
* Improve tiled_* enum summaryDemi Marie Obenour2021-11-171-4/+4
| | | | | | No change in behavior, just a doc fix. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* linux-dmabuf: add note about pre-multiplied alphaSimon Ser2021-11-101-0/+3
| | | | | | | | | | | | Add a note about pre-multiplied alpha for all DRM formats. Include an escape hatch in the spec to allow other protocol extensions to override this. Essentially the same as [1]. [1]: https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/187 Signed-off-by: Simon Ser <contact@emersion.fr>
* Drop autotoolsSimon Ser2021-11-096-166/+2
| | | | | | | It's been a few releases that we ship Meson support, we should be able to drop the old autotools build system now. Signed-off-by: Simon Ser <contact@emersion.fr>
* Use “software” instead of “user space”Demi Marie Obenour2021-10-131-2/+2
| | | | | | | | | On Genode, graphics drivers run in user space. It is also theoretically possible for a Wayland compositor to run in kernel space. Therefore, the phrase “user space” should be avoided in a Wayland protocol specification. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* tests: check whether -Wl,--unresolved-symbols=ignore-all is supportedAlex Richardson2021-10-111-4/+6
| | | | | | | | When linking for macOS, this linker flag is rejected. Instead of always passing it, we can check whether it is supported first. Signed-off-by: Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> Reviewed-by: Simon Ser <contact@emersion.fr>
* tests: allow cross-compiling the testsAlex Richardson2021-10-041-3/+1
| | | | | | | | | | | | | I am trying to cross-compile from macOS for FreeBSD and this is currently failing since the tests attempt to build a native binary that links against the wayland-client and wayland-server libraries for the FreeBSD system. I believe we should be building them for the target system and not the current host (especially since there is no way to build wayland-client and wayland-server for macOS, but I do want to check that the files build correctly for FreeBSD). Signed-off-by: Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> Reviewed-by: Simon Ser <contact@emersion.fr>
* meson.build: wayland-scanner is only needed for testsFabrice Fontaine2021-09-192-2/+1
| | | | | | | wayland-scanner is only needed for tests so don't require it if tests are disabled Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
* build: Bump version to 1.231.23Jonas Ådahl2021-09-152-2/+2
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* pointer-gestures: add hold gesturesPeter Hutterer2021-09-131-8/+75
| | | | | | | | | | | | | | | | | | Hold gestures merely denote "there are fingers on the touchpad but they are not moving". As touchpad touches are generally fully abstracted, a client cannot currently know when a user is interacting with the touchpad without moving - no motion events will be sent in this case. The two use-cases here are: - hold-to-interact: where a hold gesture is active for some time a menu could pop up, or some object is selected, etc. - hold-to-cancel: where e.g. kinetic scrolling is currently active, the start of a hold gesture can be used to stop the scroll Since hold gestures by definition do not have movement, there is no need for an "update" stage in the gesture. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Set Vlad Zahorodnii as kwin maintainerDavid Edmundson2021-09-091-1/+1
| | | | | Signed-off-by: David Edmundson <davidedmundson@kde.org> Signed-off by: Eike Hein <hein@kde.org>
* build: Bump version to 1.221.22Jonas Ådahl2021-09-012-2/+2
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* build: only require C/C++ compilers for hostSimon Ser2021-09-011-1/+3
| | | | | | | | | | We use the no-op executables in test() directives, so these will be run on the host. This fixes the following warning: tests/meson.build:23: WARNING: add_languages is missing native:, assuming languages are wanted for both host and build. Signed-off-by: Simon Ser <contact@emersion.fr>
* build: fix indentation in tests/meson.buildSimon Ser2021-09-011-4/+4
| | | | | | The rest of the file uses tabs, not spaces. Signed-off-by: Simon Ser <contact@emersion.fr>
* build: declare dependency for use as a subprojectSimon Ser2021-09-011-1/+9
| | | | | | | This allows clients and compositors to easily use wayland-protocols as a Meson subproject. Signed-off-by: Simon Ser <contact@emersion.fr>
* tests: Include libwayland cflags/ldflagsDaniel Stone2021-08-281-0/+1
| | | | | | | | When we're building C++ test executables, make sure we pull in the correct libwayland headers, to avoid trying to compile against a version different from the scanner we built it against. Signed-off-by: Daniel Stone <daniels@collabora.com>
* readme: fix unformatted label referencesSimon Ser2021-08-061-3/+3
| | | | | | | The newlines prevent the labels from being properly formatted. Additionally, the second label reference has a typo (extra "s"). Signed-off-by: Simon Ser <contact@emersion.fr>
* staging/drm-lease: DRM lease protocol supportXaver Hugl2021-08-064-0/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | | DRM leasing is a feature which allows the DRM master to "lease" a subset of its DRM resources to another DRM master via drmModeCreateLease, which returns a file descriptor for the new DRM master. We use this protocol to negotiate the terms of the lease and transfer this file descriptor to clients. In less DRM-specific terms: this protocol allows Wayland compositors to give over their GPU resources (like displays) to a Wayland client to exclusively control. The primary use-case for this is Virtual Reality headsets, which via the non-desktop DRM property are generally not used as desktop displays by Wayland compositors, and for latency reasons (among others) are most useful to games et al if they have direct control over the DRM resources associated with it. Basically, these are peripherals which are of no use to the compositor and may be of use to a client, but since they are tied up in DRM we need to use DRM leasing to get them into client's hands. Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Signed-off-by: Drew DeVault <sir@cmpwn.com> Signed-off-by: Xaver Hugl <xaver.hugl@gmail.com> Reviewed-by: Simon Ser <contact@emersion.fr> Signed-off-by: David Edmundson <davidedmundson@kde.org> Reviewed-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-activation: rewrite and move description of token forwardingRoman Gilg2021-08-041-13/+16
| | | | | | | | | | | | | | | After a requesting client receives a new token, the client usually forwards the token string to another client by a different process, which then uses the token in an activate request. For that the token string must be transferred to the other process. Two default ways of doing that were described in the done event, but the description had some issues and it makes more sense to describe them in the protocol description itself, which talks about the protocol in a more general way. Therefore rewrite the paragraphs about token forwarding between clients and place them in the protocol description. Signed-off-by: Roman Gilg <subdiff@gmail.com>
* xdg-activation: correct sequence when X11 client spawns Wayland clientRoman Gilg2021-08-041-4/+3
| | | | | | | The Wayland client requests surface activation directly using the token that it received from the X11 client. Signed-off-by: Roman Gilg <subdiff@gmail.com>
* xdg-activation: use rst inline codeRoman Gilg2021-08-041-10/+10
| | | | | | rst requires two backticks to format text as inline code. Signed-off-by: Roman Gilg <subdiff@gmail.com>
* xdg-activation: use rst linkRoman Gilg2021-08-041-2/+2
| | | | | | Instead of writing the link in brackets use the rst link functionality. Signed-off-by: Roman Gilg <subdiff@gmail.com>
* presentation-time: use enum entry description tagsSimon Ser2021-07-271-36/+36
| | | | | | | | | | | | | Instead of describing each enum entry in the enum description, use enum entry descriptions. This avoids the awkward list of flags in the top-level description. This has been possible for a long time, but wasn't correctly handled by wayland-scanner until recently [1]. [1]: https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/151 Signed-off-by: Simon Ser <contact@emersion.fr>
* xdg-shell: Make xdg_surface fail when surface has roleDaniel Stone2021-07-211-1/+3
| | | | | | | | | | | | | | | | | | | | It is illegal for a surface to have more than one role. The only thing which can be done with an xdg_surface (apart from destroying it) is to assign the surface a role with the get_toplevel, get_popup, etc requests. On Mutter, calling get_xdg_surface on a surface which already has an assigned role generates the 'role' protocol error. Weston will not send an error, however it may later abort on a failed assert during cleanup. wlroots allows this case, and only sends the role error when assigning an explicit role through creating a toplevel or popup. On the grounds that it makes no sense to create an xdg_surface for a wl_surface which already has a role, make it explicitly illegal. cf. wayland/weston!559, wayland/weston!627 Signed-off-by: Daniel Stone <daniels@collabora.com>
* xdg-activation-v1: clarify set_{serial,surface}Simon Ser2021-07-011-4/+15
| | | | | | Make it clearer what the requests are used for. Signed-off-by: Simon Ser <contact@emersion.fr>
* readme: mention the DCOSimon Ser2021-06-251-0/+6
| | | | | | | | | | We haven't mentionned the DCO anywhere, yet we were requiring all contributions to have a Signed-off-by line to accept it. Add a reference to the DCO in our README's "development procedure" section. Signed-off-by: Simon Ser <contact@emersion.fr>
* tests: Fix build with -WextraXavier Claessens2021-06-232-0/+4
| | | | | | | | | Unused arguments warnings are treated as errors in those tests otherwise. Fixes: #53. Signed-off-by: Xavier Claessens <xavier.claessens@collabora.com>
* xdg-output: fix minor calculation errorManuel Stoeckl2021-06-071-1/+1
| | | | | Signed-off-by: Manuel Stoeckl <code@mstoeckl.com> Reviewed-by: Simon Ser <contact@emersion.fr>
* xdg-activation: Fix an inconsistencyVlad Zahorodnii2021-06-071-2/+2
| | | | | | | The spec uses the terms "presentation token" and "activation token" interchangeably, which can cause confusion. Signed-off-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org>
* tests: use dynamic python pathIssam E. Maghni2021-06-031-1/+1
| | | | | | | | | | | Stop hardcoding the Python path to /usr/bin/python3. Not all systems have Python installed to /usr/bin, and some users might have installed Python to a custom location. Instead, use /usr/bin/env, which performs a $PATH lookup to find the Python executable. Signed-off-by: Issam E. Maghni <issam.e.maghni@mailbox.org>
View Lorry Controller Status