summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* CI: bump ci-templatesHEADmainPekka Paalanen2023-05-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should fix the following problem when I targeted a MR to branch 'color' in Sebastian's fork of wayland-protocols: $ ci-fairy check-commits --signed-off-by --junit-xml=results.xml Traceback (most recent call last): File "/usr/bin/ci-fairy", line 33, in <module> sys.exit(load_entry_point('ci-fairy==0.1', 'console_scripts', 'ci-fairy')()) File "/usr/lib/python3.9/site-packages/click/core.py", line 1137, in __call__ return self.main(*args, **kwargs) File "/usr/lib/python3.9/site-packages/click/core.py", line 1062, in main rv = self.invoke(ctx) File "/usr/lib/python3.9/site-packages/click/core.py", line 1668, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/lib/python3.9/site-packages/click/core.py", line 1404, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/lib/python3.9/site-packages/click/core.py", line 763, in invoke return __callback(*args, **kwargs) File "/usr/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func return f(get_current_context(), *args, **kwargs) File "/usr/lib/python3.9/site-packages/ci_fairy.py", line 1335, in check_commits for commit in repo.iter_commits(commit_range): File "/usr/lib/python3.9/site-packages/git/objects/commit.py", line 318, in _iter_from_process_or_stream finalize_process(proc_or_stream) File "/usr/lib/python3.9/site-packages/git/util.py", line 370, in finalize_process proc.wait(**kwargs) File "/usr/lib/python3.9/site-packages/git/cmd.py", line 447, in wait raise GitCommandError(remove_password_if_present(self.args), status, errstr) git.exc.GitCommandError: Cmd('git') failed due to: exit code(128) cmdline: git rev-list cifairy/color..HEAD -- stderr: 'fatal: bad revision 'cifairy/color..HEAD' ' Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
* tablet-v2: fix typo in set_cursor serial descriptionSimon Ser2023-05-091-1/+1
| | | | | | | | | This interface has no "enter" event. This was likely copy-pasted from wl_pointer.set_cursor. The event which indicates focus is proximity_in. Signed-off-by: Simon Ser <contact@emersion.fr>
* ci: skip ci-fairy checks on main branchSimon Ser2023-04-251-0/+4
| | | | | | | | We merged a commit by mistake which doesn't have S-o-b. ci-fairy is unhappy about it and will fail the check. Skip it if we aren't running in a merge request context. Signed-off-by: Simon Ser <contact@emersion.fr>
* ci: use detached CI pipelinesSimon Ser2023-04-251-0/+5
| | | | | | | | | | See [1], required to allow contributors to trigger CI pipelines for MRs. Example failure can be found at [2]. [1]: https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/540#what-it-means-for-me-a-maintainer-of-a-project-part-of-gitlabfreedesktoporg [2]: https://gitlab.freedesktop.org/i509VCB/wayland-protocols/-/jobs/40117393 Signed-off-by: Simon Ser <contact@emersion.fr>
* Add ext-foreign-toplevel-list protocoli509VCB2023-04-253-0/+224
|
* linux-dmabuf: Fix a couple of typosVlad Zahorodnii2023-04-181-2/+2
| | | | | | There are no interfaces such as zlinux_dmabuf_params and zlinux_buffer_params. Signed-off-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org>
* xdg-shell: Clarify window geometry boundsJonas Ådahl2023-04-041-1/+3
| | | | | | | | The xdg_surface window geometry can extend outside the base wl_surface to e.g. accompany subsurfaces that extend outside it but is part of the window itself. Spell out this bit explicitly. Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-shell: Clarify that geometry doesn't automatically changeJonas Ådahl2023-04-041-5/+12
| | | | | | | | | | | | | | The spec says that When applied, the effective window geometry will be the set window geometry clamped to the bounding rectangle of the combined geometry of the surface of the xdg_surface and the associated subsurfaces. Thus, a client cannot assume the geometry will adapt to any subsequent changes to any conditions that constrained the geometry. Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-shell: Clarify relationship between [un]set_maximized and configureMikhail Gusarov2023-03-302-0/+20
| | | | | | | | | | Make it explicit in the protocol that [un]set_maximized and the following configure event can't be reliably matched, and the clients shouldn't try to do it. Closes #106 Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
* unstable/xdg-shell v6: clarify when which errors are usedXaver Hugl2023-03-301-11/+20
| | | | Signed-off-by: Xaver Hugl <xaver.hugl@gmail.com>
* Add a .mailmap fileFaith Ekstrand2023-03-251-0/+3
| | | | | | | | | This will let command-line Git tools re-map my name and e-mail address properly. I'm using my personal e-mail address and not my Collabora address because I'm not actively contributing to Wayland anymore and this is mostly for letting people find me should they dig me up in the project history. Signed-off-by: Faith Ekstrand <faith@gfxstrand.net>
* xdg-output: Remove and tweak contradicting examplesJonas Ådahl2023-02-271-9/+5
| | | | | | | | | | | | | | | | | | | | | The "logical size" as stated by the first paragraph corresponds to the monitor size in the global compositor space. To most clients, this is unnecessary information, and should be ignored, but some used the listed examples to derive information that contradicts the very definition of what this event communicates. One example tried to add surface size assumptions, which was not correct. Remove this part completely, clients should not try to configure their surface sizes from the logical size of a monitor. The other is the list of size examples; it tried to communicate that a compositor sometimes may not scale the viewport of the monitor in its global compositor coordinate space, in which case, the logical size itself matches the actual resolution. Tweak this wording to make that clear that it does not related to any surface size. Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-output: clarify goalSimon Ser2023-02-211-6/+6
| | | | | | | | | | | | | In the past, xdg-output had only the logical_position and logical_size events, then the name and description events were added. Later on, they were moved inside wl_output since they aren't desktop-specific. However the goals section of the protocol overview hasn't been updated accordingly. Make it clear that this protocol's name and description events should not be preferred over wl_output. Signed-off-by: Simon Ser <contact@emersion.fr>
* xdg-output-unstable-v1: deprecate name and descriptionSimon Ser2023-02-121-0/+6
| | | | | | | These have been merged into wl_output. Clients should prefer using wl_output events instead of relying on xdg-output. Signed-off-by: Simon Ser <contact@emersion.fr>
* ext-session-lock-v1: relicense to MITIsaac Freund2023-02-101-11/+17
| | | | | | | | | | | | All other protocols in wayland-protocols are released under the MIT license and this one was only merged with the ISC license by accident. I am the only person who has touched this protocol in commits and the only copyright holder, so relicensing to bring this protocol in line with the rest is easy in this case. References: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/119 Signed-off-by: Isaac Freund <mail@isaacfreund.com>
* ext-session-lock-v1: clarify to fix raceIsaac Freund2023-02-101-8/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clients such as swaylock [1] or waylock [2] provide options to fork and detach from the controlling terminal when the session is locked. The point of these options is avoid a race on suspending the system. A command to suspend the system (e.g. zzz) may safely be chained with e.g. waylock as so: waylock -fork-on-lock && zzz However, there is no guarantee that the compositor has actually blanked all outputs before sending the locked event. Therefore there is still a race as new "locked" frames may not have been presented on all outputs before the system is suspended. On my Linux system at least, the current framebuffer seems to be preserved on suspend and restored on resume, leading to an "unlocked" frame potentially being displayed when the system is resumed. Blanking all outputs before suspend eliminates this vulnerability. Currently clients could theoretically implement such -fork-on-lock options a bit better if the compositor supports the presentation-time protocol, however no clients I've seen currently do this and it seems wise to make clients to do the right thing by default in this security sensitive context. The presentation-time protocol is also not sufficient in all cases, for example if the compositor has turned off power of an output but still exposes it to clients. In this case the client would wait forever to get a presentation feedback that will never come. Unfortunately, the protocol currently states that the locked event will be sent immediately on creation of the ext_session_lock_v1 object rather than after all normal content is hidden. Several different approaches have been considered for how to fix this in the protocol specification. One possibility would be to add a new event sent when all normal content is hidden. This is however opt-in for clients and therefore less likely to be properly implemented by all clients in practice. Another alternative is to bump the version of the ext_session_lock_v1 interface and state that the semantics of when the compositor will send the locked event. However, this still requires clients to opt-in by binding version 2 of the interface. The compositor could technically deny the attempts of any version 1 clients to lock the session, but this would likely be a bad breaking change for users of version 1 clients. While session lock clients should inform the user in some way that their attempt to lock the session was denied (e.g. by exiting non-zero) it does not seem to be the case that such exit codes are widely checked. The option to fix the protocol that is all around the most secure is changing the semantics of the locked event without bumping the version of the interface. This is technically a breaking change, but the failure mode is that a client relying on the locked event being sent immediately hangs or crashes and the session stays locked. I also have been unable to find any session lock client in the wild that relies on the locked event being sent immediately. The river wayland compositor [3] in fact already implements the fix for this race condition since the 0.2.0 release and has not received any bug reports about broken session lock clients yet. Therefore, I think that making this technically breaking change to the protocol is our all around best option in this situation. Prioritizing security over compatibility seems like the right trade-off to make for a security critical protocol. [1]: https://github.com/swaywm/swaylock [2]: https://github.com/ifreund/waylock [3]: https://github.com/riverwm/river Signed-off-by: Isaac Freund <mail@isaacfreund.com>
* ext-session-lock-v1: use RFC 2119 key wordsIsaac Freund2023-02-101-15/+19
| | | | Signed-off-by: Isaac Freund <mail@isaacfreund.com>
* staging/drm-lease: clarify connector namingXaver Hugl2023-01-231-0/+4
| | | | | | | | If the compositor advertises an output as a wp_drm_lease_connector_v1 and as wl_output, it should make the names match to allow clients to identify the connection between the two outputs. Signed-off-by: Xaver Hugl <xaver.hugl@gmail.com>
* Add merge request template for new protocolsSimon Ser2023-01-231-0/+9
| | | | | | Adds the checklist and the appropriate labels automatically. Signed-off-by: Simon Ser <contact@emersion.fr>
* Fix typo in xdg-activation-v1Philip Withnall2022-12-191-1/+1
| | | | | | | | | | Noticed during review in https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/98#note_1003427, but not changed at the time. Noticed again in https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3090#note_1606895. Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
* build: Bump version to 1.311.31Jonas Ådahl2022-11-291-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* Add Victoria as Smithay/cosmic-comp memberJonas Ådahl2022-11-291-0/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-shell: add defunct_role_object errorKirill Primak2022-11-291-1/+4
| | | | Signed-off-by: Kirill Primak <vyivel@eclair.cafe>
* wp-fractional-scale-v1: new protocolKenny Levinsen2022-11-283-0/+107
| | | | | | | | This protocols allows for communicating preferred fractional scales to surfaces, which in combination with wp_viewport can be used to render surfaces at fractional scales when applicable. Signed-off-by: Kenny Levinsen <kl@kl.wtf>
* governance: improve consistency of ACK requirementsSimon Ser2022-11-231-1/+1
| | | | | | | | | | For "ext" and "wp", the document uses the wording "ACKed by at least 3 members". For "ext", the document uses the wording "ACKed by at least one other member". This is confusing, let's just use the same wording everywhere. Signed-off-by: Simon Ser <contact@emersion.fr>
* build: Bump version to 1.301.30Jonas Ådahl2022-11-211-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* staging: add tearing control protocolXaver Hugl2022-11-143-0/+125
| | | | | | | | | For some use cases like games or drawing tablets it can make sense to reduce latency by accepting tearing with the use of asynchronous page flips. This protocol provides a way for clients to indicate whether or not their content is suitable for this kind of presentation. Signed-off-by: Xaver Hugl <xaver.hugl@gmail.com>
* build: Bump version to 1.291.29Jonas Ådahl2022-11-141-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* linux-dmabuf: fix references to tranche_formatsManuel Stoeckl2022-11-141-5/+5
| | | | Signed-off-by: Manuel Stoeckl <code@mstoeckl.com>
* content-type: fix enum name in wp_content_type_v1.set_content_typei509VCB2022-11-051-1/+1
| | | | | | This was originally set to `content_type`, but the protocol defines an enum named `type`. This fixes an issue with the protocol that was noticed when binding the protocol in wayland-rs. Signed-off-by: i509VCB <git@i509.me>
* build: Bump version to 1.281.28Jonas Ådahl2022-11-041-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* Add xdg-shell.unresponsive errorDemi Marie Obenour2022-11-041-2/+7
| | | | | | | This allows compositors to disconnect clients that have been deemed unresponsive. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* xdg-shell: Add specific errorsDemi Marie Obenour2022-11-041-17/+28
| | | | | | This adds specific errors for all xdg_shell errors. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* xdg-shell: window menus are optionalDemi Marie Obenour2022-11-041-1/+2
| | | | | | | A compositor is free to completely ignore requests to draw a window menu. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* xdg-shell: Replace an HTTP link with HTTPSDemi Marie Obenour2022-11-041-1/+1
| | | | | | No normative change. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* xwayland_shell_v1: New protocolJoshua Ashton2022-10-283-0/+167
| | | | | | | | | | | | | | | | | | | | | | | | This protocol adds a xwayland_surface role which allows an Xwayland server to associate an X11 window to a wl_surface. Before this protocol, this would be done via the Xwayland server providing the wl_surface's resource id via the WL_SURFACE_ID atom on the X window. This was problematic as a race could occur if the wl_surface associated with a WL_SURFACE_ID for a window was destroyed before the update of the atom was processed by the compositor and another surface (or other object) had taken its id due to recycling. This protocol solves the problem by moving the X11 window to wl_surface association step to the Wayland side, which means that the association cannot happen out-of-sync with the resource lifetime of the wl_surface. This protocol avoids duplicating the race on the other side by adding a non-zero monotonic serial number which is entirely unique that is set on both the wl_surface (via. xwayland_surface_v1's associate method) and the X11 window (via. the `WL_SURFACE_SERIAL` atom) that can be used to associate them, and synchronize the two timelines. Signed-off-by: Joshua Ashton <joshua@froggi.es>
* build: Bump version to 1.271.27Jonas Ådahl2022-10-101-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* xdg-shell: ack_configure must be strictly monotonicDaniel Stone2022-10-101-0/+12
| | | | | | | | | | | | | | | Clients must send ack_configure in a strictly monotonic order wrt received configure events. It is an error to send an ack_configure request for a configure event which was sent prior to the last ack_configure for that surface, or to send multiple ack_configures for the same configure event. Weston and wlroots already use this interpretation, however Mutter and KWayland are more lax and allow duplicates. This clarification tightens the spec working to explicitly encode the Weston/wlroots behaviour. Signed-off-by: Daniel Stone <daniels@collabora.com> Closes: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/21
* build: alphabetically sort list of staging protocolsSimon Ser2022-10-031-3/+3
| | | | | | | This helps with merge conflicts when a protocol is merged. This is also more consistent with the other protocol lists above. Signed-off-by: Simon Ser <contact@emersion.fr>
* staging/content-type: Content type hint supportEmmanuel Gil Peyrot2022-10-033-0/+134
| | | | | | | | | This protocol lets clients advertise which kind of content they expect to be displayed on a given surface, so that the compositor can make more informed decisions about its behavior and output configuration. Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Signed-off-by: Xaver Hugl <xaver.hugl@gmail.com>
* ext-idle-notify: new protocolSimon Ser2022-10-033-0/+107
| | | | | | | | | | | | | | | | | This patch adds a new ext-idle-notify protocol. It allows clients to be notified when the user is idle. Use-cases include e.g. power management daemons. This protocol is based on the org_kde_kwin_idle interface already being used by KDE and wlroots compositors. The protocol has been sent to wayland-protocols in 2015 [1]. This version renames and clarifies the interfaces, and addresses the review comments. [1]: https://lists.freedesktop.org/archives/wayland-devel/2015-December/026045.html Signed-off-by: Simon Ser <contact@emersion.fr> Closes: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/8 Reviewed-by: David Edmundson <davidedmundson@kde.org>
* ext-session-lock: add note on client terminationIsaac Freund2022-09-261-0/+8
| | | | | | See https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/262 Signed-off-by: Isaac Freund <mail@isaacfreund.com>
* xdg-shell: forbid loops in set_parentSimon Ser2022-09-171-0/+6
| | | | | | | These don't make sense. Add a protocol error for this case. Signed-off-by: Simon Ser <contact@emersion.fr> Closes: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/105
* build: Bump version to 1.261.26Jonas Ådahl2022-07-071-1/+1
| | | | Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
* single-pixel-buffer: new protocolSimon Ser2022-07-073-0/+74
| | | | | | | | | This protocol allows creating single-pixel buffers. It can be useful to avoid having to allocate a real buffer just to fill it with the same pixel value. Some use-cases include drawing background surfaces or toplevel decorations. Signed-off-by: Simon Ser <contact@emersion.fr>
* xdg-shell: introduce toplevel wm_capabilitiesSimon Ser2022-07-071-5/+40
| | | | | | | | | | | | Some compositors don't implement all of the features of xdg-shell. This results in UI elements (e.g. buttons) in clients which do nothing when activated. Add a wm_capabilities event to allow clients to hide these UI elements when they don't make sense. Signed-off-by: Simon Ser <contact@emersion.fr> Closes: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/64
* tablet: fix a copy/paste errorPeter Hutterer2022-06-281-1/+1
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* build: stop using deprecated Meson functionsSimon Ser2022-06-042-3/+3
| | | | | | | | | | Fixes the following warning: NOTICE: Future-deprecated features used: * 0.55.0: {'ExternalProgram.path'} * 0.56.0: {'dependency.get_pkgconfig_variable'} Signed-off-by: Simon Ser <contact@emersion.fr>
* readme: Mandate proper use of RFC 2119 keywordsAlexandros Frantzis2022-06-011-0/+20
| | | | | | | | This mandate makes explicit a practice that's already established in the writing of the protocol descriptions, and officially clarifies the meaning of the keywords for readers. Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
* xdg-shell: Delete duplicate paragraph in xdg_popupDaniel Stone2022-06-011-4/+0
| | | | | | This is already covered about three paragraphs above. Signed-off-by: Daniel Stone <daniels@collabora.com>
View Lorry Controller Status