diff options
author | Simon Steinbeiss <simon.steinbeiss@elfenbeinturm.at> | 2020-11-04 14:27:26 +0100 |
---|---|---|
committer | Simon Steinbeiss <simon.steinbeiss@elfenbeinturm.at> | 2020-11-04 14:27:26 +0100 |
commit | 8e4e7cb8b687550278696f9e607693d374fcb208 (patch) | |
tree | c6abc10303d82949827dd34a7e9e32899130e93b /common | |
parent | c7936452c09a02e5f0ff7790fa05f14321b41733 (diff) | |
download | ixfce4-power-manager-8e4e7cb8b687550278696f9e607693d374fcb208.tar.gz |
Guard against NULL pointer dereference
Diffstat (limited to 'common')
-rw-r--r-- | common/xfpm-brightness.c | 21 |
1 files changed, 15 insertions, 6 deletions
diff --git a/common/xfpm-brightness.c b/common/xfpm-brightness.c index 9fb5b9c7..d74d50fc 100644 --- a/common/xfpm-brightness.c +++ b/common/xfpm-brightness.c @@ -365,8 +365,11 @@ xfpm_brightness_helper_get_value (const gchar *argument) &stdout_data, NULL, &exit_status, &error); if ( !ret ) { - g_warning ("failed to get value: %s", error->message); - g_error_free (error); + if (error) + { + g_warning ("failed to get value: %s", error->message); + g_error_free (error); + } goto out; } g_debug ("executed %s; retval: %i", command, exit_status); @@ -447,8 +450,11 @@ xfpm_brightness_helper_set_level (XfpmBrightness *brg, gint32 level) ret = g_spawn_command_line_sync (command, NULL, NULL, &exit_status, &error); if ( !ret ) { - g_warning ("xfpm_brightness_helper_set_level: failed to set value: %s", error->message); - g_error_free (error); + if (error) + { + g_warning ("xfpm_brightness_helper_set_level: failed to set value: %s", error->message); + g_error_free (error); + } goto out; } g_debug ("executed %s; retval: %i", command, exit_status); @@ -487,8 +493,11 @@ xfpm_brightness_helper_set_switch (XfpmBrightness *brg, gint brightness_switch) ret = g_spawn_command_line_sync (command, NULL, NULL, &exit_status, &error); if ( !ret ) { - g_warning ("xfpm_brightness_helper_set_switch: failed to set value: %s", error->message); - g_error_free (error); + if (error) + { + g_warning ("xfpm_brightness_helper_set_switch: failed to set value: %s", error->message); + g_error_free (error); + } goto out; } g_debug ("executed %s; retval: %i", command, exit_status); |