diff options
| author | Nick Schermer <nick@xfce.org> | 2009-11-24 10:52:11 +0100 |
|---|---|---|
| committer | Nick Schermer <nick@xfce.org> | 2009-12-26 12:39:59 +0100 |
| commit | f514a7580a8d43264ec1b39e4521ea15485330c5 (patch) | |
| tree | 309d15d97bb2c6896ce1831a5c4bf8c4ff1d9d4e /xfconf/xfconf-cache.c | |
| parent | c27f4a1e86ff649f8c8ffc1d5d3bb68f2dafb00e (diff) | |
| download | xfconf-f514a7580a8d43264ec1b39e4521ea15485330c5.tar.gz | |
Fix double free.
When leaving the reply handler xfconf should only remove
the mutex lock and not free the item since we only looked
it up from the hash table, it's not stolen yet.
Diffstat (limited to 'xfconf/xfconf-cache.c')
| -rw-r--r-- | xfconf/xfconf-cache.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/xfconf/xfconf-cache.c b/xfconf/xfconf-cache.c index f4e23f8..d7d8504 100644 --- a/xfconf/xfconf-cache.c +++ b/xfconf/xfconf-cache.c @@ -497,10 +497,9 @@ xfconf_cache_set_property_reply_handler(DBusGProxy *proxy, xfconf_cache_mutex_lock(&cache->cache_lock); } -out: if(old_item) xfconf_cache_old_item_free(old_item); - +out: xfconf_cache_mutex_unlock(&cache->cache_lock); } |