diff options
| author | Alex Gendin <ukkeefy@gmail.com> | 2020-09-26 23:26:07 -0400 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2021-08-02 20:30:21 +0000 |
| commit | c2811c953620cf946269db2b74b29e0dc707e26a (patch) | |
| tree | ee166539b49b8a36d4cc89a68d871059b1e6211a /process.c | |
| parent | d7e5021416444e3cc545ffa4f8d1e613cabec633 (diff) | |
| download | xorg-app-xauth-c2811c953620cf946269db2b74b29e0dc707e26a.tar.gz | |
Fix segfault when X starts
This patch potentially fixes bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884934
System log entries when this bug occurs:
kernel: xauth[16729]: segfault at 1 ip 00007f51f517f5a5 sp 00007ffdec846568 error 4
in libc-2.31.so[7f51f5102000+144000]
kernel: Code: bc d1 f3 0f 7f 27 f3 0f 7f 6f 10 f3 0f 7f 77 20 f3 0f 7f 7f 30 49 83 c0
0f 49 29 d0 48 8d 7c 17 31 e9 8f 0b 00 00 66 0f ef c0 <f3> 0f 6f 0e f3
0f 6f 56 10 66 0f 74 c1 66 0f d7 d0 49 83 f8 11 0f
This bug happens when function get_address_info() in gethost.c is called
with a display name without forward slash, for example 'myhost.mydomain:0'
Diffstat (limited to 'process.c')
| -rw-r--r-- | process.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -1644,6 +1644,7 @@ do_add(const char *inputfilename, int lineno, int argc, const char **argv) return 1; } strncpy(key, hexkey+1, len-2); + key[len-1] = '\0'; len -= 2; } else if (!strcmp(protoname, SECURERPC) || !strcmp(protoname, K5AUTH)) { @@ -1961,6 +1962,7 @@ do_generate(const char *inputfilename, int lineno, int argc, const char **argv) goto exit_generate; } strncpy(authdata, hexdata+1, authdatalen-2); + authdata[authdatalen-1] = '\0'; authdatalen -= 2; } else { authdatalen = cvthexkey (hexdata, &authdata); |