summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOLHEADmasterAlan Coopersmith2023-03-041-1/+2
| | | | | | | | | | | | | | | | | AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008, so it's time to rely on it. Clears autoconf warnings: configure.ac:13: warning: The macro `AC_PROG_LIBTOOL' is obsolete. configure.ac:13: You should run autoupdate. aclocal.m4:3640: AC_PROG_LIBTOOL is expanded from... configure.ac:13: the top level libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, libtoolize: and rerunning libtoolize and aclocal. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Remove "All rights reserved" from Oracle copyright noticesAlan Coopersmith2023-02-252-2/+2
| | | | | | Oracle no longer includes this term in our copyright & license notices. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* libSM 1.2.4libSM-1.2.4Alan Coopersmith2022-12-191-2/+2
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Handle arrays too large to fit in iceConn buffersAlan Coopersmith2022-12-044-20/+68
| | | | | | | | | | | | | | | | | | | Fixes numerous gcc warnings of the form: sm_client.c: In function ‘SmcOpenConnection’: SMlibint.h:109:25: warning: potential null pointer dereference [-Wnull-dereference] *((CARD32 *) _pBuf) = _val; \ SMlibint.h:160:5: note: in expansion of macro ‘STORE_CARD32’ STORE_CARD32 (_pBuf, (CARD32) _len); \ ^~~~~~~~~~~~ sm_client.c:207:5: note: in expansion of macro ‘STORE_ARRAY8’ STORE_ARRAY8 (pData, len, previousId); ^~~~~~~~~~~~ v2: Raise required libICE version to 1.1.0 to get the updated IceGetHeaderExtra macro definition needed for this to work correctly. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* gitlab CI: build current libICE, to meet dependency on >= 1.1.0Alan Coopersmith2022-12-041-2/+27
| | | | | | | Allow us to pass CI without waiting for Debian to pick up yesterday's release of libICE 1.1.0. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith2022-12-041-2/+2
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* SmcCloseConnection: remove unnecessary cast from free()Alan Coopersmith2022-12-041-1/+1
| | | | | | | commit b17f93a1d041e63261ff followed the style of the time it was written, before commit e77dd2e4bc8227 had removed them. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Fix some potential memory leaks in SmcCloseConnection().Kim Woelders2022-08-261-0/+16
| | | | | Signed-off-by: Kim Woelders <kim@woelders.dk> Reviewed-by: Corbin Simpson <MostAwesomeDude@gmail.com>
* Add uuid as private dependency to sm.pc for static linkingAlan Coopersmith2022-03-052-2/+15
| | | | | | | | | If a uuid.pc file was found, add it to Requires.private. Otherwise, add $LIBUUID_LIBS to Libs.private. Fixes: #1 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* gitlab CI: add a basic build testAlan Coopersmith2022-03-051-0/+99
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Build xz tarballs instead of bzip2Alan Coopersmith2022-03-051-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Fix spelling/wording issuesAlan Coopersmith2022-03-053-3/+3
| | | | | | | Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Update configure.ac bug URL for gitlab migrationAlan Coopersmith2018-12-071-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Update README for gitlab migrationAlan Coopersmith2018-11-193-25/+20
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Remove obsolete B16 & B32 tags in struct definitionsAlan Coopersmith2018-11-101-18/+18
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* libSM 1.2.3libSM-1.2.3Matthieu Herrb2018-09-301-1/+1
| | | | Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
* Fixed out ouf boundary accesses.Tobias Stoeckmann2018-09-302-163/+229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Out of boundary accesses can occur while processing messages. This affects clients and the session server. Generally, the code tries to prevent out of boundary accesses. It initially "skips" over the memory areas by parsing supplied lengths. Then, it checks if it skipped over the memory boundary. If not, then data is actually read and memory allocated, etc. The problem is that while initially skipping over the memory, subsequent lengths are already parsed, i.e. accessed. This results in out of boundary reads on hostile messages. Lengths could also overflow on 32 bit systems, leading to out of boundary writes if not enough bytes have been allocated. Authentication is handled by libICE, which is not affected, because the macros for skipping already take care about memory boundaries. Therefore, this flaw can only be used by authenticated clients or by hostile servers (which could simply accept every MIT cookie). Most session managers only use Unix sockets, so in many cases it takes a local authenticated user. In order to fix this, I decided to move the macros from SMlibint.h to its only callers in sm_process.c, turning them into functions for much easier error handling and readability. Instead of skipping over the memory, validation happens during actual read and memory allocation operations, as it's rather unlikely to encounter hostile code anyway, i.e. my code has more error cleanup handling in it. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
* Fix callbacks signatures in libSM documentationFab2018-03-231-2/+2
| | | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=103135 Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* autogen: add default patch prefixMihail Konev2017-01-261-0/+3
| | | | Signed-off-by: Mihail Konev <k.mvc@ya.ru>
* autogen.sh: use quoted string variablesEmil Velikov2017-01-261-4/+4
| | | | | | | | | Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer2017-01-261-1/+1
| | | | | | | Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
* Get rid of strcpy() in the HAVE_UUID_CREATE caseMatthieu Herrb2015-10-201-5/+4
| | | | | | | Even though this use was safe, some linkers produce a warning when strcpy() is used, and this is the only use in libSM. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Fix uuid_to_string(3) typeMatthieu Herrb2015-10-201-1/+1
| | | | | | It should be char *. Reviewed-by: Adam Jackson <ajax@redhat.com>
* Include unistd.h for getpid()Jon TURNEY2015-04-101-0/+1
| | | | | Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk> Reviewed-by: David Macek <david.macek.0@gmail.com>
* Stop compiling empty sm_auth.c stubAlan Coopersmith2013-11-221-1/+2
| | | | | | | | | | File exists as a placeholder in case someone someday decides to add additional auth methods on top of what libICE provides, but it's been two decades and no one has, so stop spending time compiling & linking for now. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Adam Jackson <ajax@redhat.com>
* libSM 1.2.2libSM-1.2.2Alan Coopersmith2013-09-071-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Fix some clang warnings about integer size/sign conversionsAlan Coopersmith2013-08-096-16/+16
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* unifdef WORD64 (leftover bits of Cray support)Alan Coopersmith2013-08-091-46/+0
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Constify previous_id argument to SmcOpenConnectionAlan Coopersmith2013-08-092-2/+2
| | | | | | | | | Clears gcc warning of: sm_client.c: In function 'SmcOpenConnection': sm_client.c:199:13: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* autogen.sh: Implement GNOME Build APIbaserock/morphColin Walters2013-01-151-1/+3
| | | | | | http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Adam Jackson <ajax@redhat.com>
* configure: Remove AM_MAINTAINER_MODEAdam Jackson2013-01-151-1/+0
| | | | Signed-off-by: Adam Jackson <ajax@redhat.com>
* unifdef -U__UNIXOS2__Alan Coopersmith2013-01-042-9/+0
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Remove unused TLI ("STREAMSCONN") code from libSMAlan Coopersmith2012-12-261-2/+2
| | | | | | | | | Has never been converted to build in modular builds, so has been unusable since X11R7.0 release in 2005. All known platforms with TLI/XTI support that X11R7 & later releases run on also have (and mostly prefer) BSD socket support for their networking API. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* libSM 1.2.1libSM-1.2.1Alan Coopersmith2012-03-021-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* informaltable cleanupMatt Dew2012-01-112-550/+772
| | | | | | | | | | | | | | | | On certain tables, add top and bottom borders to table header and a bottom border to the table. This matches what those tables in the old pdfs looked like. the <?dbfo keep-together='always'> prevents tables from splitting across pages. Useful for tiny tables. Converting the colwidth to a floating point, IE, 1* -> 1.0* cleans up these build errors: WARNING: table-layout="fixed" and column-width unspecified => falling back to proportional-column-width(1) Signed-off-by: Matt Dew <marcoz@osource.org>
* unifdef -ULynxAlan Coopersmith2011-12-091-5/+1
| | | | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: James Cloos <cloos@jhcloos.com>
* SmsInitialize: Mark vendor & release args as const char *Alan Coopersmith2011-12-093-5/+6
| | | | | | | Needed to fix gcc -Wwrite-strings arguments in callers such as xsm. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Remove a bunch of unnecessary casts with malloc & free callsAlan Coopersmith2011-12-095-28/+25
| | | | | | | | | With modern compilers and headers, they cause more problems than they solve and just hide real issues. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Replace malloc(strlen) + strcpy sets with strdup callsAlan Coopersmith2011-12-094-33/+9
| | | | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Reindent IPv4 code to match IPv6 codeAlan Coopersmith2011-12-091-27/+27
| | | | | | | Takes care of the other block of code confusingly sharing indent levels Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Move variable declarations to get rid of unnecessary scope bracketsAlan Coopersmith2011-12-091-6/+6
| | | | | | | | Gets rid of one of the multiple levels of bracketing that confusingly shared the same indent level. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Move and rename temp[4] definition to reduce confusion with temp[256]Alan Coopersmith2011-12-091-5/+7
| | | | | | | | | | | Both variables were locals in different scope levels of the same function, leading to both confusing code and gcc -Wshadow warnings: sm_genid.c: In function 'SmsGenerateClientID': sm_genid.c:160:10: warning: declaration of 'temp' shadows a previous local Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Use imdent to make multiple levels of nested #if easier to followAlan Coopersmith2011-12-091-36/+36
| | | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: James Cloos <cloos@jhcloos.com>
* Cleanup IDs and links in docMatt Dew2011-10-042-295/+296
| | | | | | | | | | 1 - fix the capitalization of the ID attributes to match either the <title> or <funcdef> string it goes with. 2 - fix any <linkend>'s that were affected by 1. 3 - any <function> in the docs that has an actual funcdef, will become an olink. Signed-off-by: Matt Dew <marcoz@osource.org>
* Strip trailing whitespaceAlan Coopersmith2011-09-166-21/+21
| | | | | | | Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* docs: fix author affiliationGaetan Nadon2011-09-142-5/+3
| | | | Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
* docs: use the &fullrelvers; entity to set X11 release informationGaetan Nadon2011-09-122-4/+10
| | | | Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
* docs: remove <productnumber> which is not used by defaultGaetan Nadon2011-09-112-2/+0
| | | | | | | | This element is not rendered by default on the title. A template customization is required to display it. X Window System does not have a product number. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
* docbook.am: embed css styles inside the HTML HEAD elementGaetan Nadon2011-09-081-2/+0
| | | | | | | | | | | | Rather than referring to the external xorg.css stylesheet, embed the content of the file in the html output produced. This is accomplished by using version 1.10 of xorg-xhtml.xsl. This makes the whole html docs tree much more relocatable. In addition, it eliminates xorg.css as a runtime file which makes xorg-sgml-doctools a build time only package. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
* docbook.am: global maintenance update - entities, images and olinkingGaetan Nadon2011-09-071-52/+62
| | | | | | | | | | | | | Adding support in libX11 for html chunking caused a reorg of docbook.am as well as the xorg-sgml-doctools masterdb for olinking. The parameter img.src.path is added for pdf images. A searchpath to the root builddir is added for local entities, if present. The docbook.am makefile hides all the details and is identical for all 22 modules having DocBook documentation. It is included by a thin Makefile.am which requires no docbook knowledge. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
View Lorry Controller Status