summaryrefslogtreecommitdiff
path: root/src/XEVI.c
Commit message (Collapse)AuthorAgeFilesLines
* Convert calls to Xmalloc arrays to use Xmallocarray insteadAlan Coopersmith2022-06-111-1/+2
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Use calloc instead of malloc if we may not initialize all the bytesAlan Coopersmith2022-06-101-2/+2
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Remove unnecessary casts of malloc/calloc resultsAlan Coopersmith2022-06-101-2/+2
| | | | | | | These aren't needed in C89 and later, but can hide missing prototypes that generate broken code on platforms where pointers are larger than ints. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* XeviGetVisualInfo: Free & clear *evi_return, not evi_return pointerAlan Coopersmith2014-03-081-2/+4
| | | | | | | | | | | | | | | | evi_return is passed in as a pointer to a location into which XeviGetVisualInfo is expected to write a pointer to the memory it allocated for the returned structures. If we're failing and bailing out, we need to dispose of the pointer we set, not the one passed into us (which the caller may have put on the stack or allocated as part of a larger structure). Flagged by cppcheck 1.64: [lib/libXext/src/XEVI.c:182] -> [lib/libXext/src/XEVI.c:186]: (warning) Possible null pointer dereference: evi_return - otherwise it is redundant to check it against null. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Remove fallback for _XEatDataWords, require libX11 1.6 for itAlan Coopersmith2013-11-071-1/+0
| | | | | | | | | | | | _XEatDataWords was orignally introduced with the May 2013 security patches, and in order to ease the process of delivering those, fallback versions of _XEatDataWords were included in the X extension library patches so they could be applied to older versions that didn't have libX11 1.6 yet. Now that we're past that hurdle, we can drop the fallbacks and just require libX11 1.6 for building new versions of the extension libraries. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* integer overflow in XeviGetVisualInfo() [CVE-2013-1982 4/6]Alan Coopersmith2013-04-261-7/+18
| | | | | | | | | | If the number of visuals or conflicts reported by the server is large enough that it overflows when multiplied by the size of the appropriate struct, then memory corruption can occur when more bytes are read from the X server than the size of the buffer we allocated to hold them. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Use _XEatDataWords to avoid overflow of rep.length bit shiftingAlan Coopersmith2013-04-131-1/+3
| | | | | | rep.length is a CARD32, so rep.length << 2 could overflow in 32-bit builds Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Add const attributes to fix gcc -Wwrite-strings warningsAlan Coopersmith2011-10-141-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Purge cvs tags.Jesse Adkins2010-10-061-2/+0
| | | | | Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Purge macros NEED_EVENTS and NEED_REPLIESFernando Carrijo2010-07-071-2/+1
| | | | | | Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br> Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Move libXext library headers from xextproto to libXext.Peter Hutterer2009-07-151-1/+1
| | | | | | | | | | All library headers (or parts thereof) from xextproto are moved to include/X11/extensions/. Including build fixes to include and build with the new header locations and names. Requires xextproto 7.0.99.1 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* XeviGetVisualInfo: check for null pointer before writing to it, not afterAlan Coopersmith2007-11-281-1/+4
|
* Coverity #929: Additional defensive NULL check.XORG-7_0_99_901Adam Jackson2006-04-031-1/+1
|
* - Link Xext to /lib/Xext/src rather than /lib/XextXORG-6_8_99_9XORG-6_8_99_8XORG-6_8_99_13XORG-6_8_99_12XORG-6_8_99_11XORG-6_8_99_10Søren Sandmann Pedersen2005-05-181-0/+3
| | | | | - Conditionally include config.h in Xext source - Remove unnecessary include of ImUtil.h from XShm.c
* Bug #1434: Convert lib/Xext to ANSI function prototypes (Jeff Muizelaar).Adam Jackson2004-09-241-11/+8
|
* Merging XORG-CURRENT into trunkrel-0-6-1lg3d-rel-0-7-0lg3d-rel-0-6-2lg3d-baseXORG-6_8_2XORG-6_8_1_904XORG-6_8_1_903XORG-6_8_1_902XORG-6_8_1_901XORG-6_8_1XORG-6_8_0XORG-6_7_99_904XORG-6_7_99_903XORG-6_7_99_902XORG-6_7_99_901XORG-6_7_99_2XORG-6_7_99_1XACE-SELINUX-MERGElg3d-masterlg3d-eventlg3d-dev-0-7-1lg3d-dev-0-7-0lg3d-dev-0-6-latestlg3d-dev-0-6-2lg3d-dev-0-6-1-latestlg3d-dev-0-6-1-currentlg3d-dev-0-6-1-1lg3d-dev-0-6-1lg3dXORG-6_8-branchCOMPOSITEWRAPEgbert Eich2004-04-231-1/+1
|
* Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004xf86-4_4_99_1Egbert Eich2004-03-141-1/+1
|
* Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004xf86-4_4_0STSF-CURRENTEgbert Eich2004-03-031-1/+1
|
* readding XFree86's cvs IDsxf86-4_3_99_903Egbert Eich2004-02-261-1/+1
|
* Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004Egbert Eich2004-02-261-1/+1
|
* XFree86 4.3.0.1xf86-4_3_0_1PRE_xf86-4_3_0_1Kaleb Keithley2003-11-141-5/+6
|
* R6.6 is the Xorg base-lineXORG-MAINXORG-STABLEKaleb Keithley2003-11-141-0/+212