summaryrefslogtreecommitdiff
path: root/src/Selection.c
Commit message (Collapse)AuthorAgeFilesLines
* Replace XtMalloc() calls with XtMallocArray()Alan Coopersmith2023-03-071-12/+11
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Replace XtRealloc() calls with XtReallocArray()Alan Coopersmith2023-03-071-15/+9
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Remove "All rights reserved" from Oracle copyright noticesAlan Coopersmith2023-02-251-1/+1
| | | | | | Oracle no longer includes this term in our copyright & license notices. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Use memcpy() instead of memmove() when buffers are known not to overlapAlan Coopersmith2022-08-111-14/+14
| | | | | | | Most of these came from a mass bcopy() -> memmove() substitution in 1993 with a commit comment of "ANSIfication". Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* cppcheck fixes (const, null dereferencing, uninitialized, scope)Thomas E. Dickey2022-06-181-0/+4
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* cppcheck and clang --analyze fixesThomas E. Dickey2022-06-181-1/+1
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* codespell-fixesThomas E. Dickey2022-06-141-1/+1
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* improved the script used for typedef-options with indent, updated indentationThomas E. Dickey2019-08-011-34/+31
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* indent'd like "x-indent.sh", but with a more complete set of typedefs - seeThomas E. Dickey2019-07-141-1522/+1601
| | | | | | https://github.com/ThomasDickey/cindent-snapshots/blob/master/scripts/xxx-profile Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* use _X_UNUSED to quiet compiler warningsThomas E. Dickey2019-07-071-12/+12
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* build- and compiler-warning fixes when XTTRACEMEMORY is definedThomas E. Dickey2019-05-291-3/+3
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* fixes cppcheck "style" warnings (mostly variable-scope)Thomas E. Dickey2019-05-181-24/+28
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* fixes for gcc warnings, no object-changeThomas E. Dickey2019-05-061-2/+3
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* fix gcc warnings when assigning into a bit-field by first masking the valueThomas E. Dickey2019-05-061-1/+1
| | | | Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* eliminate casts of NULL for String* and Cardinal*, since those are unnecessaryThomas E. Dickey2019-04-151-2/+2
| | | | | | as well as interfere with proposed const-string changes. Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* This cleans up the "easy" warning fixes which can be made using myThomas E. Dickey2019-04-061-50/+50
| | | | | | | | | | | | | | | Regress script, comparing object-files before/after the edits: https://invisible-island.net/ansification/index.html https://invisible-island.net/scripts/readme.html The changes are casts, which quiet the gcc warnings about implicit conversion that my "gcc-normal" script would show. I avoided reformatting the code. The change reduces the number of gcc warnings from 769 to 163. Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
* resolv:shadows a previous localWalter Harms2019-01-081-2/+1
|
* Revert "Avoid shadowing variables."Alan Coopersmith2013-07-101-0/+1
| | | | | This reverts commit 3919044bd7d3bcb85ce3425a43b8889a248a7542. Breaks programs such as xcalc & xlogo on multiple platforms.
* Avoid shadowing variables.Thomas Klausner2013-07-091-1/+0
| | | | | Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Unchecked return values of XGetWindowProperty [CVE-2013-2005]Alan Coopersmith2013-04-261-37/+47
| | | | | | | | | | | Multiple functions in Selection.c assumed that XGetWindowProperty() would always set the pointer to the property, but before libX11 1.6, it could fail to do so in some cases, leading to libXt freeing or operating on an uninitialized pointer value, so libXt should always initialize the pointers and check for failure itself. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Bug 40577 - Missing bound checking in FreeSelectionProperty()Olivier Fourdan2011-10-031-1/+4
| | | | | | | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=40577 FreeSelectionProperty() did not check for the count of items in array and relied on a NULL terminated list, which can cause libXt to crash if FreeSelectionProperty() follows a call to GetSelectionProperty() which reallocates the array. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Convert some sprintf calls to snprintfAlan Coopersmith2010-12-221-1/+1
| | | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Julien Cristau <jcristau@debian.org>
* Purge cvs tags.Jesse Adkins2010-10-061-3/+0
| | | | | Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Sun's copyrights belong to Oracle nowAlan Coopersmith2010-09-231-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Bug 1478: Selection.c damages user error handler functionRyan Hajdaj2010-09-231-2/+3
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=1478 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Update Sun license notices to current X.Org standard formAlan Coopersmith2010-01-141-12/+23
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
* Janitor: ansification, make distcheck, compiler warnings, .gitignore.Paulo Cesar Pereira de Andrade2009-01-301-9/+9
| | | | | | Most "compiler" warnings were actually sparse warnings, due to assigning a integer to a pointer, or an external symbol without a previous declaration.
* - conditionally include config.h in xc/lib/Xt sourcesXORG-6_8_99_8Søren Sandmann Pedersen2005-05-181-0/+3
| | | | - add build system for lib/Xt
* Convert lib/Xt to ANSI C (Thomas Dickey). Fixes for a few valgrind warningsXORG-6_8_99_3XORG-6_8_99_2XORG-6_8_99_1Matthieu Herrb2005-02-211-443/+430
| | | | (Thomas Dickey).
* Merging XORG-CURRENT into trunkXACE-SELINUX-MERGECOMPOSITEWRAPEgbert Eich2004-04-231-1/+1
|
* Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004xf86-4_4_99_1Egbert Eich2004-03-141-1/+1
|
* Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004xf86-4_4_0STSF-CURRENTEgbert Eich2004-03-031-1/+1
|
* readding XFree86's cvs IDsxf86-4_3_99_903Egbert Eich2004-02-261-1/+1
|
* Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004Egbert Eich2004-02-261-1/+1
|
* XFree86 4.3.99.16 Bring the tree up to date for the Cygwin folksxf86-4_3_99_902xf86-4_3_99_901xf86-4_3_99_16Kaleb Keithley2003-11-251-6/+2
|
* XFree86 4.3.0.1xf86-4_3_0_1PRE_xf86-4_3_0_1Kaleb Keithley2003-11-141-1/+4
|
* R6.6 is the Xorg base-lineXORG-MAINKaleb Keithley2003-11-141-0/+2306
View Lorry Controller Status