diff options
author | Ray Strode <rstrode@redhat.com> | 2018-11-16 14:36:55 -0500 |
---|---|---|
committer | Adam Jackson <ajax@nwnk.net> | 2018-11-19 19:37:10 +0000 |
commit | 8738ce85df535bdfdfecfce1c0d64e209cc6e508 (patch) | |
tree | 1758a02e75062cf3a3dd441db51046e5dcba596c | |
parent | 364d64981549544213e2bca8de6ff8a5b2b5a69e (diff) | |
download | xserver-xephyr-crash.tar.gz |
dix: ensure work queues are cleared on resetxephyr-crash
If the server resets, most client workqueues are cleaned up as the
clients are killed.
The one exception is the server's client, which is exempt from
the killing spree.
If that client has a queued work procedure active, it won't get
cleared on reset.
This commit ensures it gets cleared too.
-rw-r--r-- | dix/dixutils.c | 13 | ||||
-rw-r--r-- | dix/main.c | 2 | ||||
-rw-r--r-- | include/dix.h | 2 |
3 files changed, 17 insertions, 0 deletions
diff --git a/dix/dixutils.c b/dix/dixutils.c index 540023cbd..2983174a1 100644 --- a/dix/dixutils.c +++ b/dix/dixutils.c @@ -508,6 +508,19 @@ WorkQueuePtr workQueue; static WorkQueuePtr *workQueueLast = &workQueue; void +ClearWorkQueue(void) +{ + WorkQueuePtr q, *p; + + p = &workQueue; + while ((q = *p)) { + *p = q->next; + free(q); + } + workQueueLast = p; +} + +void ProcessWorkQueue(void) { WorkQueuePtr q, *p; diff --git a/dix/main.c b/dix/main.c index 273f30330..16a7d6d39 100644 --- a/dix/main.c +++ b/dix/main.c @@ -340,6 +340,8 @@ dix_main(int argc, char *argv[], char *envp[]) DeleteCallbackManager(); + ClearWorkQueue(); + if (dispatchException & DE_TERMINATE) { CloseWellKnownConnections(); } diff --git a/include/dix.h b/include/dix.h index cf263a1f5..f2516187f 100644 --- a/include/dix.h +++ b/include/dix.h @@ -240,6 +240,8 @@ extern _X_EXPORT void RemoveBlockAndWakeupHandlers(ServerBlockHandlerProcPtr blo extern _X_EXPORT void InitBlockAndWakeupHandlers(void); +extern _X_EXPORT void ClearWorkQueue(void); + extern _X_EXPORT void ProcessWorkQueue(void); extern _X_EXPORT void ProcessWorkQueueZombies(void); |