diff options
| author | Enrico Olivelli <eolivelli@apache.org> | 2019-05-08 17:51:13 +0200 |
|---|---|---|
| committer | Andor Molnar <andor@apache.org> | 2019-05-08 17:51:13 +0200 |
| commit | cb36d5a95fca6bc098890bde517ba76901adf43a (patch) | |
| tree | cac490e94617a08042ff55712f831215279ff69e /zookeeper-client | |
| parent | c67760523492b8da033c7bc0ea3076ab4acf1a93 (diff) | |
| download | zookeeper-cb36d5a95fca6bc098890bde517ba76901adf43a.tar.gz | |
ZOOKEEPER-3362: Create a simple checkstyle file
Create a basic checkstyle file, in order to cover the minimal check on author tags.
This is needed in order to drop old ANT based precommit job (see ZOOKEEPER-3351)
We will not remove legacy checkstyle configuration file in zookeeper-server/src/test/resources/checkstyle.xml because it is referred by ANT build.xml files (even if we are not actually using that target).
This task won't add a complete checkstyle configuration with usual checks because it would imply almost a change at every .java in the codebase.
Author: Enrico Olivelli <eolivelli@apache.org>
Reviewers: andor@apache.org
Closes #909 from eolivelli/fix/checkstyle and squashes the following commits:
fdda1571c [Enrico Olivelli] use a property in order to define checkstyle version
92192981f [Enrico Olivelli] Skip CPP tests when using -DskipTests
b816e563e [Enrico Olivelli] Add cppunit for Travis
faf37bb37 [Enrico Olivelli] ZOOKEEPER-3362 Create a simple checkstyle file
Diffstat (limited to 'zookeeper-client')
| -rwxr-xr-x | zookeeper-client/zookeeper-client-c/pom.xml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/zookeeper-client/zookeeper-client-c/pom.xml b/zookeeper-client/zookeeper-client-c/pom.xml index 81a1787be..82948105d 100755 --- a/zookeeper-client/zookeeper-client-c/pom.xml +++ b/zookeeper-client/zookeeper-client-c/pom.xml @@ -55,6 +55,8 @@ <id>test-cppunit</id> <phase>test</phase> <configuration> + <!-- do not run cpp tests if tests are globally skipped --> + <skip>${skipTests}</skip> <tasks> <exec dir="${basedir}/target/c" executable="make" failonerror="true"> <env key="LD_LIBRARY_PATH" value="${env.LD_LIBRARY_PATH};/usr/lib" /> |