diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /board/mchpevb1 | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'board/mchpevb1')
| -rw-r--r-- | board/mchpevb1/board.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/mchpevb1/board.c b/board/mchpevb1/board.c index eeeb557b96..79226d7d71 100644 --- a/board/mchpevb1/board.c +++ b/board/mchpevb1/board.c @@ -880,10 +880,10 @@ static void ds1624_update(void) DS1624_READ_TEMP16, &temp); d = (temp & 0x7FFF) >> 8; - if ((uint32_t)temp & (1 << 7)) + if ((uint32_t)temp & BIT(7)) d++; - if ((uint32_t)temp & (1 << 15)) + if ((uint32_t)temp & BIT(15)) d |= (1u << 31); ds1624_temp = (int32_t)d; |