summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJay Doane <jaydoane@apache.org>2020-02-20 22:06:43 -0800
committerJay Doane <jaydoane@apache.org>2020-02-20 22:06:43 -0800
commit2ccde31ef9adfd02ef7c2f303a62bb6ab0a1cc9d (patch)
tree34864138a3485e488cdcc91cbe020ccad0d43861
parent6d1a7dacf4ff3bc5665f0ad1a831b88474f0dd6a (diff)
downloadcouchdb-improve-validate-dbname-test.tar.gz
Improve validate_dbname testimprove-validate-dbname-test
It's possible for other couch_epi plugins to interfere with this test, so mock `couch_epi:decide/5` to always return `no_decision`.
-rw-r--r--src/fabric/test/fabric2_db_misc_tests.erl10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/fabric/test/fabric2_db_misc_tests.erl b/src/fabric/test/fabric2_db_misc_tests.erl
index c48ee2c73..42a63e2f9 100644
--- a/src/fabric/test/fabric2_db_misc_tests.erl
+++ b/src/fabric/test/fabric2_db_misc_tests.erl
@@ -141,7 +141,15 @@ validate_dbname(_) ->
Expect = {error, {Reason, DbName}},
?assertEqual(Expect, fabric2_db:validate_dbname(DbName))
end,
- lists:foreach(CheckFun, Tests).
+ try
+ % Don't allow epi plugins to interfere with test results
+ meck:new(couch_epi, [passthrough]),
+ meck:expect(couch_epi, decide, 5, no_decision),
+ lists:foreach(CheckFun, Tests)
+ after
+ % Unload within the test to minimize interference with other tests
+ meck:unload()
+ end.
validate_doc_ids(_) ->