summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Berg <bberg@redhat.com>2020-08-21 12:15:47 +0200
committerIgnacio Casal Quinteiro <qignacio@amazon.com>2020-10-29 17:47:55 +0100
commit84b4f871e3d8276a102285ac83d21ef11256d6c3 (patch)
treed2e8f46673c2a9ec17cac0dc2af3065543bb3ccf
parentb7bbd224b0aef9d6c75c876153fdf778b5346fd9 (diff)
downloadgdm-wip/nacho/crash-backport.tar.gz
manager: Always write out parameterwip/nacho/crash-backport
The get_display_and_details_for_bus_sender function does not return a proper error value. Due to this, it makes sense to always write the out parameters (though, I expect we have still more that we might need to write). This is just slightly safer, but the function probably isn't great as is.
-rw-r--r--daemon/gdm-manager.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/daemon/gdm-manager.c b/daemon/gdm-manager.c
index e1bc09b1..012be49d 100644
--- a/daemon/gdm-manager.c
+++ b/daemon/gdm-manager.c
@@ -576,10 +576,11 @@ get_display_and_details_for_bus_sender (GdmManager *self,
lookup_by_session_id,
(gpointer) session_id);
+out:
if (out_display != NULL) {
*out_display = display;
}
-out:
+
g_free (session_id);
}