diff options
| author | Andrew Newdigate <andrew@gitlab.com> | 2019-03-05 14:47:23 +0200 |
|---|---|---|
| committer | Andrew Newdigate <andrew@gitlab.com> | 2019-03-05 14:47:23 +0200 |
| commit | 4392b57e227cb724f6623e9f9b9c2d4451d2774d (patch) | |
| tree | ffa77ba6486448ba8411863f9290bc5a82814919 | |
| parent | cb64d81b9e85aba5d1a29000c12722fa79e654a7 (diff) | |
| download | gitlab-ce-58500-document-.tar.gz | |
Add more documentation around how polling works58500-document-
| -rw-r--r-- | doc/development/polling.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/development/polling.md b/doc/development/polling.md index 76bb5ae7819..f6db6889ecc 100644 --- a/doc/development/polling.md +++ b/doc/development/polling.md @@ -1,5 +1,9 @@ # Polling with ETag caching +TODO: we should probably document the side-effect that sharing etags per path, not on the full URL means that invalidating the path will intentionally invalidate all query strings for that path. +TODO: Yes, and we should also note that the content itself will still be different - we only use the path for computing the ETag, not for the body (when there is a cache miss). +TODO: See https://gitlab.com/gitlab-org/gitlab-ce/issues/58500 + Polling for changes (repeatedly asking server if there are any new changes) introduces high load on a GitLab instance, because it usually requires executing at least a few SQL queries. This makes scaling large GitLab |