diff options
author | Jan Provaznik <jprovaznik@gitlab.com> | 2018-04-18 12:29:11 +0200 |
---|---|---|
committer | Jan Provaznik <jprovaznik@gitlab.com> | 2018-04-18 12:29:11 +0200 |
commit | f10327de8a0c0039e28c296807d84bda69a3e284 (patch) | |
tree | 5d07869f48f4775054f93ec96c7c83a5c6cea4bc | |
parent | 99e606ab019fa28cbfcb480a872b4ea9e8fcb1d9 (diff) | |
download | gitlab-ce-jprovazn-label-links.tar.gz |
Added a comment about extra query for label idsjprovazn-label-links
-rw-r--r-- | app/services/labels/transfer_service.rb | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/app/services/labels/transfer_service.rb b/app/services/labels/transfer_service.rb index 31f41fc75ec..9b7486cf53b 100644 --- a/app/services/labels/transfer_service.rb +++ b/app/services/labels/transfer_service.rb @@ -65,7 +65,10 @@ module Labels def update_label_links(labels, old_label_id:, new_label_id:) # use 'labels' relation to get label_link ids only of issues/MRs - # in the project being transferred + # in the project being transferred. + # IDs are fetched in a separate query because MySQL doesn't + # allow referring of 'label_links' table in UPDATE query: + # https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/62435068 link_ids = labels.pluck('label_links.id') LabelLink.where(id: link_ids, label_id: old_label_id) |