diff options
| author | Lukas 'Eipi' Eipert <leipert@gitlab.com> | 2019-02-12 11:00:18 +0000 |
|---|---|---|
| committer | Lukas 'Eipi' Eipert <leipert@gitlab.com> | 2019-02-12 11:00:18 +0000 |
| commit | 0e1701558e02c5459be4e565cbd6859fe9ffdee8 (patch) | |
| tree | 48864ac79f0f62ebed07310e259ed1edeba08651 | |
| parent | ef494f0e4f7a25aef27bd57fca6b3e4def79030b (diff) | |
| parent | 4086d1bfb81b6e2d0eefb3e66304d1a49952a990 (diff) | |
| download | gitlab-ce-leipert-add-typescript.tar.gz | |
Eliminate errors in .js filesleipert-add-typescript
See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24792
| -rwxr-xr-x | scripts/type-check.sh | 2 | ||||
| -rw-r--r-- | tsconfig.json | 2 | ||||
| -rw-r--r-- | vendor/assets/javascripts/u2f.js | 5 |
3 files changed, 1 insertions, 8 deletions
diff --git a/scripts/type-check.sh b/scripts/type-check.sh index b3217fef11b..0658a5b6b34 100755 --- a/scripts/type-check.sh +++ b/scripts/type-check.sh @@ -1,5 +1,3 @@ #!/usr/bin/env bash yarn run tsc -p . -echo "Current errors are:" -yarn run tsc -p . | cut -d":" -f2 | grep 'error' | sort | uniq -c | sort diff --git a/tsconfig.json b/tsconfig.json index 70b03b4f012..ae163c47bf6 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -24,7 +24,7 @@ // Compile JS files "allowJs": true, // Check JS files - "checkJs": true, + "checkJs": false, // Emit no files, we are just using it as a type checker "noEmit": true, // False for now to reduce amount of errors diff --git a/vendor/assets/javascripts/u2f.js b/vendor/assets/javascripts/u2f.js index a33e5e0ade9..88ca5e315da 100644 --- a/vendor/assets/javascripts/u2f.js +++ b/vendor/assets/javascripts/u2f.js @@ -91,16 +91,11 @@ u2f.U2fResponse; /** * An error object for responses - * @typedef {{ - * errorCode: u2f.ErrorCodes, - * errorMessage: ?string - * }} */ u2f.Error; /** * Data object for a single sign request. - * @typedef {enum {BLUETOOTH_RADIO, BLUETOOTH_LOW_ENERGY, USB, NFC}} */ u2f.Transport; |