diff options
Diffstat (limited to '.rubocop_todo/rails')
| -rw-r--r-- | .rubocop_todo/rails/active_record_callbacks_order.yml | 24 | ||||
| -rw-r--r-- | .rubocop_todo/rails/content_tag.yml | 9 | ||||
| -rw-r--r-- | .rubocop_todo/rails/file_path.yml | 4 | ||||
| -rw-r--r-- | .rubocop_todo/rails/helper_instance_variable.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/rails/http_status.yml | 9 | ||||
| -rw-r--r-- | .rubocop_todo/rails/index_with.yml | 53 | ||||
| -rw-r--r-- | .rubocop_todo/rails/inverse_of.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rails/negate_include.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/rails/pluck.yml | 220 | ||||
| -rw-r--r-- | .rubocop_todo/rails/redundant_foreign_key.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/rails/time_zone.yml | 230 |
11 files changed, 321 insertions, 235 deletions
diff --git a/.rubocop_todo/rails/active_record_callbacks_order.yml b/.rubocop_todo/rails/active_record_callbacks_order.yml deleted file mode 100644 index baeba86c4b9..00000000000 --- a/.rubocop_todo/rails/active_record_callbacks_order.yml +++ /dev/null @@ -1,24 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/ActiveRecordCallbacksOrder: - Exclude: - - 'app/models/award_emoji.rb' - - 'app/models/gpg_key.rb' - - 'app/models/group.rb' - - 'app/models/issue.rb' - - 'app/models/key.rb' - - 'app/models/merge_request.rb' - - 'app/models/namespace.rb' - - 'app/models/namespace_statistics.rb' - - 'app/models/note.rb' - - 'app/models/pages_domain.rb' - - 'app/models/personal_access_token.rb' - - 'app/models/project.rb' - - 'app/models/prometheus_alert.rb' - - 'app/models/remote_mirror.rb' - - 'app/models/resource_label_event.rb' - - 'app/models/snippet_statistics.rb' - - 'app/models/upload.rb' - - 'app/models/user.rb' - - 'ee/app/models/dast_site_profile.rb' - - 'ee/app/models/geo_node.rb' diff --git a/.rubocop_todo/rails/content_tag.yml b/.rubocop_todo/rails/content_tag.yml deleted file mode 100644 index d54bd97cc08..00000000000 --- a/.rubocop_todo/rails/content_tag.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Rails/ContentTag: - Details: grace period - Exclude: - - 'app/helpers/avatars_helper.rb' - - 'app/helpers/page_layout_helper.rb' - - 'lib/gitlab/middleware/go.rb' - - 'spec/helpers/avatars_helper_spec.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 898d303bd3d..0a652631e0b 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -21,9 +21,6 @@ Rails/FilePath: - 'db/post_migrate/20210630025020_migrate_push_event_payloads_event_id_back_to_integer_for_gitlab_com.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - - 'ee/db/fixtures/development/21_dast_profiles.rb' - - 'ee/db/fixtures/development/32_compliance_report_violations.rb' - 'ee/lib/ee/feature/definition.rb' - 'ee/lib/ee/gitlab/audit/type/definition.rb' - 'ee/lib/ee/gitlab/usage/metric_definition.rb' @@ -40,7 +37,6 @@ Rails/FilePath: - 'ee/spec/models/release_highlight_spec.rb' - 'ee/spec/requests/api/experiments_spec.rb' - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - - 'ee/spec/support/factory_bot.rb' - 'ee/spec/validators/json_schema_validator_spec.rb' - 'lib/api/api.rb' - 'lib/error_tracking/collector/payload_validator.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index 53e376730fd..164edaece4e 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -61,7 +61,6 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/form_helper.rb' - 'ee/app/helpers/ee/graph_helper.rb' - - 'ee/app/helpers/ee/groups/group_members_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/integrations_helper.rb' @@ -75,7 +74,6 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/projects/security/configuration_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/search_helper.rb' - - 'ee/app/helpers/ee/selects_helper.rb' - 'ee/app/helpers/ee/sorting_helper.rb' - 'ee/app/helpers/ee/subscribable_banner_helper.rb' - 'ee/app/helpers/ee/wiki_helper.rb' diff --git a/.rubocop_todo/rails/http_status.yml b/.rubocop_todo/rails/http_status.yml deleted file mode 100644 index 1a8ece49304..00000000000 --- a/.rubocop_todo/rails/http_status.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/HttpStatus: - Exclude: - - 'app/controllers/concerns/invisible_captcha_on_signup.rb' - - 'app/controllers/projects/runner_projects_controller.rb' - - 'app/controllers/projects/service_ping_controller.rb' - - 'app/controllers/repositories/lfs_storage_controller.rb' - - 'ee/app/controllers/trials_controller.rb' diff --git a/.rubocop_todo/rails/index_with.yml b/.rubocop_todo/rails/index_with.yml deleted file mode 100644 index b7bc2a26959..00000000000 --- a/.rubocop_todo/rails/index_with.yml +++ /dev/null @@ -1,53 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/IndexWith: - Exclude: - - 'app/helpers/ci/jobs_helper.rb' - - 'app/models/ci/build_trace_chunk.rb' - - 'app/models/ci/processable.rb' - - 'app/models/concerns/cached_commit.rb' - - 'app/models/customer_relations/organization.rb' - - 'app/models/environment.rb' - - 'app/services/concerns/rate_limited_service.rb' - - 'app/services/packages/rpm/parse_package_service.rb' - - 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb' - - 'ee/app/models/concerns/identity_verifiable.rb' - - 'ee/app/models/vulnerabilities/projects_grade.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - - 'ee/lib/gitlab/custom_file_templates.rb' - - 'ee/lib/gitlab/insights/reducers/count_per_label_reducer.rb' - - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'ee/spec/models/sca/license_compliance_spec.rb' - - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' - - 'lib/api/entities/project_integration.rb' - - 'lib/api/helpers/packages/conan/api_helpers.rb' - - 'lib/banzai/filter/repository_link_filter.rb' - - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/reports/security/finding.rb' - - 'lib/gitlab/ci/reports/security/identifier.rb' - - 'lib/gitlab/ci/reports/test_suite.rb' - - 'lib/gitlab/database/count/exact_count_strategy.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/obsolete_ignored_columns.rb' - - 'lib/gitlab/database/tables_sorted_by_foreign_keys.rb' - - 'lib/gitlab/issuable_metadata.rb' - - 'lib/gitlab/template/base_template.rb' - - 'lib/gitlab/usage_data.rb' - - 'lib/google_api/cloud_platform/client.rb' - - 'lib/tasks/gitlab/db.rake' - - 'qa/qa/resource/reusable.rb' - - 'scripts/trigger-build.rb' - - 'spec/lib/gitlab/api_authentication/sent_through_builder_spec.rb' - - 'spec/lib/gitlab/conflict/file_spec.rb' - - 'spec/lib/gitlab/import_export/model_configuration_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/google_api/cloud_platform/client_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - - 'spec/support/database/multiple_databases.rb' - - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - - 'spec/support/shared_examples/models/concerns/sanitizable_shared_examples.rb' - - 'spec/views/admin/dashboard/index.html.haml_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 2ad8d6204c8..a1f49aaf2f5 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -9,7 +9,6 @@ Rails/InverseOf: - 'app/models/board.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/bulk_imports/tracker.rb' - - 'app/models/ci/bridge.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_pending_state.rb' - 'app/models/ci/build_trace_chunk.rb' diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml index c3f9ac25e7e..74f469f325b 100644 --- a/.rubocop_todo/rails/negate_include.yml +++ b/.rubocop_todo/rails/negate_include.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/NegateInclude: Details: grace period Exclude: diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 5e875daa569..e094a3397a6 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -1,10 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/Pluck: - # Offense count: 155 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: + - 'app/controllers/ldap/omniauth_callbacks_controller.rb' - 'app/finders/merge_requests/oldest_per_commit_finder.rb' - 'app/helpers/issuables_description_templates_helper.rb' - 'app/models/ci/unit_test.rb' @@ -12,67 +11,184 @@ Rails/Pluck: - 'app/models/concerns/sensitive_serializable_hash.rb' - 'app/models/integrations/chat_message/pipeline_message.rb' - 'app/models/list.rb' + - 'app/models/packages/go/module_version.rb' + - 'app/models/work_items/parent_link.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb' - 'app/services/feature_flags/update_service.rb' + - 'app/services/todos/destroy/destroyed_issuable_service.rb' + - 'app/workers/database/ci_namespace_mirrors_consistency_check_worker.rb' + - 'app/workers/database/ci_project_mirrors_consistency_check_worker.rb' + - 'db/post_migrate/20210811122206_update_external_project_bots.rb' + - 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - 'ee/app/models/boards/epic_list.rb' + - 'ee/app/models/concerns/geo/verification_state.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' - - 'ee/app/workers/geo/container_repository_sync_dispatch_worker.rb' - 'ee/app/workers/geo/registry_sync_worker.rb' - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' + - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' + - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb' + - 'ee/lib/gitlab/search/index_curator.rb' + - 'ee/spec/controllers/autocomplete_controller_spec.rb' + - 'ee/spec/controllers/countries_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' + - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' + - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb' + - 'ee/spec/controllers/projects/licenses_controller_spec.rb' + - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' + - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/graphql/api/vulnerabilities_spec.rb' + - 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' + - 'ee/spec/helpers/ee/operations_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb' + - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/spdx/catalogue_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' + - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/dast_site_profile_spec.rb' - 'ee/spec/models/integrations/chat_message/vulnerability_message_spec.rb' + - 'ee/spec/models/release_highlight_spec.rb' + - 'ee/spec/requests/api/analytics/code_review_analytics_spec.rb' + - 'ee/spec/requests/api/epic_links_spec.rb' + - 'ee/spec/requests/api/epics_spec.rb' + - 'ee/spec/requests/api/graphql/boards/board_lists_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_boards_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_lists_query_spec.rb' + - 'ee/spec/requests/api/graphql/ci/runners_spec.rb' + - 'ee/spec/requests/api/graphql/epics/epic_resolver_spec.rb' + - 'ee/spec/requests/api/graphql/iterations/cadences_spec.rb' + - 'ee/spec/requests/api/graphql/iterations/iterations_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/analytics/devops_adoption/enabled_namespaces/bulk_enable_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_profiles_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_site_validations_spec.rb' + - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/code_quality_reports_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/issue_links_spec.rb' + - 'ee/spec/requests/api/groups_spec.rb' + - 'ee/spec/requests/api/iterations_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' + - 'ee/spec/requests/api/project_approval_rules_spec.rb' + - 'ee/spec/requests/api/project_approval_settings_spec.rb' + - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/protected_branches_spec.rb' + - 'ee/spec/requests/api/protected_environments_spec.rb' + - 'ee/spec/requests/api/protected_tags_spec.rb' + - 'ee/spec/requests/api/releases_spec.rb' + - 'ee/spec/requests/api/search_spec.rb' + - 'ee/spec/requests/api/status_checks_spec.rb' + - 'ee/spec/requests/api/users_spec.rb' + - 'ee/spec/requests/api/vulnerabilities_spec.rb' + - 'ee/spec/requests/api/vulnerability_findings_spec.rb' + - 'ee/spec/requests/api/vulnerability_issue_links_spec.rb' + - 'ee/spec/requests/ee/groups/autocomplete_sources_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' + - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/create_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' + - 'ee/spec/services/ee/releases/create_evidence_service_spec.rb' + - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' + - 'ee/spec/support/elastic.rb' + - 'ee/spec/support/helpers/feature_approval_helper.rb' + - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' + - 'ee/spec/support/shared_examples/requests/api/graphql/incident_management/escalation_policies_shared_examples.rb' + - 'lib/atlassian/jira_connect/client.rb' - 'lib/banzai/filter/references/label_reference_filter.rb' - 'lib/banzai/filter/references/milestone_reference_filter.rb' - 'lib/banzai/renderer.rb' - 'lib/gitlab/access.rb' - 'lib/gitlab/analytics/cycle_analytics/default_stages.rb' + - 'lib/gitlab/bullet/exclusions.rb' - 'lib/gitlab/checks/lfs_check.rb' - 'lib/gitlab/ci/pipeline/chain/build/associations.rb' - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' - 'lib/gitlab/ci/variables/collection/sort.rb' - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/cycle_analytics/updater.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb' - 'lib/gitlab/git_access.rb' + - 'lib/gitlab/github_import/representation/issue.rb' + - 'lib/gitlab/jira_import/metadata_collector.rb' + - 'lib/gitlab/merge_requests/message_generator.rb' - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - 'lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' + - 'lib/gitlab/sql/pattern.rb' - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - - 'qa/qa/specs/features/browser_ui/3_create/jira/jira_basic_integration_spec.rb' - - 'qa/qa/support/page_error_checker.rb' + - 'lib/gitlab/zentao/client.rb' + - 'lib/tasks/gitlab/info.rake' + - 'qa/qa/specs/features/api/1_manage/import/import_github_repo_spec.rb' + - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_mr_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' + - 'qa/qa/tools/ci/qa_changes.rb' + - 'qa/qa/tools/delete_projects.rb' + - 'qa/qa/tools/delete_test_snippets.rb' + - 'qa/qa/tools/delete_test_ssh_keys.rb' + - 'qa/qa/tools/delete_test_users.rb' + - 'qa/qa/tools/delete_user_projects.rb' - 'scripts/perf/query_limiting_report.rb' - 'spec/config/mail_room_spec.rb' - - 'spec/config/metrics/aggregates/aggregated_metrics_spec.rb' + - 'spec/controllers/autocomplete_controller_spec.rb' + - 'spec/controllers/dashboard/milestones_controller_spec.rb' + - 'spec/controllers/groups/labels_controller_spec.rb' + - 'spec/controllers/groups/milestones_controller_spec.rb' + - 'spec/controllers/groups/releases_controller_spec.rb' + - 'spec/controllers/groups/shared_projects_controller_spec.rb' + - 'spec/controllers/projects/analytics/cycle_analytics/stages_controller_spec.rb' + - 'spec/controllers/projects/autocomplete_sources_controller_spec.rb' + - 'spec/controllers/projects/environments_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' + - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' + - 'spec/controllers/projects/releases_controller_spec.rb' + - 'spec/controllers/projects/starrers_controller_spec.rb' + - 'spec/db/schema_spec.rb' + - 'spec/features/issues/csv_spec.rb' + - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' + - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' + - 'spec/graphql/resolvers/namespace_projects_resolver_spec.rb' + - 'spec/graphql/types/ci/job_token_scope_type_spec.rb' + - 'spec/graphql/types/snippet_type_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/pull_request_entity_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/projects/stage_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb' + - 'spec/lib/gitlab/database/similarity_score_spec.rb' + - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/conflict/parser_spec.rb' + - 'spec/lib/gitlab/import_export/group/legacy_tree_saver_spec.rb' + - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/language_detection_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' @@ -80,9 +196,11 @@ Rails/Pluck: - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/search/query_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_matcher_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/peek/views/rugged_spec.rb' - 'spec/migrations/20210713042000_fix_ci_sources_pipelines_index_names_spec.rb' + - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/pipeline_spec.rb' @@ -94,12 +212,98 @@ Rails/Pluck: - 'spec/models/project_spec.rb' - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' + - 'spec/requests/api/admin/instance_clusters_spec.rb' + - 'spec/requests/api/branches_spec.rb' + - 'spec/requests/api/ci/pipeline_schedules_spec.rb' + - 'spec/requests/api/ci/pipelines_spec.rb' + - 'spec/requests/api/commit_statuses_spec.rb' + - 'spec/requests/api/commits_spec.rb' + - 'spec/requests/api/deploy_tokens_spec.rb' + - 'spec/requests/api/deployments_spec.rb' + - 'spec/requests/api/events_spec.rb' + - 'spec/requests/api/feature_flags_spec.rb' + - 'spec/requests/api/feature_flags_user_lists_spec.rb' + - 'spec/requests/api/files_spec.rb' + - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' + - 'spec/requests/api/graphql/ci/manual_variables_spec.rb' + - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' + - 'spec/requests/api/graphql/group/timelogs_spec.rb' + - 'spec/requests/api/graphql/group_query_spec.rb' + - 'spec/requests/api/graphql/mutations/design_management/move_spec.rb' + - 'spec/requests/api/graphql/packages/package_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alerts_spec.rb' + - 'spec/requests/api/graphql/project/base_service_spec.rb' + - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' + - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' + - 'spec/requests/api/graphql/project/issues_spec.rb' + - 'spec/requests/api/graphql/project/jira_import_spec.rb' + - 'spec/requests/api/graphql/project/jira_projects_spec.rb' + - 'spec/requests/api/graphql/project/release_spec.rb' + - 'spec/requests/api/graphql/project/releases_spec.rb' + - 'spec/requests/api/group_clusters_spec.rb' + - 'spec/requests/api/group_labels_spec.rb' + - 'spec/requests/api/group_milestones_spec.rb' + - 'spec/requests/api/group_packages_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/api/invitations_spec.rb' + - 'spec/requests/api/issues/get_project_issues_spec.rb' + - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/members_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/namespaces_spec.rb' + - 'spec/requests/api/package_files_spec.rb' + - 'spec/requests/api/pages_domains_spec.rb' + - 'spec/requests/api/personal_access_tokens_spec.rb' + - 'spec/requests/api/project_clusters_spec.rb' + - 'spec/requests/api/project_container_repositories_spec.rb' + - 'spec/requests/api/project_events_spec.rb' + - 'spec/requests/api/project_milestones_spec.rb' + - 'spec/requests/api/project_snippets_spec.rb' + - 'spec/requests/api/project_templates_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/protected_branches_spec.rb' + - 'spec/requests/api/protected_tags_spec.rb' + - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/repositories_spec.rb' + - 'spec/requests/api/resource_access_tokens_spec.rb' + - 'spec/requests/api/snippets_spec.rb' + - 'spec/requests/api/tags_spec.rb' + - 'spec/requests/api/templates_spec.rb' + - 'spec/requests/api/todos_spec.rb' + - 'spec/requests/api/topics_spec.rb' + - 'spec/requests/api/unleash_spec.rb' + - 'spec/requests/api/users_spec.rb' + - 'spec/requests/api/v3/github_spec.rb' + - 'spec/requests/groups/autocomplete_sources_spec.rb' + - 'spec/requests/groups/milestones_controller_spec.rb' + - 'spec/requests/jwks_controller_spec.rb' + - 'spec/requests/lfs_http_spec.rb' - 'spec/serializers/ci/dag_pipeline_entity_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/diff_file_entity_spec.rb' - 'spec/serializers/stage_entity_spec.rb' + - 'spec/services/ci/compare_test_reports_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' + - 'spec/services/clusters/applications/prometheus_config_service_spec.rb' + - 'spec/services/issues/export_csv_service_spec.rb' - 'spec/services/metrics/dashboard/custom_metric_embed_service_spec.rb' - 'spec/services/projects/participants_service_spec.rb' + - 'spec/support/helpers/api_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/matchers/background_migrations_matchers.rb' - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' + - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' + - 'spec/support/shared_examples/services/packages_shared_examples.rb' + - 'spec/tooling/docs/deprecation_handling_spec.rb' - 'tooling/danger/sidekiq_queues.rb' + - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 0d23c51caae..3251429876e 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/RedundantForeignKey: Exclude: - 'app/models/alert_management/metric_image.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index f1e7d519a8f..378c00c1063 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -1,126 +1,110 @@ --- +# Cop supports --autocorrect. Rails/TimeZone: - Enabled: true Exclude: - - lib/gitlab/popen.rb - - ee/lib/delay.rb - - ee/lib/gitlab/elastic/helper.rb - - ee/lib/gitlab/elastic/indexer.rb - - ee/lib/gitlab/geo/event_gap_tracking.rb - - ee/lib/gitlab/geo/log_cursor/events/design_repository_updated_event.rb - - ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb - - ee/lib/gitlab/geo/log_cursor/logger.rb - - ee/lib/gitlab/geo/oauth/login_state.rb - - ee/lib/gitlab/prometheus/queries/cluster_query.rb - - ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb - - ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb - - ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb - - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb - - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - - ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb - - ee/spec/lib/gitlab/auth/smartcard/session_spec.rb - - ee/spec/lib/gitlab/elastic/client_spec.rb - - ee/spec/lib/gitlab/geo/base_request_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/logger_spec.rb - - ee/spec/lib/gitlab/git_access_spec.rb - - ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb - - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb - - lib/api/helpers.rb - - lib/api/sidekiq_metrics.rb - - lib/backup/manager.rb - - lib/bitbucket_server/representation/base.rb - - lib/gitlab/auth/current_user_mode.rb - - lib/gitlab/auth/ldap/access.rb - - lib/gitlab/chaos.rb - - lib/gitlab/checks/timed_logger.rb - - lib/gitlab/ci/pipeline/duration.rb - - lib/gitlab/database.rb - - lib/gitlab/external_authorization/access.rb - - lib/gitlab/external_authorization/cache.rb - - lib/gitlab/gitaly_client.rb - - lib/gitlab/gitaly_client/ref_service.rb - - lib/gitlab/github_import/representation.rb - - lib/gitlab/health_checks/base_abstract_check.rb - - lib/gitlab/import_export.rb - - lib/gitlab/instrumentation/elasticsearch_transport.rb - - lib/gitlab/instrumentation_helper.rb - - lib/gitlab/lfs_token.rb - - lib/gitlab/loop_helpers.rb - - lib/gitlab/phabricator_import/representation/task.rb - - lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb - - lib/gitlab/prometheus/queries/matched_metric_query.rb - - lib/gitlab/prometheus_client.rb - - lib/gitlab/task_helpers.rb - - lib/gitlab/x509/tag.rb - - lib/grafana/time_window.rb - - lib/json_web_token/token.rb - - lib/object_storage/direct_upload.rb - - lib/quality/seeders/issues.rb - - lib/tasks/gitlab/assets.rake - - lib/tasks/gitlab/backup.rake - - lib/tasks/gitlab/cleanup.rake - - lib/tasks/gitlab/list_repos.rake - - spec/lib/api/helpers_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb - - spec/lib/gitlab/app_json_logger_spec.rb - - spec/lib/gitlab/app_text_logger_spec.rb - - spec/lib/gitlab/auth/current_user_mode_spec.rb - - spec/lib/gitlab/bitbucket_import/importer_spec.rb - - spec/lib/gitlab/bitbucket_server_import/importer_spec.rb - - spec/lib/gitlab/checks/timed_logger_spec.rb - - spec/lib/gitlab/ci/cron_parser_spec.rb - - spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb - - spec/lib/gitlab/data_builder/note_spec.rb - - spec/lib/gitlab/database/background_migration_job_spec.rb - - spec/lib/gitlab/database_spec.rb - - spec/lib/gitlab/discussions_diff/file_collection_spec.rb - - spec/lib/gitlab/external_authorization/access_spec.rb - - spec/lib/gitlab/external_authorization/cache_spec.rb - - spec/lib/gitlab/external_authorization/logger_spec.rb - - spec/lib/gitlab/fogbugz_import/importer_spec.rb - - spec/lib/gitlab/git/branch_spec.rb - - spec/lib/gitlab/git/commit_spec.rb - - spec/lib/gitlab/git/repository_spec.rb - - spec/lib/gitlab/git_access_spec.rb - - spec/lib/gitlab/github_import/importer/issue_importer_spec.rb - - spec/lib/gitlab/github_import/importer/issues_importer_spec.rb - - spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb - - spec/lib/gitlab/github_import/importer/note_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb - - spec/lib/gitlab/github_import/importer/releases_importer_spec.rb - - spec/lib/gitlab/github_import/representation/diff_note_spec.rb - - spec/lib/gitlab/github_import/representation/issue_spec.rb - - spec/lib/gitlab/github_import/representation/note_spec.rb - - spec/lib/gitlab/github_import/representation/pull_request_spec.rb - - spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb - - spec/lib/gitlab/grape_logging/loggers/cloudflare_logger_spec.rb - - spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb - - spec/lib/gitlab/graphql_logger_spec.rb - - spec/lib/gitlab/graphs/commits_spec.rb - - spec/lib/gitlab/import_export/project/relation_factory_spec.rb - - spec/lib/gitlab/json_logger_spec.rb - - spec/lib/gitlab/lfs_token_spec.rb - - spec/lib/gitlab/log_timestamp_formatter_spec.rb - - spec/lib/gitlab/middleware/rails_queue_duration_spec.rb - - spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb - - spec/lib/gitlab/phabricator_import/representation/task_spec.rb - - spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb - - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - - spec/lib/gitlab/prometheus/queries/validate_query_spec.rb - - spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb - - spec/lib/gitlab/utils/json_size_estimator_spec.rb - - spec/lib/gitlab/x509/signature_spec.rb - - spec/lib/grafana/time_window_spec.rb - - spec/lib/json_web_token/hmac_token_spec.rb + - 'ee/lib/delay.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'ee/lib/gitlab/geo/event_gap_tracking.rb' + - 'ee/lib/gitlab/geo/log_cursor/events/design_repository_updated_event.rb' + - 'ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb' + - 'ee/lib/gitlab/geo/log_cursor/logger.rb' + - 'ee/lib/gitlab/geo/oauth/login_state.rb' + - 'ee/spec/lib/gitlab/geo/base_request_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/logger_spec.rb' + - 'ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' + - 'ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb' + - 'lib/api/helpers.rb' + - 'lib/api/sidekiq_metrics.rb' + - 'lib/bitbucket_server/representation/base.rb' + - 'lib/gitlab/auth/current_user_mode.rb' + - 'lib/gitlab/auth/ldap/access.rb' + - 'lib/gitlab/chaos.rb' + - 'lib/gitlab/checks/timed_logger.rb' + - 'lib/gitlab/ci/pipeline/duration.rb' + - 'lib/gitlab/database.rb' + - 'lib/gitlab/external_authorization/access.rb' + - 'lib/gitlab/external_authorization/cache.rb' + - 'lib/gitlab/gitaly_client.rb' + - 'lib/gitlab/gitaly_client/ref_service.rb' + - 'lib/gitlab/github_import/representation.rb' + - 'lib/gitlab/health_checks/base_abstract_check.rb' + - 'lib/gitlab/import_export.rb' + - 'lib/gitlab/instrumentation/elasticsearch_transport.rb' + - 'lib/gitlab/instrumentation_helper.rb' + - 'lib/gitlab/lfs_token.rb' + - 'lib/gitlab/loop_helpers.rb' + - 'lib/gitlab/phabricator_import/representation/task.rb' + - 'lib/gitlab/popen.rb' + - 'lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb' + - 'lib/gitlab/prometheus/queries/matched_metric_query.rb' + - 'lib/gitlab/prometheus_client.rb' + - 'lib/gitlab/task_helpers.rb' + - 'lib/gitlab/x509/tag.rb' + - 'lib/grafana/time_window.rb' + - 'lib/json_web_token/token.rb' + - 'lib/object_storage/direct_upload.rb' + - 'lib/quality/seeders/issues.rb' + - 'lib/tasks/gitlab/assets.rake' + - 'lib/tasks/gitlab/backup.rake' + - 'lib/tasks/gitlab/cleanup.rake' + - 'lib/tasks/gitlab/list_repos.rake' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' + - 'spec/lib/gitlab/app_json_logger_spec.rb' + - 'spec/lib/gitlab/app_text_logger_spec.rb' + - 'spec/lib/gitlab/auth/current_user_mode_spec.rb' + - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' + - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' + - 'spec/lib/gitlab/checks/timed_logger_spec.rb' + - 'spec/lib/gitlab/ci/cron_parser_spec.rb' + - 'spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' + - 'spec/lib/gitlab/data_builder/note_spec.rb' + - 'spec/lib/gitlab/database/background_migration_job_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/discussions_diff/file_collection_spec.rb' + - 'spec/lib/gitlab/external_authorization/access_spec.rb' + - 'spec/lib/gitlab/external_authorization/cache_spec.rb' + - 'spec/lib/gitlab/external_authorization/logger_spec.rb' + - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' + - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/issue_spec.rb' + - 'spec/lib/gitlab/github_import/representation/note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/pull_request_spec.rb' + - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/cloudflare_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/graphql_logger_spec.rb' + - 'spec/lib/gitlab/graphs/commits_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' + - 'spec/lib/gitlab/json_logger_spec.rb' + - 'spec/lib/gitlab/lfs_token_spec.rb' + - 'spec/lib/gitlab/log_timestamp_formatter_spec.rb' + - 'spec/lib/gitlab/middleware/rails_queue_duration_spec.rb' + - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' + - 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' + - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' + - 'spec/lib/gitlab/utils/json_size_estimator_spec.rb' + - 'spec/lib/gitlab/x509/signature_spec.rb' + - 'spec/lib/grafana/time_window_spec.rb' + - 'spec/lib/json_web_token/hmac_token_spec.rb' |