diff options
Diffstat (limited to '.rubocop_todo')
121 files changed, 4671 insertions, 5680 deletions
diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index 653865e3d43..6f8cc5429c2 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -1,63 +1,57 @@ --- Cop/UserAdmin: Exclude: - - app/controllers/admin/impersonations_controller.rb - - app/controllers/sessions_controller.rb - - app/finders/autocomplete/routes_finder.rb - - app/finders/ci/jobs_finder.rb - - app/finders/ci/runners_finder.rb - - app/finders/personal_access_tokens_finder.rb - - app/finders/users_finder.rb - - app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb - - app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb - - app/helpers/application_helper.rb - - app/helpers/import_helper.rb - - app/helpers/nav_helper.rb - - app/helpers/projects_helper.rb - - app/helpers/search_helper.rb - - app/helpers/users/callouts_helper.rb - - app/helpers/users_helper.rb - - app/helpers/visibility_level_helper.rb - - app/models/concerns/protected_ref_access.rb - - app/models/concerns/spammable.rb - - app/models/issue_collection.rb - - app/models/merge_requests_closing_issues.rb - - app/models/protected_branch.rb - - app/models/user.rb - - app/policies/note_policy.rb - - app/services/auth/container_registry_authentication_service.rb - - app/services/emails/create_service.rb - - app/services/projects/enable_deploy_key_service.rb - - app/services/projects/fork_service.rb - - app/services/users/build_service.rb - - ee/app/controllers/ee/projects_controller.rb - - ee/app/helpers/ee/dashboard_helper.rb - - ee/app/helpers/ee/import_helper.rb - - ee/app/helpers/ee/subscribable_banner_helper.rb - - ee/app/helpers/ee/users/callouts_helper.rb - - ee/app/helpers/license_monitoring_helper.rb - - ee/app/helpers/push_rules_helper.rb - - ee/app/models/concerns/ee/protected_ref_access.rb - - ee/app/models/ee/user.rb - - ee/app/models/protected_environment/deploy_access_level.rb - - ee/app/policies/ee/group_policy.rb - - ee/app/policies/ee/project_policy.rb - - ee/app/services/ee/groups/create_service.rb - - ee/app/services/ee/groups/update_service.rb - - ee/app/services/ee/projects/update_service.rb - - ee/lib/ee/api/helpers.rb - - ee/lib/ee/gitlab/git_access.rb - - lib/api/award_emoji.rb - - lib/api/ci/runners.rb - - lib/api/entities/ci/runner_details.rb - - lib/api/groups.rb - - lib/api/helpers.rb - - lib/api/users.rb - - lib/api/v3/github.rb - - lib/constraints/admin_constrainer.rb - - lib/gitlab/auth.rb - - lib/gitlab/ci/runner_instructions.rb - - lib/gitlab/import_export/members_mapper.rb - - lib/gitlab/performance_bar.rb - - lib/gitlab/visibility_level.rb - - qa/qa/runtime/api/client.rb + - 'app/controllers/admin/impersonations_controller.rb' + - 'app/controllers/sessions_controller.rb' + - 'app/finders/autocomplete/routes_finder.rb' + - 'app/finders/ci/jobs_finder.rb' + - 'app/finders/ci/runners_finder.rb' + - 'app/finders/personal_access_tokens_finder.rb' + - 'app/finders/users_finder.rb' + - 'app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb' + - 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/import_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/helpers/users/callouts_helper.rb' + - 'app/helpers/users_helper.rb' + - 'app/helpers/visibility_level_helper.rb' + - 'app/models/concerns/protected_ref_access.rb' + - 'app/models/concerns/spammable.rb' + - 'app/models/issue_collection.rb' + - 'app/models/merge_requests_closing_issues.rb' + - 'app/models/protected_branch.rb' + - 'app/models/user.rb' + - 'app/policies/note_policy.rb' + - 'app/services/auth/container_registry_authentication_service.rb' + - 'app/services/emails/create_service.rb' + - 'app/services/projects/enable_deploy_key_service.rb' + - 'app/services/projects/fork_service.rb' + - 'app/services/users/build_service.rb' + - 'ee/app/controllers/ee/projects_controller.rb' + - 'ee/app/helpers/ee/dashboard_helper.rb' + - 'ee/app/helpers/ee/import_helper.rb' + - 'ee/app/helpers/ee/subscribable_banner_helper.rb' + - 'ee/app/helpers/ee/users/callouts_helper.rb' + - 'ee/app/helpers/license_monitoring_helper.rb' + - 'ee/app/helpers/push_rules_helper.rb' + - 'ee/app/models/concerns/ee/protected_ref_access.rb' + - 'ee/app/models/ee/user.rb' + - 'ee/app/policies/ee/group_policy.rb' + - 'ee/app/services/ee/groups/create_service.rb' + - 'ee/app/services/ee/groups/update_service.rb' + - 'ee/app/services/ee/projects/update_service.rb' + - 'ee/lib/ee/api/helpers.rb' + - 'ee/lib/ee/gitlab/git_access.rb' + - 'lib/api/award_emoji.rb' + - 'lib/api/ci/runners.rb' + - 'lib/api/groups.rb' + - 'lib/api/helpers.rb' + - 'lib/api/users.rb' + - 'lib/api/v3/github.rb' + - 'lib/constraints/admin_constrainer.rb' + - 'lib/gitlab/auth.rb' + - 'lib/gitlab/import_export/members_mapper.rb' + - 'lib/gitlab/performance_bar.rb' + - 'lib/gitlab/visibility_level.rb' diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml index 86db4e0c91f..43da6f8a5b4 100644 --- a/.rubocop_todo/database/multiple_databases.yml +++ b/.rubocop_todo/database/multiple_databases.yml @@ -1,21 +1,11 @@ --- Database/MultipleDatabases: Exclude: - - 'config/initializers/active_record_data_types.rb' - 'db/post_migrate/20210317104032_set_iteration_cadence_automatic_to_false.rb' - 'db/post_migrate/20210811122206_update_external_project_bots.rb' - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - - 'spec/db/schema_spec.rb' - - 'spec/initializers/database_config_spec.rb' - - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - - 'spec/lib/gitlab/profiler_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins_spec.rb' - 'spec/support/caching.rb' - - 'spec/support/gitlab/usage/metrics_instrumentation_shared_examples.rb' - 'spec/support/helpers/database/database_helpers.rb' - 'spec/support/helpers/database/table_schema_helpers.rb' - 'spec/support/helpers/migrations_helpers.rb' diff --git a/.rubocop_todo/database/rescue_query_canceled.yml b/.rubocop_todo/database/rescue_query_canceled.yml index 76635ca4018..324ab498dd9 100644 --- a/.rubocop_todo/database/rescue_query_canceled.yml +++ b/.rubocop_todo/database/rescue_query_canceled.yml @@ -6,4 +6,3 @@ Database/RescueQueryCanceled: - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/database/batch_counter.rb' - 'lib/gitlab/issuables_count_for_state.rb' - - 'lib/tasks/gitlab/db/lock_writes.rake' diff --git a/.rubocop_todo/fips/md5.yml b/.rubocop_todo/fips/md5.yml index ef9e8fdde62..fc9cee17653 100644 --- a/.rubocop_todo/fips/md5.yml +++ b/.rubocop_todo/fips/md5.yml @@ -8,8 +8,6 @@ Fips/MD5: - 'app/services/packages/go/create_package_service.rb' - 'app/services/packages/maven/metadata/append_package_file_service.rb' - 'app/services/packages/rubygems/create_gemspec_service.rb' - - 'config/application.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'ee/app/models/license.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'lib/tasks/migrate/setup_postgresql.rake' @@ -19,7 +17,6 @@ Fips/MD5: - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' - 'spec/models/concerns/checksummable_spec.rb' - 'spec/services/gravatar_service_spec.rb' - - 'spec/support/matchers/match_file.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - 'spec/tooling/rspec_flaky/example_spec.rb' - 'tooling/rspec_flaky/example.rb' diff --git a/.rubocop_todo/fips/sha1.yml b/.rubocop_todo/fips/sha1.yml index 934805c86d4..35221d9d3ff 100644 --- a/.rubocop_todo/fips/sha1.yml +++ b/.rubocop_todo/fips/sha1.yml @@ -37,7 +37,6 @@ Fips/SHA1: - 'ee/spec/models/vulnerabilities/finding_spec.rb' - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' @@ -85,8 +84,6 @@ Fips/SHA1: - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/diff/position_spec.rb' - - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' - - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/git/branch_spec.rb' - 'spec/lib/gitlab/git/tag_spec.rb' - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' diff --git a/.rubocop_todo/gitlab/delegate_predicate_methods.yml b/.rubocop_todo/gitlab/delegate_predicate_methods.yml index 44d603b3206..eb96914796f 100644 --- a/.rubocop_todo/gitlab/delegate_predicate_methods.yml +++ b/.rubocop_todo/gitlab/delegate_predicate_methods.yml @@ -1,4 +1,4 @@ --- Gitlab/DelegatePredicateMethods: Exclude: - - app/models/clusters/cluster.rb + - 'app/models/clusters/cluster.rb' diff --git a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml index 06651a0f60a..ce2190c980c 100644 --- a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml +++ b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml @@ -1,29 +1,14 @@ --- Gitlab/DeprecateTrackRedisHLLEvent: Exclude: - - 'app/controllers/admin/dev_ops_report_controller.rb' - - 'app/controllers/admin/usage_trends_controller.rb' - 'app/controllers/concerns/snippets_actions.rb' - 'app/controllers/concerns/wiki_actions.rb' - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/cycle_analytics_controller.rb' - - 'app/controllers/projects/graphs_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'ee/app/controllers/admin/audit_logs_controller.rb' - 'ee/app/controllers/admin/credentials_controller.rb' - - 'ee/app/controllers/ee/admin/dev_ops_report_controller.rb' - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb' - - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb' - - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' - 'ee/app/controllers/groups/audit_events_controller.rb' - - 'ee/app/controllers/groups/contribution_analytics_controller.rb' - 'ee/app/controllers/groups/epic_boards_controller.rb' - - 'ee/app/controllers/groups/insights_controller.rb' - - 'ee/app/controllers/groups/issues_analytics_controller.rb' - 'ee/app/controllers/groups/security/compliance_dashboards_controller.rb' - - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb' - - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' - - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' - - 'ee/app/controllers/projects/insights_controller.rb' - - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'spec/controllers/concerns/redis_tracking_spec.rb' diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 0daacdfe2b1..26800923393 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -1,152 +1,116 @@ --- Gitlab/FeatureAvailableUsage: Exclude: - - app/controllers/projects/application_controller.rb - - app/graphql/types/project_type.rb - - app/helpers/events_helper.rb - - app/helpers/labels_helper.rb - - app/policies/project_policy.rb - - ee/app/controllers/concerns/description_diff_actions.rb - - ee/app/controllers/concerns/ee/boards_actions.rb - - ee/app/controllers/concerns/security_dashboards_permissions.rb - - ee/app/controllers/ee/boards/lists_controller.rb - - ee/app/controllers/ee/projects/autocomplete_sources_controller.rb - - ee/app/controllers/ee/projects/issues_controller.rb - - ee/app/controllers/ee/projects/security/configuration_controller.rb - - ee/app/controllers/ee/projects/settings/ci_cd_controller.rb - - ee/app/controllers/ee/projects/settings/operations_controller.rb - - ee/app/controllers/ee/projects/settings/repository_controller.rb - - ee/app/controllers/projects/audit_events_controller.rb - - ee/app/controllers/projects/iterations_controller.rb - - ee/app/controllers/projects/path_locks_controller.rb - - ee/app/controllers/projects/subscriptions_controller.rb - - ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb - - ee/app/finders/ee/alert_management/http_integrations_finder.rb - - ee/app/graphql/ee/types/group_type.rb - - ee/app/graphql/mutations/dast/profiles/create.rb - - ee/app/graphql/mutations/dast/profiles/run.rb - - ee/app/graphql/mutations/dast/profiles/update.rb - - ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb - - ee/app/helpers/ee/application_helper.rb - - ee/app/helpers/ee/boards_helper.rb - - ee/app/helpers/ee/dashboard_helper.rb - - ee/app/helpers/ee/form_helper.rb - - ee/app/helpers/ee/graph_helper.rb - - ee/app/helpers/ee/issues_helper.rb - - ee/app/helpers/ee/lock_helper.rb - - ee/app/helpers/ee/operations_helper.rb - - ee/app/helpers/ee/projects/incidents_helper.rb - - ee/app/helpers/ee/projects_helper.rb - - ee/app/helpers/ee/releases_helper.rb - - ee/app/helpers/ee/search_helper.rb - - ee/app/helpers/ee/tree_helper.rb - - ee/app/models/approval_state.rb - - ee/app/models/concerns/ee/approvable.rb - - ee/app/models/concerns/ee/project_security_scanners_information.rb - - ee/app/models/concerns/ee/protected_ref_access.rb - - ee/app/models/concerns/insights_feature.rb - - ee/app/models/ee/board.rb - - ee/app/models/ee/ci/build.rb - - ee/app/models/ee/ci/build_dependencies.rb - - ee/app/models/ee/ci/pipeline.rb - - ee/app/models/ee/group.rb - - ee/app/models/ee/group_member.rb - - ee/app/models/ee/issue.rb - - ee/app/models/ee/list.rb - - ee/app/models/ee/merge_request.rb - - ee/app/models/ee/milestone_release.rb - - ee/app/models/ee/namespace.rb - - ee/app/models/ee/namespace_setting.rb - - ee/app/models/ee/project.rb - - ee/app/models/ee/project_ci_cd_setting.rb - - ee/app/models/project_security_setting.rb - - ee/app/policies/compliance_management/framework_policy.rb - - ee/app/policies/ee/group_policy.rb - - ee/app/policies/ee/project_policy.rb - - ee/app/policies/ee/protected_branch_policy.rb - - ee/app/presenters/ee/label_presenter.rb - - ee/app/presenters/merge_request_approver_presenter.rb - - ee/app/serializers/dashboard_operations_project_entity.rb - - ee/app/serializers/ee/environment_entity.rb - - ee/app/serializers/ee/evidences/release_entity.rb - - ee/app/serializers/ee/note_entity.rb - - ee/app/services/boards/epic_boards/update_service.rb - - ee/app/services/ci/audit_variable_change_service.rb - - ee/app/services/dashboard/projects/create_service.rb - - ee/app/services/dashboard/projects/list_service.rb - - ee/app/services/ee/alert_management/http_integrations/create_service.rb - - ee/app/services/ee/audit_event_service.rb - - ee/app/services/ee/boards/issues/list_service.rb - - ee/app/services/ee/boards/lists/create_service.rb - - ee/app/services/ee/boards/update_service.rb - - ee/app/services/ee/ide/schemas_config_service.rb - - ee/app/services/ee/issuable_base_service.rb - - ee/app/services/ee/issue_links/create_service.rb - - ee/app/services/ee/issues/build_service.rb - - ee/app/services/ee/lfs/lock_file_service.rb - - ee/app/services/ee/lfs/unlock_file_service.rb - - ee/app/services/ee/merge_requests/approval_service.rb - - ee/app/services/ee/merge_requests/build_service.rb - - ee/app/services/ee/merge_requests/merge_base_service.rb - - ee/app/services/ee/merge_requests/refresh_service.rb - - ee/app/services/ee/merge_requests/update_service.rb - - ee/app/services/ee/projects/create_service.rb - - ee/app/services/ee/protected_branches/create_service.rb - - ee/app/services/ee/releases/create_evidence_service.rb - - ee/app/services/iterations/create_service.rb - - ee/app/services/iterations/update_service.rb - - ee/app/services/merge_requests/sync_report_approver_approval_rules.rb - - ee/app/services/merge_requests/update_blocks_service.rb - - ee/app/services/projects/mark_for_deletion_service.rb - - ee/app/services/quality_management/test_cases/create_service.rb - - ee/app/services/requirements_management/process_test_reports_service.rb - - ee/app/services/security/store_scans_service.rb - - ee/app/views/projects/_merge_request_approvals_settings.html.haml - - ee/app/views/projects/_merge_request_settings.html.haml - - ee/app/views/projects/_merge_request_settings_description_text.html.haml - - ee/app/views/projects/audit_events/index.html.haml - - ee/app/views/projects/blob/_header_file_locks.html.haml - - ee/app/views/projects/issues/_related_issues.html.haml - - ee/app/views/projects/merge_requests/show.html.haml - - ee/app/views/projects/pipelines/_tabs_content.html.haml - - ee/app/views/projects/protected_branches/ee/_code_owner_approval_form.html.haml - - ee/app/views/projects/protected_branches/ee/_code_owner_approval_table.html.haml - - ee/app/views/projects/protected_branches/ee/_code_owner_approval_table_head.html.haml - - ee/app/views/projects/push_rules/_index.html.haml - - ee/app/views/projects/settings/_default_issue_template.html.haml - - ee/app/views/projects/settings/_marked_for_removal.html.haml - - ee/app/views/projects/settings/_restore.html.haml - - ee/app/views/projects/settings/ci_cd/_auto_rollback.html.haml - - ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml - - ee/app/views/projects/settings/operations/_status_page.html.haml - - ee/app/views/projects/settings/repository/_protected_branches.html.haml - - ee/app/views/shared/issuable/_group_bulk_update_sidebar.html.haml - - ee/app/views/shared/issuable/form/_default_templates.html.haml - - ee/app/views/shared/labels/_create_label_help_text.html.haml - - ee/app/views/shared/promotions/_promote_mr_features.html.haml - - ee/app/views/shared/promotions/_promote_repository_features.html.haml - - ee/app/workers/analytics/code_review_metrics_worker.rb - - ee/app/workers/group_saml_group_sync_worker.rb - - ee/lib/ee/api/entities/approval_state.rb - - ee/lib/ee/api/entities/board.rb - - ee/lib/ee/api/entities/issue.rb - - ee/lib/ee/api/entities/project.rb - - ee/lib/ee/api/helpers.rb - - ee/lib/ee/api/internal/kubernetes.rb - - ee/lib/ee/api/projects.rb - - ee/lib/ee/gitlab/alert_management/payload/generic.rb - - ee/lib/ee/gitlab/checks/diff_check.rb - - ee/lib/ee/gitlab/gon_helper.rb - - ee/lib/ee/gitlab/tree_summary.rb - - ee/lib/gitlab/alert_management.rb - - ee/lib/gitlab/ci/pipeline/chain/config/content/compliance.rb - - ee/lib/gitlab/ci/project_config/compliance.rb - - ee/lib/gitlab/code_owners.rb - - ee/lib/gitlab/incident_management.rb - - ee/lib/gitlab/path_locks_finder.rb - - ee/lib/incident_management/incident_sla.rb - - ee/spec/models/instance_security_dashboard_spec.rb - - ee/spec/models/license_spec.rb - - ee/spec/models/project_spec.rb - - lib/api/helpers/related_resources_helpers.rb - - spec/models/concerns/featurable_spec.rb + - 'app/controllers/projects/application_controller.rb' + - 'app/graphql/types/project_type.rb' + - 'app/helpers/events_helper.rb' + - 'app/helpers/labels_helper.rb' + - 'ee/app/controllers/concerns/description_diff_actions.rb' + - 'ee/app/controllers/concerns/ee/boards_actions.rb' + - 'ee/app/controllers/concerns/security_dashboards_permissions.rb' + - 'ee/app/controllers/ee/projects/autocomplete_sources_controller.rb' + - 'ee/app/controllers/ee/projects/issues_controller.rb' + - 'ee/app/controllers/ee/projects/security/configuration_controller.rb' + - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' + - 'ee/app/controllers/ee/projects/settings/operations_controller.rb' + - 'ee/app/controllers/ee/projects/settings/repository_controller.rb' + - 'ee/app/controllers/projects/audit_events_controller.rb' + - 'ee/app/controllers/projects/iterations_controller.rb' + - 'ee/app/controllers/projects/path_locks_controller.rb' + - 'ee/app/controllers/projects/subscriptions_controller.rb' + - 'ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb' + - 'ee/app/finders/ee/alert_management/http_integrations_finder.rb' + - 'ee/app/graphql/ee/types/group_type.rb' + - 'ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb' + - 'ee/app/helpers/ee/application_helper.rb' + - 'ee/app/helpers/ee/boards_helper.rb' + - 'ee/app/helpers/ee/dashboard_helper.rb' + - 'ee/app/helpers/ee/form_helper.rb' + - 'ee/app/helpers/ee/graph_helper.rb' + - 'ee/app/helpers/ee/issues_helper.rb' + - 'ee/app/helpers/ee/lock_helper.rb' + - 'ee/app/helpers/ee/operations_helper.rb' + - 'ee/app/helpers/ee/projects/incidents_helper.rb' + - 'ee/app/helpers/ee/projects_helper.rb' + - 'ee/app/helpers/ee/releases_helper.rb' + - 'ee/app/helpers/ee/search_helper.rb' + - 'ee/app/helpers/ee/tree_helper.rb' + - 'ee/app/models/approval_state.rb' + - 'ee/app/models/concerns/ee/approvable.rb' + - 'ee/app/models/concerns/ee/project_security_scanners_information.rb' + - 'ee/app/models/concerns/ee/protected_ref_access.rb' + - 'ee/app/models/concerns/insights_feature.rb' + - 'ee/app/models/ee/board.rb' + - 'ee/app/models/ee/ci/build.rb' + - 'ee/app/models/ee/ci/build_dependencies.rb' + - 'ee/app/models/ee/ci/pipeline.rb' + - 'ee/app/models/ee/group.rb' + - 'ee/app/models/ee/group_member.rb' + - 'ee/app/models/ee/issue.rb' + - 'ee/app/models/ee/list.rb' + - 'ee/app/models/ee/merge_request.rb' + - 'ee/app/models/ee/milestone_release.rb' + - 'ee/app/models/ee/namespace.rb' + - 'ee/app/models/ee/namespace_setting.rb' + - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/project_ci_cd_setting.rb' + - 'ee/app/models/project_security_setting.rb' + - 'ee/app/policies/compliance_management/framework_policy.rb' + - 'ee/app/policies/ee/group_policy.rb' + - 'ee/app/policies/ee/project_policy.rb' + - 'ee/app/policies/ee/protected_branch_policy.rb' + - 'ee/app/presenters/ee/label_presenter.rb' + - 'ee/app/presenters/merge_request_approver_presenter.rb' + - 'ee/app/serializers/dashboard_operations_project_entity.rb' + - 'ee/app/serializers/ee/environment_entity.rb' + - 'ee/app/serializers/ee/evidences/release_entity.rb' + - 'ee/app/serializers/ee/note_entity.rb' + - 'ee/app/services/boards/epic_boards/update_service.rb' + - 'ee/app/services/ci/audit_variable_change_service.rb' + - 'ee/app/services/dashboard/projects/create_service.rb' + - 'ee/app/services/dashboard/projects/list_service.rb' + - 'ee/app/services/ee/alert_management/http_integrations/create_service.rb' + - 'ee/app/services/ee/audit_event_service.rb' + - 'ee/app/services/ee/boards/issues/list_service.rb' + - 'ee/app/services/ee/boards/lists/create_service.rb' + - 'ee/app/services/ee/boards/update_service.rb' + - 'ee/app/services/ee/ide/schemas_config_service.rb' + - 'ee/app/services/ee/issuable_base_service.rb' + - 'ee/app/services/ee/issue_links/create_service.rb' + - 'ee/app/services/ee/issues/build_service.rb' + - 'ee/app/services/ee/lfs/lock_file_service.rb' + - 'ee/app/services/ee/lfs/unlock_file_service.rb' + - 'ee/app/services/ee/merge_requests/build_service.rb' + - 'ee/app/services/ee/merge_requests/merge_base_service.rb' + - 'ee/app/services/ee/merge_requests/refresh_service.rb' + - 'ee/app/services/ee/projects/create_service.rb' + - 'ee/app/services/ee/protected_branches/create_service.rb' + - 'ee/app/services/ee/releases/create_evidence_service.rb' + - 'ee/app/services/iterations/create_service.rb' + - 'ee/app/services/iterations/update_service.rb' + - 'ee/app/services/merge_requests/update_blocks_service.rb' + - 'ee/app/services/projects/mark_for_deletion_service.rb' + - 'ee/app/services/requirements_management/process_test_reports_service.rb' + - 'ee/app/services/security/store_scans_service.rb' + - 'ee/app/workers/analytics/code_review_metrics_worker.rb' + - 'ee/app/workers/group_saml_group_sync_worker.rb' + - 'ee/lib/ee/api/entities/approval_state.rb' + - 'ee/lib/ee/api/entities/board.rb' + - 'ee/lib/ee/api/entities/issue.rb' + - 'ee/lib/ee/api/entities/project.rb' + - 'ee/lib/ee/api/helpers.rb' + - 'ee/lib/ee/api/projects.rb' + - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' + - 'ee/lib/ee/gitlab/checks/diff_check.rb' + - 'ee/lib/ee/gitlab/gon_helper.rb' + - 'ee/lib/ee/gitlab/tree_summary.rb' + - 'ee/lib/gitlab/alert_management.rb' + - 'ee/lib/gitlab/ci/project_config/compliance.rb' + - 'ee/lib/gitlab/code_owners.rb' + - 'ee/lib/gitlab/path_locks_finder.rb' + - 'ee/lib/incident_management/incident_sla.rb' + - 'ee/spec/models/instance_security_dashboard_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'lib/api/helpers/related_resources_helpers.rb' + - 'spec/models/concerns/featurable_spec.rb' diff --git a/.rubocop_todo/gitlab/json.yml b/.rubocop_todo/gitlab/json.yml deleted file mode 100644 index 190778a3de7..00000000000 --- a/.rubocop_todo/gitlab/json.yml +++ /dev/null @@ -1,465 +0,0 @@ ---- -# Cop supports --autocorrect. -Gitlab/Json: - Exclude: - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/concerns/authenticates_with_two_factor.rb' - - 'app/controllers/projects/commit_controller.rb' - - 'app/controllers/projects/google_cloud/configuration_controller.rb' - - 'app/controllers/projects/google_cloud/databases_controller.rb' - - 'app/controllers/projects/google_cloud/deployments_controller.rb' - - 'app/controllers/projects/google_cloud/gcp_regions_controller.rb' - - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' - - 'app/controllers/projects/graphs_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/controllers/projects/notes_controller.rb' - - 'app/controllers/projects/settings/ci_cd_controller.rb' - - 'app/controllers/projects/templates_controller.rb' - - 'app/controllers/projects_controller.rb' - - 'app/controllers/search_controller.rb' - - 'app/helpers/access_tokens_helper.rb' - - 'app/helpers/application_settings_helper.rb' - - 'app/helpers/breadcrumbs_helper.rb' - - 'app/helpers/ci/builds_helper.rb' - - 'app/helpers/ci/pipelines_helper.rb' - - 'app/helpers/compare_helper.rb' - - 'app/helpers/emails_helper.rb' - - 'app/helpers/environment_helper.rb' - - 'app/helpers/groups_helper.rb' - - 'app/helpers/ide_helper.rb' - - 'app/helpers/integrations_helper.rb' - - 'app/helpers/invite_members_helper.rb' - - 'app/helpers/issuables_description_templates_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/jira_connect_helper.rb' - - 'app/helpers/learn_gitlab_helper.rb' - - 'app/helpers/namespaces_helper.rb' - - 'app/helpers/notes_helper.rb' - - 'app/helpers/operations_helper.rb' - - 'app/helpers/packages_helper.rb' - - 'app/helpers/projects/project_members_helper.rb' - - 'app/helpers/projects_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/helpers/terms_helper.rb' - - 'app/helpers/users_helper.rb' - - 'app/mailers/emails/members.rb' - - 'app/presenters/packages/composer/packages_presenter.rb' - - 'app/presenters/projects/security/configuration_presenter.rb' - - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - - 'config/initializers/rack_multipart_patch.rb' - - 'ee/app/controllers/admin/geo/nodes_controller.rb' - - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - - 'ee/app/controllers/ee/search_controller.rb' - - 'ee/app/controllers/subscriptions_controller.rb' - - 'ee/app/graphql/types/json_string_type.rb' - - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/ee/environments_helper.rb' - - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - - 'ee/app/helpers/ee/invite_members_helper.rb' - - 'ee/app/helpers/ee/operations_helper.rb' - - 'ee/app/helpers/ee/projects/pipeline_helper.rb' - - 'ee/app/helpers/ee/projects_helper.rb' - - 'ee/app/helpers/ee/security_orchestration_helper.rb' - - 'ee/app/helpers/groups/ldap_sync_helper.rb' - - 'ee/app/helpers/groups/security_features_helper.rb' - - 'ee/app/helpers/incident_management/oncall_schedule_helper.rb' - - 'ee/app/helpers/projects/on_demand_scans_helper.rb' - - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' - - 'ee/app/helpers/security_helper.rb' - - 'ee/app/helpers/subscriptions_helper.rb' - - 'ee/app/helpers/users/identity_verification_helper.rb' - - 'ee/app/helpers/vulnerabilities_helper.rb' - - 'ee/app/models/product_analytics/jitsu_authentication.rb' - - 'ee/app/presenters/epic_presenter.rb' - - 'ee/app/services/arkose/blocked_users_report_service.rb' - - 'ee/app/services/elastic/indexing_control_service.rb' - - 'ee/app/services/elastic/process_bookkeeping_service.rb' - - 'ee/app/services/security/token_revocation_service.rb' - - 'ee/app/services/status_page/publish_base_service.rb' - - 'ee/app/services/upcoming_reconciliations/update_service.rb' - - 'ee/app/services/vulnerabilities/create_service_base.rb' - - 'ee/app/workers/concerns/elastic/migration_state.rb' - - 'ee/app/workers/sync_seat_link_request_worker.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - - 'ee/lib/api/analytics/product_analytics.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'ee/lib/gitlab/elastic/indexer.rb' - - 'ee/lib/gitlab/geo/signed_data.rb' - - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' - - 'ee/lib/gitlab/subscription_portal/clients/rest.rb' - - 'ee/lib/slack/api.rb' - - 'ee/lib/tasks/gitlab/elastic.rake' - - 'ee/lib/tasks/gitlab/spdx.rake' - - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - - 'ee/spec/controllers/countries_controller_spec.rb' - - 'ee/spec/controllers/country_states_controller_spec.rb' - - 'ee/spec/controllers/ee/search_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb' - - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - - 'ee/spec/controllers/subscriptions_controller_spec.rb' - - 'ee/spec/factories/vulnerabilities/findings.rb' - - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' - - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' - - 'ee/spec/features/billings/qrtly_reconciliation_alert_spec.rb' - - 'ee/spec/features/projects/integrations/jira_issues_list_spec.rb' - - 'ee/spec/features/projects/integrations/user_activates_github_spec.rb' - - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'ee/spec/frontend/fixtures/dast_profiles.rb' - - 'ee/spec/frontend/fixtures/epic.rb' - - 'ee/spec/graphql/api/vulnerabilities_spec.rb' - - 'ee/spec/graphql/types/json_string_type_spec.rb' - - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' - - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/license_compliance/license_scanning_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/security/dependency_scanning_spec.rb' - - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' - - 'ee/spec/lib/slack/api_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - - 'ee/spec/models/ee/integrations/jira_spec.rb' - - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - - 'ee/spec/models/group_member_spec.rb' - - 'ee/spec/models/integrations/github/status_notifier_spec.rb' - - 'ee/spec/models/integrations/github_spec.rb' - - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - - 'ee/spec/models/vulnerabilities/finding_spec.rb' - - 'ee/spec/presenters/audit_event_presenter_spec.rb' - - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' - - 'ee/spec/requests/api/experiments_spec.rb' - - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' - - 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb' - - 'ee/spec/requests/api/graphql/vulnerabilities/external_issue_links_spec.rb' - - 'ee/spec/requests/api/graphql/vulnerabilities/location_spec.rb' - - 'ee/spec/requests/api/integrations/slack/events_spec.rb' - - 'ee/spec/requests/api/releases_spec.rb' - - 'ee/spec/requests/api/settings_spec.rb' - - 'ee/spec/requests/git_http_geo_spec.rb' - - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' - - 'ee/spec/requests/projects/security/policies_controller_spec.rb' - - 'ee/spec/requests/users/identity_verification_controller_spec.rb' - - 'ee/spec/serializers/clusters/environment_entity_spec.rb' - - 'ee/spec/serializers/clusters/environment_serializer_spec.rb' - - 'ee/spec/serializers/dependency_list_serializer_spec.rb' - - 'ee/spec/serializers/epics/related_epic_entity_spec.rb' - - 'ee/spec/serializers/evidences/evidence_entity_spec.rb' - - 'ee/spec/serializers/issue_serializer_spec.rb' - - 'ee/spec/serializers/licenses_list_serializer_spec.rb' - - 'ee/spec/serializers/member_entity_spec.rb' - - 'ee/spec/serializers/member_user_entity_spec.rb' - - 'ee/spec/serializers/status_page/incident_entity_spec.rb' - - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' - - 'ee/spec/serializers/test_reports_comparer_serializer_spec.rb' - - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/arkose/token_verification_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - - 'ee/spec/services/integrations/slack_events/app_home_opened_service_spec.rb' - - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - - 'ee/spec/services/projects/slack_application_install_service_spec.rb' - - 'ee/spec/services/security/token_revocation_service_spec.rb' - - 'ee/spec/support/helpers/subscription_portal_helpers.rb' - - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - - 'ee/spec/support/shared_examples/status_page/publish_shared_examples.rb' - - 'ee/spec/tasks/gitlab/spdx_rake_spec.rb' - - 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb' - - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' - - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - - 'ee/spec/workers/vulnerability_exports/export_worker_spec.rb' - - 'lib/api/api.rb' - - 'lib/api/feature_flags_user_lists.rb' - - 'lib/api/helpers.rb' - - 'lib/api/terraform/state.rb' - - 'lib/atlassian/jira_connect/client.rb' - - 'lib/atlassian/jira_connect/serializers/base_entity.rb' - - 'lib/backup/gitaly_backup.rb' - - 'lib/bitbucket_server/client.rb' - - 'lib/bulk_imports/clients/graphql.rb' - - 'lib/error_tracking/sentry_client.rb' - - 'lib/gitlab/alert_management/payload/prometheus.rb' - - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - - 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb' - - 'lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp.rb' - - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' - - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/bitbucket_import/importer.rb' - - 'lib/gitlab/bitbucket_server_import/importer.rb' - - 'lib/gitlab/chat/responder/mattermost.rb' - - 'lib/gitlab/chat/responder/slack.rb' - - 'lib/gitlab/chat_name_token.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/ansi2json/state.rb' - - 'lib/gitlab/ci/build/releaser.rb' - - 'lib/gitlab/ci/config/external/mapper.rb' - - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' - - 'lib/gitlab/ci/reports/security/finding.rb' - - 'lib/gitlab/composer/cache.rb' - - 'lib/gitlab/database/background_migration/batched_migration.rb' - - 'lib/gitlab/database/background_migration_job.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' - - 'lib/gitlab/database/migrations/instrumentation.rb' - - 'lib/gitlab/database/migrations/runner.rb' - - 'lib/gitlab/database/postgres_hll/buckets.rb' - - 'lib/gitlab/database/reindexing/grafana_notifier.rb' - - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb' - - 'lib/gitlab/diff/highlight_cache.rb' - - 'lib/gitlab/discussions_diff/highlight_cache.rb' - - 'lib/gitlab/external_authorization/client.rb' - - 'lib/gitlab/file_hook.rb' - - 'lib/gitlab/gitaly_client/conflicts_service.rb' - - 'lib/gitlab/graphql/pagination/active_record_array_connection.rb' - - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - - 'lib/gitlab/health_checks/middleware.rb' - - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' - - 'lib/gitlab/import_export/json/legacy_writer.rb' - - 'lib/gitlab/import_export/json/ndjson_writer.rb' - - 'lib/gitlab/import_export/lfs_saver.rb' - - 'lib/gitlab/jira/http_client.rb' - - 'lib/gitlab/json_cache.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - - 'lib/gitlab/lfs/client.rb' - - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb' - - 'lib/gitlab/middleware/read_only/controller.rb' - - 'lib/gitlab/patch/hangouts_chat_http_override.rb' - - 'lib/gitlab/puma_logging/json_formatter.rb' - - 'lib/gitlab/sidekiq_config.rb' - - 'lib/gitlab/sidekiq_daemon/monitor.rb' - - 'lib/gitlab/sidekiq_logging/json_formatter.rb' - - 'lib/gitlab/usage/metrics/aggregates/sources/postgres_hll.rb' - - 'lib/gitlab/utils/json_size_estimator.rb' - - 'lib/gitlab/version_info.rb' - - 'lib/gitlab/workhorse.rb' - - 'lib/mattermost/command.rb' - - 'lib/mattermost/team.rb' - - 'lib/microsoft_teams/notifier.rb' - - 'lib/tasks/gitlab/background_migrations.rake' - - 'lib/version_check.rb' - - 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb' - - 'spec/controllers/admin/integrations_controller_spec.rb' - - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' - - 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb' - - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' - - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/factories/ci/pipeline_artifacts.rb' - - 'spec/features/dashboard/issues_spec.rb' - - 'spec/features/error_tracking/user_filters_errors_by_status_spec.rb' - - 'spec/features/file_uploads/graphql_add_design_spec.rb' - - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' - - 'spec/features/markdown/copy_as_gfm_spec.rb' - - 'spec/features/markdown/metrics_spec.rb' - - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'spec/features/projects/settings/monitor_settings_spec.rb' - - 'spec/frontend/fixtures/timezones.rb' - - 'spec/helpers/access_tokens_helper_spec.rb' - - 'spec/helpers/breadcrumbs_helper_spec.rb' - - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/environment_helper_spec.rb' - - 'spec/helpers/environments_helper_spec.rb' - - 'spec/helpers/groups/group_members_helper_spec.rb' - - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/ide_helper_spec.rb' - - 'spec/helpers/invite_members_helper_spec.rb' - - 'spec/helpers/issuables_description_templates_helper_spec.rb' - - 'spec/helpers/listbox_helper_spec.rb' - - 'spec/helpers/namespaces_helper_spec.rb' - - 'spec/helpers/projects/project_members_helper_spec.rb' - - 'spec/helpers/projects_helper_spec.rb' - - 'spec/initializers/hangouts_chat_http_override_spec.rb' - - 'spec/lib/api/entities/merge_request_basic_spec.rb' - - 'spec/lib/api/helpers/caching_spec.rb' - - 'spec/lib/api/helpers/common_helpers_spec.rb' - - 'spec/lib/atlassian/jira_connect/client_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/build_entity_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/repository_entity_spec.rb' - - 'spec/lib/bitbucket_server/connection_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/snippets_pipeline_spec.rb' - - 'spec/lib/container_registry/client_spec.rb' - - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - - 'spec/lib/gitlab/chat/responder/mattermost_spec.rb' - - 'spec/lib/gitlab/chat/responder/slack_spec.rb' - - 'spec/lib/gitlab/ci/build/releaser_spec.rb' - - 'spec/lib/gitlab/ci/parsers/accessibility/pa11y_spec.rb' - - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' - - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' - - 'spec/lib/gitlab/ci/parsers/sbom/cyclonedx_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - - 'spec/lib/gitlab/composer/cache_spec.rb' - - 'spec/lib/gitlab/composer/version_index_spec.rb' - - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - - 'spec/lib/gitlab/database/postgres_hll/buckets_spec.rb' - - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' - - 'spec/lib/gitlab/diff/position_spec.rb' - - 'spec/lib/gitlab/diff/stats_cache_spec.rb' - - 'spec/lib/gitlab/discussions_diff/highlight_cache_spec.rb' - - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' - - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - - 'spec/lib/gitlab/external_authorization/client_spec.rb' - - 'spec/lib/gitlab/external_authorization/response_spec.rb' - - 'spec/lib/gitlab/file_hook_spec.rb' - - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' - - 'spec/lib/gitlab/github_import/client_spec.rb' - - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' - - 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb' - - 'spec/lib/gitlab/harbor/client_spec.rb' - - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' - - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' - - 'spec/lib/gitlab/json_cache_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - - 'spec/lib/gitlab/lfs/client_spec.rb' - - 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb' - - 'spec/lib/gitlab/middleware/multipart_spec.rb' - - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' - - 'spec/lib/gitlab/tracking/service_ping_context_spec.rb' - - 'spec/lib/gitlab/tracking/standard_context_spec.rb' - - 'spec/lib/gitlab/tracking_spec.rb' - - 'spec/lib/gitlab/usage/service_ping/legacy_metric_timing_decorator_spec.rb' - - 'spec/lib/gitlab/utils/json_size_estimator_spec.rb' - - 'spec/lib/gitlab/version_info_spec.rb' - - 'spec/lib/gitlab/webpack/manifest_spec.rb' - - 'spec/lib/gitlab/workhorse_spec.rb' - - 'spec/lib/gitlab/zentao/client_spec.rb' - - 'spec/lib/grafana/client_spec.rb' - - 'spec/lib/json_web_token/hmac_token_spec.rb' - - 'spec/lib/mattermost/command_spec.rb' - - 'spec/lib/mattermost/team_spec.rb' - - 'spec/lib/microsoft_teams/notifier_spec.rb' - - 'spec/lib/object_storage/direct_upload_spec.rb' - - 'spec/lib/service_ping/devops_report_spec.rb' - - 'spec/lib/version_check_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20220204194347_encrypt_integration_properties_spec.rb' - - 'spec/migrations/20220412143552_consume_remaining_encrypt_integration_property_jobs_spec.rb' - - 'spec/models/blob_viewer/package_json_spec.rb' - - 'spec/models/ci/runner_spec.rb' - - 'spec/models/concerns/prometheus_adapter_spec.rb' - - 'spec/models/concerns/redis_cacheable_spec.rb' - - 'spec/models/concerns/sensitive_serializable_hash_spec.rb' - - 'spec/models/diff_discussion_spec.rb' - - 'spec/models/diff_note_spec.rb' - - 'spec/models/hooks/web_hook_spec.rb' - - 'spec/models/integrations/datadog_spec.rb' - - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/mattermost_slash_commands_spec.rb' - - 'spec/models/integrations/mock_ci_spec.rb' - - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/packages/composer/metadatum_spec.rb' - - 'spec/models/terraform/state_spec.rb' - - 'spec/presenters/packages/composer/packages_presenter_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/composer_packages_spec.rb' - - 'spec/requests/api/conan_instance_packages_spec.rb' - - 'spec/requests/api/conan_project_packages_spec.rb' - - 'spec/requests/api/container_registry_event_spec.rb' - - 'spec/requests/api/graphql/mutations/design_management/upload_spec.rb' - - 'spec/requests/api/integrations/jira_connect/subscriptions_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/namespaces_spec.rb' - - 'spec/requests/api/project_snapshots_spec.rb' - - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - - 'spec/requests/projects/incident_management/pagerduty_incidents_spec.rb' - - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' - - 'spec/requests/users_controller_spec.rb' - - 'spec/requests/whats_new_controller_spec.rb' - - 'spec/scripts/pipeline_test_report_builder_spec.rb' - - 'spec/serializers/ci/dag_job_entity_spec.rb' - - 'spec/serializers/ci/dag_job_group_entity_spec.rb' - - 'spec/serializers/ci/dag_pipeline_entity_spec.rb' - - 'spec/serializers/ci/dag_pipeline_serializer_spec.rb' - - 'spec/serializers/ci/dag_stage_entity_spec.rb' - - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' - - 'spec/serializers/ci/lint/result_serializer_spec.rb' - - 'spec/serializers/ci/trigger_entity_spec.rb' - - 'spec/serializers/ci/trigger_serializer_spec.rb' - - 'spec/serializers/diff_line_serializer_spec.rb' - - 'spec/serializers/evidences/evidence_entity_spec.rb' - - 'spec/serializers/feature_flags_client_serializer_spec.rb' - - 'spec/serializers/group_link/group_group_link_entity_spec.rb' - - 'spec/serializers/group_link/group_group_link_serializer_spec.rb' - - 'spec/serializers/group_link/group_link_entity_spec.rb' - - 'spec/serializers/group_link/project_group_link_entity_spec.rb' - - 'spec/serializers/group_link/project_group_link_serializer_spec.rb' - - 'spec/serializers/member_entity_spec.rb' - - 'spec/serializers/member_serializer_spec.rb' - - 'spec/serializers/member_user_entity_spec.rb' - - 'spec/serializers/test_reports_comparer_serializer_spec.rb' - - 'spec/services/ci/runners/process_runner_version_update_service_spec.rb' - - 'spec/services/draft_notes/create_service_spec.rb' - - 'spec/services/error_tracking/issue_details_service_spec.rb' - - 'spec/services/error_tracking/issue_latest_event_service_spec.rb' - - 'spec/services/error_tracking/list_issues_service_spec.rb' - - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/jira/requests/projects/list_service_spec.rb' - - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - - 'spec/services/packages/composer/create_package_service_spec.rb' - - 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb' - - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - - 'spec/services/webauthn/authenticate_service_spec.rb' - - 'spec/services/webauthn/register_service_spec.rb' - - 'spec/support/frontend_fixtures.rb' - - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - - 'spec/support/helpers/dependency_proxy_helpers.rb' - - 'spec/support/helpers/fake_webauthn_device.rb' - - 'spec/support/helpers/features/two_factor_helpers.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/helpers/input_helper.rb' - - 'spec/support/helpers/jira_integration_helpers.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - - 'spec/support/helpers/prometheus_helpers.rb' - - 'spec/support/helpers/sentry_client_helpers.rb' - - 'spec/support/helpers/usage_data_helpers.rb' - - 'spec/support/import_export/configuration_helper.rb' - - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - - 'spec/support/shared_contexts/features/error_tracking_shared_context.rb' - - 'spec/support/shared_contexts/prometheus/alert_shared_context.rb' - - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - - 'spec/support/shared_examples/blocks_unsafe_serialization_shared_examples.rb' - - 'spec/support/shared_examples/controllers/rate_limited_endpoint_shared_examples.rb' - - 'spec/support/shared_examples/controllers/snowplow_event_tracking_examples.rb' - - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' - - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' - - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' - - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - - 'spec/support_specs/helpers/graphql_helpers_spec.rb' - - 'spec/tasks/gitlab/update_templates_rake_spec.rb' - - 'spec/tasks/gitlab/usage_data_rake_spec.rb' - - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - - 'spec/workers/ci/runners/process_runner_version_update_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' - - 'spec/workers/packages/composer/cache_update_worker_spec.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 3fb2df623e0..e49169bae67 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -162,9 +162,6 @@ Gitlab/NamespacedClass: - 'app/models/epic.rb' - 'app/models/event.rb' - 'app/models/event_collection.rb' - - 'app/models/experiment.rb' - - 'app/models/experiment_subject.rb' - - 'app/models/experiment_user.rb' - 'app/models/exported_protected_branch.rb' - 'app/models/external_issue.rb' - 'app/models/external_pull_request.rb' @@ -396,15 +393,15 @@ Gitlab/NamespacedClass: - 'app/policies/personal_access_token_policy.rb' - 'app/policies/personal_snippet_policy.rb' - 'app/policies/project_ci_cd_setting_policy.rb' + - 'app/policies/project_hook_policy.rb' - 'app/policies/project_label_policy.rb' - 'app/policies/project_member_policy.rb' - 'app/policies/project_policy.rb' - 'app/policies/project_snippet_policy.rb' - 'app/policies/project_statistics_policy.rb' - - 'app/policies/project_hook_policy.rb' - 'app/policies/prometheus_alert_policy.rb' - - 'app/policies/protected_branch_policy.rb' - 'app/policies/protected_branch_access_policy.rb' + - 'app/policies/protected_branch_policy.rb' - 'app/policies/release_policy.rb' - 'app/policies/repository_policy.rb' - 'app/policies/resource_label_event_policy.rb' @@ -472,8 +469,6 @@ Gitlab/NamespacedClass: - 'app/serializers/base_discussion_entity.rb' - 'app/serializers/base_serializer.rb' - 'app/serializers/blob_entity.rb' - - 'app/serializers/board_serializer.rb' - - 'app/serializers/board_simple_entity.rb' - 'app/serializers/build_action_entity.rb' - 'app/serializers/build_artifact_entity.rb' - 'app/serializers/build_coverage_entity.rb' @@ -497,8 +492,6 @@ Gitlab/NamespacedClass: - 'app/serializers/container_tag_entity.rb' - 'app/serializers/container_tags_serializer.rb' - 'app/serializers/context_commits_diff_entity.rb' - - 'app/serializers/current_board_entity.rb' - - 'app/serializers/current_board_serializer.rb' - 'app/serializers/current_user_entity.rb' - 'app/serializers/deploy_keys_project_entity.rb' - 'app/serializers/deployment_cluster_entity.rb' @@ -690,7 +683,7 @@ Gitlab/NamespacedClass: - 'app/validators/addressable_url_validator.rb' - 'app/validators/any_field_validator.rb' - 'app/validators/array_members_validator.rb' - - 'app/validators/branch_filter_validator.rb' + - 'app/validators/bytesize_validator.rb' - 'app/validators/certificate_fingerprint_validator.rb' - 'app/validators/certificate_key_validator.rb' - 'app/validators/certificate_validator.rb' @@ -708,6 +701,7 @@ Gitlab/NamespacedClass: - 'app/validators/gitlab/zoom_url_validator.rb' - 'app/validators/html_safety_validator.rb' - 'app/validators/ip_address_validator.rb' + - 'app/validators/iso8601_date_validator.rb' - 'app/validators/js_regex_validator.rb' - 'app/validators/json_schema_validator.rb' - 'app/validators/key_restriction_validator.rb' @@ -725,15 +719,12 @@ Gitlab/NamespacedClass: - 'app/validators/top_level_group_validator.rb' - 'app/validators/untrusted_regexp_validator.rb' - 'app/validators/x509_certificate_credentials_validator.rb' - - 'app/validators/bytesize_validator.rb' - 'app/workers/admin_email_worker.rb' - 'app/workers/approve_blocked_pending_approval_users_worker.rb' - - 'app/workers/archive_trace_worker.rb' - 'app/workers/authorized_keys_worker.rb' - 'app/workers/authorized_projects_worker.rb' - 'app/workers/auto_merge_process_worker.rb' - 'app/workers/background_migration_worker.rb' - - 'app/workers/build_finished_worker.rb' - 'app/workers/build_hooks_worker.rb' - 'app/workers/build_queue_worker.rb' - 'app/workers/build_success_worker.rb' @@ -964,13 +955,13 @@ Gitlab/NamespacedClass: - 'ee/app/policies/dast_site_validation_policy.rb' - 'ee/app/policies/epic_policy.rb' - 'ee/app/policies/geo_node_policy.rb' + - 'ee/app/policies/group_hook_policy.rb' - 'ee/app/policies/instance_security_dashboard_policy.rb' - 'ee/app/policies/issuable_metric_image_policy.rb' - 'ee/app/policies/iteration_policy.rb' - 'ee/app/policies/push_rule_policy.rb' - 'ee/app/policies/saml_provider_policy.rb' - 'ee/app/policies/vulnerability_policy.rb' - - 'ee/app/policies/group_hook_policy.rb' - 'ee/app/presenters/approval_rule_presenter.rb' - 'ee/app/presenters/audit_event_presenter.rb' - 'ee/app/presenters/epic_issue_presenter.rb' @@ -982,9 +973,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/audit_event_entity.rb' - 'ee/app/serializers/audit_event_serializer.rb' - 'ee/app/serializers/blocking_merge_request_entity.rb' - - 'ee/app/serializers/board_assignee_entity.rb' - - 'ee/app/serializers/board_label_entity.rb' - - 'ee/app/serializers/board_milestone_entity.rb' - 'ee/app/serializers/dashboard_environment_entity.rb' - 'ee/app/serializers/dashboard_environments_project_entity.rb' - 'ee/app/serializers/dashboard_environments_serializer.rb' @@ -1078,7 +1066,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/sync_seat_link_worker.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - - 'ee/lib/gitlab/auth_logger.rb' - 'ee/lib/gitlab/authority_analyzer.rb' - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/gitlab/custom_file_templates.rb' @@ -1088,7 +1075,6 @@ Gitlab/NamespacedClass: - 'ee/lib/gitlab/ip_address_state.rb' - 'ee/lib/gitlab/items_collection.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - - 'ee/lib/gitlab/pagination_delegate.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'ee/lib/gitlab/proxy.rb' - 'ee/lib/gitlab/return_to_location.rb' @@ -1114,7 +1100,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/avatar_cache.rb' - 'lib/gitlab/backup_logger.rb' - 'lib/gitlab/base_doorkeeper_controller.rb' - - 'lib/gitlab/batch_pop_queueing.rb' - 'lib/gitlab/batch_worker_context.rb' - 'lib/gitlab/blame.rb' - 'lib/gitlab/branch_push_merge_commit_analyzer.rb' @@ -1147,7 +1132,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/exceptions_app.rb' - 'lib/gitlab/exclusive_lease.rb' - 'lib/gitlab/experiment/rollout/feature.rb' - - 'lib/gitlab/experimentation_logger.rb' - 'lib/gitlab/fake_application_settings.rb' - 'lib/gitlab/favicon.rb' - 'lib/gitlab/feature_categories.rb' @@ -1269,7 +1253,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/wiki_file_finder.rb' - 'lib/gitlab/workhorse.rb' - 'lib/gitlab/zoom_link_extractor.rb' - - 'lib/tasks/gitlab/graphql.rake' - 'lib/tasks/gitlab/seed/group_seed.rake' - 'lib/tasks/import.rake' - 'lib/tasks/tokens.rake' diff --git a/.rubocop_todo/gitlab/service_response.yml b/.rubocop_todo/gitlab/service_response.yml index 03b73d6491d..d6ce9633882 100644 --- a/.rubocop_todo/gitlab/service_response.yml +++ b/.rubocop_todo/gitlab/service_response.yml @@ -64,7 +64,6 @@ Gitlab/ServiceResponse: - 'ee/app/services/vulnerability_issue_links/create_service.rb' - 'ee/app/services/vulnerability_issue_links/delete_service.rb' - 'ee/spec/graphql/mutations/security/finding/dismiss_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - 'spec/controllers/import/bulk_imports_controller_spec.rb' - 'spec/controllers/import/fogbugz_controller_spec.rb' - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml new file mode 100644 index 00000000000..5afb7574ff1 --- /dev/null +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -0,0 +1,759 @@ +--- +# Cop supports --autocorrect. +Gitlab/StrongMemoizeAttr: + Details: grace period + Exclude: + - 'app/components/pajamas/avatar_component.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/concerns/boards_actions.rb' + - 'app/controllers/concerns/creates_commit.rb' + - 'app/controllers/concerns/find_snippet.rb' + - 'app/controllers/concerns/impersonation.rb' + - 'app/controllers/concerns/issuable_actions.rb' + - 'app/controllers/concerns/issuable_collections.rb' + - 'app/controllers/concerns/known_sign_in.rb' + - 'app/controllers/concerns/wiki_actions.rb' + - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' + - 'app/controllers/ide_controller.rb' + - 'app/controllers/import/github_controller.rb' + - 'app/controllers/invites_controller.rb' + - 'app/controllers/jira_connect/application_controller.rb' + - 'app/controllers/jwt_controller.rb' + - 'app/controllers/oauth/authorizations_controller.rb' + - 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb' + - 'app/controllers/projects/boards_controller.rb' + - 'app/controllers/projects/compare_controller.rb' + - 'app/controllers/projects/forks_controller.rb' + - 'app/controllers/projects/import/jira_controller.rb' + - 'app/controllers/projects/incidents_controller.rb' + - 'app/controllers/projects/merge_requests/drafts_controller.rb' + - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/controllers/projects/metrics_dashboard_controller.rb' + - 'app/controllers/projects/milestones_controller.rb' + - 'app/controllers/projects/pipelines/application_controller.rb' + - 'app/controllers/projects/pipelines_controller.rb' + - 'app/controllers/projects/todos_controller.rb' + - 'app/controllers/repositories/git_http_client_controller.rb' + - 'app/controllers/repositories/lfs_api_controller.rb' + - 'app/controllers/sessions_controller.rb' + - 'app/controllers/whats_new_controller.rb' + - 'app/finders/autocomplete/users_finder.rb' + - 'app/finders/ci/commit_statuses_finder.rb' + - 'app/finders/ci/pipelines_for_merge_request_finder.rb' + - 'app/finders/cluster_ancestors_finder.rb' + - 'app/finders/clusters/knative_services_finder.rb' + - 'app/finders/concerns/finder_with_group_hierarchy.rb' + - 'app/finders/crm/contacts_finder.rb' + - 'app/finders/crm/organizations_finder.rb' + - 'app/finders/groups/accepting_group_transfers_finder.rb' + - 'app/finders/issuable_finder.rb' + - 'app/finders/issuable_finder/params.rb' + - 'app/finders/issuables/label_filter.rb' + - 'app/finders/issues_finder/params.rb' + - 'app/finders/license_template_finder.rb' + - 'app/finders/merge_requests_finder/params.rb' + - 'app/finders/projects/members/effective_access_level_finder.rb' + - 'app/finders/releases/evidence_pipeline_finder.rb' + - 'app/finders/releases_finder.rb' + - 'app/finders/snippets_finder.rb' + - 'app/finders/todos_finder.rb' + - 'app/graphql/resolvers/issue_status_counts_resolver.rb' + - 'app/graphql/resolvers/issues/base_parent_resolver.rb' + - 'app/graphql/resolvers/namespace_projects_resolver.rb' + - 'app/graphql/resolvers/work_items_resolver.rb' + - 'app/graphql/types/board_list_type.rb' + - 'app/helpers/appearances_helper.rb' + - 'app/helpers/broadcast_messages_helper.rb' + - 'app/helpers/diff_helper.rb' + - 'app/helpers/operations_helper.rb' + - 'app/helpers/page_layout_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/sessions_helper.rb' + - 'app/helpers/timeboxes_helper.rb' + - 'app/models/alert_management/alert.rb' + - 'app/models/application_setting_implementation.rb' + - 'app/models/blob_viewer/go_mod.rb' + - 'app/models/blob_viewer/metrics_dashboard_yml.rb' + - 'app/models/bulk_imports/export.rb' + - 'app/models/bulk_imports/export_status.rb' + - 'app/models/bulk_imports/file_transfer/base_config.rb' + - 'app/models/ci/bridge.rb' + - 'app/models/ci/build.rb' + - 'app/models/ci/build_dependencies.rb' + - 'app/models/ci/build_metadata.rb' + - 'app/models/ci/commit_with_pipeline.rb' + - 'app/models/ci/group.rb' + - 'app/models/ci/job_artifact.rb' + - 'app/models/ci/pipeline.rb' + - 'app/models/ci/processable.rb' + - 'app/models/ci/runner.rb' + - 'app/models/clusters/cluster.rb' + - 'app/models/clusters/providers/aws.rb' + - 'app/models/commit.rb' + - 'app/models/commit_collection.rb' + - 'app/models/compare.rb' + - 'app/models/concerns/analytics/cycle_analytics/stage.rb' + - 'app/models/concerns/avatarable.rb' + - 'app/models/concerns/cascading_namespace_setting_attribute.rb' + - 'app/models/concerns/ci/contextable.rb' + - 'app/models/concerns/ci/partitionable.rb' + - 'app/models/concerns/discussion_on_diff.rb' + - 'app/models/concerns/has_repository.rb' + - 'app/models/concerns/has_wiki.rb' + - 'app/models/concerns/has_wiki_page_meta_attributes.rb' + - 'app/models/concerns/mentionable/reference_regexes.rb' + - 'app/models/concerns/redis_cacheable.rb' + - 'app/models/concerns/require_email_verification.rb' + - 'app/models/concerns/resolvable_discussion.rb' + - 'app/models/concerns/security/latest_pipeline_information.rb' + - 'app/models/container_registry/event.rb' + - 'app/models/container_repository.rb' + - 'app/models/customer_relations/contact_state_counts.rb' + - 'app/models/deploy_token.rb' + - 'app/models/deployment.rb' + - 'app/models/deployment_metrics.rb' + - 'app/models/design_management/design.rb' + - 'app/models/design_management/design_at_version.rb' + - 'app/models/design_management/version.rb' + - 'app/models/diff_note.rb' + - 'app/models/draft_note.rb' + - 'app/models/environment.rb' + - 'app/models/environment_status.rb' + - 'app/models/error_tracking/project_error_tracking_setting.rb' + - 'app/models/event.rb' + - 'app/models/event_collection.rb' + - 'app/models/group.rb' + - 'app/models/incident_management/project_incident_management_setting.rb' + - 'app/models/integrations/jira.rb' + - 'app/models/internal_id.rb' + - 'app/models/member.rb' + - 'app/models/merge_request.rb' + - 'app/models/merge_request_diff.rb' + - 'app/models/namespace.rb' + - 'app/models/namespaces/traversal/linear.rb' + - 'app/models/namespaces/traversal/recursive.rb' + - 'app/models/note.rb' + - 'app/models/onboarding/completion.rb' + - 'app/models/packages/go/module.rb' + - 'app/models/packages/go/module_version.rb' + - 'app/models/packages/package.rb' + - 'app/models/pages/lookup_path.rb' + - 'app/models/project.rb' + - 'app/models/release.rb' + - 'app/models/resource_event.rb' + - 'app/models/service_desk_setting.rb' + - 'app/models/snippet.rb' + - 'app/models/snippet_input_action_collection.rb' + - 'app/models/state_note.rb' + - 'app/models/tree.rb' + - 'app/models/uploads/fog.rb' + - 'app/models/user.rb' + - 'app/models/wiki_page.rb' + - 'app/models/work_item.rb' + - 'app/policies/application_setting/term_policy.rb' + - 'app/policies/note_policy.rb' + - 'app/presenters/blobs/unfold_presenter.rb' + - 'app/presenters/ci/build_runner_presenter.rb' + - 'app/presenters/ci/pipeline_artifacts/code_coverage_presenter.rb' + - 'app/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter.rb' + - 'app/presenters/ci/pipeline_presenter.rb' + - 'app/presenters/clusters/cluster_presenter.rb' + - 'app/presenters/merge_request_presenter.rb' + - 'app/presenters/packages/conan/package_presenter.rb' + - 'app/presenters/packages/nuget/packages_metadata_presenter.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' + - 'app/presenters/project_presenter.rb' + - 'app/presenters/projects/settings/deploy_keys_presenter.rb' + - 'app/serializers/ci/pipeline_entity.rb' + - 'app/serializers/concerns/diff_file_conflict_type.rb' + - 'app/serializers/diff_file_base_entity.rb' + - 'app/serializers/integrations/field_entity.rb' + - 'app/serializers/linked_project_issue_entity.rb' + - 'app/serializers/suggestion_entity.rb' + - 'app/services/alert_management/alerts/update_service.rb' + - 'app/services/alert_management/create_alert_issue_service.rb' + - 'app/services/alert_management/process_prometheus_alert_service.rb' + - 'app/services/auth/dependency_proxy_authentication_service.rb' + - 'app/services/authorized_project_update/project_recalculate_service.rb' + - 'app/services/auto_merge/base_service.rb' + - 'app/services/award_emojis/add_service.rb' + - 'app/services/base_project_service.rb' + - 'app/services/boards/base_items_list_service.rb' + - 'app/services/boards/lists/base_create_service.rb' + - 'app/services/ci/create_downstream_pipeline_service.rb' + - 'app/services/ci/create_web_ide_terminal_service.rb' + - 'app/services/ci/job_artifacts/destroy_batch_service.rb' + - 'app/services/ci/parse_dotenv_artifact_service.rb' + - 'app/services/ci/pipeline_artifacts/coverage_report_service.rb' + - 'app/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service.rb' + - 'app/services/ci/pipeline_artifacts/destroy_all_expired_service.rb' + - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb' + - 'app/services/ci/pipeline_schedules/calculate_next_run_service.rb' + - 'app/services/ci/pipeline_trigger_service.rb' + - 'app/services/ci/pipelines/hook_service.rb' + - 'app/services/ci/queue/build_queue_service.rb' + - 'app/services/ci/update_build_state_service.rb' + - 'app/services/clusters/agents/refresh_authorization_service.rb' + - 'app/services/clusters/aws/finalize_creation_service.rb' + - 'app/services/clusters/integrations/prometheus_health_check_service.rb' + - 'app/services/concerns/alert_management/alert_processing.rb' + - 'app/services/concerns/incident_management/settings.rb' + - 'app/services/concerns/issues/resolve_discussions.rb' + - 'app/services/concerns/suggestible.rb' + - 'app/services/concerns/update_repository_storage_methods.rb' + - 'app/services/container_expiration_policies/update_service.rb' + - 'app/services/dependency_proxy/image_ttl_group_policies/update_service.rb' + - 'app/services/discussions/resolve_service.rb' + - 'app/services/error_tracking/collect_error_service.rb' + - 'app/services/error_tracking/issue_details_service.rb' + - 'app/services/feature_flags/base_service.rb' + - 'app/services/git/base_hooks_service.rb' + - 'app/services/git/branch_hooks_service.rb' + - 'app/services/git/branch_push_service.rb' + - 'app/services/git/tag_hooks_service.rb' + - 'app/services/git/wiki_push_service/change.rb' + - 'app/services/groups/open_issues_count_service.rb' + - 'app/services/import/github_service.rb' + - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' + - 'app/services/incident_management/issuable_escalation_statuses/prepare_update_service.rb' + - 'app/services/incident_management/pager_duty/process_webhook_service.rb' + - 'app/services/integrations/test/project_service.rb' + - 'app/services/issuable/discussions_list_service.rb' + - 'app/services/issues/reorder_service.rb' + - 'app/services/jira_connect_subscriptions/create_service.rb' + - 'app/services/jira_import/users_mapper_service.rb' + - 'app/services/lfs/push_service.rb' + - 'app/services/markdown_content_rewriter_service.rb' + - 'app/services/members/invitation_reminder_email_service.rb' + - 'app/services/merge_requests/build_service.rb' + - 'app/services/merge_requests/merge_base_service.rb' + - 'app/services/merge_requests/mergeability/detailed_merge_status_service.rb' + - 'app/services/merge_requests/mergeability/logger.rb' + - 'app/services/merge_requests/mergeability/run_checks_service.rb' + - 'app/services/merge_requests/mergeability_check_service.rb' + - 'app/services/merge_requests/outdated_discussion_diff_lines_service.rb' + - 'app/services/merge_requests/pushed_branches_service.rb' + - 'app/services/merge_requests/refresh_service.rb' + - 'app/services/metrics/dashboard/clone_dashboard_service.rb' + - 'app/services/metrics/dashboard/custom_metric_embed_service.rb' + - 'app/services/metrics/dashboard/dynamic_embed_service.rb' + - 'app/services/metrics/dashboard/gitlab_alert_embed_service.rb' + - 'app/services/namespaces/package_settings/update_service.rb' + - 'app/services/packages/cleanup/execute_policy_service.rb' + - 'app/services/packages/cleanup/update_policy_service.rb' + - 'app/services/packages/composer/create_package_service.rb' + - 'app/services/packages/debian/extract_changes_metadata_service.rb' + - 'app/services/packages/debian/extract_metadata_service.rb' + - 'app/services/packages/debian/find_or_create_package_service.rb' + - 'app/services/packages/debian/generate_distribution_key_service.rb' + - 'app/services/packages/debian/generate_distribution_service.rb' + - 'app/services/packages/debian/process_changes_service.rb' + - 'app/services/packages/debian/process_package_file_service.rb' + - 'app/services/packages/helm/process_file_service.rb' + - 'app/services/packages/maven/metadata/base_create_xml_service.rb' + - 'app/services/packages/maven/metadata/create_plugins_xml_service.rb' + - 'app/services/packages/maven/metadata/create_versions_xml_service.rb' + - 'app/services/packages/maven/metadata/sync_service.rb' + - 'app/services/packages/npm/create_package_service.rb' + - 'app/services/packages/npm/create_tag_service.rb' + - 'app/services/packages/nuget/metadata_extraction_service.rb' + - 'app/services/packages/nuget/search_service.rb' + - 'app/services/packages/nuget/sync_metadatum_service.rb' + - 'app/services/packages/nuget/update_package_from_metadata_service.rb' + - 'app/services/packages/pypi/create_package_service.rb' + - 'app/services/packages/rpm/parse_package_service.rb' + - 'app/services/packages/rubygems/dependency_resolver_service.rb' + - 'app/services/packages/rubygems/process_gem_service.rb' + - 'app/services/packages/terraform_module/create_package_service.rb' + - 'app/services/packages/update_tags_service.rb' + - 'app/services/projects/container_repository/cleanup_tags_base_service.rb' + - 'app/services/projects/container_repository/third_party/cleanup_tags_service.rb' + - 'app/services/projects/create_from_template_service.rb' + - 'app/services/projects/gitlab_projects_import_service.rb' + - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' + - 'app/services/projects/open_issues_count_service.rb' + - 'app/services/projects/record_target_platforms_service.rb' + - 'app/services/projects/update_remote_mirror_service.rb' + - 'app/services/projects/update_statistics_service.rb' + - 'app/services/prometheus/proxy_service.rb' + - 'app/services/quick_actions/interpret_service.rb' + - 'app/services/releases/base_service.rb' + - 'app/services/resource_access_tokens/revoke_service.rb' + - 'app/services/resource_events/base_synthetic_notes_builder_service.rb' + - 'app/services/search/global_service.rb' + - 'app/services/search/project_service.rb' + - 'app/services/search_service.rb' + - 'app/services/security/ci_configuration/sast_parser_service.rb' + - 'app/services/test_hooks/project_service.rb' + - 'app/services/test_hooks/system_service.rb' + - 'app/uploaders/file_mover.rb' + - 'app/uploaders/object_storage/cdn.rb' + - 'app/uploaders/object_storage/cdn/google_cdn.rb' + - 'app/workers/concerns/each_shard_worker.rb' + - 'app/workers/concerns/limited_capacity/worker.rb' + - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' + - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' + - 'app/workers/container_registry/delete_container_repository_worker.rb' + - 'app/workers/container_registry/migration/enqueuer_worker.rb' + - 'app/workers/database/batched_background_migration/execution_worker.rb' + - 'app/workers/database/batched_background_migration/single_database_worker.rb' + - 'app/workers/error_tracking_issue_link_worker.rb' + - 'app/workers/merge_request_cleanup_refs_worker.rb' + - 'app/workers/packages/cleanup/execute_policy_worker.rb' + - 'app/workers/packages/debian/generate_distribution_worker.rb' + - 'app/workers/packages/debian/process_changes_worker.rb' + - 'app/workers/packages/maven/metadata/sync_worker.rb' + - 'app/workers/projects/inactive_projects_deletion_cron_worker.rb' + - 'ee/app/controllers/admin/audit_logs_controller.rb' + - 'ee/app/controllers/concerns/description_diff_actions.rb' + - 'ee/app/controllers/concerns/ee/lfs_request.rb' + - 'ee/app/controllers/concerns/ee/routable_actions/sso_enforcement_redirect.rb' + - 'ee/app/controllers/concerns/epic_relations.rb' + - 'ee/app/controllers/ee/admin/health_check_controller.rb' + - 'ee/app/controllers/ee/groups/settings/repository_controller.rb' + - 'ee/app/controllers/ee/groups_controller.rb' + - 'ee/app/controllers/ee/registrations/welcome_controller.rb' + - 'ee/app/controllers/ee/repositories/git_http_controller.rb' + - 'ee/app/controllers/groups/audit_events_controller.rb' + - 'ee/app/controllers/groups/epic_boards_controller.rb' + - 'ee/app/controllers/groups/push_rules_controller.rb' + - 'ee/app/controllers/groups/todos_controller.rb' + - 'ee/app/controllers/projects/audit_events_controller.rb' + - 'ee/app/controllers/projects/subscriptions_controller.rb' + - 'ee/app/controllers/subscriptions_controller.rb' + - 'ee/app/finders/approval_rules/group_finder.rb' + - 'ee/app/finders/concerns/epics/with_access_check.rb' + - 'ee/app/finders/ee/issues_finder.rb' + - 'ee/app/finders/epics_finder.rb' + - 'ee/app/finders/incident_management/oncall_users_finder.rb' + - 'ee/app/finders/requirements_management/requirements_finder.rb' + - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' + - 'ee/app/finders/security/training_providers/base_url_finder.rb' + - 'ee/app/graphql/resolvers/epics_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerabilities_base_resolver.rb' + - 'ee/app/helpers/admin/emails_helper.rb' + - 'ee/app/helpers/auditor_user_helper.rb' + - 'ee/app/helpers/billing_plans_helper.rb' + - 'ee/app/helpers/ee/ci/runners_helper.rb' + - 'ee/app/helpers/ee/preferences_helper.rb' + - 'ee/app/helpers/ee/registrations_helper.rb' + - 'ee/app/helpers/ee/timeboxes_helper.rb' + - 'ee/app/helpers/ee/trial_helper.rb' + - 'ee/app/helpers/ee/welcome_helper.rb' + - 'ee/app/helpers/license_monitoring_helper.rb' + - 'ee/app/helpers/paid_feature_callout_helper.rb' + - 'ee/app/helpers/subscriptions_helper.rb' + - 'ee/app/helpers/trial_status_widget_helper.rb' + - 'ee/app/models/approval_merge_request_rule.rb' + - 'ee/app/models/approval_state.rb' + - 'ee/app/models/approval_wrapped_any_approver_rule.rb' + - 'ee/app/models/approval_wrapped_code_owner_rule.rb' + - 'ee/app/models/approval_wrapped_rule.rb' + - 'ee/app/models/approvals/scan_finding_wrapped_rule_set.rb' + - 'ee/app/models/approvals/wrapped_rule_set.rb' + - 'ee/app/models/burndown.rb' + - 'ee/app/models/ci/minutes/limit.rb' + - 'ee/app/models/concerns/deprecated_approvals_before_merge.rb' + - 'ee/app/models/concerns/ee/approvable.rb' + - 'ee/app/models/concerns/ee/issue_available_features.rb' + - 'ee/app/models/concerns/insights_feature.rb' + - 'ee/app/models/concerns/security/scan_execution_policy.rb' + - 'ee/app/models/deployments/approval_summary.rb' + - 'ee/app/models/ee/audit_event.rb' + - 'ee/app/models/ee/ci/bridge.rb' + - 'ee/app/models/ee/ci/build.rb' + - 'ee/app/models/ee/ci/build_dependencies.rb' + - 'ee/app/models/ee/ci/job_artifact.rb' + - 'ee/app/models/ee/ci/pipeline.rb' + - 'ee/app/models/ee/ci/runner.rb' + - 'ee/app/models/ee/deployment.rb' + - 'ee/app/models/ee/environment.rb' + - 'ee/app/models/ee/group.rb' + - 'ee/app/models/ee/integrations/jira.rb' + - 'ee/app/models/ee/list.rb' + - 'ee/app/models/ee/merge_request.rb' + - 'ee/app/models/ee/namespace.rb' + - 'ee/app/models/ee/namespace/storage/notification.rb' + - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/snippet.rb' + - 'ee/app/models/ee/user.rb' + - 'ee/app/models/ee/work_item.rb' + - 'ee/app/models/gitlab/seat_link_data.rb' + - 'ee/app/models/gitlab_subscription.rb' + - 'ee/app/models/issuables_analytics.rb' + - 'ee/app/models/license.rb' + - 'ee/app/models/namespaces/storage/root_excess_size.rb' + - 'ee/app/models/sca/license_compliance.rb' + - 'ee/app/models/security/orchestration_policy_configuration.rb' + - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' + - 'ee/app/models/vulnerabilities/finding.rb' + - 'ee/app/presenters/approval_rule_presenter.rb' + - 'ee/app/presenters/ci/minutes/usage_presenter.rb' + - 'ee/app/presenters/merge_request_approver_presenter.rb' + - 'ee/app/serializers/dashboard_operations_project_entity.rb' + - 'ee/app/serializers/ee/member_user_entity.rb' + - 'ee/app/services/app_sec/dast/pipelines/find_latest_service.rb' + - 'ee/app/services/app_sec/dast/scan_configs/build_service.rb' + - 'ee/app/services/approval_rules/params_filtering_service.rb' + - 'ee/app/services/boards/epics/position_create_service.rb' + - 'ee/app/services/ci/compare_license_scanning_reports_collapsed_service.rb' + - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' + - 'ee/app/services/ci/subscribe_bridge_service.rb' + - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' + - 'ee/app/services/deployments/approval_service.rb' + - 'ee/app/services/ee/allowed_email_domains/update_service.rb' + - 'ee/app/services/ee/auto_merge_service.rb' + - 'ee/app/services/ee/boards/lists/create_service.rb' + - 'ee/app/services/ee/ci/retry_pipeline_service.rb' + - 'ee/app/services/ee/incident_management/issuable_escalation_statuses/prepare_update_service.rb' + - 'ee/app/services/ee/integrations/test/project_service.rb' + - 'ee/app/services/ee/ip_restrictions/update_service.rb' + - 'ee/app/services/ee/issuable_base_service.rb' + - 'ee/app/services/ee/issues/export_csv_service.rb' + - 'ee/app/services/ee/merge_requests/merge_base_service.rb' + - 'ee/app/services/ee/post_receive_service.rb' + - 'ee/app/services/ee/projects/create_from_template_service.rb' + - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' + - 'ee/app/services/ee/protected_branches/create_service.rb' + - 'ee/app/services/ee/search/global_service.rb' + - 'ee/app/services/ee/search/group_service.rb' + - 'ee/app/services/ee/search_service.rb' + - 'ee/app/services/ee/users/authorized_build_service.rb' + - 'ee/app/services/ee/users/build_service.rb' + - 'ee/app/services/ee/users/update_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' + - 'ee/app/services/epic_issues/list_service.rb' + - 'ee/app/services/epics/descendant_count_service.rb' + - 'ee/app/services/epics/related_epic_links/destroy_service.rb' + - 'ee/app/services/geo/container_repository_sync.rb' + - 'ee/app/services/geo/event_service.rb' + - 'ee/app/services/geo/file_registry_removal_service.rb' + - 'ee/app/services/geo/repository_destroy_service.rb' + - 'ee/app/services/gitlab_subscriptions/activate_service.rb' + - 'ee/app/services/gitlab_subscriptions/create_service.rb' + - 'ee/app/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service.rb' + - 'ee/app/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service.rb' + - 'ee/app/services/groups/sync_service.rb' + - 'ee/app/services/incident_management/escalation_policies/update_service.rb' + - 'ee/app/services/incident_management/pending_escalations/process_service.rb' + - 'ee/app/services/iterations/create_service.rb' + - 'ee/app/services/merge_commits/export_csv_service.rb' + - 'ee/app/services/merge_requests/update_blocks_service.rb' + - 'ee/app/services/projects/restore_service.rb' + - 'ee/app/services/projects/update_mirror_service.rb' + - 'ee/app/services/protected_environments/base_service.rb' + - 'ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected.rb' + - 'ee/app/services/security/report_fetch_service.rb' + - 'ee/app/services/security/report_summary_service.rb' + - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb' + - 'ee/app/services/security/security_orchestration_policies/operational_vulnerabilities_configuration_service.rb' + - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' + - 'ee/app/services/status_page/publish_attachments_service.rb' + - 'ee/app/services/status_page/publish_base_service.rb' + - 'ee/app/services/status_page/publish_service.rb' + - 'ee/app/services/status_page/trigger_publish_service.rb' + - 'ee/app/services/timebox_report_service.rb' + - 'ee/app/services/vulnerabilities/create_service.rb' + - 'ee/app/services/vulnerability_feedback/create_service.rb' + - 'ee/app/services/vulnerability_feedback/destroy_service.rb' + - 'ee/app/workers/auth/saml_group_sync_worker.rb' + - 'ee/app/workers/geo/repository_cleanup_worker.rb' + - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' + - 'ee/app/workers/group_saml_group_sync_worker.rb' + - 'ee/app/workers/status_page/publish_worker.rb' + - 'ee/lib/api/analytics/project_deployment_frequency.rb' + - 'ee/lib/api/epic_links.rb' + - 'ee/lib/api/geo_nodes.rb' + - 'ee/lib/api/vulnerability_exports.rb' + - 'ee/lib/api/vulnerability_findings.rb' + - 'ee/lib/ee/api/geo.rb' + - 'ee/lib/ee/api/helpers.rb' + - 'ee/lib/ee/banzai/filter/references/reference_cache.rb' + - 'ee/lib/ee/container_registry/client.rb' + - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' + - 'ee/lib/ee/gitlab/analytics/cycle_analytics/data_collector.rb' + - 'ee/lib/ee/gitlab/analytics/cycle_analytics/stage_events.rb' + - 'ee/lib/ee/gitlab/auth/o_auth/auth_hash.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'ee/lib/ee/gitlab/checks/base_checker.rb' + - 'ee/lib/ee/gitlab/checks/diff_check.rb' + - 'ee/lib/ee/gitlab/ci/matching/runner_matcher.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/external.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/activity.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' + - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' + - 'ee/lib/ee/gitlab/git_access.rb' + - 'ee/lib/ee/gitlab/gitaly_client/with_feature_flag_actors.rb' + - 'ee/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy.rb' + - 'ee/lib/ee/gitlab/issuable_metadata.rb' + - 'ee/lib/ee/gitlab/scim/deprovision_service.rb' + - 'ee/lib/ee/gitlab/scim/provisioning_service.rb' + - 'ee/lib/ee/gitlab/security/scan_configuration.rb' + - 'ee/lib/ee/gitlab/web_hooks/rate_limiter.rb' + - 'ee/lib/ee/sidebars/groups/menus/issues_menu.rb' + - 'ee/lib/ee/sidebars/groups/menus/settings_menu.rb' + - 'ee/lib/elastic/multi_version_util.rb' + - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' + - 'ee/lib/gitlab/auth/group_saml/membership_updater.rb' + - 'ee/lib/gitlab/auth/group_saml/user.rb' + - 'ee/lib/gitlab/auth/saml/membership_updater.rb' + - 'ee/lib/gitlab/auth/smartcard/certificate.rb' + - 'ee/lib/gitlab/ci/minutes/build_consumption.rb' + - 'ee/lib/gitlab/ci/minutes/cached_quota.rb' + - 'ee/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor.rb' + - 'ee/lib/gitlab/ci/minutes/runners_availability.rb' + - 'ee/lib/gitlab/ci/parsers/security/container_scanning.rb' + - 'ee/lib/gitlab/ci/project_config/compliance.rb' + - 'ee/lib/gitlab/ci/reports/license_scanning/reports_comparer.rb' + - 'ee/lib/gitlab/ci/reports/metrics/reports_comparer.rb' + - 'ee/lib/gitlab/code_owners/entry.rb' + - 'ee/lib/gitlab/code_owners/loader.rb' + - 'ee/lib/gitlab/custom_file_templates.rb' + - 'ee/lib/gitlab/elastic/client.rb' + - 'ee/lib/gitlab/elastic/document_reference.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'ee/lib/gitlab/elastic/project_search_results.rb' + - 'ee/lib/gitlab/elastic/search_results.rb' + - 'ee/lib/gitlab/expiring_subscription_message.rb' + - 'ee/lib/gitlab/geo.rb' + - 'ee/lib/gitlab/geo/health_check.rb' + - 'ee/lib/gitlab/geo/jwt_request_decoder.rb' + - 'ee/lib/gitlab/geo/oauth/logout_state.rb' + - 'ee/lib/gitlab/geo/oauth/logout_token.rb' + - 'ee/lib/gitlab/geo/oauth/session.rb' + - 'ee/lib/gitlab/geo/replication/blob_retriever.rb' + - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' + - 'ee/lib/gitlab/ingestion/bulk_insertable_task.rb' + - 'ee/lib/gitlab/ingestion/bulk_updatable_task.rb' + - 'ee/lib/gitlab/insights/finders/issuable_finder.rb' + - 'ee/lib/gitlab/insights/finders/projects_finder.rb' + - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' + - 'ee/lib/gitlab/return_to_location.rb' + - 'ee/lib/gitlab_subscriptions/upcoming_reconciliation_entity.rb' + - 'ee/lib/incident_management/oncall_shift_generator.rb' + - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' + - 'ee/lib/sidebars/groups/menus/epics_menu.rb' + - 'ee/lib/world.rb' + - 'lib/api/api_guard.rb' + - 'lib/api/ci/helpers/runner.rb' + - 'lib/api/ci/pipelines.rb' + - 'lib/api/commit_statuses.rb' + - 'lib/api/composer_packages.rb' + - 'lib/api/container_repositories.rb' + - 'lib/api/entities/basic_project_details.rb' + - 'lib/api/helpers/authentication.rb' + - 'lib/api/helpers/packages/basic_auth_helpers.rb' + - 'lib/api/helpers/packages/conan/api_helpers.rb' + - 'lib/api/helpers/packages/npm.rb' + - 'lib/api/helpers/packages_helpers.rb' + - 'lib/api/terraform/modules/v1/packages.rb' + - 'lib/api/unleash.rb' + - 'lib/atlassian/jira_connect/jwt/asymmetric.rb' + - 'lib/atlassian/jira_connect/jwt/symmetric.rb' + - 'lib/banzai/filter/base_sanitization_filter.rb' + - 'lib/banzai/filter/custom_emoji_filter.rb' + - 'lib/banzai/filter/inline_metrics_redactor_filter.rb' + - 'lib/banzai/filter/issuable_reference_expansion_filter.rb' + - 'lib/banzai/filter/references/reference_cache.rb' + - 'lib/banzai/filter/repository_link_filter.rb' + - 'lib/banzai/reference_parser/merge_request_parser.rb' + - 'lib/bulk_imports/clients/http.rb' + - 'lib/bulk_imports/pipeline.rb' + - 'lib/bulk_imports/users_mapper.rb' + - 'lib/container_registry/client.rb' + - 'lib/container_registry/gitlab_api_client.rb' + - 'lib/container_registry/tag.rb' + - 'lib/gitlab/alert_management/alert_status_counts.rb' + - 'lib/gitlab/alert_management/payload/base.rb' + - 'lib/gitlab/alert_management/payload/managed_prometheus.rb' + - 'lib/gitlab/analytics/cycle_analytics/aggregated/data_collector.rb' + - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' + - 'lib/gitlab/analytics/cycle_analytics/average.rb' + - 'lib/gitlab/analytics/cycle_analytics/data_collector.rb' + - 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb' + - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' + - 'lib/gitlab/application_context.rb' + - 'lib/gitlab/auth/atlassian/identity_linker.rb' + - 'lib/gitlab/auth/auth_finders.rb' + - 'lib/gitlab/auth/ip_rate_limiter.rb' + - 'lib/gitlab/auth/key_status_checker.rb' + - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' + - 'lib/gitlab/auth/request_authenticator.rb' + - 'lib/gitlab/background_migration/legacy_upload_mover.rb' + - 'lib/gitlab/bare_repository_import/repository.rb' + - 'lib/gitlab/blob_helper.rb' + - 'lib/gitlab/cache/ci/project_pipeline_status.rb' + - 'lib/gitlab/chat/command.rb' + - 'lib/gitlab/checks/changes_access.rb' + - 'lib/gitlab/checks/diff_check.rb' + - 'lib/gitlab/ci/artifacts/metrics.rb' + - 'lib/gitlab/ci/build/auto_retry.rb' + - 'lib/gitlab/ci/build/cache.rb' + - 'lib/gitlab/ci/build/context/base.rb' + - 'lib/gitlab/ci/build/context/global.rb' + - 'lib/gitlab/ci/build/prerequisite/kubernetes_namespace.rb' + - 'lib/gitlab/ci/build/rules/rule/clause/changes.rb' + - 'lib/gitlab/ci/config/entry/product/matrix.rb' + - 'lib/gitlab/ci/config/entry/root.rb' + - 'lib/gitlab/ci/config/extendable/entry.rb' + - 'lib/gitlab/ci/config/external/context.rb' + - 'lib/gitlab/ci/config/external/file/artifact.rb' + - 'lib/gitlab/ci/config/external/file/base.rb' + - 'lib/gitlab/ci/config/external/file/local.rb' + - 'lib/gitlab/ci/config/external/file/project.rb' + - 'lib/gitlab/ci/config/external/file/remote.rb' + - 'lib/gitlab/ci/config/external/file/template.rb' + - 'lib/gitlab/ci/config/normalizer.rb' + - 'lib/gitlab/ci/config/normalizer/factory.rb' + - 'lib/gitlab/ci/pipeline/chain/command.rb' + - 'lib/gitlab/ci/pipeline/chain/config/content.rb' + - 'lib/gitlab/ci/pipeline/chain/create.rb' + - 'lib/gitlab/ci/pipeline/chain/evaluate_workflow_rules.rb' + - 'lib/gitlab/ci/pipeline/chain/limit/active_jobs.rb' + - 'lib/gitlab/ci/pipeline/chain/limit/rate_limit.rb' + - 'lib/gitlab/ci/pipeline/chain/seed.rb' + - 'lib/gitlab/ci/pipeline/chain/skip.rb' + - 'lib/gitlab/ci/pipeline/expression/lexer.rb' + - 'lib/gitlab/ci/pipeline/logger.rb' + - 'lib/gitlab/ci/pipeline/metrics.rb' + - 'lib/gitlab/ci/pipeline/quota/deployments.rb' + - 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb' + - 'lib/gitlab/ci/project_config/auto_devops.rb' + - 'lib/gitlab/ci/project_config/external_project.rb' + - 'lib/gitlab/ci/project_config/parameter.rb' + - 'lib/gitlab/ci/project_config/remote.rb' + - 'lib/gitlab/ci/project_config/repository.rb' + - 'lib/gitlab/ci/project_config/source.rb' + - 'lib/gitlab/ci/queue/metrics.rb' + - 'lib/gitlab/ci/reports/accessibility_reports_comparer.rb' + - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' + - 'lib/gitlab/ci/reports/security/locations/base.rb' + - 'lib/gitlab/ci/reports/security/vulnerability_reports_comparer.rb' + - 'lib/gitlab/ci/reports/test_reports_comparer.rb' + - 'lib/gitlab/ci/reports/test_suite_comparer.rb' + - 'lib/gitlab/ci/reports/test_suite_summary.rb' + - 'lib/gitlab/ci/runner/metrics.rb' + - 'lib/gitlab/ci/status/composite.rb' + - 'lib/gitlab/ci/tags/bulk_insert.rb' + - 'lib/gitlab/ci/trace.rb' + - 'lib/gitlab/ci/trace/archive.rb' + - 'lib/gitlab/ci/trace/checksum.rb' + - 'lib/gitlab/ci/trace/metrics.rb' + - 'lib/gitlab/ci/trace/remote_checksum.rb' + - 'lib/gitlab/ci/variables/builder.rb' + - 'lib/gitlab/ci/variables/builder/group.rb' + - 'lib/gitlab/ci/variables/builder/release.rb' + - 'lib/gitlab/ci/variables/collection/item.rb' + - 'lib/gitlab/ci/variables/collection/sort.rb' + - 'lib/gitlab/cleanup/orphan_job_artifact_files.rb' + - 'lib/gitlab/cleanup/orphan_job_artifact_files_batch.rb' + - 'lib/gitlab/code_navigation_path.rb' + - 'lib/gitlab/config/entry/composable_array.rb' + - 'lib/gitlab/config/loader/yaml.rb' + - 'lib/gitlab/conflict/file.rb' + - 'lib/gitlab/database/as_with_materialized.rb' + - 'lib/gitlab/database/background_migration/health_status/indicators/write_ahead_log.rb' + - 'lib/gitlab/database/background_migration/prometheus_metrics.rb' + - 'lib/gitlab/database/bulk_update.rb' + - 'lib/gitlab/database/load_balancing/srv_resolver.rb' + - 'lib/gitlab/database/metrics.rb' + - 'lib/gitlab/database/postgres_index.rb' + - 'lib/gitlab/diff/char_diff.rb' + - 'lib/gitlab/diff/file.rb' + - 'lib/gitlab/diff/file_collection/base.rb' + - 'lib/gitlab/diff/file_collection/merge_request_diff_base.rb' + - 'lib/gitlab/diff/highlight_cache.rb' + - 'lib/gitlab/diff/lines_unfolder.rb' + - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' + - 'lib/gitlab/diff/stats_cache.rb' + - 'lib/gitlab/diff/suggestion.rb' + - 'lib/gitlab/discussions_diff/file_collection.rb' + - 'lib/gitlab/email/handler/service_desk_handler.rb' + - 'lib/gitlab/email/hook/delivery_metrics_observer.rb' + - 'lib/gitlab/email/receiver.rb' + - 'lib/gitlab/external_authorization/response.rb' + - 'lib/gitlab/gfm/reference_rewriter.rb' + - 'lib/gitlab/gfm/uploads_rewriter.rb' + - 'lib/gitlab/git/commit.rb' + - 'lib/gitlab/git/diff_stats_collection.rb' + - 'lib/gitlab/git/merge_base.rb' + - 'lib/gitlab/git/push.rb' + - 'lib/gitlab/git/repository.rb' + - 'lib/gitlab/git/wiki_page_version.rb' + - 'lib/gitlab/git_access.rb' + - 'lib/gitlab/git_access_project.rb' + - 'lib/gitlab/gitaly_client/with_feature_flag_actors.rb' + - 'lib/gitlab/github_import/client.rb' + - 'lib/gitlab/github_import/importer/repository_importer.rb' + - 'lib/gitlab/github_import/representation/diff_note.rb' + - 'lib/gitlab/github_import/representation/diff_notes/suggestion_formatter.rb' + - 'lib/gitlab/gl_repository/identifier.rb' + - 'lib/gitlab/gpg/commit.rb' + - 'lib/gitlab/graphql/lazy.rb' + - 'lib/gitlab/graphql/pagination/keyset/connection.rb' + - 'lib/gitlab/import_export/base/relation_factory.rb' + - 'lib/gitlab/import_export/base/relation_object_saver.rb' + - 'lib/gitlab/import_export/decompressed_archive_size_validator.rb' + - 'lib/gitlab/import_export/fast_hash_serializer.rb' + - 'lib/gitlab/import_export/group/legacy_tree_restorer.rb' + - 'lib/gitlab/import_export/group/tree_restorer.rb' + - 'lib/gitlab/import_export/importer.rb' + - 'lib/gitlab/import_export/json/legacy_reader.rb' + - 'lib/gitlab/import_export/lfs_restorer.rb' + - 'lib/gitlab/import_export/project/sample/date_calculator.rb' + - 'lib/gitlab/import_export/project/tree_restorer.rb' + - 'lib/gitlab/inactive_projects_deletion_warning_tracker.rb' + - 'lib/gitlab/instrumentation/redis_base.rb' + - 'lib/gitlab/instrumentation/redis_payload.rb' + - 'lib/gitlab/issuable_metadata.rb' + - 'lib/gitlab/jwt_authenticatable.rb' + - 'lib/gitlab/kubernetes/deployment.rb' + - 'lib/gitlab/kubernetes/ingress.rb' + - 'lib/gitlab/kubernetes/rollout_instances.rb' + - 'lib/gitlab/language_data.rb' + - 'lib/gitlab/lets_encrypt/client.rb' + - 'lib/gitlab/metrics/dashboard/stages/grafana_formatter.rb' + - 'lib/gitlab/metrics/dashboard/url.rb' + - 'lib/gitlab/metrics/prometheus.rb' + - 'lib/gitlab/metrics/subscribers/active_record.rb' + - 'lib/gitlab/pages/cache_control.rb' + - 'lib/gitlab/prometheus_client.rb' + - 'lib/gitlab/rack_attack/request.rb' + - 'lib/gitlab/redis/multi_store.rb' + - 'lib/gitlab/relative_positioning/ending_at.rb' + - 'lib/gitlab/relative_positioning/item_context.rb' + - 'lib/gitlab/relative_positioning/starting_from.rb' + - 'lib/gitlab/request_context.rb' + - 'lib/gitlab/search/found_blob.rb' + - 'lib/gitlab/search/parsed_query.rb' + - 'lib/gitlab/serverless/service.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' + - 'lib/gitlab/sidekiq_queue.rb' + - 'lib/gitlab/signed_commit.rb' + - 'lib/gitlab/ssh/signature.rb' + - 'lib/gitlab/suggestions/file_suggestion.rb' + - 'lib/gitlab/task_helpers.rb' + - 'lib/gitlab/template/gitlab_ci_yml_template.rb' + - 'lib/gitlab/tracking/destinations/snowplow_micro.rb' + - 'lib/gitlab/usage_data.rb' + - 'lib/gitlab/web_hooks/rate_limiter.rb' + - 'lib/gitlab/web_ide/config/entry/terminal.rb' + - 'lib/gitlab/webpack/graphql_known_operations.rb' + - 'lib/gitlab/webpack/manifest.rb' + - 'lib/gitlab/wiki_pages/front_matter_parser.rb' + - 'lib/gitlab/x509/certificate.rb' + - 'lib/gitlab/x509/signature.rb' + - 'lib/gitlab/x509/tag.rb' + - 'lib/grafana/time_window.rb' + - 'lib/object_storage/direct_upload.rb' + - 'lib/safe_zip/extract_params.rb' + - 'lib/sidebars/groups/menus/issues_menu.rb' + - 'lib/sidebars/groups/menus/merge_requests_menu.rb' + - 'lib/sidebars/projects/menus/analytics_menu.rb' + - 'lib/sidebars/projects/menus/issues_menu.rb' + - 'lib/sidebars/projects/menus/learn_gitlab_menu.rb' + - 'lib/unnested_in_filters/rewriter.rb' + - 'tooling/graphql/docs/helper.rb' diff --git a/.rubocop_todo/graphql/argument_uniqueness.yml b/.rubocop_todo/graphql/argument_uniqueness.yml index 036d5d8ecdb..8a1fb31af62 100644 --- a/.rubocop_todo/graphql/argument_uniqueness.yml +++ b/.rubocop_todo/graphql/argument_uniqueness.yml @@ -1,4 +1,4 @@ --- GraphQL/ArgumentUniqueness: Exclude: - - app/graphql/resolvers/merge_requests_resolver.rb + - 'app/graphql/resolvers/merge_requests_resolver.rb' diff --git a/.rubocop_todo/graphql/descriptions.yml b/.rubocop_todo/graphql/descriptions.yml new file mode 100644 index 00000000000..9d76d7d7638 --- /dev/null +++ b/.rubocop_todo/graphql/descriptions.yml @@ -0,0 +1,98 @@ +--- +# Cop supports --autocorrect. +Graphql/Descriptions: + Safe: false + Details: grace period + Exclude: + - 'app/graphql/mutations/boards/lists/base_update.rb' + - 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb' + - 'app/graphql/mutations/clusters/agents/create.rb' + - 'app/graphql/mutations/merge_requests/accept.rb' + - 'app/graphql/mutations/notes/create/note.rb' + - 'app/graphql/mutations/releases/create.rb' + - 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb' + - 'app/graphql/resolvers/alert_management/alert_resolver.rb' + - 'app/graphql/resolvers/concerns/issues/sort_arguments.rb' + - 'app/graphql/resolvers/concerns/resolves_pipelines.rb' + - 'app/graphql/resolvers/container_repositories_resolver.rb' + - 'app/graphql/resolvers/design_management/design_at_version_resolver.rb' + - 'app/graphql/resolvers/group_packages_resolver.rb' + - 'app/graphql/resolvers/issues/base_parent_resolver.rb' + - 'app/graphql/resolvers/issues/base_resolver.rb' + - 'app/graphql/resolvers/issues_resolver.rb' + - 'app/graphql/resolvers/merge_requests_resolver.rb' + - 'app/graphql/resolvers/milestones_resolver.rb' + - 'app/graphql/resolvers/namespace_projects_resolver.rb' + - 'app/graphql/resolvers/packages_base_resolver.rb' + - 'app/graphql/resolvers/releases_resolver.rb' + - 'app/graphql/resolvers/users_resolver.rb' + - 'app/graphql/resolvers/work_items_resolver.rb' + - 'app/graphql/types/alert_management/alert_type.rb' + - 'app/graphql/types/award_emojis/award_emoji_type.rb' + - 'app/graphql/types/board_list_type.rb' + - 'app/graphql/types/branch_protections/base_access_level_type.rb' + - 'app/graphql/types/branch_rules/branch_protection_type.rb' + - 'app/graphql/types/ci/job_token_scope_type.rb' + - 'app/graphql/types/ci/pipeline_type.rb' + - 'app/graphql/types/ci/runner_status_enum.rb' + - 'app/graphql/types/ci/runner_type.rb' + - 'app/graphql/types/ci/runner_web_url_edge.rb' + - 'app/graphql/types/ci/status_action_type.rb' + - 'app/graphql/types/clusters/agent_token_type.rb' + - 'app/graphql/types/clusters/agent_type.rb' + - 'app/graphql/types/container_expiration_policy_type.rb' + - 'app/graphql/types/container_repository_tag_type.rb' + - 'app/graphql/types/container_repository_type.rb' + - 'app/graphql/types/deployment_tag_type.rb' + - 'app/graphql/types/design_management/design_at_version_type.rb' + - 'app/graphql/types/design_management/design_fields.rb' + - 'app/graphql/types/diff_stats_type.rb' + - 'app/graphql/types/event_type.rb' + - 'app/graphql/types/group_type.rb' + - 'app/graphql/types/issue_type.rb' + - 'app/graphql/types/issues/negated_issue_filter_input_type.rb' + - 'app/graphql/types/label_type.rb' + - 'app/graphql/types/merge_request_type.rb' + - 'app/graphql/types/merge_requests/interacts_with_merge_request.rb' + - 'app/graphql/types/milestone_sort_enum.rb' + - 'app/graphql/types/milestone_type.rb' + - 'app/graphql/types/namespace/package_settings_type.rb' + - 'app/graphql/types/notes/discussion_type.rb' + - 'app/graphql/types/notes/note_type.rb' + - 'app/graphql/types/notes/noteable_interface.rb' + - 'app/graphql/types/packages/cleanup/policy_type.rb' + - 'app/graphql/types/packages/package_details_type.rb' + - 'app/graphql/types/project_type.rb' + - 'app/graphql/types/projects/branch_rule_type.rb' + - 'app/graphql/types/release_links_type.rb' + - 'app/graphql/types/repository/blob_type.rb' + - 'app/graphql/types/snippet_type.rb' + - 'app/graphql/types/terraform/state_version_type.rb' + - 'app/graphql/types/todo_type.rb' + - 'app/graphql/types/todoable_interface.rb' + - 'app/graphql/types/user_interface.rb' + - 'app/graphql/types/user_merge_request_interaction_type.rb' + - 'ee/app/graphql/ee/types/branch_protections/base_access_level_type.rb' + - 'ee/app/graphql/ee/types/branch_rules/branch_protection_type.rb' + - 'ee/app/graphql/ee/types/issue_type.rb' + - 'ee/app/graphql/ee/types/merge_request_type.rb' + - 'ee/app/graphql/ee/types/projects/branch_rule_type.rb' + - 'ee/app/graphql/ee/types/user_merge_request_interaction_type.rb' + - 'ee/app/graphql/resolvers/epics_resolver.rb' + - 'ee/app/graphql/types/access_levels/user_type.rb' + - 'ee/app/graphql/types/boards/epic_list_type.rb' + - 'ee/app/graphql/types/branch_rules/approval_project_rule_type.rb' + - 'ee/app/graphql/types/burnup_chart_daily_totals_type.rb' + - 'ee/app/graphql/types/ci/namespace_ci_cd_setting_type.rb' + - 'ee/app/graphql/types/compliance_management/compliance_framework_input_type.rb' + - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_input_type.rb' + - 'ee/app/graphql/types/epic_descendant_weight_sum_type.rb' + - 'ee/app/graphql/types/epic_type.rb' + - 'ee/app/graphql/types/geo/geo_node_type.rb' + - 'ee/app/graphql/types/iterations/cadence_type.rb' + - 'ee/app/graphql/types/network_policy_type.rb' + - 'ee/app/graphql/types/path_lock_type.rb' + - 'ee/app/graphql/types/security_orchestration/group_security_policy_source_type.rb' + - 'ee/app/graphql/types/security_orchestration/orchestration_policy_type.rb' + - 'ee/app/graphql/types/vulnerability_type.rb' + - 'ee/app/graphql/types/vulnerable_projects_by_grade_type.rb' diff --git a/.rubocop_todo/graphql/field_definitions.yml b/.rubocop_todo/graphql/field_definitions.yml index 0e2399ba243..fa230afc8d0 100644 --- a/.rubocop_todo/graphql/field_definitions.yml +++ b/.rubocop_todo/graphql/field_definitions.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. GraphQL/FieldDefinitions: Exclude: - - ee/app/graphql/types/vulnerability_type.rb + - 'ee/app/graphql/types/vulnerability_type.rb' diff --git a/.rubocop_todo/graphql/field_hash_key.yml b/.rubocop_todo/graphql/field_hash_key.yml index 806920e24f6..13460170c07 100644 --- a/.rubocop_todo/graphql/field_hash_key.yml +++ b/.rubocop_todo/graphql/field_hash_key.yml @@ -1,7 +1,5 @@ --- +# Cop supports --autocorrect. GraphQL/FieldHashKey: Exclude: - - app/graphql/types/ci/config/job_type.rb - - app/graphql/types/ci/status_action_type.rb - - app/graphql/types/error_tracking/sentry_error_stack_trace_entry_type.rb - - app/graphql/types/packages/helm/dependency_type.rb + - 'app/graphql/types/error_tracking/sentry_error_stack_trace_entry_type.rb' diff --git a/.rubocop_todo/graphql/field_method.yml b/.rubocop_todo/graphql/field_method.yml index 6a05b3c23b8..f9e9f46e7d6 100644 --- a/.rubocop_todo/graphql/field_method.yml +++ b/.rubocop_todo/graphql/field_method.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. GraphQL/FieldMethod: Exclude: - - app/graphql/types/packages/package_details_type.rb + - 'app/graphql/types/packages/package_details_type.rb' diff --git a/.rubocop_todo/graphql/ordered_fields.yml b/.rubocop_todo/graphql/ordered_fields.yml deleted file mode 100644 index b7135d7aabb..00000000000 --- a/.rubocop_todo/graphql/ordered_fields.yml +++ /dev/null @@ -1,12 +0,0 @@ ---- -GraphQL/OrderedFields: - Exclude: - - app/graphql/types/ci/runner_type.rb - - app/graphql/types/container_repository_type.rb - - app/graphql/types/dependency_proxy/manifest_type.rb - - app/graphql/types/merge_request_type.rb - - app/graphql/types/project_statistics_type.rb - - app/graphql/types/release_type.rb - - app/graphql/types/root_storage_statistics_type.rb - - ee/app/graphql/types/scan_type.rb - - ee/app/graphql/types/timebox_report_type.rb diff --git a/.rubocop_todo/graphql/resolver_method_length.yml b/.rubocop_todo/graphql/resolver_method_length.yml index e2183bb0894..f27246096a7 100644 --- a/.rubocop_todo/graphql/resolver_method_length.yml +++ b/.rubocop_todo/graphql/resolver_method_length.yml @@ -1,6 +1,6 @@ --- GraphQL/ResolverMethodLength: Exclude: - - app/graphql/types/ci/detailed_status_type.rb - - app/graphql/types/ci/runner_type.rb - - app/graphql/types/ci/stage_type.rb
\ No newline at end of file + - 'app/graphql/types/ci/detailed_status_type.rb' + - 'app/graphql/types/ci/runner_type.rb' + - 'app/graphql/types/ci/stage_type.rb' diff --git a/.rubocop_todo/graphql/unused_argument.yml b/.rubocop_todo/graphql/unused_argument.yml index c55d8551591..d03c6799471 100644 --- a/.rubocop_todo/graphql/unused_argument.yml +++ b/.rubocop_todo/graphql/unused_argument.yml @@ -1,5 +1,6 @@ --- +# Cop supports --autocorrect. GraphQL/UnusedArgument: Exclude: - - app/graphql/mutations/jira_import/start.rb - - app/graphql/resolvers/packages_base_resolver.rb + - 'app/graphql/mutations/jira_import/start.rb' + - 'app/graphql/resolvers/packages_base_resolver.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 4b5fb5ad1a6..98633709bee 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -1,49 +1,66 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/ArgumentAlignment: - # Offense count: 2502 + # Offense count: 4159 # Temporarily disabled due to too many offenses Enabled: false Exclude: + - 'app/controllers/admin/cohorts_controller.rb' + - 'app/controllers/admin/dev_ops_report_controller.rb' + - 'app/controllers/admin/usage_trends_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' + - 'app/controllers/concerns/import/github_oauth.rb' - 'app/controllers/concerns/notes_actions.rb' - 'app/controllers/concerns/page_limiter.rb' + - 'app/controllers/concerns/sends_blob.rb' - 'app/controllers/concerns/snippets_actions.rb' - 'app/controllers/concerns/wiki_actions.rb' - 'app/controllers/groups_controller.rb' + - 'app/controllers/ide_controller.rb' - 'app/controllers/import/gitea_controller.rb' - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_groups_controller.rb' + - 'app/controllers/oauth/authorizations_controller.rb' - 'app/controllers/passwords_controller.rb' - 'app/controllers/profiles_controller.rb' - 'app/controllers/projects/branches_controller.rb' + - 'app/controllers/projects/cycle_analytics_controller.rb' + - 'app/controllers/projects/graphs_controller.rb' - 'app/controllers/projects/jobs_controller.rb' - 'app/controllers/projects/merge_requests/creations_controller.rb' - 'app/controllers/projects/pages_domains_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' + - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/uploads_controller.rb' - 'app/controllers/projects/web_ide_terminals_controller.rb' - - 'app/controllers/projects_controller.rb' - 'app/controllers/registrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' + - 'app/controllers/search_controller.rb' - 'app/controllers/sessions_controller.rb' + - 'app/finders/context_commits_finder.rb' + - 'app/finders/deployments_finder.rb' - 'app/finders/issues_finder.rb' - 'app/finders/projects/prometheus/alerts_finder.rb' + - 'app/graphql/mutations/award_emojis/toggle.rb' - 'app/graphql/mutations/boards/destroy.rb' - 'app/graphql/mutations/boards/lists/base_update.rb' - 'app/graphql/mutations/boards/lists/destroy.rb' - 'app/graphql/mutations/boards/lists/update.rb' - - 'app/graphql/mutations/ci/ci_cd_settings_update.rb' - 'app/graphql/mutations/ci/job_token_scope/add_project.rb' - 'app/graphql/mutations/ci/job_token_scope/remove_project.rb' - 'app/graphql/mutations/ci/pipeline/base.rb' + - 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb' + - 'app/graphql/mutations/ci/runner/update.rb' - 'app/graphql/mutations/ci/runners_registration_token/reset.rb' + - 'app/graphql/mutations/concerns/mutations/work_items/widgetable.rb' - 'app/graphql/mutations/customer_relations/contacts/update.rb' - 'app/graphql/mutations/customer_relations/organizations/update.rb' - 'app/graphql/mutations/dependency_proxy/group_settings/update.rb' - 'app/graphql/mutations/dependency_proxy/image_ttl_group_policy/update.rb' + - 'app/graphql/mutations/design_management/move.rb' - 'app/graphql/mutations/discussions/toggle_resolve.rb' + - 'app/graphql/mutations/issues/set_severity.rb' - 'app/graphql/mutations/metrics/dashboard/annotations/create.rb' - 'app/graphql/mutations/metrics/dashboard/annotations/delete.rb' - 'app/graphql/mutations/namespace/package_settings/update.rb' @@ -52,18 +69,24 @@ Layout/ArgumentAlignment: - 'app/graphql/mutations/notes/create/image_diff_note.rb' - 'app/graphql/mutations/notes/create/note.rb' - 'app/graphql/mutations/notes/reposition_image_diff_note.rb' + - 'app/graphql/mutations/packages/cleanup/policy/update.rb' + - 'app/graphql/mutations/packages/destroy_files.rb' + - 'app/graphql/mutations/pages/base.rb' + - 'app/graphql/mutations/pages/mark_onboarding_complete.rb' + - 'app/graphql/mutations/security/ci_configuration/base_security_analyzer.rb' - 'app/graphql/mutations/security/ci_configuration/configure_sast.rb' - 'app/graphql/mutations/terraform/state/base.rb' - 'app/graphql/mutations/user_callouts/create.rb' - 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb' - 'app/graphql/resolvers/alert_management/alert_resolver.rb' - 'app/graphql/resolvers/alert_management/alert_status_counts_resolver.rb' - - 'app/graphql/resolvers/base_issues_resolver.rb' + - 'app/graphql/resolvers/ci/all_jobs_resolver.rb' - 'app/graphql/resolvers/ci/jobs_resolver.rb' - 'app/graphql/resolvers/ci/project_pipeline_counts_resolver.rb' - 'app/graphql/resolvers/ci/test_suite_resolver.rb' - 'app/graphql/resolvers/clusters/agents_resolver.rb' - 'app/graphql/resolvers/concerns/group_issuable_resolver.rb' + - 'app/graphql/resolvers/concerns/issues/sort_arguments.rb' - 'app/graphql/resolvers/concerns/search_arguments.rb' - 'app/graphql/resolvers/container_repositories_resolver.rb' - 'app/graphql/resolvers/container_repository_tags_resolver.rb' @@ -73,6 +96,9 @@ Layout/ArgumentAlignment: - 'app/graphql/resolvers/error_tracking/sentry_errors_resolver.rb' - 'app/graphql/resolvers/group_members_resolver.rb' - 'app/graphql/resolvers/group_packages_resolver.rb' + - 'app/graphql/resolvers/issues/base_parent_resolver.rb' + - 'app/graphql/resolvers/issues/base_resolver.rb' + - 'app/graphql/resolvers/issues_resolver.rb' - 'app/graphql/resolvers/members_resolver.rb' - 'app/graphql/resolvers/namespace_projects_resolver.rb' - 'app/graphql/resolvers/package_details_resolver.rb' @@ -80,6 +106,7 @@ Layout/ArgumentAlignment: - 'app/graphql/resolvers/paginated_tree_resolver.rb' - 'app/graphql/resolvers/project_jobs_resolver.rb' - 'app/graphql/resolvers/project_members_resolver.rb' + - 'app/graphql/resolvers/projects/fork_targets_resolver.rb' - 'app/graphql/resolvers/projects/snippets_resolver.rb' - 'app/graphql/resolvers/release_resolver.rb' - 'app/graphql/resolvers/repository_branch_names_resolver.rb' @@ -88,17 +115,40 @@ Layout/ArgumentAlignment: - 'app/graphql/resolvers/tree_resolver.rb' - 'app/graphql/resolvers/users_resolver.rb' - 'app/graphql/subscriptions/issuable_updated.rb' + - 'app/graphql/types/alert_management/domain_filter_enum.rb' + - 'app/graphql/types/ci/group_variable_connection_type.rb' + - 'app/graphql/types/ci/project_variable_connection_type.rb' - 'app/graphql/types/ci_configuration/sast/analyzers_entity_input_type.rb' - 'app/graphql/types/ci_configuration/sast/input_type.rb' + - 'app/graphql/types/commit_signature_interface.rb' + - 'app/graphql/types/commit_signatures/gpg_signature_type.rb' + - 'app/graphql/types/commit_signatures/ssh_signature_type.rb' + - 'app/graphql/types/commit_signatures/x509_signature_type.rb' + - 'app/graphql/types/customer_relations/contact_sort_enum.rb' + - 'app/graphql/types/customer_relations/organization_sort_enum.rb' + - 'app/graphql/types/deployment_type.rb' + - 'app/graphql/types/environment_type.rb' - 'app/graphql/types/error_tracking/sentry_error_frequency_type.rb' - 'app/graphql/types/error_tracking/sentry_error_tags_type.rb' - 'app/graphql/types/issues/negated_issue_filter_input_type.rb' + - 'app/graphql/types/limited_countable_connection_type.rb' - 'app/graphql/types/merge_request_state_event_enum.rb' + - 'app/graphql/types/namespace/package_settings_type.rb' + - 'app/graphql/types/packages/package_base_type.rb' + - 'app/graphql/types/permission_types/group_enum.rb' - 'app/graphql/types/project_type.rb' - 'app/graphql/types/release_asset_link_shared_input_arguments.rb' - 'app/graphql/types/saved_reply_type.rb' + - 'app/graphql/types/upload_type.rb' - 'app/graphql/types/user_preferences_type.rb' - - 'app/helpers/application_helper.rb' + - 'app/graphql/types/work_items/widget_interface.rb' + - 'app/graphql/types/work_items/widgets/assignees_input_type.rb' + - 'app/graphql/types/work_items/widgets/assignees_type.rb' + - 'app/graphql/types/work_items/widgets/hierarchy_type.rb' + - 'app/graphql/types/work_items/widgets/labels_type.rb' + - 'app/graphql/types/work_items/widgets/start_and_due_date_type.rb' + - 'app/graphql/types/x509_certificate_type.rb' + - 'app/graphql/types/x509_issuer_type.rb' - 'app/helpers/blob_helper.rb' - 'app/helpers/button_helper.rb' - 'app/helpers/ci/status_helper.rb' @@ -107,6 +157,8 @@ Layout/ArgumentAlignment: - 'app/helpers/members_helper.rb' - 'app/helpers/notes_helper.rb' - 'app/helpers/repository_languages_helper.rb' + - 'app/helpers/snippets_helper.rb' + - 'app/helpers/todos_helper.rb' - 'app/helpers/wiki_helper.rb' - 'app/models/alert_management/http_integration.rb' - 'app/models/alerting/project_alerting_setting.rb' @@ -121,6 +173,7 @@ Layout/ArgumentAlignment: - 'app/models/ci/processable.rb' - 'app/models/ci/resource_group.rb' - 'app/models/ci/runner.rb' + - 'app/models/ci/stage.rb' - 'app/models/ci_platform_metric.rb' - 'app/models/clusters/agent.rb' - 'app/models/clusters/applications/helm.rb' @@ -136,8 +189,9 @@ Layout/ArgumentAlignment: - 'app/models/concerns/bulk_insert_safe.rb' - 'app/models/concerns/ci/has_variable.rb' - 'app/models/concerns/ci/new_has_variable.rb' + - 'app/models/concerns/ci/partitionable.rb' - 'app/models/concerns/each_batch.rb' - - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' + - 'app/models/concerns/integrations/slack_mattermost_notifier.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/merge_request_reviewer_state.rb' - 'app/models/concerns/nullify_if_blank.rb' @@ -147,6 +201,7 @@ Layout/ArgumentAlignment: - 'app/models/concerns/packages/debian/distribution_key.rb' - 'app/models/concerns/repository_storage_movable.rb' - 'app/models/concerns/storage/legacy_namespace.rb' + - 'app/models/concerns/taskable.rb' - 'app/models/concerns/with_uploads.rb' - 'app/models/custom_emoji.rb' - 'app/models/deploy_token.rb' @@ -159,10 +214,34 @@ Layout/ArgumentAlignment: - 'app/models/gpg_key_subkey.rb' - 'app/models/grafana_integration.rb' - 'app/models/group.rb' + - 'app/models/hooks/web_hook.rb' - 'app/models/incident_management/project_incident_management_setting.rb' + - 'app/models/incident_management/timeline_event.rb' + - 'app/models/incident_management/timeline_event_tag.rb' + - 'app/models/integrations/asana.rb' + - 'app/models/integrations/assembla.rb' - 'app/models/integrations/bamboo.rb' - - 'app/models/integrations/jira.rb' + - 'app/models/integrations/buildkite.rb' + - 'app/models/integrations/campfire.rb' + - 'app/models/integrations/confluence.rb' + - 'app/models/integrations/datadog.rb' + - 'app/models/integrations/discord.rb' + - 'app/models/integrations/drone_ci.rb' + - 'app/models/integrations/emails_on_push.rb' + - 'app/models/integrations/external_wiki.rb' + - 'app/models/integrations/flowdock.rb' + - 'app/models/integrations/harbor.rb' + - 'app/models/integrations/irker.rb' + - 'app/models/integrations/jenkins.rb' + - 'app/models/integrations/mock_ci.rb' + - 'app/models/integrations/packagist.rb' + - 'app/models/integrations/pipelines_email.rb' + - 'app/models/integrations/pivotaltracker.rb' + - 'app/models/integrations/prometheus.rb' + - 'app/models/integrations/pushover.rb' + - 'app/models/integrations/shimo.rb' - 'app/models/integrations/teamcity.rb' + - 'app/models/integrations/zentao.rb' - 'app/models/issue.rb' - 'app/models/key.rb' - 'app/models/lfs_object.rb' @@ -187,6 +266,8 @@ Layout/ArgumentAlignment: - 'app/models/project_ci_cd_setting.rb' - 'app/models/project_feature.rb' - 'app/models/project_metrics_setting.rb' + - 'app/models/projects/import_export/relation_export.rb' + - 'app/models/projects/import_export/relation_export_upload.rb' - 'app/models/redirect_route.rb' - 'app/models/route.rb' - 'app/models/serverless/domain_cluster.rb' @@ -197,14 +278,18 @@ Layout/ArgumentAlignment: - 'app/models/users/saved_reply.rb' - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/gitlab/blame_presenter.rb' + - 'app/presenters/key_presenter.rb' - 'app/presenters/label_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' - 'app/serializers/build_details_entity.rb' + - 'app/serializers/detailed_status_entity.rb' - 'app/serializers/diffs_entity.rb' - 'app/serializers/environment_entity.rb' - 'app/serializers/error_tracking/error_entity.rb' - 'app/serializers/stage_entity.rb' + - 'app/serializers/test_suite_entity.rb' + - 'app/serializers/test_suite_summary_entity.rb' - 'app/serializers/triggered_pipeline_entity.rb' - 'app/services/ci/archive_trace_service.rb' - 'app/services/ci/job_artifacts/create_service.rb' @@ -218,18 +303,27 @@ Layout/ArgumentAlignment: - 'app/services/gravatar_service.rb' - 'app/services/issues/clone_service.rb' - 'app/services/jira/requests/base.rb' + - 'app/services/members/creator_service.rb' + - 'app/services/merge_requests/create_pipeline_service.rb' - 'app/services/merge_requests/merge_to_ref_service.rb' - 'app/services/metrics/dashboard/update_dashboard_service.rb' + - 'app/services/notification_service.rb' - 'app/services/packages/conan/create_package_service.rb' - 'app/services/packages/create_temporary_package_service.rb' - 'app/services/packages/go/create_package_service.rb' - 'app/services/packages/maven/create_package_service.rb' - 'app/services/prometheus/proxy_variable_substitution_service.rb' + - 'app/services/protected_branches/api_service.rb' + - 'app/services/quick_actions/interpret_service.rb' - 'app/services/web_hook_service.rb' - 'app/services/webauthn/authenticate_service.rb' - 'app/uploaders/object_storage.rb' + - 'app/workers/bulk_imports/entity_worker.rb' + - 'app/workers/bulk_imports/export_request_worker.rb' + - 'app/workers/bulk_imports/pipeline_worker.rb' - 'app/workers/run_pipeline_schedule_worker.rb' - 'config/application.rb' + - 'config/initializers/sawyer_patch.rb' - 'config/initializers/zz_metrics.rb' - 'config/routes.rb' - 'config/routes/legacy_builds.rb' @@ -262,6 +356,47 @@ Layout/ArgumentAlignment: - 'db/migrate/20211109101010_support_partition_query_in_loose_fk_table.rb' - 'db/migrate/20220119170426_remove_temporary_vulnerability_occurrences_deduplication_index.rb' - 'db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb' + - 'db/migrate/20220401071609_add_campaign_to_in_product_marketing_email.rb' + - 'db/migrate/20220401110443_add_on_hold_until_column_for_batched_migration.rb' + - 'db/migrate/20220404170446_add_index_for_non_requested_non_invited_awaiting_members.rb' + - 'db/migrate/20220406113217_add_inactive_project_deletion_to_application_settings.rb' + - 'db/migrate/20220408135815_update_index_on_greated_done_at_on_container_repositories.rb' + - 'db/migrate/20220422220507_remove_tmp_index_supporting_leaky_regex_cleanup.rb' + - 'db/migrate/20220505092254_add_allow_stale_runner_pruning_index_to_namespace_ci_cd_settings.rb' + - 'db/migrate/20220512020500_index_batched_migrations_on_gitlab_schema_and_configuration.rb' + - 'db/migrate/20220513093614_add_ding_talk_into_application_settings.rb' + - 'db/migrate/20220516054002_temp_index_for_project_namespace_member_backfill.rb' + - 'db/migrate/20220601223501_add_vulnerability_related_columns.rb' + - 'db/migrate/20220608074738_add_max_repository_downloads_limit_to_application_settings.rb' + - 'db/migrate/20220613054349_add_unique_project_download_limit_settings_to_namespace_settings.rb' + - 'db/migrate/20220616182015_create_sbom_component_versions.rb' + - 'db/migrate/20220616183240_add_sbom_component_versions_foreign_key_to_sbom_occurrences.rb' + - 'db/migrate/20220627061008_add_fei_shu_integration.rb' + - 'db/migrate/20220627122230_add_foreign_keys_to_user_namespace_callouts.rb' + - 'db/migrate/20220627171538_add_error_tracking_settings.rb' + - 'db/migrate/20220704034050_add_users_allowlist_to_git_rate_limits.rb' + - 'db/migrate/20220708150315_add_vulnerabilities_foreign_key_to_vulnerability_merge_request_links.rb' + - 'db/migrate/20220718083945_add_unique_project_download_limit_allowlist_to_namespace_settings.rb' + - 'db/migrate/20220726025516_add_namespace_settings_unique_project_download_limit_allowlist_size_constraint.rb' + - 'db/migrate/20220726154015_add_component_foreign_key_to_sbom_occurrences.rb' + - 'db/migrate/20220726230052_remove_tmp_index_project_membership_namespace_id_column.rb' + - 'db/migrate/20220803004853_add_auto_ban_user_to_namespace_settings.rb' + - 'db/migrate/20220803235114_add_auto_ban_user_to_application_settings.rb' + - 'db/migrate/20220805154101_add_allow_run_pipelines_in_the_parent_project_setting.rb' + - 'db/migrate/20220907115806_add_security_orchestration_policy_configuration_id.rb' + - 'db/migrate/20220915140802_create_merge_request_predictions.rb' + - 'db/migrate/20220921201347_add_maven_package_requests_forwarding_to_namespace_package_settings.rb' + - 'db/migrate/20220928201920_create_project_wiki_repository_states.rb' + - 'db/migrate/20220929171925_add_pypi_package_requests_forwarding_to_namespace_package_settings.rb' + - 'db/migrate/20220929172356_add_npm_package_requests_forwarding_to_namespace_package_settings.rb' + - 'db/migrate/20221005094926_create_incident_management_timeline_event_tag_links.rb' + - 'db/migrate/20221005103010_add_index_project_id_on_scan_finding_approval_project_rules.rb' + - 'db/migrate/20221011162637_add_partial_index_project_incident_management_settings_on_project_id_and_sla_timer.rb' + - 'db/migrate/20221018202524_create_dependency_proxy_blob_states.rb' + - 'db/migrate/20221102150737_index_environments_for_name_search_within_folder.rb' + - 'db/migrate/20221102195642_create_dependency_proxy_manifest_states.rb' + - 'db/migrate/20221108185442_add_project_wiki_repository_id_to_project_wiki_repository_states.rb' + - 'db/migrate/20221110150942_add_project_id_lower_name_index_remove_old_index.rb' - 'db/post_migrate/20210330130420_drop_finding_fingerprint_table.rb' - 'db/post_migrate/20210413130011_add_partitioned_web_hook_log_fk.rb' - 'db/post_migrate/20210415101228_backfill_ci_build_needs_for_bigint_conversion.rb' @@ -271,7 +406,6 @@ Layout/ArgumentAlignment: - 'db/post_migrate/20210701033622_finalize_ci_builds_needs_bigint_conversion.rb' - 'db/post_migrate/20210706212710_finalize_ci_job_artifacts_bigint_conversion.rb' - 'db/post_migrate/20210713042153_finalize_ci_sources_pipelines_bigint_conversion.rb' - - 'db/post_migrate/20210804151444_prepare_indexes_for_ci_job_artifact_bigint_conversion.rb' - 'db/post_migrate/20210804153307_prepare_indexes_for_tagging_bigint_conversion.rb' - 'db/post_migrate/20210809143931_finalize_job_id_conversion_to_bigint_for_ci_job_artifacts.rb' - 'db/post_migrate/20210817024335_prepare_indexes_for_events_bigint_conversion.rb' @@ -284,102 +418,314 @@ Layout/ArgumentAlignment: - 'db/post_migrate/20211031154919_add_indexes_to_merge_request_stage_events.rb' - 'db/post_migrate/20211109112454_drop_old_loose_fk_deleted_records_index.rb' - 'db/post_migrate/20220310134207_add_index_project_id_and_released_at_and_id_on_releases.rb' + - 'db/post_migrate/20220315171027_add_tmp_index_to_support_leaky_regex_cleanup.rb' + - 'db/post_migrate/20220322035654_add_migration_plan_index_to_container_repositories.rb' + - 'db/post_migrate/20220323152202_add_index_on_visible_deployments.rb' + - 'db/post_migrate/20220404183350_add_forbidden_state_index_to_users.rb' + - 'db/post_migrate/20220412143551_add_partial_index_on_unencrypted_integrations.rb' + - 'db/post_migrate/20220413011328_remove_partial_index_on_unencrypted_integrations.rb' + - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' + - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220503134610_remove_requirements_management_test_reports_requirement_id.rb' + - 'db/post_migrate/20220505174658_update_index_on_alerts_to_exclude_null_fingerprints.rb' + - 'db/post_migrate/20220525172001_migrate_cluster_integration_worker_queues.rb' + - 'db/post_migrate/20220530044712_add_index_for_vulnerability_reads_location_image.rb' + - 'db/post_migrate/20220610223040_add_index_on_available_pypi_packages.rb' + - 'db/post_migrate/20220621082245_remove_tmp_index_on_routes_namespace_id_column.rb' + - 'db/post_migrate/20220622070547_add_temp_index_for_container_registry_size_migration.rb' + - 'db/post_migrate/20220628110823_add_issues_namespace_id_fk_and_index.rb' + - 'db/post_migrate/20220630050050_index_vulnerability_reads_on_casted_cluster_agent_id_full.rb' + - 'db/post_migrate/20220630085003_drop_project_successfull_pages_deploy_index_from_ci_builds.rb' + - 'db/post_migrate/20220704044408_remove_foreign_key_in_project_tracing_settings.rb' + - 'db/post_migrate/20220706065245_remove_foreign_key_in_clusters_applications_elastic_stacks.rb' + - 'db/post_migrate/20220706065611_remove_foreign_key_in_clusters_integration_elasticstack.rb' + - 'db/post_migrate/20220707192420_remove_tmp_idx_merge_requests_draft_and_status.rb' + - 'db/post_migrate/20220715054506_add_parent_link_unique_work_item_index.rb' + - 'db/post_migrate/20220721140252_prepare_partial_trigram_indexes_for_issues.rb' + - 'db/post_migrate/20220726225114_remove_tmp_index_group_membership_namespace_id_column.rb' + - 'db/post_migrate/20220801144713_add_partial_trigram_index_for_issue_title.rb' + - 'db/post_migrate/20220801150028_add_partial_trigram_index_for_issue_description.rb' + - 'db/post_migrate/20220803042351_add_tmp_index_todos_attention_request_action.rb' + - 'db/post_migrate/20220810093742_add_async_tmp_index_job_artifacts_id_and_expire_at.rb' + - 'db/post_migrate/20220824114218_add_tmp_index_approval_merge_request_rules.rb' + - 'db/post_migrate/20220825061250_drop_tmp_index_todos_attention_request_action_idx.rb' + - 'db/post_migrate/20220901071310_add_tmp_index_user_callouts_on_attention_request_feature_names.rb' + - 'db/post_migrate/20220901073300_remove_partial_trigram_indexes_for_issues.rb' + - 'db/post_migrate/20220905090300_add_tmp_index_merge_request_reviewers_attention_request_state.rb' + - 'db/post_migrate/20220913030552_add_tmp_index_system_note_metadata_on_attention_request_actions.rb' + - 'db/post_migrate/20220915192521_prepare_async_trigram_index_for_vulnerability_reads_container_images.rb' + - 'db/post_migrate/20220916112841_remove_unused_aggregation_columns.rb' + - 'db/post_migrate/20220919023208_drop_unused_fields_from_merge_request_assignees.rb' + - 'db/post_migrate/20220919041604_drop_unused_fields_from_merge_request_reviewers.rb' + - 'db/post_migrate/20220919050555_drop_tmp_index_user_callouts_on_attention_request_feature_names.rb' + - 'db/post_migrate/20220923052531_remove_tmp_index_merge_request_reviewers_on_attention_requested_state.rb' + - 'db/post_migrate/20220923060226_remove_tmp_index_system_note_metadata_on_attention_request_actions.rb' + - 'db/post_migrate/20220929081645_tmp_idx_null_member_namespace_id.rb' + - 'db/post_migrate/20220929091500_add_tmp_index_vulns_on_report_type.rb' + - 'db/post_migrate/20221004092038_tmp_index_members_on_id_where_namespace_id_null.rb' + - 'db/post_migrate/20221005103000_add_index_merge_request_id_on_scan_finding_approval_merge_request_rules.rb' + - 'db/post_migrate/20221006083240_prepare_partial_trigram_indexes_for_issues_attempt_2.rb' + - 'db/post_migrate/20221019102426_remove_tmp_index_approval_merge_request_rules_on_report_type.rb' + - 'db/post_migrate/20221024034228_remove_sprints_project_id_column.rb' + - 'db/post_migrate/20221025220607_add_index_id_on_scan_finding_approval_merge_request_rules.rb' + - 'db/post_migrate/20221028000603_prepare_partial_trigram_indexes_for_issues_attempt_3.rb' + - 'db/post_migrate/20221104042137_add_partial_trigram_index_for_issue_title_attempt_2.rb' + - 'db/post_migrate/20221104042159_add_partial_trigram_index_for_issue_description_attempt_2.rb' + - 'db/post_migrate/20221104074652_add_temp_index_for_project_statistics_upload_size_migration.rb' + - 'db/post_migrate/20221104100203_recreate_async_trigram_index_for_vulnerability_reads_container_images.rb' + - 'db/post_migrate/20221115120602_add_index_for_issues_health_status_ordering.rb' + - 'db/post_migrate/20221117153015_add_index_merge_request_id_created_at_on_scan_finding_approval_merge_request_rules.rb' - 'ee/app/controllers/concerns/insights_actions.rb' - 'ee/app/controllers/customers_dot/proxy_controller.rb' + - 'ee/app/controllers/ee/admin/dev_ops_report_controller.rb' - 'ee/app/controllers/ee/groups_controller.rb' - 'ee/app/controllers/ee/passwords_controller.rb' + - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb' - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' + - 'ee/app/controllers/groups/contribution_analytics_controller.rb' + - 'ee/app/controllers/groups/insights_controller.rb' + - 'ee/app/controllers/groups/issues_analytics_controller.rb' + - 'ee/app/controllers/groups/two_factor_auths_controller.rb' + - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb' + - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' + - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' + - 'ee/app/controllers/projects/insights_controller.rb' - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' - 'ee/app/finders/geo/registry_finder.rb' - 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb' + - 'ee/app/graphql/ee/mutations/ci/project_ci_cd_settings_update.rb' + - 'ee/app/graphql/ee/resolvers/clusters/agents_resolver.rb' + - 'ee/app/graphql/ee/resolvers/issues/base_resolver.rb' + - 'ee/app/graphql/ee/types/board_list_type.rb' + - 'ee/app/graphql/ee/types/board_type.rb' + - 'ee/app/graphql/ee/types/boards/board_issue_input_type.rb' - 'ee/app/graphql/ee/types/ci/pipeline_type.rb' + - 'ee/app/graphql/ee/types/ci/runner_type.rb' - 'ee/app/graphql/ee/types/deprecated_mutations.rb' + - 'ee/app/graphql/ee/types/group_type.rb' + - 'ee/app/graphql/ee/types/issue_type.rb' + - 'ee/app/graphql/ee/types/merge_request_type.rb' + - 'ee/app/graphql/ee/types/query_type.rb' + - 'ee/app/graphql/ee/types/repository/blob_type.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/coverage/corpus/create.rb' - 'ee/app/graphql/mutations/boards/epic_boards/epic_move_list.rb' - 'ee/app/graphql/mutations/boards/epic_lists/update.rb' + - 'ee/app/graphql/mutations/ci/namespace_ci_cd_settings_update.rb' - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/dast/profiles/create.rb' - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb' - 'ee/app/graphql/mutations/epics/update.rb' + - 'ee/app/graphql/mutations/incident_management/issuable_resource_link/create.rb' + - 'ee/app/graphql/mutations/incident_management/issuable_resource_link/destroy.rb' + - 'ee/app/graphql/mutations/iterations/cadences/create.rb' + - 'ee/app/graphql/mutations/iterations/cadences/update.rb' + - 'ee/app/graphql/mutations/iterations/delete.rb' + - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/mutations/requirements_management/update_requirement.rb' + - 'ee/app/graphql/mutations/security/finding/create_issue.rb' + - 'ee/app/graphql/mutations/security/finding/dismiss.rb' + - 'ee/app/graphql/mutations/users/abuse/namespace_bans/destroy.rb' - 'ee/app/graphql/mutations/vulnerabilities/create.rb' + - 'ee/app/graphql/mutations/vulnerabilities/finding/dismiss.rb' - 'ee/app/graphql/resolvers/boards/board_list_epics_resolver.rb' + - 'ee/app/graphql/resolvers/boards/epic_list_resolver.rb' - 'ee/app/graphql/resolvers/ci/code_coverage_activities_resolver.rb' - 'ee/app/graphql/resolvers/concerns/common_requirement_arguments.rb' - - 'ee/app/graphql/resolvers/epics_resolver.rb' + - 'ee/app/graphql/resolvers/gitlab_subscriptions/preview_billable_user_change_resolver.rb' + - 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb' - 'ee/app/graphql/resolvers/iterations_resolver.rb' - - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb' - 'ee/app/graphql/resolvers/security_training_urls_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerabilities_count_per_day_resolver.rb' - 'ee/app/graphql/resolvers/vulnerabilities_grade_resolver.rb' + - 'ee/app/graphql/types/access_levels/group_type.rb' + - 'ee/app/graphql/types/access_levels/user_type.rb' + - 'ee/app/graphql/types/admin/cloud_licenses/current_license_type.rb' + - 'ee/app/graphql/types/admin/cloud_licenses/license_type.rb' + - 'ee/app/graphql/types/admin/cloud_licenses/subscription_future_entry_type.rb' - 'ee/app/graphql/types/alert_management/payload_alert_field_input_type.rb' + - 'ee/app/graphql/types/analytics/contribution_analytics/contribution_metadata_type.rb' + - 'ee/app/graphql/types/analytics/devops_adoption/enabled_namespace_type.rb' + - 'ee/app/graphql/types/analytics/devops_adoption/snapshot_type.rb' + - 'ee/app/graphql/types/app_sec/fuzzing/api/ci_configuration_type.rb' + - 'ee/app/graphql/types/app_sec/fuzzing/api/scan_profile_type.rb' + - 'ee/app/graphql/types/app_sec/fuzzing/coverage/corpus_type.rb' + - 'ee/app/graphql/types/boards/epic_board_type.rb' + - 'ee/app/graphql/types/boards/epic_list_type.rb' + - 'ee/app/graphql/types/boards/epic_user_preferences_type.rb' + - 'ee/app/graphql/types/burnup_chart_daily_totals_type.rb' + - 'ee/app/graphql/types/ci/code_quality_degradation_type.rb' + - 'ee/app/graphql/types/ci/namespace_ci_cd_setting_type.rb' + - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_type.rb' - 'ee/app/graphql/types/dast/profile_cadence_input_type.rb' - 'ee/app/graphql/types/dast/profile_schedule_input_type.rb' + - 'ee/app/graphql/types/dast/profile_schedule_type.rb' + - 'ee/app/graphql/types/dast/profile_type.rb' + - 'ee/app/graphql/types/dast_scanner_profile_type.rb' + - 'ee/app/graphql/types/dast_site_profile_type.rb' + - 'ee/app/graphql/types/dast_site_validation_type.rb' + - 'ee/app/graphql/types/dora_type.rb' + - 'ee/app/graphql/types/epic_issue_type.rb' + - 'ee/app/graphql/types/epic_type.rb' + - 'ee/app/graphql/types/external_issue_type.rb' + - 'ee/app/graphql/types/geo/dependency_proxy_manifest_registry_type.rb' - 'ee/app/graphql/types/incident_management/escalation_rule_input_type.rb' - 'ee/app/graphql/types/incident_management/oncall_participant_type.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_length_input_type.rb' - 'ee/app/graphql/types/incident_management/oncall_user_input_type.rb' + - 'ee/app/graphql/types/iteration_type.rb' + - 'ee/app/graphql/types/iterations/cadence_type.rb' + - 'ee/app/graphql/types/merge_requests/approval_state_type.rb' + - 'ee/app/graphql/types/namespaces/namespace_ban_type.rb' - 'ee/app/graphql/types/push_rules_type.rb' + - 'ee/app/graphql/types/requirements_management/requirement_type.rb' + - 'ee/app/graphql/types/requirements_management/test_report_type.rb' + - 'ee/app/graphql/types/security/training_type.rb' + - 'ee/app/graphql/types/security_orchestration/security_policy_relation_type_enum.rb' + - 'ee/app/graphql/types/time_report_stats_type.rb' + - 'ee/app/graphql/types/timebox_report_interface.rb' + - 'ee/app/graphql/types/timebox_report_type.rb' + - 'ee/app/graphql/types/vulnerabilities/asset_type.rb' + - 'ee/app/graphql/types/vulnerabilities/container_image_type.rb' + - 'ee/app/graphql/types/vulnerability/external_issue_link_type.rb' + - 'ee/app/graphql/types/vulnerability/issue_link_type.rb' + - 'ee/app/graphql/types/vulnerability_details/base_type.rb' + - 'ee/app/graphql/types/vulnerability_details/diff_type.rb' + - 'ee/app/graphql/types/vulnerability_details/file_location_type.rb' + - 'ee/app/graphql/types/vulnerability_details/markdown_type.rb' + - 'ee/app/graphql/types/vulnerability_details/module_location_type.rb' - 'ee/app/graphql/types/vulnerability_identifier_input_type.rb' + - 'ee/app/graphql/types/vulnerability_location/container_scanning_type.rb' + - 'ee/app/graphql/types/vulnerability_location/coverage_fuzzing_type.rb' + - 'ee/app/graphql/types/vulnerability_location/dast_type.rb' + - 'ee/app/graphql/types/vulnerability_location/dependency_scanning_type.rb' + - 'ee/app/graphql/types/vulnerability_location/generic_type.rb' + - 'ee/app/graphql/types/vulnerability_location/sast_type.rb' + - 'ee/app/graphql/types/vulnerability_location/secret_detection_type.rb' + - 'ee/app/graphql/types/vulnerability_request_response_header_type.rb' + - 'ee/app/graphql/types/vulnerability_request_type.rb' + - 'ee/app/graphql/types/vulnerability_response_type.rb' - 'ee/app/graphql/types/vulnerability_scanner_input_type.rb' + - 'ee/app/graphql/types/vulnerability_scanner_type.rb' - 'ee/app/graphql/types/vulnerability_scanner_vendor_input_type.rb' + - 'ee/app/graphql/types/vulnerability_type.rb' + - 'ee/app/graphql/types/vulnerable_dependency_type.rb' + - 'ee/app/graphql/types/vulnerable_kubernetes_resource_type.rb' + - 'ee/app/graphql/types/vulnerable_projects_by_grade_type.rb' + - 'ee/app/graphql/types/work_items/widgets/status_type.rb' + - 'ee/app/graphql/types/work_items/widgets/weight_type.rb' - 'ee/app/helpers/ee/button_helper.rb' - 'ee/app/models/concerns/approval_rule_like.rb' - 'ee/app/models/concerns/security/scan_execution_policy.rb' + - 'ee/app/models/concerns/security/scan_result_policy.rb' - 'ee/app/models/dast/site_profile_secret_variable.rb' + - 'ee/app/models/ee/dependency_proxy/blob.rb' + - 'ee/app/models/ee/dependency_proxy/manifest.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/identity.rb' - 'ee/app/models/ee/incident_management/project_incident_management_setting.rb' - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/lfs_object.rb' - 'ee/app/models/ee/list.rb' - - 'ee/app/models/ee/merge_request_diff.rb' - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/pages_deployment.rb' + - 'ee/app/models/ee/namespace_setting.rb' - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/project_group_link.rb' + - 'ee/app/models/geo/dependency_proxy_manifest_state.rb' - 'ee/app/models/geo/event_log.rb' + - 'ee/app/models/geo/project_wiki_repository_state.rb' - 'ee/app/models/geo/repository_renamed_event.rb' + - 'ee/app/models/integrations/github.rb' + - 'ee/app/models/package_metadata/package_version_license.rb' - 'ee/app/models/project_alias.rb' + - 'ee/app/models/slack_integration.rb' - 'ee/app/models/status_page/project_setting.rb' + - 'ee/app/serializers/ee/evidences/release_entity.rb' - 'ee/app/serializers/vulnerability_entity.rb' - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' - - 'ee/app/services/ee/ci/queue/build_queue_service.rb' + - 'ee/app/services/ee/merge_requests/create_pipeline_service.rb' - 'ee/app/services/geo/event_store.rb' - 'ee/app/services/geo/repository_base_sync_service.rb' + - 'ee/app/services/geo/repository_sync_service.rb' + - 'ee/app/services/geo/wiki_sync_service.rb' + - 'ee/app/services/incident_management/issuable_resource_links/create_service.rb' + - 'ee/app/services/incident_management/issuable_resource_links/destroy_service.rb' + - 'ee/app/services/incident_management/issuable_resource_links/zoom_link_service.rb' - 'ee/app/services/timebox_report_service.rb' + - 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' - 'ee/db/geo/migrate/20180405074130_add_partial_index_project_repository_verification.rb' + - 'ee/db/geo/migrate/20221017195204_create_project_wiki_repository_registry.rb' + - 'ee/db/geo/migrate/20221018201808_create_dependency_proxy_blob_registry.rb' + - 'ee/db/geo/migrate/20221102195145_create_dependency_proxy_manifest_registry.rb' + - 'ee/db/seeds/awesome_co/awesome_co.rb' + - 'ee/lib/api/dora/metrics.rb' - 'ee/lib/api/epic_issues.rb' + - 'ee/lib/api/geo_replication.rb' + - 'ee/lib/api/iterations.rb' - 'ee/lib/api/managed_licenses.rb' + - 'ee/lib/api/merge_trains.rb' + - 'ee/lib/api/protected_environments.rb' + - 'ee/lib/api/related_epic_links.rb' + - 'ee/lib/api/vulnerability_exports.rb' + - 'ee/lib/api/vulnerability_findings.rb' + - 'ee/lib/audit/project_changes_auditor.rb' + - 'ee/lib/audit/project_setting_changes_auditor.rb' - 'ee/lib/bulk_imports/groups/pipelines/iterations_pipeline.rb' - 'ee/lib/ee/api/entities/approval_settings.rb' - - 'ee/lib/ee/api/members.rb' + - 'ee/lib/ee/api/entities/approval_state.rb' + - 'ee/lib/ee/api/entities/epic.rb' + - 'ee/lib/ee/api/entities/group.rb' + - 'ee/lib/ee/api/entities/group_detail.rb' + - 'ee/lib/ee/api/entities/merge_train.rb' + - 'ee/lib/ee/api/helpers/groups_helpers.rb' + - 'ee/lib/ee/api/helpers/issues_helpers.rb' + - 'ee/lib/ee/api/helpers/merge_requests_helpers.rb' + - 'ee/lib/ee/api/helpers/protected_branches_helpers.rb' + - 'ee/lib/ee/api/merge_requests.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - 'ee/lib/ee/gitlab/ci/config/entry/job.rb' - 'ee/lib/ee/gitlab/ci/config/entry/need.rb' - 'ee/lib/ee/gitlab/event_store.rb' + - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' - 'ee/lib/ee/gitlab/web_ide/config/entry/global.rb' + - 'ee/lib/elastic/latest/config.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary.rb' + - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' + - 'ee/lib/gitlab/ingestion/bulk_updatable_task.rb' + - 'ee/lib/gitlab/insights/loader.rb' - 'ee/lib/gitlab/web_ide/config/entry/schema.rb' + - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/spec/controllers/admin/clusters_controller_spec.rb' + - 'ee/spec/controllers/ee/admin/sessions_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' - 'ee/spec/controllers/groups/clusters_controller_spec.rb' + - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - 'ee/spec/controllers/groups/todos_controller_spec.rb' + - 'ee/spec/controllers/projects/iterations_controller_spec.rb' + - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' + - 'ee/spec/controllers/projects/security/sast_configuration_controller_spec.rb' - 'ee/spec/controllers/projects/security/scanned_resources_controller_spec.rb' + - 'ee/spec/controllers/projects/settings/merge_requests_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/factories/epic_tree_nodes.rb' - 'ee/spec/factories/groups.rb' - 'ee/spec/factories/namespaces.rb' - 'ee/spec/factories/users.rb' + - 'ee/spec/features/account_recovery_regular_check_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/ide/user_commits_changes_spec.rb' + - 'ee/spec/features/groups/contribution_analytics_spec.rb' + - 'ee/spec/features/issues/filtered_search/filter_issues_by_health_spec.rb' - 'ee/spec/features/merge_request/user_approves_spec.rb' - 'ee/spec/features/merge_request/user_merges_immediately_spec.rb' - 'ee/spec/features/merge_request/user_sees_approval_widget_spec.rb' @@ -390,23 +736,42 @@ Layout/ArgumentAlignment: - 'ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb' - 'ee/spec/features/projects/environments/environments_spec.rb' - 'ee/spec/features/projects/merge_requests/user_edits_merge_request_spec.rb' + - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' + - 'ee/spec/features/registrations/saas/standard_flow_company_creating_project_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/finders/security/training_urls_finder_spec.rb' + - 'ee/spec/frontend/fixtures/oncall_schedule.rb' - 'ee/spec/frontend/fixtures/search.rb' + - 'ee/spec/graphql/ee/types/clusters/agent_type_spec.rb' - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' - - 'ee/spec/helpers/billing_plans_helper_spec.rb' + - 'ee/spec/helpers/ee/environments_helper_spec.rb' + - 'ee/spec/helpers/ee/namespace_user_cap_reached_alert_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' + - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' - - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' + - 'ee/spec/lib/audit/protected_branches_changes_auditor_spec.rb' - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb' - 'ee/spec/lib/ee/api/entities/analytics/group_activity_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' + - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb' + - 'ee/spec/lib/ee/gitlab/database/gitlab_schema_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' + - 'ee/spec/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor_spec.rb' + - 'ee/spec/lib/gitlab/ci/parsers/security/validators/default_branch_image_validator_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/container_scanning_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/license_scanning_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/secret_detection_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' + - 'ee/spec/lib/slack/block_kit/app_home_opened_spec.rb' - 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb' - 'ee/spec/models/ci/minutes/limit_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' @@ -414,13 +779,18 @@ Layout/ArgumentAlignment: - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - 'ee/spec/models/ee/ci/runner_spec.rb' + - 'ee/spec/models/ee/event_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/service_desk_setting_spec.rb' + - 'ee/spec/models/integrations/github/status_message_spec.rb' - 'ee/spec/models/integrations/github_spec.rb' - 'ee/spec/models/ldap_group_link_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/protected_environments/approval_rule_spec.rb' + - 'ee/spec/models/protected_environments/deploy_access_level_spec.rb' + - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - 'ee/spec/models/vulnerabilities/read_spec.rb' - 'ee/spec/policies/merge_request_policy_spec.rb' - 'ee/spec/requests/api/ci/runner/jobs_put_spec.rb' @@ -428,8 +798,10 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb' - 'ee/spec/requests/api/graphql/boards/epic_boards_query_spec.rb' - 'ee/spec/requests/api/graphql/boards/epic_lists_query_spec.rb' + - 'ee/spec/requests/api/graphql/ci/minutes/usage_spec.rb' - 'ee/spec/requests/api/graphql/group/dast_profile_schedule_spec.rb' - 'ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb' + - 'ee/spec/requests/api/graphql/group/epics_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb' @@ -444,78 +816,134 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb' - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/finding_dismiss_spec.rb' - 'ee/spec/requests/api/graphql/namespace/projects_spec.rb' + - 'ee/spec/requests/api/graphql/project/branch_rules/approval_project_rules_spec.rb' + - 'ee/spec/requests/api/graphql/project/deployment_spec.rb' + - 'ee/spec/requests/api/graphql/project/environments_spec.rb' - 'ee/spec/requests/api/graphql/project/issues_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_finding_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/requirements_management/test_reports_spec.rb' + - 'ee/spec/requests/api/graphql/project/security_orchestration/scan_result_policy_spec.rb' - 'ee/spec/requests/api/group_hooks_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' + - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/invitations_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' - 'ee/spec/requests/api/managed_licenses_spec.rb' - 'ee/spec/requests/api/project_push_rule_spec.rb' + - 'ee/spec/requests/api/protected_environments_spec.rb' + - 'ee/spec/requests/api/provider_identity_spec.rb' - 'ee/spec/requests/api/settings_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - - 'ee/spec/requests/projects/mirrors_controller_spec.rb' - 'ee/spec/requests/projects/requirements_management/requirements_controller_spec.rb' + - 'ee/spec/serializers/protected_environments/deploy_access_level_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/audit_events/export_csv_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' + - 'ee/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' - 'ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb' - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' - 'ee/spec/services/ci/pipeline_creation/drop_not_runnable_builds_service_spec.rb' + - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' - 'ee/spec/services/epics/update_service_spec.rb' - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' + - 'ee/spec/services/incident_management/issuable_resource_links/create_service_spec.rb' + - 'ee/spec/services/incident_management/issuable_resource_links/destroy_service_spec.rb' + - 'ee/spec/services/issuable/discussions_list_service_spec.rb' + - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' + - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' + - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' + - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' + - 'ee/spec/services/security/findings/dismiss_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' + - 'ee/spec/services/security/orchestration/unassign_service_spec.rb' - 'ee/spec/services/security/report_summary_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/rule_schedule_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/sync_scan_result_policies_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' + - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb' + - 'ee/spec/services/users/email_verification/send_custom_confirmation_instructions_service_spec.rb' + - 'ee/spec/services/vulnerabilities/find_or_create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/find_or_create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' + - 'ee/spec/services/vulnerabilities/starboard_vulnerability_resolve_service_spec.rb' - 'ee/spec/support/helpers/ee/geo_helpers.rb' - 'ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb' + - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/views/groups/feature_discovery_moments/advanced_features_dashboard.html.haml_spec.rb' + - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - 'ee/spec/views/layouts/_search.html.haml_spec.rb' + - 'ee/spec/views/shared/credentials_inventory/resource_access_tokens/_resource_access_token.html.haml_spec.rb' - 'ee/spec/workers/adjourned_group_deletion_worker_spec.rb' + - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' - 'ee/spec/workers/ci/batch_reset_minutes_worker_spec.rb' + - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' + - 'ee/spec/workers/namespaces/sync_namespace_name_worker_spec.rb' + - 'lib/api/admin/batched_background_migrations.rb' - 'lib/api/admin/ci/variables.rb' - - 'lib/api/ci/job_artifacts.rb' + - 'lib/api/alert_management_alerts.rb' + - 'lib/api/ci/runners.rb' - 'lib/api/commits.rb' - 'lib/api/concerns/packages/npm_endpoints.rb' - 'lib/api/deploy_keys.rb' - 'lib/api/deployments.rb' + - 'lib/api/entities/ci/job.rb' + - 'lib/api/entities/ci/job_artifact.rb' + - 'lib/api/entities/ci/pipeline.rb' - 'lib/api/entities/ci/pipeline_schedule_details.rb' + - 'lib/api/entities/ci/runner.rb' + - 'lib/api/entities/ci/secure_file.rb' + - 'lib/api/entities/compare.rb' + - 'lib/api/entities/deploy_key.rb' - 'lib/api/entities/diff_position.rb' - 'lib/api/entities/event.rb' + - 'lib/api/entities/group_detail.rb' - 'lib/api/entities/internal/pages/lookup_path.rb' - 'lib/api/entities/merge_request_diff.rb' + - 'lib/api/entities/merge_request_simple.rb' - 'lib/api/entities/pages_domain.rb' - 'lib/api/entities/pages_domain_basic.rb' + - 'lib/api/entities/protected_ref_access.rb' + - 'lib/api/entities/pull_mirror.rb' + - 'lib/api/entities/release.rb' + - 'lib/api/environments.rb' + - 'lib/api/error_tracking/project_settings.rb' - 'lib/api/feature_flags.rb' - 'lib/api/feature_flags_user_lists.rb' - 'lib/api/features.rb' + - 'lib/api/freeze_periods.rb' - 'lib/api/helm_packages.rb' - 'lib/api/helpers/internal_helpers.rb' - - 'lib/api/helpers/merge_requests_helpers.rb' + - 'lib/api/internal/pages.rb' - 'lib/api/issues.rb' - 'lib/api/merge_requests.rb' - 'lib/api/project_container_repositories.rb' - 'lib/api/project_import.rb' + - 'lib/api/protected_branches.rb' + - 'lib/api/release/links.rb' - 'lib/api/releases.rb' - 'lib/api/remote_mirrors.rb' - 'lib/api/repositories.rb' - 'lib/api/search.rb' + - 'lib/api/submodules.rb' - 'lib/api/tags.rb' + - 'lib/api/unleash.rb' - 'lib/api/users.rb' - 'lib/api/wikis.rb' - 'lib/banzai/filter/commit_trailers_filter.rb' @@ -529,8 +957,10 @@ Layout/ArgumentAlignment: - 'lib/gem_extensions/active_record/disable_joins/associations/association_scope.rb' - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' + - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/base_strategy.rb' + - 'lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/ci/config/entry/artifacts.rb' @@ -538,7 +968,8 @@ Layout/ArgumentAlignment: - 'lib/gitlab/ci/config/entry/cache.rb' - 'lib/gitlab/ci/config/entry/default.rb' - 'lib/gitlab/ci/config/entry/environment.rb' - - 'lib/gitlab/ci/config/entry/image.rb' + - 'lib/gitlab/ci/config/entry/hooks.rb' + - 'lib/gitlab/ci/config/entry/imageable.rb' - 'lib/gitlab/ci/config/entry/include.rb' - 'lib/gitlab/ci/config/entry/inherit.rb' - 'lib/gitlab/ci/config/entry/job.rb' @@ -553,7 +984,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/ci/config/entry/workflow.rb' - 'lib/gitlab/ci/pipeline/chain/config/process.rb' - 'lib/gitlab/ci/trace.rb' - - 'lib/gitlab/ci/variables/builder.rb' - 'lib/gitlab/config/loader/yaml.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/data_builder/pipeline.rb' @@ -562,6 +992,7 @@ Layout/ArgumentAlignment: - 'lib/gitlab/database/load_balancing/resolver.rb' - 'lib/gitlab/database/partitioning/replace_table.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' + - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb' - 'lib/gitlab/database_importers/self_monitoring/project/delete_service.rb' @@ -569,21 +1000,27 @@ Layout/ArgumentAlignment: - 'lib/gitlab/diff/file_collection/base.rb' - 'lib/gitlab/diff/suggestion.rb' - 'lib/gitlab/error_tracking/error.rb' + - 'lib/gitlab/event_store.rb' - 'lib/gitlab/git/repository.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' + - 'lib/gitlab/gitaly_client/remote_service.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/representation/diff_note.rb' - 'lib/gitlab/gpg.rb' - 'lib/gitlab/graphs/commits.rb' - 'lib/gitlab/kubernetes/kube_client.rb' - 'lib/gitlab/legacy_github_import/client.rb' + - 'lib/gitlab/metrics/methods.rb' - 'lib/gitlab/middleware/read_only/controller.rb' - 'lib/gitlab/net_http_adapter.rb' + - 'lib/gitlab/octokit/middleware.rb' - 'lib/gitlab/phabricator_import/cache/map.rb' - 'lib/gitlab/quick_actions/command_definition.rb' + - 'lib/gitlab/redis/multi_store.rb' - 'lib/gitlab/search/abuse_detection.rb' + - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/spamcheck/client.rb' - - 'lib/gitlab/usage_data.rb' + - 'lib/gitlab/url_builder.rb' - 'lib/gitlab/utils/delegator_override/validator.rb' - 'lib/gitlab/web_ide/config.rb' - 'lib/gitlab/web_ide/config/entry/global.rb' @@ -592,12 +1029,53 @@ Layout/ArgumentAlignment: - 'lib/safe_zip/extract.rb' - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/update_templates.rake' - - 'qa/qa/page/base.rb' + - 'qa/qa/ee/resource/license.rb' + - 'qa/qa/ee/resource/vulnerability_item.rb' + - 'qa/qa/page/component/groups_filter.rb' + - 'qa/qa/resource/members.rb' + - 'qa/qa/resource/personal_access_token.rb' + - 'qa/qa/resource/user.rb' - 'qa/qa/scenario/shared_attributes.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' + - 'qa/qa/specs/features/api/3_create/repository/storage_size_spec.rb' + - 'qa/qa/specs/features/api/8_monitor/metrics_spec.rb' + - 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_creation_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_manipulation_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_directory_management_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_file_upload_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_list_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_page_deletion_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/license_detection_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/source_editor/source_editor_toolbar_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/prefill_variables_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/raw_variables_defined_in_yaml_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/fix_vulnerability_workflow_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/policies_list_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/scan_result_policy_vulnerabilities_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerabilities_jira_integration_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/free_namespace_storage_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/rename_replication_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/14_model_ops/suggested_reviewer_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/delete_group_wiki_page_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/file_upload_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/4_verify/job_trace_archival_spec.rb' + - 'qa/qa/tools/delete_test_snippets.rb' + - 'qa/qa/tools/delete_user_projects.rb' - 'qa/qa/tools/generate_perf_testdata.rb' + - 'qa/qa/tools/revoke_user_personal_access_tokens.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/runtime/env_spec.rb' - 'scripts/changed-feature-flags' @@ -605,7 +1083,9 @@ Layout/ArgumentAlignment: - 'spec/bin/feature_flag_spec.rb' - 'spec/controllers/admin/ci/variables_controller_spec.rb' - 'spec/controllers/admin/clusters_controller_spec.rb' + - 'spec/controllers/concerns/redis_tracking_spec.rb' - 'spec/controllers/concerns/renders_commits_spec.rb' + - 'spec/controllers/graphql_controller_spec.rb' - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/milestones_controller_spec.rb' - 'spec/controllers/groups/variables_controller_spec.rb' @@ -617,6 +1097,7 @@ Layout/ArgumentAlignment: - 'spec/controllers/projects/commit_controller_spec.rb' - 'spec/controllers/projects/design_management/designs/raw_images_controller_spec.rb' - 'spec/controllers/projects/design_management/designs/resized_image_controller_spec.rb' + - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/feature_flags_clients_controller_spec.rb' - 'spec/controllers/projects/forks_controller_spec.rb' - 'spec/controllers/projects/grafana_api_controller_spec.rb' @@ -627,6 +1108,8 @@ Layout/ArgumentAlignment: - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/service_desk_controller_spec.rb' + - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/tags_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' @@ -638,9 +1121,11 @@ Layout/ArgumentAlignment: - 'spec/factories/integrations.rb' - 'spec/factories/merge_requests.rb' - 'spec/factories/notes.rb' - - 'spec/factories/projects.rb' - - 'spec/factories/snippets.rb' + - 'spec/features/admin/integrations/user_activates_mattermost_slash_command_spec.rb' + - 'spec/features/broadcast_messages_spec.rb' + - 'spec/features/clusters/cluster_health_dashboard_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' + - 'spec/features/help_dropdown_spec.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - 'spec/features/merge_request/user_creates_mr_spec.rb' @@ -655,22 +1140,31 @@ Layout/ArgumentAlignment: - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/merge_requests/user_views_open_merge_requests_spec.rb' + - 'spec/features/nav/top_nav_tooltip_spec.rb' + - 'spec/features/profiles/user_changes_notified_of_own_activity_spec.rb' + - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/commit/mini_pipeline_graph_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/environments/environments_spec.rb' + - 'spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - 'spec/features/projects/files/editing_a_file_spec.rb' - 'spec/features/projects/files/project_owner_creates_license_file_spec.rb' + - 'spec/features/projects/files/project_owner_sees_link_to_create_license_file_in_empty_project_spec.rb' + - 'spec/features/projects/files/user_browses_a_tree_with_a_folder_containing_only_a_folder_spec.rb' - 'spec/features/projects/files/user_reads_pipeline_status_spec.rb' - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/milestones/milestones_sorting_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' + - 'spec/features/tags/developer_deletes_tag_spec.rb' - 'spec/finders/ci/commit_statuses_finder_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/clusters/knative_services_finder_spec.rb' - 'spec/finders/clusters/kubernetes_namespace_finder_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' + - 'spec/finders/incident_management/timeline_event_tags_finder_spec.rb' - 'spec/finders/keys_finder_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' - 'spec/finders/personal_access_tokens_finder_spec.rb' @@ -684,12 +1178,17 @@ Layout/ArgumentAlignment: - 'spec/graphql/mutations/customer_relations/organizations/create_spec.rb' - 'spec/graphql/mutations/dependency_proxy/group_settings/update_spec.rb' - 'spec/graphql/mutations/dependency_proxy/image_ttl_group_policy/update_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event/create_spec.rb' - 'spec/graphql/mutations/namespace/package_settings/update_spec.rb' + - 'spec/graphql/resolvers/environments/last_deployment_resolver_spec.rb' + - 'spec/graphql/resolvers/incident_management/timeline_event_tags_resolver_spec.rb' - 'spec/graphql/types/project_statistics_type_spec.rb' + - 'spec/graphql/types/project_type_spec.rb' - 'spec/graphql/types/root_storage_statistics_type_spec.rb' - 'spec/helpers/notes_helper_spec.rb' - - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/todos_helper_spec.rb' + - 'spec/initializers/00_rails_disable_joins_spec.rb' + - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/backup/manager_spec.rb' @@ -700,11 +1199,18 @@ Layout/ArgumentAlignment: - 'spec/lib/constraints/group_url_constrainer_spec.rb' - 'spec/lib/constraints/project_url_constrainer_spec.rb' - 'spec/lib/constraints/user_url_constrainer_spec.rb' + - 'spec/lib/feature/definition_spec.rb' - 'spec/lib/feature_spec.rb' - 'spec/lib/gitlab/alert_management/payload/managed_prometheus_spec.rb' - 'spec/lib/gitlab/api_authentication/builder_spec.rb' + - 'spec/lib/gitlab/application_rate_limiter/increment_per_actioned_resource_spec.rb' - 'spec/lib/gitlab/asciidoc_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' + - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' + - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' @@ -716,87 +1222,123 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/assign_partition_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/remove_unwanted_chat_jobs_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/validate/abilities_spec.rb' - 'spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/common_spec.rb' - 'spec/lib/gitlab/ci/status/build/factory_spec.rb' - 'spec/lib/gitlab/ci/variables/builder/group_spec.rb' - 'spec/lib/gitlab/ci/variables/builder/project_spec.rb' - 'spec/lib/gitlab/ci/variables/builder_spec.rb' + - 'spec/lib/gitlab/cleanup/personal_access_tokens_spec.rb' - 'spec/lib/gitlab/config/entry/composable_hash_spec.rb' - 'spec/lib/gitlab/config/entry/configurable_spec.rb' - 'spec/lib/gitlab/current_settings_spec.rb' + - 'spec/lib/gitlab/data_builder/note_spec.rb' - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb' - 'spec/lib/gitlab/database/batch_count_spec.rb' + - 'spec/lib/gitlab/database/each_database_spec.rb' - 'spec/lib/gitlab/database/gitlab_schema_spec.rb' + - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' + - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb' - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb' - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/external_authorization/client_spec.rb' - 'spec/lib/gitlab/fogbugz_import/project_creator_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/lib/gitlab/github_import/importer/protected_branches_importer_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' + - 'spec/lib/gitlab/graphql/deprecation_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' + - 'spec/lib/gitlab/import_export/project/exported_relations_merger_spec.rb' - 'spec/lib/gitlab/import_export/project/object_builder_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importer_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/post_schema_validator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator_spec.rb' + - 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/column_order_definition_spec.rb' - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' + - 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' + - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - 'spec/lib/gitlab/spamcheck/client_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/merge_request_widget_extension_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/query_spec.rb' - 'spec/lib/gitlab/usage_data_counters/designs_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/snippet_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/wiki_page_counter_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' + - 'spec/lib/gitlab/web_hooks/rate_limiter_spec.rb' - 'spec/lib/mattermost/session_spec.rb' - 'spec/lib/peek/views/detailed_view_spec.rb' - 'spec/lib/system_check/base_check_spec.rb' + - 'spec/lib/system_check/incoming_email_check_spec.rb' - 'spec/mailers/emails/pipelines_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/models/active_session_spec.rb' + - 'spec/models/bulk_imports/export_status_spec.rb' - 'spec/models/ci/build_dependencies_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/build_trace_metadata_spec.rb' - 'spec/models/ci/commit_with_pipeline_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/job_token/project_scope_link_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/processable_spec.rb' - 'spec/models/clusters/applications/knative_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' + - 'spec/models/concerns/ci/partitionable/switch_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' + - 'spec/models/customer_relations/contact_spec.rb' + - 'spec/models/deployment_spec.rb' - 'spec/models/design_management/design_spec.rb' - 'spec/models/diff_note_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/external_pull_request_spec.rb' - 'spec/models/instance_configuration_spec.rb' + - 'spec/models/integrations/every_integration_spec.rb' - 'spec/models/integrations/pipelines_email_spec.rb' - 'spec/models/merge_request_spec.rb' + - 'spec/models/milestone_spec.rb' - 'spec/models/note_spec.rb' + - 'spec/models/personal_access_token_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/repository_spec.rb' - 'spec/models/u2f_registration_spec.rb' + - 'spec/models/user_spec.rb' - 'spec/presenters/blob_presenter_spec.rb' + - 'spec/requests/admin/batched_jobs_controller_spec.rb' - 'spec/requests/api/admin/ci/variables_spec.rb' + - 'spec/requests/api/alert_management_alerts_spec.rb' - 'spec/requests/api/badges_spec.rb' - 'spec/requests/api/broadcast_messages_spec.rb' - 'spec/requests/api/ci/job_artifacts_spec.rb' @@ -804,50 +1346,73 @@ Layout/ArgumentAlignment: - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - 'spec/requests/api/ci/triggers_spec.rb' + - 'spec/requests/api/ci/variables_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' + - 'spec/requests/api/commits_spec.rb' - 'spec/requests/api/discussions_spec.rb' + - 'spec/requests/api/feature_flags_spec.rb' + - 'spec/requests/api/graphql/ci/group_variables_spec.rb' + - 'spec/requests/api/graphql/ci/runner_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/group/dependency_proxy_manifests_spec.rb' - 'spec/requests/api/graphql/group/group_members_spec.rb' - 'spec/requests/api/graphql/group/milestones_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/job_retry_spec.rb' - 'spec/requests/api/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/project_ci_cd_settings_update_spec.rb' - 'spec/requests/api/graphql/mutations/commits/create_spec.rb' - 'spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event/create_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event/update_spec.rb' - 'spec/requests/api/graphql/mutations/labels/create_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/create_spec.rb' - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb' - 'spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb' - 'spec/requests/api/graphql/mutations/notes/create/note_spec.rb' + - 'spec/requests/api/graphql/mutations/notes/update/note_spec.rb' + - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/create_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'spec/requests/api/graphql/project/container_repositories_spec.rb' + - 'spec/requests/api/graphql/project/incident_management/timeline_events_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb' + - 'spec/requests/api/graphql/project/issues_spec.rb' + - 'spec/requests/api/graphql/project/milestones_spec.rb' - 'spec/requests/api/graphql/project/project_members_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - 'spec/requests/api/graphql/project/releases_spec.rb' - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/graphql/tasks/task_completion_status_spec.rb' - - 'spec/requests/api/import_github_spec.rb' + - 'spec/requests/api/group_variables_spec.rb' + - 'spec/requests/api/import_bitbucket_server_spec.rb' + - 'spec/requests/api/internal/lfs_spec.rb' + - 'spec/requests/api/invitations_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' - 'spec/requests/api/issues/get_project_issues_spec.rb' - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/namespaces_spec.rb' - 'spec/requests/api/notes_spec.rb' - 'spec/requests/api/oauth_tokens_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' + - 'spec/requests/api/personal_access_tokens_spec.rb' + - 'spec/requests/api/project_export_spec.rb' - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/protected_tags_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/settings_spec.rb' - - 'spec/requests/api/system_hooks_spec.rb' + - 'spec/requests/api/suggestions_spec.rb' + - 'spec/requests/api/unleash_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/git_http_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/openid_connect_spec.rb' + - 'spec/requests/projects/environments_controller_spec.rb' - 'spec/requests/self_monitoring_project_spec.rb' - 'spec/routing/project_routing_spec.rb' - 'spec/rubocop/cop/rspec/be_success_matcher_spec.rb' @@ -859,20 +1424,32 @@ Layout/ArgumentAlignment: - 'spec/services/ci/archive_trace_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service/custom_config_content_spec.rb' + - 'spec/services/ci/create_pipeline_service/environment_spec.rb' + - 'spec/services/ci/create_pipeline_service/partitioning_spec.rb' + - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/job_artifacts/create_service_spec.rb' + - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - 'spec/services/ci/job_token_scope/remove_project_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' + - 'spec/services/ci/retry_job_service_spec.rb' - 'spec/services/ci/retry_pipeline_service_spec.rb' - 'spec/services/dependency_proxy/group_settings/update_service_spec.rb' - 'spec/services/dependency_proxy/image_ttl_group_policies/update_service_spec.rb' - 'spec/services/deployments/update_environment_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' + - 'spec/services/environments/create_for_build_service_spec.rb' - 'spec/services/environments/stop_service_spec.rb' - 'spec/services/files/delete_service_spec.rb' - 'spec/services/files/update_service_spec.rb' + - 'spec/services/google_cloud/fetch_google_ip_list_service_spec.rb' + - 'spec/services/incident_management/timeline_event_tags/create_service_spec.rb' + - 'spec/services/incident_management/timeline_events/update_service_spec.rb' + - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/issues/resolve_discussions_spec.rb' + - 'spec/services/jira_connect_subscriptions/create_service_spec.rb' + - 'spec/services/merge_requests/build_service_spec.rb' - 'spec/services/merge_requests/create_pipeline_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' - 'spec/services/merge_requests/post_merge_service_spec.rb' @@ -883,13 +1460,17 @@ Layout/ArgumentAlignment: - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - 'spec/services/namespaces/package_settings/update_service_spec.rb' + - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/notification_service_spec.rb' - 'spec/services/packages/debian/extract_metadata_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' + - 'spec/services/projects/update_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' + - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/upload_service_spec.rb' + - 'spec/services/work_items/task_list_reference_removal_service_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/database/prevent_cross_joins.rb' @@ -902,32 +1483,51 @@ Layout/ArgumentAlignment: - 'spec/support/shared_examples/controllers/concerns/integrations/integrations_actions_shared_examples.rb' - 'spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' + - 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb' - 'spec/support/shared_examples/graphql/mutations/boards_create_shared_examples.rb' - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' + - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/template/template_shared_examples.rb' - 'spec/support/shared_examples/models/active_record_enum_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/from_set_operator_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb' + - 'spec/support/shared_examples/models/member_shared_examples.rb' + - 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/merge_request/merge_quick_action_shared_examples.rb' - 'spec/support/shared_examples/requests/api/diff_discussions_shared_examples.rb' - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/group_and_project_boards_query_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/requests/api/merge_requests_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb' - 'spec/support/shared_examples/requests/graphql_shared_examples.rb' - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - 'spec/support/shared_examples/services/boards/boards_recent_visit_shared_examples.rb' + - 'spec/support/shared_examples/services/issuable/discussions_list_shared_examples.rb' + - 'spec/support/shared_examples/workers/background_migration_worker_shared_examples.rb' - 'spec/support/trace/trace_helpers.rb' + - 'spec/tasks/gitlab/sidekiq_rake_spec.rb' - 'spec/tooling/quality/test_level_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' + - 'spec/uploaders/object_storage/cdn/google_cdn_spec.rb' + - 'spec/uploaders/object_storage/cdn/google_ip_cache_spec.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/projects/merge_requests/_commits.html.haml_spec.rb' - 'spec/views/projects/merge_requests/edit.html.haml_spec.rb' - 'spec/views/projects/tags/index.html.haml_spec.rb' + - 'spec/workers/ci/job_artifacts/track_artifact_report_worker_spec.rb' + - 'spec/workers/database/batched_background_migration/ci_execution_worker_spec.rb' + - 'spec/workers/database/batched_background_migration/main_execution_worker_spec.rb' + - 'spec/workers/merge_requests/create_pipeline_worker_spec.rb' + - 'spec/workers/pages/invalidate_domain_cache_worker_spec.rb' + - 'spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb' - 'spec/workers/pipeline_notification_worker_spec.rb' - 'spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb' - 'spec/workers/update_external_pull_requests_worker_spec.rb' + - 'spec/workers/update_merge_requests_worker_spec.rb' - 'spec/workers/web_hook_worker_spec.rb' diff --git a/.rubocop_todo/layout/closing_parenthesis_indentation.yml b/.rubocop_todo/layout/closing_parenthesis_indentation.yml index 79397e92312..3abbb024db6 100644 --- a/.rubocop_todo/layout/closing_parenthesis_indentation.yml +++ b/.rubocop_todo/layout/closing_parenthesis_indentation.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/ClosingParenthesisIndentation: Exclude: - 'app/presenters/project_presenter.rb' diff --git a/.rubocop_todo/layout/empty_line_between_defs.yml b/.rubocop_todo/layout/empty_line_between_defs.yml deleted file mode 100644 index ba69fc4c51b..00000000000 --- a/.rubocop_todo/layout/empty_line_between_defs.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -# Cop supports --auto-correct. -Layout/EmptyLineBetweenDefs: - Exclude: - - 'db/post_migrate/20220202105733_delete_service_template_records.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/import_export/remote_stream_upload.rb' - - 'lib/gitlab/redis/multi_store.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml deleted file mode 100644 index d4a3d2f5524..00000000000 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ /dev/null @@ -1,25 +0,0 @@ ---- -# Cop supports --auto-correct. -Layout/FirstArrayElementIndentation: - Exclude: - - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' - - 'spec/lib/gitlab/search/found_blob_spec.rb' - - 'spec/models/ci/runner_version_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/requests/api/task_completion_status_spec.rb' - - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/simplecov_env.rb' - - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/capybara.rb' - - 'spec/support/helpers/project_template_test_helper.rb' - - 'spec/support/helpers/test_env.rb' - - 'spec/support/helpers/usage_data_helpers.rb' - - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/shared_contexts/policies/group_policy_shared_context.rb' - - 'spec/support/shared_examples/graphql/label_fields.rb' - - 'spec/support/shared_examples/lib/gitlab/middleware/multipart_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' - - 'spec/views/projects/issues/_related_branches.html.haml_spec.rb' - - 'tooling/lib/tooling/helm3_client.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 50cd90019b6..e1ac4ccb650 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -1,31 +1,12 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/FirstHashElementIndentation: Exclude: - - 'app/components/diffs/stats_component.rb' - - 'app/controllers/admin/ci/variables_controller.rb' - - 'app/controllers/admin/system_info_controller.rb' - - 'app/controllers/boards/issues_controller.rb' - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/concerns/milestone_actions.rb' - - 'app/controllers/concerns/render_service_results.rb' - - 'app/controllers/concerns/sourcegraph_decorator.rb' - - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/badges_controller.rb' - - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/experiments/concerns/project_commit_count.rb' - - 'app/graphql/mutations/clusters/agent_tokens/create.rb' - - 'app/graphql/mutations/notes/create/diff_note.rb' - - 'app/graphql/mutations/notes/create/image_diff_note.rb' - - 'app/graphql/mutations/notes/create/note.rb' - - 'app/graphql/mutations/todos/restore_many.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - 'app/helpers/avatars_helper.rb' - 'app/helpers/breadcrumbs_helper.rb' - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/commits_helper.rb' - 'app/helpers/environments_helper.rb' - - 'app/helpers/icons_helper.rb' - 'app/helpers/keyset_helper.rb' - 'app/helpers/listbox_helper.rb' - 'app/helpers/page_layout_helper.rb' @@ -51,7 +32,6 @@ Layout/FirstHashElementIndentation: - 'app/models/concerns/subscribable.rb' - 'app/models/concerns/taskable.rb' - 'app/models/diff_note.rb' - - 'app/models/integrations/datadog.rb' - 'app/models/integrations/jira.rb' - 'app/models/jira_connect_installation.rb' - 'app/models/milestone.rb' @@ -81,10 +61,8 @@ Layout/FirstHashElementIndentation: - 'app/services/timelogs/base_service.rb' - 'app/validators/addressable_url_validator.rb' - 'app/workers/concerns/cluster_cleanup_methods.rb' - - 'ee/app/components/namespaces/free_user_cap/alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_preview_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb' - 'ee/app/controllers/groups/analytics/tasks_by_type_controller.rb' - 'ee/app/graphql/mutations/boards/epic_lists/destroy.rb' - 'ee/app/graphql/mutations/boards/epics/create.rb' @@ -97,7 +75,6 @@ Layout/FirstHashElementIndentation: - 'ee/app/helpers/ee/ci/jobs_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - - 'ee/app/helpers/ee/members_helper.rb' - 'ee/app/helpers/ee/namespaces_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/sidebars_helper.rb' @@ -111,7 +88,6 @@ Layout/FirstHashElementIndentation: - 'ee/app/serializers/ee/environment_serializer.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' - - 'ee/app/services/audit_events/build_service.rb' - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - 'ee/app/services/ee/ci/register_job_service.rb' - 'ee/app/services/ee/issues/export_csv_service.rb' @@ -135,17 +111,12 @@ Layout/FirstHashElementIndentation: - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' - 'ee/lib/gitlab/status_page/storage/s3_multipart_upload.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - - 'ee/spec/controllers/boards/issues_controller_spec.rb' - - 'ee/spec/controllers/boards/lists_controller_spec.rb' - - 'ee/spec/controllers/boards/users_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb' - - 'ee/spec/controllers/projects/imports_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/licenses_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' @@ -154,18 +125,14 @@ Layout/FirstHashElementIndentation: - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/factories/dependencies.rb' - 'ee/spec/factories/licenses.rb' - - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/frontend/fixtures/search.rb' - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' @@ -175,7 +142,6 @@ Layout/FirstHashElementIndentation: - 'ee/spec/helpers/groups/sso_helper_spec.rb' - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' @@ -230,9 +196,7 @@ Layout/FirstHashElementIndentation: - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/groups/group_members_controller_spec.rb' - - 'ee/spec/requests/groups/usage_quotas_spec.rb' - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb' - - 'ee/spec/requests/projects/mirrors_controller_spec.rb' - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb' - 'ee/spec/serializers/license_entity_spec.rb' - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' @@ -253,18 +217,14 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - 'ee/spec/services/approval_rules/create_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service_spec.rb' - - 'ee/spec/services/ci/runners/stale_group_runners_prune_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - 'ee/spec/services/ee/post_receive_service_spec.rb' - 'ee/spec/services/external_status_checks/create_service_spec.rb' - 'ee/spec/services/geo/node_status_request_service_spec.rb' - - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_trial_or_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' @@ -274,18 +234,14 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/iterations/create_service_spec.rb' - - 'ee/spec/services/namespaces/free_user_cap/deactivate_members_over_limit_service_spec.rb' - - 'ee/spec/services/namespaces/free_user_cap/remove_group_group_links_outside_hierarchy_service_spec.rb' - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - 'ee/spec/services/security/report_summary_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/services/security/track_scan_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - - 'ee/spec/services/users/abuse/excessive_projects_download_ban_service_spec.rb' - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb' - 'ee/spec/support/helpers/ee/login_helpers.rb' - 'ee/spec/support/shared_contexts/fixtures/analytics_shared_context.rb' @@ -320,7 +276,6 @@ Layout/FirstHashElementIndentation: - 'lib/gitlab/kubernetes/namespace.rb' - 'lib/gitlab/kubernetes/rollout_instances.rb' - 'lib/gitlab/legacy_github_import/client.rb' - - 'lib/gitlab/nav/top_nav_view_model_builder.rb' - 'lib/gitlab/push_options.rb' - 'lib/gitlab/quick_actions/issuable_actions.rb' - 'lib/gitlab/usage_data_counters/track_unique_events.rb' @@ -343,20 +298,14 @@ Layout/FirstHashElementIndentation: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'spec/components/diffs/stats_component_spec.rb' - 'spec/components/pajamas/component_spec.rb' - 'spec/config/object_store_settings_spec.rb' - 'spec/config/smime_signature_settings_spec.rb' - - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - - 'spec/controllers/boards/lists_controller_spec.rb' - 'spec/controllers/concerns/import_url_params_spec.rb' - 'spec/controllers/concerns/issuable_collections_spec.rb' - - 'spec/controllers/groups/boards_controller_spec.rb' - 'spec/controllers/groups/group_members_controller_spec.rb' - 'spec/controllers/groups/packages_controller_spec.rb' - 'spec/controllers/groups/registry/repositories_controller_spec.rb' @@ -416,13 +365,11 @@ Layout/FirstHashElementIndentation: - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' - 'spec/lib/api/entities/bulk_imports/export_status_spec.rb' - 'spec/lib/api/entities/design_management/design_spec.rb' - 'spec/lib/api/entities/merge_request_approvals_spec.rb' - 'spec/lib/api/entities/personal_access_token_spec.rb' - - 'spec/lib/api/entities/personal_access_token_with_details_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - 'spec/lib/backup/database_spec.rb' - 'spec/lib/backup/repositories_spec.rb' @@ -461,7 +408,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' - - 'spec/lib/gitlab/ci/parsers/sbom/source/dependency_scanning_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build/cache_spec.rb' @@ -478,11 +424,8 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb' - 'spec/lib/gitlab/error_tracking_spec.rb' - - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - - 'spec/lib/gitlab/experimentation_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' - 'spec/lib/gitlab/git/hook_env_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' @@ -504,7 +447,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_instances_spec.rb' - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' - - 'spec/lib/gitlab/memory/watchdog_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' @@ -536,7 +478,6 @@ Layout/FirstHashElementIndentation: - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - - 'spec/models/integrations/packagist_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/loose_foreign_keys/modification_tracker_spec.rb' - 'spec/models/merge_request_diff_commit_spec.rb' @@ -583,7 +524,6 @@ Layout/FirstHashElementIndentation: - 'spec/services/ci/play_manual_stage_service_spec.rb' - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb' - 'spec/services/clusters/agents/create_service_spec.rb' - - 'spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb' - 'spec/services/clusters/aws/authorize_role_service_spec.rb' - 'spec/services/clusters/update_service_spec.rb' - 'spec/services/commits/tag_service_spec.rb' @@ -631,7 +571,6 @@ Layout/FirstHashElementIndentation: - 'spec/support_specs/graphql/arguments_spec.rb' - 'spec/support_specs/graphql/field_selection_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - 'spec/views/projects/issues/_issue.html.haml_spec.rb' - 'spec/workers/ci/runners/reconcile_existing_runner_versions_cron_worker_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index 62d877624a7..7aa46e3fd05 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/HashAlignment: Exclude: - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' diff --git a/.rubocop_todo/layout/leading_comment_space.yml b/.rubocop_todo/layout/leading_comment_space.yml index fda1d4ff30b..9dc79492f2a 100644 --- a/.rubocop_todo/layout/leading_comment_space.yml +++ b/.rubocop_todo/layout/leading_comment_space.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/LeadingCommentSpace: Exclude: - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index b5fc199c0ca..07e7b374db2 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/LineLength: Exclude: - 'app/controllers/abuse_reports_controller.rb' @@ -13,7 +13,6 @@ Layout/LineLength: - 'app/controllers/admin/topics_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' - - 'app/controllers/boards/lists_controller.rb' - 'app/controllers/concerns/access_tokens_actions.rb' - 'app/controllers/concerns/analytics/cycle_analytics/stage_actions.rb' - 'app/controllers/concerns/clientside_preview_csp.rb' @@ -93,7 +92,6 @@ Layout/LineLength: - 'app/controllers/projects/pipeline_schedules_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/prometheus/metrics_controller.rb' - - 'app/controllers/projects/raw_controller.rb' - 'app/controllers/projects/settings/ci_cd_controller.rb' - 'app/controllers/projects/settings/repository_controller.rb' - 'app/controllers/projects/templates_controller.rb' @@ -165,7 +163,6 @@ Layout/LineLength: - 'app/graphql/mutations/snippets/update.rb' - 'app/graphql/mutations/todos/create.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/container_repository_tags_resolver.rb' - 'app/graphql/resolvers/project_merge_requests_resolver.rb' @@ -355,7 +352,6 @@ Layout/LineLength: - 'app/models/concerns/sortable.rb' - 'app/models/concerns/storage/legacy_namespace.rb' - 'app/models/concerns/subscribable.rb' - - 'app/models/concerns/timebox.rb' - 'app/models/concerns/token_authenticatable_strategies/base.rb' - 'app/models/concerns/token_authenticatable_strategies/encrypted.rb' - 'app/models/concerns/token_authenticatable_strategies/encryption_helper.rb' @@ -395,7 +391,6 @@ Layout/LineLength: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/ewm.rb' - 'app/models/integrations/external_wiki.rb' - - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/harbor.rb' - 'app/models/integrations/jenkins.rb' @@ -516,7 +511,6 @@ Layout/LineLength: - 'app/services/ci/drop_pipeline_service.rb' - 'app/services/ci/generate_coverage_reports_service.rb' - 'app/services/ci/job_artifacts/destroy_all_expired_service.rb' - - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - 'app/services/ci/job_artifacts/expire_project_build_artifacts_service.rb' - 'app/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service.rb' - 'app/services/ci/pipelines/add_job_service.rb' @@ -527,8 +521,6 @@ Layout/LineLength: - 'app/services/clusters/agent_tokens/create_service.rb' - 'app/services/clusters/agents/delete_service.rb' - 'app/services/clusters/applications/check_progress_service.rb' - - 'app/services/clusters/applications/check_uninstall_progress_service.rb' - - 'app/services/clusters/applications/prometheus_update_service.rb' - 'app/services/clusters/aws/finalize_creation_service.rb' - 'app/services/clusters/aws/verify_provision_status_service.rb' - 'app/services/clusters/build_kubernetes_namespace_service.rb' @@ -683,7 +675,6 @@ Layout/LineLength: - 'app/services/system_notes/zoom_service.rb' - 'app/services/tags/destroy_service.rb' - 'app/services/tasks_to_be_done/base_service.rb' - - 'app/services/two_factor/destroy_service.rb' - 'app/services/users/approve_service.rb' - 'app/services/users/banned_user_base_service.rb' - 'app/services/users/build_service.rb' @@ -712,8 +703,6 @@ Layout/LineLength: - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/error_tracking_issue_link_worker.rb' - 'app/workers/gitlab/github_import/stage/finish_import_worker.rb' - - 'app/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker.rb' - - 'app/workers/gitlab/github_import/stage/import_notes_worker.rb' - 'app/workers/gitlab/github_import/stage/import_repository_worker.rb' - 'app/workers/gitlab/import/stuck_import_job.rb' - 'app/workers/gitlab/jira_import/stage/import_attachments_worker.rb' @@ -759,6 +748,7 @@ Layout/LineLength: - 'config/initializers/validate_puma.rb' - 'config/initializers/zz_metrics.rb' - 'config/object_store_settings.rb' + - 'config/puma.rb' - 'config/routes.rb' - 'config/routes/admin.rb' - 'config/routes/api.rb' @@ -1057,7 +1047,6 @@ Layout/LineLength: - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - - 'ee/app/controllers/concerns/audit_events/audit_events_params.rb' - 'ee/app/controllers/concerns/audit_events/date_range.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/controllers/concerns/ee/issuable_collections.rb' @@ -1097,7 +1086,6 @@ Layout/LineLength: - 'ee/app/enums/vulnerabilities/dismissal_reason_enum.rb' - 'ee/app/finders/compliance_management/merge_requests/compliance_violations_finder.rb' - 'ee/app/finders/incident_management/escalation_rules_finder.rb' - - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/merge_requests/by_approvers_finder.rb' - 'ee/app/finders/projects/integrations/jira/by_ids_finder.rb' - 'ee/app/finders/projects/integrations/jira/issues_finder.rb' @@ -1105,7 +1093,6 @@ Layout/LineLength: - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/ee/mutations/boards/lists/create.rb' - 'ee/app/graphql/ee/mutations/ci/runner/update.rb' - - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/analytics/devops_adoption/enabled_namespaces/bulk_enable.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/update.rb' @@ -1136,7 +1123,6 @@ Layout/LineLength: - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' - 'ee/app/graphql/resolvers/ci/code_coverage_activities_resolver.rb' - 'ee/app/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver.rb' - - 'ee/app/graphql/resolvers/concerns/resolves_orchestration_policy.rb' - 'ee/app/graphql/resolvers/dora_metrics_resolver.rb' - 'ee/app/graphql/resolvers/external_issue_resolver.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_rotations_resolver.rb' @@ -1283,7 +1269,6 @@ Layout/LineLength: - 'ee/app/models/elastic/migration_record.rb' - 'ee/app/models/elastic/reindexing_slice.rb' - 'ee/app/models/epic_issue.rb' - - 'ee/app/models/geo/container_repository_registry.rb' - 'ee/app/models/geo/project_registry.rb' - 'ee/app/models/geo/secondary_usage_data.rb' - 'ee/app/models/geo_node.rb' @@ -1371,7 +1356,6 @@ Layout/LineLength: - 'ee/app/services/ee/analytics/cycle_analytics/stages/list_service.rb' - 'ee/app/services/ee/application_settings/update_service.rb' - 'ee/app/services/ee/applications/create_service.rb' - - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - 'ee/app/services/ee/boards/base_service.rb' - 'ee/app/services/ee/ci/job_artifacts/destroy_batch_service.rb' - 'ee/app/services/ee/ci/register_job_service.rb' @@ -1458,7 +1442,6 @@ Layout/LineLength: - 'ee/app/services/security/report_summary_service.rb' - 'ee/app/services/security/scanned_resources_counting_service.rb' - 'ee/app/services/security/scanned_resources_service.rb' - - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb' - 'ee/app/services/security/security_orchestration_policies/fetch_policy_approvers_service.rb' - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_commit_service.rb' @@ -1473,9 +1456,7 @@ Layout/LineLength: - 'ee/app/services/system_notes/escalations_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/app/services/vulnerabilities/base_service.rb' - - 'ee/app/services/vulnerabilities/dismiss_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - - 'ee/app/services/vulnerabilities/resolve_service.rb' - 'ee/app/services/vulnerabilities/revert_to_detected_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/update_service.rb' @@ -1508,7 +1489,6 @@ Layout/LineLength: - 'ee/app/workers/repository_update_mirror_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb' - - 'ee/app/workers/update_all_mirrors_worker.rb' - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/config/routes/group.rb' - 'ee/config/routes/project.rb' @@ -1537,13 +1517,11 @@ Layout/LineLength: - 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb' - 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb' - 'ee/lib/analytics/productivity_analytics_request_params.rb' - - 'ee/lib/api/analytics/code_review_analytics.rb' - 'ee/lib/api/audit_events.rb' - 'ee/lib/api/ci/minutes.rb' - 'ee/lib/api/dependencies.rb' - 'ee/lib/api/epic_issues.rb' - 'ee/lib/api/epic_links.rb' - - 'ee/lib/api/epics.rb' - 'ee/lib/api/geo_nodes.rb' - 'ee/lib/api/group_hooks.rb' - 'ee/lib/api/group_push_rule.rb' @@ -1588,8 +1566,6 @@ Layout/LineLength: - 'ee/lib/ee/api/merge_request_approvals.rb' - 'ee/lib/ee/api/merge_requests.rb' - 'ee/lib/ee/api/namespaces.rb' - - 'ee/lib/ee/api/protected_branches.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/data_collector.rb' @@ -1627,9 +1603,7 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/repository_size_checker.rb' - 'ee/lib/ee/gitlab/scim/deprovision_service.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/ee/sidebars/groups/menus/issues_menu.rb' - 'ee/lib/ee/sidebars/groups/panel.rb' - - 'ee/lib/ee/sidebars/projects/menus/issues_menu.rb' - 'ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb' - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/config.rb' @@ -1664,7 +1638,6 @@ Layout/LineLength: - 'ee/lib/gitlab/ci/reports/security/locations/cluster_image_scanning.rb' - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/elastic/group_search_results.rb' - - 'ee/lib/gitlab/elastic/indexer.rb' - 'ee/lib/gitlab/elastic/project_search_results.rb' - 'ee/lib/gitlab/elastic/search_results.rb' - 'ee/lib/gitlab/email/message/account_validation.rb' @@ -1713,7 +1686,6 @@ Layout/LineLength: - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/admin/projects_controller_spec.rb' - 'ee/spec/controllers/admin/users_controller_spec.rb' - - 'ee/spec/controllers/boards/issues_controller_spec.rb' - 'ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb' - 'ee/spec/controllers/ee/dashboard/projects_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' @@ -1721,7 +1693,6 @@ Layout/LineLength: - 'ee/spec/controllers/ee/search_controller_spec.rb' - 'ee/spec/controllers/ee/uploads_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb' @@ -1764,7 +1735,6 @@ Layout/LineLength: - 'ee/spec/factories/ci/reports/security/locations/container_scanning.rb' - 'ee/spec/factories/ci/reports/security/locations/dependency_scanning.rb' - 'ee/spec/factories/compliance_management/frameworks.rb' - - 'ee/spec/factories/geo/container_repository_registry.rb' - 'ee/spec/factories/iterations.rb' - 'ee/spec/factories/namespaces.rb' - 'ee/spec/factories/vulnerabilities/exports.rb' @@ -1803,7 +1773,6 @@ Layout/LineLength: - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/groups/groups_security_credentials_spec.rb' - 'ee/spec/features/groups/hooks/user_tests_hooks_spec.rb' - - 'ee/spec/features/groups/iterations/iterations_list_spec.rb' - 'ee/spec/features/groups/iterations/user_creates_iteration_in_cadence_spec.rb' - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' - 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb' @@ -1839,7 +1808,6 @@ Layout/LineLength: - 'ee/spec/features/projects/integrations/prometheus_custom_metrics_spec.rb' - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - 'ee/spec/features/projects/iterations/iteration_cadences_list_spec.rb' - - 'ee/spec/features/projects/iterations/iterations_list_spec.rb' - 'ee/spec/features/projects/iterations/user_views_iteration_spec.rb' - 'ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb' - 'ee/spec/features/projects/members/member_is_removed_from_project_spec.rb' @@ -1857,7 +1825,6 @@ Layout/LineLength: - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/read_only_spec.rb' - - 'ee/spec/features/search/elastic/global_search_spec.rb' - 'ee/spec/features/search/elastic/project_search_spec.rb' - 'ee/spec/features/search/elastic/snippet_search_spec.rb' - 'ee/spec/features/subscriptions_spec.rb' @@ -1874,7 +1841,6 @@ Layout/LineLength: - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/finders/geo/container_repository_legacy_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - 'ee/spec/finders/group_projects_finder_spec.rb' @@ -2048,8 +2014,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/api/entities/deployment_extended_spec.rb' - 'ee/spec/lib/ee/api/entities/vulnerability_export_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' - - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' @@ -2071,7 +2035,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' @@ -2139,7 +2102,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dependency_list_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dependency_scanning_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/dependency_list/dependency_spec.rb' @@ -2467,7 +2429,6 @@ Layout/LineLength: - 'ee/spec/requests/api/graphql/project/issues_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' - - 'ee/spec/requests/api/graphql/project/requirements_management/test_reports_spec.rb' - 'ee/spec/requests/api/graphql/project/vulnerability_severities_count_spec.rb' - 'ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb' - 'ee/spec/requests/api/graphql/vulnerabilities/description_spec.rb' @@ -2609,7 +2570,6 @@ Layout/LineLength: - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - 'ee/spec/services/ee/allowed_email_domains/update_service_spec.rb' - - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' @@ -2640,7 +2600,6 @@ Layout/LineLength: - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - 'ee/spec/services/ee/system_notes/issuables_service_spec.rb' - 'ee/spec/services/ee/users/destroy_service_spec.rb' - - 'ee/spec/services/ee/users/migrate_to_ghost_user_service_spec.rb' - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/elastic/cluster_reindexing_service_spec.rb' - 'ee/spec/services/elastic/data_migration_service_spec.rb' @@ -2692,7 +2651,6 @@ Layout/LineLength: - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - 'ee/spec/services/iterations/cadences/destroy_service_spec.rb' - 'ee/spec/services/iterations/cadences/update_service_spec.rb' - - 'ee/spec/services/iterations/create_service_spec.rb' - 'ee/spec/services/iterations/delete_service_spec.rb' - 'ee/spec/services/jira/jql_builder_service_spec.rb' - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' @@ -2700,13 +2658,11 @@ Layout/LineLength: - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' - - 'ee/spec/services/merge_requests/merge_to_ref_service_spec.rb' - 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' - 'ee/spec/services/merge_requests/sync_report_approver_approval_rules_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - 'ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb' - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' @@ -2725,7 +2681,6 @@ Layout/LineLength: - 'ee/spec/services/search/group_service_spec.rb' - 'ee/spec/services/search/project_service_spec.rb' - 'ee/spec/services/search/snippet_service_spec.rb' - - 'ee/spec/services/search_service_spec.rb' - 'ee/spec/services/security/dependency_list_service_spec.rb' - 'ee/spec/services/security/ingestion/finding_map_collection_spec.rb' - 'ee/spec/services/security/ingestion/ingest_report_service_spec.rb' @@ -2783,7 +2738,6 @@ Layout/LineLength: - 'ee/spec/services/wiki_pages/create_service_spec.rb' - 'ee/spec/services/wiki_pages/destroy_service_spec.rb' - 'ee/spec/services/wiki_pages/update_service_spec.rb' - - 'ee/spec/support/elastic.rb' - 'ee/spec/support/features/redacted_search_results_examples.rb' - 'ee/spec/support/helpers/search_results_helpers.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' @@ -2855,7 +2809,6 @@ Layout/LineLength: - 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb' - 'ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - 'ee/spec/workers/adjourned_group_deletion_worker_spec.rb' @@ -2874,7 +2827,6 @@ Layout/LineLength: - 'ee/spec/workers/elastic_association_indexer_worker_spec.rb' - 'ee/spec/workers/elastic_commit_indexer_worker_spec.rb' - 'ee/spec/workers/geo/batch/project_registry_scheduler_worker_spec.rb' - - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' - 'ee/spec/workers/geo/destroy_worker_spec.rb' - 'ee/spec/workers/geo/project_sync_worker_spec.rb' - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' @@ -3014,7 +2966,6 @@ Layout/LineLength: - 'lib/api/settings.rb' - 'lib/api/snippet_repository_storage_moves.rb' - 'lib/api/snippets.rb' - - 'lib/api/submodules.rb' - 'lib/api/suggestions.rb' - 'lib/api/tags.rb' - 'lib/api/templates.rb' @@ -3112,7 +3063,6 @@ Layout/LineLength: - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'lib/gitlab/batch_pop_queueing.rb' - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/buffered_io.rb' @@ -3208,7 +3158,6 @@ Layout/LineLength: - 'lib/gitlab/database/reindexing/coordinator.rb' - 'lib/gitlab/database/reindexing/grafana_notifier.rb' - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - - 'lib/gitlab/database/schema_cleaner.rb' - 'lib/gitlab/database/schema_migrations/context.rb' - 'lib/gitlab/database/similarity_score.rb' - 'lib/gitlab/database/with_lock_retries.rb' @@ -3239,8 +3188,6 @@ Layout/LineLength: - 'lib/gitlab/event_store/event.rb' - 'lib/gitlab/event_store/store.rb' - 'lib/gitlab/event_store/subscription.rb' - - 'lib/gitlab/experimentation.rb' - - 'lib/gitlab/experimentation/controller_concern.rb' - 'lib/gitlab/external_authorization/client.rb' - 'lib/gitlab/faraday/error_callback.rb' - 'lib/gitlab/file_detector.rb' @@ -3255,7 +3202,6 @@ Layout/LineLength: - 'lib/gitlab/git/repository.rb' - 'lib/gitlab/git/rugged_impl/repository.rb' - 'lib/gitlab/git/user.rb' - - 'lib/gitlab/git/wiki.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/git_access_snippet.rb' @@ -3270,10 +3216,8 @@ Layout/LineLength: - 'lib/gitlab/gitaly_client/remote_service.rb' - 'lib/gitlab/gitaly_client/repository_service.rb' - 'lib/gitlab/gitaly_client/server_service.rb' - - 'lib/gitlab/gitaly_client/wiki_service.rb' - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - - 'lib/gitlab/github_import/issuable_finder.rb' - 'lib/gitlab/github_import/parallel_scheduling.rb' - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' @@ -3323,7 +3267,6 @@ Layout/LineLength: - 'lib/gitlab/lograge/custom_options.rb' - 'lib/gitlab/mail_room/authenticator.rb' - 'lib/gitlab/markdown_cache/active_record/extension.rb' - - 'lib/gitlab/merge_requests/commit_message_generator.rb' - 'lib/gitlab/metrics/dashboard/importer.rb' - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - 'lib/gitlab/metrics/dashboard/stages/cluster_endpoint_inserter.rb' @@ -3342,7 +3285,6 @@ Layout/LineLength: - 'lib/gitlab/middleware/read_only/controller.rb' - 'lib/gitlab/middleware/speedscope.rb' - 'lib/gitlab/object_hierarchy.rb' - - 'lib/gitlab/octokit/middleware.rb' - 'lib/gitlab/pagination/keyset/column_order_definition.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/order_by_columns.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/query_builder.rb' @@ -3354,7 +3296,6 @@ Layout/LineLength: - 'lib/gitlab/pagination/offset_pagination.rb' - 'lib/gitlab/patch/database_config.rb' - 'lib/gitlab/path_regex.rb' - - 'lib/gitlab/profiler.rb' - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/project_template.rb' - 'lib/gitlab/prometheus/queries/base_query.rb' @@ -3382,7 +3323,6 @@ Layout/LineLength: - 'lib/gitlab/sidekiq_config/worker_router.rb' - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb' @@ -3470,7 +3410,6 @@ Layout/LineLength: - 'qa/qa/ee/resource/license.rb' - 'qa/qa/flow/sign_up.rb' - 'qa/qa/git/repository.rb' - - 'qa/qa/page/base.rb' - 'qa/qa/page/component/ci_badge_link.rb' - 'qa/qa/page/component/issuable/sidebar.rb' - 'qa/qa/page/component/select2.rb' @@ -3485,7 +3424,6 @@ Layout/LineLength: - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/file.rb' - - 'qa/qa/resource/members.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/repository/push.rb' @@ -3511,7 +3449,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/api/1_manage/users_spec.rb' - - 'qa/qa/specs/features/api/3_create/integrations/webhook_events_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb' @@ -3532,7 +3469,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' @@ -3540,12 +3476,9 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/2_plan/issue/export_as_csv_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/real_time_assignee_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/related_issues/related_issues_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/transient/comment_on_discussion_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/jira/jira_basic_integration_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_merge_request_from_fork_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' @@ -3564,11 +3497,8 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/repository/move_project_create_fork_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_to_canary_gitaly_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' @@ -3587,11 +3517,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/upload_new_file_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/content_editor_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_creation_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_manipulation_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_list_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_page_deletion_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/pipeline_with_protected_variable_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_local_config_file_paths_with_wildcard_spec.rb' @@ -3622,7 +3547,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb' - 'qa/qa/specs/features/ee/api/3_create/wiki/group_wiki_repository_storage_move_spec.rb' - 'qa/qa/specs/features/ee/api/7_configure/kubernetes/kubernetes_agent_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_protect/policies_list_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' @@ -3630,21 +3554,14 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/upgrade_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/user_registration_billing_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/create_merge_request_with_secure_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_2_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/custom_email/custom_email_spec.rb' @@ -3674,13 +3591,11 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_status_on_operation_dashboard_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - - 'qa/qa/support/loglinking.rb' - 'qa/qa/support/run.rb' - 'qa/qa/support/ssh.rb' - 'qa/qa/tools/delete_projects.rb' @@ -3696,9 +3611,7 @@ Layout/LineLength: - 'qa/spec/specs/helpers/context_selector_spec.rb' - 'qa/spec/specs/helpers/quarantine_spec.rb' - 'qa/spec/specs/runner_spec.rb' - - 'qa/spec/support/loglinking_spec.rb' - 'qa/spec/support/page_error_checker_spec.rb' - - 'qa/spec/support/repeater_spec.rb' - 'qa/spec/support/run_spec.rb' - 'qa/spec/support/ssh_spec.rb' - 'rubocop/cop/active_model_errors_direct_manipulation.rb' @@ -3710,14 +3623,12 @@ Layout/LineLength: - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - 'rubocop/cop/migration/add_reference.rb' - 'rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction.rb' - - 'rubocop/cop/migration/safer_boolean_column.rb' - 'rubocop/cop/migration/versioned_migration_class.rb' - 'rubocop/cop/migration/with_lock_retries_disallowed_method.rb' - 'rubocop/cop/qa/selector_usage.rb' - 'rubocop/cop/rspec/top_level_describe_path.rb' - 'rubocop/cop/usage_data/large_table.rb' - 'scripts/api/cancel_pipeline.rb' - - 'scripts/api/download_job_artifact.rb' - 'scripts/api/get_job_id.rb' - 'scripts/changed-feature-flags' - 'scripts/failed_tests.rb' @@ -3728,7 +3639,6 @@ Layout/LineLength: - 'scripts/perf/query_limiting_report.rb' - 'scripts/pipeline_test_report_builder.rb' - 'scripts/review_apps/automated_cleanup.rb' - - 'scripts/rubocop-max-files-in-cache-check' - 'scripts/security-harness' - 'scripts/static-analysis' - 'scripts/trigger-build.rb' @@ -3737,18 +3647,14 @@ Layout/LineLength: - 'sidekiq_cluster/sidekiq_cluster.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' - - 'spec/config/metrics/aggregates/aggregated_metrics_spec.rb' - 'spec/config/settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/impersonations_controller_spec.rb' - 'spec/controllers/admin/projects_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - 'spec/controllers/concerns/check_rate_limit_spec.rb' - 'spec/controllers/concerns/confirm_email_warning_spec.rb' - - 'spec/controllers/concerns/issuable_actions_spec.rb' - 'spec/controllers/concerns/metrics_dashboard_spec.rb' - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - 'spec/controllers/concerns/send_file_upload_spec.rb' @@ -3842,7 +3748,6 @@ Layout/LineLength: - 'spec/db/schema_spec.rb' - 'spec/deprecation_toolkit_env.rb' - 'spec/experiments/concerns/project_commit_count_spec.rb' - - 'spec/experiments/require_verification_for_namespace_creation_experiment_spec.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/ci/job_artifacts.rb' - 'spec/factories/ci/pipelines.rb' @@ -3932,7 +3837,6 @@ Layout/LineLength: - 'spec/features/issues/user_creates_issue_spec.rb' - 'spec/features/issues/user_edits_issue_spec.rb' - 'spec/features/issues/user_interacts_with_awards_spec.rb' - - 'spec/features/issues/user_sees_empty_state_spec.rb' - 'spec/features/issues/user_sees_live_update_spec.rb' - 'spec/features/issues/user_views_issue_spec.rb' - 'spec/features/labels_hierarchy_spec.rb' @@ -3993,7 +3897,6 @@ Layout/LineLength: - 'spec/features/profiles/two_factor_auths_spec.rb' - 'spec/features/profiles/user_edit_profile_spec.rb' - 'spec/features/projects/artifacts/file_spec.rb' - - 'spec/features/projects/artifacts/user_browses_artifacts_spec.rb' - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - 'spec/features/projects/blobs/blob_line_permalink_updater_spec.rb' - 'spec/features/projects/blobs/blob_show_spec.rb' @@ -4055,7 +3958,6 @@ Layout/LineLength: - 'spec/features/projects_spec.rb' - 'spec/features/search/user_searches_for_comments_spec.rb' - 'spec/features/search/user_searches_for_merge_requests_spec.rb' - - 'spec/features/search/user_searches_for_projects_spec.rb' - 'spec/features/search/user_uses_header_search_field_spec.rb' - 'spec/features/security/project/internal_access_spec.rb' - 'spec/features/security/project/public_access_spec.rb' @@ -4152,7 +4054,6 @@ Layout/LineLength: - 'spec/graphql/mutations/issues/set_escalation_status_spec.rb' - 'spec/graphql/mutations/issues/update_spec.rb' - 'spec/graphql/mutations/merge_requests/set_labels_spec.rb' - - 'spec/graphql/mutations/namespace/package_settings/update_spec.rb' - 'spec/graphql/mutations/release_asset_links/update_spec.rb' - 'spec/graphql/mutations/releases/delete_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' @@ -4437,7 +4338,6 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - - 'spec/lib/gitlab/batch_pop_queueing_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/buffered_io_spec.rb' @@ -4473,7 +4373,6 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/parsers/coverage/cobertura_spec.rb' - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/sast_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/cancel_pending_pipelines_spec.rb' @@ -4500,7 +4399,6 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/npm_spec.rb' - 'spec/lib/gitlab/ci/variables/builder_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' @@ -4607,13 +4505,11 @@ Layout/LineLength: - 'spec/lib/gitlab/etag_caching/router/graphql_spec.rb' - 'spec/lib/gitlab/etag_caching/router/rails_spec.rb' - 'spec/lib/gitlab/exception_log_formatter_spec.rb' - - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb' - 'spec/lib/gitlab/git/base_error_spec.rb' - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/compare_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' - - 'spec/lib/gitlab/git/cross_repo_comparer_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/raw_diff_change_spec.rb' - 'spec/lib/gitlab/git/remote_mirror_spec.rb' @@ -4681,7 +4577,6 @@ Layout/LineLength: - 'spec/lib/gitlab/import_export/uploads_manager_spec.rb' - 'spec/lib/gitlab/import_export/version_checker_spec.rb' - 'spec/lib/gitlab/import_sources_spec.rb' - - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_interceptor_spec.rb' - 'spec/lib/gitlab/issuable_metadata_spec.rb' - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' @@ -4706,7 +4601,6 @@ Layout/LineLength: - 'spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/mail_room/authenticator_spec.rb' - - 'spec/lib/gitlab/merge_requests/commit_message_generator_spec.rb' - 'spec/lib/gitlab/metrics/background_transaction_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' @@ -4804,8 +4698,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins_spec.rb' - 'spec/lib/gitlab/usage/metrics/query_spec.rb' - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' @@ -4968,7 +4860,6 @@ Layout/LineLength: - 'spec/models/concerns/bulk_insert_safe_spec.rb' - 'spec/models/concerns/cache_markdown_field_spec.rb' - 'spec/models/concerns/cacheable_attributes_spec.rb' - - 'spec/models/concerns/cascading_namespace_setting_attribute_spec.rb' - 'spec/models/concerns/ci/artifactable_spec.rb' - 'spec/models/concerns/clusters/agents/authorization_config_scopes_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' @@ -5005,7 +4896,6 @@ Layout/LineLength: - 'spec/models/environment_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - 'spec/models/event_spec.rb' - - 'spec/models/experiment_spec.rb' - 'spec/models/gpg_key_spec.rb' - 'spec/models/grafana_integration_spec.rb' - 'spec/models/group_deploy_key_spec.rb' @@ -5031,9 +4921,7 @@ Layout/LineLength: - 'spec/models/integrations/drone_ci_spec.rb' - 'spec/models/integrations/emails_on_push_spec.rb' - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/packagist_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - - 'spec/models/integrations/slack_spec.rb' - 'spec/models/issue_spec.rb' - 'spec/models/jira_import_state_spec.rb' - 'spec/models/key_spec.rb' @@ -5239,7 +5127,6 @@ Layout/LineLength: - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/container_repositories_spec.rb' - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' - - 'spec/requests/api/graphql/project/issues_spec.rb' - 'spec/requests/api/graphql/project/jira_import_spec.rb' - 'spec/requests/api/graphql/project/jobs_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' @@ -5379,8 +5266,6 @@ Layout/LineLength: - 'spec/serializers/context_commits_diff_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diff_file_entity_spec.rb' - - 'spec/serializers/diffs_entity_spec.rb' - - 'spec/serializers/diffs_metadata_entity_spec.rb' - 'spec/serializers/discussion_entity_spec.rb' - 'spec/serializers/environment_entity_spec.rb' - 'spec/serializers/environment_serializer_spec.rb' @@ -5398,7 +5283,6 @@ Layout/LineLength: - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'spec/serializers/merge_request_serializer_spec.rb' - 'spec/serializers/merge_request_widget_entity_spec.rb' - - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/pipeline_serializer_spec.rb' - 'spec/serializers/review_app_setup_entity_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' @@ -5436,15 +5320,10 @@ Layout/LineLength: - 'spec/services/ci/test_failure_history_service_spec.rb' - 'spec/services/ci/unlock_artifacts_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' - - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' - - 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - - 'spec/services/clusters/applications/uninstall_service_spec.rb' - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb' - 'spec/services/clusters/aws/provision_service_spec.rb' - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - - 'spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb' @@ -5493,7 +5372,6 @@ Layout/LineLength: - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - 'spec/services/import/validate_remote_git_endpoint_service_spec.rb' - 'spec/services/incident_management/incidents/create_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' - 'spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb' - 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb' - 'spec/services/integrations/propagate_service_spec.rb' @@ -5563,7 +5441,6 @@ Layout/LineLength: - 'spec/services/milestones/transfer_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - - 'spec/services/namespaces/package_settings/update_service_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/copy_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' @@ -5599,7 +5476,6 @@ Layout/LineLength: - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - - 'spec/services/personal_access_tokens/revoke_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/apple_target_platform_detector_service_spec.rb' - 'spec/services/projects/autocomplete_service_spec.rb' @@ -5666,11 +5542,9 @@ Layout/LineLength: - 'spec/services/users/approve_service_spec.rb' - 'spec/services/users/ban_service_spec.rb' - 'spec/services/users/create_service_spec.rb' - - 'spec/services/users/migrate_to_ghost_user_service_spec.rb' - 'spec/services/users/reject_service_spec.rb' - 'spec/services/users/unban_service_spec.rb' - 'spec/services/users/upsert_credit_card_validation_service_spec.rb' - - 'spec/services/web_hook_service_spec.rb' - 'spec/services/web_hooks/log_execution_service_spec.rb' - 'spec/services/work_items/create_and_link_service_spec.rb' - 'spec/services/work_items/create_from_task_service_spec.rb' @@ -5683,7 +5557,6 @@ Layout/LineLength: - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - - 'spec/support/database/multiple_databases.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/db_cleaner.rb' @@ -5866,7 +5739,6 @@ Layout/LineLength: - 'spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb' - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - - 'spec/support/shared_examples/services/packages_shared_examples.rb' - 'spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb' - 'spec/support/shared_examples/services/rate_limited_service_shared_examples.rb' - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' @@ -5879,7 +5751,6 @@ Layout/LineLength: - 'spec/support/shared_examples/workers/concerns/git_garbage_collect_methods_shared_examples.rb' - 'spec/support/shared_examples/workers/gitlab/jira_import/jira_import_workers_shared_examples.rb' - 'spec/support/shared_examples/workers/project_export_shared_examples.rb' - - 'spec/support_specs/database/multiple_databases_spec.rb' - 'spec/support_specs/database/prevent_cross_joins_spec.rb' - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/helpers/graphql_helpers_spec.rb' @@ -5918,11 +5789,9 @@ Layout/LineLength: - 'spec/tooling/rspec_flaky/flaky_examples_collection_spec.rb' - 'spec/tooling/rspec_flaky/report_spec.rb' - 'spec/uploaders/ci/pipeline_artifact_uploader_spec.rb' - - 'spec/uploaders/external_diff_uploader_spec.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' - 'spec/uploaders/job_artifact_uploader_spec.rb' - - 'spec/uploaders/lfs_object_uploader_spec.rb' - 'spec/uploaders/namespace_file_uploader_spec.rb' - 'spec/uploaders/object_storage_spec.rb' - 'spec/uploaders/pages/deployment_uploader_spec.rb' @@ -5942,7 +5811,6 @@ Layout/LineLength: - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/notify/push_to_merge_request_email.text.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' - - 'spec/views/projects/artifacts/_artifact.html.haml_spec.rb' - 'spec/views/projects/commits/_commit.html.haml_spec.rb' - 'spec/views/projects/imports/new.html.haml_spec.rb' - 'spec/views/projects/jobs/_build.html.haml_spec.rb' @@ -5977,7 +5845,6 @@ Layout/LineLength: - 'spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb' - 'spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb' - 'spec/workers/ci/resource_groups/assign_resource_from_resource_group_worker_spec.rb' - - 'spec/workers/cluster_wait_for_app_update_worker_spec.rb' - 'spec/workers/clusters/integrations/check_prometheus_health_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' - 'spec/workers/concerns/project_import_options_spec.rb' diff --git a/.rubocop_todo/layout/multiline_operation_indentation.yml b/.rubocop_todo/layout/multiline_operation_indentation.yml index cdfa560ef2e..a000ec0dcda 100644 --- a/.rubocop_todo/layout/multiline_operation_indentation.yml +++ b/.rubocop_todo/layout/multiline_operation_indentation.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/MultilineOperationIndentation: Exclude: - 'app/components/pajamas/concerns/checkbox_radio_label_with_help_text.rb' @@ -16,43 +16,36 @@ Layout/MultilineOperationIndentation: - 'app/helpers/whats_new_helper.rb' - 'app/models/concerns/admin_changed_password_notifier.rb' - 'app/models/integrations/prometheus.rb' - - 'app/models/merge_request_diff_file.rb' - 'app/models/namespaces/traversal/linear_scopes.rb' - 'app/models/packages/conan/metadatum.rb' - 'app/models/packages/sem_ver.rb' - 'app/models/project.rb' - - 'app/models/project_statistics.rb' - 'app/models/user.rb' - 'app/models/work_items/parent_link.rb' - 'app/policies/project_policy.rb' - 'app/serializers/deploy_keys/deploy_key_entity.rb' - 'app/services/ci/create_downstream_pipeline_service.rb' - - 'app/services/ci/create_pipeline_service.rb' - 'app/services/git/branch_hooks_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/issues/update_service.rb' - 'app/services/labels/promote_service.rb' - 'app/services/labels/transfer_service.rb' - 'app/services/members/approve_access_request_service.rb' - - 'app/services/projects/container_repository/cleanup_tags_service.rb' - 'app/services/webauthn/authenticate_service.rb' - 'app/validators/feature_flag_strategies_validator.rb' - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' - 'app/workers/container_registry/migration/guard_worker.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'danger/utility_css/Dangerfile' - - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/boards_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - - 'ee/app/helpers/ee/groups/reporting_helper.rb' - 'ee/app/helpers/ee/projects/project_members_helper.rb' - 'ee/app/helpers/groups/security_features_helper.rb' - 'ee/app/helpers/groups/sso_helper.rb' - - 'ee/app/models/approval_project_rule.rb' - 'ee/app/models/concerns/ee/issuable.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/project.rb' @@ -68,52 +61,9 @@ Layout/MultilineOperationIndentation: - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/api/helpers.rb' - 'ee/lib/ee/api/settings.rb' - - 'ee/lib/ee/gitlab/git_access_project.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' - 'ee/lib/ee/sidebars/projects/menus/ci_cd_menu.rb' - 'ee/lib/ee/sidebars/projects/menus/issues_menu.rb' - - 'ee/lib/gitlab/incident_management.rb' - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' - - 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb' - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - - 'lib/api/maven_packages.rb' - - 'lib/api/users.rb' - - 'lib/api/validations/validators/array_none_any.rb' - - 'lib/gitlab/auth/o_auth/user.rb' - - 'lib/gitlab/ci/reports/security/finding_key.rb' - - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - - 'lib/gitlab/git_access.rb' - - 'lib/gitlab/gl_repository/repo_type.rb' - - 'lib/gitlab/jwt_token.rb' - - 'lib/gitlab/kubernetes/helm/v2/install_command.rb' - - 'lib/gitlab/kubernetes/helm/v2/patch_command.rb' - - 'lib/gitlab/kubernetes/helm/v3/install_command.rb' - - 'lib/gitlab/kubernetes/helm/v3/patch_command.rb' - - 'lib/gitlab/pagination/cursor_based_keyset.rb' - - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' - - 'lib/gitlab/rack_attack/request.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - - 'lib/gitlab/sidekiq_status.rb' - - 'lib/gitlab/x509/signature.rb' - - 'lib/gitlab_edition.rb' - - 'lib/kramdown/converter/commonmark.rb' - - 'lib/sidebars/groups/menus/packages_registries_menu.rb' - - 'lib/sidebars/projects/menus/analytics_menu.rb' - - 'lib/sidebars/projects/menus/deployments_menu.rb' - - 'lib/sidebars/projects/menus/hidden_menu.rb' - - 'lib/sidebars/projects/menus/monitor_menu.rb' - - 'qa/qa/ee/page/group/roadmap.rb' - - 'qa/qa/page/component/snippet.rb' - - 'qa/qa/runtime/api/repository_storage_moves.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - - 'rubocop/migration_helpers.rb' - - 'spec/controllers/graphql_controller_spec.rb' - - 'spec/frontend/fixtures/tabs.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/projects/import_export/export_service_spec.rb' - - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - - 'spec/support/shared_examples/models/with_debian_distributions_shared_examples.rb' diff --git a/.rubocop_todo/layout/space_around_operators.yml b/.rubocop_todo/layout/space_around_operators.yml index 9f6c0145723..1ddce55213e 100644 --- a/.rubocop_todo/layout/space_around_operators.yml +++ b/.rubocop_todo/layout/space_around_operators.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/SpaceAroundOperators: Exclude: - 'lib/gitlab/utils/strong_memoize.rb' diff --git a/.rubocop_todo/layout/space_before_block_braces.yml b/.rubocop_todo/layout/space_before_block_braces.yml index 3be90947fee..ff99ad7187a 100644 --- a/.rubocop_todo/layout/space_before_block_braces.yml +++ b/.rubocop_todo/layout/space_before_block_braces.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/SpaceBeforeBlockBraces: Exclude: - 'app/helpers/colors_helper.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index f025680c209..73b8a354a58 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -1,29 +1,8 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/SpaceInLambdaLiteral: - # Offense count: 986 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/projects/ci/daily_build_group_report_results_controller.rb' - - 'app/controllers/projects/merge_requests/diffs_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/finders/releases/group_releases_finder.rb' - - 'app/finders/user_recent_events_finder.rb' - - 'app/graphql/types/permission_types/base_permission_type.rb' - - 'app/models/abuse_report.rb' - - 'app/models/alert_management/alert.rb' - - 'app/models/alert_management/http_integration.rb' - - 'app/models/analytics/cycle_analytics/aggregation.rb' - - 'app/models/analytics/usage_trends/measurement.rb' - - 'app/models/application_setting.rb' - - 'app/models/audit_event.rb' - - 'app/models/award_emoji.rb' - - 'app/models/board_group_recent_visit.rb' - - 'app/models/board_project_recent_visit.rb' - - 'app/models/bulk_import.rb' - - 'app/models/bulk_imports/entity.rb' - 'app/models/bulk_imports/tracker.rb' - 'app/models/ci/build.rb' - 'app/models/ci/daily_build_group_report_result.rb' @@ -47,7 +26,7 @@ Layout/SpaceInLambdaLiteral: - 'app/models/commit_status.rb' - 'app/models/concerns/analytics/cycle_analytics/stage.rb' - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' - - 'app/models/concerns/approvable_base.rb' + - 'app/models/concerns/approvable.rb' - 'app/models/concerns/ci/artifactable.rb' - 'app/models/concerns/ci/has_status.rb' - 'app/models/concerns/ci/has_variable.rb' @@ -55,6 +34,7 @@ Layout/SpaceInLambdaLiteral: - 'app/models/concerns/has_unique_internal_users.rb' - 'app/models/concerns/id_in_ordered.rb' - 'app/models/concerns/incident_management/escalatable.rb' + - 'app/models/concerns/issuable.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/milestoneable.rb' - 'app/models/concerns/protected_ref_access.rb' @@ -68,10 +48,14 @@ Layout/SpaceInLambdaLiteral: - 'app/models/design_management/version.rb' - 'app/models/diff_note.rb' - 'app/models/environment.rb' + - 'app/models/error_tracking/client_key.rb' - 'app/models/error_tracking/error.rb' - 'app/models/external_pull_request.rb' - 'app/models/group.rb' + - 'app/models/group_group_link.rb' + - 'app/models/incident_management/timeline_event_tag.rb' - 'app/models/integration.rb' + - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/datadog.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -107,6 +91,7 @@ Layout/SpaceInLambdaLiteral: - 'app/models/project_feature_usage.rb' - 'app/models/project_group_link.rb' - 'app/models/project_statistics.rb' + - 'app/models/projects/import_export/relation_export.rb' - 'app/models/projects/topic.rb' - 'app/models/prometheus_alert.rb' - 'app/models/prometheus_alert_event.rb' @@ -116,14 +101,15 @@ Layout/SpaceInLambdaLiteral: - 'app/models/release.rb' - 'app/models/route.rb' - 'app/models/service_desk_setting.rb' - - 'app/models/snippet.rb' - 'app/models/snippet_input_action.rb' - 'app/models/terraform/state.rb' - 'app/models/timelog.rb' - 'app/models/todo.rb' - 'app/models/user.rb' - 'app/models/user_highest_role.rb' + - 'app/models/users/callout.rb' - 'app/models/users/in_product_marketing_email.rb' + - 'app/models/users/phone_number_validation.rb' - 'app/models/users_star_project.rb' - 'app/models/zoom_meeting.rb' - 'app/serializers/analytics/cycle_analytics/stage_entity.rb' @@ -139,6 +125,7 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/concerns/user_status_tooltip.rb' - 'app/serializers/container_repository_entity.rb' - 'app/serializers/container_tag_entity.rb' + - 'app/serializers/deploy_keys/basic_deploy_key_entity.rb' - 'app/serializers/deployment_cluster_entity.rb' - 'app/serializers/deployment_entity.rb' - 'app/serializers/detailed_status_entity.rb' @@ -160,6 +147,7 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/merge_request_poll_cached_widget_entity.rb' - 'app/serializers/merge_request_poll_widget_entity.rb' - 'app/serializers/merge_request_widget_entity.rb' + - 'app/serializers/merge_requests/pipeline_entity.rb' - 'app/serializers/note_entity.rb' - 'app/serializers/project_note_entity.rb' - 'app/serializers/review_app_setup_entity.rb' @@ -173,13 +161,16 @@ Layout/SpaceInLambdaLiteral: - 'app/services/ci/job_artifacts/expire_project_build_artifacts_service.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/environments/auto_stop_service.rb' + - 'app/services/incident_management/timeline_events/create_service.rb' - 'app/services/issues/export_csv_service.rb' - 'app/services/issues/referenced_merge_requests_service.rb' - 'app/services/jira_connect_subscriptions/create_service.rb' - 'app/services/merge_requests/export_csv_service.rb' + - 'app/services/packages/mark_packages_for_destruction_service.rb' - 'app/services/projects/fork_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/workers/issues/reschedule_stuck_issue_rebalances_worker.rb' + - 'app/workers/process_commit_worker.rb' - 'config/initializers/deprecations.rb' - 'config/routes/project.rb' - 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb' @@ -196,27 +187,32 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/ci/minutes/project_monthly_usage.rb' - 'ee/app/models/concerns/approval_rule_like.rb' - 'ee/app/models/concerns/ee/protected_ref.rb' + - 'ee/app/models/concerns/filterable_by_test_reports.rb' - 'ee/app/models/concerns/issue_widgets/acts_like_requirement.rb' - 'ee/app/models/dast/profile.rb' - 'ee/app/models/dast/profile_schedule.rb' - - 'ee/app/models/dast/site_profile_secret_variable.rb' - 'ee/app/models/dast_scanner_profile.rb' - 'ee/app/models/dast_site_profile.rb' - 'ee/app/models/dast_site_validation.rb' - 'ee/app/models/dora/daily_metrics.rb' + - 'ee/app/models/ee/application_setting.rb' - 'ee/app/models/ee/audit_event.rb' - 'ee/app/models/ee/ci/build.rb' - 'ee/app/models/ee/ci/job_artifact.rb' + - 'ee/app/models/ee/clusters/agent.rb' - 'ee/app/models/ee/environment.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/gpg_key.rb' - 'ee/app/models/ee/group.rb' + - 'ee/app/models/ee/group_group_link.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/list.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/namespace.rb' + - 'ee/app/models/ee/namespace_setting.rb' - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/project_group_link.rb' - 'ee/app/models/ee/release.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/elasticsearch_indexed_namespace.rb' @@ -232,6 +228,7 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/merge_request_block.rb' - 'ee/app/models/merge_requests/compliance_violation.rb' - 'ee/app/models/merge_train.rb' + - 'ee/app/models/namespaces/namespace_ban.rb' - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/models/resource_iteration_event.rb' - 'ee/app/models/saml_group_link.rb' @@ -241,6 +238,7 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/security/scan.rb' - 'ee/app/models/security/training.rb' - 'ee/app/models/security/training_provider.rb' + - 'ee/app/models/slack_integration.rb' - 'ee/app/models/software_license.rb' - 'ee/app/models/software_license_policy.rb' - 'ee/app/models/vulnerabilities/external_issue_link.rb' @@ -255,6 +253,7 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/vulnerabilities/read.rb' - 'ee/app/models/vulnerabilities/remediation.rb' - 'ee/app/models/vulnerabilities/scanner.rb' + - 'ee/app/models/vulnerabilities/statistic.rb' - 'ee/app/serializers/blocking_merge_request_entity.rb' - 'ee/app/serializers/clusters/environment_entity.rb' - 'ee/app/serializers/dashboard_operations_project_entity.rb' @@ -289,22 +288,26 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/services/user_permissions/export_service.rb' - 'ee/app/services/vulnerability_exports/exporters/csv_service.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - - 'ee/lib/api/entities/iteration.rb' - 'ee/lib/api/entities/pending_member.rb' + - 'ee/lib/api/ml/ai_assist.rb' - 'ee/lib/ee/api/entities/ci/job_request/response.rb' - 'ee/lib/ee/api/entities/epic.rb' - - 'ee/lib/ee/api/entities/geo_node_status.rb' - 'ee/lib/ee/api/entities/issue.rb' - 'ee/lib/ee/api/entities/list.rb' - 'ee/lib/ee/api/entities/member.rb' - 'ee/lib/ee/api/entities/project_approval_rule.rb' - 'ee/lib/ee/api/entities/user_basic.rb' - 'ee/lib/ee/api/entities/vulnerability_issue_link.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' + - 'ee/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_approval_merge_request_rules_with_security_orchestration.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb' - 'ee/lib/ee/gitlab/ci/config/entry/need.rb' - 'ee/lib/ee/gitlab/event_store.rb' - 'ee/lib/gitlab/ci/config/entry/vault/secret.rb' + - 'ee/lib/gitlab/insights/executors/dora_executor.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' @@ -318,7 +321,6 @@ Layout/SpaceInLambdaLiteral: - 'lib/api/entities/ci/variable.rb' - 'lib/api/entities/container_registry.rb' - 'lib/api/entities/deploy_key.rb' - - 'lib/api/entities/environment.rb' - 'lib/api/entities/event.rb' - 'lib/api/entities/group.rb' - 'lib/api/entities/invitation.rb' @@ -335,18 +337,27 @@ Layout/SpaceInLambdaLiteral: - 'lib/api/files.rb' - 'lib/api/helm_packages.rb' - 'lib/api/helpers/caching.rb' + - 'lib/api/merge_requests.rb' + - 'lib/api/metadata.rb' - 'lib/api/metrics/dashboard/annotations.rb' + - 'lib/api/ml/mlflow.rb' - 'lib/api/releases.rb' - - 'lib/api/repositories.rb' - 'lib/api/settings.rb' - 'lib/api/tags.rb' + - 'lib/api/unleash.rb' - 'lib/api/users.rb' - - 'lib/api/version.rb' - 'lib/atlassian/jira_connect/serializers/author_entity.rb' + - 'lib/bulk_imports/groups/transformers/group_attributes_transformer.rb' - 'lib/container_registry/base_client.rb' - 'lib/container_registry/client.rb' + - 'lib/event_filter.rb' - 'lib/file_size_validator.rb' + - 'lib/gitlab/analytics/date_filler.rb' + - 'lib/gitlab/background_migration/backfill_internal_on_notes.rb' + - 'lib/gitlab/background_migration/backfill_project_namespace_on_issues.rb' + - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' + - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/cache/helpers.rb' - 'lib/gitlab/ci/config/entry/inherit/default.rb' @@ -356,29 +367,33 @@ Layout/SpaceInLambdaLiteral: - 'lib/gitlab/ci/config/entry/policy.rb' - 'lib/gitlab/ci/config/entry/product/parallel.rb' - 'lib/gitlab/ci/config/entry/retry.rb' + - 'lib/gitlab/ci/config/entry/rules/rule/changes.rb' - 'lib/gitlab/ci/config/entry/trigger.rb' + - 'lib/gitlab/ci/config/entry/variable.rb' - 'lib/gitlab/database/background_migration_job.rb' - 'lib/gitlab/email/handler/unsubscribe_handler.rb' + - 'lib/gitlab/event_store.rb' - 'lib/gitlab/gl_repository.rb' + - 'lib/gitlab/health_checks/server.rb' - 'lib/gitlab/import_export/import_failure_service.rb' - - 'lib/gitlab/merge_requests/commit_message_generator.rb' + - 'lib/gitlab/merge_requests/message_generator.rb' - 'lib/gitlab/metrics/dashboard/transformers/yml/v1/prometheus_metrics.rb' - 'lib/gitlab/metrics/exporter/base_exporter.rb' - 'lib/gitlab/visibility_level.rb' - - 'rubocop/cop/rspec/modify_sidekiq_middleware.rb' - - 'rubocop/cop/rspec/timecop_freeze.rb' - - 'rubocop/cop/rspec/timecop_travel.rb' - 'spec/deprecation_toolkit_env.rb' - 'spec/features/admin/users/user_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/container_registry/client_spec.rb' - 'spec/lib/csv_builder_spec.rb' + - 'spec/lib/gitlab/analytics/date_filler_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb' - 'spec/lib/gitlab/database/consistency_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb' - 'spec/lib/gitlab/event_store/store_spec.rb' - - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/middleware/handle_ip_spoof_attack_error_spec.rb' - 'spec/lib/gitlab/middleware/request_context_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' @@ -393,4 +408,5 @@ Layout/SpaceInLambdaLiteral: - 'spec/models/concerns/uniquify_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/support/shared_examples/lib/cache_helpers_shared_examples.rb' + - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - 'spec/workers/concerns/worker_context_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml index c775ad94e46..07cd163103e 100644 --- a/.rubocop_todo/layout/space_inside_block_braces.yml +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/SpaceInsideBlockBraces: Exclude: - 'spec/requests/api/groups_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index e6238992619..69508e309e3 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -1,34 +1,43 @@ --- # Cop supports --autocorrect. Layout/SpaceInsideParens: - # Offense count: 701 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - - 'config/initializers/wikicloth_redos_patch.rb' - 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb' + - 'ee/app/models/ee/dependency_proxy/blob.rb' + - 'ee/app/models/ee/dependency_proxy/manifest.rb' + - 'ee/app/services/gitlab_subscriptions/notify_seats_exceeded_batch_service.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/gitlab/auth/smartcard/session.rb' + - 'ee/lib/system_check/geo/current_node_check.rb' + - 'ee/spec/controllers/projects/mirrors_controller_spec.rb' + - 'ee/spec/features/groups/saml_enforcement_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/finders/security/vulnerability_feedbacks_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' - 'ee/spec/frontend/fixtures/epic.rb' + - 'ee/spec/frontend/fixtures/namespace.rb' - 'ee/spec/frontend/fixtures/projects.rb' + - 'ee/spec/lib/gitlab/search/index_curator_spec.rb' + - 'ee/spec/lib/world_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb' - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' + - 'ee/spec/models/audit_events/external_audit_event_destination_spec.rb' - 'ee/spec/models/boards/epic_board_position_spec.rb' - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/models/ee/key_spec.rb' + - 'ee/spec/models/ee/project_setting_spec.rb' - 'ee/spec/models/ee/system_note_metadata_spec.rb' - 'ee/spec/models/geo/every_geo_event_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' - 'ee/spec/models/ip_restriction_spec.rb' - - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/ldap_group_link_spec.rb' - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/member_spec.rb' @@ -39,6 +48,7 @@ Layout/SpaceInsideParens: - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - 'ee/spec/requests/api/graphql/group/epics_spec.rb' + - 'ee/spec/requests/api/graphql/iteration_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' - 'ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb' - 'ee/spec/requests/api/group_boards_spec.rb' @@ -51,48 +61,47 @@ Layout/SpaceInsideParens: - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/runner_service_spec.rb' - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/base_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/create_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb' - 'ee/spec/services/ci_cd/github_setup_service_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/epic_issues/update_service_spec.rb' + - 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb' + - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' + - 'ee/spec/services/groups/update_service_spec.rb' + - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' + - 'ee/spec/services/search/global_service_spec.rb' - 'ee/spec/services/search/group_service_spec.rb' - 'ee/spec/services/search/project_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/exporters/csv_service_spec.rb' + - 'ee/spec/support/shared_examples/finders/epics_findable_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb' - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' - 'ee/spec/workers/security/auto_fix_worker_spec.rb' - - 'ee/spec/workers/security/create_orchestration_policy_worker_spec.rb' - - 'lib/backup/files.rb' - - 'lib/gitlab/ci/reports/security/finding.rb' - - 'lib/gitlab/ci/runner_instructions.rb' - - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - - 'lib/gitlab/database/postgres_hll/buckets.rb' - - 'lib/gitlab/diff/parser.rb' - - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - - 'lib/gitlab/gitaly_client/commit_service.rb' - - 'lib/gitlab/prometheus_client.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - - 'lib/gitlab/tracking/incident_management.rb' - - 'lib/gitlab/visibility_level.rb' - - 'lib/security/ci_configuration/sast_build_action.rb' - 'qa/qa/page/group/settings/group_deploy_tokens.rb' - - 'qa/qa/page/merge_request/show.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/scan_result_policy_vulnerabilities_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb' - 'qa/qa/tools/delete_subgroups.rb' - 'qa/spec/runtime/feature_spec.rb' - - 'qa/spec/scenario/template_spec.rb' - 'spec/dependencies/omniauth_saml_spec.rb' + - 'spec/factories/ml/candidates.rb' - 'spec/factories/usage_data.rb' - 'spec/finders/alert_management/http_integrations_finder_spec.rb' - 'spec/finders/events_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' + - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/badges_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - 'spec/helpers/ci/runners_helper_spec.rb' @@ -112,30 +121,33 @@ Layout/SpaceInsideParens: - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - 'spec/lib/bitbucket_server/representation/comment_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/namespace_settings_pipeline_spec.rb' - 'spec/lib/error_tracking/sentry_client/projects_spec.rb' - 'spec/lib/error_tracking/sentry_client/repo_spec.rb' + - 'spec/lib/feature/gitaly_spec.rb' - 'spec/lib/gitlab/app_text_logger_spec.rb' - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/ci/build/image_spec.rb' - 'spec/lib/gitlab/ci/config/entry/reports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/trigger_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/parsers_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/MATLAB_spec.rb' - 'spec/lib/gitlab/ci/templates/Terraform/base_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Terraform/base_latest_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/flutter_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/kaniko_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/katalon_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/npm_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_projects_spec.rb' @@ -146,9 +158,10 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' - 'spec/lib/gitlab/graphql/lazy_spec.rb' - - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/health_checks/simple_check_shared.rb' - 'spec/lib/gitlab/highlight_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' @@ -156,11 +169,11 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' + - 'spec/lib/gitlab/import_export/recursive_merge_folders_spec.rb' - 'spec/lib/gitlab/issuables_count_for_state_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - - 'spec/lib/gitlab/puma_logging/json_formatter_spec.rb' - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' - 'spec/lib/gitlab/redis/queues_spec.rb' @@ -173,6 +186,7 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' + - 'spec/lib/gitlab/x509/commit_spec.rb' - 'spec/lib/security/ci_configuration/container_scanning_build_action_spec.rb' - 'spec/lib/security/ci_configuration/sast_build_action_spec.rb' - 'spec/lib/security/ci_configuration/sast_iac_build_action_spec.rb' @@ -180,8 +194,12 @@ Layout/SpaceInsideParens: - 'spec/mailers/emails/profile_spec.rb' - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - 'spec/migrations/backfill_issues_upvotes_count_spec.rb' - - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' + - 'spec/models/ci/pending_build_spec.rb' + - 'spec/models/ci/running_build_spec.rb' + - 'spec/models/ml/candidate_metric_spec.rb' + - 'spec/models/ml/candidate_spec.rb' - 'spec/policies/clusters/agent_policy_spec.rb' + - 'spec/policies/user_policy_spec.rb' - 'spec/presenters/ci/build_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/requests/jwt_controller_spec.rb' @@ -190,16 +208,20 @@ Layout/SpaceInsideParens: - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/requests/search_controller_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - - 'spec/serializers/merge_request_user_entity_spec.rb' + - 'spec/services/bulk_imports/create_service_spec.rb' + - 'spec/services/jira_connect_installations/proxy_lifecycle_event_service_spec.rb' + - 'spec/services/users/destroy_service_spec.rb' - 'spec/support/helpers/database/partitioning_helpers.rb' - 'spec/support/helpers/dependency_proxy_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' + - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - 'spec/support/shared_examples/ci/badge_template_shared_examples.rb' - 'spec/support/shared_examples/controllers/destroy_hook_shared_examples.rb' - 'spec/support/shared_examples/features/project_features_apply_to_issuables_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/finders/packages/debian/distributions_finder_shared_examples.rb' + - 'spec/support/shared_examples/graphql/types/gitlab_style_deprecations_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/position_formatters_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb' - 'spec/support/shared_examples/mailers/notify_shared_examples.rb' @@ -210,7 +232,11 @@ Layout/SpaceInsideParens: - 'spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/validators/devise_email_validator_spec.rb' + - 'spec/views/dashboard/projects/_blank_state_welcome.html.haml_spec.rb' + - 'spec/views/profiles/keys/_form.html.haml_spec.rb' + - 'spec/views/search/_results.html.haml_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' + - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' - 'spec/workers/pipeline_schedule_worker_spec.rb' - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml index 8e3e0795c03..2cb6c81256c 100644 --- a/.rubocop_todo/layout/trailing_whitespace.yml +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/TrailingWhitespace: Exclude: - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' @@ -9,7 +9,6 @@ Layout/TrailingWhitespace: - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' - - 'qa/qa/specs/features/browser_ui/7_configure/auto_devops/create_project_with_auto_devops_spec.rb' - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/support/helpers/x509_helpers.rb' diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml index fc70f4870b1..ff3f6b2afbc 100644 --- a/.rubocop_todo/lint/constant_definition_in_block.yml +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -1,8 +1,6 @@ --- Lint/ConstantDefinitionInBlock: - # Offense count: 105 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/concerns/ignorable_columns.rb' - 'app/models/concerns/partitioned_table.rb' @@ -10,13 +8,16 @@ Lint/ConstantDefinitionInBlock: - 'config/application.rb' - 'config/initializers/direct_upload_support.rb' - 'config/initializers/elastic_client_setup.rb' + - 'ee/app/graphql/ee/types/work_items/widget_interface.rb' - 'ee/app/models/concerns/ee/issuable_link.rb' - 'ee/app/models/ee/application_setting.rb' - 'ee/app/models/ee/ci/job_artifact.rb' - 'ee/app/models/ee/ci/pipeline.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/merge_request_diff.rb' + - 'ee/app/models/ee/namespace_setting.rb' - 'ee/app/models/ee/plan.rb' - 'ee/app/models/ee/project_import_state.rb' - 'ee/app/models/ee/user.rb' @@ -31,8 +32,13 @@ Lint/ConstantDefinitionInBlock: - 'lib/gitlab/quick_actions/issue_actions.rb' - 'lib/tasks/cache.rake' - 'lib/tasks/dev.rake' + - 'lib/tasks/gitlab/backup.rake' + - 'lib/tasks/gitlab/db.rake' + - 'lib/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences.rake' + - 'lib/tasks/gitlab/db/validate_config.rake' - 'lib/tasks/gitlab/docs/compile_deprecations.rake' - 'lib/tasks/gitlab/graphql.rake' + - 'lib/tasks/gitlab/metrics_exporter.rake' - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake' - 'lib/tasks/gitlab/snippets.rake' - 'lib/tasks/gitlab/tw/codeowners.rake' @@ -47,5 +53,4 @@ Lint/ConstantDefinitionInBlock: - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - 'spec/models/concerns/triggerable_hooks_spec.rb' - 'spec/models/repository_spec.rb' - - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 5e1421c0f3e..e0b2afe8256 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -147,7 +147,6 @@ Lint/MissingCopEnableDirective: - 'ee/lib/api/scim.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/gitlab/spdx/license.rb' - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb' @@ -189,7 +188,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - 'lib/gitlab/gon_helper.rb' - - 'lib/gitlab/graphql/pagination/keyset/last_items.rb' - 'lib/gitlab/graphql/standard_graphql_error.rb' - 'lib/gitlab/metrics/methods.rb' - 'lib/gitlab/patch/action_cable_redis_listener.rb' diff --git a/.rubocop_todo/lint/mixed_regexp_capture_types.yml b/.rubocop_todo/lint/mixed_regexp_capture_types.yml index 3dcb9427ef8..70f3773eb31 100644 --- a/.rubocop_todo/lint/mixed_regexp_capture_types.yml +++ b/.rubocop_todo/lint/mixed_regexp_capture_types.yml @@ -12,4 +12,4 @@ Lint/MixedRegexpCaptureTypes: - 'lib/gitlab/metrics/system.rb' - 'lib/gitlab/slash_commands/issue_move.rb' - 'lib/gitlab/slash_commands/issue_new.rb' - - 'lib/gitlab/slash_commands/run.rb'
\ No newline at end of file + - 'lib/gitlab/slash_commands/run.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index b0b5697536e..a2dd002b54f 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -1,12 +1,12 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Lint/RedundantCopDisableDirective: - # Used to be enabled in "grace period" and is now disabled due to too many - # silenced offenses. - # See https://gitlab.com/gitlab-org/gitlab/-/issues/376133 + # Offense count: 357 + # Temporarily disabled due to too many offenses Enabled: false Exclude: - 'app/controllers/concerns/enforces_two_factor_authentication.rb' + - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/web_hooks/hook_log_actions.rb' - 'app/controllers/groups/autocomplete_sources_controller.rb' - 'app/controllers/groups/labels_controller.rb' @@ -14,7 +14,6 @@ Lint/RedundantCopDisableDirective: - 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb' - 'app/finders/autocomplete/move_to_project_finder.rb' - 'app/finders/autocomplete/routes_finder.rb' - - 'app/finders/autocomplete/users_finder.rb' - 'app/finders/ci/daily_build_group_report_results_finder.rb' - 'app/finders/ci/runner_jobs_finder.rb' - 'app/finders/groups_finder.rb' @@ -24,6 +23,7 @@ Lint/RedundantCopDisableDirective: - 'app/graphql/resolvers/project_milestones_resolver.rb' - 'app/graphql/types/base_enum.rb' - 'app/graphql/types/ci/runner_web_url_edge.rb' + - 'app/graphql/types/commit_signatures/verification_status_enum.rb' - 'app/graphql/types/packages/helm/dependency_type.rb' - 'app/graphql/types/projects/service_type_enum.rb' - 'app/helpers/diff_helper.rb' @@ -34,6 +34,7 @@ Lint/RedundantCopDisableDirective: - 'app/models/concerns/from_except.rb' - 'app/models/concerns/from_intersect.rb' - 'app/models/concerns/from_union.rb' + - 'app/models/concerns/redis_cacheable.rb' - 'app/models/project_statistics.rb' - 'app/models/user.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' @@ -43,7 +44,9 @@ Lint/RedundantCopDisableDirective: - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' + - 'app/services/ci/runners/bulk_delete_runners_service.rb' - 'app/services/database/consistency_check_service.rb' + - 'app/services/groups/import_export/import_service.rb' - 'app/services/issues/export_csv_service.rb' - 'app/services/labels/transfer_service.rb' - 'app/services/members/create_service.rb' @@ -52,8 +55,9 @@ Lint/RedundantCopDisableDirective: - 'app/services/members/standard_member_builder.rb' - 'app/services/projects/auto_devops/disable_service.rb' - 'app/services/projects/open_issues_count_service.rb' + - 'app/services/releases/create_service.rb' + - 'app/services/releases/update_service.rb' - 'app/services/spam/spam_action_service.rb' - - 'app/services/users/migrate_to_ghost_user_service.rb' - 'app/services/web_hook_service.rb' - 'app/uploaders/object_storage/cdn/google_ip_cache.rb' - 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb' @@ -85,6 +89,7 @@ Lint/RedundantCopDisableDirective: - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb' + - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' @@ -103,13 +108,12 @@ Lint/RedundantCopDisableDirective: - 'ee/app/models/dast/branch.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/event_log.rb' + - 'ee/app/models/protected_environments/approval_rules/summarizable.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/search_service.rb' - - 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb' - - 'ee/app/services/geo/repository_base_sync_service.rb' - 'ee/app/workers/ee/issuable_export_csv_worker.rb' - 'ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb' - 'ee/app/workers/geo/design_repository_shard_sync_worker.rb' @@ -120,6 +124,7 @@ Lint/RedundantCopDisableDirective: - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb' - 'ee/lib/analytics/merge_request_metrics_calculator.rb' - 'ee/lib/api/audit_events.rb' + - 'ee/lib/api/dora/metrics.rb' - 'ee/lib/api/scim.rb' - 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' @@ -131,12 +136,15 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/gitlab/elastic/bool_expr.rb' - 'ee/lib/gitlab/spdx/license.rb' - 'ee/lib/gitlab/status_page/storage/object.rb' + - 'ee/spec/contracts/provider/pact_helpers/project/merge_request/show/suggested_reviewers_helper.rb' + - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - 'ee/spec/helpers/ee/releases_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' @@ -181,13 +189,14 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/database/migrations/observation.rb' - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' - 'lib/gitlab/diff/file.rb' - - 'lib/gitlab/diff/file_collection/merge_request_diff_batch.rb' + - 'lib/gitlab/diff/file_collection/paginated_diffs.rb' - 'lib/gitlab/diff/pair_selector.rb' - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/encrypted_ldap_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/patches/collection.rb' + - 'lib/gitlab/github_import/markdown_text.rb' - 'lib/gitlab/github_import/user_finder.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' @@ -211,8 +220,9 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/utils/usage_data.rb' - 'lib/gitlab/x509/signature.rb' - 'lib/tasks/gitlab/cleanup.rake' - - 'qa/tasks/ci.rake' - - 'scripts/lib/glfm/render_static_html.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb' - 'scripts/security-harness' - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' @@ -225,7 +235,6 @@ Lint/RedundantCopDisableDirective: - 'spec/graphql/mutations/commits/create_spec.rb' - 'spec/graphql/resolvers/base_resolver_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - - 'spec/initializers/memory_watchdog_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' @@ -241,6 +250,7 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/git/tree_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' + - 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - 'spec/lib/gitlab/rack_attack/request_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' @@ -252,6 +262,7 @@ Lint/RedundantCopDisableDirective: - 'spec/migrations/reschedule_backfill_imported_issue_search_data_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/concerns/encrypted_user_password_spec.rb' - 'spec/models/namespace/package_setting_spec.rb' - 'spec/models/namespace_spec.rb' - 'spec/models/project_feature_spec.rb' @@ -263,6 +274,7 @@ Lint/RedundantCopDisableDirective: - 'spec/requests/api/graphql/ci/config_spec.rb' - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/services/alert_management/metric_images/upload_service_spec.rb' + - 'spec/services/boards/lists/list_service_spec.rb' - 'spec/services/projects/update_statistics_service_spec.rb' - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/services/topics/merge_service_spec.rb' diff --git a/.rubocop_todo/metrics/abc_size.yml b/.rubocop_todo/metrics/abc_size.yml index f5646151592..01e7a5c9688 100644 --- a/.rubocop_todo/metrics/abc_size.yml +++ b/.rubocop_todo/metrics/abc_size.yml @@ -1,15 +1,11 @@ --- Metrics/AbcSize: Exclude: - - 'app/controllers/concerns/issuable_actions.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/nav/top_nav_helper.rb' - - 'app/helpers/search_helper.rb' - 'app/models/instance_configuration.rb' - 'app/services/projects/create_service.rb' - - 'ee/app/workers/elastic/migration_worker.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' + - 'ee/db/seeds/awesome_co/awesome_co.rb' - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - 'qa/qa/resource/repository/push.rb' - - 'ee/db/seeds/awesome_co/**/*.rb' diff --git a/.rubocop_todo/metrics/cyclomatic_complexity.yml b/.rubocop_todo/metrics/cyclomatic_complexity.yml index 71efe9d5a3a..634ec6221f4 100644 --- a/.rubocop_todo/metrics/cyclomatic_complexity.yml +++ b/.rubocop_todo/metrics/cyclomatic_complexity.yml @@ -13,11 +13,9 @@ Metrics/CyclomaticComplexity: - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/utils/merge_hash.rb' - 'lib/kramdown/parser/atlassian_document_format.rb' - 'qa/qa/runtime/browser.rb' - 'qa/qa/support/repeater.rb' - - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'sidekiq_cluster/cli.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/metrics/perceived_complexity.yml b/.rubocop_todo/metrics/perceived_complexity.yml index 0f2d3030064..5f5f1858ed6 100644 --- a/.rubocop_todo/metrics/perceived_complexity.yml +++ b/.rubocop_todo/metrics/perceived_complexity.yml @@ -11,13 +11,10 @@ Metrics/PerceivedComplexity: - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/banzai/renderer.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/utils/merge_hash.rb' - 'qa/qa/runtime/browser.rb' - - 'qa/qa/specs/runner.rb' - 'qa/qa/support/repeater.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'sidekiq_cluster/cli.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index 9e42e85cce8..56b6a4294d4 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -2,10 +2,9 @@ Migration/BackgroundMigrationBaseClass: Exclude: - 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb' - - 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb' - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' + - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' @@ -16,14 +15,12 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb' - 'lib/gitlab/background_migration/backfill_user_namespace.rb' - - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' @@ -31,7 +28,6 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' @@ -42,8 +38,9 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/legacy_uploads_migrator.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' + - 'lib/gitlab/background_migration/legacy_uploads_migrator.rb' + - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' @@ -63,28 +60,21 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_status_column_of_security_scans.rb' - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' + - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' + - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' + - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_vulnerability_finding_links.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - 'lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users.rb' - - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb' - 'lib/gitlab/background_migration/update_timelogs_project_id.rb' - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' diff --git a/.rubocop_todo/migration/background_migration_record.yml b/.rubocop_todo/migration/background_migration_record.yml index b4feb944d75..567926e33a2 100644 --- a/.rubocop_todo/migration/background_migration_record.yml +++ b/.rubocop_todo/migration/background_migration_record.yml @@ -1,54 +1,50 @@ --- Migration/BackgroundMigrationRecord: Exclude: - - lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb - - lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb - - lib/gitlab/background_migration/backfill_ci_project_mirrors.rb - - lib/gitlab/background_migration/backfill_ci_queuing_tables.rb - - lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb - - lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb - - lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb - - lib/gitlab/background_migration/backfill_project_repositories.rb - - lib/gitlab/background_migration/backfill_projects_with_coverage.rb - - lib/gitlab/background_migration/backfill_topics_title.rb - - lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb - - lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb - - lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb - - lib/gitlab/background_migration/drop_invalid_security_findings.rb - - lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb - - lib/gitlab/background_migration/encrypt_integration_properties.rb - - lib/gitlab/background_migration/encrypt_static_object_token.rb - - lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb - - lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb - - lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb - - lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb - - lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb - - lib/gitlab/background_migration/merge_topics_with_same_name.rb - - lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb - - lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb - - lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb - - lib/gitlab/background_migration/migrate_u2f_webauthn.rb - - lib/gitlab/background_migration/populate_latest_pipeline_ids.rb - - lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb - - lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb - - lib/gitlab/background_migration/project_namespaces/models/namespace.rb - - lib/gitlab/background_migration/project_namespaces/models/project.rb - - lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb - - lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb - - lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb - - lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb - - lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb - - lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb - - lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb - - ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb - - ee/lib/ee/gitlab/background_migration/create_security_setting.rb - - ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb - - ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb - - ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb - - ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb - - ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb - - ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb - - ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb - - ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb - - ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb - - ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb + - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' + - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' + - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' + - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' + - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' + - 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb' + - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' + - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' + - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' + - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' + - 'lib/gitlab/background_migration/backfill_project_repositories.rb' + - 'lib/gitlab/background_migration/backfill_topics_title.rb' + - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' + - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' + - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' + - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' + - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' + - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' + - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' + - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' + - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' + - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' + - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' + - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' + - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' + - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' + - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' + - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' + - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' + - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' + - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' + - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' + - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' + - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' + - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' + - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' + - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' + - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' + - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' + - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' + - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' diff --git a/.rubocop_todo/migration/background_migrations.yml b/.rubocop_todo/migration/background_migrations.yml index 17548ef6b87..2219f37901d 100644 --- a/.rubocop_todo/migration/background_migrations.yml +++ b/.rubocop_todo/migration/background_migrations.yml @@ -1,25 +1,10 @@ --- Migration/BackgroundMigrations: Exclude: - - 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb' - - 'db/post_migrate/20220506124021_schedule_populate_requirements_issue_id.rb' - - 'db/post_migrate/20220502173045_reset_too_many_tags_skipped_registry_imports.rb' - - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' - - 'db/post_migrate/20220420061450_backfill_null_note_discussion_ids.rb' - - 'db/post_migrate/20220407163559_schedule_purging_stale_security_scans.rb' - - 'db/post_migrate/20220331133802_schedule_backfill_topics_title.rb' - - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220324081709_fix_and_backfill_project_namespaces_for_projects_with_duplicate_name.rb' - - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' - - 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb' - - 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb' - 'db/migrate/20210519154058_schedule_update_users_where_two_factor_auth_required_from_group.rb' - - 'db/post_migrate/20210302150310_schedule_migrate_pages_to_zip_storage.rb' + - 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb' - 'db/post_migrate/20210304133508_schedule_remove_duplicate_vulnerabilities_findings2.rb' - 'db/post_migrate/20210415155043_move_container_registry_enabled_to_project_features3.rb' - - 'db/post_migrate/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url.rb' - 'db/post_migrate/20210423160427_schedule_drop_invalid_vulnerabilities.rb' - 'db/post_migrate/20210427212034_schedule_update_timelogs_project_id.rb' - 'db/post_migrate/20210506065000_schedule_backfill_traversal_ids.rb' @@ -27,55 +12,63 @@ Migration/BackgroundMigrations: - 'db/post_migrate/20210511142748_schedule_drop_invalid_vulnerabilities2.rb' - 'db/post_migrate/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects.rb' - 'db/post_migrate/20210518074332_schedule_disable_expiration_policies_linked_to_no_container_images.rb' + - 'db/post_migrate/20210604070207_retry_backfill_traversal_ids.rb' - 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb' - 'db/post_migrate/20210701111909_backfill_issues_upvotes_count.rb' + - 'db/post_migrate/20210708130419_reschedule_merge_request_diff_users_background_migration.rb' - 'db/post_migrate/20210722010101_reschedule_delete_orphaned_deployments.rb' - 'db/post_migrate/20210729163312_re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types.rb' - 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb' - 'db/post_migrate/20210730170823_schedule_security_setting_creation.rb' - - 'db/post_migrate/20210816183304_schedule_copy_ci_builds_columns_to_security_scans2.rb' - - 'db/post_migrate/20210818185845_backfill_projects_with_coverage.rb' + - 'db/post_migrate/20210823113259_steal_merge_request_diff_commit_users_migration.rb' + - 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb' + - 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb' + - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' + - 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb' - 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb' - 'db/post_migrate/20211004120135_schedule_add_primary_email_to_emails_if_user_confirmed.rb' + - 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb' - 'db/post_migrate/20211005194425_schedule_requirements_migration.rb' - 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb' - - 'db/post_migrate/20211007155221_schedule_populate_status_column_of_security_scans.rb' - 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb' + - 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb' - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb' - 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211208122200_schedule_backfill_ci_namespace_mirrors.rb' - - 'db/post_migrate/20211208122201_schedule_backfill_ci_project_mirrors.rb' + - 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb' + - 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - 'db/post_migrate/20211210140629_encrypt_static_object_token.rb' - 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb' - 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb' - 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb' + - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' + - 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb' - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' + - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' - 'db/post_migrate/20220204194347_encrypt_integration_properties.rb' - 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb' + - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb' + - 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb' - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb' - - 'db/post_migrate/20210604070207_retry_backfill_traversal_ids.rb' - - 'db/post_migrate/20210708130419_reschedule_merge_request_diff_users_background_migration.rb' - - 'db/post_migrate/20210823113259_steal_merge_request_diff_commit_users_migration.rb' - - 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb' - - 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb' - - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' - - 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb' - - 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb' - - 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb' - - 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb' - - 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb' + - 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb' + - 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb' + - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' + - 'db/post_migrate/20220324081709_fix_and_backfill_project_namespaces_for_projects_with_duplicate_name.rb' + - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' + - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' + - 'db/post_migrate/20220331133802_schedule_backfill_topics_title.rb' + - 'db/post_migrate/20220407163559_schedule_purging_stale_security_scans.rb' + - 'db/post_migrate/20220420061450_backfill_null_note_discussion_ids.rb' + - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' + - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220502173045_reset_too_many_tags_skipped_registry_imports.rb' + - 'db/post_migrate/20220506124021_schedule_populate_requirements_issue_id.rb' + - 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb' - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_case.yml b/.rubocop_todo/naming/heredoc_delimiter_case.yml index 8779831da21..2d2337b82ee 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_case.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_case.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. Naming/HeredocDelimiterCase: Exclude: - 'spec/lib/gitlab/diff/parser_spec.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 29276e529af..d57905c8607 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -29,7 +29,6 @@ Naming/HeredocDelimiterNaming: - 'ee/spec/support/helpers/ee/ldap_helpers.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/api/metadata.rb' - - 'lib/api/version.rb' - 'lib/backup/helper.rb' - 'lib/feature/shared.rb' - 'lib/gitlab/cache/import/caching.rb' @@ -38,12 +37,10 @@ Naming/HeredocDelimiterNaming: - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/migration_helpers/v2.rb' - 'lib/gitlab/exclusive_lease.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sql/set_operator.rb' - 'lib/gitlab/utils/delegator_override/validator.rb' - 'lib/tasks/gitlab/docs/compile_deprecations.rake' - 'lib/tasks/gitlab/password.rake' - - 'qa/qa/scenario/test/sanity/selectors.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/view_code_coverage_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' @@ -65,7 +62,6 @@ Naming/HeredocDelimiterNaming: - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/features/projects/commit/user_comments_on_commit_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/helpers/markup_helper_spec.rb' - 'spec/initializers/100_patch_omniauth_oauth2_spec.rb' - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' diff --git a/.rubocop_todo/performance/active_record_subtransaction_methods.yml b/.rubocop_todo/performance/active_record_subtransaction_methods.yml index 2644f08c4d1..1eeb37ff3fd 100644 --- a/.rubocop_todo/performance/active_record_subtransaction_methods.yml +++ b/.rubocop_todo/performance/active_record_subtransaction_methods.yml @@ -43,7 +43,6 @@ Performance/ActiveRecordSubtransactionMethods: - 'ee/db/fixtures/production/027_plans.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/gitlab/elastic/indexer.rb' - - 'lib/gitlab/ci/pipeline/seed/environment.rb' - 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb' - 'lib/gitlab/ci/trace/chunked_io.rb' - 'lib/gitlab/composer/cache.rb' diff --git a/.rubocop_todo/performance/bind_call.yml b/.rubocop_todo/performance/bind_call.yml deleted file mode 100644 index 5adb519793d..00000000000 --- a/.rubocop_todo/performance/bind_call.yml +++ /dev/null @@ -1,10 +0,0 @@ ---- -# Cop supports --auto-correct. -Performance/BindCall: - Exclude: - - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' - - 'ee/spec/features/issues/form_spec.rb' - - 'lib/gitlab/patch/prependable.rb' - - 'spec/features/issues/form_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/support/patches/rspec_mocks_prepended_methods.rb' diff --git a/.rubocop_todo/performance/method_object_as_block.yml b/.rubocop_todo/performance/method_object_as_block.yml index acb1e2d621b..8524376772e 100644 --- a/.rubocop_todo/performance/method_object_as_block.yml +++ b/.rubocop_todo/performance/method_object_as_block.yml @@ -11,7 +11,6 @@ Performance/MethodObjectAsBlock: - 'app/models/container_repository.rb' - 'app/models/programming_language.rb' - 'app/presenters/packages/detail/package_presenter.rb' - - 'app/services/bulk_imports/file_download_service.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service.rb' - 'app/services/ci/prometheus_metrics/observe_histograms_service.rb' - 'app/services/concerns/users/participable_service.rb' @@ -26,7 +25,6 @@ Performance/MethodObjectAsBlock: - 'ee/app/finders/security/findings_finder.rb' - 'ee/app/graphql/resolvers/vulnerabilities/scanners_resolver.rb' - 'ee/app/services/dashboard/projects/create_service.rb' - - 'ee/app/services/security/findings/cleanup_service.rb' - 'ee/app/services/security/ingestion/ingest_reports_service.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - 'ee/app/services/security/store_grouped_scans_service.rb' @@ -75,20 +73,17 @@ Performance/MethodObjectAsBlock: - 'lib/gitlab/uploads/migration_helper.rb' - 'lib/gitlab/utils.rb' - 'lib/peek/views/detailed_view.rb' - - 'lib/tasks/gitlab/assets.rake' - 'lib/unnested_in_filters/rewriter.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'rubocop/cop/avoid_return_from_blocks.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/rubocop.rb' - - 'scripts/api/download_job_artifact.rb' - 'spec/graphql/resolvers/concerns/caching_array_resolver_spec.rb' - 'spec/lib/api/entities/merge_request_basic_spec.rb' - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - 'spec/lib/gitlab/search_context/builder_spec.rb' - 'spec/models/design_management/version_spec.rb' - 'spec/services/notification_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/support/helpers/migrations_helpers.rb' - 'spec/support/shared_examples/models/active_record_enum_shared_examples.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' diff --git a/.rubocop_todo/performance/redundant_block_call.yml b/.rubocop_todo/performance/redundant_block_call.yml deleted file mode 100644 index 89a67e3fd30..00000000000 --- a/.rubocop_todo/performance/redundant_block_call.yml +++ /dev/null @@ -1,12 +0,0 @@ ---- -# Cop supports --auto-correct. -Performance/RedundantBlockCall: - Exclude: - - 'ee/app/models/gitlab_subscription.rb' - - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' - - 'lib/gitlab/auth/ldap/access.rb' - - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/database/bulk_update.rb' - - 'lib/gitlab/http.rb' - - 'lib/gitlab/safe_request_store.rb' - - 'lib/gitlab/timeless.rb' diff --git a/.rubocop_todo/performance/string_include.yml b/.rubocop_todo/performance/string_include.yml index f477593c02a..2a2d0559397 100644 --- a/.rubocop_todo/performance/string_include.yml +++ b/.rubocop_todo/performance/string_include.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Performance/StringInclude: Exclude: - 'app/models/snippet_repository.rb' @@ -7,7 +7,6 @@ Performance/StringInclude: - 'config/spring.rb' - 'ee/app/models/ee/container_registry/event.rb' - 'ee/lib/gitlab/auth/smartcard/certificate.rb' - - 'lib/gitlab/database/migration_helpers.rb' - 'lib/kramdown/parser/atlassian_document_format.rb' - 'lib/prometheus/pid_provider.rb' - 'spec/features/projects/jobs_spec.rb' diff --git a/.rubocop_todo/rails/active_record_callbacks_order.yml b/.rubocop_todo/rails/active_record_callbacks_order.yml deleted file mode 100644 index baeba86c4b9..00000000000 --- a/.rubocop_todo/rails/active_record_callbacks_order.yml +++ /dev/null @@ -1,24 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/ActiveRecordCallbacksOrder: - Exclude: - - 'app/models/award_emoji.rb' - - 'app/models/gpg_key.rb' - - 'app/models/group.rb' - - 'app/models/issue.rb' - - 'app/models/key.rb' - - 'app/models/merge_request.rb' - - 'app/models/namespace.rb' - - 'app/models/namespace_statistics.rb' - - 'app/models/note.rb' - - 'app/models/pages_domain.rb' - - 'app/models/personal_access_token.rb' - - 'app/models/project.rb' - - 'app/models/prometheus_alert.rb' - - 'app/models/remote_mirror.rb' - - 'app/models/resource_label_event.rb' - - 'app/models/snippet_statistics.rb' - - 'app/models/upload.rb' - - 'app/models/user.rb' - - 'ee/app/models/dast_site_profile.rb' - - 'ee/app/models/geo_node.rb' diff --git a/.rubocop_todo/rails/content_tag.yml b/.rubocop_todo/rails/content_tag.yml deleted file mode 100644 index d54bd97cc08..00000000000 --- a/.rubocop_todo/rails/content_tag.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Rails/ContentTag: - Details: grace period - Exclude: - - 'app/helpers/avatars_helper.rb' - - 'app/helpers/page_layout_helper.rb' - - 'lib/gitlab/middleware/go.rb' - - 'spec/helpers/avatars_helper_spec.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 898d303bd3d..0a652631e0b 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -21,9 +21,6 @@ Rails/FilePath: - 'db/post_migrate/20210630025020_migrate_push_event_payloads_event_id_back_to_integer_for_gitlab_com.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - - 'ee/db/fixtures/development/21_dast_profiles.rb' - - 'ee/db/fixtures/development/32_compliance_report_violations.rb' - 'ee/lib/ee/feature/definition.rb' - 'ee/lib/ee/gitlab/audit/type/definition.rb' - 'ee/lib/ee/gitlab/usage/metric_definition.rb' @@ -40,7 +37,6 @@ Rails/FilePath: - 'ee/spec/models/release_highlight_spec.rb' - 'ee/spec/requests/api/experiments_spec.rb' - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - - 'ee/spec/support/factory_bot.rb' - 'ee/spec/validators/json_schema_validator_spec.rb' - 'lib/api/api.rb' - 'lib/error_tracking/collector/payload_validator.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index 53e376730fd..164edaece4e 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -61,7 +61,6 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/form_helper.rb' - 'ee/app/helpers/ee/graph_helper.rb' - - 'ee/app/helpers/ee/groups/group_members_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/integrations_helper.rb' @@ -75,7 +74,6 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/projects/security/configuration_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/search_helper.rb' - - 'ee/app/helpers/ee/selects_helper.rb' - 'ee/app/helpers/ee/sorting_helper.rb' - 'ee/app/helpers/ee/subscribable_banner_helper.rb' - 'ee/app/helpers/ee/wiki_helper.rb' diff --git a/.rubocop_todo/rails/http_status.yml b/.rubocop_todo/rails/http_status.yml deleted file mode 100644 index 1a8ece49304..00000000000 --- a/.rubocop_todo/rails/http_status.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/HttpStatus: - Exclude: - - 'app/controllers/concerns/invisible_captcha_on_signup.rb' - - 'app/controllers/projects/runner_projects_controller.rb' - - 'app/controllers/projects/service_ping_controller.rb' - - 'app/controllers/repositories/lfs_storage_controller.rb' - - 'ee/app/controllers/trials_controller.rb' diff --git a/.rubocop_todo/rails/index_with.yml b/.rubocop_todo/rails/index_with.yml deleted file mode 100644 index b7bc2a26959..00000000000 --- a/.rubocop_todo/rails/index_with.yml +++ /dev/null @@ -1,53 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/IndexWith: - Exclude: - - 'app/helpers/ci/jobs_helper.rb' - - 'app/models/ci/build_trace_chunk.rb' - - 'app/models/ci/processable.rb' - - 'app/models/concerns/cached_commit.rb' - - 'app/models/customer_relations/organization.rb' - - 'app/models/environment.rb' - - 'app/services/concerns/rate_limited_service.rb' - - 'app/services/packages/rpm/parse_package_service.rb' - - 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb' - - 'ee/app/models/concerns/identity_verifiable.rb' - - 'ee/app/models/vulnerabilities/projects_grade.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - - 'ee/lib/gitlab/custom_file_templates.rb' - - 'ee/lib/gitlab/insights/reducers/count_per_label_reducer.rb' - - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'ee/spec/models/sca/license_compliance_spec.rb' - - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' - - 'lib/api/entities/project_integration.rb' - - 'lib/api/helpers/packages/conan/api_helpers.rb' - - 'lib/banzai/filter/repository_link_filter.rb' - - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/reports/security/finding.rb' - - 'lib/gitlab/ci/reports/security/identifier.rb' - - 'lib/gitlab/ci/reports/test_suite.rb' - - 'lib/gitlab/database/count/exact_count_strategy.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/obsolete_ignored_columns.rb' - - 'lib/gitlab/database/tables_sorted_by_foreign_keys.rb' - - 'lib/gitlab/issuable_metadata.rb' - - 'lib/gitlab/template/base_template.rb' - - 'lib/gitlab/usage_data.rb' - - 'lib/google_api/cloud_platform/client.rb' - - 'lib/tasks/gitlab/db.rake' - - 'qa/qa/resource/reusable.rb' - - 'scripts/trigger-build.rb' - - 'spec/lib/gitlab/api_authentication/sent_through_builder_spec.rb' - - 'spec/lib/gitlab/conflict/file_spec.rb' - - 'spec/lib/gitlab/import_export/model_configuration_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/google_api/cloud_platform/client_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - - 'spec/support/database/multiple_databases.rb' - - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - - 'spec/support/shared_examples/models/concerns/sanitizable_shared_examples.rb' - - 'spec/views/admin/dashboard/index.html.haml_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 2ad8d6204c8..a1f49aaf2f5 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -9,7 +9,6 @@ Rails/InverseOf: - 'app/models/board.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/bulk_imports/tracker.rb' - - 'app/models/ci/bridge.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_pending_state.rb' - 'app/models/ci/build_trace_chunk.rb' diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml index c3f9ac25e7e..74f469f325b 100644 --- a/.rubocop_todo/rails/negate_include.yml +++ b/.rubocop_todo/rails/negate_include.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/NegateInclude: Details: grace period Exclude: diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 5e875daa569..e094a3397a6 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -1,10 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/Pluck: - # Offense count: 155 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: + - 'app/controllers/ldap/omniauth_callbacks_controller.rb' - 'app/finders/merge_requests/oldest_per_commit_finder.rb' - 'app/helpers/issuables_description_templates_helper.rb' - 'app/models/ci/unit_test.rb' @@ -12,67 +11,184 @@ Rails/Pluck: - 'app/models/concerns/sensitive_serializable_hash.rb' - 'app/models/integrations/chat_message/pipeline_message.rb' - 'app/models/list.rb' + - 'app/models/packages/go/module_version.rb' + - 'app/models/work_items/parent_link.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb' - 'app/services/feature_flags/update_service.rb' + - 'app/services/todos/destroy/destroyed_issuable_service.rb' + - 'app/workers/database/ci_namespace_mirrors_consistency_check_worker.rb' + - 'app/workers/database/ci_project_mirrors_consistency_check_worker.rb' + - 'db/post_migrate/20210811122206_update_external_project_bots.rb' + - 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - 'ee/app/models/boards/epic_list.rb' + - 'ee/app/models/concerns/geo/verification_state.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' - - 'ee/app/workers/geo/container_repository_sync_dispatch_worker.rb' - 'ee/app/workers/geo/registry_sync_worker.rb' - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' + - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' + - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb' + - 'ee/lib/gitlab/search/index_curator.rb' + - 'ee/spec/controllers/autocomplete_controller_spec.rb' + - 'ee/spec/controllers/countries_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' + - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' + - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb' + - 'ee/spec/controllers/projects/licenses_controller_spec.rb' + - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' + - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/graphql/api/vulnerabilities_spec.rb' + - 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' + - 'ee/spec/helpers/ee/operations_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb' + - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/spdx/catalogue_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' + - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/dast_site_profile_spec.rb' - 'ee/spec/models/integrations/chat_message/vulnerability_message_spec.rb' + - 'ee/spec/models/release_highlight_spec.rb' + - 'ee/spec/requests/api/analytics/code_review_analytics_spec.rb' + - 'ee/spec/requests/api/epic_links_spec.rb' + - 'ee/spec/requests/api/epics_spec.rb' + - 'ee/spec/requests/api/graphql/boards/board_lists_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_boards_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_lists_query_spec.rb' + - 'ee/spec/requests/api/graphql/ci/runners_spec.rb' + - 'ee/spec/requests/api/graphql/epics/epic_resolver_spec.rb' + - 'ee/spec/requests/api/graphql/iterations/cadences_spec.rb' + - 'ee/spec/requests/api/graphql/iterations/iterations_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/analytics/devops_adoption/enabled_namespaces/bulk_enable_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_profiles_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_site_validations_spec.rb' + - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/code_quality_reports_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/issue_links_spec.rb' + - 'ee/spec/requests/api/groups_spec.rb' + - 'ee/spec/requests/api/iterations_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' + - 'ee/spec/requests/api/project_approval_rules_spec.rb' + - 'ee/spec/requests/api/project_approval_settings_spec.rb' + - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/protected_branches_spec.rb' + - 'ee/spec/requests/api/protected_environments_spec.rb' + - 'ee/spec/requests/api/protected_tags_spec.rb' + - 'ee/spec/requests/api/releases_spec.rb' + - 'ee/spec/requests/api/search_spec.rb' + - 'ee/spec/requests/api/status_checks_spec.rb' + - 'ee/spec/requests/api/users_spec.rb' + - 'ee/spec/requests/api/vulnerabilities_spec.rb' + - 'ee/spec/requests/api/vulnerability_findings_spec.rb' + - 'ee/spec/requests/api/vulnerability_issue_links_spec.rb' + - 'ee/spec/requests/ee/groups/autocomplete_sources_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' + - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/create_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' + - 'ee/spec/services/ee/releases/create_evidence_service_spec.rb' + - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' + - 'ee/spec/support/elastic.rb' + - 'ee/spec/support/helpers/feature_approval_helper.rb' + - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' + - 'ee/spec/support/shared_examples/requests/api/graphql/incident_management/escalation_policies_shared_examples.rb' + - 'lib/atlassian/jira_connect/client.rb' - 'lib/banzai/filter/references/label_reference_filter.rb' - 'lib/banzai/filter/references/milestone_reference_filter.rb' - 'lib/banzai/renderer.rb' - 'lib/gitlab/access.rb' - 'lib/gitlab/analytics/cycle_analytics/default_stages.rb' + - 'lib/gitlab/bullet/exclusions.rb' - 'lib/gitlab/checks/lfs_check.rb' - 'lib/gitlab/ci/pipeline/chain/build/associations.rb' - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' - 'lib/gitlab/ci/variables/collection/sort.rb' - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/cycle_analytics/updater.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb' - 'lib/gitlab/git_access.rb' + - 'lib/gitlab/github_import/representation/issue.rb' + - 'lib/gitlab/jira_import/metadata_collector.rb' + - 'lib/gitlab/merge_requests/message_generator.rb' - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - 'lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' + - 'lib/gitlab/sql/pattern.rb' - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - - 'qa/qa/specs/features/browser_ui/3_create/jira/jira_basic_integration_spec.rb' - - 'qa/qa/support/page_error_checker.rb' + - 'lib/gitlab/zentao/client.rb' + - 'lib/tasks/gitlab/info.rake' + - 'qa/qa/specs/features/api/1_manage/import/import_github_repo_spec.rb' + - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_mr_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' + - 'qa/qa/tools/ci/qa_changes.rb' + - 'qa/qa/tools/delete_projects.rb' + - 'qa/qa/tools/delete_test_snippets.rb' + - 'qa/qa/tools/delete_test_ssh_keys.rb' + - 'qa/qa/tools/delete_test_users.rb' + - 'qa/qa/tools/delete_user_projects.rb' - 'scripts/perf/query_limiting_report.rb' - 'spec/config/mail_room_spec.rb' - - 'spec/config/metrics/aggregates/aggregated_metrics_spec.rb' + - 'spec/controllers/autocomplete_controller_spec.rb' + - 'spec/controllers/dashboard/milestones_controller_spec.rb' + - 'spec/controllers/groups/labels_controller_spec.rb' + - 'spec/controllers/groups/milestones_controller_spec.rb' + - 'spec/controllers/groups/releases_controller_spec.rb' + - 'spec/controllers/groups/shared_projects_controller_spec.rb' + - 'spec/controllers/projects/analytics/cycle_analytics/stages_controller_spec.rb' + - 'spec/controllers/projects/autocomplete_sources_controller_spec.rb' + - 'spec/controllers/projects/environments_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' + - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' + - 'spec/controllers/projects/releases_controller_spec.rb' + - 'spec/controllers/projects/starrers_controller_spec.rb' + - 'spec/db/schema_spec.rb' + - 'spec/features/issues/csv_spec.rb' + - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' + - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' + - 'spec/graphql/resolvers/namespace_projects_resolver_spec.rb' + - 'spec/graphql/types/ci/job_token_scope_type_spec.rb' + - 'spec/graphql/types/snippet_type_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/pull_request_entity_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/projects/stage_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb' + - 'spec/lib/gitlab/database/similarity_score_spec.rb' + - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/conflict/parser_spec.rb' + - 'spec/lib/gitlab/import_export/group/legacy_tree_saver_spec.rb' + - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/language_detection_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' @@ -80,9 +196,11 @@ Rails/Pluck: - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/search/query_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_matcher_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/peek/views/rugged_spec.rb' - 'spec/migrations/20210713042000_fix_ci_sources_pipelines_index_names_spec.rb' + - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/pipeline_spec.rb' @@ -94,12 +212,98 @@ Rails/Pluck: - 'spec/models/project_spec.rb' - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' + - 'spec/requests/api/admin/instance_clusters_spec.rb' + - 'spec/requests/api/branches_spec.rb' + - 'spec/requests/api/ci/pipeline_schedules_spec.rb' + - 'spec/requests/api/ci/pipelines_spec.rb' + - 'spec/requests/api/commit_statuses_spec.rb' + - 'spec/requests/api/commits_spec.rb' + - 'spec/requests/api/deploy_tokens_spec.rb' + - 'spec/requests/api/deployments_spec.rb' + - 'spec/requests/api/events_spec.rb' + - 'spec/requests/api/feature_flags_spec.rb' + - 'spec/requests/api/feature_flags_user_lists_spec.rb' + - 'spec/requests/api/files_spec.rb' + - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' + - 'spec/requests/api/graphql/ci/manual_variables_spec.rb' + - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' + - 'spec/requests/api/graphql/group/timelogs_spec.rb' + - 'spec/requests/api/graphql/group_query_spec.rb' + - 'spec/requests/api/graphql/mutations/design_management/move_spec.rb' + - 'spec/requests/api/graphql/packages/package_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alerts_spec.rb' + - 'spec/requests/api/graphql/project/base_service_spec.rb' + - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' + - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' + - 'spec/requests/api/graphql/project/issues_spec.rb' + - 'spec/requests/api/graphql/project/jira_import_spec.rb' + - 'spec/requests/api/graphql/project/jira_projects_spec.rb' + - 'spec/requests/api/graphql/project/release_spec.rb' + - 'spec/requests/api/graphql/project/releases_spec.rb' + - 'spec/requests/api/group_clusters_spec.rb' + - 'spec/requests/api/group_labels_spec.rb' + - 'spec/requests/api/group_milestones_spec.rb' + - 'spec/requests/api/group_packages_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/api/invitations_spec.rb' + - 'spec/requests/api/issues/get_project_issues_spec.rb' + - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/members_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/namespaces_spec.rb' + - 'spec/requests/api/package_files_spec.rb' + - 'spec/requests/api/pages_domains_spec.rb' + - 'spec/requests/api/personal_access_tokens_spec.rb' + - 'spec/requests/api/project_clusters_spec.rb' + - 'spec/requests/api/project_container_repositories_spec.rb' + - 'spec/requests/api/project_events_spec.rb' + - 'spec/requests/api/project_milestones_spec.rb' + - 'spec/requests/api/project_snippets_spec.rb' + - 'spec/requests/api/project_templates_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/protected_branches_spec.rb' + - 'spec/requests/api/protected_tags_spec.rb' + - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/repositories_spec.rb' + - 'spec/requests/api/resource_access_tokens_spec.rb' + - 'spec/requests/api/snippets_spec.rb' + - 'spec/requests/api/tags_spec.rb' + - 'spec/requests/api/templates_spec.rb' + - 'spec/requests/api/todos_spec.rb' + - 'spec/requests/api/topics_spec.rb' + - 'spec/requests/api/unleash_spec.rb' + - 'spec/requests/api/users_spec.rb' + - 'spec/requests/api/v3/github_spec.rb' + - 'spec/requests/groups/autocomplete_sources_spec.rb' + - 'spec/requests/groups/milestones_controller_spec.rb' + - 'spec/requests/jwks_controller_spec.rb' + - 'spec/requests/lfs_http_spec.rb' - 'spec/serializers/ci/dag_pipeline_entity_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/diff_file_entity_spec.rb' - 'spec/serializers/stage_entity_spec.rb' + - 'spec/services/ci/compare_test_reports_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' + - 'spec/services/clusters/applications/prometheus_config_service_spec.rb' + - 'spec/services/issues/export_csv_service_spec.rb' - 'spec/services/metrics/dashboard/custom_metric_embed_service_spec.rb' - 'spec/services/projects/participants_service_spec.rb' + - 'spec/support/helpers/api_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/matchers/background_migrations_matchers.rb' - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' + - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' + - 'spec/support/shared_examples/services/packages_shared_examples.rb' + - 'spec/tooling/docs/deprecation_handling_spec.rb' - 'tooling/danger/sidekiq_queues.rb' + - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 0d23c51caae..3251429876e 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/RedundantForeignKey: Exclude: - 'app/models/alert_management/metric_image.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index f1e7d519a8f..378c00c1063 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -1,126 +1,110 @@ --- +# Cop supports --autocorrect. Rails/TimeZone: - Enabled: true Exclude: - - lib/gitlab/popen.rb - - ee/lib/delay.rb - - ee/lib/gitlab/elastic/helper.rb - - ee/lib/gitlab/elastic/indexer.rb - - ee/lib/gitlab/geo/event_gap_tracking.rb - - ee/lib/gitlab/geo/log_cursor/events/design_repository_updated_event.rb - - ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb - - ee/lib/gitlab/geo/log_cursor/logger.rb - - ee/lib/gitlab/geo/oauth/login_state.rb - - ee/lib/gitlab/prometheus/queries/cluster_query.rb - - ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb - - ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb - - ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb - - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb - - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - - ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb - - ee/spec/lib/gitlab/auth/smartcard/session_spec.rb - - ee/spec/lib/gitlab/elastic/client_spec.rb - - ee/spec/lib/gitlab/geo/base_request_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/logger_spec.rb - - ee/spec/lib/gitlab/git_access_spec.rb - - ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb - - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb - - lib/api/helpers.rb - - lib/api/sidekiq_metrics.rb - - lib/backup/manager.rb - - lib/bitbucket_server/representation/base.rb - - lib/gitlab/auth/current_user_mode.rb - - lib/gitlab/auth/ldap/access.rb - - lib/gitlab/chaos.rb - - lib/gitlab/checks/timed_logger.rb - - lib/gitlab/ci/pipeline/duration.rb - - lib/gitlab/database.rb - - lib/gitlab/external_authorization/access.rb - - lib/gitlab/external_authorization/cache.rb - - lib/gitlab/gitaly_client.rb - - lib/gitlab/gitaly_client/ref_service.rb - - lib/gitlab/github_import/representation.rb - - lib/gitlab/health_checks/base_abstract_check.rb - - lib/gitlab/import_export.rb - - lib/gitlab/instrumentation/elasticsearch_transport.rb - - lib/gitlab/instrumentation_helper.rb - - lib/gitlab/lfs_token.rb - - lib/gitlab/loop_helpers.rb - - lib/gitlab/phabricator_import/representation/task.rb - - lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb - - lib/gitlab/prometheus/queries/matched_metric_query.rb - - lib/gitlab/prometheus_client.rb - - lib/gitlab/task_helpers.rb - - lib/gitlab/x509/tag.rb - - lib/grafana/time_window.rb - - lib/json_web_token/token.rb - - lib/object_storage/direct_upload.rb - - lib/quality/seeders/issues.rb - - lib/tasks/gitlab/assets.rake - - lib/tasks/gitlab/backup.rake - - lib/tasks/gitlab/cleanup.rake - - lib/tasks/gitlab/list_repos.rake - - spec/lib/api/helpers_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb - - spec/lib/gitlab/app_json_logger_spec.rb - - spec/lib/gitlab/app_text_logger_spec.rb - - spec/lib/gitlab/auth/current_user_mode_spec.rb - - spec/lib/gitlab/bitbucket_import/importer_spec.rb - - spec/lib/gitlab/bitbucket_server_import/importer_spec.rb - - spec/lib/gitlab/checks/timed_logger_spec.rb - - spec/lib/gitlab/ci/cron_parser_spec.rb - - spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb - - spec/lib/gitlab/data_builder/note_spec.rb - - spec/lib/gitlab/database/background_migration_job_spec.rb - - spec/lib/gitlab/database_spec.rb - - spec/lib/gitlab/discussions_diff/file_collection_spec.rb - - spec/lib/gitlab/external_authorization/access_spec.rb - - spec/lib/gitlab/external_authorization/cache_spec.rb - - spec/lib/gitlab/external_authorization/logger_spec.rb - - spec/lib/gitlab/fogbugz_import/importer_spec.rb - - spec/lib/gitlab/git/branch_spec.rb - - spec/lib/gitlab/git/commit_spec.rb - - spec/lib/gitlab/git/repository_spec.rb - - spec/lib/gitlab/git_access_spec.rb - - spec/lib/gitlab/github_import/importer/issue_importer_spec.rb - - spec/lib/gitlab/github_import/importer/issues_importer_spec.rb - - spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb - - spec/lib/gitlab/github_import/importer/note_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb - - spec/lib/gitlab/github_import/importer/releases_importer_spec.rb - - spec/lib/gitlab/github_import/representation/diff_note_spec.rb - - spec/lib/gitlab/github_import/representation/issue_spec.rb - - spec/lib/gitlab/github_import/representation/note_spec.rb - - spec/lib/gitlab/github_import/representation/pull_request_spec.rb - - spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb - - spec/lib/gitlab/grape_logging/loggers/cloudflare_logger_spec.rb - - spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb - - spec/lib/gitlab/graphql_logger_spec.rb - - spec/lib/gitlab/graphs/commits_spec.rb - - spec/lib/gitlab/import_export/project/relation_factory_spec.rb - - spec/lib/gitlab/json_logger_spec.rb - - spec/lib/gitlab/lfs_token_spec.rb - - spec/lib/gitlab/log_timestamp_formatter_spec.rb - - spec/lib/gitlab/middleware/rails_queue_duration_spec.rb - - spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb - - spec/lib/gitlab/phabricator_import/representation/task_spec.rb - - spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb - - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - - spec/lib/gitlab/prometheus/queries/validate_query_spec.rb - - spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb - - spec/lib/gitlab/utils/json_size_estimator_spec.rb - - spec/lib/gitlab/x509/signature_spec.rb - - spec/lib/grafana/time_window_spec.rb - - spec/lib/json_web_token/hmac_token_spec.rb + - 'ee/lib/delay.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'ee/lib/gitlab/geo/event_gap_tracking.rb' + - 'ee/lib/gitlab/geo/log_cursor/events/design_repository_updated_event.rb' + - 'ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb' + - 'ee/lib/gitlab/geo/log_cursor/logger.rb' + - 'ee/lib/gitlab/geo/oauth/login_state.rb' + - 'ee/spec/lib/gitlab/geo/base_request_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/logger_spec.rb' + - 'ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' + - 'ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb' + - 'lib/api/helpers.rb' + - 'lib/api/sidekiq_metrics.rb' + - 'lib/bitbucket_server/representation/base.rb' + - 'lib/gitlab/auth/current_user_mode.rb' + - 'lib/gitlab/auth/ldap/access.rb' + - 'lib/gitlab/chaos.rb' + - 'lib/gitlab/checks/timed_logger.rb' + - 'lib/gitlab/ci/pipeline/duration.rb' + - 'lib/gitlab/database.rb' + - 'lib/gitlab/external_authorization/access.rb' + - 'lib/gitlab/external_authorization/cache.rb' + - 'lib/gitlab/gitaly_client.rb' + - 'lib/gitlab/gitaly_client/ref_service.rb' + - 'lib/gitlab/github_import/representation.rb' + - 'lib/gitlab/health_checks/base_abstract_check.rb' + - 'lib/gitlab/import_export.rb' + - 'lib/gitlab/instrumentation/elasticsearch_transport.rb' + - 'lib/gitlab/instrumentation_helper.rb' + - 'lib/gitlab/lfs_token.rb' + - 'lib/gitlab/loop_helpers.rb' + - 'lib/gitlab/phabricator_import/representation/task.rb' + - 'lib/gitlab/popen.rb' + - 'lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb' + - 'lib/gitlab/prometheus/queries/matched_metric_query.rb' + - 'lib/gitlab/prometheus_client.rb' + - 'lib/gitlab/task_helpers.rb' + - 'lib/gitlab/x509/tag.rb' + - 'lib/grafana/time_window.rb' + - 'lib/json_web_token/token.rb' + - 'lib/object_storage/direct_upload.rb' + - 'lib/quality/seeders/issues.rb' + - 'lib/tasks/gitlab/assets.rake' + - 'lib/tasks/gitlab/backup.rake' + - 'lib/tasks/gitlab/cleanup.rake' + - 'lib/tasks/gitlab/list_repos.rake' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' + - 'spec/lib/gitlab/app_json_logger_spec.rb' + - 'spec/lib/gitlab/app_text_logger_spec.rb' + - 'spec/lib/gitlab/auth/current_user_mode_spec.rb' + - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' + - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' + - 'spec/lib/gitlab/checks/timed_logger_spec.rb' + - 'spec/lib/gitlab/ci/cron_parser_spec.rb' + - 'spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' + - 'spec/lib/gitlab/data_builder/note_spec.rb' + - 'spec/lib/gitlab/database/background_migration_job_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/discussions_diff/file_collection_spec.rb' + - 'spec/lib/gitlab/external_authorization/access_spec.rb' + - 'spec/lib/gitlab/external_authorization/cache_spec.rb' + - 'spec/lib/gitlab/external_authorization/logger_spec.rb' + - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' + - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/issue_spec.rb' + - 'spec/lib/gitlab/github_import/representation/note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/pull_request_spec.rb' + - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/cloudflare_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/graphql_logger_spec.rb' + - 'spec/lib/gitlab/graphs/commits_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' + - 'spec/lib/gitlab/json_logger_spec.rb' + - 'spec/lib/gitlab/lfs_token_spec.rb' + - 'spec/lib/gitlab/log_timestamp_formatter_spec.rb' + - 'spec/lib/gitlab/middleware/rails_queue_duration_spec.rb' + - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' + - 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' + - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' + - 'spec/lib/gitlab/utils/json_size_estimator_spec.rb' + - 'spec/lib/gitlab/x509/signature_spec.rb' + - 'spec/lib/grafana/time_window_spec.rb' + - 'spec/lib/json_web_token/hmac_token_spec.rb' diff --git a/.rubocop_todo/rake/require.yml b/.rubocop_todo/rake/require.yml index 5042f0d504e..07138d6b622 100644 --- a/.rubocop_todo/rake/require.yml +++ b/.rubocop_todo/rake/require.yml @@ -22,5 +22,4 @@ Rake/Require: - 'lib/tasks/gitlab/x509/update.rake' - 'lib/tasks/import.rake' - 'lib/tasks/tokens.rake' - - 'qa/tasks/ci.rake' - 'qa/tasks/webdrivers.rake' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 5ee00cb0e24..f24fbbfbed2 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -1,463 +1,401 @@ --- +# Cop supports --autocorrect. RSpec/AnyInstanceOf: Exclude: - - ee/spec/controllers/admin/geo/nodes_controller_spec.rb - - ee/spec/controllers/ee/groups_controller_spec.rb - - ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb - - ee/spec/controllers/groups/epics/notes_controller_spec.rb - - ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb - - ee/spec/controllers/oauth/geo_auth_controller_spec.rb - - ee/spec/controllers/projects/environments_controller_spec.rb - - ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb - - ee/spec/controllers/projects/merge_requests_controller_spec.rb - - ee/spec/controllers/projects/path_locks_controller_spec.rb - - ee/spec/controllers/projects_controller_spec.rb - - ee/spec/controllers/subscriptions_controller_spec.rb - - ee/spec/features/admin/admin_audit_logs_spec.rb - - ee/spec/features/admin/admin_reset_pipeline_minutes_spec.rb - - ee/spec/features/admin/admin_users_spec.rb - - ee/spec/features/boards/scoped_issue_board_spec.rb - - ee/spec/features/ci_shared_runner_warnings_spec.rb - - ee/spec/features/groups/group_settings_spec.rb - - ee/spec/features/groups/navbar_spec.rb - - ee/spec/features/groups/saml_providers_spec.rb - - ee/spec/features/issues/form_spec.rb - - ee/spec/features/merge_request/user_creates_merge_request_spec.rb - - ee/spec/features/projects/new_project_spec.rb - - ee/spec/features/registrations/welcome_spec.rb - - ee/spec/features/security/project/internal_access_spec.rb - - ee/spec/features/security/project/private_access_spec.rb - - ee/spec/features/security/project/public_access_spec.rb - - ee/spec/features/trials/select_namespace_spec.rb - - ee/spec/features/users/login_spec.rb - - ee/spec/graphql/mutations/dast_on_demand_scans/create_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_schedule/create_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb - - ee/spec/helpers/application_helper_spec.rb - - ee/spec/lib/ee/api/helpers_spec.rb - - ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb - - ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb - - ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb - - ee/spec/lib/gitlab/auth/group_saml/membership_enforcer_spec.rb - - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - - ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/elastic/project_search_results_spec.rb - - ee/spec/lib/gitlab/expiring_subscription_message_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb - - ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb - - ee/spec/lib/omni_auth/strategies/group_saml_spec.rb - - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - - ee/spec/models/ee/namespace_spec.rb - - ee/spec/models/geo_node_status_spec.rb - - ee/spec/models/issue_spec.rb - - ee/spec/models/merge_request_spec.rb - - ee/spec/models/project_import_state_spec.rb - - ee/spec/models/push_rule_spec.rb - - ee/spec/presenters/ci/pipeline_presenter_spec.rb - - ee/spec/requests/api/geo_nodes_spec.rb - - ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb - - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb - - ee/spec/requests/api/issues_spec.rb - - ee/spec/requests/api/projects_spec.rb - - ee/spec/requests/git_http_spec.rb - - ee/spec/requests/groups_controller_spec.rb - - ee/spec/requests/omniauth_kerberos_spec.rb - - ee/spec/requests/repositories/git_http_controller_spec.rb - - ee/spec/services/ee/git/branch_push_service_spec.rb - - ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb - - ee/spec/services/ee/merge_requests/refresh_service_spec.rb - - ee/spec/services/ee/users/create_service_spec.rb - - ee/spec/services/ee/users/destroy_service_spec.rb - - ee/spec/services/geo/container_repository_sync_service_spec.rb - - ee/spec/services/geo/design_repository_sync_service_spec.rb - - ee/spec/services/geo/framework_repository_sync_service_spec.rb - - ee/spec/services/geo/hashed_storage_migration_service_spec.rb - - ee/spec/services/geo/metrics_update_service_spec.rb - - ee/spec/services/geo/move_repository_service_spec.rb - - ee/spec/services/geo/project_housekeeping_service_spec.rb - - ee/spec/services/geo/rename_repository_service_spec.rb - - ee/spec/services/geo/repository_destroy_service_spec.rb - - ee/spec/services/geo/repository_sync_service_spec.rb - - ee/spec/services/geo/wiki_sync_service_spec.rb - - ee/spec/services/groups/destroy_service_spec.rb - - ee/spec/services/groups/update_service_spec.rb - - ee/spec/services/merge_trains/check_status_service_spec.rb - - ee/spec/services/projects/destroy_service_spec.rb - - ee/spec/services/projects/group_links/destroy_service_spec.rb - - ee/spec/services/projects/update_service_spec.rb - - ee/spec/services/slash_commands/global_slack_handler_spec.rb - - ee/spec/support/helpers/ee/stub_configuration.rb - - ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb - - ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb - - ee/spec/support/shared_examples/lib/gitlab/geo/geo_logs_event_source_info_shared_examples.rb - - ee/spec/support/shared_examples/models/member_shared_examples.rb - - ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb - - ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb - - ee/spec/workers/concerns/elastic/indexing_control_spec.rb - - ee/spec/workers/elastic_commit_indexer_worker_spec.rb - - ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb - - ee/spec/workers/geo/registry_sync_worker_spec.rb - - ee/spec/workers/geo/repository_cleanup_worker_spec.rb - - ee/spec/workers/geo/repository_shard_sync_worker_spec.rb - - ee/spec/workers/project_cache_worker_spec.rb - - ee/spec/workers/repository_import_worker_spec.rb - - ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb - - qa/spec/runtime/release_spec.rb - - spec/controllers/admin/sessions_controller_spec.rb - - spec/controllers/application_controller_spec.rb - - spec/controllers/concerns/issuable_actions_spec.rb - - spec/controllers/concerns/static_object_external_storage_spec.rb - - spec/controllers/explore/projects_controller_spec.rb - - spec/controllers/groups/clusters_controller_spec.rb - - spec/controllers/groups/settings/ci_cd_controller_spec.rb - - spec/controllers/groups_controller_spec.rb - - spec/controllers/import/bitbucket_controller_spec.rb - - spec/controllers/oauth/jira_dvcs/authorizations_controller_spec.rb - - spec/controllers/omniauth_callbacks_controller_spec.rb - - spec/controllers/projects/artifacts_controller_spec.rb - - spec/controllers/projects/branches_controller_spec.rb - - spec/controllers/projects/clusters_controller_spec.rb - - spec/controllers/projects/commit_controller_spec.rb - - spec/controllers/projects/commits_controller_spec.rb - - spec/controllers/projects/environments_controller_spec.rb - - spec/controllers/projects/imports_controller_spec.rb - - spec/controllers/projects/issues_controller_spec.rb - - spec/controllers/projects/jobs_controller_spec.rb - - spec/controllers/projects/labels_controller_spec.rb - - spec/controllers/projects/merge_requests_controller_spec.rb - - spec/controllers/projects/pipelines_controller_spec.rb - - spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb - - spec/controllers/projects/settings/integrations_controller_spec.rb - - spec/controllers/projects/tags_controller_spec.rb - - spec/controllers/registrations_controller_spec.rb - - spec/controllers/sessions_controller_spec.rb - - spec/controllers/snippets/notes_controller_spec.rb - - spec/controllers/snippets_controller_spec.rb - - spec/features/admin/admin_mode/login_spec.rb - - spec/features/groups/members/tabs_spec.rb - - spec/features/ide/static_object_external_storage_csp_spec.rb - - spec/features/issuables/issuable_list_spec.rb - - spec/features/issues/form_spec.rb - - spec/features/merge_request/user_creates_image_diff_notes_spec.rb - - spec/features/merge_request/user_reviews_image_spec.rb - - spec/features/merge_request/user_sees_diff_spec.rb - - spec/features/merge_request/user_sees_merge_widget_spec.rb - - spec/features/profiles/personal_access_tokens_spec.rb - - spec/features/projects/clusters/gcp_spec.rb - - spec/features/projects/clusters_spec.rb - - spec/features/projects/container_registry_spec.rb - - spec/features/projects/files/user_browses_lfs_files_spec.rb - - spec/features/projects/jobs_spec.rb - - spec/features/projects/navbar_spec.rb - - spec/features/projects/settings/service_desk_setting_spec.rb - - spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb - - spec/features/snippets/embedded_snippet_spec.rb - - spec/features/usage_stats_consent_spec.rb - - spec/finders/prometheus_metrics_finder_spec.rb - - spec/graphql/mutations/alert_management/create_alert_issue_spec.rb - - spec/graphql/mutations/alert_management/http_integration/create_spec.rb - - spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb - - spec/graphql/mutations/alert_management/http_integration/reset_token_spec.rb - - spec/graphql/mutations/alert_management/http_integration/update_spec.rb - - spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb - - spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb - - spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb - - spec/helpers/projects_helper_spec.rb - - spec/initializers/lograge_spec.rb - - spec/lib/api/entities/merge_request_basic_spec.rb - - spec/lib/api/entities/merge_request_changes_spec.rb - - spec/lib/api/helpers_spec.rb - - spec/lib/backup/files_spec.rb - - spec/lib/backup/manager_spec.rb - - spec/lib/banzai/commit_renderer_spec.rb - - spec/lib/banzai/filter/references/external_issue_reference_filter_spec.rb - - spec/lib/banzai/filter/references/issue_reference_filter_spec.rb - - spec/lib/banzai/filter/repository_link_filter_spec.rb - - spec/lib/banzai/pipeline/gfm_pipeline_spec.rb - - spec/lib/extracts_ref_spec.rb - - spec/lib/feature_spec.rb - - spec/lib/gitlab/app_logger_spec.rb - - spec/lib/gitlab/asciidoc_spec.rb - - spec/lib/gitlab/auth/auth_finders_spec.rb - - spec/lib/gitlab/auth/blocked_user_tracker_spec.rb - - spec/lib/gitlab/auth/request_authenticator_spec.rb - - spec/lib/gitlab/auth_spec.rb - - spec/lib/gitlab/checks/diff_check_spec.rb - - spec/lib/gitlab/checks/lfs_check_spec.rb - - spec/lib/gitlab/checks/lfs_integrity_spec.rb - - spec/lib/gitlab/ci/config/external/file/base_spec.rb - - spec/lib/gitlab/ci/config/external/file/local_spec.rb - - spec/lib/gitlab/ci/config/external/processor_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/build_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/command_spec.rb - - spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/Jobs/build_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb - - spec/lib/gitlab/ci/templates/npm_spec.rb - - spec/lib/gitlab/ci/trace_spec.rb - - spec/lib/gitlab/current_settings_spec.rb - - spec/lib/gitlab/diff/highlight_cache_spec.rb - - spec/lib/gitlab/diff/highlight_spec.rb - - spec/lib/gitlab/diff/position_spec.rb - - spec/lib/gitlab/email/handler/create_issue_handler_spec.rb - - spec/lib/gitlab/email/handler/create_note_handler_spec.rb - - spec/lib/gitlab/etag_caching/middleware_spec.rb - - spec/lib/gitlab/exclusive_lease_helpers_spec.rb - - spec/lib/gitlab/fogbugz_import/importer_spec.rb - - spec/lib/gitlab/gfm/reference_rewriter_spec.rb - - spec/lib/gitlab/git/repository_spec.rb - - spec/lib/gitlab/gitaly_client/blob_service_spec.rb - - spec/lib/gitlab/gitaly_client/commit_service_spec.rb - - spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb - - spec/lib/gitlab/gitaly_client/health_check_service_spec.rb - - spec/lib/gitlab/gitaly_client/operation_service_spec.rb - - spec/lib/gitlab/gitaly_client/praefect_info_service_spec.rb - - spec/lib/gitlab/gitaly_client/ref_service_spec.rb - - spec/lib/gitlab/gitaly_client/remote_service_spec.rb - - spec/lib/gitlab/gitaly_client/repository_service_spec.rb - - spec/lib/gitlab/gitaly_client/wiki_service_spec.rb - - spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb - - spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb - - spec/lib/gitlab/hashed_storage/migrator_spec.rb - - spec/lib/gitlab/import/merge_request_helpers_spec.rb - - spec/lib/gitlab/import_export/config_spec.rb - - spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb - - spec/lib/gitlab/import_export/importer_spec.rb - - spec/lib/gitlab/import_export/lfs_restorer_spec.rb - - spec/lib/gitlab/import_export/project/tree_restorer_spec.rb - - spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb - - spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb - - spec/lib/gitlab/import_export/version_checker_spec.rb - - spec/lib/gitlab/job_waiter_spec.rb - - spec/lib/gitlab/legacy_github_import/importer_spec.rb - - spec/lib/gitlab/legacy_github_import/project_creator_spec.rb - - spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb - - spec/lib/gitlab/metrics/rack_middleware_spec.rb - - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb - - spec/lib/gitlab/metrics_spec.rb - - spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb - - spec/lib/gitlab/sidekiq_middleware_spec.rb - - spec/lib/gitlab/tracking/destinations/snowplow_spec.rb - - spec/lib/gitlab/tracking_spec.rb - - spec/lib/gitlab/usage_data_spec.rb - - spec/lib/gitlab/workhorse_spec.rb - - spec/lib/gitlab/x509/commit_spec.rb - - spec/lib/gitlab/x509/signature_spec.rb - - spec/lib/google_api/cloud_platform/client_spec.rb - - spec/lib/json_web_token/rsa_token_spec.rb - - spec/lib/mattermost/command_spec.rb - - spec/lib/mattermost/team_spec.rb - - spec/lib/system_check/simple_executor_spec.rb - - spec/models/ci/build_spec.rb - - spec/models/ci/runner_spec.rb - - spec/models/commit_spec.rb - - spec/models/environment_spec.rb - - spec/models/group_spec.rb - - spec/models/hooks/service_hook_spec.rb - - spec/models/hooks/system_hook_spec.rb - - spec/models/hooks/web_hook_spec.rb - - spec/models/integrations/jira_spec.rb - - spec/models/integrations/mattermost_slash_commands_spec.rb - - spec/models/issue_spec.rb - - spec/models/key_spec.rb - - spec/models/member_spec.rb - - spec/models/merge_request_diff_spec.rb - - spec/models/merge_request_spec.rb - - spec/models/note_spec.rb - - spec/models/project_import_state_spec.rb - - spec/models/project_spec.rb - - spec/models/repository_spec.rb - - spec/models/user_spec.rb - - spec/models/x509_certificate_spec.rb - - spec/policies/ci/build_policy_spec.rb - - spec/policies/ci/pipeline_policy_spec.rb - - spec/presenters/gitlab/blame_presenter_spec.rb - - spec/presenters/merge_request_presenter_spec.rb - - spec/requests/api/ci/runner/jobs_artifacts_spec.rb - - spec/requests/api/ci/runner/jobs_put_spec.rb - - spec/requests/api/ci/runner/jobs_request_post_spec.rb - - spec/requests/api/ci/runner/jobs_trace_spec.rb - - spec/requests/api/ci/runner/runners_delete_spec.rb - - spec/requests/api/ci/runner/runners_post_spec.rb - - spec/requests/api/ci/runner/runners_verify_post_spec.rb - - spec/requests/api/graphql/gitlab_schema_spec.rb - - spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb - - spec/requests/api/graphql_spec.rb - - spec/requests/api/helpers_spec.rb - - spec/requests/api/internal/base_spec.rb - - spec/requests/api/maven_packages_spec.rb - - spec/requests/api/merge_requests_spec.rb - - spec/requests/api/pages/pages_spec.rb - - spec/requests/api/project_export_spec.rb - - spec/requests/api/project_import_spec.rb - - spec/requests/api/projects_spec.rb - - spec/requests/api/snippets_spec.rb - - spec/requests/api/todos_spec.rb - - spec/requests/git_http_spec.rb - - spec/requests/import/gitlab_projects_controller_spec.rb - - spec/routing/routing_spec.rb - - spec/serializers/merge_request_poll_cached_widget_entity_spec.rb - - spec/serializers/merge_request_poll_widget_entity_spec.rb - - spec/services/application_settings/update_service_spec.rb - - spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb - - spec/services/boards/lists/update_service_spec.rb - - spec/services/ci/create_pipeline_service_spec.rb - - spec/services/ci/expire_pipeline_cache_service_spec.rb - - spec/services/ci/list_config_variables_service_spec.rb - - spec/services/ci/register_job_service_spec.rb - - spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb - - spec/services/ci/retry_pipeline_service_spec.rb - - spec/services/clusters/applications/create_service_spec.rb - - spec/services/clusters/cleanup/project_namespace_service_spec.rb - - spec/services/clusters/cleanup/service_account_service_spec.rb - - spec/services/deployments/older_deployments_drop_service_spec.rb - - spec/services/deployments/update_environment_service_spec.rb - - spec/services/draft_notes/destroy_service_spec.rb - - spec/services/events/render_service_spec.rb - - spec/services/git/branch_push_service_spec.rb - - spec/services/git/process_ref_changes_service_spec.rb - - spec/services/groups/create_service_spec.rb - - spec/services/groups/update_service_spec.rb - - spec/services/integrations/test/project_service_spec.rb - - spec/services/issuable/destroy_service_spec.rb - - spec/services/issues/close_service_spec.rb - - spec/services/issues/reopen_service_spec.rb - - spec/services/members/destroy_service_spec.rb - - spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb - - spec/services/merge_requests/build_service_spec.rb - - spec/services/merge_requests/merge_service_spec.rb - - spec/services/merge_requests/mergeability_check_service_spec.rb - - spec/services/merge_requests/refresh_service_spec.rb - - spec/services/merge_requests/reload_diffs_service_spec.rb - - spec/services/merge_requests/resolved_discussion_notification_service_spec.rb - - spec/services/metrics/dashboard/custom_dashboard_service_spec.rb - - spec/services/metrics/dashboard/transient_embed_service_spec.rb - - spec/services/notes/create_service_spec.rb - - spec/services/notes/render_service_spec.rb - - spec/services/packages/conan/create_package_file_service_spec.rb - - spec/services/packages/nuget/metadata_extraction_service_spec.rb - - spec/services/packages/nuget/update_package_from_metadata_service_spec.rb - - spec/services/post_receive_service_spec.rb - - spec/services/projects/after_rename_service_spec.rb - - spec/services/projects/container_repository/cleanup_tags_service_spec.rb - - spec/services/projects/container_repository/delete_tags_service_spec.rb - - spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb - - spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb - - spec/services/projects/destroy_service_spec.rb - - spec/services/projects/fork_service_spec.rb - - spec/services/projects/import_service_spec.rb - - spec/services/projects/lfs_pointers/lfs_download_service_spec.rb - - spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb - - spec/services/projects/prometheus/alerts/notify_service_spec.rb - - spec/services/projects/transfer_service_spec.rb - - spec/services/projects/update_remote_mirror_service_spec.rb - - spec/services/projects/update_service_spec.rb - - spec/services/projects/update_statistics_service_spec.rb - - spec/services/resource_events/change_labels_service_spec.rb - - spec/services/search_service_spec.rb - - spec/services/snippets/create_service_spec.rb - - spec/services/test_hooks/project_service_spec.rb - - spec/services/test_hooks/system_service_spec.rb - - spec/services/todo_service_spec.rb - - spec/services/users/destroy_service_spec.rb - - spec/services/users/migrate_to_ghost_user_service_spec.rb - - spec/spec_helper.rb - - spec/support/capybara.rb - - spec/support/helpers/api_helpers.rb - - spec/support/helpers/graphql_helpers.rb - - spec/support/helpers/ldap_helpers.rb - - spec/support/helpers/login_helpers.rb - - spec/support/helpers/metrics_dashboard_url_helpers.rb - - spec/support/helpers/rake_helpers.rb - - spec/support/helpers/stub_configuration.rb - - spec/support/helpers/stub_gitlab_calls.rb - - spec/support/helpers/test_env.rb - - spec/support/import_export/common_util.rb - - spec/support/services/migrate_to_ghost_user_service_shared_examples.rb - - spec/support/shared_contexts/email_shared_context.rb - - spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb - - spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb - - spec/support/shared_examples/controllers/issuable_notes_filter_shared_examples.rb - - spec/support/shared_examples/controllers/issuables_requiring_filter_shared_examples.rb - - spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb - - spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb - - spec/support/shared_examples/controllers/unique_visits_shared_examples.rb - - spec/support/shared_examples/controllers/update_invalid_issuable_shared_examples.rb - - spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb - - spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb - - spec/support/shared_examples/features/snippets_shared_examples.rb - - spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb - - spec/support/shared_examples/models/atomic_internal_id_shared_examples.rb - - spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb - - spec/support/shared_examples/models/integrations/base_slash_commands_shared_examples.rb - - spec/support/shared_examples/models/mentionable_shared_examples.rb - - spec/support/shared_examples/models/with_uploads_shared_examples.rb - - spec/support/shared_examples/path_extraction_shared_examples.rb - - spec/support/shared_examples/requests/api/discussions_shared_examples.rb - - spec/support/shared_examples/requests/api/snippets_shared_examples.rb - - spec/support/shared_examples/requests/rack_attack_shared_examples.rb - - spec/support/shared_examples/requests/snippet_shared_examples.rb - - spec/support/shared_examples/services/alert_management_shared_examples.rb - - spec/support/shared_examples/services/boards/boards_list_service_shared_examples.rb - - spec/support/shared_examples/services/boards/issues_list_service_shared_examples.rb - - spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb - - spec/support/shared_examples/services/issuable_shared_examples.rb - - spec/support/shared_examples/uploaders/object_storage_shared_examples.rb - - spec/support/shared_examples/workers/authorized_projects_worker_shared_example.rb - - spec/support/shared_examples/workers/reactive_cacheable_shared_examples.rb - - spec/tasks/gitlab/cleanup_rake_spec.rb - - spec/tasks/gitlab/container_registry_rake_spec.rb - - spec/tasks/gitlab/db_rake_spec.rb - - spec/tasks/gitlab/git_rake_spec.rb - - spec/tasks/gitlab/praefect_rake_spec.rb - - spec/tasks/gitlab/shell_rake_spec.rb - - spec/tasks/gitlab/x509/update_rake_spec.rb - - spec/uploaders/file_mover_spec.rb - - spec/uploaders/records_uploads_spec.rb - - spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb - - spec/views/layouts/_head.html.haml_spec.rb - - spec/views/projects/artifacts/_artifact.html.haml_spec.rb - - spec/workers/archive_trace_worker_spec.rb - - spec/workers/build_hooks_worker_spec.rb - - spec/workers/ci/build_schedule_worker_spec.rb - - spec/workers/ci/daily_build_group_report_results_worker_spec.rb - - spec/workers/cluster_configure_istio_worker_spec.rb - - spec/workers/cluster_provision_worker_spec.rb - - spec/workers/clusters/cleanup/project_namespace_worker_spec.rb - - spec/workers/clusters/cleanup/service_account_worker_spec.rb - - spec/workers/concerns/project_import_options_spec.rb - - spec/workers/create_commit_signature_worker_spec.rb - - spec/workers/create_note_diff_file_worker_spec.rb - - spec/workers/delete_diff_files_worker_spec.rb - - spec/workers/email_receiver_worker_spec.rb - - spec/workers/emails_on_push_worker_spec.rb - - spec/workers/error_tracking_issue_link_worker_spec.rb - - spec/workers/group_export_worker_spec.rb - - spec/workers/group_import_worker_spec.rb - - spec/workers/namespaces/root_statistics_worker_spec.rb - - spec/workers/new_note_worker_spec.rb - - spec/workers/object_pool/create_worker_spec.rb - - spec/workers/packages/nuget/extraction_worker_spec.rb - - spec/workers/pipeline_hooks_worker_spec.rb - - spec/workers/pipeline_process_worker_spec.rb - - spec/workers/pipeline_schedule_worker_spec.rb - - spec/workers/project_cache_worker_spec.rb - - spec/workers/stage_update_worker_spec.rb - - spec/workers/stuck_ci_jobs_worker_spec.rb - - spec/workers/wait_for_cluster_creation_worker_spec.rb - - ee/spec/workers/security/auto_fix_worker_spec.rb + - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb' + - 'ee/spec/controllers/ee/groups_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb' + - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb' + - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' + - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/projects/path_locks_controller_spec.rb' + - 'ee/spec/controllers/projects_controller_spec.rb' + - 'ee/spec/controllers/subscriptions_controller_spec.rb' + - 'ee/spec/features/admin/admin_audit_logs_spec.rb' + - 'ee/spec/features/admin/admin_reset_pipeline_minutes_spec.rb' + - 'ee/spec/features/admin/admin_users_spec.rb' + - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' + - 'ee/spec/features/groups/group_settings_spec.rb' + - 'ee/spec/features/issues/form_spec.rb' + - 'ee/spec/features/merge_request/user_creates_merge_request_spec.rb' + - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/features/registrations/welcome_spec.rb' + - 'ee/spec/features/security/project/internal_access_spec.rb' + - 'ee/spec/features/security/project/private_access_spec.rb' + - 'ee/spec/features/security/project/public_access_spec.rb' + - 'ee/spec/features/users/login_spec.rb' + - 'ee/spec/graphql/mutations/dast_on_demand_scans/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' + - 'ee/spec/helpers/application_helper_spec.rb' + - 'ee/spec/lib/ee/api/helpers_spec.rb' + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' + - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/membership_enforcer_spec.rb' + - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb' + - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' + - 'ee/spec/models/ee/namespace_spec.rb' + - 'ee/spec/models/geo_node_status_spec.rb' + - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/merge_request_spec.rb' + - 'ee/spec/models/project_import_state_spec.rb' + - 'ee/spec/models/push_rule_spec.rb' + - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb' + - 'ee/spec/requests/api/geo_nodes_spec.rb' + - 'ee/spec/requests/api/issues_spec.rb' + - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/git_http_spec.rb' + - 'ee/spec/requests/groups_controller_spec.rb' + - 'ee/spec/requests/omniauth_kerberos_spec.rb' + - 'ee/spec/requests/repositories/git_http_controller_spec.rb' + - 'ee/spec/services/ee/git/branch_push_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' + - 'ee/spec/services/ee/users/create_service_spec.rb' + - 'ee/spec/services/geo/container_repository_sync_service_spec.rb' + - 'ee/spec/services/geo/design_repository_sync_service_spec.rb' + - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' + - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' + - 'ee/spec/services/geo/metrics_update_service_spec.rb' + - 'ee/spec/services/geo/move_repository_service_spec.rb' + - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' + - 'ee/spec/services/geo/rename_repository_service_spec.rb' + - 'ee/spec/services/geo/repository_destroy_service_spec.rb' + - 'ee/spec/services/geo/repository_sync_service_spec.rb' + - 'ee/spec/services/groups/destroy_service_spec.rb' + - 'ee/spec/services/groups/update_service_spec.rb' + - 'ee/spec/services/merge_trains/check_status_service_spec.rb' + - 'ee/spec/services/projects/destroy_service_spec.rb' + - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' + - 'ee/spec/services/projects/update_service_spec.rb' + - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' + - 'ee/spec/support/helpers/ee/stub_configuration.rb' + - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' + - 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/geo/geo_logs_event_source_info_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/member_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' + - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' + - 'ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb' + - 'ee/spec/workers/geo/registry_sync_worker_spec.rb' + - 'ee/spec/workers/geo/repository_cleanup_worker_spec.rb' + - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' + - 'ee/spec/workers/project_cache_worker_spec.rb' + - 'ee/spec/workers/repository_import_worker_spec.rb' + - 'ee/spec/workers/security/auto_fix_worker_spec.rb' + - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' + - 'spec/controllers/admin/sessions_controller_spec.rb' + - 'spec/controllers/application_controller_spec.rb' + - 'spec/controllers/concerns/issuable_actions_spec.rb' + - 'spec/controllers/concerns/static_object_external_storage_spec.rb' + - 'spec/controllers/explore/projects_controller_spec.rb' + - 'spec/controllers/groups/clusters_controller_spec.rb' + - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' + - 'spec/controllers/groups_controller_spec.rb' + - 'spec/controllers/import/bitbucket_controller_spec.rb' + - 'spec/controllers/oauth/jira_dvcs/authorizations_controller_spec.rb' + - 'spec/controllers/omniauth_callbacks_controller_spec.rb' + - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/projects/branches_controller_spec.rb' + - 'spec/controllers/projects/clusters_controller_spec.rb' + - 'spec/controllers/projects/commit_controller_spec.rb' + - 'spec/controllers/projects/commits_controller_spec.rb' + - 'spec/controllers/projects/environments_controller_spec.rb' + - 'spec/controllers/projects/imports_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/controllers/projects/labels_controller_spec.rb' + - 'spec/controllers/projects/merge_requests_controller_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb' + - 'spec/controllers/projects/settings/integrations_controller_spec.rb' + - 'spec/controllers/projects/tags_controller_spec.rb' + - 'spec/controllers/registrations_controller_spec.rb' + - 'spec/controllers/sessions_controller_spec.rb' + - 'spec/controllers/snippets/notes_controller_spec.rb' + - 'spec/controllers/snippets_controller_spec.rb' + - 'spec/features/admin/admin_mode/login_spec.rb' + - 'spec/features/groups/members/tabs_spec.rb' + - 'spec/features/ide/static_object_external_storage_csp_spec.rb' + - 'spec/features/issuables/issuable_list_spec.rb' + - 'spec/features/issues/form_spec.rb' + - 'spec/features/merge_request/user_creates_image_diff_notes_spec.rb' + - 'spec/features/merge_request/user_reviews_image_spec.rb' + - 'spec/features/merge_request/user_sees_diff_spec.rb' + - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' + - 'spec/features/projects/clusters/gcp_spec.rb' + - 'spec/features/projects/clusters_spec.rb' + - 'spec/features/projects/container_registry_spec.rb' + - 'spec/features/projects/files/user_browses_lfs_files_spec.rb' + - 'spec/features/projects/jobs_spec.rb' + - 'spec/features/projects/settings/service_desk_setting_spec.rb' + - 'spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb' + - 'spec/features/snippets/embedded_snippet_spec.rb' + - 'spec/features/usage_stats_consent_spec.rb' + - 'spec/finders/prometheus_metrics_finder_spec.rb' + - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/reset_token_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/update_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/initializers/lograge_spec.rb' + - 'spec/lib/api/entities/merge_request_basic_spec.rb' + - 'spec/lib/api/entities/merge_request_changes_spec.rb' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/backup/files_spec.rb' + - 'spec/lib/backup/manager_spec.rb' + - 'spec/lib/banzai/commit_renderer_spec.rb' + - 'spec/lib/banzai/filter/references/external_issue_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' + - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' + - 'spec/lib/extracts_ref_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitlab/app_logger_spec.rb' + - 'spec/lib/gitlab/asciidoc_spec.rb' + - 'spec/lib/gitlab/auth/auth_finders_spec.rb' + - 'spec/lib/gitlab/auth/blocked_user_tracker_spec.rb' + - 'spec/lib/gitlab/auth/request_authenticator_spec.rb' + - 'spec/lib/gitlab/auth_spec.rb' + - 'spec/lib/gitlab/checks/lfs_check_spec.rb' + - 'spec/lib/gitlab/checks/lfs_integrity_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/base_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/local_spec.rb' + - 'spec/lib/gitlab/ci/config/external/processor_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/build_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' + - 'spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/build_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/npm_spec.rb' + - 'spec/lib/gitlab/ci/trace_spec.rb' + - 'spec/lib/gitlab/current_settings_spec.rb' + - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' + - 'spec/lib/gitlab/diff/highlight_spec.rb' + - 'spec/lib/gitlab/diff/position_spec.rb' + - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' + - 'spec/lib/gitlab/etag_caching/middleware_spec.rb' + - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' + - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/gitaly_client/blob_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/health_check_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/operation_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/praefect_info_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/remote_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' + - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' + - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' + - 'spec/lib/gitlab/import/merge_request_helpers_spec.rb' + - 'spec/lib/gitlab/import_export/config_spec.rb' + - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' + - 'spec/lib/gitlab/import_export/importer_spec.rb' + - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/version_checker_spec.rb' + - 'spec/lib/gitlab/job_waiter_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' + - 'spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb' + - 'spec/lib/gitlab/metrics/rack_middleware_spec.rb' + - 'spec/lib/gitlab/metrics_spec.rb' + - 'spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb' + - 'spec/lib/gitlab/tracking/destinations/snowplow_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/lib/gitlab/workhorse_spec.rb' + - 'spec/lib/gitlab/x509/commit_spec.rb' + - 'spec/lib/gitlab/x509/signature_spec.rb' + - 'spec/lib/google_api/cloud_platform/client_spec.rb' + - 'spec/lib/json_web_token/rsa_token_spec.rb' + - 'spec/lib/mattermost/command_spec.rb' + - 'spec/lib/mattermost/team_spec.rb' + - 'spec/lib/system_check/simple_executor_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/runner_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/environment_spec.rb' + - 'spec/models/hooks/service_hook_spec.rb' + - 'spec/models/hooks/system_hook_spec.rb' + - 'spec/models/integrations/jira_spec.rb' + - 'spec/models/key_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/merge_request_diff_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/project_import_state_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/x509_certificate_spec.rb' + - 'spec/policies/ci/build_policy_spec.rb' + - 'spec/policies/ci/pipeline_policy_spec.rb' + - 'spec/presenters/gitlab/blame_presenter_spec.rb' + - 'spec/presenters/merge_request_presenter_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_put_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' + - 'spec/requests/api/ci/runner/runners_delete_spec.rb' + - 'spec/requests/api/ci/runner/runners_post_spec.rb' + - 'spec/requests/api/ci/runner/runners_verify_post_spec.rb' + - 'spec/requests/api/graphql/gitlab_schema_spec.rb' + - 'spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb' + - 'spec/requests/api/helpers_spec.rb' + - 'spec/requests/api/internal/base_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/project_export_spec.rb' + - 'spec/requests/api/project_import_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/snippets_spec.rb' + - 'spec/requests/api/todos_spec.rb' + - 'spec/requests/git_http_spec.rb' + - 'spec/requests/import/gitlab_projects_controller_spec.rb' + - 'spec/routing/routing_spec.rb' + - 'spec/serializers/merge_request_poll_cached_widget_entity_spec.rb' + - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'spec/services/application_settings/update_service_spec.rb' + - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/register_job_service_spec.rb' + - 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb' + - 'spec/services/ci/retry_pipeline_service_spec.rb' + - 'spec/services/clusters/cleanup/project_namespace_service_spec.rb' + - 'spec/services/clusters/cleanup/service_account_service_spec.rb' + - 'spec/services/deployments/older_deployments_drop_service_spec.rb' + - 'spec/services/deployments/update_environment_service_spec.rb' + - 'spec/services/draft_notes/destroy_service_spec.rb' + - 'spec/services/events/render_service_spec.rb' + - 'spec/services/git/branch_push_service_spec.rb' + - 'spec/services/git/process_ref_changes_service_spec.rb' + - 'spec/services/groups/create_service_spec.rb' + - 'spec/services/groups/update_service_spec.rb' + - 'spec/services/issuable/destroy_service_spec.rb' + - 'spec/services/issues/close_service_spec.rb' + - 'spec/services/issues/reopen_service_spec.rb' + - 'spec/services/members/destroy_service_spec.rb' + - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' + - 'spec/services/merge_requests/build_service_spec.rb' + - 'spec/services/merge_requests/merge_service_spec.rb' + - 'spec/services/merge_requests/mergeability_check_service_spec.rb' + - 'spec/services/merge_requests/refresh_service_spec.rb' + - 'spec/services/merge_requests/reload_diffs_service_spec.rb' + - 'spec/services/merge_requests/resolved_discussion_notification_service_spec.rb' + - 'spec/services/metrics/dashboard/custom_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' + - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/notes/render_service_spec.rb' + - 'spec/services/packages/conan/create_package_file_service_spec.rb' + - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' + - 'spec/services/post_receive_service_spec.rb' + - 'spec/services/projects/after_rename_service_spec.rb' + - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' + - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' + - 'spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb' + - 'spec/services/projects/destroy_service_spec.rb' + - 'spec/services/projects/fork_service_spec.rb' + - 'spec/services/projects/import_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' + - 'spec/services/projects/transfer_service_spec.rb' + - 'spec/services/projects/update_remote_mirror_service_spec.rb' + - 'spec/services/projects/update_service_spec.rb' + - 'spec/services/projects/update_statistics_service_spec.rb' + - 'spec/services/resource_events/change_labels_service_spec.rb' + - 'spec/services/search_service_spec.rb' + - 'spec/services/snippets/create_service_spec.rb' + - 'spec/services/todo_service_spec.rb' + - 'spec/services/users/destroy_service_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/capybara.rb' + - 'spec/support/helpers/api_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/helpers/ldap_helpers.rb' + - 'spec/support/helpers/login_helpers.rb' + - 'spec/support/helpers/metrics_dashboard_url_helpers.rb' + - 'spec/support/helpers/rake_helpers.rb' + - 'spec/support/helpers/stub_configuration.rb' + - 'spec/support/helpers/stub_gitlab_calls.rb' + - 'spec/support/import_export/common_util.rb' + - 'spec/support/services/migrate_to_ghost_user_service_shared_examples.rb' + - 'spec/support/shared_contexts/email_shared_context.rb' + - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' + - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' + - 'spec/support/shared_examples/controllers/issuable_notes_filter_shared_examples.rb' + - 'spec/support/shared_examples/controllers/issuables_requiring_filter_shared_examples.rb' + - 'spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb' + - 'spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb' + - 'spec/support/shared_examples/controllers/update_invalid_issuable_shared_examples.rb' + - 'spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb' + - 'spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb' + - 'spec/support/shared_examples/features/snippets_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/models/atomic_internal_id_shared_examples.rb' + - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb' + - 'spec/support/shared_examples/models/integrations/base_slash_commands_shared_examples.rb' + - 'spec/support/shared_examples/models/mentionable_shared_examples.rb' + - 'spec/support/shared_examples/models/with_uploads_shared_examples.rb' + - 'spec/support/shared_examples/path_extraction_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/snippets_shared_examples.rb' + - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' + - 'spec/support/shared_examples/requests/snippet_shared_examples.rb' + - 'spec/support/shared_examples/services/boards/issues_list_service_shared_examples.rb' + - 'spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb' + - 'spec/support/shared_examples/services/issuable_shared_examples.rb' + - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' + - 'spec/support/shared_examples/workers/authorized_projects_worker_shared_example.rb' + - 'spec/support/shared_examples/workers/reactive_cacheable_shared_examples.rb' + - 'spec/tasks/gitlab/cleanup_rake_spec.rb' + - 'spec/tasks/gitlab/container_registry_rake_spec.rb' + - 'spec/tasks/gitlab/db_rake_spec.rb' + - 'spec/tasks/gitlab/praefect_rake_spec.rb' + - 'spec/tasks/gitlab/shell_rake_spec.rb' + - 'spec/tasks/gitlab/x509/update_rake_spec.rb' + - 'spec/uploaders/file_mover_spec.rb' + - 'spec/uploaders/records_uploads_spec.rb' + - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' + - 'spec/views/layouts/_head.html.haml_spec.rb' + - 'spec/workers/build_hooks_worker_spec.rb' + - 'spec/workers/ci/build_schedule_worker_spec.rb' + - 'spec/workers/ci/daily_build_group_report_results_worker_spec.rb' + - 'spec/workers/cluster_provision_worker_spec.rb' + - 'spec/workers/clusters/cleanup/project_namespace_worker_spec.rb' + - 'spec/workers/clusters/cleanup/service_account_worker_spec.rb' + - 'spec/workers/concerns/project_import_options_spec.rb' + - 'spec/workers/create_commit_signature_worker_spec.rb' + - 'spec/workers/create_note_diff_file_worker_spec.rb' + - 'spec/workers/delete_diff_files_worker_spec.rb' + - 'spec/workers/email_receiver_worker_spec.rb' + - 'spec/workers/emails_on_push_worker_spec.rb' + - 'spec/workers/error_tracking_issue_link_worker_spec.rb' + - 'spec/workers/group_export_worker_spec.rb' + - 'spec/workers/group_import_worker_spec.rb' + - 'spec/workers/namespaces/root_statistics_worker_spec.rb' + - 'spec/workers/new_note_worker_spec.rb' + - 'spec/workers/object_pool/create_worker_spec.rb' + - 'spec/workers/packages/nuget/extraction_worker_spec.rb' + - 'spec/workers/pipeline_process_worker_spec.rb' + - 'spec/workers/pipeline_schedule_worker_spec.rb' + - 'spec/workers/project_cache_worker_spec.rb' + - 'spec/workers/stage_update_worker_spec.rb' + - 'spec/workers/wait_for_cluster_creation_worker_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 5e9e80402b4..5a01f229482 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1,7 +1,6 @@ --- RSpec/ContextWording: Exclude: - - 'ee/spec/components/namespaces/free_user_cap/personal_usage_quota_limitations_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' - 'ee/spec/controllers/admin/dev_ops_report_controller_spec.rb' @@ -11,7 +10,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/admin/push_rules_controller_spec.rb' - 'ee/spec/controllers/admin/users_controller_spec.rb' - 'ee/spec/controllers/autocomplete_controller_spec.rb' - - 'ee/spec/controllers/boards/lists_controller_spec.rb' - 'ee/spec/controllers/dashboard_controller_spec.rb' - 'ee/spec/controllers/ee/groups/variables_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' @@ -24,7 +22,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/groups/billings_controller_spec.rb' - - 'ee/spec/controllers/groups/boards_controller_spec.rb' - 'ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb' @@ -36,7 +33,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/groups/push_rules_controller_spec.rb' - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - - 'ee/spec/controllers/groups/security/merge_commit_reports_controller_spec.rb' - 'ee/spec/controllers/groups/sso_controller_spec.rb' - 'ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' - 'ee/spec/controllers/oauth/applications_controller_spec.rb' @@ -44,7 +40,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/profiles_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/environments_controller_spec.rb' - 'ee/spec/controllers/projects/imports_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/escalation_policies_controller_spec.rb' @@ -115,18 +110,15 @@ RSpec/ContextWording: - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/groups/groups_security_credentials_spec.rb' - 'ee/spec/features/groups/issues_spec.rb' - - 'ee/spec/features/groups/iteration_spec.rb' - 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb' - 'ee/spec/features/groups/ldap_group_links_spec.rb' - 'ee/spec/features/groups/members/manage_groups_spec.rb' - - 'ee/spec/features/groups/members/manage_members_spec.rb' - 'ee/spec/features/groups/push_rules_spec.rb' - 'ee/spec/features/groups/saml_enforcement_spec.rb' - 'ee/spec/features/groups/saml_providers_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/groups_spec.rb' - - 'ee/spec/features/ide/user_commits_changes_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb' @@ -153,7 +145,6 @@ RSpec/ContextWording: - 'ee/spec/features/merge_requests/user_filters_by_approvers_spec.rb' - 'ee/spec/features/oncall_schedules/user_creates_schedule_spec.rb' - 'ee/spec/features/profiles/account_spec.rb' - - 'ee/spec/features/profiles/usage_quotas_spec.rb' - 'ee/spec/features/projects/active_tabs_spec.rb' - 'ee/spec/features/projects/audit_events_spec.rb' - 'ee/spec/features/projects/custom_projects_template_spec.rb' @@ -180,9 +171,7 @@ RSpec/ContextWording: - 'ee/spec/features/projects/settings/push_rules_settings_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/welcome_spec.rb' - - 'ee/spec/features/search/elastic/global_search_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/features/trials/select_namespace_spec.rb' @@ -289,7 +278,6 @@ RSpec/ContextWording: - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - 'ee/spec/helpers/ee/lock_helper_spec.rb' @@ -318,7 +306,6 @@ RSpec/ContextWording: - 'ee/spec/lib/banzai/reference_parser/iteration_parser_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - 'ee/spec/lib/ee/api/entities/analytics/group_activity_spec.rb' - - 'ee/spec/lib/ee/api/entities/billable_member_spec.rb' - 'ee/spec/lib/ee/api/entities/geo_node_status_spec.rb' - 'ee/spec/lib/ee/api/entities/project_spec.rb' - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' @@ -378,23 +365,17 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/runners_availability_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/dependency_list/dependency_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' @@ -438,7 +419,6 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/insights/finders/issuable_finder_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - - 'ee/spec/lib/gitlab/pagination_delegate_spec.rb' - 'ee/spec/lib/gitlab/search/aggregation_parser_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb' - 'ee/spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' @@ -546,7 +526,6 @@ RSpec/ContextWording: - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/project_team_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - - 'ee/spec/models/protected_environments/approval_summary_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' - 'ee/spec/models/requirements_management/test_report_spec.rb' @@ -670,7 +649,6 @@ RSpec/ContextWording: - 'ee/spec/requests/git_http_geo_spec.rb' - 'ee/spec/requests/groups/roadmap_controller_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' - - 'ee/spec/requests/groups/settings/reporting_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/jwt_controller_spec.rb' - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' @@ -687,7 +665,6 @@ RSpec/ContextWording: - 'ee/spec/routing/user_routing_spec.rb' - 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb' - 'ee/spec/serializers/blocking_merge_request_entity_spec.rb' - - 'ee/spec/serializers/board_serializer_spec.rb' - 'ee/spec/serializers/clusters/environment_entity_spec.rb' - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' - 'ee/spec/serializers/ee/group_child_entity_spec.rb' @@ -743,10 +720,8 @@ RSpec/ContextWording: - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - - 'ee/spec/services/ee/issues/close_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/move_service_spec.rb' - - 'ee/spec/services/ee/issues/reopen_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' @@ -769,8 +744,6 @@ RSpec/ContextWording: - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - 'ee/spec/services/ee/users/build_service_spec.rb' - 'ee/spec/services/ee/users/create_service_spec.rb' - - 'ee/spec/services/ee/users/destroy_service_spec.rb' - - 'ee/spec/services/ee/users/migrate_to_ghost_user_service_spec.rb' - 'ee/spec/services/ee/users/reject_service_spec.rb' - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' @@ -792,7 +765,6 @@ RSpec/ContextWording: - 'ee/spec/services/geo/container_repository_sync_service_spec.rb' - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/geo/design_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' - 'ee/spec/services/geo/move_repository_service_spec.rb' @@ -804,8 +776,6 @@ RSpec/ContextWording: - 'ee/spec/services/geo/repository_sync_service_spec.rb' - 'ee/spec/services/geo/repository_verification_reset_spec.rb' - 'ee/spec/services/geo/wiki_sync_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/activate_awaiting_users_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/extend_reactivate_trial_service_spec.rb' @@ -830,7 +800,6 @@ RSpec/ContextWording: - 'ee/spec/services/incident_management/pending_escalations/create_service_spec.rb' - 'ee/spec/services/incident_management/pending_escalations/process_service_spec.rb' - 'ee/spec/services/issues/build_service_spec.rb' - - 'ee/spec/services/issues/export_csv_service_spec.rb' - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - 'ee/spec/services/iterations/create_service_spec.rb' - 'ee/spec/services/iterations/update_service_spec.rb' @@ -839,7 +808,6 @@ RSpec/ContextWording: - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/reload_merge_head_diff_service_spec.rb' @@ -868,14 +836,12 @@ RSpec/ContextWording: - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - 'ee/spec/services/requirements_management/export_csv_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb' - 'ee/spec/services/search/global_service_spec.rb' - 'ee/spec/services/search/group_service_spec.rb' - 'ee/spec/services/search/project_service_spec.rb' - 'ee/spec/services/search/snippet_service_spec.rb' - - 'ee/spec/services/search_service_spec.rb' - 'ee/spec/services/security/dependency_list_service_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/create_spec.rb' - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' @@ -959,7 +925,6 @@ RSpec/ContextWording: - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb' - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' - - 'ee/spec/views/projects/edit.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/search/_category.html.haml_spec.rb' @@ -968,7 +933,6 @@ RSpec/ContextWording: - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/gpg_keys/_gpg_key.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' - 'ee/spec/views/shared/issuable/_sidebar.html.haml_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' @@ -1006,60 +970,29 @@ RSpec/ContextWording: - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/automatic_failover_and_recovery_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/backend_node_recovery_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/gitaly_mtls_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_connectivity_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_dataloss_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_replication_queue_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/batch_suggestion_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/custom_commit_suggestion_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/file/create_file_via_web_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/file/delete_file_via_web_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/file/edit_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/server_hooks_custom_error_message_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/content_editor_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_creation_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_manipulation_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_directory_management_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_list_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_page_deletion_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - - 'qa/qa/specs/features/browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_tier_group_namespace_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_2_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/insights/default_insights_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/epics_management_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/wiki/create_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/element_spec.rb' @@ -1134,7 +1067,6 @@ RSpec/ContextWording: - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - - 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb' - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/badges_controller_spec.rb' @@ -1143,7 +1075,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/boards_controller_spec.rb' - 'spec/controllers/projects/branches_controller_spec.rb' - 'spec/controllers/projects/ci/lints_controller_spec.rb' - - 'spec/controllers/projects/ci/secure_files_controller_spec.rb' - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/commit_controller_spec.rb' - 'spec/controllers/projects/commits_controller_spec.rb' @@ -1175,7 +1106,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/pages_domains_controller_spec.rb' - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/controllers/projects/product_analytics_controller_spec.rb' - 'spec/controllers/projects/project_members_controller_spec.rb' - 'spec/controllers/projects/prometheus/alerts_controller_spec.rb' - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' @@ -1342,7 +1272,6 @@ RSpec/ContextWording: - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/merge_requests/user_mass_updates_spec.rb' - 'spec/features/milestones/user_views_milestone_spec.rb' - - 'spec/features/monitor_sidebar_link_spec.rb' - 'spec/features/nav/top_nav_responsive_spec.rb' - 'spec/features/oauth_login_spec.rb' - 'spec/features/one_trust_spec.rb' @@ -1481,7 +1410,6 @@ RSpec/ContextWording: - 'spec/finders/license_template_finder_spec.rb' - 'spec/finders/merge_request_target_project_finder_spec.rb' - 'spec/finders/merge_requests/by_approvals_finder_spec.rb' - - 'spec/finders/merge_requests_finder/params_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' - 'spec/finders/metrics/dashboards/annotations_finder_spec.rb' - 'spec/finders/metrics/users_starred_dashboards_finder_spec.rb' @@ -1519,7 +1447,6 @@ RSpec/ContextWording: - 'spec/frontend/fixtures/search.rb' - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - - 'spec/graphql/features/feature_flag_spec.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb' @@ -1630,7 +1557,6 @@ RSpec/ContextWording: - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/submodule_helper_spec.rb' - 'spec/helpers/timeboxes_helper_spec.rb' - 'spec/helpers/todos_helper_spec.rb' @@ -1752,10 +1678,7 @@ RSpec/ContextWording: - 'spec/lib/container_registry/migration_spec.rb' - 'spec/lib/container_registry/registry_spec.rb' - 'spec/lib/container_registry/tag_spec.rb' - - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - - 'spec/lib/error_tracking/sentry_client/issue_link_spec.rb' - 'spec/lib/error_tracking/sentry_client/projects_spec.rb' - - 'spec/lib/error_tracking/sentry_client/repo_spec.rb' - 'spec/lib/expand_variables_spec.rb' - 'spec/lib/extracts_path_spec.rb' - 'spec/lib/extracts_ref_spec.rb' @@ -1792,7 +1715,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/avatar_cache_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' @@ -1983,8 +1905,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - - 'spec/lib/gitlab/experimentation_spec.rb' - 'spec/lib/gitlab/external_authorization/access_spec.rb' - 'spec/lib/gitlab/favicon_spec.rb' - 'spec/lib/gitlab/file_hook_spec.rb' @@ -1999,7 +1919,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/compare_spec.rb' - 'spec/lib/gitlab/git/conflict/parser_spec.rb' - - 'spec/lib/gitlab/git/cross_repo_comparer_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' @@ -2076,9 +1995,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/version_checker_spec.rb' - - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' - - 'spec/lib/gitlab/instrumentation/redis_cluster_validator_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - 'spec/lib/gitlab/internal_post_receive/response_spec.rb' - 'spec/lib/gitlab/issuable/clone/attributes_rewriter_spec.rb' @@ -2105,7 +2022,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' - 'spec/lib/gitlab/memory/watchdog_spec.rb' - - 'spec/lib/gitlab/merge_requests/commit_message_generator_spec.rb' + - 'spec/lib/gitlab/merge_requests/message_generator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/cache_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importer_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' @@ -2115,7 +2032,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/metrics/dashboard/validator/post_schema_validator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator_spec.rb' - 'spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb' - - 'spec/lib/gitlab/metrics/method_call_spec.rb' - 'spec/lib/gitlab/metrics/methods_spec.rb' - 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' @@ -2179,7 +2095,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/search/sort_options_spec.rb' - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' - - 'spec/lib/gitlab/service_desk_email_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' @@ -2207,7 +2122,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/ssh_public_key_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - - 'spec/lib/gitlab/subscription_portal_spec.rb' - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/time_tracking_formatter_spec.rb' @@ -2223,7 +2137,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/url_sanitizer_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/aggregates/aggregate_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' @@ -2232,7 +2145,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/ci_template_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/ipynb_diff_activity_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' @@ -2360,7 +2272,6 @@ RSpec/ContextWording: - 'spec/models/concerns/ci/artifactable_spec.rb' - 'spec/models/concerns/ci/has_ref_spec.rb' - 'spec/models/concerns/ci/has_status_spec.rb' - - 'spec/models/concerns/cross_database_modification_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' @@ -2397,13 +2308,11 @@ RSpec/ContextWording: - 'spec/models/environment_status_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - 'spec/models/event_spec.rb' - - 'spec/models/experiment_spec.rb' - 'spec/models/external_pull_request_spec.rb' - 'spec/models/gpg_key_spec.rb' - 'spec/models/grafana_integration_spec.rb' - 'spec/models/group_label_spec.rb' - 'spec/models/group_spec.rb' - - 'spec/models/hooks/active_hook_filter_spec.rb' - 'spec/models/hooks/project_hook_spec.rb' - 'spec/models/hooks/system_hook_spec.rb' - 'spec/models/identity_spec.rb' @@ -2429,7 +2338,6 @@ RSpec/ContextWording: - 'spec/models/integrations/microsoft_teams_spec.rb' - 'spec/models/integrations/pipelines_email_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - - 'spec/models/integrations/slack_spec.rb' - 'spec/models/integrations/teamcity_spec.rb' - 'spec/models/internal_id_spec.rb' - 'spec/models/issue/metrics_spec.rb' @@ -2446,7 +2354,6 @@ RSpec/ContextWording: - 'spec/models/merge_request_assignee_spec.rb' - 'spec/models/merge_request_diff_file_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/merge_request_reviewer_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/models/metrics/dashboard/annotation_spec.rb' - 'spec/models/metrics/users_starred_dashboard_spec.rb' @@ -2610,7 +2517,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' - 'spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb' - 'spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb' - - 'spec/requests/api/graphql/mutations/branches/create_spec.rb' - 'spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb' - 'spec/requests/api/graphql/mutations/commits/create_spec.rb' - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' @@ -2620,19 +2526,16 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/issues/set_crm_contacts_spec.rb' - 'spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/create_spec.rb' - - 'spec/requests/api/graphql/mutations/merge_requests/request_attention_spec.rb' - 'spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb' - 'spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'spec/requests/api/graphql/mutations/remove_attention_request_spec.rb' - 'spec/requests/api/graphql/mutations/todos/create_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/create_from_task_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/create_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/delete_task_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/update_task_spec.rb' - - 'spec/requests/api/graphql/mutations/work_items/update_widgets_spec.rb' - 'spec/requests/api/graphql/namespace_query_spec.rb' - 'spec/requests/api/graphql/packages/maven_spec.rb' - 'spec/requests/api/graphql/packages/package_spec.rb' @@ -2643,7 +2546,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' - 'spec/requests/api/graphql/project/issue_spec.rb' - - 'spec/requests/api/graphql/project/issues_spec.rb' - 'spec/requests/api/graphql/project/jira_import_spec.rb' - 'spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' @@ -2720,7 +2622,6 @@ RSpec/ContextWording: - 'spec/requests/api/terraform/state_version_spec.rb' - 'spec/requests/api/todos_spec.rb' - 'spec/requests/api/usage_data_spec.rb' - - 'spec/requests/api/user_counts_spec.rb' - 'spec/requests/api/users_preferences_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/api/v3/github_spec.rb' @@ -2744,8 +2645,6 @@ RSpec/ContextWording: - 'spec/requests/mailgun/webhooks_controller_spec.rb' - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/openid_connect_spec.rb' - - 'spec/requests/product_analytics/collector_app_attack_spec.rb' - - 'spec/requests/product_analytics/collector_app_spec.rb' - 'spec/requests/projects/clusters/integrations_controller_spec.rb' - 'spec/requests/projects/commits_controller_spec.rb' - 'spec/requests/projects/google_cloud/configuration_controller_spec.rb' @@ -2795,12 +2694,10 @@ RSpec/ContextWording: - 'spec/rubocop/cop/rspec/factory_bot/inline_association_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - - 'spec/serializers/board_serializer_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - - 'spec/serializers/diff_file_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' - 'spec/serializers/environment_entity_spec.rb' - 'spec/serializers/environment_serializer_spec.rb' @@ -2811,8 +2708,6 @@ RSpec/ContextWording: - 'spec/serializers/member_serializer_spec.rb' - 'spec/serializers/merge_request_diff_entity_spec.rb' - 'spec/serializers/merge_request_serializer_spec.rb' - - 'spec/serializers/merge_request_user_entity_spec.rb' - - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/pipeline_details_entity_spec.rb' - 'spec/serializers/user_serializer_spec.rb' - 'spec/services/access_token_validation_service_spec.rb' @@ -2838,7 +2733,6 @@ RSpec/ContextWording: - 'spec/services/ci/create_pipeline_service/cache_spec.rb' - 'spec/services/ci/create_pipeline_service/custom_config_content_spec.rb' - 'spec/services/ci/create_pipeline_service/include_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' - 'spec/services/ci/create_pipeline_service/needs_spec.rb' - 'spec/services/ci/create_pipeline_service/parallel_spec.rb' @@ -2865,13 +2759,7 @@ RSpec/ContextWording: - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' - 'spec/services/clusters/agents/refresh_authorization_service_spec.rb' - - 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - - 'spec/services/clusters/applications/destroy_service_spec.rb' - 'spec/services/clusters/applications/install_service_spec.rb' - - 'spec/services/clusters/applications/patch_service_spec.rb' - - 'spec/services/clusters/applications/uninstall_service_spec.rb' - - 'spec/services/clusters/applications/update_service_spec.rb' - 'spec/services/clusters/applications/upgrade_service_spec.rb' - 'spec/services/clusters/aws/authorize_role_service_spec.rb' - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb' @@ -2881,7 +2769,6 @@ RSpec/ContextWording: - 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb' - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/gcp/finalize_creation_service_spec.rb' - - 'spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb' @@ -2942,7 +2829,6 @@ RSpec/ContextWording: - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - 'spec/services/incident_management/incidents/create_service_spec.rb' - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb' - - 'spec/services/incident_management/timeline_events/destroy_service_spec.rb' - 'spec/services/integrations/test/project_service_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issue_links/list_service_spec.rb' @@ -2974,7 +2860,6 @@ RSpec/ContextWording: - 'spec/services/merge_requests/approval_service_spec.rb' - 'spec/services/merge_requests/base_service_spec.rb' - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/services/merge_requests/bulk_remove_attention_requested_service_spec.rb' - 'spec/services/merge_requests/cleanup_refs_service_spec.rb' - 'spec/services/merge_requests/close_service_spec.rb' - 'spec/services/merge_requests/create_from_issue_service_spec.rb' @@ -2993,8 +2878,6 @@ RSpec/ContextWording: - 'spec/services/merge_requests/reload_diffs_service_spec.rb' - 'spec/services/merge_requests/reopen_service_spec.rb' - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/merge_requests/toggle_attention_requested_service_spec.rb' - - 'spec/services/merge_requests/update_assignees_service_spec.rb' - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/annotations/create_service_spec.rb' - 'spec/services/metrics/dashboard/annotations/delete_service_spec.rb' @@ -3034,7 +2917,6 @@ RSpec/ContextWording: - 'spec/services/packages/conan/create_package_service_spec.rb' - 'spec/services/packages/create_package_file_service_spec.rb' - 'spec/services/packages/debian/create_distribution_service_spec.rb' - - 'spec/services/packages/debian/create_package_file_service_spec.rb' - 'spec/services/packages/debian/extract_metadata_service_spec.rb' - 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb' - 'spec/services/packages/debian/find_or_create_package_service_spec.rb' @@ -3129,7 +3011,6 @@ RSpec/ContextWording: - 'spec/services/users/approve_service_spec.rb' - 'spec/services/users/ban_service_spec.rb' - 'spec/services/users/destroy_service_spec.rb' - - 'spec/services/users/migrate_to_ghost_user_service_spec.rb' - 'spec/services/users/refresh_authorized_projects_service_spec.rb' - 'spec/services/users/reject_service_spec.rb' - 'spec/services/users/set_status_service_spec.rb' @@ -3285,7 +3166,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/repository_storage_movable_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/timebox_shared_examples.rb' - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' - 'spec/support/shared_examples/models/integrations/base_slash_commands_shared_examples.rb' @@ -3446,7 +3326,6 @@ RSpec/ContextWording: - 'spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb' - 'spec/workers/ci/build_prepare_worker_spec.rb' - 'spec/workers/cleanup_container_repository_worker_spec.rb' - - 'spec/workers/cluster_update_app_worker_spec.rb' - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' - 'spec/workers/concerns/waitable_worker_spec.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml index 516eda12675..729423d8abd 100644 --- a/.rubocop_todo/rspec/described_class.yml +++ b/.rubocop_todo/rspec/described_class.yml @@ -1,28 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/DescribedClass: Exclude: - - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' - - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' - - 'ee/spec/controllers/concerns/routable_actions_spec.rb' - - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' - - 'ee/spec/frontend/fixtures/epic.rb' - - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' - - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - - 'ee/spec/lib/gitlab/auth/saml/config_spec.rb' - - 'ee/spec/lib/gitlab/checks/changes_access_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb' - - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - - 'ee/spec/lib/gitlab/geo_spec.rb' - - 'ee/spec/lib/gitlab/gl_repository/repo_type_spec.rb' - - 'ee/spec/lib/gitlab/instrumentation/elasticsearch_transport_spec.rb' - - 'ee/spec/lib/gitlab/vulnerabilities/findings_preloader_spec.rb' - - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - - 'ee/spec/models/ci/processable_spec.rb' - - 'ee/spec/models/concerns/elastic/issue_spec.rb' - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' - 'ee/spec/models/concerns/elastic/project_spec.rb' @@ -63,7 +42,6 @@ RSpec/DescribedClass: - 'ee/spec/models/vulnerabilities/flag_spec.rb' - 'ee/spec/models/vulnerabilities/read_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/ee/resource_events/synthetic_weight_notes_builder_service_spec.rb' - 'ee/spec/services/ee/users/reject_service_spec.rb' - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' @@ -74,7 +52,6 @@ RSpec/DescribedClass: - 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb' - 'qa/spec/service/docker_run/base_spec.rb' - - 'qa/spec/support/formatters/test_stats_formatter_spec.rb' - 'qa/spec/support/loglinking_spec.rb' - 'qa/spec/support/page_error_checker_spec.rb' - 'spec/config/settings_spec.rb' @@ -136,7 +113,6 @@ RSpec/DescribedClass: - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - 'spec/lib/gitlab/encrypted_configuration_spec.rb' - 'spec/lib/gitlab/error_tracking/logger_spec.rb' - - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/blob_spec.rb' - 'spec/lib/gitlab/git/commit_spec.rb' @@ -205,7 +181,6 @@ RSpec/DescribedClass: - 'spec/models/customer_relations/organization_spec.rb' - 'spec/models/dependency_proxy/manifest_spec.rb' - 'spec/models/deployment_spec.rb' - - 'spec/models/experiment_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/import_failure_spec.rb' - 'spec/models/integration_spec.rb' @@ -259,7 +234,6 @@ RSpec/DescribedClass: - 'spec/services/auth/dependency_proxy_authentication_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' - 'spec/services/issuable/process_assignees_spec.rb' - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' - 'spec/services/merge_requests/update_service_spec.rb' @@ -267,7 +241,6 @@ RSpec/DescribedClass: - 'spec/services/projects/create_service_spec.rb' - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/resource_events/synthetic_label_notes_builder_service_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' - 'spec/services/system_hooks_service_spec.rb' - 'spec/services/user_project_access_changed_service_spec.rb' diff --git a/.rubocop_todo/rspec/empty_example_group.yml b/.rubocop_todo/rspec/empty_example_group.yml deleted file mode 100644 index 09906638cd8..00000000000 --- a/.rubocop_todo/rspec/empty_example_group.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -RSpec/EmptyExampleGroup: - Exclude: - - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' - - 'spec/services/projects/prometheus/alerts/notify_service_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_example_group.yml b/.rubocop_todo/rspec/empty_line_after_example_group.yml deleted file mode 100644 index 80d60ee181e..00000000000 --- a/.rubocop_todo/rspec/empty_line_after_example_group.yml +++ /dev/null @@ -1,39 +0,0 @@ ---- -# Cop supports --auto-correct. -RSpec/EmptyLineAfterExampleGroup: - Exclude: - - 'ee/spec/controllers/groups/clusters_controller_spec.rb' - - 'ee/spec/controllers/groups/groups_controller_spec.rb' - - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - - 'ee/spec/features/security/group/private_access_spec.rb' - - 'ee/spec/lib/gitlab/vulnerabilities/container_scanning_vulnerability_spec.rb' - - 'ee/spec/services/ee/gpg_keys/create_service_spec.rb' - - 'ee/spec/services/ee/issues/create_from_vulnerability_data_service_spec.rb' - - 'ee/spec/services/vulnerabilities/confirm_service_spec.rb' - - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' - - 'ee/spec/services/vulnerabilities/resolve_service_spec.rb' - - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' - - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' - - 'qa/spec/support/loglinking_spec.rb' - - 'spec/controllers/explore/projects_controller_spec.rb' - - 'spec/controllers/projects/notes_controller_spec.rb' - - 'spec/factories/projects/ci_feature_usages.rb' - - 'spec/features/security/group/internal_access_spec.rb' - - 'spec/features/security/group/private_access_spec.rb' - - 'spec/features/security/group/public_access_spec.rb' - - 'spec/helpers/blob_helper_spec.rb' - - 'spec/helpers/git_helper_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - - 'spec/lib/gitlab/blob_helper_spec.rb' - - 'spec/lib/gitlab/file_type_detection_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - - 'spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/project_feature_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/zoom_meeting_spec.rb' - - 'spec/requests/api/graphql/project/issues_spec.rb' - - 'spec/requests/api/projects_spec.rb' - - 'spec/routing/project_routing_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_hook.yml b/.rubocop_todo/rspec/empty_line_after_hook.yml index 125055044de..263fde8f38e 100644 --- a/.rubocop_todo/rspec/empty_line_after_hook.yml +++ b/.rubocop_todo/rspec/empty_line_after_hook.yml @@ -1,13 +1,11 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/EmptyLineAfterHook: Exclude: - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' - - 'ee/spec/features/profiles/usage_quotas_spec.rb' - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' - - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' @@ -16,17 +14,13 @@ RSpec/EmptyLineAfterHook: - 'ee/spec/models/ee/key_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - - 'ee/spec/requests/search_controller_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' - 'ee/spec/services/external_status_checks/update_service_spec.rb' - 'ee/spec/services/group_saml/saml_group_links/destroy_service_spec.rb' - 'ee/spec/services/groups/memberships/export_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'qa/spec/specs/helpers/quarantine_spec.rb' - 'qa/spec/support/page_error_checker_spec.rb' - 'spec/controllers/admin/spam_logs_controller_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 83892031a6c..23bb61a5d68 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,913 +1,464 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/ExpectChange: Details: grace period Exclude: - - 'ee/spec/controllers/admin/applications_controller_spec.rb' - - 'ee/spec/controllers/ee/groups_controller_spec.rb' - - 'ee/spec/controllers/ee/omniauth_callbacks_controller_spec.rb' - - 'ee/spec/controllers/ee/registrations_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb' - - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb' - - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb' - - 'ee/spec/controllers/groups/epics_controller_spec.rb' - - 'ee/spec/controllers/groups/issues_controller_spec.rb' - - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - - 'ee/spec/controllers/oauth/applications_controller_spec.rb' - - 'ee/spec/controllers/passwords_controller_spec.rb' - - 'ee/spec/controllers/profiles/keys_controller_spec.rb' - - 'ee/spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'ee/spec/controllers/projects/mirrors_controller_spec.rb' - - 'ee/spec/controllers/projects/path_locks_controller_spec.rb' - - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' - - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' - - 'ee/spec/features/groups/group_settings_spec.rb' - - 'ee/spec/features/projects_spec.rb' - - 'ee/spec/features/signup_spec.rb' - - 'ee/spec/features/users/login_spec.rb' - - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' - - 'ee/spec/graphql/mutations/dast/profiles/delete_spec.rb' - - 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' - - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' - - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' - - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' - - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - - 'ee/spec/lib/audit/changes_spec.rb' - - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' - - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - - 'ee/spec/lib/bulk_imports/projects/pipelines/push_rule_pipeline_spec.rb' - - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/group_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_ci_cd_setting_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_feature_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_setting_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' - - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' - - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb' - - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' + - 'ee/spec/graphql/mutations/boards/update_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' + - 'ee/spec/lib/audit/compliance_framework_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/group_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_ci_cd_setting_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_feature_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_setting_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/protected_branches_changes_auditor_spec.rb' + - 'ee/spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' + - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_cadences_pipeline_spec.rb' + - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' + - 'ee/spec/lib/ee/feature_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - - 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb' - - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - - 'ee/spec/lib/gitlab/cache_spec.rb' - - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - - 'ee/spec/lib/gitlab/mirror_spec.rb' - - 'ee/spec/migrations/20220411173544_cleanup_orphans_approval_project_rules_spec.rb' - - 'ee/spec/models/ci/bridge_spec.rb' - - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - - 'ee/spec/models/concerns/geo/eventable_spec.rb' - - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - - 'ee/spec/models/container_registry/event_spec.rb' - - 'ee/spec/models/dast/profile_schedule_spec.rb' - - 'ee/spec/models/dast_site_spec.rb' - - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/event_spec.rb' - - 'ee/spec/models/ee/lfs_object_spec.rb' - - 'ee/spec/models/ee/merge_request_diff_spec.rb' - - 'ee/spec/models/ee/pages_deployment_spec.rb' - - 'ee/spec/models/elastic/index_setting_spec.rb' - - 'ee/spec/models/elastic/migration_record_spec.rb' - - 'ee/spec/models/epic_spec.rb' - - 'ee/spec/models/geo/project_registry_spec.rb' - - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' + - 'ee/spec/lib/gitlab/compliance_management/violations/approved_by_committer_spec.rb' + - 'ee/spec/lib/gitlab/compliance_management/violations/approved_by_insufficient_users_spec.rb' + - 'ee/spec/lib/gitlab/compliance_management/violations/approved_by_merge_request_author_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb' + - 'ee/spec/lib/gitlab/instrumentation/elasticsearch_transport_spec.rb' + - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' + - 'ee/spec/lib/quality/seeders/vulnerabilities_spec.rb' + - 'ee/spec/mailers/license_mailer_spec.rb' + - 'ee/spec/migrations/20220517144749_remove_vulnerability_approval_rules_spec.rb' + - 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb' + - 'ee/spec/models/ee/ci/pending_build_spec.rb' + - 'ee/spec/models/ee/group_spec.rb' + - 'ee/spec/models/ee/namespace_spec.rb' + - 'ee/spec/models/ee/project_group_link_spec.rb' + - 'ee/spec/models/ee/user_spec.rb' + - 'ee/spec/models/geo_node_spec.rb' + - 'ee/spec/models/gitlab_subscription_spec.rb' + - 'ee/spec/models/group_wiki_spec.rb' + - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' + - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/project_member_spec.rb' - - 'ee/spec/models/project_spec.rb' - - 'ee/spec/models/repository_spec.rb' - - 'ee/spec/models/requirements_management/requirement_spec.rb' - - 'ee/spec/models/requirements_management/test_report_spec.rb' - - 'ee/spec/models/status_page/published_incident_spec.rb' - - 'ee/spec/models/vulnerabilities/export_spec.rb' - - 'ee/spec/models/vulnerabilities/read_spec.rb' - - 'ee/spec/models/vulnerabilities/statistic_spec.rb' - - 'ee/spec/replicators/geo/pipeline_replicator_spec.rb' - - 'ee/spec/requests/api/ci/pipelines_spec.rb' - - 'ee/spec/requests/api/deployments_spec.rb' - - 'ee/spec/requests/api/epic_issues_spec.rb' - - 'ee/spec/requests/api/epics_spec.rb' - - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/destroy_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/boards/epics/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast/profiles/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast/profiles/delete_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast_site_tokens/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' + - 'ee/spec/models/push_rule_spec.rb' + - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' + - 'ee/spec/models/upload_spec.rb' + - 'ee/spec/replicators/geo/container_repository_replicator_spec.rb' + - 'ee/spec/requests/api/ci/minutes_spec.rb' + - 'ee/spec/requests/api/ci/triggers_spec.rb' + - 'ee/spec/requests/api/ci/variables_spec.rb' + - 'ee/spec/requests/api/features_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/delete_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/finding_dismiss_spec.rb' - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - - 'ee/spec/requests/api/group_push_rule_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/external_issue_links_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' - - 'ee/spec/requests/api/invitations_spec.rb' + - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' - - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/requests/api/project_mirror_spec.rb' - - 'ee/spec/requests/api/project_push_rule_spec.rb' - - 'ee/spec/requests/api/projects_spec.rb' - - 'ee/spec/requests/api/releases_spec.rb' - - 'ee/spec/requests/api/repositories_spec.rb' - - 'ee/spec/requests/api/status_checks_spec.rb' - - 'ee/spec/requests/api/todos_spec.rb' - - 'ee/spec/requests/api/users_spec.rb' - - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/api/provider_identity_spec.rb' + - 'ee/spec/requests/api/visual_review_discussions_spec.rb' - 'ee/spec/requests/groups/epics/related_epic_links_controller_spec.rb' - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - - 'ee/spec/requests/smartcard_controller_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb' - - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service_spec.rb' - - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profiles/audit/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_tokens/find_or_create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_validations/revoke_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_validations/runner_service_spec.rb' - - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - - 'ee/spec/services/application_settings/update_service_spec.rb' - - 'ee/spec/services/approval_rules/finalize_service_spec.rb' - - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' - - 'ee/spec/services/approval_rules/update_service_spec.rb' + - 'ee/spec/requests/registrations/project_creation_spec.rb' + - 'ee/spec/requests/registrations_controller_spec.rb' + - 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/sites/find_or_create_service_spec.rb' + - 'ee/spec/services/applications/create_service_spec.rb' + - 'ee/spec/services/approval_rules/create_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/headers/create_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - - 'ee/spec/services/boards/epic_user_preferences/update_service_spec.rb' - - 'ee/spec/services/boards/epics/create_service_spec.rb' - - 'ee/spec/services/boards/epics/move_service_spec.rb' - - 'ee/spec/services/boards/epics/position_create_service_spec.rb' - - 'ee/spec/services/ci/destroy_pipeline_service_spec.rb' - - 'ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb' - - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' - - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' - - 'ee/spec/services/ci/process_build_service_spec.rb' - - 'ee/spec/services/ci/retry_job_service_spec.rb' - - 'ee/spec/services/ci/runners/stale_group_runners_prune_service_spec.rb' - - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' - - 'ee/spec/services/ci/trigger_downstream_subscription_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - - 'ee/spec/services/deploy_keys/create_service_spec.rb' - - 'ee/spec/services/deployments/approval_service_spec.rb' - - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' - - 'ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb' - - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' + - 'ee/spec/services/audit_events/impersonation_audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/runner_custom_audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/runners_token_audit_event_service_spec.rb' + - 'ee/spec/services/boards/create_service_spec.rb' + - 'ee/spec/services/ci/audit_variable_change_service_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'ee/spec/services/ci/minutes/additional_packs/create_service_spec.rb' + - 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb' + - 'ee/spec/services/ee/git/wiki_push_service_spec.rb' + - 'ee/spec/services/ee/gpg_keys/create_service_spec.rb' - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' + - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' + - 'ee/spec/services/ee/issue_links/create_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' - - 'ee/spec/services/ee/members/update_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/create_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' - - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' - - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/services/ee/projects/unlink_fork_service_spec.rb' + - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' + - 'ee/spec/services/ee/protected_branches/destroy_service_spec.rb' + - 'ee/spec/services/ee/protected_branches/update_service_spec.rb' - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' - - 'ee/spec/services/ee/users/approve_service_spec.rb' - 'ee/spec/services/ee/users/block_service_spec.rb' - - 'ee/spec/services/ee/users/reject_service_spec.rb' - - 'ee/spec/services/ee/users/update_service_spec.rb' + - 'ee/spec/services/ee/users/create_service_spec.rb' + - 'ee/spec/services/ee/users/destroy_service_spec.rb' - 'ee/spec/services/elastic/indexing_control_service_spec.rb' - - 'ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb' - - 'ee/spec/services/emails/create_service_spec.rb' - - 'ee/spec/services/emails/destroy_service_spec.rb' + - 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' - - 'ee/spec/services/epic_issues/destroy_service_spec.rb' - - 'ee/spec/services/epics/close_service_spec.rb' - - 'ee/spec/services/epics/create_service_spec.rb' - - 'ee/spec/services/epics/reopen_service_spec.rb' - - 'ee/spec/services/epics/update_service_spec.rb' - - 'ee/spec/services/external_status_checks/create_service_spec.rb' - - 'ee/spec/services/external_status_checks/destroy_service_spec.rb' - - 'ee/spec/services/external_status_checks/update_service_spec.rb' - - 'ee/spec/services/geo/blob_download_service_spec.rb' - - 'ee/spec/services/geo/metrics_update_service_spec.rb' + - 'ee/spec/services/epics/issue_promote_service_spec.rb' + - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' + - 'ee/spec/services/epics/transfer_service_spec.rb' + - 'ee/spec/services/geo/container_repository_registry_removal_service_spec.rb' + - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' + - 'ee/spec/services/geo/node_create_service_spec.rb' + - 'ee/spec/services/geo/node_update_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - - 'ee/spec/services/geo/prune_event_log_service_spec.rb' - - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - - 'ee/spec/services/geo/repository_registry_removal_service_spec.rb' - 'ee/spec/services/geo/repository_sync_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' + - 'ee/spec/services/geo/repository_updated_service_spec.rb' + - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' + - 'ee/spec/services/geo/repository_verification_secondary_service_spec.rb' + - 'ee/spec/services/geo/wiki_sync_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/activate_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - 'ee/spec/services/group_saml/identity/destroy_service_spec.rb' - - 'ee/spec/services/group_saml/sign_up_service_spec.rb' - - 'ee/spec/services/groups/destroy_service_spec.rb' - - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - - 'ee/spec/services/groups/restore_service_spec.rb' - - 'ee/spec/services/groups/sync_service_spec.rb' - - 'ee/spec/services/incident_management/issuable_resource_links/create_service_spec.rb' + - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' + - 'ee/spec/services/incident_management/escalation_policies/create_service_spec.rb' + - 'ee/spec/services/incident_management/incidents/create_sla_service_spec.rb' + - 'ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_rotations/create_service_spec.rb' - 'ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb' - - 'ee/spec/services/incident_management/pending_escalations/create_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - - 'ee/spec/services/iterations/update_service_spec.rb' - - 'ee/spec/services/keys/create_service_spec.rb' - - 'ee/spec/services/lfs/lock_file_service_spec.rb' - - 'ee/spec/services/lfs/unlock_file_service_spec.rb' - - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' + - 'ee/spec/services/incident_management/pending_escalations/process_service_spec.rb' + - 'ee/spec/services/iterations/cadences/destroy_service_spec.rb' + - 'ee/spec/services/iterations/cadences/update_service_spec.rb' + - 'ee/spec/services/iterations/delete_service_spec.rb' + - 'ee/spec/services/iterations/roll_over_issues_service_spec.rb' + - 'ee/spec/services/projects/after_rename_service_spec.rb' + - 'ee/spec/services/projects/alerting/notify_service_spec.rb' + - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/destroy_service_spec.rb' - - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' - - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - - 'ee/spec/services/projects/import_service_spec.rb' - - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - - 'ee/spec/services/projects/restore_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - - 'ee/spec/services/projects/update_service_spec.rb' - - 'ee/spec/services/protected_environments/destroy_service_spec.rb' - - 'ee/spec/services/protected_environments/update_service_spec.rb' - - 'ee/spec/services/push_rules/create_or_update_service_spec.rb' - - 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb' - - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - - 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'ee/spec/services/resource_events/change_weight_service_spec.rb' - - 'ee/spec/services/security/ingestion/finding_map_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_report_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_finding_evidence_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_finding_identifiers_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_finding_links_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_finding_signatures_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_findings_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - - 'ee/spec/services/security/override_uuids_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' - - 'ee/spec/services/security/store_scan_service_spec.rb' - - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - - 'ee/spec/services/status_page/mark_for_publication_service_spec.rb' - - 'ee/spec/services/system_notes/epics_service_spec.rb' - - 'ee/spec/services/system_notes/merge_train_service_spec.rb' - - 'ee/spec/services/todo_service_spec.rb' - - 'ee/spec/services/todos/destroy/confidential_epic_service_spec.rb' - - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - - 'ee/spec/services/users_ops_dashboard_projects/destroy_service_spec.rb' - - 'ee/spec/services/vulnerabilities/confirm_service_spec.rb' - - 'ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb' - - 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb' - - 'ee/spec/services/vulnerabilities/historical_statistics/deletion_service_spec.rb' - - 'ee/spec/services/vulnerabilities/resolve_service_spec.rb' - - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' + - 'ee/spec/services/protected_environments/create_service_spec.rb' + - 'ee/spec/services/quality_management/test_cases/create_service_spec.rb' + - 'ee/spec/services/registrations/import_namespace_create_service_spec.rb' + - 'ee/spec/services/registrations/standard_namespace_create_service_spec.rb' + - 'ee/spec/services/requirements_management/export_csv_service_spec.rb' + - 'ee/spec/services/sbom/ingestion/tasks/ingest_component_versions_spec.rb' + - 'ee/spec/services/sbom/ingestion/tasks/ingest_components_spec.rb' + - 'ee/spec/services/sbom/ingestion/tasks/ingest_occurrences_spec.rb' + - 'ee/spec/services/sbom/ingestion/tasks/ingest_sources_spec.rb' + - 'ee/spec/services/security/orchestration/unassign_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/process_rule_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/rule_schedule_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/sync_scan_result_policies_service_spec.rb' + - 'ee/spec/services/security/store_findings_service_spec.rb' + - 'ee/spec/services/users/email_verification/send_custom_confirmation_instructions_service_spec.rb' + - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' + - 'ee/spec/services/vulnerabilities/find_or_create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/finding_dismiss_service_spec.rb' + - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_merge_request_service_spec.rb' - 'ee/spec/services/vulnerabilities/starboard_vulnerability_create_service_spec.rb' - - 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb' - - 'ee/spec/services/vulnerabilities/statistics/update_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/create_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/destroy_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' - - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' - - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/concerns/replicable_model_with_separate_table_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/concerns/repository_replicator_strategy_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/group_saml/saml_provider/base_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/vulnerabilities/removes_dismissal_feedback_from_associated_findings_shared_example.rb' - - 'ee/spec/tasks/geo/git_rake_spec.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - - 'ee/spec/workers/app_sec/dast/scanner_profiles_builds/consistency_worker_spec.rb' - - 'ee/spec/workers/app_sec/dast/scans/consistency_worker_spec.rb' - - 'ee/spec/workers/app_sec/dast/site_profiles_builds/consistency_worker_spec.rb' - - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' - - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' - - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' - - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' - - 'spec/controllers/admin/applications_controller_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' + - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' + - 'ee/spec/services/work_items/widgets/iteration_service/update_service_spec.rb' + - 'ee/spec/support/shared_examples/graphql/mutations/work_items/update_weight_widget_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/geo/geo_log_cursor_event_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/incident_management/pending_escalations_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/audit_event_logging_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/boards/create_boards_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/geo_event_store_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/issuable_links/create_links_with_link_type.rb' + - 'ee/spec/support/shared_examples/services/protected_environments_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/vulnerabilities/does_not_create_state_transition_for_same_state.rb' + - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' + - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' + - 'ee/spec/workers/geo/batch/project_registry_scheduler_worker_spec.rb' + - 'ee/spec/workers/geo/destroy_worker_spec.rb' + - 'ee/spec/workers/geo/file_registry_removal_worker_spec.rb' + - 'ee/spec/workers/groups/create_event_worker_spec.rb' + - 'ee/spec/workers/import_software_licenses_worker_spec.rb' + - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' + - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' + - 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - - 'spec/controllers/admin/runners_controller_spec.rb' - - 'spec/controllers/admin/spam_logs_controller_spec.rb' - - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - - 'spec/controllers/groups/runners_controller_spec.rb' - - 'spec/controllers/groups/settings/applications_controller_spec.rb' + - 'spec/controllers/groups/boards_controller_spec.rb' + - 'spec/controllers/groups/group_links_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' - 'spec/controllers/import/gitlab_controller_spec.rb' - - 'spec/controllers/jira_connect/events_controller_spec.rb' - - 'spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/profiles/gpg_keys_controller_spec.rb' - - 'spec/controllers/profiles/keys_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' + - 'spec/controllers/projects/boards_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' + - 'spec/controllers/projects/hooks_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - 'spec/controllers/projects/mirrors_controller_spec.rb' - - 'spec/controllers/projects/notes_controller_spec.rb' - 'spec/controllers/projects/pages_domains_controller_spec.rb' - - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' - - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/controllers/projects/raw_controller_spec.rb' - - 'spec/controllers/projects/runners_controller_spec.rb' - - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' + - 'spec/controllers/projects/protected_branches_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - - 'spec/controllers/sessions_controller_spec.rb' - - 'spec/controllers/snippets/notes_controller_spec.rb' - - 'spec/controllers/uploads_controller_spec.rb' - - 'spec/controllers/users/callouts_controller_spec.rb' - - 'spec/features/admin/users/users_spec.rb' - - 'spec/features/file_uploads/attachment_spec.rb' - - 'spec/features/file_uploads/ci_artifact_spec.rb' - - 'spec/features/file_uploads/git_lfs_spec.rb' - - 'spec/features/file_uploads/graphql_add_design_spec.rb' - - 'spec/features/file_uploads/group_import_spec.rb' - - 'spec/features/file_uploads/maven_package_spec.rb' - - 'spec/features/file_uploads/nuget_package_spec.rb' - - 'spec/features/file_uploads/project_import_spec.rb' - - 'spec/features/file_uploads/rubygem_package_spec.rb' - - 'spec/features/groups/import_export/import_file_spec.rb' - - 'spec/features/groups_spec.rb' - - 'spec/features/invites_spec.rb' - - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/environments/environments_spec.rb' - - 'spec/features/projects/import_export/import_file_spec.rb' - - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/projects_spec.rb' - - 'spec/features/users/signup_spec.rb' - - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' - - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' - - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' - - 'spec/graphql/mutations/ci/runner/bulk_delete_spec.rb' - - 'spec/graphql/mutations/ci/runner/delete_spec.rb' - - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' - - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' - - 'spec/graphql/mutations/container_repositories/destroy_spec.rb' - - 'spec/graphql/mutations/container_repositories/destroy_tags_spec.rb' - - 'spec/graphql/mutations/dependency_proxy/image_ttl_group_policy/update_spec.rb' - - 'spec/graphql/mutations/issues/set_severity_spec.rb' - - 'spec/graphql/mutations/releases/delete_spec.rb' - - 'spec/graphql/mutations/timelogs/delete_spec.rb' - - 'spec/helpers/markup_helper_spec.rb' - - 'spec/helpers/projects_helper_spec.rb' - - 'spec/initializers/active_record_locking_spec.rb' + - 'spec/controllers/registrations_controller_spec.rb' + - 'spec/features/admin/admin_hooks_spec.rb' + - 'spec/features/projects/settings/webhooks_settings_spec.rb' + - 'spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb' + - 'spec/graphql/mutations/custom_emoji/create_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event/create_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event_tag/create_spec.rb' + - 'spec/graphql/mutations/merge_requests/create_spec.rb' + - 'spec/graphql/mutations/user_callouts/create_spec.rb' + - 'spec/graphql/types/base_enum_spec.rb' + - 'spec/initializers/1_acts_as_taggable_spec.rb' + - 'spec/initializers/load_balancing_spec.rb' - 'spec/lib/api/helpers_spec.rb' - - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - - 'spec/lib/declarative_enum_spec.rb' - - 'spec/lib/gitaly/server_spec.rb' - - 'spec/lib/gitlab/auth/ldap/access_spec.rb' - - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' - - 'spec/lib/gitlab/auth/saml/identity_linker_spec.rb' - - 'spec/lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_projects_with_coverage_spec.rb' - - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - - 'spec/lib/gitlab/background_task_spec.rb' - - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' - - 'spec/lib/gitlab/ci/config/external/context_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/create_deployments_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/ensure_environments_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/ensure_resource_groups_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/processable/resource_group_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/report_spec.rb' - - 'spec/lib/gitlab/ci/status/factory_spec.rb' - - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' - - 'spec/lib/gitlab/composer/cache_spec.rb' - - 'spec/lib/gitlab/config/entry/validatable_spec.rb' - - 'spec/lib/gitlab/daemon_spec.rb' - - 'spec/lib/gitlab/database/async_indexes/index_creator_spec.rb' - - 'spec/lib/gitlab/database/async_indexes/index_destructor_spec.rb' + - 'spec/lib/backup/repositories_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/badges_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/entity_finisher_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/labels_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/members_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/milestones_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/project_entities_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' + - 'spec/lib/bulk_imports/pipeline/runner_spec.rb' + - 'spec/lib/gitlab/audit/auditor_spec.rb' + - 'spec/lib/gitlab/auth_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' + - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' + - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' + - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' + - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' + - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' + - 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb' + - 'spec/lib/gitlab/background_migration/sanitize_confidential_todos_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/assign_partition_spec.rb' + - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' + - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/observers/query_log_spec.rb' - - 'spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb' - - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_spec.rb' - - 'spec/lib/gitlab/database/reindexing/reindex_action_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/tag_spec.rb' - - 'spec/lib/gitlab/git_access_project_spec.rb' - - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb' - - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb' - - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' + - 'spec/lib/gitlab/database/tables_truncate_spec.rb' + - 'spec/lib/gitlab/diff/file_spec.rb' + - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' + - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/protected_branch_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb' - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' - - 'spec/lib/gitlab/import_export/base/object_builder_spec.rb' - - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' - - 'spec/lib/gitlab/jira_import/handle_labels_service_spec.rb' - - 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb' - - 'spec/lib/gitlab/manifest_import/project_creator_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/importer_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - - 'spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb' - - 'spec/lib/gitlab/middleware/request_context_spec.rb' - - 'spec/lib/gitlab/process_memory_cache/helper_spec.rb' - - 'spec/lib/gitlab/process_supervisor_spec.rb' - - 'spec/lib/gitlab/query_limiting_spec.rb' - - 'spec/lib/gitlab/reference_counter_spec.rb' - - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - - 'spec/lib/gitlab/slash_commands/issue_move_spec.rb' - - 'spec/lib/gitlab/word_diff/positions_counter_spec.rb' - - 'spec/migrations/20210805192450_update_trial_plans_ci_daily_pipeline_schedule_triggers_spec.rb' - - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb' - - 'spec/migrations/20211117084814_migrate_remaining_u2f_registrations_spec.rb' - - 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220124130028_dedup_runner_projects_spec.rb' - - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' - - 'spec/migrations/20220629184402_unset_escalation_policies_for_alert_incidents_spec.rb' - - 'spec/migrations/add_new_trail_plans_spec.rb' - - 'spec/migrations/add_open_source_plan_spec.rb' - - 'spec/migrations/backfill_cycle_analytics_aggregations_spec.rb' - - 'spec/migrations/bulk_insert_cluster_enabled_grants_spec.rb' - - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - - 'spec/migrations/cleanup_after_fixing_regression_with_new_users_emails_spec.rb' - - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' - - 'spec/migrations/populate_audit_event_streaming_verification_token_spec.rb' - - 'spec/migrations/remove_records_without_group_from_webhooks_table_spec.rb' - - 'spec/migrations/remove_wiki_notes_spec.rb' - - 'spec/models/alert_management/alert_spec.rb' - - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - - 'spec/models/analytics/cycle_analytics/stage_event_hash_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - - 'spec/models/chat_name_spec.rb' - - 'spec/models/ci/bridge_spec.rb' + - 'spec/lib/gitlab/import_export/after_export_strategies/web_upload_strategy_spec.rb' + - 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb' + - 'spec/lib/gitlab/import_export/importer_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' + - 'spec/lib/gitlab/pages/cache_control_spec.rb' + - 'spec/lib/gitlab/query_limiting/transaction_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' + - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' + - 'spec/migrations/20220321234317_remove_all_issuable_escalation_statuses_spec.rb' + - 'spec/migrations/20220506154054_create_sync_namespace_details_trigger_spec.rb' + - 'spec/migrations/20220512190659_remove_web_hooks_web_hook_logs_web_hook_id_fk_spec.rb' + - 'spec/migrations/20220524184149_create_sync_project_namespace_details_trigger_spec.rb' + - 'spec/migrations/20220802204737_remove_deactivated_user_highest_role_stats_spec.rb' + - 'spec/migrations/20220913030624_cleanup_attention_request_related_system_notes_spec.rb' + - 'spec/migrations/20221018050323_add_objective_and_keyresult_to_work_item_types_spec.rb' + - 'spec/migrations/20221018193635_ensure_task_note_renaming_background_migration_finished_spec.rb' + - 'spec/migrations/20221102090940_create_next_ci_partitions_record_spec.rb' + - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' + - 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb' + - 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb' + - 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb' + - 'spec/migrations/remove_duplicate_dast_site_tokens_spec.rb' + - 'spec/migrations/remove_duplicate_dast_site_tokens_with_same_token_spec.rb' + - 'spec/models/awareness_session_spec.rb' + - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/deleted_object_spec.rb' - - 'spec/models/ci/namespace_mirror_spec.rb' - - 'spec/models/ci/pipeline_artifact_spec.rb' - - 'spec/models/ci/pipeline_schedule_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/pipeline_variable_spec.rb' - 'spec/models/ci/processable_spec.rb' - - 'spec/models/ci/project_mirror_spec.rb' - - 'spec/models/ci/ref_spec.rb' - 'spec/models/ci/runner_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - - 'spec/models/clusters/cluster_spec.rb' + - 'spec/models/ci/stage_spec.rb' - 'spec/models/commit_status_spec.rb' - - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' - - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/delete_with_limit_spec.rb' - - 'spec/models/concerns/ignorable_columns_spec.rb' - - 'spec/models/concerns/issuable_spec.rb' - - 'spec/models/concerns/require_email_verification_spec.rb' - - 'spec/models/concerns/resolvable_discussion_spec.rb' - - 'spec/models/concerns/resolvable_note_spec.rb' - - 'spec/models/concerns/routable_spec.rb' - - 'spec/models/concerns/schedulable_spec.rb' + - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/container_repository_spec.rb' - - 'spec/models/customer_relations/issue_contact_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/error_tracking/project_error_tracking_setting_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/experiment_spec.rb' - - 'spec/models/group_spec.rb' + - 'spec/models/diff_note_spec.rb' + - 'spec/models/environment_spec.rb' + - 'spec/models/hooks/web_hook_log_spec.rb' - 'spec/models/hooks/web_hook_spec.rb' - - 'spec/models/incident_management/timeline_event_spec.rb' - - 'spec/models/integrations/prometheus_spec.rb' - - 'spec/models/internal_id_spec.rb' - - 'spec/models/issue_spec.rb' - - 'spec/models/jira_import_state_spec.rb' - - 'spec/models/lfs_objects_project_spec.rb' - - 'spec/models/member_spec.rb' + - 'spec/models/integration_spec.rb' + - 'spec/models/integrations/confluence_spec.rb' + - 'spec/models/integrations/drone_ci_spec.rb' + - 'spec/models/integrations/shimo_spec.rb' + - 'spec/models/label_spec.rb' + - 'spec/models/members/last_group_owner_assigner_spec.rb' + - 'spec/models/merge_request/cleanup_schedule_spec.rb' + - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' - - 'spec/models/packages/package_file_spec.rb' + - 'spec/models/namespace_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/oauth_access_grant_spec.rb' + - 'spec/models/onboarding/progress_spec.rb' - 'spec/models/packages/package_spec.rb' - - 'spec/models/pages_domain_spec.rb' - - 'spec/models/plan_spec.rb' - - 'spec/models/project_auto_devops_spec.rb' - - 'spec/models/project_import_state_spec.rb' - 'spec/models/project_spec.rb' - - 'spec/models/project_statistics_spec.rb' - - 'spec/models/projects/build_artifacts_size_refresh_spec.rb' - - 'spec/models/projects/ci_feature_usage_spec.rb' - 'spec/models/release_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/route_spec.rb' - - 'spec/models/sent_notification_spec.rb' - 'spec/models/snippet_spec.rb' - - 'spec/models/terraform/state_spec.rb' - - 'spec/models/upload_spec.rb' - - 'spec/models/user_interacted_project_spec.rb' + - 'spec/models/todo_spec.rb' - 'spec/models/user_spec.rb' - - 'spec/models/user_status_spec.rb' - - 'spec/models/x509_certificate_spec.rb' - - 'spec/models/x509_issuer_spec.rb' - - 'spec/requests/abuse_reports_controller_spec.rb' - - 'spec/requests/api/admin/ci/variables_spec.rb' - - 'spec/requests/api/applications_spec.rb' - - 'spec/requests/api/broadcast_messages_spec.rb' - - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - - 'spec/requests/api/ci/pipelines_spec.rb' - - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' + - 'spec/models/wiki_page_spec.rb' + - 'spec/models/work_items/type_spec.rb' + - 'spec/requests/api/ci/triggers_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - 'spec/requests/api/deploy_keys_spec.rb' - - 'spec/requests/api/deploy_tokens_spec.rb' - - 'spec/requests/api/error_tracking/collector_spec.rb' - - 'spec/requests/api/feature_flags_spec.rb' - - 'spec/requests/api/freeze_periods_spec.rb' - - 'spec/requests/api/generic_packages_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' - - 'spec/requests/api/graphql/mutations/boards/destroy_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agents/create_spec.rb' - - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' - - 'spec/requests/api/graphql/mutations/container_repository/destroy_spec.rb' - - 'spec/requests/api/graphql/mutations/container_repository/destroy_tags_spec.rb' - - 'spec/requests/api/graphql/mutations/labels/create_spec.rb' - - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb' - - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb' - - 'spec/requests/api/graphql/mutations/notes/destroy_spec.rb' - - 'spec/requests/api/graphql/mutations/packages/cleanup/policy/update_spec.rb' - - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/update_spec.rb' - - 'spec/requests/api/group_import_spec.rb' + - 'spec/requests/api/graphql/mutations/custom_emoji/create_spec.rb' + - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/create_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/update_spec.rb' + - 'spec/requests/api/graphql/mutations/timelogs/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/create_from_task_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/create_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/delete_task_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_task_spec.rb' - 'spec/requests/api/groups_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/maven_packages_spec.rb' + - 'spec/requests/api/issues/post_projects_issues_spec.rb' + - 'spec/requests/api/labels_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/notes_spec.rb' - - 'spec/requests/api/npm_project_packages_spec.rb' - - 'spec/requests/api/project_snippets_spec.rb' + - 'spec/requests/api/pages_domains_spec.rb' + - 'spec/requests/api/project_milestones_spec.rb' - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/pypi_packages_spec.rb' - - 'spec/requests/api/release/links_spec.rb' - - 'spec/requests/api/releases_spec.rb' - - 'spec/requests/api/rubygem_packages_spec.rb' - - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' - - 'spec/requests/api/terraform/state_spec.rb' - - 'spec/requests/api/terraform/state_version_spec.rb' - - 'spec/requests/api/users_spec.rb' - - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - - 'spec/requests/import/gitlab_groups_controller_spec.rb' - - 'spec/requests/oauth_tokens_spec.rb' - - 'spec/requests/product_analytics/collector_app_spec.rb' - - 'spec/requests/projects/issue_links_controller_spec.rb' - - 'spec/requests/projects/merge_requests_discussions_spec.rb' - - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' - - 'spec/requests/users/group_callouts_spec.rb' - - 'spec/requests/users/namespace_callouts_spec.rb' - - 'spec/requests/users/project_callouts_spec.rb' - - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' + - 'spec/serializers/member_serializer_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' + - 'spec/services/alert_management/create_alert_issue_service_spec.rb' + - 'spec/services/alert_management/metric_images/upload_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/applications/create_service_spec.rb' - - 'spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb' - - 'spec/services/authorized_project_update/project_recalculate_service_spec.rb' - - 'spec/services/award_emojis/add_service_spec.rb' - - 'spec/services/award_emojis/copy_service_spec.rb' - - 'spec/services/award_emojis/destroy_service_spec.rb' - - 'spec/services/award_emojis/toggle_service_spec.rb' - - 'spec/services/bulk_imports/create_service_spec.rb' - - 'spec/services/bulk_imports/relation_export_service_spec.rb' - - 'spec/services/ci/build_report_result_service_spec.rb' + - 'spec/services/audit_event_service_spec.rb' + - 'spec/services/boards/issues/create_service_spec.rb' + - 'spec/services/ci/change_variable_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/ci/daily_build_group_report_result_service_spec.rb' - - 'spec/services/ci/delete_objects_service_spec.rb' - - 'spec/services/ci/destroy_pipeline_service_spec.rb' - - 'spec/services/ci/ensure_stage_service_spec.rb' - - 'spec/services/ci/job_artifacts/create_service_spec.rb' - - 'spec/services/ci/job_artifacts/delete_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_associations_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' - - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - - 'spec/services/ci/job_token_scope/add_project_service_spec.rb' - - 'spec/services/ci/job_token_scope/remove_project_service_spec.rb' - - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb' - - 'spec/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service_spec.rb' - - 'spec/services/ci/pipeline_artifacts/destroy_all_expired_service_spec.rb' - - 'spec/services/ci/pipeline_trigger_service_spec.rb' - - 'spec/services/ci/play_build_service_spec.rb' - - 'spec/services/ci/process_build_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/ci/retry_pipeline_service_spec.rb' - - 'spec/services/ci/run_scheduled_build_service_spec.rb' - - 'spec/services/ci/runners/bulk_delete_runners_service_spec.rb' - - 'spec/services/ci/runners/unregister_runner_service_spec.rb' - - 'spec/services/ci/update_build_queue_service_spec.rb' - - 'spec/services/ci/update_build_state_service_spec.rb' - - 'spec/services/ci/update_instance_variables_service_spec.rb' + - 'spec/services/ci/pipelines/add_job_service_spec.rb' + - 'spec/services/ci/process_sync_events_service_spec.rb' + - 'spec/services/ci/runners/process_runner_version_update_service_spec.rb' - 'spec/services/clusters/agent_tokens/create_service_spec.rb' - - 'spec/services/clusters/agents/create_service_spec.rb' - - 'spec/services/clusters/agents/delete_service_spec.rb' - - 'spec/services/clusters/create_service_spec.rb' - - 'spec/services/clusters/destroy_service_spec.rb' - - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - - 'spec/services/deployments/create_for_build_service_spec.rb' - - 'spec/services/deployments/update_environment_service_spec.rb' - - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' - - 'spec/services/design_management/delete_designs_service_spec.rb' - - 'spec/services/design_management/design_user_notes_count_service_spec.rb' + - 'spec/services/clusters/agents/create_activity_event_service_spec.rb' + - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' + - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' + - 'spec/services/design_management/copy_design_collection/queue_service_spec.rb' - 'spec/services/design_management/save_designs_service_spec.rb' - - 'spec/services/draft_notes/destroy_service_spec.rb' - - 'spec/services/draft_notes/publish_service_spec.rb' - - 'spec/services/emails/create_service_spec.rb' - - 'spec/services/environments/create_for_build_service_spec.rb' - - 'spec/services/error_tracking/collect_error_service_spec.rb' - - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/event_create_service_spec.rb' - - 'spec/services/feature_flags/create_service_spec.rb' - - 'spec/services/feature_flags/destroy_service_spec.rb' - - 'spec/services/feature_flags/update_service_spec.rb' + - 'spec/services/events/destroy_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/git/process_ref_changes_service_spec.rb' - - 'spec/services/git/tag_hooks_service_spec.rb' + - 'spec/services/git/wiki_push_service_spec.rb' + - 'spec/services/gpg_keys/destroy_service_spec.rb' - 'spec/services/groups/create_service_spec.rb' - - 'spec/services/groups/import_export/import_service_spec.rb' - - 'spec/services/groups/transfer_service_spec.rb' - - 'spec/services/groups/update_service_spec.rb' - - 'spec/services/groups/update_statistics_service_spec.rb' + - 'spec/services/import/gitlab_projects/create_project_service_spec.rb' + - 'spec/services/incident_management/incidents/create_service_spec.rb' + - 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' + - 'spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb' - 'spec/services/incident_management/timeline_events/create_service_spec.rb' - - 'spec/services/incident_management/timeline_events/update_service_spec.rb' + - 'spec/services/issuable/bulk_update_service_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - - 'spec/services/issues/close_service_spec.rb' - 'spec/services/issues/create_service_spec.rb' - - 'spec/services/issues/import_csv_service_spec.rb' + - 'spec/services/issues/export_csv_service_spec.rb' - 'spec/services/issues/move_service_spec.rb' - - 'spec/services/issues/reopen_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' - - 'spec/services/jira_import/start_import_service_spec.rb' + - 'spec/services/jira_connect_installations/destroy_service_spec.rb' + - 'spec/services/keys/destroy_service_spec.rb' + - 'spec/services/labels/find_or_create_service_spec.rb' - 'spec/services/labels/promote_service_spec.rb' - - 'spec/services/lfs/lock_file_service_spec.rb' - - 'spec/services/merge_requests/add_spent_time_service_spec.rb' - - 'spec/services/merge_requests/close_service_spec.rb' - - 'spec/services/merge_requests/create_pipeline_service_spec.rb' - - 'spec/services/merge_requests/create_service_spec.rb' - - 'spec/services/merge_requests/ff_merge_service_spec.rb' - - 'spec/services/merge_requests/merge_service_spec.rb' + - 'spec/services/labels/transfer_service_spec.rb' + - 'spec/services/members/invite_service_spec.rb' + - 'spec/services/merge_requests/base_service_spec.rb' + - 'spec/services/merge_requests/create_from_issue_service_spec.rb' - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'spec/services/merge_requests/post_merge_service_spec.rb' - - 'spec/services/merge_requests/push_options_handler_service_spec.rb' - - 'spec/services/merge_requests/reopen_service_spec.rb' - - 'spec/services/merge_requests/squash_service_spec.rb' + - 'spec/services/merge_requests/mergeability_check_service_spec.rb' + - 'spec/services/merge_requests/rebase_service_spec.rb' + - 'spec/services/merge_requests/update_assignees_service_spec.rb' + - 'spec/services/merge_requests/update_reviewers_service_spec.rb' - 'spec/services/merge_requests/update_service_spec.rb' - - 'spec/services/milestones/destroy_service_spec.rb' - - 'spec/services/namespace_settings/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' - - 'spec/services/notes/destroy_service_spec.rb' - - 'spec/services/notes/quick_actions_service_spec.rb' - - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - - 'spec/services/packages/composer/create_package_service_spec.rb' - - 'spec/services/packages/create_dependency_service_spec.rb' - - 'spec/services/packages/create_event_service_spec.rb' - - 'spec/services/packages/create_temporary_package_service_spec.rb' - - 'spec/services/packages/debian/find_or_create_package_service_spec.rb' + - 'spec/services/milestones/find_or_create_service_spec.rb' + - 'spec/services/milestones/transfer_service_spec.rb' + - 'spec/services/namespaces/statistics_refresher_service_spec.rb' - 'spec/services/packages/debian/process_changes_service_spec.rb' - - 'spec/services/packages/generic/create_package_file_service_spec.rb' - - 'spec/services/packages/go/create_package_service_spec.rb' - - 'spec/services/packages/helm/process_file_service_spec.rb' - - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' - - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/packages/npm/create_tag_service_spec.rb' - - 'spec/services/packages/nuget/create_dependency_service_spec.rb' - - 'spec/services/packages/nuget/sync_metadatum_service_spec.rb' - - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - - 'spec/services/packages/pypi/create_package_service_spec.rb' - - 'spec/services/packages/remove_tag_service_spec.rb' - - 'spec/services/packages/rubygems/create_dependencies_service_spec.rb' - - 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb' - - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/packages/update_package_file_service_spec.rb' - - 'spec/services/packages/update_tags_service_spec.rb' - - 'spec/services/pages/delete_service_spec.rb' - - 'spec/services/pages/destroy_deployments_service_spec.rb' - - 'spec/services/pages_domains/retry_acme_order_service_spec.rb' - - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - - 'spec/services/projects/auto_devops/disable_service_spec.rb' + - 'spec/services/packages/debian/process_package_file_service_spec.rb' + - 'spec/services/pages_domains/create_service_spec.rb' + - 'spec/services/post_receive_service_spec.rb' + - 'spec/services/projects/cleanup_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' - - 'spec/services/projects/fetch_statistics_increment_service_spec.rb' - - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' - - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - - 'spec/services/projects/record_target_platforms_service_spec.rb' + - 'spec/services/projects/detect_repository_languages_service_spec.rb' + - 'spec/services/projects/operations/update_service_spec.rb' + - 'spec/services/projects/repository_languages_service_spec.rb' - 'spec/services/projects/transfer_service_spec.rb' - 'spec/services/projects/update_pages_service_spec.rb' + - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - - 'spec/services/quick_actions/interpret_service_spec.rb' + - 'spec/services/protected_branches/create_service_spec.rb' + - 'spec/services/protected_tags/create_service_spec.rb' - 'spec/services/releases/create_service_spec.rb' - - 'spec/services/releases/destroy_service_spec.rb' - - 'spec/services/resource_access_tokens/create_service_spec.rb' - - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/service_ping/submit_service_ping_service_spec.rb' + - 'spec/services/snippets/bulk_destroy_service_spec.rb' - 'spec/services/snippets/create_service_spec.rb' - - 'spec/services/snippets/destroy_service_spec.rb' - - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/spam/ham_service_spec.rb' - - 'spec/services/system_notes/issuables_service_spec.rb' - - 'spec/services/timelogs/delete_service_spec.rb' + - 'spec/services/snippets/update_repository_storage_service_spec.rb' + - 'spec/services/snippets/update_statistics_service_spec.rb' + - 'spec/services/spam/spam_action_service_spec.rb' + - 'spec/services/suggestions/create_service_spec.rb' + - 'spec/services/tasks_to_be_done/base_service_spec.rb' + - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' - 'spec/services/todo_service_spec.rb' - - 'spec/services/todos/destroy/confidential_issue_service_spec.rb' - - 'spec/services/todos/destroy/design_service_spec.rb' - - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - - 'spec/services/todos/destroy/group_private_service_spec.rb' - - 'spec/services/todos/destroy/project_private_service_spec.rb' - - 'spec/services/todos/destroy/unauthorized_features_service_spec.rb' - - 'spec/services/uploads/destroy_service_spec.rb' + - 'spec/services/todos/destroy/destroyed_issuable_service_spec.rb' + - 'spec/services/users/activity_service_spec.rb' - 'spec/services/users/approve_service_spec.rb' - - 'spec/services/users/ban_service_spec.rb' - - 'spec/services/users/batch_status_cleaner_service_spec.rb' - - 'spec/services/users/block_service_spec.rb' - - 'spec/services/users/set_status_service_spec.rb' - - 'spec/services/users/unban_service_spec.rb' - - 'spec/services/users/update_highest_member_role_service_spec.rb' - - 'spec/services/users/update_service_spec.rb' - - 'spec/services/verify_pages_domain_service_spec.rb' + - 'spec/services/users/reject_service_spec.rb' + - 'spec/services/users/saved_replies/create_service_spec.rb' + - 'spec/services/users/saved_replies/destroy_service_spec.rb' + - 'spec/services/users/saved_replies/update_service_spec.rb' + - 'spec/services/users/update_todo_count_cache_service_spec.rb' + - 'spec/services/web_hook_service_spec.rb' + - 'spec/services/web_hooks/destroy_service_spec.rb' + - 'spec/services/web_hooks/log_destroy_service_spec.rb' + - 'spec/services/web_hooks/log_execution_service_spec.rb' + - 'spec/services/wiki_pages/event_create_service_spec.rb' + - 'spec/services/work_items/create_and_link_service_spec.rb' + - 'spec/services/work_items/create_from_task_service_spec.rb' + - 'spec/services/work_items/create_service_spec.rb' + - 'spec/services/work_items/delete_task_service_spec.rb' - 'spec/services/work_items/parent_links/create_service_spec.rb' - - 'spec/support/services/clusters/create_service_shared.rb' - - 'spec/support/services/deploy_token_shared_examples.rb' - - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - - 'spec/support/shared_contexts/email_shared_context.rb' - - 'spec/support/shared_examples/controllers/clusters_controller_shared_examples.rb' - - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - - 'spec/support/shared_examples/controllers/variables_shared_examples.rb' - - 'spec/support/shared_examples/graphql/mutations/boards_create_shared_examples.rb' - - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - - 'spec/support/shared_examples/incident_management/issuable_escalation_statuses/build_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' - - 'spec/support/shared_examples/models/commit_signature_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/cron_schedulable_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/repository_storage_movable_shared_examples.rb' - - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' - - 'spec/support/shared_examples/models/member_shared_examples.rb' - - 'spec/support/shared_examples/models/packages/debian/component_file_shared_example.rb' - - 'spec/support/shared_examples/models/with_uploads_shared_examples.rb' - - 'spec/support/shared_examples/requests/access_tokens_controller_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/mutations/destroy_list_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/read_only_instance_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/npm_packages_tags_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/terraform/modules/v1/packages_shared_examples.rb' - - 'spec/support/shared_examples/services/common_system_notes_shared_examples.rb' - - 'spec/support/shared_examples/services/container_expiration_policy_shared_examples.rb' - - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' - - 'spec/support/shared_examples/services/dependency_proxy_ttl_policies_shared_examples.rb' - - 'spec/support/shared_examples/services/issuable_links/create_links_shared_examples.rb' - - 'spec/support/shared_examples/services/merge_request_shared_examples.rb' - - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' - - 'spec/support/shared_examples/services/packages_shared_examples.rb' - - 'spec/support/shared_examples/services/rate_limited_service_shared_examples.rb' - - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - - 'spec/support/shared_examples/services/updating_mentions_shared_examples.rb' - - 'spec/support/shared_examples/services/wiki_pages/create_service_shared_examples.rb' - - 'spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb' - - 'spec/support/shared_examples/services/wiki_pages/update_service_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/upload_type_shared_examples.rb' - - 'spec/tasks/cache/clear/redis_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - - 'spec/uploaders/file_uploader_spec.rb' - - 'spec/uploaders/records_uploads_spec.rb' - - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' - - 'spec/workers/gitlab_service_ping_worker_spec.rb' - - 'spec/workers/group_import_worker_spec.rb' - - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - - 'spec/workers/namespaces/root_statistics_worker_spec.rb' - - 'spec/workers/namespaces/schedule_aggregation_worker_spec.rb' - - 'spec/workers/new_issue_worker_spec.rb' - - 'spec/workers/new_merge_request_worker_spec.rb' - - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' - - 'spec/workers/packages/composer/cache_cleanup_worker_spec.rb' - - 'spec/workers/packages/composer/cache_update_worker_spec.rb' - - 'spec/workers/packages/debian/process_changes_worker_spec.rb' - - 'spec/workers/packages/go/sync_packages_worker_spec.rb' - - 'spec/workers/packages/helm/extraction_worker_spec.rb' - - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb' - - 'spec/workers/packages/nuget/extraction_worker_spec.rb' - - 'spec/workers/packages/rubygems/extraction_worker_spec.rb' - - 'spec/workers/pages_domain_removal_cron_worker_spec.rb' - - 'spec/workers/projects/post_creation_worker_spec.rb' - - 'spec/workers/prune_old_events_worker_spec.rb' - - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - - 'spec/workers/remove_expired_group_links_worker_spec.rb' - - 'spec/workers/remove_expired_members_worker_spec.rb' - - 'spec/workers/remove_unaccepted_member_invites_worker_spec.rb' - - 'spec/workers/update_highest_role_worker_spec.rb' - - 'spec/workers/user_status_cleanup/batch_worker_spec.rb' - - 'spec/workers/users/create_statistics_worker_spec.rb' - - 'spec/workers/web_hooks/log_destroy_worker_spec.rb' + - 'spec/services/work_items/parent_links/destroy_service_spec.rb' + - 'spec/services/work_items/task_list_reference_removal_service_spec.rb' + - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' + - 'spec/services/work_items/update_service_spec.rb' + - 'spec/services/work_items/widgets/hierarchy_service/update_service_spec.rb' + - 'spec/services/work_items/widgets/milestone_service/update_service_spec.rb' + - 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb' + - 'spec/services/x509_certificate_revoke_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 70b4105fc89..aa0f5f005d7 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -4,7 +4,6 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/settings/slacks_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' @@ -14,11 +13,8 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' @@ -60,7 +56,6 @@ RSpec/ExpectInHook: - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/presenters/group_member_presenter_spec.rb' @@ -72,7 +67,6 @@ RSpec/ExpectInHook: - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - - 'ee/spec/services/ci/runners/assign_runner_service_spec.rb' - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' - 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb' - 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb' @@ -89,14 +83,12 @@ RSpec/ExpectInHook: - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - 'ee/spec/services/members/await_service_spec.rb' - - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb' - 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb' - 'ee/spec/services/merge_requests/mergeability/check_denied_policies_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' @@ -112,16 +104,11 @@ RSpec/ExpectInHook: - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/jira/jira_basic_integration_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/dependency_proxy/dependency_proxy_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' @@ -340,7 +327,6 @@ RSpec/ExpectInHook: - 'spec/models/member_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' - - 'spec/models/personal_access_token_spec.rb' - 'spec/models/postgresql/replication_slot_spec.rb' - 'spec/models/project_import_state_spec.rb' - 'spec/models/project_spec.rb' @@ -381,7 +367,6 @@ RSpec/ExpectInHook: - 'spec/requests/api/project_debian_distributions_spec.rb' - 'spec/requests/api/project_packages_spec.rb' - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/protected_branches_spec.rb' - 'spec/requests/api/v3/github_spec.rb' - 'spec/requests/health_controller_spec.rb' - 'spec/requests/import/gitlab_groups_controller_spec.rb' @@ -396,25 +381,17 @@ RSpec/ExpectInHook: - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'spec/services/award_emojis/add_service_spec.rb' - 'spec/services/captcha/captcha_verification_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/delete_objects_service_spec.rb' - 'spec/services/ci/generate_kubeconfig_service_spec.rb' - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' - - 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - 'spec/services/clusters/applications/install_service_spec.rb' - - 'spec/services/clusters/applications/patch_service_spec.rb' - - 'spec/services/clusters/applications/prometheus_update_service_spec.rb' - - 'spec/services/clusters/applications/uninstall_service_spec.rb' - 'spec/services/clusters/applications/upgrade_service_spec.rb' - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb' - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - - 'spec/services/database/consistency_check_service_spec.rb' - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - 'spec/services/dependency_proxy/image_ttl_group_policies/update_service_spec.rb' - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' @@ -464,7 +441,6 @@ RSpec/ExpectInHook: - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' - 'spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb' @@ -480,9 +456,6 @@ RSpec/ExpectInHook: - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - - 'spec/services/protected_branches/create_service_spec.rb' - - 'spec/services/protected_branches/destroy_service_spec.rb' - - 'spec/services/protected_branches/update_service_spec.rb' - 'spec/services/search_service_spec.rb' - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' @@ -491,8 +464,6 @@ RSpec/ExpectInHook: - 'spec/services/system_notes/commit_service_spec.rb' - 'spec/services/system_notes/issuables_service_spec.rb' - 'spec/services/user_project_access_changed_service_spec.rb' - - 'spec/support/services/issuable_update_service_shared_examples.rb' - - 'spec/support/services/migrate_to_ghost_user_service_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/csp.rb' - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' @@ -506,7 +477,6 @@ RSpec/ExpectInHook: - 'spec/support/shared_examples/models/concerns/has_wiki_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/update_namespace_statistics_shared_examples.rb' - 'spec/support/shared_examples/models/mentionable_shared_examples.rb' - - 'spec/support/shared_examples/models/wiki_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/issuable/close_quick_action_shared_examples.rb' - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/repositories_shared_context.rb' @@ -525,14 +495,11 @@ RSpec/ExpectInHook: - 'spec/tasks/gitlab/praefect_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/danger/specs_spec.rb' - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/uploaders/gitlab_uploader_spec.rb' - 'spec/uploaders/object_storage_spec.rb' - - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - - 'spec/workers/build_finished_worker_spec.rb' - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/build_finished_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index b41233d83af..3201d5a8370 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -1,6 +1,107 @@ --- RSpec/FactoryBot/AvoidCreate: Exclude: + - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/limit_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/project_pre_enforcement_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/user_pre_enforcement_alert_component_spec.rb' + - 'ee/spec/helpers/admin/ip_restriction_helper_spec.rb' + - 'ee/spec/helpers/application_helper_spec.rb' + - 'ee/spec/helpers/billing_plans_helper_spec.rb' + - 'ee/spec/helpers/boards_helper_spec.rb' + - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' + - 'ee/spec/helpers/ee/admin/identities_helper_spec.rb' + - 'ee/spec/helpers/ee/blob_helper_spec.rb' + - 'ee/spec/helpers/ee/branches_helper_spec.rb' + - 'ee/spec/helpers/ee/ci/pipeline_editor_helper_spec.rb' + - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' + - 'ee/spec/helpers/ee/dashboard_helper_spec.rb' + - 'ee/spec/helpers/ee/environments_helper_spec.rb' + - 'ee/spec/helpers/ee/events_helper_spec.rb' + - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' + - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' + - 'ee/spec/helpers/ee/graph_helper_spec.rb' + - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' + - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/hooks_helper_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' + - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' + - 'ee/spec/helpers/ee/issuables_helper_spec.rb' + - 'ee/spec/helpers/ee/issues_helper_spec.rb' + - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/ee/learn_gitlab_helper_spec.rb' + - 'ee/spec/helpers/ee/lock_helper_spec.rb' + - 'ee/spec/helpers/ee/namespace_user_cap_reached_alert_helper_spec.rb' + - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' + - 'ee/spec/helpers/ee/operations_helper_spec.rb' + - 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb' + - 'ee/spec/helpers/ee/releases_helper_spec.rb' + - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' + - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' + - 'ee/spec/helpers/ee/todos_helper_spec.rb' + - 'ee/spec/helpers/ee/trial_helper_spec.rb' + - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' + - 'ee/spec/helpers/ee/welcome_helper_spec.rb' + - 'ee/spec/helpers/ee/wiki_helper_spec.rb' + - 'ee/spec/helpers/epics_helper_spec.rb' + - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' + - 'ee/spec/helpers/groups/feature_discovery_moments_helper_spec.rb' + - 'ee/spec/helpers/groups/security_features_helper_spec.rb' + - 'ee/spec/helpers/incident_management/escalation_policy_helper_spec.rb' + - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' + - 'ee/spec/helpers/license_helper_spec.rb' + - 'ee/spec/helpers/license_monitoring_helper_spec.rb' + - 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb' + - 'ee/spec/helpers/markup_helper_spec.rb' + - 'ee/spec/helpers/notes_helper_spec.rb' + - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' + - 'ee/spec/helpers/path_locks_helper_spec.rb' + - 'ee/spec/helpers/prevent_forking_helper_spec.rb' + - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' + - 'ee/spec/helpers/projects/project_members_helper_spec.rb' + - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' + - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' + - 'ee/spec/helpers/projects_helper_spec.rb' + - 'ee/spec/helpers/push_rules_helper_spec.rb' + - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' + - 'ee/spec/helpers/search_helper_spec.rb' + - 'ee/spec/helpers/seat_count_alert_helper_spec.rb' + - 'ee/spec/helpers/security_helper_spec.rb' + - 'ee/spec/helpers/subscriptions_helper_spec.rb' + - 'ee/spec/helpers/timeboxes_helper_spec.rb' + - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' + - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' + - 'ee/spec/helpers/users_helper_spec.rb' + - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' + - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' + - 'ee/spec/mailers/devise_mailer_spec.rb' + - 'ee/spec/mailers/ee/emails/admin_notification_spec.rb' + - 'ee/spec/mailers/ee/emails/issues_spec.rb' + - 'ee/spec/mailers/ee/emails/merge_requests_spec.rb' + - 'ee/spec/mailers/ee/emails/profile_spec.rb' + - 'ee/spec/mailers/ee/emails/projects_spec.rb' + - 'ee/spec/mailers/emails/free_user_cap_spec.rb' + - 'ee/spec/mailers/emails/group_memberships_spec.rb' + - 'ee/spec/mailers/emails/in_product_marketing_spec.rb' + - 'ee/spec/mailers/emails/merge_commits_spec.rb' + - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' + - 'ee/spec/mailers/emails/requirements_spec.rb' + - 'ee/spec/mailers/emails/user_cap_spec.rb' + - 'ee/spec/mailers/license_mailer_spec.rb' + - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/presenters/approval_rule_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' @@ -10,12 +111,10 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/presenters/ee/blob_presenter_spec.rb' - 'ee/spec/presenters/ee/clusters/cluster_presenter_spec.rb' - 'ee/spec/presenters/ee/instance_clusterable_presenter_spec.rb' - - 'ee/spec/presenters/ee/issue_presenter_spec.rb' - 'ee/spec/presenters/ee/projects/security/configuration_presenter_spec.rb' - 'ee/spec/presenters/epic_issue_presenter_spec.rb' - 'ee/spec/presenters/epic_presenter_spec.rb' - 'ee/spec/presenters/group_clusterable_presenter_spec.rb' - - 'ee/spec/presenters/label_presenter_spec.rb' - 'ee/spec/presenters/merge_request_approver_presenter_spec.rb' - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/presenters/project_clusterable_presenter_spec.rb' @@ -92,6 +191,178 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb' - 'ee/spec/serializers/vulnerability_entity_spec.rb' - 'ee/spec/serializers/vulnerability_note_entity_spec.rb' + - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' + - 'ee/spec/views/admin/application_settings/_git_abuse_rate_limit.html.haml_spec.rb' + - 'ee/spec/views/admin/application_settings/general.html.haml_spec.rb' + - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' + - 'ee/spec/views/admin/groups/_form.html.haml_spec.rb' + - 'ee/spec/views/admin/identities/index.html.haml_spec.rb' + - 'ee/spec/views/admin/users/_credit_card_info.html.haml_spec.rb' + - 'ee/spec/views/admin/users/index.html.haml_spec.rb' + - 'ee/spec/views/admin/users/show.html.haml_spec.rb' + - 'ee/spec/views/clusters/clusters/show.html.haml_spec.rb' + - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' + - 'ee/spec/views/groups/billings/index.html.haml_spec.rb' + - 'ee/spec/views/groups/edit.html.haml_spec.rb' + - 'ee/spec/views/groups/feature_discovery_moments/advanced_features_dashboard.html.haml_spec.rb' + - 'ee/spec/views/groups/group_members/index.html.haml_spec.rb' + - 'ee/spec/views/groups/hook_logs/show.html.haml_spec.rb' + - 'ee/spec/views/groups/hooks/edit.html.haml_spec.rb' + - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' + - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' + - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' + - 'ee/spec/views/layouts/_search.html.haml_spec.rb' + - 'ee/spec/views/layouts/application.html.haml_spec.rb' + - 'ee/spec/views/layouts/group.html.haml_spec.rb' + - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' + - 'ee/spec/views/layouts/header/_new_dropdown.haml_spec.rb' + - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' + - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' + - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' + - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' + - 'ee/spec/views/layouts/project.html.haml_spec.rb' + - 'ee/spec/views/projects/edit.html.haml_spec.rb' + - 'ee/spec/views/projects/issues/show.html.haml_spec.rb' + - 'ee/spec/views/projects/on_demand_scans/index.html.haml_spec.rb' + - 'ee/spec/views/projects/pipelines/_tabs_content.html.haml_spec.rb' + - 'ee/spec/views/projects/project_members/index.html.haml_spec.rb' + - 'ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_scanner_profiles/edit.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_scanner_profiles/new.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_site_profiles/edit.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_site_profiles/new.html.haml_spec.rb' + - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' + - 'ee/spec/views/projects/security/policies/index.html.haml_spec.rb' + - 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb' + - 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb' + - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' + - 'ee/spec/views/registrations/welcome/continuous_onboarding_getting_started.html.haml_spec.rb' + - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' + - 'ee/spec/views/search/_category.html.haml_spec.rb' + - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' + - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' + - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' + - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' + - 'ee/spec/views/shared/_namespace_user_cap_reached_alert.html.haml_spec.rb' + - 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb' + - 'ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb' + - 'ee/spec/views/shared/credentials_inventory/_expiry_date.html.haml_spec.rb' + - 'ee/spec/views/shared/credentials_inventory/gpg_keys/_gpg_key.html.haml_spec.rb' + - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' + - 'ee/spec/views/shared/credentials_inventory/resource_access_tokens/_resource_access_token.html.haml_spec.rb' + - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' + - 'ee/spec/views/shared/issuable/_approver_suggestion.html.haml_spec.rb' + - 'ee/spec/views/shared/issuable/_sidebar.html.haml_spec.rb' + - 'ee/spec/views/shared/labels/_create_label_help_text.html.haml_spec.rb' + - 'ee/spec/views/shared/milestones/_milestone.html.haml_spec.rb' + - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' + - 'spec/components/diffs/overflow_warning_component_spec.rb' + - 'spec/components/diffs/stats_component_spec.rb' + - 'spec/components/pajamas/avatar_component_spec.rb' + - 'spec/helpers/admin/identities_helper_spec.rb' + - 'spec/helpers/admin/user_actions_helper_spec.rb' + - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' + - 'spec/helpers/appearances_helper_spec.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/helpers/application_settings_helper_spec.rb' + - 'spec/helpers/auth_helper_spec.rb' + - 'spec/helpers/auto_devops_helper_spec.rb' + - 'spec/helpers/avatars_helper_spec.rb' + - 'spec/helpers/award_emoji_helper_spec.rb' + - 'spec/helpers/blob_helper_spec.rb' + - 'spec/helpers/boards_helper_spec.rb' + - 'spec/helpers/branches_helper_spec.rb' + - 'spec/helpers/broadcast_messages_helper_spec.rb' + - 'spec/helpers/button_helper_spec.rb' + - 'spec/helpers/calendar_helper_spec.rb' + - 'spec/helpers/ci/builds_helper_spec.rb' + - 'spec/helpers/ci/jobs_helper_spec.rb' + - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' + - 'spec/helpers/ci/pipelines_helper_spec.rb' + - 'spec/helpers/ci/runners_helper_spec.rb' + - 'spec/helpers/ci/secure_files_helper_spec.rb' + - 'spec/helpers/clusters_helper_spec.rb' + - 'spec/helpers/commits_helper_spec.rb' + - 'spec/helpers/diff_helper_spec.rb' + - 'spec/helpers/emails_helper_spec.rb' + - 'spec/helpers/environment_helper_spec.rb' + - 'spec/helpers/environments_helper_spec.rb' + - 'spec/helpers/events_helper_spec.rb' + - 'spec/helpers/feature_flags_helper_spec.rb' + - 'spec/helpers/gitlab_routing_helper_spec.rb' + - 'spec/helpers/graph_helper_spec.rb' + - 'spec/helpers/groups/group_members_helper_spec.rb' + - 'spec/helpers/groups/settings_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' + - 'spec/helpers/ide_helper_spec.rb' + - 'spec/helpers/import_helper_spec.rb' + - 'spec/helpers/integrations_helper_spec.rb' + - 'spec/helpers/invite_members_helper_spec.rb' + - 'spec/helpers/issuables_description_templates_helper_spec.rb' + - 'spec/helpers/issuables_helper_spec.rb' + - 'spec/helpers/issues_helper_spec.rb' + - 'spec/helpers/jira_connect_helper_spec.rb' + - 'spec/helpers/keyset_helper_spec.rb' + - 'spec/helpers/labels_helper_spec.rb' + - 'spec/helpers/lazy_image_tag_helper_spec.rb' + - 'spec/helpers/learn_gitlab_helper_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/helpers/members_helper_spec.rb' + - 'spec/helpers/merge_requests_helper_spec.rb' + - 'spec/helpers/namespaces_helper_spec.rb' + - 'spec/helpers/nav/top_nav_helper_spec.rb' + - 'spec/helpers/nav_helper_spec.rb' + - 'spec/helpers/notes_helper_spec.rb' + - 'spec/helpers/notifications_helper_spec.rb' + - 'spec/helpers/notify_helper_spec.rb' + - 'spec/helpers/operations_helper_spec.rb' + - 'spec/helpers/packages_helper_spec.rb' + - 'spec/helpers/profiles_helper_spec.rb' + - 'spec/helpers/projects/alert_management_helper_spec.rb' + - 'spec/helpers/projects/cluster_agents_helper_spec.rb' + - 'spec/helpers/projects/ml/experiments_helper_spec.rb' + - 'spec/helpers/projects/pages_helper_spec.rb' + - 'spec/helpers/projects/pipeline_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' + - 'spec/helpers/projects/security/configuration_helper_spec.rb' + - 'spec/helpers/projects/terraform_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/helpers/releases_helper_spec.rb' + - 'spec/helpers/routing/pseudonymization_helper_spec.rb' + - 'spec/helpers/rss_helper_spec.rb' + - 'spec/helpers/search_helper_spec.rb' + - 'spec/helpers/snippets_helper_spec.rb' + - 'spec/helpers/storage_helper_spec.rb' + - 'spec/helpers/submodule_helper_spec.rb' + - 'spec/helpers/timeboxes_helper_spec.rb' + - 'spec/helpers/todos_helper_spec.rb' + - 'spec/helpers/tree_helper_spec.rb' + - 'spec/helpers/users/callouts_helper_spec.rb' + - 'spec/helpers/users/group_callouts_helper_spec.rb' + - 'spec/helpers/users_helper_spec.rb' + - 'spec/helpers/version_check_helper_spec.rb' + - 'spec/helpers/visibility_level_helper_spec.rb' + - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' + - 'spec/helpers/whats_new_helper_spec.rb' + - 'spec/helpers/wiki_helper_spec.rb' + - 'spec/helpers/wiki_page_version_helper_spec.rb' + - 'spec/mailers/abuse_report_mailer_spec.rb' + - 'spec/mailers/devise_mailer_spec.rb' + - 'spec/mailers/emails/auto_devops_spec.rb' + - 'spec/mailers/emails/groups_spec.rb' + - 'spec/mailers/emails/in_product_marketing_spec.rb' + - 'spec/mailers/emails/issues_spec.rb' + - 'spec/mailers/emails/merge_requests_spec.rb' + - 'spec/mailers/emails/pages_domains_spec.rb' + - 'spec/mailers/emails/pipelines_spec.rb' + - 'spec/mailers/emails/profile_spec.rb' + - 'spec/mailers/emails/projects_spec.rb' + - 'spec/mailers/emails/releases_spec.rb' + - 'spec/mailers/emails/service_desk_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/mailers/previews_spec.rb' + - 'spec/mailers/repository_check_mailer_spec.rb' - 'spec/presenters/alert_management/alert_presenter_spec.rb' - 'spec/presenters/blob_presenter_spec.rb' - 'spec/presenters/blobs/notebook_presenter_spec.rb' @@ -219,7 +490,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/impersonation_access_token_serializer_spec.rb' - 'spec/serializers/import/manifest_provider_repo_entity_spec.rb' - 'spec/serializers/integrations/event_entity_spec.rb' - - 'spec/serializers/integrations/field_entity_spec.rb' - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' - 'spec/serializers/integrations/harbor_serializers/repository_entity_spec.rb' - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' @@ -265,8 +535,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/project_mirror_entity_spec.rb' - 'spec/serializers/project_note_entity_spec.rb' - 'spec/serializers/project_serializer_spec.rb' - - 'spec/serializers/prometheus_alert_entity_spec.rb' - - 'spec/serializers/release_serializer_spec.rb' - 'spec/serializers/review_app_setup_entity_spec.rb' - 'spec/serializers/runner_entity_spec.rb' - 'spec/serializers/serverless/domain_entity_spec.rb' @@ -283,3 +551,104 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/user_serializer_spec.rb' - 'spec/serializers/web_ide_terminal_entity_spec.rb' - 'spec/serializers/web_ide_terminal_serializer_spec.rb' + - 'spec/views/admin/application_settings/_ci_cd.html.haml_spec.rb' + - 'spec/views/admin/application_settings/_eks.html.haml_spec.rb' + - 'spec/views/admin/application_settings/_jira_connect.html.haml_spec.rb' + - 'spec/views/admin/application_settings/_package_registry.html.haml_spec.rb' + - 'spec/views/admin/application_settings/_repository_check.html.haml_spec.rb' + - 'spec/views/admin/application_settings/ci_cd.html.haml_spec.rb' + - 'spec/views/admin/application_settings/general.html.haml_spec.rb' + - 'spec/views/admin/application_settings/repository.html.haml_spec.rb' + - 'spec/views/admin/broadcast_messages/index.html.haml_spec.rb' + - 'spec/views/admin/dashboard/index.html.haml_spec.rb' + - 'spec/views/admin/identities/index.html.haml_spec.rb' + - 'spec/views/admin/sessions/new.html.haml_spec.rb' + - 'spec/views/admin/sessions/two_factor.html.haml_spec.rb' + - 'spec/views/ci/status/_badge.html.haml_spec.rb' + - 'spec/views/ci/status/_icon.html.haml_spec.rb' + - 'spec/views/dashboard/projects/_blank_state_admin_welcome.haml_spec.rb' + - 'spec/views/dashboard/projects/_blank_state_welcome.html.haml_spec.rb' + - 'spec/views/events/event/_common.html.haml_spec.rb' + - 'spec/views/groups/_home_panel.html.haml_spec.rb' + - 'spec/views/groups/edit.html.haml_spec.rb' + - 'spec/views/groups/group_members/index.html.haml_spec.rb' + - 'spec/views/groups/new.html.haml_spec.rb' + - 'spec/views/help/instance_configuration.html.haml_spec.rb' + - 'spec/views/layouts/_search.html.haml_spec.rb' + - 'spec/views/layouts/application.html.haml_spec.rb' + - 'spec/views/layouts/devise.html.haml_spec.rb' + - 'spec/views/layouts/fullscreen.html.haml_spec.rb' + - 'spec/views/layouts/header/_new_dropdown.haml_spec.rb' + - 'spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' + - 'spec/views/layouts/nav/sidebar/_profile.html.haml_spec.rb' + - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' + - 'spec/views/layouts/profile.html.haml_spec.rb' + - 'spec/views/layouts/terms.html.haml_spec.rb' + - 'spec/views/notify/approved_merge_request_email.html.haml_spec.rb' + - 'spec/views/notify/autodevops_disabled_email.text.erb_spec.rb' + - 'spec/views/notify/change_in_merge_request_draft_status_email.html.haml_spec.rb' + - 'spec/views/notify/change_in_merge_request_draft_status_email.text.erb_spec.rb' + - 'spec/views/notify/changed_milestone_email.html.haml_spec.rb' + - 'spec/views/notify/import_issues_csv_email.html.haml_spec.rb' + - 'spec/views/notify/pipeline_failed_email.text.erb_spec.rb' + - 'spec/views/notify/push_to_merge_request_email.text.haml_spec.rb' + - 'spec/views/profiles/audit_log.html.haml_spec.rb' + - 'spec/views/profiles/keys/_key.html.haml_spec.rb' + - 'spec/views/profiles/keys/_key_details.html.haml_spec.rb' + - 'spec/views/profiles/notifications/show.html.haml_spec.rb' + - 'spec/views/profiles/show.html.haml_spec.rb' + - 'spec/views/projects/_files.html.haml_spec.rb' + - 'spec/views/projects/_flash_messages.html.haml_spec.rb' + - 'spec/views/projects/_home_panel.html.haml_spec.rb' + - 'spec/views/projects/branches/index.html.haml_spec.rb' + - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb' + - 'spec/views/projects/commit/branches.html.haml_spec.rb' + - 'spec/views/projects/commit/show.html.haml_spec.rb' + - 'spec/views/projects/commits/_commit.html.haml_spec.rb' + - 'spec/views/projects/commits/show.html.haml_spec.rb' + - 'spec/views/projects/diffs/_viewer.html.haml_spec.rb' + - 'spec/views/projects/edit.html.haml_spec.rb' + - 'spec/views/projects/empty.html.haml_spec.rb' + - 'spec/views/projects/environments/terminal.html.haml_spec.rb' + - 'spec/views/projects/hooks/edit.html.haml_spec.rb' + - 'spec/views/projects/hooks/index.html.haml_spec.rb' + - 'spec/views/projects/imports/new.html.haml_spec.rb' + - 'spec/views/projects/issues/_issue.html.haml_spec.rb' + - 'spec/views/projects/issues/_service_desk_info_content.html.haml_spec.rb' + - 'spec/views/projects/issues/show.html.haml_spec.rb' + - 'spec/views/projects/jobs/_build.html.haml_spec.rb' + - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb' + - 'spec/views/projects/jobs/show.html.haml_spec.rb' + - 'spec/views/projects/merge_requests/_close_reopen_draft_report_toggle.html.haml_spec.rb' + - 'spec/views/projects/merge_requests/_commits.html.haml_spec.rb' + - 'spec/views/projects/merge_requests/creations/_new_submit.html.haml_spec.rb' + - 'spec/views/projects/merge_requests/edit.html.haml_spec.rb' + - 'spec/views/projects/notes/_more_actions_dropdown.html.haml_spec.rb' + - 'spec/views/projects/pages/new.html.haml_spec.rb' + - 'spec/views/projects/pages/show.html.haml_spec.rb' + - 'spec/views/projects/pages_domains/show.html.haml_spec.rb' + - 'spec/views/projects/pipeline_schedules/_pipeline_schedule.html.haml_spec.rb' + - 'spec/views/projects/pipelines/show.html.haml_spec.rb' + - 'spec/views/projects/project_members/index.html.haml_spec.rb' + - 'spec/views/projects/runners/_specific_runners.html.haml_spec.rb' + - 'spec/views/projects/settings/ci_cd/_autodevops_form.html.haml_spec.rb' + - 'spec/views/projects/settings/integrations/edit.html.haml_spec.rb' + - 'spec/views/projects/settings/merge_requests/show.html.haml_spec.rb' + - 'spec/views/projects/settings/operations/show.html.haml_spec.rb' + - 'spec/views/projects/tags/index.html.haml_spec.rb' + - 'spec/views/projects/tree/show.html.haml_spec.rb' + - 'spec/views/registrations/welcome/show.html.haml_spec.rb' + - 'spec/views/search/_results.html.haml_spec.rb' + - 'spec/views/shared/_label_row.html.haml_spec.rb' + - 'spec/views/shared/issuable/_sidebar.html.haml_spec.rb' + - 'spec/views/shared/milestones/_issuable.html.haml_spec.rb' + - 'spec/views/shared/milestones/_top.html.haml_spec.rb' + - 'spec/views/shared/nav/_sidebar.html.haml_spec.rb' + - 'spec/views/shared/notes/_form.html.haml_spec.rb' + - 'spec/views/shared/projects/_inactive_project_deletion_alert.html.haml_spec.rb' + - 'spec/views/shared/projects/_list.html.haml_spec.rb' + - 'spec/views/shared/projects/_project.html.haml_spec.rb' + - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' + - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' + - 'spec/views/shared/web_hooks/_web_hook_disabled_alert.html.haml_spec.rb' + - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index 8930b709bfd..9cc2e1b5b6c 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -18,7 +18,6 @@ RSpec/FilePath: - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/runnable_builds_spec.rb' - 'spec/benchmarks/banzai_benchmark.rb' @@ -53,7 +52,6 @@ RSpec/FilePath: - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' - 'spec/services/ci/create_pipeline_service/include_spec.rb' - 'spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' - 'spec/services/ci/create_pipeline_service/needs_spec.rb' - 'spec/services/ci/create_pipeline_service/parallel_spec.rb' @@ -63,5 +61,6 @@ RSpec/FilePath: - 'spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb' - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - 'spec/services/ci/create_pipeline_service/rules_spec.rb' + - 'spec/services/ci/create_pipeline_service/scripts_spec.rb' - 'spec/services/ci/create_pipeline_service/tags_spec.rb' - 'spec/services/ci/create_pipeline_service/variables_spec.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml index 0de9ff4b6c0..333687e1cc4 100644 --- a/.rubocop_todo/rspec/hooks_before_examples.yml +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/HooksBeforeExamples: Exclude: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' @@ -30,47 +30,17 @@ RSpec/HooksBeforeExamples: - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/spec/resource/reusable_collection_spec.rb' - 'qa/spec/specs/runner_spec.rb' - - 'spec/controllers/import/github_controller_spec.rb' - - 'spec/features/projects/pages/user_configures_pages_pipeline_spec.rb' - - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' - - 'spec/graphql/resolvers/project_pipeline_resolver_spec.rb' - - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' - - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/feature/definition_spec.rb' - - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - - 'spec/lib/gitlab/tracking/event_definition_spec.rb' - - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/lib/mattermost/session_spec.rb' - - 'spec/models/ci/build_trace_chunk_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/services/feature_flags/hook_service_spec.rb' - - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' - - 'spec/support/shared_examples/lib/gitlab/cycle_analytics/deployment_metrics.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index 2cc146a0625..b1b4a6c16ce 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -1,198 +1,172 @@ --- RSpec/InstanceVariable: Exclude: - - ee/spec/controllers/admin/application_settings_controller_spec.rb - - ee/spec/controllers/admin/geo/settings_controller_spec.rb - - ee/spec/controllers/ee/sessions_controller_spec.rb - - ee/spec/controllers/groups/groups_controller_spec.rb - - ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb - - ee/spec/controllers/passwords_controller_spec.rb - - ee/spec/features/markdown/markdown_spec.rb - - ee/spec/frontend/fixtures/dast_profiles.rb - - ee/spec/frontend/fixtures/epic.rb - - ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb - - ee/spec/graphql/types/vulnerability_request_type_spec.rb - - ee/spec/graphql/types/vulnerability_response_type_spec.rb - - ee/spec/helpers/ee/issuables_helper_spec.rb - - ee/spec/helpers/ee/wiki_helper_spec.rb - - ee/spec/helpers/notes_helper_spec.rb - - ee/spec/helpers/search_helper_spec.rb - - ee/spec/lib/ee/gitlab/elastic/helper_spec.rb - - ee/spec/lib/gitlab/elastic/search_results_spec.rb - - ee/spec/lib/gitlab/reference_extractor_spec.rb - - ee/spec/services/ee/merge_requests/update_service_spec.rb - - ee/spec/services/ee/notification_service_spec.rb - - ee/spec/services/ee/users/create_service_spec.rb - - ee/spec/services/ee/users/destroy_service_spec.rb - - ee/spec/services/geo/metrics_update_service_spec.rb - - ee/spec/services/groups/create_service_spec.rb - - ee/spec/services/groups/participants_service_spec.rb - - ee/spec/services/projects/create_from_template_service_spec.rb - - ee/spec/services/projects/create_service_spec.rb - - ee/spec/support/shared_examples/views/subscription_shared_examples.rb - - ee/spec/tasks/geo_rake_spec.rb - - ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb - - ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb - - ee/spec/views/projects/security/dast_scanner_profiles/new.html.haml_spec.rb - - ee/spec/views/projects/security/dast_site_profiles/new.html.haml_spec.rb - - qa/qa/specs/features/api/1_manage/import_large_github_repo_spec.rb - - qa/qa/specs/features/api/1_manage/project_access_token_spec.rb - - qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb - - qa/qa/specs/features/browser_ui/1_manage/login/2fa_recovery_spec.rb - - qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb - - qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb - - qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb - - qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb - - qa/qa/specs/features/browser_ui/1_manage/project/protected_tags_spec.rb - - qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb - - qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb - - qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb - - qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb - - qa/qa/specs/features/browser_ui/3_create/web_ide/link_to_line_in_web_ide_spec.rb - - qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb - - qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb - - qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb - - qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_ci_job_log_artifacts_spec.rb - - qa/qa/specs/features/ee/browser_ui/12_geo/rename_replication_spec.rb - - qa/qa/specs/features/ee/browser_ui/13_secure/create_merge_request_with_secure_spec.rb - - qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb - - qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb - - qa/qa/specs/features/ee/browser_ui/13_secure/project_security_dashboard_spec.rb - - qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb - - qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb - - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb - - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_file_template_spec.rb - - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb - - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb - - qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb - - qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb - - qa/qa/specs/features/ee/browser_ui/2_plan/integrations/jira_issues_list_spec.rb - - qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb - - qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb - - qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb - - qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb - - qa/spec/support/repeater_spec.rb - - spec/commands/metrics_server/metrics_server_spec.rb - - spec/controllers/admin/clusters_controller_spec.rb - - spec/controllers/admin/topics/avatars_controller_spec.rb - - spec/controllers/concerns/renders_commits_spec.rb - - spec/controllers/confirmations_controller_spec.rb - - spec/controllers/groups/avatars_controller_spec.rb - - spec/controllers/groups/clusters_controller_spec.rb - - spec/controllers/import/bitbucket_controller_spec.rb - - spec/controllers/import/bitbucket_server_controller_spec.rb - - spec/controllers/metrics_controller_spec.rb - - spec/controllers/omniauth_callbacks_controller_spec.rb - - spec/controllers/passwords_controller_spec.rb - - spec/controllers/profiles/avatars_controller_spec.rb - - spec/controllers/projects/clusters_controller_spec.rb - - spec/controllers/sessions_controller_spec.rb - - spec/features/calendar_spec.rb - - spec/features/issues/user_filters_issues_spec.rb - - spec/features/markdown/copy_as_gfm_spec.rb - - spec/features/markdown/gitlab_flavored_markdown_spec.rb - - spec/features/markdown/keyboard_shortcuts_spec.rb - - spec/features/markdown/markdown_spec.rb - - spec/features/merge_request/batch_comments_spec.rb - - spec/features/merge_request/user_sees_pipelines_spec.rb - - spec/features/merge_requests/user_lists_merge_requests_spec.rb - - spec/features/projects/diffs/diff_show_spec.rb - - spec/features/triggers_spec.rb - - spec/features/u2f_spec.rb - - spec/finders/admin/plans_finder_spec.rb - - spec/finders/groups_finder_spec.rb - - spec/finders/issues_finder_spec.rb - - spec/frontend/fixtures/listbox.rb - - spec/frontend/fixtures/raw.rb - - spec/frontend/fixtures/sessions.rb - - spec/frontend/fixtures/tabs.rb - - spec/frontend/fixtures/timezones.rb - - spec/frontend/fixtures/u2f.rb - - spec/frontend/fixtures/webauthn.rb - - spec/helpers/application_helper_spec.rb - - spec/helpers/award_emoji_helper_spec.rb - - spec/helpers/issuables_description_templates_helper_spec.rb - - spec/helpers/issuables_helper_spec.rb - - spec/helpers/notes_helper_spec.rb - - spec/helpers/projects_helper_spec.rb - - spec/helpers/search_helper_spec.rb - - spec/helpers/tree_helper_spec.rb - - spec/helpers/wiki_helper_spec.rb - - spec/lib/api/helpers/authentication_spec.rb - - spec/lib/banzai/filter/asset_proxy_filter_spec.rb - - spec/lib/extracts_path_spec.rb - - spec/lib/extracts_ref_spec.rb - - spec/lib/gitlab/auth/auth_finders_spec.rb - - spec/lib/gitlab/auth/ldap/person_spec.rb - - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb - - spec/lib/gitlab/bitbucket_import/importer_spec.rb - - spec/lib/gitlab/chat_name_token_spec.rb - - spec/lib/gitlab/ci/lint_spec.rb - - spec/lib/gitlab/ci/status/composite_spec.rb - - spec/lib/gitlab/contributions_calendar_spec.rb - - spec/lib/gitlab/diff/parser_spec.rb - - spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb - - spec/lib/gitlab/git/commit_spec.rb - - spec/lib/gitlab/git/diff_collection_spec.rb - - spec/lib/gitlab/git/diff_spec.rb - - spec/lib/gitlab/git/repository_spec.rb - - spec/lib/gitlab/http_spec.rb - - spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb - - spec/lib/gitlab/import_export/group/tree_restorer_spec.rb - - spec/lib/gitlab/import_export/project/tree_restorer_spec.rb - - spec/lib/gitlab/patch/prependable_spec.rb - - spec/lib/gitlab/popen_spec.rb - - spec/lib/gitlab/project_transfer_spec.rb - - spec/lib/gitlab/reference_extractor_spec.rb - - spec/lib/gitlab/tcp_checker_spec.rb - - spec/lib/gitlab/user_access_spec.rb - - spec/lib/gitlab/version_info_spec.rb - - spec/lib/gitlab/x509/certificate_spec.rb - - spec/mailers/emails/issues_spec.rb - - spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb - - spec/migrations/rename_services_to_integrations_spec.rb - - spec/migrations/replace_external_wiki_triggers_spec.rb - - spec/models/group_spec.rb - - spec/models/integrations/assembla_spec.rb - - spec/models/integrations/campfire_spec.rb - - spec/models/member_spec.rb - - spec/models/members/project_member_spec.rb - - spec/models/namespace_spec.rb - - spec/models/note_spec.rb - - spec/models/postgresql/replication_slot_spec.rb - - spec/models/project_spec.rb - - spec/models/user_spec.rb - - spec/models/users/in_product_marketing_email_spec.rb - - spec/rack_servers/puma_spec.rb - - spec/requests/api/admin/plan_limits_spec.rb - - spec/requests/api/merge_requests_spec.rb - - spec/requests/api/users_spec.rb - - spec/requests/git_http_spec.rb - - spec/requests/openid_connect_spec.rb - - spec/requests/projects/issues/discussions_spec.rb - - spec/rubocop/cop/migration/update_column_in_batches_spec.rb - - spec/services/ci/create_pipeline_service/logger_spec.rb - - spec/services/ci/process_sync_events_service_spec.rb - - spec/services/labels/update_service_spec.rb - - spec/services/members/destroy_service_spec.rb - - spec/services/merge_requests/close_service_spec.rb - - spec/services/merge_requests/refresh_service_spec.rb - - spec/services/merge_requests/reopen_service_spec.rb - - spec/services/merge_requests/update_service_spec.rb - - spec/services/milestones/create_service_spec.rb - - spec/services/notes/post_process_service_spec.rb - - spec/services/notes/update_service_spec.rb - - spec/services/notification_service_spec.rb - - spec/services/pages/zip_directory_service_spec.rb - - spec/services/projects/create_from_template_service_spec.rb - - spec/services/projects/download_service_spec.rb - - spec/services/projects/fork_service_spec.rb - - spec/services/upload_service_spec.rb - - spec/support/shared_contexts/controllers/ldap_omniauth_callbacks_controller_shared_context.rb - - spec/support/shared_contexts/email_shared_context.rb - - spec/support/shared_examples/features/wiki/user_views_wiki_empty_shared_examples.rb - - spec/support/shared_examples/path_extraction_shared_examples.rb - - spec/support/shared_examples/requests/api/notes_shared_examples.rb - - spec/support_specs/helpers/stub_feature_flags_spec.rb - - spec/views/search/_results.html.haml_spec.rb - - spec/workers/emails_on_push_worker_spec.rb + - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' + - 'ee/spec/controllers/admin/geo/settings_controller_spec.rb' + - 'ee/spec/controllers/ee/sessions_controller_spec.rb' + - 'ee/spec/controllers/groups/groups_controller_spec.rb' + - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/controllers/passwords_controller_spec.rb' + - 'ee/spec/features/markdown/markdown_spec.rb' + - 'ee/spec/frontend/fixtures/dast_profiles.rb' + - 'ee/spec/frontend/fixtures/epic.rb' + - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' + - 'ee/spec/helpers/ee/issuables_helper_spec.rb' + - 'ee/spec/helpers/ee/wiki_helper_spec.rb' + - 'ee/spec/helpers/notes_helper_spec.rb' + - 'ee/spec/helpers/search_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' + - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' + - 'ee/spec/lib/gitlab/reference_extractor_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/services/ee/users/create_service_spec.rb' + - 'ee/spec/services/geo/metrics_update_service_spec.rb' + - 'ee/spec/services/groups/create_service_spec.rb' + - 'ee/spec/services/groups/participants_service_spec.rb' + - 'ee/spec/services/projects/create_from_template_service_spec.rb' + - 'ee/spec/services/projects/create_service_spec.rb' + - 'ee/spec/support/shared_examples/views/subscription_shared_examples.rb' + - 'ee/spec/tasks/geo_rake_spec.rb' + - 'ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_scanner_profiles/new.html.haml_spec.rb' + - 'ee/spec/views/projects/security/dast_site_profiles/new.html.haml_spec.rb' + - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/link_to_line_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' + - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' + - 'spec/commands/metrics_server/metrics_server_spec.rb' + - 'spec/controllers/admin/topics/avatars_controller_spec.rb' + - 'spec/controllers/concerns/renders_commits_spec.rb' + - 'spec/controllers/confirmations_controller_spec.rb' + - 'spec/controllers/groups/avatars_controller_spec.rb' + - 'spec/controllers/import/bitbucket_controller_spec.rb' + - 'spec/controllers/import/bitbucket_server_controller_spec.rb' + - 'spec/controllers/metrics_controller_spec.rb' + - 'spec/controllers/omniauth_callbacks_controller_spec.rb' + - 'spec/controllers/passwords_controller_spec.rb' + - 'spec/controllers/profiles/avatars_controller_spec.rb' + - 'spec/controllers/sessions_controller_spec.rb' + - 'spec/features/calendar_spec.rb' + - 'spec/features/issues/user_filters_issues_spec.rb' + - 'spec/features/markdown/copy_as_gfm_spec.rb' + - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' + - 'spec/features/markdown/keyboard_shortcuts_spec.rb' + - 'spec/features/markdown/markdown_spec.rb' + - 'spec/features/merge_request/batch_comments_spec.rb' + - 'spec/features/merge_request/user_sees_pipelines_spec.rb' + - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' + - 'spec/features/projects/diffs/diff_show_spec.rb' + - 'spec/features/triggers_spec.rb' + - 'spec/features/u2f_spec.rb' + - 'spec/finders/admin/plans_finder_spec.rb' + - 'spec/finders/groups_finder_spec.rb' + - 'spec/frontend/fixtures/listbox.rb' + - 'spec/frontend/fixtures/raw.rb' + - 'spec/frontend/fixtures/sessions.rb' + - 'spec/frontend/fixtures/tabs.rb' + - 'spec/frontend/fixtures/timezones.rb' + - 'spec/frontend/fixtures/u2f.rb' + - 'spec/frontend/fixtures/webauthn.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/helpers/award_emoji_helper_spec.rb' + - 'spec/helpers/issuables_description_templates_helper_spec.rb' + - 'spec/helpers/issuables_helper_spec.rb' + - 'spec/helpers/notes_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/helpers/search_helper_spec.rb' + - 'spec/helpers/tree_helper_spec.rb' + - 'spec/helpers/wiki_helper_spec.rb' + - 'spec/lib/api/helpers/authentication_spec.rb' + - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' + - 'spec/lib/extracts_path_spec.rb' + - 'spec/lib/extracts_ref_spec.rb' + - 'spec/lib/gitlab/auth/auth_finders_spec.rb' + - 'spec/lib/gitlab/auth/ldap/person_spec.rb' + - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' + - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' + - 'spec/lib/gitlab/chat_name_token_spec.rb' + - 'spec/lib/gitlab/ci/lint_spec.rb' + - 'spec/lib/gitlab/ci/status/composite_spec.rb' + - 'spec/lib/gitlab/contributions_calendar_spec.rb' + - 'spec/lib/gitlab/diff/parser_spec.rb' + - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' + - 'spec/lib/gitlab/git/diff_collection_spec.rb' + - 'spec/lib/gitlab/git/diff_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/http_spec.rb' + - 'spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' + - 'spec/lib/gitlab/patch/prependable_spec.rb' + - 'spec/lib/gitlab/popen_spec.rb' + - 'spec/lib/gitlab/project_transfer_spec.rb' + - 'spec/lib/gitlab/reference_extractor_spec.rb' + - 'spec/lib/gitlab/tcp_checker_spec.rb' + - 'spec/lib/gitlab/user_access_spec.rb' + - 'spec/lib/gitlab/version_info_spec.rb' + - 'spec/lib/gitlab/x509/certificate_spec.rb' + - 'spec/mailers/emails/issues_spec.rb' + - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' + - 'spec/migrations/rename_services_to_integrations_spec.rb' + - 'spec/migrations/replace_external_wiki_triggers_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/models/integrations/assembla_spec.rb' + - 'spec/models/integrations/campfire_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/members/project_member_spec.rb' + - 'spec/models/namespace_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/postgresql/replication_slot_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/users/in_product_marketing_email_spec.rb' + - 'spec/rack_servers/puma_spec.rb' + - 'spec/requests/api/admin/plan_limits_spec.rb' + - 'spec/requests/api/users_spec.rb' + - 'spec/requests/git_http_spec.rb' + - 'spec/requests/openid_connect_spec.rb' + - 'spec/requests/projects/issues/discussions_spec.rb' + - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' + - 'spec/services/ci/process_sync_events_service_spec.rb' + - 'spec/services/labels/update_service_spec.rb' + - 'spec/services/members/destroy_service_spec.rb' + - 'spec/services/merge_requests/close_service_spec.rb' + - 'spec/services/merge_requests/refresh_service_spec.rb' + - 'spec/services/merge_requests/reopen_service_spec.rb' + - 'spec/services/merge_requests/update_service_spec.rb' + - 'spec/services/milestones/create_service_spec.rb' + - 'spec/services/notes/post_process_service_spec.rb' + - 'spec/services/notes/update_service_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/pages/zip_directory_service_spec.rb' + - 'spec/services/projects/create_from_template_service_spec.rb' + - 'spec/services/projects/download_service_spec.rb' + - 'spec/services/projects/fork_service_spec.rb' + - 'spec/services/upload_service_spec.rb' + - 'spec/support/shared_contexts/controllers/ldap_omniauth_callbacks_controller_shared_context.rb' + - 'spec/support/shared_contexts/email_shared_context.rb' + - 'spec/support/shared_examples/features/wiki/user_views_wiki_empty_shared_examples.rb' + - 'spec/support/shared_examples/path_extraction_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' + - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' + - 'spec/views/search/_results.html.haml_spec.rb' + - 'spec/workers/emails_on_push_worker_spec.rb' diff --git a/.rubocop_todo/rspec/leaky_constant_declaration.yml b/.rubocop_todo/rspec/leaky_constant_declaration.yml index b8b3980ef4f..824be5765c8 100644 --- a/.rubocop_todo/rspec/leaky_constant_declaration.yml +++ b/.rubocop_todo/rspec/leaky_constant_declaration.yml @@ -1,15 +1,8 @@ --- RSpec/LeakyConstantDeclaration: Exclude: - - spec/db/schema_spec.rb - - spec/lib/gitlab/config/entry/simplifiable_spec.rb - - spec/lib/gitlab/quick_actions/dsl_spec.rb - - spec/lib/marginalia_spec.rb - - spec/mailers/notify_spec.rb - - spec/models/concerns/batch_destroy_dependent_associations_spec.rb - - spec/models/concerns/bulk_insert_safe_spec.rb - - spec/models/concerns/bulk_insertable_associations_spec.rb - - spec/models/concerns/triggerable_hooks_spec.rb - - spec/models/repository_spec.rb - - spec/services/clusters/applications/check_installation_progress_service_spec.rb - - spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb + - 'spec/db/schema_spec.rb' + - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb' + - 'spec/lib/marginalia_spec.rb' + - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' + - 'spec/models/concerns/bulk_insert_safe_spec.rb' diff --git a/.rubocop_todo/rspec/let_before_examples.yml b/.rubocop_todo/rspec/let_before_examples.yml deleted file mode 100644 index f84df4bdb5f..00000000000 --- a/.rubocop_todo/rspec/let_before_examples.yml +++ /dev/null @@ -1,17 +0,0 @@ ---- -# Cop supports --auto-correct. -RSpec/LetBeforeExamples: - Exclude: - - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - - 'ee/spec/models/resource_weight_event_spec.rb' - - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - - 'ee/spec/requests/api/scim_spec.rb' - - 'spec/graphql/types/ci/detailed_status_type_spec.rb' - - 'spec/graphql/types/merge_request_type_spec.rb' - - 'spec/graphql/types/snippets/blob_type_spec.rb' - - 'spec/models/ci/job_token/project_scope_link_spec.rb' - - 'spec/models/ci/runner_version_spec.rb' - - 'spec/models/group_deploy_key_spec.rb' - - 'spec/models/snippet_repository_spec.rb' - - 'spec/requests/api/issue_links_spec.rb' diff --git a/.rubocop_todo/rspec/overwriting_setup.yml b/.rubocop_todo/rspec/overwriting_setup.yml index 630f08eb72f..2bca06918fc 100644 --- a/.rubocop_todo/rspec/overwriting_setup.yml +++ b/.rubocop_todo/rspec/overwriting_setup.yml @@ -3,7 +3,6 @@ RSpec/OverwritingSetup: Exclude: - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/requests/api/namespaces_spec.rb' - 'ee/spec/services/epics/descendant_count_service_spec.rb' - 'spec/finders/packages/helm/packages_finder_spec.rb' diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml deleted file mode 100644 index 5847080dcde..00000000000 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ /dev/null @@ -1,516 +0,0 @@ ---- -# Cop supports --auto-correct. -RSpec/PredicateMatcher: - Exclude: - - 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb' - - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - - 'ee/spec/controllers/ee/sent_notifications_controller_spec.rb' - - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - - 'ee/spec/controllers/groups/ldaps_controller_spec.rb' - - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' - - 'ee/spec/elastic/migrate/20220713103500_delete_commits_from_original_index_spec.rb' - - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - - 'ee/spec/features/admin/admin_settings_spec.rb' - - 'ee/spec/features/projects/members/member_is_removed_from_project_spec.rb' - - 'ee/spec/features/projects/mirror_spec.rb' - - 'ee/spec/features/signup_spec.rb' - - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - - 'ee/spec/helpers/ee/groups_helper_spec.rb' - - 'ee/spec/helpers/ee/issues_helper_spec.rb' - - 'ee/spec/helpers/projects_helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/after_config_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - - 'ee/spec/lib/ee/gitlab/database_spec.rb' - - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/gma_membership_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/membership_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' - - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'ee/spec/lib/gitlab/geo/geo_node_status_check_spec.rb' - - 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb' - - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - - 'ee/spec/lib/gitlab/geo_spec.rb' - - 'ee/spec/lib/gitlab/mirror_spec.rb' - - 'ee/spec/lib/gitlab/user_access_spec.rb' - - 'ee/spec/lib/system_check/geo/authorized_keys_flag_check_spec.rb' - - 'ee/spec/lib/system_check/geo/current_node_check_spec.rb' - - 'ee/spec/lib/system_check/geo/http_connection_check_spec.rb' - - 'ee/spec/models/allowed_email_domain_spec.rb' - - 'ee/spec/models/application_setting_spec.rb' - - 'ee/spec/models/approval_state_spec.rb' - - 'ee/spec/models/ci/minutes/notification_spec.rb' - - 'ee/spec/models/concerns/approval_rule_like_spec.rb' - - 'ee/spec/models/concerns/elastic/issue_spec.rb' - - 'ee/spec/models/concerns/elastic/note_spec.rb' - - 'ee/spec/models/concerns/elastic/project_spec.rb' - - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - - 'ee/spec/models/dast_site_profile_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' - - 'ee/spec/models/ee/group_spec.rb' - - 'ee/spec/models/ee/label_spec.rb' - - 'ee/spec/models/ee/list_spec.rb' - - 'ee/spec/models/ee/namespace_spec.rb' - - 'ee/spec/models/ee/user_spec.rb' - - 'ee/spec/models/epic_spec.rb' - - 'ee/spec/models/geo/container_repository_registry_spec.rb' - - 'ee/spec/models/geo/project_registry_spec.rb' - - 'ee/spec/models/geo_node_spec.rb' - - 'ee/spec/models/ip_restriction_spec.rb' - - 'ee/spec/models/issue_spec.rb' - - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/namespace_setting_spec.rb' - - 'ee/spec/models/note_spec.rb' - - 'ee/spec/models/path_lock_spec.rb' - - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/project_spec.rb' - - 'ee/spec/models/saml_provider_spec.rb' - - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - - 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb' - - 'ee/spec/requests/api/boards_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb' - - 'ee/spec/requests/api/groups_spec.rb' - - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/requests/api/projects_spec.rb' - - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' - - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' - - 'ee/spec/services/ci/process_build_service_spec.rb' - - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' - - 'ee/spec/services/ee/allowed_email_domains/update_service_spec.rb' - - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/geo/container_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/event_service_spec.rb' - - 'ee/spec/services/geo/files_expire_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb' - - 'ee/spec/services/geo/move_repository_service_spec.rb' - - 'ee/spec/services/geo/repository_destroy_service_spec.rb' - - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - - 'ee/spec/services/groups/restore_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - - 'ee/spec/services/iterations/create_service_spec.rb' - - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - - 'ee/spec/services/milestones/promote_service_spec.rb' - - 'ee/spec/services/protected_environments/create_service_spec.rb' - - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - - 'ee/spec/support/shared_examples/graphql/mutations/dast_on_demand_scans_shared_examples.rb' - - 'ee/spec/support/shared_examples/lib/gitlab/geo/geo_log_cursor_event_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/concerns/elastic/limited_indexing_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/member_shared_examples.rb' - - 'ee/spec/tasks/geo_rake_spec.rb' - - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' - - 'ee/spec/workers/elastic/migration_worker_spec.rb' - - 'ee/spec/workers/geo/batch/project_registry_worker_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/database_delete_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/roadmap_spec.rb' - - 'qa/spec/runtime/env_spec.rb' - - 'qa/spec/specs/helpers/context_selector_spec.rb' - - 'spec/components/diffs/overflow_warning_component_spec.rb' - - 'spec/controllers/admin/dev_ops_report_controller_spec.rb' - - 'spec/controllers/admin/topics/avatars_controller_spec.rb' - - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/concerns/checks_collaboration_spec.rb' - - 'spec/controllers/groups/avatars_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - - 'spec/controllers/groups/group_links_controller_spec.rb' - - 'spec/controllers/groups/group_members_controller_spec.rb' - - 'spec/controllers/groups/settings/applications_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/profiles/avatars_controller_spec.rb' - - 'spec/controllers/profiles_controller_spec.rb' - - 'spec/controllers/projects/avatars_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/controllers/projects/project_members_controller_spec.rb' - - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/sent_notifications_controller_spec.rb' - - 'spec/controllers/sessions_controller_spec.rb' - - 'spec/controllers/snippets/notes_controller_spec.rb' - - 'spec/features/admin/admin_settings_spec.rb' - - 'spec/features/admin/users/user_spec.rb' - - 'spec/features/admin/users/users_spec.rb' - - 'spec/features/groups/members/request_access_spec.rb' - - 'spec/features/groups/share_lock_spec.rb' - - 'spec/features/merge_request/user_interacts_with_batched_mr_diffs_spec.rb' - - 'spec/features/password_reset_spec.rb' - - 'spec/features/profile_spec.rb' - - 'spec/features/profiles/emails_spec.rb' - - 'spec/features/projects/integrations/user_activates_mattermost_slash_command_spec.rb' - - 'spec/features/projects/jobs/user_browses_job_spec.rb' - - 'spec/features/projects/members/member_leaves_project_spec.rb' - - 'spec/features/projects/members/user_requests_access_spec.rb' - - 'spec/features/projects/pages/user_edits_settings_spec.rb' - - 'spec/features/projects/settings/forked_project_settings_spec.rb' - - 'spec/features/unsubscribe_links_spec.rb' - - 'spec/features/users/signup_spec.rb' - - 'spec/finders/group_descendants_finder_spec.rb' - - 'spec/finders/merge_request_target_project_finder_spec.rb' - - 'spec/helpers/application_helper_spec.rb' - - 'spec/helpers/application_settings_helper_spec.rb' - - 'spec/helpers/auth_helper_spec.rb' - - 'spec/helpers/blob_helper_spec.rb' - - 'spec/helpers/clusters_helper_spec.rb' - - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/issues_helper_spec.rb' - - 'spec/helpers/projects_helper_spec.rb' - - 'spec/helpers/recaptcha_helper_spec.rb' - - 'spec/helpers/sessions_helper_spec.rb' - - 'spec/helpers/sorting_helper_spec.rb' - - 'spec/lib/backup/files_spec.rb' - - 'spec/lib/bitbucket/connection_spec.rb' - - 'spec/lib/bitbucket/page_spec.rb' - - 'spec/lib/bitbucket/representation/pull_request_comment_spec.rb' - - 'spec/lib/bitbucket/representation/repo_spec.rb' - - 'spec/lib/bitbucket_server/page_spec.rb' - - 'spec/lib/bitbucket_server/paginator_spec.rb' - - 'spec/lib/bitbucket_server/representation/activity_spec.rb' - - 'spec/lib/bitbucket_server/representation/pull_request_comment_spec.rb' - - 'spec/lib/bitbucket_server/representation/pull_request_spec.rb' - - 'spec/lib/constraints/group_url_constrainer_spec.rb' - - 'spec/lib/constraints/project_url_constrainer_spec.rb' - - 'spec/lib/constraints/user_url_constrainer_spec.rb' - - 'spec/lib/feature_spec.rb' - - 'spec/lib/gitlab/auth/ip_rate_limiter_spec.rb' - - 'spec/lib/gitlab/auth/ldap/access_spec.rb' - - 'spec/lib/gitlab/auth/ldap/config_spec.rb' - - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/provider_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - - 'spec/lib/gitlab/auth/result_spec.rb' - - 'spec/lib/gitlab/auth/two_factor_auth_verifier_spec.rb' - - 'spec/lib/gitlab/auth_spec.rb' - - 'spec/lib/gitlab/authorized_keys_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2_spec.rb' - - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - - 'spec/lib/gitlab/background_migration/merge_topics_with_same_name_spec.rb' - - 'spec/lib/gitlab/blob_helper_spec.rb' - - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - - 'spec/lib/gitlab/checks/lfs_integrity_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json/parser_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' - - 'spec/lib/gitlab/ci/lint_spec.rb' - - 'spec/lib/gitlab/ci/matching/build_matcher_spec.rb' - - 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb' - - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/limit/rate_limit_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/pipeline/process_spec.rb' - - 'spec/lib/gitlab/ci/reports/test_case_spec.rb' - - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - - 'spec/lib/gitlab/ci/status/build/waiting_for_approval_spec.rb' - - 'spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - - 'spec/lib/gitlab/ci/trace_spec.rb' - - 'spec/lib/gitlab/ci_access_spec.rb' - - 'spec/lib/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' - - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' - - 'spec/lib/gitlab/cleanup/project_uploads_spec.rb' - - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb' - - 'spec/lib/gitlab/cross_project_access/check_collection_spec.rb' - - 'spec/lib/gitlab/cross_project_access/check_info_spec.rb' - - 'spec/lib/gitlab/current_settings_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migration_spec.rb' - - 'spec/lib/gitlab/database/migrations/runner_spec.rb' - - 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb' - - 'spec/lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin_spec.rb' - - 'spec/lib/gitlab/database/reflection_spec.rb' - - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces_spec.rb' - - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_projects_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - - 'spec/lib/gitlab/dependency_linker/cargo_toml_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/cartfile_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/composer_json_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/gemfile_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/gemspec_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/go_mod_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/go_sum_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/godeps_json_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/package_json_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/podfile_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/podspec_json_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/podspec_linker_spec.rb' - - 'spec/lib/gitlab/dependency_linker/requirements_txt_linker_spec.rb' - - 'spec/lib/gitlab/deploy_key_access_spec.rb' - - 'spec/lib/gitlab/diff/file_spec.rb' - - 'spec/lib/gitlab/diff/position_spec.rb' - - 'spec/lib/gitlab/diff/rendered/notebook/diff_file_spec.rb' - - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' - - 'spec/lib/gitlab/experimentation/group_types_spec.rb' - - 'spec/lib/gitlab/external_authorization_spec.rb' - - 'spec/lib/gitlab/fake_application_settings_spec.rb' - - 'spec/lib/gitlab/git/blob_spec.rb' - - 'spec/lib/gitlab/git/branch_spec.rb' - - 'spec/lib/gitlab/git/keep_around_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' - - 'spec/lib/gitlab/git/tag_spec.rb' - - 'spec/lib/gitlab/git/tree_spec.rb' - - 'spec/lib/gitlab/git_access_snippet_spec.rb' - - 'spec/lib/gitlab/git_post_receive_spec.rb' - - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/storage_settings_spec.rb' - - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' - - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - - 'spec/lib/gitlab/gpg/commit_spec.rb' - - 'spec/lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer_spec.rb' - - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' - - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' - - 'spec/lib/gitlab/import_export/fork_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/snippet_repo_saver_spec.rb' - - 'spec/lib/gitlab/import_export/snippets_repo_saver_spec.rb' - - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb' - - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - - 'spec/lib/gitlab/markdown_cache/field_data_spec.rb' - - 'spec/lib/gitlab/markup_helper_spec.rb' - - 'spec/lib/gitlab/metrics/prometheus_spec.rb' - - 'spec/lib/gitlab/null_request_store_spec.rb' - - 'spec/lib/gitlab/pagination/cursor_based_keyset_spec.rb' - - 'spec/lib/gitlab/pagination/keyset_spec.rb' - - 'spec/lib/gitlab/performance_bar_spec.rb' - - 'spec/lib/gitlab/project_transfer_spec.rb' - - 'spec/lib/gitlab/reference_extractor_spec.rb' - - 'spec/lib/gitlab/request_forgery_protection_spec.rb' - - 'spec/lib/gitlab/sanitizers/svg_spec.rb' - - 'spec/lib/gitlab/search/found_blob_spec.rb' - - 'spec/lib/gitlab/search/found_wiki_page_spec.rb' - - 'spec/lib/gitlab/service_desk_email_spec.rb' - - 'spec/lib/gitlab/shard_health_cache_spec.rb' - - 'spec/lib/gitlab/uploads_transfer_spec.rb' - - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - - 'spec/lib/gitlab/usage/service_ping/legacy_metric_timing_decorator_spec.rb' - - 'spec/lib/gitlab/user_access_snippet_spec.rb' - - 'spec/lib/gitlab/user_access_spec.rb' - - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' - - 'spec/lib/gitlab/version_info_spec.rb' - - 'spec/lib/gitlab/view/presenter/base_spec.rb' - - 'spec/lib/gitlab/visibility_level_spec.rb' - - 'spec/lib/object_storage/direct_upload_spec.rb' - - 'spec/lib/sidebars/projects/menus/external_issue_tracker_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/external_wiki_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/shimo_menu_spec.rb' - - 'spec/lib/system_check/app/hashed_storage_all_projects_check_spec.rb' - - 'spec/lib/system_check/app/hashed_storage_enabled_check_spec.rb' - - 'spec/migrations/20210713042000_fix_ci_sources_pipelines_index_names_spec.rb' - - 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb' - - 'spec/migrations/20220128155814_fix_approval_rules_code_owners_rule_type_index_spec.rb' - - 'spec/migrations/20220505174658_update_index_on_alerts_to_exclude_null_fingerprints_spec.rb' - - 'spec/models/blob_spec.rb' - - 'spec/models/blob_viewer/base_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/build_trace_chunk_spec.rb' - - 'spec/models/ci/job_artifact_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/processable_spec.rb' - - 'spec/models/ci/runner_spec.rb' - - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/commit_spec.rb' - - 'spec/models/concerns/access_requestable_spec.rb' - - 'spec/models/concerns/awardable_spec.rb' - - 'spec/models/concerns/chronic_duration_attribute_spec.rb' - - 'spec/models/concerns/ci/has_deployment_name_spec.rb' - - 'spec/models/concerns/counter_attribute_spec.rb' - - 'spec/models/concerns/featurable_spec.rb' - - 'spec/models/concerns/ignorable_columns_spec.rb' - - 'spec/models/concerns/integrations/has_data_fields_spec.rb' - - 'spec/models/concerns/issuable_spec.rb' - - 'spec/models/concerns/mentionable_spec.rb' - - 'spec/models/concerns/milestoneable_spec.rb' - - 'spec/models/concerns/resolvable_discussion_spec.rb' - - 'spec/models/concerns/resolvable_note_spec.rb' - - 'spec/models/concerns/routable_spec.rb' - - 'spec/models/concerns/spammable_spec.rb' - - 'spec/models/concerns/subscribable_spec.rb' - - 'spec/models/container_repository_spec.rb' - - 'spec/models/customer_relations/contact_spec.rb' - - 'spec/models/deploy_token_spec.rb' - - 'spec/models/diff_note_spec.rb' - - 'spec/models/diff_viewer/base_spec.rb' - - 'spec/models/email_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/gpg_key_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/hooks/web_hook_log_spec.rb' - - 'spec/models/identity_spec.rb' - - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/base_issue_tracker_spec.rb' - - 'spec/models/integrations/base_third_party_wiki_spec.rb' - - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/issue_spec.rb' - - 'spec/models/members/project_member_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/milestone_spec.rb' - - 'spec/models/namespace/aggregation_schedule_spec.rb' - - 'spec/models/namespace_setting_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/postgresql/replication_slot_spec.rb' - - 'spec/models/project_feature_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/project_statistics_spec.rb' - - 'spec/models/project_team_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/route_spec.rb' - - 'spec/models/sent_notification_spec.rb' - - 'spec/models/snippet_spec.rb' - - 'spec/models/todo_spec.rb' - - 'spec/models/upload_spec.rb' - - 'spec/models/uploads/local_spec.rb' - - 'spec/models/user_agent_detail_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/wiki_page_spec.rb' - - 'spec/policies/project_policy_spec.rb' - - 'spec/presenters/blob_presenter_spec.rb' - - 'spec/presenters/ci/build_presenter_spec.rb' - - 'spec/presenters/label_presenter_spec.rb' - - 'spec/requests/api/admin/instance_clusters_spec.rb' - - 'spec/requests/api/ci/jobs_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/ci/runners_spec.rb' - - 'spec/requests/api/features_spec.rb' - - 'spec/requests/api/group_clusters_spec.rb' - - 'spec/requests/api/integrations_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/project_clusters_spec.rb' - - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_snippets_spec.rb' - - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/resource_access_tokens_spec.rb' - - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/users_spec.rb' - - 'spec/requests/git_http_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - - 'spec/services/branches/create_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/needs_spec.rb' - - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - - 'spec/services/ci/delete_objects_service_spec.rb' - - 'spec/services/ci/destroy_pipeline_service_spec.rb' - - 'spec/services/ci/expire_pipeline_cache_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' - - 'spec/services/ci/job_artifacts/expire_project_build_artifacts_service_spec.rb' - - 'spec/services/ci/runners/register_runner_service_spec.rb' - - 'spec/services/clusters/destroy_service_spec.rb' - - 'spec/services/concerns/exclusive_lease_guard_spec.rb' - - 'spec/services/concerns/merge_requests/assigns_merge_params_spec.rb' - - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - - 'spec/services/container_expiration_policies/update_service_spec.rb' - - 'spec/services/customer_relations/contacts/update_service_spec.rb' - - 'spec/services/customer_relations/organizations/update_service_spec.rb' - - 'spec/services/deployments/create_for_build_service_spec.rb' - - 'spec/services/deployments/older_deployments_drop_service_spec.rb' - - 'spec/services/draft_notes/publish_service_spec.rb' - - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - - 'spec/services/groups/destroy_service_spec.rb' - - 'spec/services/groups/group_links/create_service_spec.rb' - - 'spec/services/groups/group_links/destroy_service_spec.rb' - - 'spec/services/groups/transfer_service_spec.rb' - - 'spec/services/groups/update_service_spec.rb' - - 'spec/services/issuable/bulk_update_service_spec.rb' - - 'spec/services/jira/requests/projects/list_service_spec.rb' - - 'spec/services/jira_import/users_importer_spec.rb' - - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - - 'spec/services/merge_requests/create_from_issue_service_spec.rb' - - 'spec/services/merge_requests/merge_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/metrics/dashboard/cluster_metrics_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' - - 'spec/services/metrics/users_starred_dashboards/delete_service_spec.rb' - - 'spec/services/milestones/promote_service_spec.rb' - - 'spec/services/milestones/transfer_service_spec.rb' - - 'spec/services/namespaces/package_settings/update_service_spec.rb' - - 'spec/services/note_summary_spec.rb' - - 'spec/services/notes/build_service_spec.rb' - - 'spec/services/notes/quick_actions_service_spec.rb' - - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - - 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb' - - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - - 'spec/services/projects/after_rename_service_spec.rb' - - 'spec/services/projects/cleanup_service_spec.rb' - - 'spec/services/projects/create_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - - 'spec/services/projects/fork_service_spec.rb' - - 'spec/services/projects/hashed_storage/base_attachment_service_spec.rb' - - 'spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' - - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_attachments_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' - - 'spec/services/projects/update_pages_service_spec.rb' - - 'spec/services/projects/update_service_spec.rb' - - 'spec/services/releases/create_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - - 'spec/services/repository_archive_clean_up_service_spec.rb' - - 'spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'spec/services/snippets/create_service_spec.rb' - - 'spec/services/snippets/destroy_service_spec.rb' - - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/spam/akismet_service_spec.rb' - - 'spec/services/system_notes/issuables_service_spec.rb' - - 'spec/services/todo_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - - 'spec/support/shared_contexts/email_shared_context.rb' - - 'spec/support/shared_examples/ci/auto_merge_merge_requests_shared_examples.rb' - - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - - 'spec/support/shared_examples/models/cluster_application_core_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/timebox_shared_examples.rb' - - 'spec/support/shared_examples/models/integrations/base_slash_commands_shared_examples.rb' - - 'spec/support/shared_examples/models/member_shared_examples.rb' - - 'spec/support/shared_examples/models/note_access_check_shared_examples.rb' - - 'spec/support/shared_examples/requests/access_tokens_controller_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - - 'spec/uploaders/object_storage_spec.rb' - - 'spec/validators/any_field_validator_spec.rb' - - 'spec/validators/array_members_validator_spec.rb' - - 'spec/validators/cron_validator_spec.rb' - - 'spec/validators/namespace_path_validator_spec.rb' - - 'spec/validators/project_path_validator_spec.rb' - - 'spec/workers/bulk_imports/entity_worker_spec.rb' - - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - - 'spec/workers/ci/delete_objects_worker_spec.rb' - - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - - 'spec/workers/group_destroy_worker_spec.rb' - - 'spec/workers/hashed_storage/migrator_worker_spec.rb' - - 'spec/workers/hashed_storage/rollbacker_worker_spec.rb' - - 'spec/workers/project_destroy_worker_spec.rb' - - 'spec/workers/remote_mirror_notification_worker_spec.rb' - - 'spec/workers/remove_expired_group_links_worker_spec.rb' - - 'spec/workers/x509_issuer_crl_check_worker_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_body.yml b/.rubocop_todo/rspec/repeated_example_group_body.yml index 6fdeb9a2094..93cbe77765a 100644 --- a/.rubocop_todo/rspec/repeated_example_group_body.yml +++ b/.rubocop_todo/rspec/repeated_example_group_body.yml @@ -43,16 +43,11 @@ RSpec/RepeatedExampleGroupBody: - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/deploy_token_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/merge_request_spec.rb' - 'spec/models/project_spec.rb' - 'spec/policies/project_policy_spec.rb' - - 'spec/presenters/project_hook_presenter_spec.rb' - - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/services/boards/lists/update_service_spec.rb' - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' - 'spec/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service_spec.rb' - - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/mark_reviewer_reviewed_service_spec.rb' - 'spec/services/merge_requests/mergeability/check_base_service_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index 31c17c994a6..826ac2a6838 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -2,10 +2,8 @@ RSpec/RepeatedExampleGroupDescription: Exclude: - 'ee/spec/finders/merge_trains_finder_spec.rb' - - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - 'ee/spec/models/approval_merge_request_rule_spec.rb' @@ -23,16 +21,13 @@ RSpec/RepeatedExampleGroupDescription: - 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb' - 'ee/spec/policies/group_policy_spec.rb' - 'ee/spec/requests/api/graphql/iteration_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' - - 'ee/spec/requests/groups/settings/reporting_controller_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/services/scoped_label_shared_examples.rb' - - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' @@ -61,7 +56,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/data_builder/push_spec.rb' @@ -73,7 +67,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - - 'spec/lib/gitlab/redis/multi_store_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' @@ -83,14 +76,11 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/models/concerns/ci/has_ref_spec.rb' - 'spec/models/concerns/issuable_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - - 'spec/models/merge_request_assignee_spec.rb' - - 'spec/models/merge_request_reviewer_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/models/personal_access_token_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/requests/api/files_spec.rb' - - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - 'spec/requests/api/group_clusters_spec.rb' - 'spec/requests/api/internal/base_spec.rb' @@ -100,8 +90,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/requests/api/users_spec.rb' - 'spec/routing/project_routing_spec.rb' - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' - - 'spec/services/ci/register_job_service_spec.rb' - - 'spec/services/import/github_service_spec.rb' - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 215660f31d3..99da72936c6 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -1,27 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/ReturnFromStub: Exclude: - - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb' - - 'ee/spec/controllers/groups/billings_controller_spec.rb' - - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - - 'ee/spec/controllers/profiles/billings_controller_spec.rb' - - 'ee/spec/controllers/projects/branches_controller_spec.rb' - - 'ee/spec/features/account_recovery_regular_check_spec.rb' - - 'ee/spec/features/admin/groups/admin_changes_plan_spec.rb' - - 'ee/spec/features/burndown_charts_spec.rb' - - 'ee/spec/features/groups/group_settings_spec.rb' - - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' - - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'ee/spec/features/projects/milestones/milestone_spec.rb' - - 'ee/spec/features/projects/new_project_spec.rb' - - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb' - - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/promotion_spec.rb' - - 'ee/spec/features/trials/select_namespace_spec.rb' - - 'ee/spec/graphql/mutations/projects/set_locked_spec.rb' - - 'ee/spec/helpers/application_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/ci/pipelines_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' @@ -37,7 +17,6 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' - - 'ee/spec/lib/ee/gitlab/git_access_project_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' @@ -53,7 +32,6 @@ RSpec/ReturnFromStub: - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/user_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' @@ -92,7 +70,6 @@ RSpec/ReturnFromStub: - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' - 'ee/spec/workers/ee/ci/build_finished_worker_spec.rb' - - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' - 'ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' @@ -122,7 +99,6 @@ RSpec/ReturnFromStub: - 'spec/controllers/projects/merge_requests_controller_spec.rb' - 'spec/controllers/projects/service_desk_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/search_controller_spec.rb' - 'spec/features/groups/clusters/user_spec.rb' - 'spec/features/groups/container_registry_spec.rb' - 'spec/features/markdown/markdown_spec.rb' @@ -163,7 +139,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - - 'spec/lib/gitlab/batch_pop_queueing_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/policy/changes_spec.rb' - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' @@ -180,7 +155,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/external_authorization_spec.rb' - 'spec/lib/gitlab/git/blob_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' @@ -194,7 +168,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' - 'spec/lib/gitlab/metrics/system_spec.rb' - 'spec/lib/gitlab/middleware/read_only_spec.rb' - - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/prometheus_client_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' - 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb' @@ -250,10 +223,8 @@ RSpec/ReturnFromStub: - 'spec/services/captcha/captcha_verification_service_spec.rb' - 'spec/services/ci/archive_trace_service_spec.rb' - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - - 'spec/services/ci/list_config_variables_service_spec.rb' - 'spec/services/ci/pipeline_artifacts/destroy_all_expired_service_spec.rb' - 'spec/services/ci/pipeline_trigger_service_spec.rb' - - 'spec/services/ci/process_build_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb' - 'spec/services/environments/auto_stop_service_spec.rb' @@ -282,7 +253,6 @@ RSpec/ReturnFromStub: - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/redis/redis_shared_examples.rb' @@ -292,7 +262,6 @@ RSpec/ReturnFromStub: - 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - - 'spec/support/shared_examples/models/wiki_shared_examples.rb' - 'spec/support/shared_examples/path_extraction_shared_examples.rb' - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - 'spec/support/shared_examples/services/boards/boards_create_service_shared_examples.rb' @@ -302,7 +271,6 @@ RSpec/ReturnFromStub: - 'spec/uploaders/file_mover_spec.rb' - 'spec/uploaders/gitlab_uploader_spec.rb' - 'spec/uploaders/object_storage_spec.rb' - - 'spec/uploaders/workers/object_storage/background_move_worker_spec.rb' - 'spec/views/admin/application_settings/_ci_cd.html.haml_spec.rb' - 'spec/views/admin/application_settings/_eks.html.haml_spec.rb' - 'spec/views/admin/application_settings/_package_registry.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 9a272ec31cc..9d049dd4a26 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -1,26 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/ScatteredLet: Exclude: - - 'ee/spec/features/boards/user_visits_board_spec.rb' - - 'ee/spec/features/groups/group_roadmap_spec.rb' - - 'ee/spec/features/milestones/user_views_milestone_spec.rb' - - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' - - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - - 'ee/spec/finders/issues_finder_spec.rb' - - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/frontend/fixtures/runner.rb' - - 'ee/spec/graphql/ee/types/clusters/agent_type_spec.rb' - - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - - 'ee/spec/graphql/mutations/merge_requests/accept_spec.rb' - - 'ee/spec/graphql/mutations/releases/update_spec.rb' - - 'ee/spec/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' - - 'ee/spec/graphql/types/asset_type_spec.rb' - - 'ee/spec/graphql/types/boards/board_epic_type_spec.rb' - - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_supporting_message_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' @@ -30,7 +11,6 @@ RSpec/ScatteredLet: - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' @@ -62,7 +42,6 @@ RSpec/ScatteredLet: - 'ee/spec/requests/api/graphql/project/dast_profile_schedule_spec.rb' - 'ee/spec/requests/api/graphql/project/environments_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/dast_profile_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipeline/security_report_finding_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' @@ -83,7 +62,6 @@ RSpec/ScatteredLet: - 'ee/spec/services/ee/issue_links/create_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' @@ -95,12 +73,10 @@ RSpec/ScatteredLet: - 'ee/spec/services/incident_management/oncall_rotations/remove_participant_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb' - - 'ee/spec/services/sbom/ingestion/occurrence_map_spec.rb' - 'ee/spec/services/security/report_summary_service_spec.rb' - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - 'spec/controllers/concerns/metrics_dashboard_spec.rb' - 'spec/controllers/import/bitbucket_server_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' @@ -166,7 +142,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - - 'spec/lib/gitlab/database/migrations/test_batched_background_runner_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb' - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' @@ -205,7 +180,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' - 'spec/lib/peek/views/external_http_spec.rb' @@ -263,8 +237,6 @@ RSpec/ScatteredLet: - 'spec/serializers/ci/job_entity_spec.rb' - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/include_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' diff --git a/.rubocop_todo/rspec/shared_examples.yml b/.rubocop_todo/rspec/shared_examples.yml deleted file mode 100644 index 612692bdb55..00000000000 --- a/.rubocop_todo/rspec/shared_examples.yml +++ /dev/null @@ -1,24 +0,0 @@ ---- -# Cop supports --auto-correct. -RSpec/SharedExamples: - Exclude: - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' - - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' - - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_on_issuable_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' - - 'spec/lib/gitlab/email/receiver_spec.rb' - - 'spec/lib/gitlab/git/tree_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/integrations/drone_ci_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - - 'spec/support/shared_contexts/email_shared_context.rb' diff --git a/.rubocop_todo/rspec/timecop_freeze.yml b/.rubocop_todo/rspec/timecop_freeze.yml deleted file mode 100644 index 2967793e42a..00000000000 --- a/.rubocop_todo/rspec/timecop_freeze.yml +++ /dev/null @@ -1,24 +0,0 @@ ---- -RSpec/TimecopFreeze: - Exclude: - - ee/spec/models/merge_train_spec.rb - - ee/spec/support/shared_contexts/lib/gitlab/insights/reducers/reducers_shared_contexts.rb - - qa/spec/support/repeater_spec.rb - - spec/features/users/active_sessions_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb - - spec/lib/gitlab/auth/unique_ips_limiter_spec.rb - - spec/lib/gitlab/checks/timed_logger_spec.rb - - spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb - - spec/lib/gitlab/puma_logging/json_formatter_spec.rb - - spec/lib/json_web_token/hmac_token_spec.rb - - spec/models/active_session_spec.rb - - spec/serializers/entity_date_helper_spec.rb - - spec/support/cycle_analytics_helpers/test_generation.rb - - spec/support/helpers/cycle_analytics_helpers.rb - - spec/support/helpers/javascript_fixtures_helpers.rb - - spec/support/shared_contexts/rack_attack_shared_context.rb - - spec/support/shared_examples/workers/concerns/reenqueuer_shared_examples.rb - - spec/workers/concerns/reenqueuer_spec.rb - - spec/workers/metrics/dashboard/prune_old_annotations_worker_spec.rb diff --git a/.rubocop_todo/rspec/timecop_travel.yml b/.rubocop_todo/rspec/timecop_travel.yml deleted file mode 100644 index 3a9ebc443fd..00000000000 --- a/.rubocop_todo/rspec/timecop_travel.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -RSpec/TimecopTravel: - Exclude: - - qa/spec/support/repeater_spec.rb diff --git a/.rubocop_todo/rspec/variable_definition.yml b/.rubocop_todo/rspec/variable_definition.yml index 797fa763ba1..187064b9bb4 100644 --- a/.rubocop_todo/rspec/variable_definition.yml +++ b/.rubocop_todo/rspec/variable_definition.yml @@ -1,6 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. RSpec/VariableDefinition: Exclude: - - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index c9f405a8283..8fa03c775be 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -1,1149 +1,1070 @@ --- RSpec/VerifiedDoubles: Exclude: - - ee/spec/controllers/boards/issues_controller_spec.rb - - ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb - - ee/spec/controllers/groups/clusters_controller_spec.rb - - ee/spec/controllers/groups/sso_controller_spec.rb - - ee/spec/controllers/oauth/geo_auth_controller_spec.rb - - ee/spec/controllers/projects/clusters_controller_spec.rb - - ee/spec/db/production/license_spec.rb - - ee/spec/elastic/migrate/20210510113500_delete_merge_requests_from_original_index_spec.rb - - ee/spec/elastic/migrate/20210510143200_delete_notes_from_original_index_spec.rb - - ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb - - ee/spec/features/billings/billing_plans_spec.rb - - ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb - - ee/spec/features/profiles/account_spec.rb - - ee/spec/finders/license_template_finder_spec.rb - - ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb - - ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb - - ee/spec/finders/template_finder_spec.rb - - ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb - - ee/spec/graphql/mutations/dast_scanner_profiles/create_spec.rb - - ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb - - ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb - - ee/spec/graphql/mutations/dast_site_profiles/update_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_rotation/create_spec.rb - - ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb - - ee/spec/graphql/mutations/issues/set_epic_spec.rb - - ee/spec/graphql/mutations/merge_requests/accept_spec.rb - - ee/spec/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb - - ee/spec/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb - - ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb - - ee/spec/graphql/resolvers/external_issue_resolver_spec.rb - - ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb - - ee/spec/graphql/resolvers/vulnerabilities/details_resolver_spec.rb - - ee/spec/graphql/types/network_policy_type_spec.rb - - ee/spec/graphql/types/security/training_type_spec.rb - - ee/spec/helpers/billing_plans_helper_spec.rb - - ee/spec/helpers/ee/ci/runners_helper_spec.rb - - ee/spec/helpers/ee/integrations_helper_spec.rb - - ee/spec/helpers/ee/subscribable_banner_helper_spec.rb - - ee/spec/helpers/ee/trial_helper_spec.rb - - ee/spec/helpers/ee/trial_registration_helper_spec.rb - - ee/spec/helpers/kerberos_helper_spec.rb - - ee/spec/helpers/license_helper_spec.rb - - ee/spec/helpers/roadmaps_helper_spec.rb - - ee/spec/helpers/routing/pseudonymization_helper_spec.rb - - ee/spec/helpers/subscriptions_helper_spec.rb - - ee/spec/helpers/timeboxes_helper_spec.rb - - ee/spec/helpers/vulnerabilities_helper_spec.rb - - ee/spec/lib/ee/backup/repositories_spec.rb - - ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb - - ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb - - ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb - - ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb - - ee/spec/lib/ee/gitlab/etag_caching/router/rails_spec.rb - - ee/spec/lib/ee/gitlab/gon_helper_spec.rb - - ee/spec/lib/elastic/latest/config_shared_examples.rb - - ee/spec/lib/elastic/latest/git_instance_proxy_spec.rb - - ee/spec/lib/elastic/migration_spec.rb - - ee/spec/lib/elastic/multi_version_class_proxy_spec.rb - - ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb - - ee/spec/lib/gitlab/audit/target_spec.rb - - ee/spec/lib/gitlab/auth/group_saml/response_check_spec.rb - - ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb - - ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb - - ee/spec/lib/gitlab/authority_analyzer_spec.rb - - ee/spec/lib/gitlab/cache_spec.rb - - ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb - - ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb - - ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb - - ee/spec/lib/gitlab/code_owners/users_loader_spec.rb - - ee/spec/lib/gitlab/custom_file_templates_spec.rb - - ee/spec/lib/gitlab/elastic/client_spec.rb - - ee/spec/lib/gitlab/elastic/search_results_spec.rb - - ee/spec/lib/gitlab/expiring_subscription_message_spec.rb - - ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb - - ee/spec/lib/gitlab/geo/oauth/logout_token_spec.rb - - ee/spec/lib/gitlab/geo/oauth/session_spec.rb - - ee/spec/lib/gitlab/geo/replicator_spec.rb - - ee/spec/lib/gitlab/geo_spec.rb - - ee/spec/lib/gitlab/git_access_spec.rb - - ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb - - ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb - - ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb - - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb - - ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb - - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb - - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb - - ee/spec/models/concerns/geo/verification_state_spec.rb - - ee/spec/models/ee/ci/job_artifact_spec.rb - - ee/spec/models/ee/user_spec.rb - - ee/spec/models/elastic/index_setting_spec.rb - - ee/spec/models/geo/project_registry_spec.rb - - ee/spec/models/geo/secondary_usage_data_spec.rb - - ee/spec/models/geo_node_status_spec.rb - - ee/spec/models/integrations/github/status_message_spec.rb - - ee/spec/models/integrations/github_spec.rb - - ee/spec/models/project_spec.rb - - ee/spec/models/push_rule_spec.rb - - ee/spec/presenters/audit_event_presenter_spec.rb - - ee/spec/presenters/group_member_presenter_spec.rb - - ee/spec/presenters/merge_request_approver_presenter_spec.rb - - ee/spec/presenters/project_member_presenter_spec.rb - - ee/spec/requests/api/geo_spec.rb - - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb - - ee/spec/requests/api/internal/base_spec.rb - - ee/spec/requests/api/ldap_spec.rb - - ee/spec/requests/api/visual_review_discussions_spec.rb - - ee/spec/requests/api/vulnerability_findings_spec.rb - - ee/spec/requests/callout_spec.rb - - ee/spec/requests/rack_attack_spec.rb - - ee/spec/serializers/blocking_merge_request_entity_spec.rb - - ee/spec/serializers/clusters/environment_entity_spec.rb - - ee/spec/serializers/dashboard_operations_project_entity_spec.rb - - ee/spec/serializers/dependency_entity_spec.rb - - ee/spec/serializers/ee/admin/user_entity_spec.rb - - ee/spec/serializers/ee/build_details_entity_spec.rb - - ee/spec/serializers/ee/ci/job_entity_spec.rb - - ee/spec/serializers/ee/ci/pipeline_entity_spec.rb - - ee/spec/serializers/ee/group_child_entity_spec.rb - - ee/spec/serializers/ee/issue_board_entity_spec.rb - - ee/spec/serializers/ee/issue_entity_spec.rb - - ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb - - ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb - - ee/spec/serializers/ee/note_entity_spec.rb - - ee/spec/serializers/environment_entity_spec.rb - - ee/spec/serializers/epic_entity_spec.rb - - ee/spec/serializers/epic_note_entity_spec.rb - - ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb - - ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb - - ee/spec/serializers/issuable_sidebar_extras_entity_spec.rb - - ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb - - ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb - - ee/spec/serializers/merge_request_poll_widget_entity_spec.rb - - ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb - - ee/spec/serializers/merge_request_widget_entity_spec.rb - - ee/spec/serializers/test_reports_comparer_serializer_spec.rb - - ee/spec/serializers/user_analytics_entity_spec.rb - - ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb - - ee/spec/serializers/vulnerabilities/finding_entity_spec.rb - - ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb - - ee/spec/serializers/vulnerabilities/finding_serializer_spec.rb - - ee/spec/serializers/vulnerability_note_entity_spec.rb - - ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb - - ee/spec/services/app_sec/dast/scans/create_service_spec.rb - - ee/spec/services/app_sec/dast/site_profiles/update_service_spec.rb - - ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb - - ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb - - ee/spec/services/ci/minutes/track_live_consumption_service_spec.rb - - ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb - - ee/spec/services/ci/pipeline_creation/drop_not_runnable_builds_service_spec.rb - - ee/spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb - - ee/spec/services/dashboard/operations/list_service_spec.rb - - ee/spec/services/dashboard/projects/create_service_spec.rb - - ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb - - ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb - - ee/spec/services/ee/issues/create_service_spec.rb - - ee/spec/services/ee/issues/update_service_spec.rb - - ee/spec/services/ee/merge_requests/base_service_spec.rb - - ee/spec/services/ee/merge_requests/post_merge_service_spec.rb - - ee/spec/services/ee/merge_requests/refresh_service_spec.rb - - ee/spec/services/ee/notification_service_spec.rb - - ee/spec/services/ee/post_receive_service_spec.rb - - ee/spec/services/geo/blob_download_service_spec.rb - - ee/spec/services/geo/graphql_request_service_spec.rb - - ee/spec/services/geo/node_status_request_service_spec.rb - - ee/spec/services/geo/replication_toggle_request_service_spec.rb - - ee/spec/services/geo/repository_verification_primary_service_spec.rb - - ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb - - ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb - - ee/spec/services/group_saml/sign_up_service_spec.rb - - ee/spec/services/groups/update_repository_storage_service_spec.rb - - ee/spec/services/ide/schemas_config_service_spec.rb - - ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb - - ee/spec/services/incident_management/pending_escalations/process_service_spec.rb - - ee/spec/services/merge_requests/approval_service_spec.rb - - ee/spec/services/merge_requests/build_service_spec.rb - - ee/spec/services/merge_requests/reset_approvals_service_spec.rb - - ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb - - ee/spec/services/projects/update_mirror_service_spec.rb - - ee/spec/services/projects/update_pages_service_spec.rb - - ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb - - ee/spec/services/security/orchestration/assign_service_spec.rb - - ee/spec/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service_spec.rb - - ee/spec/services/slash_commands/global_slack_handler_spec.rb - - ee/spec/services/status_page/publish_details_service_spec.rb - - ee/spec/services/status_page/publish_service_spec.rb - - ee/spec/services/status_page/trigger_publish_service_spec.rb - - ee/spec/services/system_note_service_spec.rb - - ee/spec/services/vulnerability_exports/export_service_spec.rb - - ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb - - ee/spec/support/helpers/ee/ldap_helpers.rb - - ee/spec/support/prometheus/additional_metrics_shared_examples.rb - - ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb - - ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb - - ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb - - ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb - - ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb - - ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb - - ee/spec/support/shared_examples/services/alert_management/alert_processing/oncall_notifications_shared_examples.rb - - ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb - - ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb - - ee/spec/support/shared_examples/status_page/reference_links_examples.rb - - ee/spec/validators/json_schema_validator_spec.rb - - ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb - - ee/spec/workers/ci/sync_reports_to_report_approval_rules_worker_spec.rb - - ee/spec/workers/geo/container_repository_sync_worker_spec.rb - - ee/spec/workers/compliance_management/chain_of_custody_report_worker_spec.rb - - ee/spec/workers/geo/design_repository_sync_worker_spec.rb - - ee/spec/workers/geo/destroy_worker_spec.rb - - ee/spec/workers/geo/event_worker_spec.rb - - ee/spec/workers/geo/metrics_update_worker_spec.rb - - ee/spec/workers/geo/prune_event_log_worker_spec.rb - - ee/spec/workers/geo/registry_sync_worker_spec.rb - - ee/spec/workers/geo/reverification_batch_worker_spec.rb - - ee/spec/workers/geo/sidekiq_cron_config_worker_spec.rb - - ee/spec/workers/geo/sync_timeout_cron_worker_spec.rb - - ee/spec/workers/geo/verification_batch_worker_spec.rb - - ee/spec/workers/geo/verification_cron_worker_spec.rb - - ee/spec/workers/geo/verification_timeout_worker_spec.rb - - ee/spec/workers/geo/verification_worker_spec.rb - - ee/spec/workers/iterations/cadences/create_iterations_worker_spec.rb - - ee/spec/workers/iterations/roll_over_issues_worker_spec.rb - - ee/spec/workers/ldap_group_sync_worker_spec.rb - - ee/spec/workers/merge_request_reset_approvals_worker_spec.rb - - ee/spec/workers/new_epic_worker_spec.rb - - ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb - - qa/spec/git/repository_spec.rb - - qa/spec/page/base_spec.rb - - qa/spec/page/validator_spec.rb - - qa/spec/page/view_spec.rb - - qa/spec/resource/api_fabricator_spec.rb - - qa/spec/resource/base_spec.rb - - qa/spec/runtime/application_settings_spec.rb - - qa/spec/runtime/feature_spec.rb - - qa/spec/runtime/release_spec.rb - - qa/spec/scenario/template_spec.rb - - qa/spec/scenario/test/integration/github_spec.rb - - qa/spec/scenario/test/sanity/selectors_spec.rb - - qa/spec/specs/allure_report_spec.rb - - qa/spec/support/formatters/allure_metadata_formatter_spec.rb - - qa/spec/support/page_error_checker_spec.rb - - qa/spec/support/run_spec.rb - - qa/spec/tools/long_running_spec_reporter_spec.rb - - spec/benchmarks/banzai_benchmark.rb - - spec/bin/feature_flag_spec.rb - - spec/controllers/admin/clusters_controller_spec.rb - - spec/controllers/application_controller_spec.rb - - spec/controllers/boards/issues_controller_spec.rb - - spec/controllers/boards/lists_controller_spec.rb - - spec/controllers/concerns/checks_collaboration_spec.rb - - spec/controllers/concerns/import_url_params_spec.rb - - spec/controllers/concerns/issuable_actions_spec.rb - - spec/controllers/concerns/issuable_collections_spec.rb - - spec/controllers/concerns/page_limiter_spec.rb - - spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb - - spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb - - spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb - - spec/controllers/dashboard/snippets_controller_spec.rb - - spec/controllers/explore/projects_controller_spec.rb - - spec/controllers/groups/clusters_controller_spec.rb - - spec/controllers/groups/dependency_proxy_auth_controller_spec.rb - - spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb - - spec/controllers/help_controller_spec.rb - - spec/controllers/import/bitbucket_controller_spec.rb - - spec/controllers/import/bitbucket_server_controller_spec.rb - - spec/controllers/import/bulk_imports_controller_spec.rb - - spec/controllers/import/fogbugz_controller_spec.rb - - spec/controllers/import/gitea_controller_spec.rb - - spec/controllers/import/github_controller_spec.rb - - spec/controllers/import/gitlab_controller_spec.rb - - spec/controllers/oauth/jira_dvcs/authorizations_controller_spec.rb - - spec/controllers/omniauth_callbacks_controller_spec.rb - - spec/controllers/profiles/two_factor_auths_controller_spec.rb - - spec/controllers/projects/blob_controller_spec.rb - - spec/controllers/projects/branches_controller_spec.rb - - spec/controllers/projects/clusters_controller_spec.rb - - spec/controllers/projects/import/jira_controller_spec.rb - - spec/controllers/projects/jobs_controller_spec.rb - - spec/controllers/projects/merge_requests/diffs_controller_spec.rb - - spec/controllers/projects/merge_requests_controller_spec.rb - - spec/controllers/projects/notes_controller_spec.rb - - spec/controllers/projects/pages_controller_spec.rb - - spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb - - spec/controllers/projects/pipelines_controller_spec.rb - - spec/controllers/projects/prometheus/metrics_controller_spec.rb - - spec/controllers/projects/registry/tags_controller_spec.rb - - spec/controllers/projects/settings/operations_controller_spec.rb - - spec/controllers/projects/snippets_controller_spec.rb - - spec/controllers/sessions_controller_spec.rb - - spec/dependencies/omniauth_saml_spec.rb - - spec/experiments/concerns/project_commit_count_spec.rb - - spec/factories/ci/job_artifacts.rb - - spec/factories/clusters/applications/helm.rb - - spec/features/admin/admin_system_info_spec.rb - - spec/features/clusters/create_agent_spec.rb - - spec/features/file_uploads/maven_package_spec.rb - - spec/features/groups/container_registry_spec.rb - - spec/features/help_pages_spec.rb - - spec/features/issuables/markdown_references/jira_spec.rb - - spec/features/markdown/markdown_spec.rb - - spec/features/profiles/personal_access_tokens_spec.rb - - spec/features/projects/clusters/gcp_spec.rb - - spec/features/projects/clusters_spec.rb - - spec/features/projects/container_registry_spec.rb - - spec/features/projects/integrations/user_activates_jira_spec.rb - - spec/finders/ci/auth_job_finder_spec.rb - - spec/finders/merge_requests/oldest_per_commit_finder_spec.rb - - spec/finders/repositories/changelog_commits_finder_spec.rb - - spec/finders/repositories/changelog_tag_finder_spec.rb - - spec/graphql/features/authorization_spec.rb - - spec/graphql/features/feature_flag_spec.rb - - spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb - - spec/graphql/mutations/alert_management/update_alert_status_spec.rb - - spec/graphql/mutations/branches/create_spec.rb - - spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb - - spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb - - spec/graphql/mutations/concerns/mutations/finds_by_gid_spec.rb - - spec/graphql/mutations/design_management/upload_spec.rb - - spec/graphql/mutations/environments/canary_ingress/update_spec.rb - - spec/graphql/mutations/merge_requests/accept_spec.rb - - spec/graphql/mutations/merge_requests/create_spec.rb - - spec/graphql/resolvers/design_management/versions_resolver_spec.rb - - spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb - - spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb - - spec/graphql/types/ci/detailed_status_type_spec.rb - - spec/graphql/types/ci/status_action_type_spec.rb - - spec/graphql/types/kas/agent_connection_type_spec.rb - - spec/graphql/types/permission_types/base_permission_type_spec.rb - - spec/graphql/types/project_type_spec.rb - - spec/graphql/types/range_input_type_spec.rb - - spec/helpers/blame_helper_spec.rb - - spec/helpers/blob_helper_spec.rb - - spec/helpers/ci/pipelines_helper_spec.rb - - spec/helpers/ci/status_helper_spec.rb - - spec/helpers/ci/triggers_helper_spec.rb - - spec/helpers/commits_helper_spec.rb - - spec/helpers/dev_ops_report_helper_spec.rb - - spec/helpers/diff_helper_spec.rb - - spec/helpers/emails_helper_spec.rb - - spec/helpers/environments_helper_spec.rb - - spec/helpers/form_helper_spec.rb - - spec/helpers/gitlab_routing_helper_spec.rb - - spec/helpers/integrations_helper_spec.rb - - spec/helpers/issuables_helper_spec.rb - - spec/helpers/markup_helper_spec.rb - - spec/helpers/merge_requests_helper_spec.rb - - spec/helpers/notes_helper_spec.rb - - spec/helpers/numbers_helper_spec.rb - - spec/helpers/preferences_helper_spec.rb - - spec/helpers/projects_helper_spec.rb - - spec/helpers/routing/pseudonymization_helper_spec.rb - - spec/helpers/sorting_helper_spec.rb - - spec/helpers/submodule_helper_spec.rb - - spec/helpers/todos_helper_spec.rb - - spec/helpers/tree_helper_spec.rb - - spec/helpers/version_check_helper_spec.rb - - spec/initializers/doorkeeper_spec.rb - - spec/initializers/global_id_spec.rb - - spec/initializers/hangouts_chat_http_override_spec.rb - - spec/lib/api/base_spec.rb - - spec/lib/api/entities/ci/job_request/image_spec.rb - - spec/lib/api/entities/ci/job_request/port_spec.rb - - spec/lib/api/helpers/authentication_spec.rb - - spec/lib/api/helpers/caching_spec.rb - - spec/lib/api/helpers/graphql_helpers_spec.rb - - spec/lib/api/helpers/pagination_spec.rb - - spec/lib/api/helpers/pagination_strategies_spec.rb - - spec/lib/api/helpers/variables_helpers_spec.rb - - spec/lib/api/helpers_spec.rb - - spec/lib/atlassian/jira_connect/client_spec.rb - - spec/lib/backup/files_spec.rb - - spec/lib/backup/repositories_spec.rb - - spec/lib/banzai/cross_project_reference_spec.rb - - spec/lib/banzai/filter/gollum_tags_filter_spec.rb - - spec/lib/banzai/filter/repository_link_filter_spec.rb - - spec/lib/banzai/pipeline/wiki_pipeline_spec.rb - - spec/lib/banzai/querying_spec.rb - - spec/lib/banzai/reference_parser/base_parser_spec.rb - - spec/lib/banzai/reference_parser/commit_parser_spec.rb - - spec/lib/banzai/reference_parser/commit_range_parser_spec.rb - - spec/lib/banzai/render_context_spec.rb - - spec/lib/banzai/renderer_spec.rb - - spec/lib/bitbucket/connection_spec.rb - - spec/lib/bitbucket/paginator_spec.rb - - spec/lib/bitbucket_server/paginator_spec.rb - - spec/lib/bulk_imports/clients/http_spec.rb - - spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb - - spec/lib/bulk_imports/common/extractors/rest_extractor_spec.rb - - spec/lib/bulk_imports/ndjson_pipeline_spec.rb - - spec/lib/bulk_imports/network_error_spec.rb - - spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb - - spec/lib/bulk_imports/projects/transformers/project_attributes_transformer_spec.rb - - spec/lib/constraints/admin_constrainer_spec.rb - - spec/lib/constraints/group_url_constrainer_spec.rb - - spec/lib/constraints/jira_encoded_url_constrainer_spec.rb - - spec/lib/constraints/project_url_constrainer_spec.rb - - spec/lib/constraints/user_url_constrainer_spec.rb - - spec/lib/csv_builder_spec.rb - - spec/lib/csv_builders/stream_spec.rb - - spec/lib/extracts_path_spec.rb - - spec/lib/feature_spec.rb - - spec/lib/gitaly/server_spec.rb - - spec/lib/gitlab/api_authentication/token_locator_spec.rb - - spec/lib/gitlab/application_context_spec.rb - - spec/lib/gitlab/application_rate_limiter_spec.rb - - spec/lib/gitlab/asciidoc/include_processor_spec.rb - - spec/lib/gitlab/auth/auth_finders_spec.rb - - spec/lib/gitlab/auth/blocked_user_tracker_spec.rb - - spec/lib/gitlab/auth/ldap/adapter_spec.rb - - spec/lib/gitlab/auth/ldap/authentication_spec.rb - - spec/lib/gitlab/authorized_keys_spec.rb - - spec/lib/gitlab/avatar_cache_spec.rb - - spec/lib/gitlab/background_migration/base_job_spec.rb - - spec/lib/gitlab/background_migration/batching_strategies/base_strategy_spec.rb - - spec/lib/gitlab/background_migration/fix_merge_request_diff_commit_users_spec.rb - - spec/lib/gitlab/background_migration/job_coordinator_spec.rb - - spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb - - spec/lib/gitlab/background_migration_spec.rb - - spec/lib/gitlab/bitbucket_import/importer_spec.rb - - spec/lib/gitlab/bitbucket_import/project_creator_spec.rb - - spec/lib/gitlab/bitbucket_server_import/importer_spec.rb - - spec/lib/gitlab/cache/import/caching_spec.rb - - spec/lib/gitlab/changelog/committer_spec.rb - - spec/lib/gitlab/chat/responder/base_spec.rb - - spec/lib/gitlab/chat/responder_spec.rb - - spec/lib/gitlab/ci/badge/coverage/metadata_spec.rb - - spec/lib/gitlab/ci/badge/coverage/template_spec.rb - - spec/lib/gitlab/ci/badge/pipeline/metadata_spec.rb - - spec/lib/gitlab/ci/badge/pipeline/template_spec.rb - - spec/lib/gitlab/ci/build/cache_spec.rb - - spec/lib/gitlab/ci/build/policy/changes_spec.rb - - spec/lib/gitlab/ci/build/policy/variables_spec.rb - - spec/lib/gitlab/ci/build/policy_spec.rb - - spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb - - spec/lib/gitlab/ci/build/rules/rule_spec.rb - - spec/lib/gitlab/ci/build/rules_spec.rb - - spec/lib/gitlab/ci/build/status/reason_spec.rb - - spec/lib/gitlab/ci/config/entry/default_spec.rb - - spec/lib/gitlab/ci/config/entry/job_spec.rb - - spec/lib/gitlab/ci/config/entry/processable_spec.rb - - spec/lib/gitlab/ci/config/external/context_spec.rb - - spec/lib/gitlab/ci/config/external/file/local_spec.rb - - spec/lib/gitlab/ci/config/external/file/project_spec.rb - - spec/lib/gitlab/ci/config/external/rules_spec.rb - - spec/lib/gitlab/ci/parsers/test/junit_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/evaluate_workflow_rules_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/remove_unwanted_chat_jobs_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/sequence_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/skip_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb - - spec/lib/gitlab/ci/pipeline/expression/lexeme/and_spec.rb - - spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb - - spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb - - spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb - - spec/lib/gitlab/ci/pipeline/expression/lexeme/not_matches_spec.rb - - spec/lib/gitlab/ci/pipeline/expression/lexeme/or_spec.rb - - spec/lib/gitlab/ci/pipeline/preloader_spec.rb - - spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb - - spec/lib/gitlab/ci/pipeline/seed/build_spec.rb - - spec/lib/gitlab/ci/reports/security/report_spec.rb - - spec/lib/gitlab/ci/status/build/action_spec.rb - - spec/lib/gitlab/ci/status/build/cancelable_spec.rb - - spec/lib/gitlab/ci/status/build/canceled_spec.rb - - spec/lib/gitlab/ci/status/build/created_spec.rb - - spec/lib/gitlab/ci/status/build/erased_spec.rb - - spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb - - spec/lib/gitlab/ci/status/build/failed_spec.rb - - spec/lib/gitlab/ci/status/build/pending_spec.rb - - spec/lib/gitlab/ci/status/build/preparing_spec.rb - - spec/lib/gitlab/ci/status/build/retried_spec.rb - - spec/lib/gitlab/ci/status/build/retryable_spec.rb - - spec/lib/gitlab/ci/status/build/skipped_spec.rb - - spec/lib/gitlab/ci/status/build/stop_spec.rb - - spec/lib/gitlab/ci/status/build/unschedule_spec.rb - - spec/lib/gitlab/ci/status/canceled_spec.rb - - spec/lib/gitlab/ci/status/core_spec.rb - - spec/lib/gitlab/ci/status/created_spec.rb - - spec/lib/gitlab/ci/status/factory_spec.rb - - spec/lib/gitlab/ci/status/failed_spec.rb - - spec/lib/gitlab/ci/status/manual_spec.rb - - spec/lib/gitlab/ci/status/pending_spec.rb - - spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb - - spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb - - spec/lib/gitlab/ci/status/preparing_spec.rb - - spec/lib/gitlab/ci/status/running_spec.rb - - spec/lib/gitlab/ci/status/scheduled_spec.rb - - spec/lib/gitlab/ci/status/skipped_spec.rb - - spec/lib/gitlab/ci/status/stage/play_manual_spec.rb - - spec/lib/gitlab/ci/status/success_spec.rb - - spec/lib/gitlab/ci/status/success_warning_spec.rb - - spec/lib/gitlab/ci/status/waiting_for_resource_spec.rb - - spec/lib/gitlab/ci/trace/archive_spec.rb - - spec/lib/gitlab/ci/trace/remote_checksum_spec.rb - - spec/lib/gitlab/ci/trace/stream_spec.rb - - spec/lib/gitlab/ci/variables/builder_spec.rb - - spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb - - spec/lib/gitlab/cleanup/project_uploads_spec.rb - - spec/lib/gitlab/cleanup/remote_uploads_spec.rb - - spec/lib/gitlab/cluster/puma_worker_killer_observer_spec.rb - - spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb - - spec/lib/gitlab/color_schemes_spec.rb - - spec/lib/gitlab/conan_token_spec.rb - - spec/lib/gitlab/config/entry/configurable_spec.rb - - spec/lib/gitlab/config/entry/factory_spec.rb - - spec/lib/gitlab/config/entry/simplifiable_spec.rb - - spec/lib/gitlab/config/entry/unspecified_spec.rb - - spec/lib/gitlab/config/entry/validator_spec.rb - - spec/lib/gitlab/conflict/file_spec.rb - - spec/lib/gitlab/cross_project_access/check_collection_spec.rb - - spec/lib/gitlab/database/async_indexes_spec.rb - - spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb - - spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb - - spec/lib/gitlab/database/batch_count_spec.rb - - spec/lib/gitlab/database/count_spec.rb - - spec/lib/gitlab/database/each_database_spec.rb - - spec/lib/gitlab/database/load_balancing/configuration_spec.rb - - spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb - - spec/lib/gitlab/database/load_balancing/host_list_spec.rb - - spec/lib/gitlab/database/load_balancing/host_spec.rb - - spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb - - spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb - - spec/lib/gitlab/database/load_balancing/resolver_spec.rb - - spec/lib/gitlab/database/load_balancing/service_discovery_spec.rb - - spec/lib/gitlab/database/load_balancing/setup_spec.rb - - spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb - - spec/lib/gitlab/database/load_balancing_spec.rb - - spec/lib/gitlab/database/migration_helpers_spec.rb - - spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb - - spec/lib/gitlab/database/migrations/instrumentation_spec.rb - - spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb - - spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb - - spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb - - spec/lib/gitlab/database/migrations/runner_spec.rb - - spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb - - spec/lib/gitlab/database/partitioning/partition_manager_spec.rb - - spec/lib/gitlab/database/partitioning/partition_monitoring_spec.rb - - spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb - - spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb - - spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb - - spec/lib/gitlab/database/partitioning_spec.rb - - spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb - - spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb - - spec/lib/gitlab/database/query_analyzer_spec.rb - - spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb - - spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb - - spec/lib/gitlab/database/shared_model_spec.rb - - spec/lib/gitlab/database_spec.rb - - spec/lib/gitlab/diff/file_collection_sorter_spec.rb - - spec/lib/gitlab/diff/file_spec.rb - - spec/lib/gitlab/diff/line_spec.rb - - spec/lib/gitlab/diff/position_tracer_spec.rb - - spec/lib/gitlab/doctor/secrets_spec.rb - - spec/lib/gitlab/email/handler/service_desk_handler_spec.rb - - spec/lib/gitlab/email/receiver_spec.rb - - spec/lib/gitlab/email/service_desk_receiver_spec.rb - - spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb - - spec/lib/gitlab/error_tracking_spec.rb - - spec/lib/gitlab/etag_caching/middleware_spec.rb - - spec/lib/gitlab/etag_caching/router/graphql_spec.rb - - spec/lib/gitlab/etag_caching/router/rails_spec.rb - - spec/lib/gitlab/etag_caching/router_spec.rb - - spec/lib/gitlab/event_store/store_spec.rb - - spec/lib/gitlab/experiment/rollout/feature_spec.rb - - spec/lib/gitlab/experimentation/controller_concern_spec.rb - - spec/lib/gitlab/experimentation/experiment_spec.rb - - spec/lib/gitlab/experimentation_spec.rb - - spec/lib/gitlab/external_authorization/access_spec.rb - - spec/lib/gitlab/external_authorization/logger_spec.rb - - spec/lib/gitlab/faraday/error_callback_spec.rb - - spec/lib/gitlab/feature_categories_spec.rb - - spec/lib/gitlab/git/blob_spec.rb - - spec/lib/gitlab/git/commit_spec.rb - - spec/lib/gitlab/git/repository_spec.rb - - spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb - - spec/lib/gitlab/git/tag_spec.rb - - spec/lib/gitlab/git_access_snippet_spec.rb - - spec/lib/gitlab/gitaly_client/commit_service_spec.rb - - spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb - - spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb - - spec/lib/gitlab/gitaly_client/health_check_service_spec.rb - - spec/lib/gitlab/gitaly_client/ref_service_spec.rb - - spec/lib/gitlab/gitaly_client/remote_service_spec.rb - - spec/lib/gitlab/gitaly_client/repository_service_spec.rb - - spec/lib/gitlab/gitaly_client_spec.rb - - spec/lib/gitlab/github_import/bulk_importing_spec.rb - - spec/lib/gitlab/github_import/client_spec.rb - - spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb - - spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb - - spec/lib/gitlab/github_import/importer/issue_and_label_links_importer_spec.rb - - spec/lib/gitlab/github_import/importer/issue_importer_spec.rb - - spec/lib/gitlab/github_import/importer/issues_importer_spec.rb - - spec/lib/gitlab/github_import/importer/label_links_importer_spec.rb - - spec/lib/gitlab/github_import/importer/labels_importer_spec.rb - - spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb - - spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb - - spec/lib/gitlab/github_import/importer/note_importer_spec.rb - - spec/lib/gitlab/github_import/importer/notes_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_requests_merged_by_importer_spec.rb - - spec/lib/gitlab/github_import/importer/pull_requests_reviews_importer_spec.rb - - spec/lib/gitlab/github_import/importer/releases_importer_spec.rb - - spec/lib/gitlab/github_import/importer/repository_importer_spec.rb - - spec/lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer_spec.rb - - spec/lib/gitlab/github_import/importer/single_endpoint_issue_notes_importer_spec.rb - - spec/lib/gitlab/github_import/importer/single_endpoint_merge_request_notes_importer_spec.rb - - spec/lib/gitlab/github_import/issuable_finder_spec.rb - - spec/lib/gitlab/github_import/markdown_text_spec.rb - - spec/lib/gitlab/github_import/milestone_finder_spec.rb - - spec/lib/gitlab/github_import/object_counter_spec.rb - - spec/lib/gitlab/github_import/page_counter_spec.rb - - spec/lib/gitlab/github_import/parallel_importer_spec.rb - - spec/lib/gitlab/github_import/parallel_scheduling_spec.rb - - spec/lib/gitlab/github_import/representation/diff_note_spec.rb - - spec/lib/gitlab/github_import/representation/issue_spec.rb - - spec/lib/gitlab/github_import/representation/note_spec.rb - - spec/lib/gitlab/github_import/representation/pull_request_review_spec.rb - - spec/lib/gitlab/github_import/representation/pull_request_spec.rb - - spec/lib/gitlab/github_import/representation/to_hash_spec.rb - - spec/lib/gitlab/github_import/representation/user_spec.rb - - spec/lib/gitlab/github_import/sequential_importer_spec.rb - - spec/lib/gitlab/github_import/user_finder_spec.rb - - spec/lib/gitlab/github_import_spec.rb - - spec/lib/gitlab/gon_helper_spec.rb - - spec/lib/gitlab/gpg/commit_spec.rb - - spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb - - spec/lib/gitlab/gpg_spec.rb - - spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb - - spec/lib/gitlab/grape_logging/loggers/perf_logger_spec.rb - - spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb - - spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb - - spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb - - spec/lib/gitlab/graphql/batch_key_spec.rb - - spec/lib/gitlab/graphql/generic_tracing_spec.rb - - spec/lib/gitlab/graphql/lazy_spec.rb - - spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb - - spec/lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition_spec.rb - - spec/lib/gitlab/graphql/pagination/keyset/conditions/null_condition_spec.rb - - spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb - - spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb - - spec/lib/gitlab/graphql/present/field_extension_spec.rb - - spec/lib/gitlab/graphql/timeout_spec.rb - - spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb - - spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb - - spec/lib/gitlab/health_checks/gitaly_check_spec.rb - - spec/lib/gitlab/hook_data/base_builder_spec.rb - - spec/lib/gitlab/hotlinking_detector_spec.rb - - spec/lib/gitlab/import/import_failure_service_spec.rb - - spec/lib/gitlab/import/metrics_spec.rb - - spec/lib/gitlab/import_export/attribute_cleaner_spec.rb - - spec/lib/gitlab/import_export/base/relation_factory_spec.rb - - spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb - - spec/lib/gitlab/import_export/group/relation_factory_spec.rb - - spec/lib/gitlab/import_export/importer_spec.rb - - spec/lib/gitlab/import_export/project/relation_factory_spec.rb - - spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb - - spec/lib/gitlab/import_export/project/tree_saver_spec.rb - - spec/lib/gitlab/issuables_count_for_state_spec.rb - - spec/lib/gitlab/issues/rebalancing/state_spec.rb - - spec/lib/gitlab/jira/middleware_spec.rb - - spec/lib/gitlab/jira_import/issue_serializer_spec.rb - - spec/lib/gitlab/jira_import/labels_importer_spec.rb - - spec/lib/gitlab/jira_import/metadata_collector_spec.rb - - spec/lib/gitlab/jira_import_spec.rb - - spec/lib/gitlab/job_waiter_spec.rb - - spec/lib/gitlab/json_cache_spec.rb - - spec/lib/gitlab/kas/client_spec.rb - - spec/lib/gitlab/kubernetes/config_map_spec.rb - - spec/lib/gitlab/kubernetes/default_namespace_spec.rb - - spec/lib/gitlab/kubernetes/helm/api_spec.rb - - spec/lib/gitlab/kubernetes/namespace_spec.rb - - spec/lib/gitlab/lazy_spec.rb - - spec/lib/gitlab/legacy_github_import/branch_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/comment_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/importer_spec.rb - - spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/release_formatter_spec.rb - - spec/lib/gitlab/legacy_github_import/user_formatter_spec.rb - - spec/lib/gitlab/lets_encrypt/client_spec.rb - - spec/lib/gitlab/mail_room/mail_room_spec.rb - - spec/lib/gitlab/manifest_import/metadata_spec.rb - - spec/lib/gitlab/markdown_cache/field_data_spec.rb - - spec/lib/gitlab/merge_requests/commit_message_generator_spec.rb - - spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb - - spec/lib/gitlab/metrics/boot_time_tracker_spec.rb - - spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb - - spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb - - spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb - - spec/lib/gitlab/metrics/exporter/gc_request_middleware_spec.rb - - spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb - - spec/lib/gitlab/metrics/rack_middleware_spec.rb - - spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb - - spec/lib/gitlab/metrics/samplers/database_sampler_spec.rb - - spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb - - spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb - - spec/lib/gitlab/metrics/sli_spec.rb - - spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb - - spec/lib/gitlab/metrics/subscribers/action_view_spec.rb - - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb - - spec/lib/gitlab/metrics/subscribers/external_http_spec.rb - - spec/lib/gitlab/metrics/subscribers/load_balancing_spec.rb - - spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb - - spec/lib/gitlab/metrics/subscribers/rails_cache_spec.rb - - spec/lib/gitlab/metrics/web_transaction_spec.rb - - spec/lib/gitlab/middleware/basic_health_check_spec.rb - - spec/lib/gitlab/middleware/compressed_json_spec.rb - - spec/lib/gitlab/middleware/go_spec.rb - - spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb - - spec/lib/gitlab/middleware/multipart_spec.rb - - spec/lib/gitlab/middleware/query_analyzer_spec.rb - - spec/lib/gitlab/middleware/rails_queue_duration_spec.rb - - spec/lib/gitlab/middleware/release_env_spec.rb - - spec/lib/gitlab/middleware/sidekiq_web_static_spec.rb - - spec/lib/gitlab/middleware/speedscope_spec.rb - - spec/lib/gitlab/middleware/webhook_recursion_detection_spec.rb - - spec/lib/gitlab/octokit/middleware_spec.rb - - spec/lib/gitlab/optimistic_locking_spec.rb - - spec/lib/gitlab/pages/settings_spec.rb - - spec/lib/gitlab/pagination/cursor_based_keyset_spec.rb - - spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb - - spec/lib/gitlab/pagination/keyset/cursor_based_request_context_spec.rb - - spec/lib/gitlab/pagination/keyset/cursor_pager_spec.rb - - spec/lib/gitlab/pagination/keyset/pager_spec.rb - - spec/lib/gitlab/pagination/keyset/request_context_spec.rb - - spec/lib/gitlab/pagination/keyset_spec.rb - - spec/lib/gitlab/pagination/offset_header_builder_spec.rb - - spec/lib/gitlab/pagination/offset_pagination_spec.rb - - spec/lib/gitlab/performance_bar/stats_spec.rb - - spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb - - spec/lib/gitlab/phabricator_import/conduit/response_spec.rb - - spec/lib/gitlab/phabricator_import/conduit/user_spec.rb - - spec/lib/gitlab/polling_interval_spec.rb - - spec/lib/gitlab/popen/runner_spec.rb - - spec/lib/gitlab/process_management_spec.rb - - spec/lib/gitlab/profiler_spec.rb - - spec/lib/gitlab/prometheus/adapter_spec.rb - - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - - spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb - - spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb - - spec/lib/gitlab/query_limiting/middleware_spec.rb - - spec/lib/gitlab/quick_actions/dsl_spec.rb - - spec/lib/gitlab/repository_cache_spec.rb - - spec/lib/gitlab/routing_spec.rb - - spec/lib/gitlab/runtime_spec.rb - - spec/lib/gitlab/sanitizers/svg_spec.rb - - spec/lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator_spec.rb - - spec/lib/gitlab/search/abuse_validators/no_abusive_term_length_validator_spec.rb - - spec/lib/gitlab/serializer/pagination_spec.rb - - spec/lib/gitlab/sidekiq_config/cli_methods_spec.rb - - spec/lib/gitlab/sidekiq_config/worker_spec.rb - - spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb - - spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb - - spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb - - spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb - - spec/lib/gitlab/sidekiq_middleware_spec.rb - - spec/lib/gitlab/sidekiq_status/client_middleware_spec.rb - - spec/lib/gitlab/sidekiq_status/server_middleware_spec.rb - - spec/lib/gitlab/slash_commands/command_spec.rb - - spec/lib/gitlab/slash_commands/deploy_spec.rb - - spec/lib/gitlab/slash_commands/issue_close_spec.rb - - spec/lib/gitlab/slash_commands/issue_comment_spec.rb - - spec/lib/gitlab/slash_commands/issue_new_spec.rb - - spec/lib/gitlab/slash_commands/issue_search_spec.rb - - spec/lib/gitlab/slash_commands/issue_show_spec.rb - - spec/lib/gitlab/slash_commands/presenters/run_spec.rb - - spec/lib/gitlab/slash_commands/run_spec.rb - - spec/lib/gitlab/spamcheck/client_spec.rb - - spec/lib/gitlab/submodule_links_spec.rb - - spec/lib/gitlab/suggestions/file_suggestion_spec.rb - - spec/lib/gitlab/tab_width_spec.rb - - spec/lib/gitlab/themes_spec.rb - - spec/lib/gitlab/tracking_spec.rb - - spec/lib/gitlab/usage/metric_spec.rb - - spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb - - spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb - - spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb - - spec/lib/gitlab/usage_data_spec.rb - - spec/lib/gitlab/utils/usage_data_spec.rb - - spec/lib/gitlab/verify/job_artifacts_spec.rb - - spec/lib/gitlab/verify/lfs_objects_spec.rb - - spec/lib/gitlab/verify/uploads_spec.rb - - spec/lib/gitlab/view/presenter/base_spec.rb - - spec/lib/gitlab/view/presenter/delegated_spec.rb - - spec/lib/gitlab/view/presenter/simple_spec.rb - - spec/lib/gitlab/workhorse_spec.rb - - spec/lib/gitlab_edition_spec.rb - - spec/lib/gitlab_spec.rb - - spec/lib/google_api/cloud_platform/client_spec.rb - - spec/lib/peek/views/active_record_spec.rb - - spec/lib/peek/views/bullet_detailed_spec.rb - - spec/lib/peek/views/external_http_spec.rb - - spec/lib/safe_zip/entry_spec.rb - - spec/lib/serializers/unsafe_json_spec.rb - - spec/lib/sidebars/projects/menus/analytics_menu_spec.rb - - spec/mailers/emails/service_desk_spec.rb - - spec/mailers/notify_spec.rb - - spec/metrics_server/metrics_server_spec.rb - - spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb - - spec/models/active_session_spec.rb - - spec/models/application_record_spec.rb - - spec/models/badge_spec.rb - - spec/models/badges/project_badge_spec.rb - - spec/models/ci/build_spec.rb - - spec/models/ci/build_trace_chunk_spec.rb - - spec/models/ci/commit_with_pipeline_spec.rb - - spec/models/ci/group_spec.rb - - spec/models/ci/pipeline_spec.rb - - spec/models/clusters/applications/runner_spec.rb - - spec/models/clusters/cluster_spec.rb - - spec/models/clusters/platforms/kubernetes_spec.rb - - spec/models/commit_signatures/gpg_signature_spec.rb - - spec/models/commit_spec.rb - - spec/models/commit_status_spec.rb - - spec/models/concerns/atomic_internal_id_spec.rb - - spec/models/concerns/legacy_bulk_insert_spec.rb - - spec/models/concerns/prometheus_adapter_spec.rb - - spec/models/concerns/sha_attribute_spec.rb - - spec/models/concerns/token_authenticatable_strategies/base_spec.rb - - spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb - - spec/models/concerns/triggerable_hooks_spec.rb - - spec/models/concerns/x509_serial_number_attribute_spec.rb - - spec/models/design_management/design_action_spec.rb - - spec/models/design_management/design_at_version_spec.rb - - spec/models/diff_viewer/image_spec.rb - - spec/models/environment_spec.rb - - spec/models/event_spec.rb - - spec/models/external_issue_spec.rb - - spec/models/hooks/web_hook_spec.rb - - spec/models/integrations/asana_spec.rb - - spec/models/integrations/chat_message/pipeline_message_spec.rb - - spec/models/integrations/jira_spec.rb - - spec/models/integrations/microsoft_teams_spec.rb - - spec/models/integrations/pipelines_email_spec.rb - - spec/models/issue_spec.rb - - spec/models/key_spec.rb - - spec/models/merge_request_diff_commit_spec.rb - - spec/models/merge_request_spec.rb - - spec/models/packages/package_spec.rb - - spec/models/plan_limits_spec.rb - - spec/models/project_import_state_spec.rb - - spec/models/project_spec.rb - - spec/models/ref_matcher_spec.rb - - spec/models/release_highlight_spec.rb - - spec/models/repository_spec.rb - - spec/models/shard_spec.rb - - spec/models/snippet_spec.rb - - spec/models/ssh_host_key_spec.rb - - spec/models/upload_spec.rb - - spec/models/user_spec.rb - - spec/policies/ci/bridge_policy_spec.rb - - spec/presenters/ci/build_presenter_spec.rb - - spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb - - spec/presenters/group_member_presenter_spec.rb - - spec/presenters/merge_request_presenter_spec.rb - - spec/presenters/packages/nuget/search_results_presenter_spec.rb - - spec/presenters/project_member_presenter_spec.rb - - spec/presenters/project_presenter_spec.rb - - spec/requests/api/avatar_spec.rb - - spec/requests/api/container_registry_event_spec.rb - - spec/requests/api/graphql/mutations/design_management/delete_spec.rb - - spec/requests/api/graphql/mutations/snippets/create_spec.rb - - spec/requests/api/graphql/project/cluster_agents_spec.rb - - spec/requests/api/graphql/project/pipeline_spec.rb - - spec/requests/api/helpers_spec.rb - - spec/requests/api/import_bitbucket_server_spec.rb - - spec/requests/api/import_github_spec.rb - - spec/requests/api/internal/base_spec.rb - - spec/requests/api/maven_packages_spec.rb - - spec/requests/api/project_container_repositories_spec.rb - - spec/requests/api/users_preferences_spec.rb - - spec/requests/jwt_controller_spec.rb - - spec/requests/whats_new_controller_spec.rb - - spec/rubocop/migration_helpers_spec.rb - - spec/scripts/setup/find_jh_branch_spec.rb - - spec/serializers/accessibility_reports_comparer_serializer_spec.rb - - spec/serializers/admin/user_entity_spec.rb - - spec/serializers/base_discussion_entity_spec.rb - - spec/serializers/build_action_entity_spec.rb - - spec/serializers/build_details_entity_spec.rb - - spec/serializers/build_trace_entity_spec.rb - - spec/serializers/ci/dag_job_entity_spec.rb - - spec/serializers/ci/dag_job_group_entity_spec.rb - - spec/serializers/ci/dag_pipeline_entity_spec.rb - - spec/serializers/ci/dag_stage_entity_spec.rb - - spec/serializers/ci/daily_build_group_report_result_entity_spec.rb - - spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb - - spec/serializers/ci/job_entity_spec.rb - - spec/serializers/ci/job_serializer_spec.rb - - spec/serializers/ci/pipeline_entity_spec.rb - - spec/serializers/codequality_reports_comparer_serializer_spec.rb - - spec/serializers/commit_entity_spec.rb - - spec/serializers/container_repositories_serializer_spec.rb - - spec/serializers/container_repository_entity_spec.rb - - spec/serializers/container_tag_entity_spec.rb - - spec/serializers/deployment_cluster_entity_spec.rb - - spec/serializers/deployment_entity_spec.rb - - spec/serializers/detailed_status_entity_spec.rb - - spec/serializers/diff_file_entity_spec.rb - - spec/serializers/diffs_entity_spec.rb - - spec/serializers/diffs_metadata_entity_spec.rb - - spec/serializers/discussion_entity_spec.rb - - spec/serializers/environment_entity_spec.rb - - spec/serializers/environment_serializer_spec.rb - - spec/serializers/environment_status_entity_spec.rb - - spec/serializers/feature_flag_entity_spec.rb - - spec/serializers/feature_flag_summary_entity_spec.rb - - spec/serializers/group_child_entity_spec.rb - - spec/serializers/group_child_serializer_spec.rb - - spec/serializers/import/manifest_provider_repo_entity_spec.rb - - spec/serializers/issuable_sidebar_extras_entity_spec.rb - - spec/serializers/issue_board_entity_spec.rb - - spec/serializers/issue_entity_spec.rb - - spec/serializers/lfs_file_lock_entity_spec.rb - - spec/serializers/linked_project_issue_entity_spec.rb - - spec/serializers/merge_request_poll_cached_widget_entity_spec.rb - - spec/serializers/merge_request_poll_widget_entity_spec.rb - - spec/serializers/merge_request_sidebar_basic_entity_spec.rb - - spec/serializers/merge_request_sidebar_extras_entity_spec.rb - - spec/serializers/merge_request_widget_commit_entity_spec.rb - - spec/serializers/merge_request_widget_entity_spec.rb - - spec/serializers/merge_requests/pipeline_entity_spec.rb - - spec/serializers/note_entity_spec.rb - - spec/serializers/paginated_diff_entity_spec.rb - - spec/serializers/pipeline_details_entity_spec.rb - - spec/serializers/pipeline_serializer_spec.rb - - spec/serializers/project_note_entity_spec.rb - - spec/serializers/prometheus_alert_entity_spec.rb - - spec/serializers/review_app_setup_entity_spec.rb - - spec/serializers/runner_entity_spec.rb - - spec/serializers/stage_entity_spec.rb - - spec/serializers/suggestion_entity_spec.rb - - spec/serializers/test_reports_comparer_serializer_spec.rb - - spec/serializers/test_suite_entity_spec.rb - - spec/serializers/trigger_variable_entity_spec.rb - - spec/services/access_token_validation_service_spec.rb - - spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb - - spec/services/award_emojis/toggle_service_spec.rb - - spec/services/base_count_service_spec.rb - - spec/services/bulk_imports/file_download_service_spec.rb - - spec/services/ci/change_variables_service_spec.rb - - spec/services/ci/create_pipeline_service_spec.rb - - spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb - - spec/services/ci/prepare_build_service_spec.rb - - spec/services/ci/process_pipeline_service_spec.rb - - spec/services/ci/register_job_service_spec.rb - - spec/services/ci/test_failure_history_service_spec.rb - - spec/services/ci/update_build_queue_service_spec.rb - - spec/services/ci/update_build_state_service_spec.rb - - spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb - - spec/services/clusters/applications/create_service_spec.rb - - spec/services/clusters/applications/prometheus_update_service_spec.rb - - spec/services/clusters/applications/update_service_spec.rb - - spec/services/clusters/aws/finalize_creation_service_spec.rb - - spec/services/clusters/aws/provision_service_spec.rb - - spec/services/clusters/aws/verify_provision_status_service_spec.rb - - spec/services/clusters/build_kubernetes_namespace_service_spec.rb - - spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb - - spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb - - spec/services/container_expiration_policies/cleanup_service_spec.rb - - spec/services/deployments/create_service_spec.rb - - spec/services/discussions/capture_diff_note_position_service_spec.rb - - spec/services/event_create_service_spec.rb - - spec/services/git/base_hooks_service_spec.rb - - spec/services/git/process_ref_changes_service_spec.rb - - spec/services/git/wiki_push_service/change_spec.rb - - spec/services/ide/schemas_config_service_spec.rb - - spec/services/import/bitbucket_server_service_spec.rb - - spec/services/import/github_service_spec.rb - - spec/services/issues/create_service_spec.rb - - spec/services/issues/related_branches_service_spec.rb - - spec/services/jira_connect_subscriptions/create_service_spec.rb - - spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb - - spec/services/merge_requests/approval_service_spec.rb - - spec/services/merge_requests/build_service_spec.rb - - spec/services/merge_requests/close_service_spec.rb - - spec/services/merge_requests/merge_service_spec.rb - - spec/services/merge_requests/post_merge_service_spec.rb - - spec/services/merge_requests/refresh_service_spec.rb - - spec/services/merge_requests/reopen_service_spec.rb - - spec/services/merge_requests/request_review_service_spec.rb - - spec/services/merge_requests/toggle_attention_requested_service_spec.rb - - spec/services/metrics/dashboard/clone_dashboard_service_spec.rb - - spec/services/metrics/dashboard/update_dashboard_service_spec.rb - - spec/services/metrics/users_starred_dashboards/create_service_spec.rb - - spec/services/milestones/update_service_spec.rb - - spec/services/namespaces/in_product_marketing_emails_service_spec.rb - - spec/services/notes/create_service_spec.rb - - spec/services/notes/render_service_spec.rb - - spec/services/notification_service_spec.rb - - spec/services/packages/generic/create_package_file_service_spec.rb - - spec/services/packages/maven/find_or_create_package_service_spec.rb - - spec/services/packages/maven/metadata/sync_service_spec.rb - - spec/services/packages/nuget/metadata_extraction_service_spec.rb - - spec/services/pages/zip_directory_service_spec.rb - - spec/services/post_receive_service_spec.rb - - spec/workers/projects/after_import_worker_spec.rb - - spec/services/projects/branches_by_mode_service_spec.rb - - spec/services/projects/create_service_spec.rb - - spec/services/projects/destroy_service_spec.rb - - spec/services/projects/import_service_spec.rb - - spec/services/projects/operations/update_service_spec.rb - - spec/services/projects/overwrite_project_service_spec.rb - - spec/services/projects/update_pages_service_spec.rb - - spec/services/projects/update_remote_mirror_service_spec.rb - - spec/services/projects/update_repository_storage_service_spec.rb - - spec/services/projects/update_service_spec.rb - - spec/services/repositories/changelog_service_spec.rb - - spec/services/search_service_spec.rb - - spec/services/service_ping/submit_service_ping_service_spec.rb - - spec/services/snippets/update_repository_storage_service_spec.rb - - spec/services/spam/akismet_mark_as_spam_service_spec.rb - - spec/services/spam/akismet_service_spec.rb - - spec/services/spam/ham_service_spec.rb - - spec/services/spam/spam_action_service_spec.rb - - spec/services/spam/spam_params_spec.rb - - spec/services/system_note_service_spec.rb - - spec/services/system_notes/commit_service_spec.rb - - spec/services/system_notes/issuables_service_spec.rb - - spec/services/update_merge_request_metrics_service_spec.rb - - spec/services/users/activity_service_spec.rb - - spec/services/users/create_service_spec.rb - - spec/services/users/refresh_authorized_projects_service_spec.rb - - spec/services/users/update_service_spec.rb - - spec/services/web_hook_service_spec.rb - - spec/services/wiki_pages/base_service_spec.rb - - spec/spam/concerns/has_spam_action_response_fields_spec.rb - - spec/support/helpers/graphql_helpers.rb - - spec/support/helpers/import_spec_helper.rb - - spec/support/helpers/ldap_helpers.rb - - spec/support/helpers/project_forks_helper.rb - - spec/support/helpers/stub_metrics.rb - - spec/support/helpers/stub_spam_services.rb - - spec/support/import_export/common_util.rb - - spec/support/prometheus/additional_metrics_shared_examples.rb - - spec/support/shared_contexts/lib/gitlab/sidekiq_middleware/server_metrics_shared_context.rb - - spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb - - spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb - - spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb - - spec/support/shared_examples/graphql/mutations/http_integrations_shared_examples.rb - - spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb - - spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb - - spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb - - spec/support/shared_examples/metrics/sampler_shared_examples.rb - - spec/support/shared_examples/models/chat_integration_shared_examples.rb - - spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb - - spec/support/shared_examples/models/members_notifications_shared_example.rb - - spec/support/shared_examples/models/project_ci_cd_settings_shared_examples.rb - - spec/support/shared_examples/namespaces/hierarchy_examples.rb - - spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb - - spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb - - spec/support/shared_examples/requests/api/debian_common_shared_examples.rb - - spec/support/shared_examples/requests/api/nuget_endpoints_shared_examples.rb - - spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb - - spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb - - spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb - - spec/support/shared_examples/requests/rack_attack_shared_examples.rb - - spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb - - spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb - - spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb - - spec/support/shared_examples/services/alert_management/alert_processing/notifications_shared_examples.rb - - spec/support/shared_examples/services/alert_management_shared_examples.rb - - spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb - - spec/support/shared_examples/services/check_ingress_ip_address_service_shared_examples.rb - - spec/support/shared_examples/services/jira/requests/base_shared_examples.rb - - spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb - - spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb - - spec/support/shared_examples/services/resource_events/synthetic_notes_builder_shared_examples.rb - - spec/support/shared_examples/workers/background_migration_worker_shared_examples.rb - - spec/support/shared_examples/workers/update_repository_move_shared_examples.rb - - spec/tasks/gettext_rake_spec.rb - - spec/tasks/gitlab/background_migrations_rake_spec.rb - - spec/tasks/gitlab/check_rake_spec.rb - - spec/tasks/gitlab/cleanup_rake_spec.rb - - spec/tasks/gitlab/db_rake_spec.rb - - spec/tasks/gitlab/packages/events_rake_spec.rb - - spec/tasks/gitlab/setup_rake_spec.rb - - spec/tooling/danger/project_helper_spec.rb - - spec/tooling/danger/specs_spec.rb - - spec/tooling/lib/tooling/helm3_client_spec.rb - - spec/tooling/lib/tooling/kubernetes_client_spec.rb - - spec/tooling/rspec_flaky/example_spec.rb - - spec/tooling/rspec_flaky/listener_spec.rb - - spec/uploaders/file_uploader_spec.rb - - spec/uploaders/object_storage_spec.rb - - spec/uploaders/personal_file_uploader_spec.rb - - spec/uploaders/records_uploads_spec.rb - - spec/views/projects/issues/show.html.haml_spec.rb - - spec/views/shared/milestones/_issuables.html.haml_spec.rb - - spec/views/shared/wikis/_sidebar.html.haml_spec.rb - - spec/workers/bulk_imports/export_request_worker_spec.rb - - spec/workers/chat_notification_worker_spec.rb - - spec/workers/ci/build_prepare_worker_spec.rb - - spec/workers/ci/create_cross_project_pipeline_worker_spec.rb - - spec/workers/ci/create_downstream_pipeline_worker_spec.rb - - spec/workers/ci/pipeline_bridge_status_worker_spec.rb - - spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb - - spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb - - spec/workers/clusters/agents/delete_expired_events_worker_spec.rb - - spec/workers/concerns/application_worker_spec.rb - - spec/workers/concerns/gitlab/github_import/object_importer_spec.rb - - spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb - - spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb - - spec/workers/create_commit_signature_worker_spec.rb - - spec/workers/environments/auto_stop_worker_spec.rb - - spec/workers/error_tracking_issue_link_worker_spec.rb - - spec/workers/gitlab/github_import/advance_stage_worker_spec.rb - - spec/workers/gitlab/github_import/import_diff_note_worker_spec.rb - - spec/workers/gitlab/github_import/import_issue_worker_spec.rb - - spec/workers/gitlab/github_import/import_note_worker_spec.rb - - spec/workers/gitlab/github_import/import_pull_request_worker_spec.rb - - spec/workers/gitlab/github_import/stage/finish_import_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_base_data_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_lfs_objects_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_notes_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_pull_requests_merged_by_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_pull_requests_reviews_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_pull_requests_worker_spec.rb - - spec/workers/gitlab/github_import/stage/import_repository_worker_spec.rb - - spec/workers/gitlab_performance_bar_stats_worker_spec.rb - - spec/workers/invalid_gpg_signature_update_worker_spec.rb - - spec/workers/issues/rebalancing_worker_spec.rb - - spec/workers/merge_request_mergeability_check_worker_spec.rb - - spec/workers/new_issue_worker_spec.rb - - spec/workers/new_merge_request_worker_spec.rb - - spec/workers/pages_domain_ssl_renewal_worker_spec.rb - - spec/workers/pages_domain_verification_worker_spec.rb - - spec/workers/post_receive_spec.rb - - spec/workers/project_cache_worker_spec.rb - - spec/workers/propagate_integration_group_worker_spec.rb - - spec/workers/propagate_integration_inherit_descendant_worker_spec.rb - - spec/workers/propagate_integration_inherit_worker_spec.rb - - spec/workers/propagate_integration_project_worker_spec.rb - - spec/workers/purge_dependency_proxy_cache_worker_spec.rb - - spec/workers/repository_import_worker_spec.rb - - spec/workers/system_hook_push_worker_spec.rb - - + - 'ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb' + - 'ee/spec/controllers/groups/clusters_controller_spec.rb' + - 'ee/spec/controllers/groups/sso_controller_spec.rb' + - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb' + - 'ee/spec/controllers/projects/clusters_controller_spec.rb' + - 'ee/spec/db/production/license_spec.rb' + - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' + - 'ee/spec/features/profiles/account_spec.rb' + - 'ee/spec/finders/license_template_finder_spec.rb' + - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' + - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/finders/template_finder_spec.rb' + - 'ee/spec/graphql/mutations/dast_scanner_profiles/create_spec.rb' + - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' + - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' + - 'ee/spec/graphql/mutations/dast_site_profiles/update_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_rotation/create_spec.rb' + - 'ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb' + - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' + - 'ee/spec/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' + - 'ee/spec/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb' + - 'ee/spec/graphql/resolvers/external_issue_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities/details_resolver_spec.rb' + - 'ee/spec/helpers/billing_plans_helper_spec.rb' + - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' + - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' + - 'ee/spec/helpers/ee/trial_helper_spec.rb' + - 'ee/spec/helpers/ee/trial_registration_helper_spec.rb' + - 'ee/spec/helpers/kerberos_helper_spec.rb' + - 'ee/spec/helpers/license_helper_spec.rb' + - 'ee/spec/helpers/roadmaps_helper_spec.rb' + - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' + - 'ee/spec/helpers/subscriptions_helper_spec.rb' + - 'ee/spec/helpers/timeboxes_helper_spec.rb' + - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/lib/ee/backup/repositories_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' + - 'ee/spec/lib/ee/gitlab/etag_caching/router/rails_spec.rb' + - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' + - 'ee/spec/lib/elastic/latest/config_shared_examples.rb' + - 'ee/spec/lib/elastic/latest/git_instance_proxy_spec.rb' + - 'ee/spec/lib/elastic/migration_spec.rb' + - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' + - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/response_check_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb' + - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' + - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' + - 'ee/spec/lib/gitlab/cache_spec.rb' + - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb' + - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' + - 'ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb' + - 'ee/spec/lib/gitlab/code_owners/users_loader_spec.rb' + - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' + - 'ee/spec/lib/gitlab/elastic/client_spec.rb' + - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' + - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' + - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' + - 'ee/spec/lib/gitlab/geo/oauth/logout_token_spec.rb' + - 'ee/spec/lib/gitlab/geo/oauth/session_spec.rb' + - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' + - 'ee/spec/lib/gitlab/geo_spec.rb' + - 'ee/spec/lib/gitlab/git_access_spec.rb' + - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' + - 'ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb' + - 'ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb' + - 'ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb' + - 'ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb' + - 'ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb' + - 'ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb' + - 'ee/spec/models/concerns/geo/verification_state_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' + - 'ee/spec/models/ee/user_spec.rb' + - 'ee/spec/models/elastic/index_setting_spec.rb' + - 'ee/spec/models/geo/project_registry_spec.rb' + - 'ee/spec/models/geo/secondary_usage_data_spec.rb' + - 'ee/spec/models/geo_node_status_spec.rb' + - 'ee/spec/models/integrations/github/status_message_spec.rb' + - 'ee/spec/models/integrations/github_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/push_rule_spec.rb' + - 'ee/spec/presenters/audit_event_presenter_spec.rb' + - 'ee/spec/presenters/group_member_presenter_spec.rb' + - 'ee/spec/presenters/merge_request_approver_presenter_spec.rb' + - 'ee/spec/presenters/project_member_presenter_spec.rb' + - 'ee/spec/requests/api/geo_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb' + - 'ee/spec/requests/api/internal/base_spec.rb' + - 'ee/spec/requests/api/ldap_spec.rb' + - 'ee/spec/requests/api/visual_review_discussions_spec.rb' + - 'ee/spec/requests/api/vulnerability_findings_spec.rb' + - 'ee/spec/requests/callout_spec.rb' + - 'ee/spec/requests/rack_attack_spec.rb' + - 'ee/spec/serializers/blocking_merge_request_entity_spec.rb' + - 'ee/spec/serializers/clusters/environment_entity_spec.rb' + - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' + - 'ee/spec/serializers/dependency_entity_spec.rb' + - 'ee/spec/serializers/ee/admin/user_entity_spec.rb' + - 'ee/spec/serializers/ee/build_details_entity_spec.rb' + - 'ee/spec/serializers/ee/ci/job_entity_spec.rb' + - 'ee/spec/serializers/ee/ci/pipeline_entity_spec.rb' + - 'ee/spec/serializers/ee/group_child_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_board_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb' + - 'ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb' + - 'ee/spec/serializers/ee/note_entity_spec.rb' + - 'ee/spec/serializers/environment_entity_spec.rb' + - 'ee/spec/serializers/epic_entity_spec.rb' + - 'ee/spec/serializers/epic_note_entity_spec.rb' + - 'ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb' + - 'ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb' + - 'ee/spec/serializers/issuable_sidebar_extras_entity_spec.rb' + - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb' + - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' + - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb' + - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' + - 'ee/spec/serializers/test_reports_comparer_serializer_spec.rb' + - 'ee/spec/serializers/user_analytics_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_serializer_spec.rb' + - 'ee/spec/serializers/vulnerability_note_entity_spec.rb' + - 'ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb' + - 'ee/spec/services/app_sec/dast/scans/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profiles/update_service_spec.rb' + - 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' + - 'ee/spec/services/ci/minutes/track_live_consumption_service_spec.rb' + - 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb' + - 'ee/spec/services/ci/pipeline_creation/drop_not_runnable_builds_service_spec.rb' + - 'ee/spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb' + - 'ee/spec/services/dashboard/operations/list_service_spec.rb' + - 'ee/spec/services/dashboard/projects/create_service_spec.rb' + - 'ee/spec/services/ee/issues/create_service_spec.rb' + - 'ee/spec/services/ee/issues/update_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/post_merge_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/services/ee/post_receive_service_spec.rb' + - 'ee/spec/services/geo/blob_download_service_spec.rb' + - 'ee/spec/services/geo/graphql_request_service_spec.rb' + - 'ee/spec/services/geo/node_status_request_service_spec.rb' + - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' + - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' + - 'ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb' + - 'ee/spec/services/group_saml/sign_up_service_spec.rb' + - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' + - 'ee/spec/services/ide/schemas_config_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' + - 'ee/spec/services/incident_management/pending_escalations/process_service_spec.rb' + - 'ee/spec/services/merge_requests/approval_service_spec.rb' + - 'ee/spec/services/merge_requests/build_service_spec.rb' + - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' + - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' + - 'ee/spec/services/projects/update_mirror_service_spec.rb' + - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' + - 'ee/spec/services/security/orchestration/assign_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service_spec.rb' + - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' + - 'ee/spec/services/status_page/publish_details_service_spec.rb' + - 'ee/spec/services/status_page/publish_service_spec.rb' + - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' + - 'ee/spec/services/system_note_service_spec.rb' + - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' + - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' + - 'ee/spec/support/helpers/ee/ldap_helpers.rb' + - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' + - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' + - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' + - 'ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' + - 'ee/spec/support/shared_examples/status_page/reference_links_examples.rb' + - 'ee/spec/validators/json_schema_validator_spec.rb' + - 'ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb' + - 'ee/spec/workers/ci/sync_reports_to_report_approval_rules_worker_spec.rb' + - 'ee/spec/workers/compliance_management/chain_of_custody_report_worker_spec.rb' + - 'ee/spec/workers/geo/container_repository_sync_worker_spec.rb' + - 'ee/spec/workers/geo/design_repository_sync_worker_spec.rb' + - 'ee/spec/workers/geo/destroy_worker_spec.rb' + - 'ee/spec/workers/geo/event_worker_spec.rb' + - 'ee/spec/workers/geo/metrics_update_worker_spec.rb' + - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' + - 'ee/spec/workers/geo/registry_sync_worker_spec.rb' + - 'ee/spec/workers/geo/reverification_batch_worker_spec.rb' + - 'ee/spec/workers/geo/sidekiq_cron_config_worker_spec.rb' + - 'ee/spec/workers/geo/sync_timeout_cron_worker_spec.rb' + - 'ee/spec/workers/geo/verification_batch_worker_spec.rb' + - 'ee/spec/workers/geo/verification_cron_worker_spec.rb' + - 'ee/spec/workers/geo/verification_timeout_worker_spec.rb' + - 'ee/spec/workers/geo/verification_worker_spec.rb' + - 'ee/spec/workers/iterations/cadences/create_iterations_worker_spec.rb' + - 'ee/spec/workers/iterations/roll_over_issues_worker_spec.rb' + - 'ee/spec/workers/ldap_group_sync_worker_spec.rb' + - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' + - 'ee/spec/workers/new_epic_worker_spec.rb' + - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' + - 'qa/spec/git/repository_spec.rb' + - 'qa/spec/page/base_spec.rb' + - 'qa/spec/page/validator_spec.rb' + - 'qa/spec/page/view_spec.rb' + - 'qa/spec/resource/api_fabricator_spec.rb' + - 'qa/spec/resource/base_spec.rb' + - 'qa/spec/runtime/application_settings_spec.rb' + - 'qa/spec/runtime/feature_spec.rb' + - 'qa/spec/runtime/release_spec.rb' + - 'qa/spec/scenario/test/sanity/selectors_spec.rb' + - 'qa/spec/support/formatters/allure_metadata_formatter_spec.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'qa/spec/support/run_spec.rb' + - 'qa/spec/tools/long_running_spec_reporter_spec.rb' + - 'spec/benchmarks/banzai_benchmark.rb' + - 'spec/bin/feature_flag_spec.rb' + - 'spec/controllers/application_controller_spec.rb' + - 'spec/controllers/concerns/checks_collaboration_spec.rb' + - 'spec/controllers/concerns/import_url_params_spec.rb' + - 'spec/controllers/concerns/issuable_actions_spec.rb' + - 'spec/controllers/concerns/issuable_collections_spec.rb' + - 'spec/controllers/concerns/page_limiter_spec.rb' + - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' + - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' + - 'spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb' + - 'spec/controllers/dashboard/snippets_controller_spec.rb' + - 'spec/controllers/explore/projects_controller_spec.rb' + - 'spec/controllers/groups/dependency_proxy_auth_controller_spec.rb' + - 'spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' + - 'spec/controllers/help_controller_spec.rb' + - 'spec/controllers/import/bitbucket_controller_spec.rb' + - 'spec/controllers/import/bitbucket_server_controller_spec.rb' + - 'spec/controllers/import/bulk_imports_controller_spec.rb' + - 'spec/controllers/import/fogbugz_controller_spec.rb' + - 'spec/controllers/import/gitea_controller_spec.rb' + - 'spec/controllers/import/github_controller_spec.rb' + - 'spec/controllers/import/gitlab_controller_spec.rb' + - 'spec/controllers/oauth/jira_dvcs/authorizations_controller_spec.rb' + - 'spec/controllers/omniauth_callbacks_controller_spec.rb' + - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' + - 'spec/controllers/projects/blob_controller_spec.rb' + - 'spec/controllers/projects/branches_controller_spec.rb' + - 'spec/controllers/projects/import/jira_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' + - 'spec/controllers/projects/merge_requests_controller_spec.rb' + - 'spec/controllers/projects/notes_controller_spec.rb' + - 'spec/controllers/projects/pages_controller_spec.rb' + - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' + - 'spec/controllers/projects/registry/tags_controller_spec.rb' + - 'spec/controllers/projects/settings/operations_controller_spec.rb' + - 'spec/controllers/projects/snippets_controller_spec.rb' + - 'spec/controllers/sessions_controller_spec.rb' + - 'spec/dependencies/omniauth_saml_spec.rb' + - 'spec/experiments/concerns/project_commit_count_spec.rb' + - 'spec/factories/ci/job_artifacts.rb' + - 'spec/features/admin/admin_system_info_spec.rb' + - 'spec/features/clusters/create_agent_spec.rb' + - 'spec/features/file_uploads/maven_package_spec.rb' + - 'spec/features/groups/container_registry_spec.rb' + - 'spec/features/help_pages_spec.rb' + - 'spec/features/issuables/markdown_references/jira_spec.rb' + - 'spec/features/markdown/markdown_spec.rb' + - 'spec/features/profiles/personal_access_tokens_spec.rb' + - 'spec/features/projects/container_registry_spec.rb' + - 'spec/features/projects/integrations/user_activates_jira_spec.rb' + - 'spec/finders/ci/auth_job_finder_spec.rb' + - 'spec/finders/merge_requests/oldest_per_commit_finder_spec.rb' + - 'spec/finders/repositories/changelog_commits_finder_spec.rb' + - 'spec/finders/repositories/changelog_tag_finder_spec.rb' + - 'spec/graphql/features/authorization_spec.rb' + - 'spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb' + - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb' + - 'spec/graphql/mutations/branches/create_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/graphql/mutations/design_management/upload_spec.rb' + - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb' + - 'spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb' + - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' + - 'spec/graphql/types/kas/agent_connection_type_spec.rb' + - 'spec/graphql/types/permission_types/base_permission_type_spec.rb' + - 'spec/graphql/types/project_type_spec.rb' + - 'spec/helpers/blame_helper_spec.rb' + - 'spec/helpers/blob_helper_spec.rb' + - 'spec/helpers/ci/pipelines_helper_spec.rb' + - 'spec/helpers/ci/status_helper_spec.rb' + - 'spec/helpers/ci/triggers_helper_spec.rb' + - 'spec/helpers/commits_helper_spec.rb' + - 'spec/helpers/dev_ops_report_helper_spec.rb' + - 'spec/helpers/diff_helper_spec.rb' + - 'spec/helpers/emails_helper_spec.rb' + - 'spec/helpers/environments_helper_spec.rb' + - 'spec/helpers/form_helper_spec.rb' + - 'spec/helpers/gitlab_routing_helper_spec.rb' + - 'spec/helpers/integrations_helper_spec.rb' + - 'spec/helpers/issuables_helper_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/helpers/merge_requests_helper_spec.rb' + - 'spec/helpers/notes_helper_spec.rb' + - 'spec/helpers/numbers_helper_spec.rb' + - 'spec/helpers/preferences_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/helpers/routing/pseudonymization_helper_spec.rb' + - 'spec/helpers/sorting_helper_spec.rb' + - 'spec/helpers/submodule_helper_spec.rb' + - 'spec/helpers/todos_helper_spec.rb' + - 'spec/helpers/version_check_helper_spec.rb' + - 'spec/initializers/doorkeeper_spec.rb' + - 'spec/initializers/global_id_spec.rb' + - 'spec/initializers/hangouts_chat_http_override_spec.rb' + - 'spec/lib/api/base_spec.rb' + - 'spec/lib/api/entities/ci/job_request/image_spec.rb' + - 'spec/lib/api/entities/ci/job_request/port_spec.rb' + - 'spec/lib/api/helpers/authentication_spec.rb' + - 'spec/lib/api/helpers/caching_spec.rb' + - 'spec/lib/api/helpers/graphql_helpers_spec.rb' + - 'spec/lib/api/helpers/pagination_spec.rb' + - 'spec/lib/api/helpers/pagination_strategies_spec.rb' + - 'spec/lib/api/helpers/variables_helpers_spec.rb' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/atlassian/jira_connect/client_spec.rb' + - 'spec/lib/backup/files_spec.rb' + - 'spec/lib/backup/repositories_spec.rb' + - 'spec/lib/banzai/cross_project_reference_spec.rb' + - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' + - 'spec/lib/banzai/pipeline/wiki_pipeline_spec.rb' + - 'spec/lib/banzai/querying_spec.rb' + - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' + - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' + - 'spec/lib/banzai/reference_parser/commit_range_parser_spec.rb' + - 'spec/lib/banzai/render_context_spec.rb' + - 'spec/lib/banzai/renderer_spec.rb' + - 'spec/lib/bitbucket/connection_spec.rb' + - 'spec/lib/bitbucket/paginator_spec.rb' + - 'spec/lib/bitbucket_server/paginator_spec.rb' + - 'spec/lib/bulk_imports/clients/http_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/rest_extractor_spec.rb' + - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' + - 'spec/lib/bulk_imports/network_error_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/transformers/project_attributes_transformer_spec.rb' + - 'spec/lib/constraints/admin_constrainer_spec.rb' + - 'spec/lib/constraints/group_url_constrainer_spec.rb' + - 'spec/lib/constraints/jira_encoded_url_constrainer_spec.rb' + - 'spec/lib/constraints/project_url_constrainer_spec.rb' + - 'spec/lib/constraints/user_url_constrainer_spec.rb' + - 'spec/lib/csv_builder_spec.rb' + - 'spec/lib/csv_builders/stream_spec.rb' + - 'spec/lib/extracts_path_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitaly/server_spec.rb' + - 'spec/lib/gitlab/api_authentication/token_locator_spec.rb' + - 'spec/lib/gitlab/application_context_spec.rb' + - 'spec/lib/gitlab/application_rate_limiter_spec.rb' + - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' + - 'spec/lib/gitlab/auth/auth_finders_spec.rb' + - 'spec/lib/gitlab/auth/blocked_user_tracker_spec.rb' + - 'spec/lib/gitlab/auth/ldap/adapter_spec.rb' + - 'spec/lib/gitlab/auth/ldap/authentication_spec.rb' + - 'spec/lib/gitlab/authorized_keys_spec.rb' + - 'spec/lib/gitlab/avatar_cache_spec.rb' + - 'spec/lib/gitlab/background_migration/base_job_spec.rb' + - 'spec/lib/gitlab/background_migration/batching_strategies/base_strategy_spec.rb' + - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' + - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' + - 'spec/lib/gitlab/background_migration_spec.rb' + - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' + - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' + - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' + - 'spec/lib/gitlab/cache/import/caching_spec.rb' + - 'spec/lib/gitlab/changelog/committer_spec.rb' + - 'spec/lib/gitlab/chat/responder/base_spec.rb' + - 'spec/lib/gitlab/chat/responder_spec.rb' + - 'spec/lib/gitlab/ci/badge/coverage/metadata_spec.rb' + - 'spec/lib/gitlab/ci/badge/coverage/template_spec.rb' + - 'spec/lib/gitlab/ci/badge/pipeline/metadata_spec.rb' + - 'spec/lib/gitlab/ci/badge/pipeline/template_spec.rb' + - 'spec/lib/gitlab/ci/build/cache_spec.rb' + - 'spec/lib/gitlab/ci/build/policy/changes_spec.rb' + - 'spec/lib/gitlab/ci/build/policy/variables_spec.rb' + - 'spec/lib/gitlab/ci/build/policy_spec.rb' + - 'spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb' + - 'spec/lib/gitlab/ci/build/rules/rule_spec.rb' + - 'spec/lib/gitlab/ci/build/rules_spec.rb' + - 'spec/lib/gitlab/ci/build/status/reason_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/default_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' + - 'spec/lib/gitlab/ci/config/external/context_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/local_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/project_spec.rb' + - 'spec/lib/gitlab/ci/config/external/rules_spec.rb' + - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/evaluate_workflow_rules_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/remove_unwanted_chat_jobs_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/sequence_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/skip_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/and_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_matches_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/or_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/preloader_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/report_spec.rb' + - 'spec/lib/gitlab/ci/status/build/action_spec.rb' + - 'spec/lib/gitlab/ci/status/build/cancelable_spec.rb' + - 'spec/lib/gitlab/ci/status/build/canceled_spec.rb' + - 'spec/lib/gitlab/ci/status/build/created_spec.rb' + - 'spec/lib/gitlab/ci/status/build/erased_spec.rb' + - 'spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb' + - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' + - 'spec/lib/gitlab/ci/status/build/pending_spec.rb' + - 'spec/lib/gitlab/ci/status/build/preparing_spec.rb' + - 'spec/lib/gitlab/ci/status/build/retried_spec.rb' + - 'spec/lib/gitlab/ci/status/build/retryable_spec.rb' + - 'spec/lib/gitlab/ci/status/build/skipped_spec.rb' + - 'spec/lib/gitlab/ci/status/build/stop_spec.rb' + - 'spec/lib/gitlab/ci/status/build/unschedule_spec.rb' + - 'spec/lib/gitlab/ci/status/canceled_spec.rb' + - 'spec/lib/gitlab/ci/status/core_spec.rb' + - 'spec/lib/gitlab/ci/status/created_spec.rb' + - 'spec/lib/gitlab/ci/status/factory_spec.rb' + - 'spec/lib/gitlab/ci/status/failed_spec.rb' + - 'spec/lib/gitlab/ci/status/manual_spec.rb' + - 'spec/lib/gitlab/ci/status/pending_spec.rb' + - 'spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb' + - 'spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb' + - 'spec/lib/gitlab/ci/status/preparing_spec.rb' + - 'spec/lib/gitlab/ci/status/running_spec.rb' + - 'spec/lib/gitlab/ci/status/scheduled_spec.rb' + - 'spec/lib/gitlab/ci/status/skipped_spec.rb' + - 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb' + - 'spec/lib/gitlab/ci/status/success_spec.rb' + - 'spec/lib/gitlab/ci/status/success_warning_spec.rb' + - 'spec/lib/gitlab/ci/status/waiting_for_resource_spec.rb' + - 'spec/lib/gitlab/ci/trace/archive_spec.rb' + - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' + - 'spec/lib/gitlab/ci/trace/stream_spec.rb' + - 'spec/lib/gitlab/ci/variables/builder_spec.rb' + - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' + - 'spec/lib/gitlab/cleanup/project_uploads_spec.rb' + - 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb' + - 'spec/lib/gitlab/cluster/puma_worker_killer_observer_spec.rb' + - 'spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb' + - 'spec/lib/gitlab/color_schemes_spec.rb' + - 'spec/lib/gitlab/conan_token_spec.rb' + - 'spec/lib/gitlab/config/entry/configurable_spec.rb' + - 'spec/lib/gitlab/config/entry/factory_spec.rb' + - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb' + - 'spec/lib/gitlab/config/entry/unspecified_spec.rb' + - 'spec/lib/gitlab/config/entry/validator_spec.rb' + - 'spec/lib/gitlab/conflict/file_spec.rb' + - 'spec/lib/gitlab/cross_project_access/check_collection_spec.rb' + - 'spec/lib/gitlab/database/async_indexes_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' + - 'spec/lib/gitlab/database/batch_count_spec.rb' + - 'spec/lib/gitlab/database/count_spec.rb' + - 'spec/lib/gitlab/database/each_database_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/resolver_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/service_discovery_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' + - 'spec/lib/gitlab/database/load_balancing_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' + - 'spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb' + - 'spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb' + - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' + - 'spec/lib/gitlab/database/migrations/runner_spec.rb' + - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' + - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' + - 'spec/lib/gitlab/database/partitioning/partition_monitoring_spec.rb' + - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' + - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' + - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' + - 'spec/lib/gitlab/database/partitioning_spec.rb' + - 'spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb' + - 'spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb' + - 'spec/lib/gitlab/database/query_analyzer_spec.rb' + - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' + - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' + - 'spec/lib/gitlab/database/shared_model_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/diff/file_collection_sorter_spec.rb' + - 'spec/lib/gitlab/diff/file_spec.rb' + - 'spec/lib/gitlab/diff/line_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer_spec.rb' + - 'spec/lib/gitlab/doctor/secrets_spec.rb' + - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' + - 'spec/lib/gitlab/email/receiver_spec.rb' + - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' + - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' + - 'spec/lib/gitlab/etag_caching/middleware_spec.rb' + - 'spec/lib/gitlab/etag_caching/router/graphql_spec.rb' + - 'spec/lib/gitlab/etag_caching/router/rails_spec.rb' + - 'spec/lib/gitlab/etag_caching/router_spec.rb' + - 'spec/lib/gitlab/event_store/store_spec.rb' + - 'spec/lib/gitlab/experiment/rollout/feature_spec.rb' + - 'spec/lib/gitlab/external_authorization/access_spec.rb' + - 'spec/lib/gitlab/external_authorization/logger_spec.rb' + - 'spec/lib/gitlab/faraday/error_callback_spec.rb' + - 'spec/lib/gitlab/feature_categories_spec.rb' + - 'spec/lib/gitlab/git/blob_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' + - 'spec/lib/gitlab/git/tag_spec.rb' + - 'spec/lib/gitlab/git_access_snippet_spec.rb' + - 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb' + - 'spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/health_check_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/remote_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' + - 'spec/lib/gitlab/gitaly_client_spec.rb' + - 'spec/lib/gitlab/github_import/bulk_importing_spec.rb' + - 'spec/lib/gitlab/github_import/client_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issue_and_label_links_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/label_links_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/labels_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_requests_merged_by_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_requests_reviews_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/repository_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_merge_request_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/issuable_finder_spec.rb' + - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' + - 'spec/lib/gitlab/github_import/milestone_finder_spec.rb' + - 'spec/lib/gitlab/github_import/object_counter_spec.rb' + - 'spec/lib/gitlab/github_import/page_counter_spec.rb' + - 'spec/lib/gitlab/github_import/parallel_importer_spec.rb' + - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' + - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/to_hash_spec.rb' + - 'spec/lib/gitlab/github_import/sequential_importer_spec.rb' + - 'spec/lib/gitlab/github_import/user_finder_spec.rb' + - 'spec/lib/gitlab/github_import_spec.rb' + - 'spec/lib/gitlab/gon_helper_spec.rb' + - 'spec/lib/gitlab/gpg/commit_spec.rb' + - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' + - 'spec/lib/gitlab/gpg_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/perf_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb' + - 'spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb' + - 'spec/lib/gitlab/graphql/batch_key_spec.rb' + - 'spec/lib/gitlab/graphql/generic_tracing_spec.rb' + - 'spec/lib/gitlab/graphql/lazy_spec.rb' + - 'spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb' + - 'spec/lib/gitlab/graphql/present/field_extension_spec.rb' + - 'spec/lib/gitlab/graphql/timeout_spec.rb' + - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' + - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' + - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' + - 'spec/lib/gitlab/hook_data/base_builder_spec.rb' + - 'spec/lib/gitlab/hotlinking_detector_spec.rb' + - 'spec/lib/gitlab/import/import_failure_service_spec.rb' + - 'spec/lib/gitlab/import/metrics_spec.rb' + - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' + - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' + - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' + - 'spec/lib/gitlab/import_export/group/relation_factory_spec.rb' + - 'spec/lib/gitlab/import_export/importer_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' + - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' + - 'spec/lib/gitlab/issuables_count_for_state_spec.rb' + - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' + - 'spec/lib/gitlab/jira/middleware_spec.rb' + - 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb' + - 'spec/lib/gitlab/jira_import/labels_importer_spec.rb' + - 'spec/lib/gitlab/jira_import/metadata_collector_spec.rb' + - 'spec/lib/gitlab/jira_import_spec.rb' + - 'spec/lib/gitlab/job_waiter_spec.rb' + - 'spec/lib/gitlab/json_cache_spec.rb' + - 'spec/lib/gitlab/kas/client_spec.rb' + - 'spec/lib/gitlab/kubernetes/config_map_spec.rb' + - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' + - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' + - 'spec/lib/gitlab/lazy_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb' + - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' + - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' + - 'spec/lib/gitlab/manifest_import/metadata_spec.rb' + - 'spec/lib/gitlab/markdown_cache/field_data_spec.rb' + - 'spec/lib/gitlab/merge_requests/message_generator_spec.rb' + - 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb' + - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' + - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' + - 'spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb' + - 'spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb' + - 'spec/lib/gitlab/metrics/exporter/gc_request_middleware_spec.rb' + - 'spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb' + - 'spec/lib/gitlab/metrics/rack_middleware_spec.rb' + - 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb' + - 'spec/lib/gitlab/metrics/samplers/database_sampler_spec.rb' + - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' + - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' + - 'spec/lib/gitlab/metrics/sli_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/action_view_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/external_http_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/load_balancing_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/rails_cache_spec.rb' + - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' + - 'spec/lib/gitlab/middleware/basic_health_check_spec.rb' + - 'spec/lib/gitlab/middleware/compressed_json_spec.rb' + - 'spec/lib/gitlab/middleware/go_spec.rb' + - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' + - 'spec/lib/gitlab/middleware/multipart_spec.rb' + - 'spec/lib/gitlab/middleware/query_analyzer_spec.rb' + - 'spec/lib/gitlab/middleware/rails_queue_duration_spec.rb' + - 'spec/lib/gitlab/middleware/release_env_spec.rb' + - 'spec/lib/gitlab/middleware/sidekiq_web_static_spec.rb' + - 'spec/lib/gitlab/middleware/speedscope_spec.rb' + - 'spec/lib/gitlab/middleware/webhook_recursion_detection_spec.rb' + - 'spec/lib/gitlab/octokit/middleware_spec.rb' + - 'spec/lib/gitlab/optimistic_locking_spec.rb' + - 'spec/lib/gitlab/pages/settings_spec.rb' + - 'spec/lib/gitlab/pagination/cursor_based_keyset_spec.rb' + - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/cursor_based_request_context_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/cursor_pager_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/pager_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/request_context_spec.rb' + - 'spec/lib/gitlab/pagination/keyset_spec.rb' + - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' + - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' + - 'spec/lib/gitlab/performance_bar/stats_spec.rb' + - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' + - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' + - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' + - 'spec/lib/gitlab/polling_interval_spec.rb' + - 'spec/lib/gitlab/popen/runner_spec.rb' + - 'spec/lib/gitlab/process_management_spec.rb' + - 'spec/lib/gitlab/profiler_spec.rb' + - 'spec/lib/gitlab/prometheus/adapter_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/query_limiting/middleware_spec.rb' + - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' + - 'spec/lib/gitlab/repository_cache_spec.rb' + - 'spec/lib/gitlab/routing_spec.rb' + - 'spec/lib/gitlab/runtime_spec.rb' + - 'spec/lib/gitlab/sanitizers/svg_spec.rb' + - 'spec/lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator_spec.rb' + - 'spec/lib/gitlab/search/abuse_validators/no_abusive_term_length_validator_spec.rb' + - 'spec/lib/gitlab/serializer/pagination_spec.rb' + - 'spec/lib/gitlab/sidekiq_config/cli_methods_spec.rb' + - 'spec/lib/gitlab/sidekiq_config/worker_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' + - 'spec/lib/gitlab/sidekiq_status/client_middleware_spec.rb' + - 'spec/lib/gitlab/sidekiq_status/server_middleware_spec.rb' + - 'spec/lib/gitlab/slash_commands/command_spec.rb' + - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' + - 'spec/lib/gitlab/slash_commands/issue_close_spec.rb' + - 'spec/lib/gitlab/slash_commands/issue_comment_spec.rb' + - 'spec/lib/gitlab/slash_commands/issue_new_spec.rb' + - 'spec/lib/gitlab/slash_commands/issue_search_spec.rb' + - 'spec/lib/gitlab/slash_commands/issue_show_spec.rb' + - 'spec/lib/gitlab/slash_commands/presenters/run_spec.rb' + - 'spec/lib/gitlab/slash_commands/run_spec.rb' + - 'spec/lib/gitlab/spamcheck/client_spec.rb' + - 'spec/lib/gitlab/submodule_links_spec.rb' + - 'spec/lib/gitlab/suggestions/file_suggestion_spec.rb' + - 'spec/lib/gitlab/tab_width_spec.rb' + - 'spec/lib/gitlab/themes_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' + - 'spec/lib/gitlab/usage/metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/lib/gitlab/utils/usage_data_spec.rb' + - 'spec/lib/gitlab/verify/job_artifacts_spec.rb' + - 'spec/lib/gitlab/verify/lfs_objects_spec.rb' + - 'spec/lib/gitlab/verify/uploads_spec.rb' + - 'spec/lib/gitlab/view/presenter/base_spec.rb' + - 'spec/lib/gitlab/view/presenter/delegated_spec.rb' + - 'spec/lib/gitlab/view/presenter/simple_spec.rb' + - 'spec/lib/gitlab/workhorse_spec.rb' + - 'spec/lib/gitlab_edition_spec.rb' + - 'spec/lib/gitlab_spec.rb' + - 'spec/lib/google_api/cloud_platform/client_spec.rb' + - 'spec/lib/peek/views/active_record_spec.rb' + - 'spec/lib/peek/views/bullet_detailed_spec.rb' + - 'spec/lib/peek/views/external_http_spec.rb' + - 'spec/lib/safe_zip/entry_spec.rb' + - 'spec/lib/serializers/unsafe_json_spec.rb' + - 'spec/lib/sidebars/projects/menus/analytics_menu_spec.rb' + - 'spec/mailers/emails/service_desk_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/metrics_server/metrics_server_spec.rb' + - 'spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb' + - 'spec/models/active_session_spec.rb' + - 'spec/models/application_record_spec.rb' + - 'spec/models/badge_spec.rb' + - 'spec/models/badges/project_badge_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/build_trace_chunk_spec.rb' + - 'spec/models/ci/commit_with_pipeline_spec.rb' + - 'spec/models/ci/group_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/clusters/applications/runner_spec.rb' + - 'spec/models/clusters/cluster_spec.rb' + - 'spec/models/clusters/platforms/kubernetes_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/concerns/atomic_internal_id_spec.rb' + - 'spec/models/concerns/legacy_bulk_insert_spec.rb' + - 'spec/models/concerns/prometheus_adapter_spec.rb' + - 'spec/models/concerns/token_authenticatable_strategies/base_spec.rb' + - 'spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb' + - 'spec/models/concerns/triggerable_hooks_spec.rb' + - 'spec/models/concerns/x509_serial_number_attribute_spec.rb' + - 'spec/models/design_management/design_action_spec.rb' + - 'spec/models/design_management/design_at_version_spec.rb' + - 'spec/models/diff_viewer/image_spec.rb' + - 'spec/models/environment_spec.rb' + - 'spec/models/event_spec.rb' + - 'spec/models/external_issue_spec.rb' + - 'spec/models/hooks/web_hook_spec.rb' + - 'spec/models/integrations/asana_spec.rb' + - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' + - 'spec/models/integrations/jira_spec.rb' + - 'spec/models/integrations/microsoft_teams_spec.rb' + - 'spec/models/integrations/pipelines_email_spec.rb' + - 'spec/models/issue_spec.rb' + - 'spec/models/key_spec.rb' + - 'spec/models/merge_request_diff_commit_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/packages/package_spec.rb' + - 'spec/models/plan_limits_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/ref_matcher_spec.rb' + - 'spec/models/release_highlight_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/models/shard_spec.rb' + - 'spec/models/snippet_spec.rb' + - 'spec/models/ssh_host_key_spec.rb' + - 'spec/models/upload_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/policies/ci/bridge_policy_spec.rb' + - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' + - 'spec/presenters/group_member_presenter_spec.rb' + - 'spec/presenters/merge_request_presenter_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/presenters/project_member_presenter_spec.rb' + - 'spec/presenters/project_presenter_spec.rb' + - 'spec/requests/api/avatar_spec.rb' + - 'spec/requests/api/container_registry_event_spec.rb' + - 'spec/requests/api/graphql/mutations/design_management/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' + - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' + - 'spec/requests/api/graphql/project/pipeline_spec.rb' + - 'spec/requests/api/helpers_spec.rb' + - 'spec/requests/api/import_bitbucket_server_spec.rb' + - 'spec/requests/api/import_github_spec.rb' + - 'spec/requests/api/internal/base_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' + - 'spec/requests/api/project_container_repositories_spec.rb' + - 'spec/requests/api/users_preferences_spec.rb' + - 'spec/requests/jwt_controller_spec.rb' + - 'spec/requests/whats_new_controller_spec.rb' + - 'spec/rubocop/migration_helpers_spec.rb' + - 'spec/scripts/setup/find_jh_branch_spec.rb' + - 'spec/serializers/accessibility_reports_comparer_serializer_spec.rb' + - 'spec/serializers/admin/user_entity_spec.rb' + - 'spec/serializers/base_discussion_entity_spec.rb' + - 'spec/serializers/build_action_entity_spec.rb' + - 'spec/serializers/build_details_entity_spec.rb' + - 'spec/serializers/build_trace_entity_spec.rb' + - 'spec/serializers/ci/dag_job_entity_spec.rb' + - 'spec/serializers/ci/dag_job_group_entity_spec.rb' + - 'spec/serializers/ci/dag_pipeline_entity_spec.rb' + - 'spec/serializers/ci/dag_stage_entity_spec.rb' + - 'spec/serializers/ci/daily_build_group_report_result_entity_spec.rb' + - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' + - 'spec/serializers/ci/job_entity_spec.rb' + - 'spec/serializers/ci/pipeline_entity_spec.rb' + - 'spec/serializers/codequality_reports_comparer_serializer_spec.rb' + - 'spec/serializers/commit_entity_spec.rb' + - 'spec/serializers/container_repositories_serializer_spec.rb' + - 'spec/serializers/container_repository_entity_spec.rb' + - 'spec/serializers/container_tag_entity_spec.rb' + - 'spec/serializers/deployment_cluster_entity_spec.rb' + - 'spec/serializers/deployment_entity_spec.rb' + - 'spec/serializers/detailed_status_entity_spec.rb' + - 'spec/serializers/diffs_entity_spec.rb' + - 'spec/serializers/diffs_metadata_entity_spec.rb' + - 'spec/serializers/discussion_entity_spec.rb' + - 'spec/serializers/environment_entity_spec.rb' + - 'spec/serializers/environment_serializer_spec.rb' + - 'spec/serializers/environment_status_entity_spec.rb' + - 'spec/serializers/feature_flag_entity_spec.rb' + - 'spec/serializers/feature_flag_summary_entity_spec.rb' + - 'spec/serializers/group_child_entity_spec.rb' + - 'spec/serializers/group_child_serializer_spec.rb' + - 'spec/serializers/import/manifest_provider_repo_entity_spec.rb' + - 'spec/serializers/issuable_sidebar_extras_entity_spec.rb' + - 'spec/serializers/issue_board_entity_spec.rb' + - 'spec/serializers/issue_entity_spec.rb' + - 'spec/serializers/lfs_file_lock_entity_spec.rb' + - 'spec/serializers/linked_project_issue_entity_spec.rb' + - 'spec/serializers/merge_request_poll_cached_widget_entity_spec.rb' + - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'spec/serializers/merge_request_sidebar_basic_entity_spec.rb' + - 'spec/serializers/merge_request_sidebar_extras_entity_spec.rb' + - 'spec/serializers/merge_request_widget_commit_entity_spec.rb' + - 'spec/serializers/merge_request_widget_entity_spec.rb' + - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' + - 'spec/serializers/note_entity_spec.rb' + - 'spec/serializers/paginated_diff_entity_spec.rb' + - 'spec/serializers/pipeline_details_entity_spec.rb' + - 'spec/serializers/pipeline_serializer_spec.rb' + - 'spec/serializers/project_note_entity_spec.rb' + - 'spec/serializers/prometheus_alert_entity_spec.rb' + - 'spec/serializers/review_app_setup_entity_spec.rb' + - 'spec/serializers/runner_entity_spec.rb' + - 'spec/serializers/stage_entity_spec.rb' + - 'spec/serializers/suggestion_entity_spec.rb' + - 'spec/serializers/test_reports_comparer_serializer_spec.rb' + - 'spec/serializers/test_suite_entity_spec.rb' + - 'spec/serializers/trigger_variable_entity_spec.rb' + - 'spec/services/access_token_validation_service_spec.rb' + - 'spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb' + - 'spec/services/award_emojis/toggle_service_spec.rb' + - 'spec/services/base_count_service_spec.rb' + - 'spec/services/bulk_imports/file_download_service_spec.rb' + - 'spec/services/ci/change_variables_service_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb' + - 'spec/services/ci/prepare_build_service_spec.rb' + - 'spec/services/ci/process_pipeline_service_spec.rb' + - 'spec/services/ci/register_job_service_spec.rb' + - 'spec/services/ci/test_failure_history_service_spec.rb' + - 'spec/services/ci/update_build_queue_service_spec.rb' + - 'spec/services/ci/update_build_state_service_spec.rb' + - 'spec/services/clusters/aws/finalize_creation_service_spec.rb' + - 'spec/services/clusters/aws/provision_service_spec.rb' + - 'spec/services/clusters/aws/verify_provision_status_service_spec.rb' + - 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb' + - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' + - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' + - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' + - 'spec/services/deployments/create_service_spec.rb' + - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' + - 'spec/services/event_create_service_spec.rb' + - 'spec/services/git/base_hooks_service_spec.rb' + - 'spec/services/git/process_ref_changes_service_spec.rb' + - 'spec/services/git/wiki_push_service/change_spec.rb' + - 'spec/services/ide/schemas_config_service_spec.rb' + - 'spec/services/import/bitbucket_server_service_spec.rb' + - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/jira_connect_subscriptions/create_service_spec.rb' + - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' + - 'spec/services/merge_requests/approval_service_spec.rb' + - 'spec/services/merge_requests/build_service_spec.rb' + - 'spec/services/merge_requests/close_service_spec.rb' + - 'spec/services/merge_requests/merge_service_spec.rb' + - 'spec/services/merge_requests/post_merge_service_spec.rb' + - 'spec/services/merge_requests/refresh_service_spec.rb' + - 'spec/services/merge_requests/reopen_service_spec.rb' + - 'spec/services/merge_requests/request_review_service_spec.rb' + - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' + - 'spec/services/metrics/users_starred_dashboards/create_service_spec.rb' + - 'spec/services/milestones/update_service_spec.rb' + - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' + - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/notes/render_service_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/packages/generic/create_package_file_service_spec.rb' + - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' + - 'spec/services/packages/maven/metadata/sync_service_spec.rb' + - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' + - 'spec/services/pages/zip_directory_service_spec.rb' + - 'spec/services/post_receive_service_spec.rb' + - 'spec/services/projects/branches_by_mode_service_spec.rb' + - 'spec/services/projects/create_service_spec.rb' + - 'spec/services/projects/destroy_service_spec.rb' + - 'spec/services/projects/import_service_spec.rb' + - 'spec/services/projects/operations/update_service_spec.rb' + - 'spec/services/projects/overwrite_project_service_spec.rb' + - 'spec/services/projects/update_pages_service_spec.rb' + - 'spec/services/projects/update_remote_mirror_service_spec.rb' + - 'spec/services/projects/update_repository_storage_service_spec.rb' + - 'spec/services/projects/update_service_spec.rb' + - 'spec/services/repositories/changelog_service_spec.rb' + - 'spec/services/search_service_spec.rb' + - 'spec/services/snippets/update_repository_storage_service_spec.rb' + - 'spec/services/spam/akismet_mark_as_spam_service_spec.rb' + - 'spec/services/spam/akismet_service_spec.rb' + - 'spec/services/spam/ham_service_spec.rb' + - 'spec/services/spam/spam_action_service_spec.rb' + - 'spec/services/spam/spam_params_spec.rb' + - 'spec/services/system_note_service_spec.rb' + - 'spec/services/system_notes/commit_service_spec.rb' + - 'spec/services/system_notes/issuables_service_spec.rb' + - 'spec/services/update_merge_request_metrics_service_spec.rb' + - 'spec/services/users/activity_service_spec.rb' + - 'spec/services/users/create_service_spec.rb' + - 'spec/services/users/refresh_authorized_projects_service_spec.rb' + - 'spec/services/users/update_service_spec.rb' + - 'spec/services/web_hook_service_spec.rb' + - 'spec/services/wiki_pages/base_service_spec.rb' + - 'spec/spam/concerns/has_spam_action_response_fields_spec.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/helpers/import_spec_helper.rb' + - 'spec/support/helpers/ldap_helpers.rb' + - 'spec/support/helpers/project_forks_helper.rb' + - 'spec/support/helpers/stub_metrics.rb' + - 'spec/support/helpers/stub_spam_services.rb' + - 'spec/support/import_export/common_util.rb' + - 'spec/support/prometheus/additional_metrics_shared_examples.rb' + - 'spec/support/shared_contexts/lib/gitlab/sidekiq_middleware/server_metrics_shared_context.rb' + - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' + - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' + - 'spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb' + - 'spec/support/shared_examples/graphql/mutations/http_integrations_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb' + - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' + - 'spec/support/shared_examples/metrics/sampler_shared_examples.rb' + - 'spec/support/shared_examples/models/chat_integration_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' + - 'spec/support/shared_examples/models/members_notifications_shared_example.rb' + - 'spec/support/shared_examples/models/project_ci_cd_settings_shared_examples.rb' + - 'spec/support/shared_examples/namespaces/hierarchy_examples.rb' + - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/debian_common_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/nuget_endpoints_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' + - 'spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb' + - 'spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb' + - 'spec/support/shared_examples/services/alert_management/alert_processing/notifications_shared_examples.rb' + - 'spec/support/shared_examples/services/alert_management_shared_examples.rb' + - 'spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb' + - 'spec/support/shared_examples/services/check_ingress_ip_address_service_shared_examples.rb' + - 'spec/support/shared_examples/services/jira/requests/base_shared_examples.rb' + - 'spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb' + - 'spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb' + - 'spec/support/shared_examples/services/resource_events/synthetic_notes_builder_shared_examples.rb' + - 'spec/support/shared_examples/workers/background_migration_worker_shared_examples.rb' + - 'spec/support/shared_examples/workers/update_repository_move_shared_examples.rb' + - 'spec/tasks/gettext_rake_spec.rb' + - 'spec/tasks/gitlab/background_migrations_rake_spec.rb' + - 'spec/tasks/gitlab/check_rake_spec.rb' + - 'spec/tasks/gitlab/cleanup_rake_spec.rb' + - 'spec/tasks/gitlab/db_rake_spec.rb' + - 'spec/tasks/gitlab/packages/events_rake_spec.rb' + - 'spec/tasks/gitlab/setup_rake_spec.rb' + - 'spec/tooling/danger/project_helper_spec.rb' + - 'spec/tooling/lib/tooling/helm3_client_spec.rb' + - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' + - 'spec/tooling/rspec_flaky/example_spec.rb' + - 'spec/tooling/rspec_flaky/listener_spec.rb' + - 'spec/uploaders/file_uploader_spec.rb' + - 'spec/uploaders/object_storage_spec.rb' + - 'spec/uploaders/personal_file_uploader_spec.rb' + - 'spec/uploaders/records_uploads_spec.rb' + - 'spec/views/projects/issues/show.html.haml_spec.rb' + - 'spec/views/shared/milestones/_issuables.html.haml_spec.rb' + - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' + - 'spec/workers/bulk_imports/export_request_worker_spec.rb' + - 'spec/workers/chat_notification_worker_spec.rb' + - 'spec/workers/ci/build_prepare_worker_spec.rb' + - 'spec/workers/ci/create_cross_project_pipeline_worker_spec.rb' + - 'spec/workers/ci/create_downstream_pipeline_worker_spec.rb' + - 'spec/workers/ci/pipeline_bridge_status_worker_spec.rb' + - 'spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb' + - 'spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb' + - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' + - 'spec/workers/concerns/application_worker_spec.rb' + - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' + - 'spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb' + - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' + - 'spec/workers/create_commit_signature_worker_spec.rb' + - 'spec/workers/environments/auto_stop_worker_spec.rb' + - 'spec/workers/error_tracking_issue_link_worker_spec.rb' + - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' + - 'spec/workers/gitlab/github_import/import_diff_note_worker_spec.rb' + - 'spec/workers/gitlab/github_import/import_issue_worker_spec.rb' + - 'spec/workers/gitlab/github_import/import_note_worker_spec.rb' + - 'spec/workers/gitlab/github_import/import_pull_request_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/finish_import_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_base_data_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_lfs_objects_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_notes_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_pull_requests_merged_by_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_pull_requests_reviews_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_pull_requests_worker_spec.rb' + - 'spec/workers/gitlab/github_import/stage/import_repository_worker_spec.rb' + - 'spec/workers/gitlab_performance_bar_stats_worker_spec.rb' + - 'spec/workers/invalid_gpg_signature_update_worker_spec.rb' + - 'spec/workers/issues/rebalancing_worker_spec.rb' + - 'spec/workers/merge_request_mergeability_check_worker_spec.rb' + - 'spec/workers/new_issue_worker_spec.rb' + - 'spec/workers/new_merge_request_worker_spec.rb' + - 'spec/workers/pages_domain_ssl_renewal_worker_spec.rb' + - 'spec/workers/pages_domain_verification_worker_spec.rb' + - 'spec/workers/post_receive_spec.rb' + - 'spec/workers/project_cache_worker_spec.rb' + - 'spec/workers/projects/after_import_worker_spec.rb' + - 'spec/workers/propagate_integration_group_worker_spec.rb' + - 'spec/workers/propagate_integration_inherit_descendant_worker_spec.rb' + - 'spec/workers/propagate_integration_inherit_worker_spec.rb' + - 'spec/workers/propagate_integration_project_worker_spec.rb' + - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' + - 'spec/workers/repository_import_worker_spec.rb' + - 'spec/workers/system_hook_push_worker_spec.rb' diff --git a/.rubocop_todo/security/io_methods.yml b/.rubocop_todo/security/io_methods.yml new file mode 100644 index 00000000000..936bb21d5dc --- /dev/null +++ b/.rubocop_todo/security/io_methods.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --autocorrect. +Security/IoMethods: + Details: grace period + Exclude: + - 'db/migrate/20210301200959_init_schema.rb' diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml index a4fae856953..a5586813885 100644 --- a/.rubocop_todo/style/accessor_grouping.yml +++ b/.rubocop_todo/style/accessor_grouping.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/AccessorGrouping: Exclude: - 'app/finders/template_finder.rb' @@ -57,7 +57,6 @@ Style/AccessorGrouping: - 'lib/gitlab/http_io.rb' - 'lib/gitlab/import_export/group/legacy_tree_restorer.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' - - 'lib/gitlab/merge_requests/commit_message_generator.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/suggestions/file_suggestion.rb' diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index cb40669ca02..e98660024db 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/BarePercentLiterals: Exclude: - 'app/models/commit.rb' @@ -75,7 +75,6 @@ Style/BarePercentLiterals: - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - 'spec/lib/gitlab/diff/highlight_spec.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index bff827ba5d3..2303c5a1652 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/ClassAndModuleChildren: Exclude: - 'app/components/pajamas/toggle_component.rb' @@ -8,11 +8,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/applications_controller.rb' - - 'app/controllers/admin/background_jobs_controller.rb' - - 'app/controllers/admin/background_migrations_controller.rb' - - 'app/controllers/admin/batched_jobs_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - - 'app/controllers/admin/ci/variables_controller.rb' - 'app/controllers/admin/clusters/integrations_controller.rb' - 'app/controllers/admin/clusters_controller.rb' - 'app/controllers/admin/cohorts_controller.rb' @@ -22,7 +17,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/admin/gitaly_servers_controller.rb' - 'app/controllers/admin/groups_controller.rb' - 'app/controllers/admin/health_check_controller.rb' - - 'app/controllers/admin/hook_logs_controller.rb' - 'app/controllers/admin/hooks_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/impersonation_tokens_controller.rb' @@ -47,7 +41,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/clusters/base_controller.rb' - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/integrations/actions.rb' - - 'app/controllers/concerns/integrations/hooks_execution.rb' - 'app/controllers/concerns/metrics/dashboard/prometheus_api_proxy.rb' - 'app/controllers/concerns/snippets/blobs_actions.rb' - 'app/controllers/concerns/snippets/send_blob.rb' @@ -149,7 +142,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/ci/daily_build_group_report_results_controller.rb' - 'app/controllers/projects/ci/lints_controller.rb' - 'app/controllers/projects/ci/pipeline_editor_controller.rb' - - 'app/controllers/projects/ci/secure_files_controller.rb' - 'app/controllers/projects/cluster_agents_controller.rb' - 'app/controllers/projects/clusters/integrations_controller.rb' - 'app/controllers/projects/clusters_controller.rb' @@ -178,7 +170,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/google_cloud/gcp_regions_controller.rb' - 'app/controllers/projects/google_cloud/revoke_oauth_controller.rb' - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' - - 'app/controllers/projects/google_cloud_controller.rb' - 'app/controllers/projects/grafana_api_controller.rb' - 'app/controllers/projects/graphs_controller.rb' - 'app/controllers/projects/group_links_controller.rb' @@ -207,7 +198,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/pipeline_schedules_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/pipelines_settings_controller.rb' - - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/project_members_controller.rb' - 'app/controllers/projects/protected_branches_controller.rb' - 'app/controllers/projects/protected_refs_controller.rb' @@ -225,7 +215,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/snippets/blobs_controller.rb' - 'app/controllers/projects/snippets_controller.rb' - 'app/controllers/projects/starrers_controller.rb' - - 'app/controllers/projects/tags/releases_controller.rb' - 'app/controllers/projects/tags_controller.rb' - 'app/controllers/projects/templates_controller.rb' - 'app/controllers/projects/terraform_controller.rb' @@ -361,7 +350,6 @@ Style/ClassAndModuleChildren: - 'app/workers/merge_requests/delete_source_branch_worker.rb' - 'app/workers/merge_requests/handle_assignees_change_worker.rb' - 'app/workers/merge_requests/resolve_todos_worker.rb' - - 'config/initializers/active_record_data_types.rb' - 'config/initializers/http_hostname_override.rb' - 'config/initializers/httpclient_patch.rb' - 'config/initializers/omniauth.rb' @@ -429,12 +417,10 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/groups/security/merge_commit_reports_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' - - 'ee/app/controllers/groups/usage_quotas_controller.rb' - 'ee/app/controllers/groups/wikis_controller.rb' - 'ee/app/controllers/oauth/geo_auth_controller.rb' - 'ee/app/controllers/profiles/billings_controller.rb' - 'ee/app/controllers/profiles/slacks_controller.rb' - - 'ee/app/controllers/profiles/usage_quotas_controller.rb' - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' - 'ee/app/controllers/projects/approver_groups_controller.rb' @@ -500,7 +486,6 @@ Style/ClassAndModuleChildren: - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/protected_branch/required_code_owners_section.rb' - 'ee/app/models/protected_branch/unprotect_access_level.rb' - - 'ee/app/models/protected_environment/deploy_access_level.rb' - 'ee/app/serializers/vulnerabilities/feedback_entity.rb' - 'ee/app/serializers/vulnerabilities/feedback_serializer.rb' - 'ee/app/serializers/vulnerabilities/finding_diff_serializer.rb' @@ -515,9 +500,7 @@ Style/ClassAndModuleChildren: - 'ee/app/services/ee/projects/after_rename_service.rb' - 'ee/app/services/ee/projects/disable_deploy_key_service.rb' - 'ee/app/services/ee/projects/enable_deploy_key_service.rb' - - 'ee/app/services/ee/projects/update_pages_service.rb' - 'ee/db/fixtures/development/20_burndown.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/db/fixtures/development/21_dast_profiles.rb' - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' - 'ee/db/fixtures/development/32_compliance_report_violations.rb' @@ -536,7 +519,6 @@ Style/ClassAndModuleChildren: - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/ci/badge/base.rb' - 'lib/gitlab/ci/badge/coverage/metadata.rb' - 'lib/gitlab/ci/badge/coverage/report.rb' diff --git a/.rubocop_todo/style/conditional_assignment.yml b/.rubocop_todo/style/conditional_assignment.yml index c9bbaaeb175..d16f2f7c3a7 100644 --- a/.rubocop_todo/style/conditional_assignment.yml +++ b/.rubocop_todo/style/conditional_assignment.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/ConditionalAssignment: Exclude: - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/style/each_for_simple_loop.yml b/.rubocop_todo/style/each_for_simple_loop.yml index 5d495f890d2..e7f99d69528 100644 --- a/.rubocop_todo/style/each_for_simple_loop.yml +++ b/.rubocop_todo/style/each_for_simple_loop.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/EachForSimpleLoop: Exclude: - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb' diff --git a/.rubocop_todo/style/empty_else.yml b/.rubocop_todo/style/empty_else.yml index 07e42692f60..bd30b4a7c50 100644 --- a/.rubocop_todo/style/empty_else.yml +++ b/.rubocop_todo/style/empty_else.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/EmptyElse: Exclude: - 'app/controllers/concerns/issuable_collections_action.rb' @@ -24,7 +24,6 @@ Style/EmptyElse: - 'app/models/resource_timebox_event.rb' - 'app/services/award_emojis/add_service.rb' - 'app/services/merge_requests/update_service.rb' - - 'app/workers/gitlab/github_import/stage/import_issue_events_worker.rb' - 'app/workers/post_receive.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - 'ee/app/controllers/admin/audit_logs_controller.rb' @@ -37,7 +36,6 @@ Style/EmptyElse: - 'ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/workers/gitlab_subscriptions/notify_seats_exceeded_worker.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/lib/elastic/latest/note_instance_proxy.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb' - 'ee/lib/gitlab/geo/oauth/logout_token.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 300d8678719..0c7eb5c0d92 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/EmptyMethod: Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' @@ -11,7 +11,6 @@ Style/EmptyMethod: - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/topics_controller.rb' - 'app/controllers/admin/usage_trends_controller.rb' - - 'app/controllers/admin/users_controller.rb' - 'app/controllers/concerns/boards_actions.rb' - 'app/controllers/groups/milestones_controller.rb' - 'app/controllers/groups/runners_controller.rb' @@ -44,7 +43,6 @@ Style/EmptyMethod: - 'app/controllers/projects/mattermosts_controller.rb' - 'app/controllers/projects/pages_domains_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/runners_controller.rb' - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/projects/settings/packages_and_registries_controller.rb' @@ -165,30 +163,3 @@ Style/EmptyMethod: - 'qa/qa/service/cluster_provider/k3d.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - 'qa/qa/service/cluster_provider/minikube.rb' - - 'spec/controllers/concerns/check_rate_limit_spec.rb' - - 'spec/controllers/concerns/issuable_actions_spec.rb' - - 'spec/initializers/forbid_sidekiq_in_transactions_spec.rb' - - 'spec/lib/api/helpers/rate_limiter_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - - 'spec/lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin_spec.rb' - - 'spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb' - - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' - - 'spec/lib/gitlab/repository_archive_rate_limiter_spec.rb' - - 'spec/lib/gitlab/repository_cache_adapter_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/instrumentation_logger_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/worker_context/client_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - - 'spec/lib/gitlab/ssh_public_key_spec.rb' - - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' - - 'spec/lib/gitlab/utils/delegator_override_spec.rb' - - 'spec/lib/gitlab/utils/override_spec.rb' - - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - - 'spec/workers/concerns/waitable_worker_spec.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 20e8c976fb7..50874266979 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/ExplicitBlockArgument: Exclude: - 'app/controllers/admin/background_migrations_controller.rb' @@ -38,7 +38,6 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/application_context.rb' - 'lib/gitlab/authorized_keys.rb' - 'lib/gitlab/cache.rb' - - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - 'lib/gitlab/ci/reports/test_suite.rb' - 'lib/gitlab/ci/variables/collection.rb' - 'lib/gitlab/cleanup/remote_uploads.rb' @@ -74,16 +73,6 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/sidekiq_status.rb' - 'lib/gitlab/utils/measuring.rb' - 'lib/tasks/config_lint.rake' - - 'qa/qa/ee/page/insights/show.rb' - - 'qa/qa/ee/page/operations_dashboard.rb' - - 'qa/qa/ee/page/project/issue/show.rb' - - 'qa/qa/ee/page/project/show.rb' - - 'qa/qa/ee/page/project/wiki/show.rb' - - 'qa/qa/flow/login.rb' - - 'qa/qa/page/admin/menu.rb' - - 'qa/qa/page/base.rb' - - 'qa/qa/page/component/blob_content.rb' - - 'qa/qa/page/group/settings/group_deploy_tokens.rb' - 'qa/qa/page/profile/menu.rb' - 'qa/qa/page/project/settings/deploy_keys.rb' - 'qa/qa/page/project/settings/deploy_tokens.rb' diff --git a/.rubocop_todo/style/float_division.yml b/.rubocop_todo/style/float_division.yml index 7fd0cda469d..b5cc208b836 100644 --- a/.rubocop_todo/style/float_division.yml +++ b/.rubocop_todo/style/float_division.yml @@ -1,7 +1,7 @@ --- +# Cop supports --autocorrect. Style/FloatDivision: Exclude: - 'ee/app/models/geo_node_status.rb' - 'ee/app/models/namespaces/storage/root_size.rb' - - 'qa/qa/support/formatters/allure_metadata_formatter.rb' - 'qa/qa/tools/reliable_report.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 4da3c32416c..c1ba754edca 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/FormatString: Exclude: - 'app/components/diffs/overflow_warning_component.rb' @@ -14,7 +14,6 @@ Style/FormatString: - 'app/controllers/concerns/confirm_email_warning.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/concerns/integrations/actions.rb' - - 'app/controllers/concerns/integrations/hooks_execution.rb' - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/redirects_for_missing_path_on_tree.rb' - 'app/controllers/concerns/spammable_actions/akismet_mark_as_spam_action.rb' @@ -28,7 +27,6 @@ Style/FormatString: - 'app/controllers/import/gitlab_groups_controller.rb' - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/invites_controller.rb' - - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/chat_names_controller.rb' - 'app/controllers/profiles/emails_controller.rb' @@ -48,7 +46,6 @@ Style/FormatString: - 'app/finders/todos_finder.rb' - 'app/graphql/mutations/release_asset_links/create.rb' - 'app/helpers/auth_helper.rb' - - 'app/helpers/blob_helper.rb' - 'app/helpers/button_helper.rb' - 'app/helpers/ci/builds_helper.rb' - 'app/helpers/ci/pipelines_helper.rb' @@ -65,7 +62,6 @@ Style/FormatString: - 'app/helpers/members_helper.rb' - 'app/helpers/merge_requests_helper.rb' - 'app/helpers/mirror_helper.rb' - - 'app/helpers/notify_helper.rb' - 'app/helpers/preferences_helper.rb' - 'app/helpers/profiles_helper.rb' - 'app/helpers/projects/project_members_helper.rb' @@ -74,7 +70,6 @@ Style/FormatString: - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/ssh_keys_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/tags_helper.rb' - 'app/helpers/time_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -91,7 +86,6 @@ Style/FormatString: - 'app/models/concerns/limitable.rb' - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/concerns/spammable.rb' - - 'app/models/concerns/timebox.rb' - 'app/models/concerns/token_authenticatable_strategies/encrypted.rb' - 'app/models/container_expiration_policy.rb' - 'app/models/custom_emoji.rb' @@ -111,7 +105,6 @@ Style/FormatString: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/ewm.rb' - 'app/models/integrations/external_wiki.rb' - - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' @@ -126,7 +119,6 @@ Style/FormatString: - 'app/models/integrations/webex_teams.rb' - 'app/models/integrations/youtrack.rb' - 'app/models/integrations/zentao.rb' - - 'app/models/merge_request.rb' - 'app/models/merge_request_diff.rb' - 'app/models/milestone.rb' - 'app/models/pages_domain.rb' @@ -134,30 +126,25 @@ Style/FormatString: - 'app/models/resource_event.rb' - 'app/models/sent_notification.rb' - 'app/models/serverless/domain.rb' - - 'app/models/snippet.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' + - 'app/presenters/key_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' - - 'app/presenters/key_presenter.rb' - 'app/serializers/build_details_entity.rb' - 'app/services/alert_management/alerts/update_service.rb' - 'app/services/boards/lists/base_create_service.rb' - - 'app/services/bulk_imports/file_download_service.rb' - 'app/services/clusters/applications/check_progress_service.rb' - - 'app/services/clusters/applications/check_uninstall_progress_service.rb' - 'app/services/clusters/applications/install_service.rb' - - 'app/services/clusters/applications/patch_service.rb' - 'app/services/clusters/applications/upgrade_service.rb' - 'app/services/clusters/aws/authorize_role_service.rb' - 'app/services/clusters/aws/finalize_creation_service.rb' - 'app/services/clusters/aws/verify_provision_status_service.rb' - 'app/services/clusters/gcp/finalize_creation_service.rb' - 'app/services/clusters/gcp/verify_provision_status_service.rb' - - 'app/services/clusters/kubernetes/configure_istio_ingress_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' - 'app/services/concerns/validates_classification_label.rb' - 'app/services/gravatar_service.rb' @@ -195,12 +182,8 @@ Style/FormatString: - 'config/initializers/rack_lineprof.rb' - 'danger/roulette/Dangerfile' - 'ee/app/components/billing/plan_component.rb' - - 'ee/app/components/namespaces/free_user_cap/alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personable.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_preview_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_usage_quota_limitations_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' @@ -213,7 +196,6 @@ Style/FormatString: - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' - 'ee/app/controllers/groups/saml_group_links_controller.rb' - - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - 'ee/app/controllers/subscriptions/groups_controller.rb' @@ -221,7 +203,6 @@ Style/FormatString: - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/reporting_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' @@ -271,8 +252,6 @@ Style/FormatString: - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' - 'ee/app/validators/user_existence_validator.rb' - 'ee/lib/audit/details.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - - 'ee/lib/ee/audit/project_setting_changes_auditor.rb' - 'ee/lib/ee/gitlab/checks/push_rules/branch_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb' @@ -301,7 +280,6 @@ Style/FormatString: - 'lib/api/helpers/packages/conan/api_helpers.rb' - 'lib/bulk_imports/network_error.rb' - 'lib/bulk_imports/users_mapper.rb' - - 'lib/flowdock/git/builder.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/checks/push_file_count_check.rb' - 'lib/gitlab/ci/ansi2json/line.rb' @@ -314,7 +292,6 @@ Style/FormatString: - 'lib/gitlab/console.rb' - 'lib/gitlab/database/async_indexes/index_creator.rb' - 'lib/gitlab/database/background_migration/batched_migration.rb' - - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - 'lib/gitlab/database/partitioning/time_partition.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' @@ -371,7 +348,6 @@ Style/FormatString: - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/graphql/project/jira_projects_spec.rb' - - 'spec/services/clusters/applications/patch_service_spec.rb' - 'spec/services/clusters/applications/upgrade_service_spec.rb' - 'spec/services/groups/import_export/export_service_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index f46f8c8f4f6..59aa38fc9f5 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. Style/GuardClause: Exclude: - 'app/controllers/admin/users_controller.rb' @@ -16,18 +17,9 @@ Style/GuardClause: - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/page_limiter.rb' - - 'app/controllers/concerns/product_analytics_tracking.rb' - - 'app/controllers/concerns/record_user_last_activity.rb' - - 'app/controllers/concerns/routable_actions.rb' - - 'app/controllers/concerns/snippets/blobs_actions.rb' - - 'app/controllers/concerns/uploads_actions.rb' - - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' - - 'app/controllers/ide_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' @@ -35,7 +27,6 @@ Style/GuardClause: - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/projects/application_controller.rb' - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/branches_controller.rb' - 'app/controllers/projects/commit_controller.rb' - 'app/controllers/projects/compare_controller.rb' - 'app/controllers/projects/design_management/designs/resized_image_controller.rb' @@ -69,7 +60,6 @@ Style/GuardClause: - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/board_list_issues_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' @@ -123,22 +113,17 @@ Style/GuardClause: - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/experiment_subject.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' - 'app/models/grafana_integration.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/field.rb' - - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - - 'app/models/integrations/teamcity.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' - 'app/models/member.rb' @@ -170,7 +155,6 @@ Style/GuardClause: - 'app/models/snippet_input_action.rb' - 'app/models/user.rb' - 'app/models/users/in_product_marketing_email.rb' - - 'app/models/wiki.rb' - 'app/models/work_item.rb' - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' @@ -194,7 +178,6 @@ Style/GuardClause: - 'app/services/commits/create_service.rb' - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb' - - 'app/services/concerns/rate_limited_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' - 'app/services/concerns/validates_classification_label.rb' - 'app/services/deployments/update_environment_service.rb' @@ -221,7 +204,6 @@ Style/GuardClause: - 'app/services/merge_requests/add_spent_time_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' @@ -260,8 +242,6 @@ Style/GuardClause: - 'app/uploaders/file_uploader.rb' - 'app/validators/abstract_path_validator.rb' - 'app/validators/any_field_validator.rb' - - 'app/validators/array_members_validator.rb' - - 'app/validators/branch_filter_validator.rb' - 'app/validators/certificate_fingerprint_validator.rb' - 'app/validators/certificate_key_validator.rb' - 'app/validators/certificate_validator.rb' @@ -292,7 +272,6 @@ Style/GuardClause: - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/postgresql_cte.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - 'db/migrate/20210302212623_rename_vuln_fingerprints_indexes.rb' @@ -322,13 +301,11 @@ Style/GuardClause: - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - - 'ee/app/finders/ee/notes_finder.rb' - 'ee/app/finders/ee/template_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' - 'ee/app/graphql/resolvers/epics_resolver.rb' @@ -374,12 +351,10 @@ Style/GuardClause: - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/incident_management/oncall_rotation.rb' - 'ee/app/models/ip_restriction.rb' - - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' - 'ee/app/models/protected_environments/deploy_access_level.rb' - - 'ee/app/models/sbom/occurrence.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' @@ -426,7 +401,6 @@ Style/GuardClause: - 'ee/app/services/iterations/delete_service.rb' - 'ee/app/services/merge_trains/check_status_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - - 'ee/app/services/merge_trains/refresh_service.rb' - 'ee/app/services/namespaces/storage/email_notification_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' @@ -445,12 +419,10 @@ Style/GuardClause: - 'ee/db/geo/migrate/20180314175612_add_partial_index_to_project_registy_verification_failure_columns.rb' - 'ee/db/geo/migrate/20180315222132_add_partial_index_to_project_registy_checksum_columns.rb' - 'ee/db/geo/migrate/20180412213305_add_index_to_artifact_id_on_job_artifact_registry.rb' - - 'ee/lib/ee/api/ci/job_artifacts.rb' - 'ee/lib/ee/api/features.rb' - 'ee/lib/ee/api/helpers/projects_helpers.rb' - 'ee/lib/ee/api/projects.rb' - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/audit/project_ci_cd_setting_changes_auditor.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb' - 'ee/lib/ee/gitlab/auth/o_auth/user.rb' @@ -586,7 +558,6 @@ Style/GuardClause: - 'lib/gitlab/gitaly_client/blobs_stitcher.rb' - 'lib/gitlab/gitaly_client/conflicts_service.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' - - 'lib/gitlab/gitaly_client/wiki_service.rb' - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' @@ -596,7 +567,6 @@ Style/GuardClause: - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - - 'lib/gitlab/i18n/metadata_entry.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' - 'lib/gitlab/import_export/base/object_builder.rb' @@ -616,7 +586,6 @@ Style/GuardClause: - 'lib/gitlab/legacy_github_import/client.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/marginalia.rb' - - 'lib/gitlab/memory/watchdog.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/active_record.rb' @@ -659,7 +628,6 @@ Style/GuardClause: - 'lib/gitlab/utils/override.rb' - 'lib/gitlab/webpack/manifest.rb' - 'lib/mattermost/session.rb' - - 'lib/release_highlights/validator/entry.rb' - 'lib/safe_zip/entry.rb' - 'lib/service_ping/devops_report.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' @@ -670,7 +638,6 @@ Style/GuardClause: - 'qa/qa/ee/resource/license.rb' - 'qa/qa/mobile/page/main/menu.rb' - 'qa/qa/mobile/page/sub_menus/common.rb' - - 'qa/qa/page/base.rb' - 'qa/qa/page/component/invite_members_modal.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' @@ -679,7 +646,6 @@ Style/GuardClause: - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/package.rb' - - 'qa/qa/resource/project.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' @@ -688,20 +654,15 @@ Style/GuardClause: - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/cop/gitlab/policy_rule_boolean.rb' - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - 'rubocop/cop/rspec/web_mock_enable.rb' - - 'rubocop/cop/usage_data/histogram_with_large_table.rb' - 'rubocop/cop/usage_data/large_table.rb' - 'rubocop/routes_under_scope.rb' - 'scripts/lint_templates_bash.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index aa22e9ed82b..911ed2f02c4 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -1,11 +1,10 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/HashAsLastArrayItem: Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/groups_controller.rb' - 'app/controllers/admin/users_controller.rb' - - 'app/controllers/boards/issues_controller.rb' - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/profiles_controller.rb' @@ -17,7 +16,6 @@ Style/HashAsLastArrayItem: - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects_controller.rb' - 'app/graphql/resolvers/clusters/agents_resolver.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/types/boards/board_issuable_input_base_type.rb' - 'app/graphql/types/boards/board_issue_input_base_type.rb' - 'app/helpers/namespaces_helper.rb' @@ -35,7 +33,6 @@ Style/HashAsLastArrayItem: - 'ee/app/controllers/ee/admin/groups_controller.rb' - 'ee/app/controllers/ee/admin/users_controller.rb' - 'ee/app/controllers/groups/epics_controller.rb' - - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/types/epics/negated_epic_filter_input_type.rb' - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/vulnerability.rb' @@ -43,7 +40,6 @@ Style/HashAsLastArrayItem: - 'ee/app/serializers/dashboard_environments_serializer.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'lib/api/entities/project.rb' diff --git a/.rubocop_todo/style/hash_each_methods.yml b/.rubocop_todo/style/hash_each_methods.yml index cebfe5c0c7d..41e6c4608cc 100644 --- a/.rubocop_todo/style/hash_each_methods.yml +++ b/.rubocop_todo/style/hash_each_methods.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/HashEachMethods: Exclude: - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' @@ -52,7 +52,6 @@ Style/HashEachMethods: - 'ee/spec/helpers/application_helper_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'lib/api/todos.rb' - - 'lib/backup/manager.rb' - 'lib/gitlab/changelog/release.rb' - 'lib/gitlab/ci/parsers.rb' - 'lib/gitlab/ci/reports/test_suite.rb' @@ -60,16 +59,12 @@ Style/HashEachMethods: - 'lib/gitlab/metrics/subscribers/active_record.rb' - 'lib/gitlab/metrics/subscribers/load_balancing.rb' - 'lib/gitlab/middleware/multipart.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - - 'lib/gitlab/usage_data.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/resource_group_spec.rb' - 'spec/models/clusters/cluster_spec.rb' diff --git a/.rubocop_todo/style/if_inside_else.yml b/.rubocop_todo/style/if_inside_else.yml deleted file mode 100644 index 40b71d7de04..00000000000 --- a/.rubocop_todo/style/if_inside_else.yml +++ /dev/null @@ -1,48 +0,0 @@ ---- -Style/IfInsideElse: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/passwords_controller.rb' - - 'app/finders/projects_finder.rb' - - 'app/helpers/diff_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/members_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/models/namespace.rb' - - 'app/presenters/project_presenter.rb' - - 'app/services/system_notes/commit_service.rb' - - 'app/services/task_list_toggle_service.rb' - - 'app/services/user_project_access_changed_service.rb' - - 'app/uploaders/gitlab_uploader.rb' - - 'config/settings.rb' - - 'ee/app/controllers/ee/registrations/welcome_controller.rb' - - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/protected_environments/authorizable.rb' - - 'ee/app/policies/ee/group_policy.rb' - - 'ee/app/services/app_sec/dast/site_profiles/audit/update_service.rb' - - 'ee/app/services/deployments/approval_service.rb' - - 'ee/app/services/geo/framework_repository_sync_service.rb' - - 'ee/app/services/geo/repository_base_sync_service.rb' - - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' - - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' - - 'ee/app/workers/elastic/project_transfer_worker.rb' - - 'ee/app/workers/project_import_schedule_worker.rb' - - 'ee/lib/gitlab/geo/base_batcher.rb' - - 'lib/api/projects.rb' - - 'lib/gitlab/auth.rb' - - 'lib/gitlab/conflict/file.rb' - - 'lib/gitlab/sql/pattern.rb' - - 'lib/gitlab/usage/service_ping/payload_keys_processor.rb' - - 'lib/service_ping/build_payload.rb' - - 'lib/tasks/gitlab/cleanup.rake' - - 'lib/tasks/gitlab/shell.rake' - - 'qa/qa/resource/protected_branch.rb' - - 'qa/qa/specs/helpers/feature_flag.rb' - - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - - 'scripts/review_apps/automated_cleanup.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/support/import_export/export_file_helper.rb' - - 'spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb' - - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index fc05a8bc163..5804fda39e1 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -1,26 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/IfUnlessModifier: Exclude: - - 'app/channels/graphql_channel.rb' - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/users_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' - - 'app/controllers/concerns/cycle_analytics_params.rb' - - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/concerns/issuable_collections.rb' - - 'app/controllers/concerns/issues_calendar.rb' - - 'app/controllers/concerns/labels_as_hash.rb' - - 'app/controllers/concerns/metrics/dashboard/prometheus_api_proxy.rb' - - 'app/controllers/concerns/metrics_dashboard.rb' - - 'app/controllers/concerns/notes_actions.rb' - - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/paginated_collection.rb' - - 'app/controllers/concerns/record_user_last_activity.rb' - - 'app/controllers/concerns/sorting_preference.rb' - 'app/controllers/concerns/uploads_actions.rb' - 'app/controllers/concerns/verifies_with_email.rb' - 'app/controllers/concerns/wiki_actions.rb' @@ -31,7 +12,6 @@ Style/IfUnlessModifier: - 'app/controllers/groups_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' @@ -43,7 +23,6 @@ Style/IfUnlessModifier: - 'app/controllers/projects/branches_controller.rb' - 'app/controllers/projects/commits_controller.rb' - 'app/controllers/projects/cycle_analytics_controller.rb' - - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/design_management/designs_controller.rb' - 'app/controllers/projects/imports_controller.rb' - 'app/controllers/projects/issues_controller.rb' @@ -93,7 +72,6 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/todos/mark_all_done.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/project_pipeline_resolver.rb' - 'app/graphql/resolvers/timelog_resolver.rb' @@ -189,14 +167,10 @@ Style/IfUnlessModifier: - 'app/models/grafana_integration.rb' - 'app/models/group.rb' - 'app/models/integrations/asana.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pushover.rb' - - 'app/models/integrations/teamcity.rb' - 'app/models/issue.rb' - 'app/models/issue_email_participant.rb' - 'app/models/label_note.rb' @@ -259,7 +233,6 @@ Style/IfUnlessModifier: - 'app/services/boards/lists/base_create_service.rb' - 'app/services/boards/lists/list_service.rb' - 'app/services/branches/validate_new_service.rb' - - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/job_token_scope/remove_project_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' @@ -271,7 +244,6 @@ Style/IfUnlessModifier: - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/update_build_state_service.rb' - 'app/services/clusters/applications/base_service.rb' - - 'app/services/clusters/applications/prometheus_update_service.rb' - 'app/services/clusters/aws/fetch_credentials_service.rb' - 'app/services/clusters/gcp/provision_service.rb' - 'app/services/clusters/update_service.rb' @@ -292,13 +264,11 @@ Style/IfUnlessModifier: - 'app/services/error_tracking/collect_error_service.rb' - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'app/services/google_cloud/setup_cloudsql_instance_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_statistics_service.rb' - 'app/services/ide/base_config_service.rb' - 'app/services/import/bitbucket_server_service.rb' - - 'app/services/import/github_service.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/issuable/bulk_update_service.rb' - 'app/services/issuable/common_system_notes_service.rb' @@ -368,12 +338,10 @@ Style/IfUnlessModifier: - 'app/services/spam/spam_verdict_service.rb' - 'app/services/system_notes/issuables_service.rb' - 'app/services/tags/destroy_service.rb' - - 'app/services/two_factor/destroy_service.rb' - 'app/services/users/approve_service.rb' - 'app/services/users/build_service.rb' - 'app/services/users/respond_to_terms_service.rb' - 'app/services/wikis/create_attachment_service.rb' - - 'app/services/work_items/create_service.rb' - 'app/services/work_items/parent_links/create_service.rb' - 'app/services/work_items/task_list_reference_removal_service.rb' - 'app/services/work_items/task_list_reference_replacement_service.rb' @@ -382,7 +350,6 @@ Style/IfUnlessModifier: - 'app/validators/abstract_path_validator.rb' - 'app/validators/addressable_url_validator.rb' - 'app/validators/any_field_validator.rb' - - 'app/validators/branch_filter_validator.rb' - 'app/validators/certificate_key_validator.rb' - 'app/validators/certificate_validator.rb' - 'app/validators/cluster_name_validator.rb' @@ -399,9 +366,7 @@ Style/IfUnlessModifier: - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - 'app/workers/concerns/project_start_import.rb' - - 'app/workers/concerns/waitable_worker.rb' - 'app/workers/concerns/worker_attributes.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/delete_container_repository_worker.rb' - 'app/workers/file_hook_worker.rb' - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' @@ -427,10 +392,8 @@ Style/IfUnlessModifier: - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/jira.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - - 'config/initializers/load_balancing.rb' - 'config/initializers/remove_active_job_execute_callback.rb' - 'config/initializers/seed_fu.rb' - - 'config/initializers/sidekiq.rb' - 'config/initializers/stackprof.rb' - 'config/initializers/validate_database_config.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' @@ -477,15 +440,12 @@ Style/IfUnlessModifier: - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/destroy.rb' - 'ee/app/graphql/mutations/boards/scoped_board_mutation.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' @@ -598,8 +558,6 @@ Style/IfUnlessModifier: - 'ee/app/services/geo/metrics_update_service.rb' - 'ee/app/services/geo/move_repository_service.rb' - 'ee/app/services/geo/prune_event_log_service.rb' - - 'ee/app/services/geo/repository_verification_primary_service.rb' - - 'ee/app/services/geo/repository_verification_secondary_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' - 'ee/app/services/groups/memberships/export_service.rb' - 'ee/app/services/groups/update_repository_storage_service.rb' @@ -659,9 +617,7 @@ Style/IfUnlessModifier: - 'ee/lib/ee/api/helpers/variables_helpers.rb' - 'ee/lib/ee/api/internal/base.rb' - 'ee/lib/ee/api/merge_request_approvals.rb' - - 'ee/lib/ee/api/protected_branches.rb' - 'ee/lib/ee/api/settings.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' @@ -740,7 +696,6 @@ Style/IfUnlessModifier: - 'ee/spec/support/helpers/feature_approval_helper.rb' - 'ee/spec/support/helpers/search_results_helpers.rb' - 'ee/spec/support/http_io/http_io_helpers.rb' - - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'lib/api/api_guard.rb' @@ -865,7 +820,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/extendable/entry.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - 'lib/gitlab/ci/config/external/file/template.rb' - - 'lib/gitlab/ci/config/external/mapper.rb' - 'lib/gitlab/ci/config/normalizer.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' - 'lib/gitlab/ci/parsers/security/common.rb' @@ -1023,7 +977,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/template_parser/eval_state.rb' - 'lib/gitlab/untrusted_regexp.rb' - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/utils.rb' @@ -1055,7 +1008,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - - 'qa/qa/flow/sign_up.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/element.rb' @@ -1080,7 +1032,6 @@ Style/IfUnlessModifier: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - - 'qa/qa/support/loglinking.rb' - 'qa/qa/tools/delete_projects.rb' - 'qa/qa/tools/delete_user_projects.rb' - 'qa/qa/tools/generate_perf_testdata.rb' @@ -1125,7 +1076,6 @@ Style/IfUnlessModifier: - 'spec/helpers/invite_members_helper_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' @@ -1148,10 +1098,8 @@ Style/IfUnlessModifier: - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' - - 'spec/rubocop_spec_helper.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - 'spec/services/git/process_ref_changes_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' @@ -1162,7 +1110,6 @@ Style/IfUnlessModifier: - 'spec/services/projects/create_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' - - 'spec/support/database/multiple_databases.rb' - 'spec/support/external_authorization_service_helpers.rb' - 'spec/support/flaky_tests.rb' - 'spec/support/generate-seed-repo-rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index ca6cb416b93..3730a86221e 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -1,30 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/KeywordParametersOrder: Exclude: - - 'app/controllers/concerns/product_analytics_tracking.rb' - - 'app/finders/group_descendants_finder.rb' - - 'app/finders/merge_request_target_project_finder.rb' - - 'app/graphql/resolvers/package_pipelines_resolver.rb' - - 'app/helpers/timeboxes_helper.rb' - - 'app/models/concerns/sortable.rb' - - 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/file_upload.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' - - 'app/services/issues/create_service.rb' - - 'app/services/merge_requests/push_options_handler_service.rb' - - 'app/services/snippets/create_service.rb' - - 'app/services/work_items/create_and_link_service.rb' - - 'app/services/work_items/create_from_task_service.rb' - - 'app/services/work_items/create_service.rb' - - 'app/services/work_items/delete_task_service.rb' - - 'ee/app/graphql/mutations/dast/profiles/create.rb' - - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/update.rb' - - 'ee/app/models/license.rb' - - 'ee/app/models/requirements_management/test_report.rb' - - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/create_service.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service.rb' - 'ee/app/services/audit_events/user_impersonation_group_audit_event_service.rb' @@ -46,30 +23,3 @@ Style/KeywordParametersOrder: - 'lib/gitlab/merge_requests/mergeability/results_store.rb' - 'lib/gitlab/usage_data_counters/editor_unique_counter.rb' - 'lib/microsoft_teams/notifier.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/spec/runtime/env_spec.rb' - - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/confirm_support_bot_user_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - - 'spec/support/helpers/doc_url_helper.rb' - - 'spec/support/helpers/smime_helper.rb' - - 'spec/support/helpers/workhorse_helpers.rb' - - 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb' - - 'spec/support/shared_examples/services/container_expiration_policy_shared_examples.rb' - - 'spec/support/shared_examples/services/dependency_proxy_ttl_policies_shared_examples.rb' - - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' - - 'spec/tasks/gitlab/usage_data_rake_spec.rb' - - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' diff --git a/.rubocop_todo/style/lambda.yml b/.rubocop_todo/style/lambda.yml index f37c2c4967e..e1c297ac5f6 100644 --- a/.rubocop_todo/style/lambda.yml +++ b/.rubocop_todo/style/lambda.yml @@ -49,7 +49,6 @@ Style/Lambda: - 'lib/gitlab/action_cable/request_store_callbacks.rb' - 'lib/gitlab/checks/diff_check.rb' - 'lib/gitlab/database/load_balancing/action_cable_callbacks.rb' - - 'lib/gitlab/memory/watchdog/configurator.rb' - 'lib/gitlab/middleware/rack_multipart_tempfile_factory.rb' - 'lib/gitlab/omniauth_initializer.rb' - 'lib/gitlab/prometheus/queries/query_additional_metrics.rb' @@ -57,7 +56,6 @@ Style/Lambda: - 'lib/gitlab/sidekiq_config/worker_matcher.rb' - 'lib/gitlab/sidekiq_middleware.rb' - 'lib/gitlab/utils/usage_data.rb' - - 'qa/qa/page/base.rb' - 'qa/qa/runtime/allure_report.rb' - 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb' - 'qa/qa/support/api.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index 295aa2f6878..6800ba2baf3 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/Next: Exclude: - 'lib/gitlab/fogbugz_import/importer.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 4e8b608e424..0060919d7b6 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/NumericLiteralPrefix: Exclude: - 'app/models/container_repository.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index bac2e807053..2f042829e35 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -1,31 +1,8 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/PercentLiteralDelimiters: Exclude: - 'Guardfile' - - 'app/controllers/abuse_reports_controller.rb' - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/impersonation.rb' - - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/uploads_actions.rb' - - 'app/controllers/groups_controller.rb' - - 'app/controllers/import/bulk_imports_controller.rb' - - 'app/controllers/import/fogbugz_controller.rb' - - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/jira_connect/app_descriptor_controller.rb' - - 'app/controllers/jira_connect/subscriptions_controller.rb' - - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - - 'app/controllers/projects/product_analytics_controller.rb' - - 'app/controllers/projects/service_desk_controller.rb' - - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/finders/group_members_finder.rb' - - 'app/finders/members_finder.rb' - - 'app/finders/notes_finder.rb' - - 'app/finders/todos_finder.rb' - - 'app/helpers/application_helper.rb' - 'app/helpers/auth_helper.rb' - 'app/helpers/ci/variables_helper.rb' - 'app/helpers/clusters_helper.rb' @@ -33,7 +10,6 @@ Style/PercentLiteralDelimiters: - 'app/helpers/diff_helper.rb' - 'app/helpers/emails_helper.rb' - 'app/helpers/external_link_helper.rb' - - 'app/helpers/icons_helper.rb' - 'app/helpers/labels_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/helpers/nav_helper.rb' @@ -82,7 +58,6 @@ Style/PercentLiteralDelimiters: - 'app/models/concerns/clusters/agents/authorization_config_scopes.rb' - 'app/models/concerns/diff_positionable_note.rb' - 'app/models/concerns/enums/prometheus_metric.rb' - - 'app/models/concerns/integrations/base_data_fields.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issue_available_features.rb' - 'app/models/concerns/mentionable/reference_regexes.rb' @@ -112,7 +87,6 @@ Style/PercentLiteralDelimiters: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/external_wiki.rb' - 'app/models/integrations/field.rb' - - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/packagist.rb' @@ -159,13 +133,11 @@ Style/PercentLiteralDelimiters: - 'app/services/import_export_clean_up_service.rb' - 'app/services/incident_management/pager_duty/process_webhook_service.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issues/export_csv_service.rb' - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/default_embed_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/preview_markdown_service.rb' - 'app/services/projects/apple_target_platform_detector_service.rb' - - 'app/services/projects/container_repository/cleanup_tags_service.rb' - 'app/services/projects/download_service.rb' - 'app/services/projects/hashed_storage/migrate_attachments_service.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' @@ -201,7 +173,6 @@ Style/PercentLiteralDelimiters: - 'config/initializers/invisible_captcha.rb' - 'config/initializers/lograge.rb' - 'config/initializers/rspec_profiling.rb' - - 'config/initializers/sidekiq.rb' - 'config/initializers_before_autoloader/000_inflections.rb' - 'config/object_store_settings.rb' - 'config/spring.rb' @@ -269,7 +240,6 @@ Style/PercentLiteralDelimiters: - 'ee/app/models/geo_node_status.rb' - 'ee/app/models/incident_management/issuable_resource_link.rb' - 'ee/app/models/integrations/github.rb' - - 'ee/app/models/integrations/gitlab_slack_application.rb' - 'ee/app/models/merge_requests/status_check_response.rb' - 'ee/app/models/saml_provider.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' @@ -285,7 +255,6 @@ Style/PercentLiteralDelimiters: - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/iterations/update_service.rb' - 'ee/app/services/jira/jql_builder_service.rb' - - 'ee/app/services/requirements_management/export_csv_service.rb' - 'ee/app/services/security/configuration/save_auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' @@ -296,7 +265,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/api/helpers/projects_helpers.rb' - 'ee/lib/ee/api/members.rb' - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/audit/group_changes_auditor.rb' - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' - 'ee/lib/ee/gitlab/auth/ldap/adapter.rb' - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' @@ -306,7 +274,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/path_regex.rb' - - 'ee/lib/ee/gitlab/uploads/migration_helper.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/elastic/class_proxy_util.rb' - 'ee/lib/elastic/latest/config.rb' @@ -315,8 +282,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/elastic/latest/project_instance_proxy.rb' - 'ee/lib/elastic/latest/snippet_class_proxy.rb' - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - - 'ee/lib/gitlab/ci/parsers/security/formatters/dast.rb' - - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/tasks/gitlab/elastic/test.rake' @@ -339,7 +304,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/features/projects/environments/environments_spec.rb' - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' - 'ee/spec/frontend/fixtures/saml_providers.rb' @@ -347,7 +311,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/graphql/ee/types/boards/board_issue_input_type_spec.rb' - 'ee/spec/graphql/mutations/boards/update_spec.rb' - 'ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb' - - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/pipeline_security_report_findings_resolver_spec.rb' - 'ee/spec/graphql/types/dast/profile_cadence_enum_spec.rb' - 'ee/spec/graphql/types/dast/scan_method_type_enum_spec.rb' @@ -439,7 +402,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/policies/group_policy_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/presenters/merge_request_approver_presenter_spec.rb' - - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' - 'ee/spec/requests/api/dependencies_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' @@ -483,7 +445,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/validators/json_schema_validator_spec.rb' - 'ee/spec/views/operations/index.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' - 'ee/spec/workers/project_cache_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' @@ -523,7 +484,6 @@ Style/PercentLiteralDelimiters: - 'lib/bitbucket/representation/issue.rb' - 'lib/container_registry/path.rb' - 'lib/feature.rb' - - 'lib/flowdock/git/builder.rb' - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - 'lib/generators/gitlab/usage_metric_generator.rb' - 'lib/gitlab.rb' @@ -591,11 +551,9 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/sanitizers/exif.rb' - 'lib/gitlab/search/abuse_detection.rb' - 'lib/gitlab/search_context.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/slash_commands/presenters/base.rb' - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/task_helpers.rb' - - 'lib/gitlab/uploads/migration_helper.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' @@ -626,7 +584,6 @@ Style/PercentLiteralDelimiters: - 'qa/qa/ee/page/project/issue/show.rb' - 'qa/qa/ee/page/project/job/show.rb' - 'qa/qa/ee/page/project/packages/index.rb' - - 'qa/qa/ee/page/project/pipeline/show.rb' - 'qa/qa/ee/page/project/show.rb' - 'qa/qa/ee/page/project/snippet/index.rb' - 'qa/qa/ee/page/project/wiki/show.rb' @@ -635,7 +592,6 @@ Style/PercentLiteralDelimiters: - 'qa/qa/resource/visibility.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' @@ -704,7 +660,6 @@ Style/PercentLiteralDelimiters: - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/protected_branches_spec.rb' - 'spec/features/tags/developer_views_tags_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/alert_management/alerts_finder_spec.rb' @@ -742,7 +697,6 @@ Style/PercentLiteralDelimiters: - 'spec/helpers/page_layout_helper_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/tracking_helper_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' - 'spec/initializers/enumerator_next_patch_spec.rb' @@ -814,7 +768,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/deployment_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb' @@ -1083,7 +1036,6 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/api/unleash_spec.rb' - 'spec/requests/api/users_spec.rb' - - 'spec/requests/api/version_spec.rb' - 'spec/requests/api/wikis_spec.rb' - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' @@ -1111,7 +1063,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' - 'spec/services/ci/stuck_builds/drop_running_service_spec.rb' - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/deployments/update_environment_service_spec.rb' - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' @@ -1137,7 +1088,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/product_analytics/build_graph_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_link_service_spec.rb' - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/record_target_platforms_service_spec.rb' @@ -1191,7 +1141,6 @@ Style/PercentLiteralDelimiters: - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' @@ -1226,7 +1175,6 @@ Style/PercentLiteralDelimiters: - 'spec/workers/post_receive_spec.rb' - 'spec/workers/project_cache_worker_spec.rb' - 'spec/workers/projects/record_target_platforms_worker_spec.rb' - - 'spec/workers/repository_import_worker_spec.rb' - 'spec/workers/stuck_merge_jobs_worker_spec.rb' - 'spec/workers/update_project_statistics_worker_spec.rb' - 'tooling/danger/datateam.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml index d2851de201b..8f490002fd6 100644 --- a/.rubocop_todo/style/redundant_begin.yml +++ b/.rubocop_todo/style/redundant_begin.yml @@ -1,56 +1,6 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantBegin: Exclude: - - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/metrics_dashboard.rb' - - 'app/controllers/concerns/renders_ldap_servers.rb' - - 'app/helpers/auth_helper.rb' - - 'app/models/event.rb' - - 'app/models/integrations/asana.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/user.rb' - - 'app/services/ci/register_job_service.rb' - - 'app/services/design_management/generate_image_versions_service.rb' - - 'app/services/error_tracking/list_projects_service.rb' - - 'app/services/issue_links/create_service.rb' - - 'app/services/merge_requests/assign_issues_service.rb' - - 'app/services/projects/batch_forks_count_service.rb' - - 'app/services/projects/batch_open_issues_count_service.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/users/update_highest_member_role_service.rb' - - 'ee/app/controllers/groups/sso_controller.rb' - - 'ee/app/finders/security/findings_finder.rb' - - 'ee/app/services/epics/epic_links/create_service.rb' - - 'ee/app/services/epics/related_epic_links/create_service.rb' - - 'ee/app/services/geo/container_repository_sync_service.rb' - - 'ee/app/validators/ee/json_schema_validator.rb' - - 'ee/lib/ee/api/helpers/award_emoji.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' - - 'ee/lib/gitlab/ci/parsers/security/dast.rb' - - 'ee/lib/omni_auth/strategies/group_saml.rb' - - 'ee/lib/system_check/geo/authorized_keys_check.rb' - - 'lib/api/helpers/award_emoji.rb' - - 'lib/api/time_tracking_endpoints.rb' - - 'lib/atlassian/jira_connect/serializers/build_entity.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/pipeline/wiki_pipeline.rb' - - 'lib/gem_extensions/active_record/association.rb' - - 'lib/gitlab.rb' - - 'lib/gitlab/changes_list.rb' - - 'lib/gitlab/color.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' - - 'lib/gitlab/favicon.rb' - - 'lib/gitlab/import_export/base/relation_factory.rb' - - 'lib/gitlab/import_export/members_mapper.rb' - - 'lib/gitlab/import_export/project/tree_saver.rb' - - 'lib/gitlab/instrumentation/redis_interceptor.rb' - - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - - 'lib/gitlab/phabricator_import/project_creator.rb' - - 'lib/gitlab/project_search_results.rb' - - 'lib/gitlab/shell.rb' - - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' - - 'lib/sidebars/menu.rb' - - 'qa/qa/resource/api_fabricator.rb' - - 'qa/qa/runtime/api/client.rb' diff --git a/.rubocop_todo/style/redundant_condition.yml b/.rubocop_todo/style/redundant_condition.yml index 86be40f7ffa..c94a65c202c 100644 --- a/.rubocop_todo/style/redundant_condition.yml +++ b/.rubocop_todo/style/redundant_condition.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantCondition: Exclude: - 'ee/app/models/license.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index ca7e01ffa61..b0d69cd2950 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -1,62 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantInterpolation: Exclude: - - 'app/components/diffs/stats_component.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/ci/runners_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/dropdowns_helper.rb' - - 'app/helpers/environments_helper.rb' - - 'app/helpers/icons_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/nav_helper.rb' - - 'app/helpers/projects_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/helpers/tooling/visual_review_helper.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/integrations/base_chat_notification.rb' - - 'app/models/integrations/hangouts_chat.rb' - - 'app/models/integrations/microsoft_teams.rb' - - 'app/models/integrations/pushover.rb' - - 'app/models/merge_request.rb' - - 'app/services/jira_import/start_import_service.rb' - - 'app/services/users/approve_service.rb' - - 'app/services/users/banned_user_base_service.rb' - - 'app/services/users/reject_service.rb' - - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' - - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb' - - 'ee/app/helpers/ee/ci/runners_helper.rb' - - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/services/geo/event_store.rb' - - 'ee/app/services/geo/repository_updated_service.rb' - - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb' - - 'ee/app/services/users/abuse/excessive_projects_download_ban_service.rb' - - 'ee/app/services/users/abuse/git_abuse/namespace_throttle_service.rb' - - 'ee/db/fixtures/development/31_devops_adoption.rb' - - 'ee/lib/gitlab/insights/serializers/chartjs/base_serializer.rb' - - 'ee/spec/features/epics/epic_issues_spec.rb' - - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' - - 'ee/spec/features/registrations/one_trust_spec.rb' - - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - - 'ee/spec/lib/gitlab/insights/serializers/chartjs/line_serializer_spec.rb' - - 'ee/spec/lib/gitlab/insights/serializers/chartjs/multi_series_serializer_spec.rb' - - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' - - 'ee/spec/requests/api/issues_spec.rb' - - 'ee/spec/requests/api/search_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - - 'ee/spec/services/search_service_spec.rb' - - 'ee/spec/services/timebox_report_service_spec.rb' - - 'ee/spec/support/shared_contexts/lib/gitlab/insights/serializers/serializers_shared_context.rb' - - 'ee/spec/support/shared_examples/lib/gitlab/elastic/standalone_indices_shared_examples.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/backup/manager.rb' - 'lib/backup/task.rb' - 'lib/gitlab/application_rate_limiter.rb' @@ -72,7 +17,6 @@ Style/RedundantInterpolation: - 'lib/gitlab/repository_cache_adapter.rb' - 'lib/gitlab/repository_hash_cache.rb' - 'lib/gitlab/repository_set_cache.rb' - - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints.rb' - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/usage_data_counters/search_counter.rb' @@ -88,7 +32,6 @@ Style/RedundantInterpolation: - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/scan_result_policy_vulnerabilities_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/project_templates_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/parent_child_pipelines_dependent_relationship_spec.rb' - 'qa/qa/tools/generate_perf_testdata.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml deleted file mode 100644 index 1ca658776b8..00000000000 --- a/.rubocop_todo/style/redundant_parentheses.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/RedundantParentheses: - Exclude: - - 'lib/gitlab/database/tables_truncate.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/billing_seats_usage_data_spec.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index 5c97275ee4b..22608a8e1f5 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantRegexpEscape: Exclude: - 'app/controllers/help_controller.rb' @@ -11,7 +11,6 @@ Style/RedundantRegexpEscape: - 'app/models/deploy_token.rb' - 'app/models/design_management/design.rb' - 'app/models/integrations/chat_message/base_message.rb' - - 'app/models/integrations/datadog.rb' - 'app/models/integrations/teamcity.rb' - 'app/models/issue.rb' - 'app/models/label.rb' @@ -23,7 +22,6 @@ Style/RedundantRegexpEscape: - 'app/models/snippet.rb' - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' - 'app/uploaders/file_uploader.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/routes/project.rb' - 'config/routes/uploads.rb' - 'ee/app/models/ee/epic.rb' @@ -60,7 +58,6 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/git/repository.rb' - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/harbor/query.rb' - - 'lib/gitlab/incoming_email.rb' - 'lib/gitlab/jira/dvcs.rb' - 'lib/gitlab/path_regex.rb' - 'lib/gitlab/private_commit_email.rb' @@ -68,7 +65,6 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/regex.rb' - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/service_desk_email.rb' - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/url_sanitizer.rb' - 'lib/gitlab/utils.rb' @@ -78,40 +74,8 @@ Style/RedundantRegexpEscape: - 'lib/tasks/gettext.rake' - 'lib/tasks/gitlab/info.rake' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/spec/runtime/key/ecdsa_spec.rb' - 'qa/spec/runtime/key/ed25519_spec.rb' - 'qa/spec/runtime/key/rsa_spec.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - 'scripts/qa/testcases-check' - 'scripts/setup/find-jh-branch.rb' - - 'spec/controllers/projects_controller_spec.rb' - - 'spec/features/read_only_spec.rb' - - 'spec/helpers/tab_helper_spec.rb' - - 'spec/lib/banzai/filter/references/reference_filter_spec.rb' - - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' - - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - - 'spec/lib/gitlab/ci/config_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - - 'spec/lib/gitlab/import_export/saver_spec.rb' - - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - - 'spec/lib/gitlab/sql/pattern_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/mailers/emails/profile_spec.rb' - - 'spec/models/release_highlight_spec.rb' - - 'spec/requests/api/graphql/mutations/merge_requests/set_draft_spec.rb' - - 'spec/requests/api/graphql_spec.rb' - - 'spec/requests/api/project_debian_distributions_spec.rb' - - 'spec/requests/api/repositories_spec.rb' - - 'spec/services/projects/download_service_spec.rb' - - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_examples/features/wiki/file_attachments_shared_examples.rb' - - 'spec/support/shared_examples/mailers/notify_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/uploaders/personal_file_uploader_spec.rb' - - 'spec/views/help/index.html.haml_spec.rb' - - 'tooling/danger/project_helper.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 8c688dc89c1..ec9aaac85dc 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantSelf: Exclude: - 'app/channels/awareness_channel.rb' @@ -71,7 +71,6 @@ Style/RedundantSelf: - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/merge_request_reviewer_state.rb' - 'app/models/concerns/noteable.rb' - - 'app/models/concerns/packages/debian/distribution.rb' - 'app/models/concerns/participable.rb' - 'app/models/concerns/pg_full_text_searchable.rb' - 'app/models/concerns/protected_ref.rb' @@ -112,7 +111,6 @@ Style/RedundantSelf: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - - 'app/models/integrations/slack.rb' - 'app/models/integrations/zentao.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -190,7 +188,6 @@ Style/RedundantSelf: - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'db/post_migrate/20210329102724_add_new_trail_plans.rb' - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' @@ -223,7 +220,6 @@ Style/RedundantSelf: - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/member.rb' - - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/packages/package_file.rb' - 'ee/app/models/ee/project.rb' @@ -420,7 +416,6 @@ Style/RedundantSelf: - 'qa/qa/resource/user_gpg.rb' - 'qa/qa/runtime/release.rb' - 'qa/qa/scenario/bootable.rb' - - 'qa/qa/scenario/test/instance.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' - 'spec/graphql/resolvers/group_labels_resolver_spec.rb' - 'spec/helpers/emails_helper_spec.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index a85039a45f5..8d35373a2c0 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/SingleArgumentDig: Exclude: - 'app/graphql/resolvers/namespace_projects_resolver.rb' @@ -38,7 +38,6 @@ Style/SingleArgumentDig: - 'lib/gitlab/auth/o_auth/auth_hash.rb' - 'lib/gitlab/ci/badge/coverage/template.rb' - 'lib/gitlab/ci/badge/template.rb' - - 'lib/gitlab/ci/lint.rb' - 'lib/gitlab/ci/parsers/accessibility/pa11y.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - 'lib/gitlab/ci/reports/codequality_reports.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 3c663b5f89a..20b70d36ce2 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/SoleNestedConditional: Exclude: - 'app/controllers/admin/application_settings_controller.rb' @@ -24,7 +24,6 @@ Style/SoleNestedConditional: - 'app/services/projects/create_service.rb' - 'app/services/projects/hashed_storage/migration_service.rb' - 'app/services/projects/hashed_storage/rollback_service.rb' - - 'app/workers/merge_requests/delete_source_branch_worker.rb' - 'ee/app/finders/ee/snippets_finder.rb' - 'ee/app/services/ee/issue_links/create_service.rb' - 'ee/app/services/ee/lfs/unlock_file_service.rb' @@ -39,7 +38,6 @@ Style/SoleNestedConditional: - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/gitlab/code_owners/groups_loader.rb' - - 'lib/api/ci/helpers/runner.rb' - 'lib/api/deploy_keys.rb' - 'lib/api/helpers/label_helpers.rb' - 'lib/api/maven_packages.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 65389d798d3..91eb45f73cf 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -1,24 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/StringConcatenation: Exclude: - - 'app/components/pajamas/button_component.rb' - - 'app/controllers/concerns/creates_commit.rb' - - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/projects/labels_controller.rb' - 'app/controllers/projects/milestones_controller.rb' - - 'app/graphql/types/global_id_type.rb' - - 'app/helpers/application_helper.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/dropdowns_helper.rb' - - 'app/helpers/emails_helper.rb' - - 'app/helpers/events_helper.rb' - - 'app/helpers/numbers_helper.rb' - - 'app/helpers/submodule_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/application_setting.rb' - - 'app/models/commit_range.rb' - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/from_set_operator.rb' @@ -66,7 +51,6 @@ Style/StringConcatenation: - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/workers/scan_security_report_secrets_worker.rb' - 'ee/lib/api/project_mirror.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' @@ -77,7 +61,6 @@ Style/StringConcatenation: - 'ee/lib/omni_auth/strategies/kerberos.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/license.rake' - - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/features/boards/boards_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' @@ -124,7 +107,6 @@ Style/StringConcatenation: - 'lib/gitlab/git.rb' - 'lib/gitlab/git/branch.rb' - 'lib/gitlab/git/tag.rb' - - 'lib/gitlab/git/wiki.rb' - 'lib/gitlab/github_import/importer/labels_importer.rb' - 'lib/gitlab/graphql/negatable_arguments.rb' - 'lib/gitlab/graphql/queries.rb' @@ -184,7 +166,6 @@ Style/StringConcatenation: - 'spec/features/projects/commits/user_browses_commits_spec.rb' - 'spec/features/projects/files/files_sort_submodules_with_folders_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' - - 'spec/features/search/user_searches_for_code_spec.rb' - 'spec/finders/packages/go/module_finder_spec.rb' - 'spec/graphql/mutations/issues/create_spec.rb' - 'spec/helpers/application_helper_spec.rb' @@ -227,7 +208,6 @@ Style/StringConcatenation: - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/remote_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/wiki_service_spec.rb' - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/other_markup_spec.rb' @@ -262,9 +242,9 @@ Style/StringConcatenation: - 'spec/models/custom_emoji_spec.rb' - 'spec/models/grafana_integration_spec.rb' - 'spec/models/integrations/campfire_spec.rb' - - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/chat_message/push_message_spec.rb' + - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' @@ -292,7 +272,6 @@ Style/StringConcatenation: - 'spec/routing/git_http_routing_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/clusters/gcp/finalize_creation_service_spec.rb' - - 'spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' @@ -311,7 +290,6 @@ Style/StringConcatenation: - 'spec/services/snippets/bulk_destroy_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' - 'spec/services/todo_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 29e94e77345..f601674a4bf 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -1,10 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/StringLiteralsInInterpolation: Exclude: - 'app/graphql/mutations/base_mutation.rb' - 'app/helpers/colors_helper.rb' - - 'app/helpers/todos_helper.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/ci/namespace_mirror.rb' - 'app/models/integrations/campfire.rb' @@ -21,7 +20,6 @@ Style/StringLiteralsInInterpolation: - 'ee/app/models/license.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/lib/ee/api/helpers/issues_helpers.rb' - - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' @@ -29,7 +27,6 @@ Style/StringLiteralsInInterpolation: - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/validations/validators/check_assignees_count.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' - - 'lib/banzai/filter/syntax_highlight_filter.rb' - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/ci/config/entry/job.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index d373788dbc6..074b400c4bb 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/SymbolProc: Exclude: - 'app/controllers/admin/users_controller.rb' @@ -13,7 +13,6 @@ Style/SymbolProc: - 'app/graphql/mutations/commits/create.rb' - 'app/graphql/mutations/concerns/mutations/work_items/widgetable.rb' - 'app/graphql/mutations/jira_import/start.rb' - - 'app/graphql/mutations/work_items/update_widgets.rb' - 'app/graphql/types/work_items/widgets/description_type.rb' - 'app/helpers/graph_helper.rb' - 'app/models/ci/build_metadata.rb' @@ -54,7 +53,6 @@ Style/SymbolProc: - 'app/serializers/linked_project_issue_entity.rb' - 'app/serializers/member_entity.rb' - 'app/serializers/member_user_entity.rb' - - 'app/serializers/merge_request_poll_widget_entity.rb' - 'app/serializers/merge_request_widget_entity.rb' - 'app/serializers/project_entity.rb' - 'app/serializers/project_mirror_entity.rb' @@ -172,7 +170,6 @@ Style/SymbolProc: - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' - 'lib/gitlab/git/diff_stats_collection.rb' - 'lib/gitlab/gitaly_client/commit_service.rb' - - 'lib/gitlab/gitaly_client/wiki_service.rb' - 'lib/gitlab/import_export/attributes_finder.rb' - 'lib/gitlab/import_export/base/relation_object_saver.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' @@ -199,12 +196,10 @@ Style/SymbolProc: - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/custom_variable_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_status_on_operation_dashboard_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/cop/gitlab/namespaced_class.rb' |