diff options
Diffstat (limited to '.rubocop_todo/style/guard_clause.yml')
-rw-r--r-- | .rubocop_todo/style/guard_clause.yml | 41 |
1 files changed, 1 insertions, 40 deletions
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index f46f8c8f4f6..59aa38fc9f5 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. Style/GuardClause: Exclude: - 'app/controllers/admin/users_controller.rb' @@ -16,18 +17,9 @@ Style/GuardClause: - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/page_limiter.rb' - - 'app/controllers/concerns/product_analytics_tracking.rb' - - 'app/controllers/concerns/record_user_last_activity.rb' - - 'app/controllers/concerns/routable_actions.rb' - - 'app/controllers/concerns/snippets/blobs_actions.rb' - - 'app/controllers/concerns/uploads_actions.rb' - - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' - - 'app/controllers/ide_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' @@ -35,7 +27,6 @@ Style/GuardClause: - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/projects/application_controller.rb' - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/branches_controller.rb' - 'app/controllers/projects/commit_controller.rb' - 'app/controllers/projects/compare_controller.rb' - 'app/controllers/projects/design_management/designs/resized_image_controller.rb' @@ -69,7 +60,6 @@ Style/GuardClause: - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/board_list_issues_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' @@ -123,22 +113,17 @@ Style/GuardClause: - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/experiment_subject.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' - 'app/models/grafana_integration.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/field.rb' - - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - - 'app/models/integrations/teamcity.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' - 'app/models/member.rb' @@ -170,7 +155,6 @@ Style/GuardClause: - 'app/models/snippet_input_action.rb' - 'app/models/user.rb' - 'app/models/users/in_product_marketing_email.rb' - - 'app/models/wiki.rb' - 'app/models/work_item.rb' - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' @@ -194,7 +178,6 @@ Style/GuardClause: - 'app/services/commits/create_service.rb' - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb' - - 'app/services/concerns/rate_limited_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' - 'app/services/concerns/validates_classification_label.rb' - 'app/services/deployments/update_environment_service.rb' @@ -221,7 +204,6 @@ Style/GuardClause: - 'app/services/merge_requests/add_spent_time_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' @@ -260,8 +242,6 @@ Style/GuardClause: - 'app/uploaders/file_uploader.rb' - 'app/validators/abstract_path_validator.rb' - 'app/validators/any_field_validator.rb' - - 'app/validators/array_members_validator.rb' - - 'app/validators/branch_filter_validator.rb' - 'app/validators/certificate_fingerprint_validator.rb' - 'app/validators/certificate_key_validator.rb' - 'app/validators/certificate_validator.rb' @@ -292,7 +272,6 @@ Style/GuardClause: - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/postgresql_cte.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - 'db/migrate/20210302212623_rename_vuln_fingerprints_indexes.rb' @@ -322,13 +301,11 @@ Style/GuardClause: - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - - 'ee/app/finders/ee/notes_finder.rb' - 'ee/app/finders/ee/template_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' - 'ee/app/graphql/resolvers/epics_resolver.rb' @@ -374,12 +351,10 @@ Style/GuardClause: - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/incident_management/oncall_rotation.rb' - 'ee/app/models/ip_restriction.rb' - - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' - 'ee/app/models/protected_environments/deploy_access_level.rb' - - 'ee/app/models/sbom/occurrence.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' @@ -426,7 +401,6 @@ Style/GuardClause: - 'ee/app/services/iterations/delete_service.rb' - 'ee/app/services/merge_trains/check_status_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - - 'ee/app/services/merge_trains/refresh_service.rb' - 'ee/app/services/namespaces/storage/email_notification_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' @@ -445,12 +419,10 @@ Style/GuardClause: - 'ee/db/geo/migrate/20180314175612_add_partial_index_to_project_registy_verification_failure_columns.rb' - 'ee/db/geo/migrate/20180315222132_add_partial_index_to_project_registy_checksum_columns.rb' - 'ee/db/geo/migrate/20180412213305_add_index_to_artifact_id_on_job_artifact_registry.rb' - - 'ee/lib/ee/api/ci/job_artifacts.rb' - 'ee/lib/ee/api/features.rb' - 'ee/lib/ee/api/helpers/projects_helpers.rb' - 'ee/lib/ee/api/projects.rb' - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/audit/project_ci_cd_setting_changes_auditor.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb' - 'ee/lib/ee/gitlab/auth/o_auth/user.rb' @@ -586,7 +558,6 @@ Style/GuardClause: - 'lib/gitlab/gitaly_client/blobs_stitcher.rb' - 'lib/gitlab/gitaly_client/conflicts_service.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' - - 'lib/gitlab/gitaly_client/wiki_service.rb' - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' @@ -596,7 +567,6 @@ Style/GuardClause: - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - - 'lib/gitlab/i18n/metadata_entry.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' - 'lib/gitlab/import_export/base/object_builder.rb' @@ -616,7 +586,6 @@ Style/GuardClause: - 'lib/gitlab/legacy_github_import/client.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/marginalia.rb' - - 'lib/gitlab/memory/watchdog.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/active_record.rb' @@ -659,7 +628,6 @@ Style/GuardClause: - 'lib/gitlab/utils/override.rb' - 'lib/gitlab/webpack/manifest.rb' - 'lib/mattermost/session.rb' - - 'lib/release_highlights/validator/entry.rb' - 'lib/safe_zip/entry.rb' - 'lib/service_ping/devops_report.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' @@ -670,7 +638,6 @@ Style/GuardClause: - 'qa/qa/ee/resource/license.rb' - 'qa/qa/mobile/page/main/menu.rb' - 'qa/qa/mobile/page/sub_menus/common.rb' - - 'qa/qa/page/base.rb' - 'qa/qa/page/component/invite_members_modal.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' @@ -679,7 +646,6 @@ Style/GuardClause: - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/package.rb' - - 'qa/qa/resource/project.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' @@ -688,20 +654,15 @@ Style/GuardClause: - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/cop/gitlab/policy_rule_boolean.rb' - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - 'rubocop/cop/rspec/web_mock_enable.rb' - - 'rubocop/cop/usage_data/histogram_with_large_table.rb' - 'rubocop/cop/usage_data/large_table.rb' - 'rubocop/routes_under_scope.rb' - 'scripts/lint_templates_bash.rb' |