| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With --enable-more-warnings, we already used -std=gnu99, see
NetworkManager commit ba2b2de3adcf3e8286249523e3841858e0c2655c.
Compilation may behave differently depending on the selected
C standard that we choose. It seems wrong, with more-warnings,
to build against a C standard, while otherwise leaving it undefind.
Indeed, one might argue, that our build system should not use
such compiler specific options. At least, not without detecting
support for the compiler option during ./configure.
However:
- we already did this for --enable-more-warnings.
- we should not program against a theoretical compiler. In practice,
only gcc and clang works to build NetworkManager. Both these compilers
support this option, so there is no reason to not use it. If we ever
come into the situation to support another compiler, adjusting -std=gnu99
will be the smallest problem. Until that happens (and that's far from
imminent), don't pretend to be portable to non-existing compilers and
use the flag that in practice is available.
[lkundrak@v3.sk: taken this from NetworkManager, did the Makefile.am
and a trivial commit message adjustment.]
See-also: https://gcc.gnu.org/onlinedocs/gcc/Standards.html
(Taken from NetworkManager commit b9bc20f4da12f15b8950daea177e6dda42cd6c3f)
|
|
|
|
| |
(Taken from NetworkManager commit cc12413c0888c18f9b569c2776a01967e6efd1f9)
|
|
|
|
|
|
|
|
| |
Make it possible to add compiler options to a different variable than
CFLAGS. This is useful to conditionally disable a compiler warning for a
subpart of a tree.
(Taken from NetworkManager commit 0999ebdf6d795a84e2afbc13282b400fbd6fd4b5)
|
|
|
|
| |
(Taken from NetworkManager commit 422e87ec0d08d51c406b12be70d19e725d9cca4d)
|
|
|
|
|
|
|
| |
This fixes the GCC 8 build. It disables the warning conditionally so that we
get the warning back if glib gets fixed.
(Taken from NetworkManager commit 631982a796a0eeb412551c61469a1cfb83e3f438)
|
|
|
|
|
|
| |
Some warnings depends on others: -Wformat-security won't work without
-Wformat. With -Wall we're confident enough that we have important
warnings enabled and in any case we're going to enable it anyway.
|
|
|
|
|
|
|
|
|
|
|
| |
g-ir-scanner uses distutils that have an unfortunate misfeature of
inheriting the compiler flags it itself was built with.
This includes the hardening flags that don't work with without
redhat-rpm-build and break with clang every full moon.
A configure check makes it clear about what went wrong in case
introspection is desired, otherwise turns it off.
|
|
|
|
|
| |
- enable -Wvla and -Wunused-but-set-variable warnings
- minor bugfixes in shared files and new API.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- new warning flags
- add -Wextra
- add -Wimplicit-fallthrough
- add -Wno-missing-field-initializers
- add -Wno-format-truncation
- compile with -gnu99 instead of -gnu89
- make the --enable-more-warning option configurable for the
NM_COMPILER_WARNINGS macro.
|
|
|
|
|
|
| |
See https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b33aacbc91864f20f4733919af1a4cf8f725ca94
(cherry picked from commit 309570724cd3c6e4de9593359e8bbfd1a0bf7323)
|
|
|
|
| |
Taken from NetworkManager repository.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When buiding with "CFLAGS=-O0 -Werror", introspection.m4 passes
those flags to the compiler, which then get mixed with the
system-provided flags "-D_FORTIFY_SOURCE=2". Which in turn causes
a fatal warning.
$ export CFLAGS=-O0; ./autogen.sh --enable-more-warnings=error && make
Workaround that, by injecting "-Wno-error" to the CFLAGS, like we
do for NetworkManager (commit f6272144e98c00db18cf6708aceab96e6e7b1705).
Related: https://bugzilla.gnome.org/show_bug.cgi?id=757934
|
|
|
|
|
| |
This makes m4/compiler_warnings.m4 more similar to what we have
currently in NetworkManager master.
|
|
|
|
|
|
| |
Known glib issue. Fixes Fedora 22 build.
Taken from NetworkManager, commit 5206a9b28d1fed252f80bc241a481780fee556e1.
|
|
|
|
|
|
| |
Fixes build with clang 3.5 on Fedora 21.
Taken from NetworkManager, commit f0740aff88a83c228aa22cfd4c567e31e36bb504.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since GCC 4.4, gcc does not warn about unknown -Wno-* flags. At
least, it does not warning unless another warning is raised as well
(https://gcc.gnu.org/wiki/FAQ#wnowarning).
We didn't notice up to now, because we only tested flags that GCC
actually supports.
Hack around this, by checking for the -W* counterpart instead.
Taken from NetworkManager, commit 0462104317bfc097a90707a13590248707324846.
|
|
|
|
|
|
|
|
|
|
|
| |
NM_COMPILER_WARNINGS still works the same, but
rename variables to have a CFLAGS_* prefix.
Also cleanup the construction of CFLAGS by appending
to CFLAGS_MORE_WARNINGS variable instead of appending
to CFLAGS, and resetting to SAVE_CFLAGS.
Taken from NetworkManager, commit dd243ceefe998be36b5f0bea014d007ba30ec3fb.
|
|
|
|
|
|
|
|
| |
Update m4 macro from current NetworkManager master branch;
with one difference: keep also -Wstrict-prototypes (which
NM does not enable).
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang does not exit with error when it is called with an
unrecognized (warning) option. Instead it just prints
a warning that makes the configure script believe the
warning is supported. Later, during build we might pass
-Werror, which causes clang to fail due to unrecognized
arguments.
Fix the script to detect compiler warnings by passing
'-Werror=unknown-warning-option', which lets clang fail too.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
| |
96ffc8809165235b17170989a1d1b5ada79ca5fb ported the applet to GSettings
but removed the glib build requirement since the gio requirement is
sufficient. However, 0d116154fb1e85e6a9551f48e76efdf3ac510373 introduced
a requirement for 2.31.5, which is erroneous. The applet and editor
only require glib 2.26 or later.
|
|
|
|
|
|
|
| |
Also copy in a local version of the GLIB_CONFIG autoconf macro, and
use that (to get gschema stuff configured in for free too)
https://bugzilla.gnome.org/show_bug.cgi?id=662767
|
| |
|
|
|
|
|
|
|
| |
'iso-codes' provides ISO country, language, script and currency codes and their
translations in gettext format.
Even it's another dependency, it's very convenient, because there's no need to
duplicate translations of countries in nm-aplet.
|
|
|
|
| |
List of countries is taken from /usr/share/zoneinfo/iso3166.tab file.
|
|
The m4 macro is called NM_COMPILER_WARNINGS. Being in a separate file
makes it easier reusable for the other NM projects.
|