| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Import code can create incomplete profiles, that don't have
"connection.type" set. Avoid the crash.
#0 __strcmp_evex () at ../sysdeps/x86_64/multiarch/strcmp-evex.S:314
#1 0x000000000043d177 in import_vpn_from_file_cb (dialog=0x7f4650, response=<optimized out>, user_data=0x7d66e0) at src/connection-editor/connection-helpers.c:275
#2 0x00007ffff6f564ea in g_closure_invoke (closure=0x8d5120, return_value=0x0, n_param_values=2, param_values=0x7fffffffd0f0, invocation_hint=0x7fffffffd070) at ../gobject/gclosure.c:832
#3 0x00007ffff6f84d36 in signal_emit_unlocked_R.isra.0
(node=node@entry=0x847c70, detail=detail@entry=0, instance=instance@entry=0x7f4650, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7fffffffd0f0) at ../gobject/gsignal.c:3812
#4 0x00007ffff6f75bdd in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7fffffffd2b0) at ../gobject/gsignal.c:3565
#5 0x00007ffff6f75e53 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3622
#6 0x00007ffff6f75cda in _g_closure_invoke_va (param_types=0x0, n_params=<optimized out>, args=0x7fffffffd520, instance=0x8ee230, return_value=0x0, closure=0x8efbf0) at ../gobject/gclosure.c:895
#7 g_signal_emit_valist (instance=0x8ee230, signal_id=216, detail=0, var_args=var_args@entry=0x7fffffffd520) at ../gobject/gsignal.c:3472
#8 0x00007ffff6f75e53 in g_signal_emit (instance=instance@entry=0x8ee230, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3622
#9 0x00007ffff76dd7dd in gtk_button_clicked (button=button@entry=0x8ee230) at ../gtk/gtkbutton.c:1541
#10 0x00007ffff76dfad6 in gtk_button_finish_activate (do_it=1, button=0x8ee230) at ../gtk/gtkbutton.c:2042
#11 button_activate_timeout (data=0x8ee230) at ../gtk/gtkbutton.c:1984
#12 0x00007ffff7eddcad in gdk_threads_dispatch (data=data@entry=0xa5f470) at ../gdk/gdk.c:769
#13 0x00007ffff6e55c69 in g_timeout_dispatch (source=0x711550, callback=0x7ffff7eddc80 <gdk_threads_dispatch>, user_data=0xa5f470) at ../glib/gmain.c:5054
#14 0x00007ffff6e5539c in g_main_dispatch (context=0x4e7c70) at ../glib/gmain.c:3460
#15 g_main_context_dispatch (context=0x4e7c70) at ../glib/gmain.c:4200
#16 0x00007ffff6eb3438 in g_main_context_iterate.isra.0 (context=0x4e7c70, block=1, dispatch=1, self=<optimized out>) at ../glib/gmain.c:4276
#17 0x00007ffff6e52a23 in g_main_context_iteration (context=context@entry=0x4e7c70, may_block=may_block@entry=1) at ../glib/gmain.c:4343
#18 0x00007ffff708a01d in g_application_run (application=application@entry=0x4e5010, argc=<optimized out>, argv=0x7fffffffd9e8) at ../gio/gapplication.c:2573
#19 0x00000000004133ad in main (argc=<optimized out>, argv=<optimized out>) at src/connection-editor/main.c:259
https://gitlab.gnome.org/GNOME/network-manager-applet/-/issues/178
Fixes: 3ff5b6cc9841 ('c-e: support importing WireGuard profiles from wg-quick files')
|
|
|
|
|
|
| |
Dependency has been unused since commit 4ab50393 ("libnma: drop").
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/132
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The maximum MTU value of 10000 is too low for USB Ethernet, which has a
maximum (for Linux USB gadgets) of 15412 bytes (although the upper limit
is the USB wMaxPacketSize which goes up to 4294967295 bytes):
linux/drivers/usb/gadget/function/u_ether.c:#define GETHER_MAX_MTU_SIZE 15412
Multiple Intel NICs can use an MTU of 16110 bytes:
linux/drivers/net/ethernet/intel/e1000/e1000_hw.h:#define MAX_JUMBO_FRAME_SIZE 0x3F00
linux/drivers/net/ethernet/intel/e1000e/defines.h:#define MAX_JUMBO_FRAME_SIZE 0x3F00
linux/drivers/net/ethernet/intel/igbvf/defines.h:#define MAX_JUMBO_FRAME_SIZE 0x3F00
The NetworkManager limit is 4294967295 bytes but this is unreasonable
in a typical enivornment because of the memory required for packets of
that size.
The maximum IPv4 and IPv6 (without using Jumbograms) packet size is 65535
bytes so increase the maximum MTU value to 65536 allow full size IP
packets to be used.
There is a corresponding change in gnome-control-center.
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/131
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XEmbed-based GtkStatusIcon will silently do nothing in many
environments nowadays. In particular, it can't work outside X11.
Let's prefer X11 only if we got no app indicator support. Otherwise, use
the best backend possible and then turn on indicator support if it was
not X11.
Based on work by Aleksei Bavshin <alebastr89@gmail.com>.
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/129
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| | |
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/127
|
| |
| |
| |
| |
| |
| |
| |
| | |
nm-connection-editor -i basic.pcf -t vpn:vpnc
should import the profile of type vpnc. This did not work and opened
an empty VPN window. The reason is that the imported profile gets
reset. Avoid that.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When calling
nm-connection-editor -i basic.pcf -t vpn:vpnc
then the import should only try the VPNC plugin. For that to work,
we need to honor the detail and pass it on to the import code, to
only use the selected VPN plugin.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use new 1.40 API from libnm to import WireGuard profiles.
The following now works as expected:
nm-connection-editor -i $WG_CONF_FILE
nm-connection-editor -i $WG_CONF_FILE -t wireguard
This was already working before:
nm-connection-editor -c -t wireguard
What also works is to click "Import a saved VPN connection..."
and select a wg-quick configuration file.
|
| |
| |
| |
| | |
It will not only import VPN profiles. Rename.
|
| |
| |
| |
| |
| | |
Apparently, not leaking stuff is hard. The cleanup attribute simplifies
that.
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nm-vpnc crashes when passing no error argument, see [1].
Try with VPNC plugin installed:
./src/connection-editor/nm-connection-editor -i /some/invalid/file
Workaround that.
Also, libnm is going to work around that too ([2)]. But the bug should be
fixed also for older libnm/plugin versions.
[1] https://gitlab.gnome.org/GNOME/NetworkManager-vpnc/-/blob/c7d197477c94c5bae0396f0ef826db4d835e487d/properties/nm-vpnc-editor-plugin.c#L281
[2] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3b2eb689f3da1e957216b6106382b9a46bae266f
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In commit 6b1aaade74cf ('gschema: move "org.gnome.nm-applet.gschema.xml"
from network-manager-applet to libnma'), both "org.gnome.nm-applet" and
"org.gnome.nm-applet.eap" have been moved over to libnma, whereas only
the latter should have been.
Bring it back.
See-also: https://gitlab.gnome.org/GNOME/libnma/-/merge_requests/42
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/125
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The libnotify's notify_notification_show() does a blocking D-Bus call.
In fact, one fine gentleman's nm-applet got stuck for many seconds
because the bus activation aparatus in his computer was not properly
greased.
Let's do away with this absolute monstrosity of a library by using the
desktop notification API provided by GLib since 2.40. It's simpler, fully
asynchronous and in addition to freedesktop notification API it can
interface with Gtk and Flatpak portal one.
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/124
|
|
|
|
|
|
|
| |
It's doesn't contain anything of value, nor did it ever do.
We got git history and it's not even being maintained. Drop it.
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/123
|
|
|
|
|
|
|
|
|
| |
It's not clear why this sort of thing (e.g. polkit build patch) needs to go
in the upstream repository and nobody seems to be maintaining this [1].
[1] https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/118
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/122
|
| |
|
| |
|
|
|
|
|
|
| |
Done by Red Hat.
https://bugzilla.redhat.com/show_bug.cgi?id=2083047
|
|
|
|
|
|
| |
https://bugzilla.redhat.com/show_bug.cgi?id=2083047
[lkundrak@v3.sk: wrote a commit message]
|