summaryrefslogtreecommitdiff
path: root/src/wireless-security
Commit message (Collapse)AuthorAgeFilesLines
* all: Remove most of wireless-securityAndrew Zaborowski2020-11-1844-6981/+0
| | | | | Since only two utilities are now used from wireless-security, go ahead and remove everything else.
* all: drop some more libnm-glib vestigesLubomir Rintel2020-02-145-68/+0
| | | | | | | [thaller@redhat.com: cherry-picked this patch from a larger merge request and trivial conflict resolution] https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/73
* libnma: droplr/libnmicideLubomir Rintel2019-11-041-19/+3
|
* wireless-security: remove GTK4 API useLubomir Rintel2019-11-0411-94/+69
| | | | This partly reverts commit 94518cf90edd05c550202ed0dc583e0fd211fdea.
* all: lay libnm-gtk to restlr/libnm-gtkicideLubomir Rintel2019-11-041-18/+0
| | | | | | It's about time. https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/68
* wireless-security: add SAE supportLubomir Rintel2019-10-097-1/+321
| | | | | This is used by WPA3 Personal and secured Meshes (which we don't support in the applet).
* wireless-security: translate "Unknown" auth methodLubomir Rintel2019-10-091-1/+1
|
* build: allow building a GTK4 flavor of libnmaLubomir Rintel2019-09-201-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | This is EXPERIMENTAL EXPERIMENTAL EXPERIMENTAL. GTK4 is not released yet and things will change in incompatible ways. A new library called "libnma-gtk4" is added. The non-libnma parts (applet, editor) are not ported. There are few reasons for merging this early and none of them is shipping the library to the users at this point: * To allow bringup of GTK4-enabled VPN plugins * Do not block GTK4 enablement of GNOME Control Center * Help avoid using features that will be difficult to port from GTK3 All the test programs work, they emit a fair amount of warnings about properties that were removed in GTK4. To deal with those, we'd need to build different GResources for GTK3 and GTK4. The differencies seem small enough to the point the conversion could be automated. TODO, doesn't block testing. Tested to build with gtk+-4.0 = 3.94.0, but even the pkg-config name changed since in GTK4 git master. Did I say this is EXPERIMENTAL and there will be incompatible changes?
* nma: avoid using GtkEntry API removed from GTK4Lubomir Rintel2019-09-2010-66/+90
| | | | | Some calls were moved to GtkEditable. Call the new variants, while providing a compatibility wrappers for the GTK3 versions.
* wifi: support ad-hoc WPA2 connectionsBeniamino Galvani2019-09-131-9/+5
| | | | | | Now that NM supports ad-hoc WPA2 connections, enable them in the applet. https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/58
* all: drop modelineslr/cleanupsLubomir Rintel2019-09-1027-27/+0
| | | | They're a waste of electrons.
* all: use SPDX license identifiersLubomir Rintel2019-09-1028-392/+28
| | | | Makes licensing audits easier.
* trivial: fix whitespaceThomas Haller2019-08-261-1/+1
|
* wireless-security: add mnemonicsBeniamino Galvani2019-06-263-1/+4
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1712291
* wireless-security: 'unknown' method requires non-empty secretsBeniamino Galvani2019-02-251-1/+1
| | | | | | | | | | | secrets_hints can be a empty array when there are no hints. See also similar commit [1] for nmcli secret agent. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/b32c03c879603ad6a8d53b083a932a9d525c0253 Fixes: 0173934c831fac41d1203affd1fdf3d7fffeb22e https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/39
* wireless-security: show no settings for method "external" in editor modeAndrew Zaborowski2018-11-262-3/+18
| | | | | | | | | | | The "external" EAP method string is used in connections automatically created by NM to mirror IWD-configured networks where we only know they use EAP authentication but not what method or other 802-1x setting values, and the values are not even needed by NM. So still don't allow manually setting a connection's EAP method to "external" but if that value is already set for the connection then reflect that in the security combo. We abuse the EAPMethodSimple class to produce an empty GtkGrid basically.
* wireless-security: prepare text entries according to 'hints'Andrew Zaborowski2018-11-2610-83/+280
| | | | | | | | | | | | | | | | | | | | | | | | | | Use the hints passed down from the secret agent request, if any, to select the EAPMethodSimple UI and show or hide GtkEntry widgets according to which secrets are being requested. This unfortunately touches all the places that use EAPMethodSimple. I used this specific class because it is already kind of handling a bunch of different actual EAP methods but I could also have created a new UI separate EAPMethodSimple. Since I'm abusing EAPMethodSimple for this, I also needed to add a new eap method type "unknown", first because where this code is useful NM does not know what specific EAP method is used and secondly the UI doesn't really need to know that. Note that hints being non-NULL implies secrets_only. Since with secrets_only the password storage flags can't be changed, I didn't bother adding the storage flags to the GtkEntry for the private key passphrase so it doesn't get the secondary icon thing even though the plain password field does still have the icon. Only the three hint strings are supported which are actually in use in the NM tree in the IWD wifi backend. [lkundrak@v3.sk: fix up error handling in eap-method-simple.c:validate()]
* all: pass 'hints' from secret agent to ws_wpa_eap_newAndrew Zaborowski2018-11-262-2/+4
| | | | | | | | | | | | | | | | | The secret agent requests contain two parameters that aren't currently used when handling Wifi network connections: the setting name and hints. Those parameters turned out useful with 802.1X / EAP authentication with NM's IWD backend where it passes a specific 802_1x setting key name that is being requested in the 'hints' array, one of: identity, password or private_key_password. nmcli already gained support for handling such agent requests in 1a6e53808db8bb8e75317fd5feacd74a9a98860f (which was obviously much easier) so this is an attempt to let the src/wireless-security/* classes in nm-applet also handle these requests as intended. A new libnma function nma_wifi_dialog_new_for_secrets is added to receive the values from setting name and hints without changing existing API.
* wireless-security/eap: tolerate missing CA on secrets_onlylr/wifi-dialog-fixesLubomir Rintel2018-11-263-0/+9
| | | | | The user chose not to use a CA certificate when creating the connection, when we ask for secrets there's no way for them to reconsider.
* wireless-security/eap: (trivial) rename poorly named variablesLubomir Rintel2018-11-263-6/+6
| | | | It's not actually ignored.
* glade: fix Wi-Fi secrets dialogue being partly untranslatedBastien Nocera2018-08-2711-11/+11
| | | | | | | | | | | | | | | | | | | | There was no gettext "domain" property defined for the wifi.ui files, nor was there a call to gtk_builder_set_translation_domain() before adding the .ui to the GtkBuilder object, so those strings used the default project gettext. Except that when the dialogue is used in another project such as gnome-control-center, that the default project isn't where the translations live. Set the "domain" property on the top-level interface tag, so that GtkBuilder knows where to find the translations. [lkundrak@v3.sk: The Wi-Fi dialog is actually composed of widgets from multiple GtkBuilder files -- set the domain in all of them.] https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/23 https://bugzilla.gnome.org/show_bug.cgi?id=792285
* glade: replace GtkHBox and GtkVBox with GtkBoxLubomir Rintel2018-07-266-6/+12
| | | | Both long deprecated.
* wireless-security: avoid passing NULL to nma_cert_chooser_set_*_password()Lubomir Rintel2018-07-261-3/+6
| | | | | | This never worked for the file picker, since it tripped an assertion on setting NULL to the GtkEntry. Don't do that and guard the PKCS#11 picker too.
* wireless-security: fix validation of "always ask" passwordslr/always-askLubomir Rintel2018-06-193-11/+26
| | | | The entry never contains a value in such cases. Don't fail the validation.
* wireless-security: Make wireless_security_get_type() into a macroBastien Nocera2018-03-191-5/+4
| | | | | | | | And use WIRELESS_TYPE_SECURITY, rather than calling out to wireless_security_get_type() directly. This looks nicer in GtkListStore definitions. https://bugzilla.gnome.org/show_bug.cgi?id=794295
* wireless-security: Change labelling styleBastien Nocera2018-03-1911-61/+61
| | | | | | | | | Replace the left justified labels with right justified ones, reduce the space between label and entry and drop the unnecessary ":". This more closely matches the GNOME UI style, reducing the differences between gnome-control-center's Network panel and nm-connection-editor. https://bugzilla.gnome.org/show_bug.cgi?id=794295
* meson: Make sure the entire wireless-security static lib is usedJan Alexander Steffens (heftig)2017-11-081-10/+0
| | | | | Otherwise ld will not link in the gresources, which contain no "needed" (as far as ld can determine) symbols.
* build: Port to meson build systemIñigo Martínez2017-10-121-0/+86
| | | | | | | | meson is a build system focused on speed an ease of use, which helps speeding up the software development. This patch adds meson support along autotools. https://bugzilla.gnome.org/show_bug.cgi?id=788146
* all: bump Gtk+ version to 3.10Lubomir Rintel2017-07-1111-11/+11
| | | | | | | | We've accidentally depended on 3.10 features for some time (widget templates, revealers) and 3.10 is already rather old. (Even RHEL 7 has a newer one). Also bump GLib to 2.38. The Gtk 3.10 requires it and we already use features from versions newer by 2.32 (e.g. g_object_replace_data()).
* wireless-security: don't add the "No CA" checkboxes to the size group for labelsLubomir Rintel2017-07-114-17/+3
| | | | | It's in a different columns which then in turn gets slightly incorrectly resized.
* all: turn all GtkTables to GtkGridsLubomir Rintel2017-07-118-219/+124
| | | | | GtkTables are deprecated and discouraged. Let's get rid of all of them to silence Glade warnings.
* wireless-security: fix some crash issues on connection saveLubomir Rintel2017-06-221-1/+4
| | | | A use-after-free and a double-free.
* wireless-security: acually save the PKCS#11 PINs for certificatesLubomir Rintel2017-06-223-4/+16
|
* eap-method: fix uninitialized errorsLubomir Rintel2017-06-132-2/+2
| | | | | CID 170707 (#1 of 2): Uninitialized scalar variable (UNINIT) 20. uninit_use_in_call: Using uninitialized value scheme when calling nm_setting_802_1x_set_ca_cert
* wireless-security/tls: add domain suffix match entryLubomir Rintel2017-06-132-36/+89
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1457542
* wireless-security/peap: add domain suffix match entryLubomir Rintel2017-06-132-7/+64
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1457542
* wireless-security/ttls: add domain suffix match entryLubomir Rintel2017-06-132-34/+88
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1457542
* wireless-security/eap: drop dead codeLubomir Rintel2017-06-132-278/+0
| | | | | Now that all TLS, TTLS and PEAP use the certificate chooser widget, we can drop the obsolete helpers. Yay!
* wireless-security/peap: use the certificate chooser widgetLubomir Rintel2017-06-132-77/+85
| | | | Reduces code duplication.
* wireless-security/peap: turn the dialog to a GtkGridLubomir Rintel2017-06-131-64/+48
| | | | The GtkTable is deprecated. Also, add missing mnemonics.
* wireless-security/ttls: use the certificate chooser widgetLubomir Rintel2017-06-132-82/+99
| | | | Reduces code duplication.
* wireless-security/ttls: turn the dialog to a GtkGridLubomir Rintel2017-06-131-44/+33
| | | | The GtkTable is deprecated. Also, add missing mnemonics.
* wireless-security/eap: move cert picker setup and validation to common locationLubomir Rintel2017-06-133-143/+151
| | | | It is now used by the TLS method, but makes sense for TTLS and PEAP too.
* wireless-security/tls: fix unsetting the CALubomir Rintel2017-06-131-2/+3
|
* wireless-security/tls: use the correct flags property for CA PINLubomir Rintel2017-06-131-2/+2
|
* wireless-security: build pkcs11 cert password support only with libnmBeniamino Galvani2017-03-301-7/+7
| | | | | | | Compile pkcs11 certificate password support only when building with libnm. https://bugzilla.gnome.org/show_bug.cgi?id=780708
* c-e: use Unicode quotation marks in a new stringPiotr Drąg2017-03-231-1/+1
| | | | See https://developer.gnome.org/hig/stable/typography.html
* c-e: minor code cleanup in eap_method_validate_filepicker()Thomas Haller2017-03-231-10/+4
| | | | The check for empty password is redundant. Drop it.
* c-e: improve error message for non-existing certificate fileThomas Haller2017-03-231-0/+1
| | | | | | | | | | | | | | | | | When the connection references a certifiate file that does not exist, the GUI's file picker button shows an "(None)", however the "Save" button is disable with message: "Invalid setting Wi-Fi Security: invalid EAP-PEAP CA certificate: unspecified error validating eap-method file" Slightly improve that by showing instead "Invalid setting Wi-Fi Security: invalid EAP-PEAP CA certificate: file "..." does not exist" The solution is not optimal because the GUI shows file "(None)", with is some hidden information that makes the connection invalid. https://bugzilla.gnome.org/show_bug.cgi?id=780423
* wireless-security: make eap-tls use the NMACertificateChooserLubomir Rintel2017-03-1910-475/+403
| | | | | This makes it support PKCS#11 tokens for certificates and keys. Also, it supports PIN entry for the relevant objects.