summaryrefslogtreecommitdiff
path: root/tp-account-widgets/tpaw-account-widget.c
Commit message (Collapse)AuthorAgeFilesLines
* Remove Facebook XMPP supportballogyor@gmail.com2017-02-031-146/+4
| | | | | | | The service is discontinued in 2015: https://developers.facebook.com/docs/chat https://bugzilla.gnome.org/show_bug.cgi?id=747623
* account-widget: Hitting ENTER should also emit GtkDialog::responseDebarshi Ray2016-06-071-2/+10
| | | | | | | | | | | | | | | If the widget is inside a GtkDialog, then clicking one of the response buttons emits GtkDialog::response, as one would expect. However, just hitting ENTER inside a GtkEntry doesn't. This is an awkward inconsistency for applications using this widget. From now on, when TpawAccountWidget is inside a GtkDialog, it will emit GtkDialog::response followed by TpawAccountWidget::close when the widget has finished adding the account. Fall out from b838c54c673165a9d948b18f21580a0ca94f8cd5 https://bugzilla.gnome.org/show_bug.cgi?id=767295
* account-widget: Fix 'login_id' leak in _get_default_display_name()Christophe Fergeau2015-07-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tpaw_account_get_default_display_name() returns early when login_id is non-NULL, and only tries to g_free() it in the codepath after this early return, which causes a leak. This commit moves the call to g_free (login_id) before the early return in the (login_id != NULL) case. This fixes: ==26855== 8 bytes in 1 blocks are definitely lost in loss record 13,180 of 34,041 ==26855== at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==26855== by 0x8A120AC: g_malloc (gmem.c:97) ==26855== by 0x8A123C5: g_malloc_n (gmem.c:336) ==26855== by 0x8A2DB9A: g_strdup (gstrfuncs.c:356) ==26855== by 0x8A4C05B: g_variant_dup_string (gvariant.c:1500) ==26855== by 0x4CB9B41: tpaw_account_settings_dup_string (tpaw-account-settings.c:843) ==26855== by 0x4CC0F8B: tpaw_account_widget_get_default_display_name (tpaw-account-widget.c:2155) ==26855== by 0x4CBDFE2: tpaw_account_widget_apply_and_log_in (tpaw-account-widget.c:999) ==26855== by 0x4CBE05C: account_widget_apply_clicked_cb (tpaw-account-widget.c:1017) ==26855== by 0x87741EA: g_cclosure_marshal_VOID__VOID (gmarshal.c:875) ==26855== by 0x8771238: g_closure_invoke (gclosure.c:801) ==26855== by 0x878E070: signal_emit_unlocked_R (gsignal.c:3581) ==26855== by 0x878D3A7: g_signal_emit_valist (gsignal.c:3337) ==26855== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==26855== by 0x7326A22: gtk_button_clicked (gtkbutton.c:1488) ==26855== by 0x7327943: gtk_button_do_release (gtkbutton.c:1899) ==26855== by 0x7327D22: gtk_real_button_released (gtkbutton.c:2017) ==26855== by 0x877427D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==26855== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==26855== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==26855== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==26855== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==26855== by 0x73244D2: multipress_released_cb (gtkbutton.c:613) ==26855== by 0x36E5A05DAF: ffi_call_unix64 (unix64.S:76) ==26855== by 0x36E5A05817: ffi_call (ffi64.c:525) ==26855== by 0x8772F7C: g_cclosure_marshal_generic_va (gclosure.c:1594) ==26855== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==26855== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==26855== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==26855== by 0x7421792: gtk_gesture_multi_press_end (gtkgesturemultipress.c:273) ==26855== by 0x8775B90: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1950) ==26855== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==26855== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==26855== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-widget: Fix 'default_display_name' leakChristophe Fergeau2015-07-301-1/+3
| | | | | | | | | | | | | | | | | | | | | do_constructed() leaks the string returned by tpaw_account_widget_get_default_display_name(): ==15713== 21 bytes in 1 blocks are definitely lost in loss record 3,415 of 16,664 ==15713== at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==15713== by 0x36E2E76B57: vasprintf (vasprintf.c:76) ==15713== by 0x7F60DD2: g_vasprintf (gprintf.c:316) ==15713== by 0x7F30D70: g_strdup_vprintf (gstrfuncs.c:507) ==15713== by 0x7F30E15: g_strdup_printf (gstrfuncs.c:533) ==15713== by 0x4FAAD98: tpaw_account_widget_get_default_display_name (tpaw-account-widget.c:2192) ==15713== by 0x4FAA444: do_constructed (tpaw-account-widget.c:1960) ==15713== by 0x7C7CC10: g_object_new_internal (gobject.c:1814) ==15713== by 0x7C7D71A: g_object_new_valist (gobject.c:2033) ==15713== by 0x7C7C6C5: g_object_new (gobject.c:1617) ==15713== by 0x4FAABCC: tpaw_account_widget_new_for_protocol (tpaw-account-widget.c:2127) ==15713== by 0x4F81352: edit_connection_parameters (goatelepathyprovider.c:544) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-widget: Make it work with dialogs using header barsDebarshi Ray2014-06-041-41/+49
| | | | | | | | | | | | | | The tpaw_account_widget_new_for_protocol API has been changed to take a pointer to a GtkDialog instead of a GtkBox. If one is passed, then buttons are added to it without directly touching the action area. This way things will work irrespective of whether a header bar is being used or not. If NULL is passed, a button box is created and used for packing the buttons inside the widget as was the case before. In other words, this only affects users of this API who used to pass an action area. Those who did not should not be affected. https://bugzilla.gnome.org/show_bug.cgi?id=730578
* account-widget: use the "error" CSS class on wrong entriesGuillaume Desmottes2014-01-081-16/+6
| | | | | | | | | | That's the proper way to do as GTK+ defines this class for exactly this purpose. Our current code was pretty hacky anyway. This also has the nice side effect of fixing a bug making the text unreadable when selecting it from the entry. https://bugzilla.gnome.org/show_bug.cgi?id=710252
* tpaw-account-widget: set the apply button's text to "Add"/"Apply"Marco Barisione2013-08-221-75/+13
| | | | | Before we set the text to "Log in" if the user was online and we were creating a new account and "Apply" in other cases.
* tpaw-account-widget: use the symbolic clear icon for password fieldsMarco Barisione2013-08-221-2/+2
|
* tpaw-account-widget: improve the size of the various fieldsMarco Barisione2013-08-221-0/+2
| | | | | | | | | Fields in the main area now are at least 280px wide. This solves the problem with fields being too small. All the fields should expand to fix the available horizontal space. This solves the problem with fields leaving empty space on their side (in particular when the advanced section is expanded).
* tpaw-account-widget: remove the ability to register accountsMarco Barisione2013-08-221-67/+0
| | | | This feature was never used anyway and most servers don't support it.
* account-widget: add an "action-area" propertyMarco Barisione2013-08-201-16/+54
| | | | | | | This allows user of the class to get the buttons packed in a different widget, for instance the one returned by gtk_dialog_get_action_area. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* account-widget: make the buttons look like normal dialog buttonsMarco Barisione2013-08-201-3/+7
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tp-account-widgets: don't include empathy(-ui)-utils.hMarco Barisione2013-08-201-2/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tp-account-widgets: use g_strcmp0 instead of strcmpMarco Barisione2013-08-201-1/+1
| | | | | | | | There was no bug in this code, but I noticed the usage of strcmp because of compilation errors caused by some changes to the includes. g_strcmp0 is safer as it handles NULLs. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tpaw-utils: add the TPAW namespace to ACCOUNT_WIDGETS_RESOURCES_PREFIXMarco Barisione2013-08-201-3/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tp-account-widgets: use TpAW's debugging functions instead of Empathy'sMarco Barisione2013-08-201-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tpaw-utils: move EMP_STR_EMPTY to tp-aw and rename itMarco Barisione2013-08-201-6/+6
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* builder: move empathy_builder_* from Empathy to tp-account-widgetsMarco Barisione2013-08-201-16/+17
| | | | | | | This commit also changes the licence of the moved code from GPL to LGPL. See GOSSIP-RELICENSING.txt for details. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tpaw-utils: copy empathy_make_color_whiter()Marco Barisione2013-08-201-2/+2
| | | | | | | This commit also changes the licence of the moved code from GPL to LGPL. See GOSSIP-RELICENSING.txt for details. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tpaw-utils: move functions for protocol and service display informationMarco Barisione2013-08-201-1/+1
| | | | | | | | | | | | | The following functions were moved from empathy to tp-aw and renamed accordingly: * empathy_protocol_icon_name; * empathy_protocol_name_to_display_name; * empathy_service_name_to_display_name. This commit also changes the licence of the moved code (all copyrighted by Collabora Ltd.) from GPL to LGPL. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tpaw-utils: move empathy_connect_new_account to tp-aw and rename itMarco Barisione2013-08-201-1/+2
| | | | | | | This commit also changes the licence of the moved code (all copyrighted by Collabora Ltd.) from GPL to LGPL. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* account-settings: move from Empathy to tp-account-widgetsMarco Barisione2013-08-201-71/+71
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* account-widget: change the license header from the GPL to the LGPL oneMarco Barisione2013-08-201-10/+9
| | | | | | | We have permission to relicense these files to LGPL, see GOSSIP-RELICENSING.txt for details. https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tp-account-widgets: refer to the right renamed filesMarco Barisione2013-08-201-4/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* tp-account-widgets: rename all the files from empathy-* to tpaw-*Marco Barisione2013-08-201-0/+2331
https://bugzilla.gnome.org/show_bug.cgi?id=699492
View Lorry Controller Status