summaryrefslogtreecommitdiff
path: root/tp-account-widgets
Commit message (Collapse)AuthorAgeFilesLines
* irc-network-chooser-dialog: Chain up to the parent's constructed()Debarshi Ray2017-07-261-0/+2
| | | | | This might be the reason why the dialog was sometimes showing only the currently selected network.
* Add skypeweb to known protocolsBalló György2017-02-131-0/+5
| | | | | | | Also add icons for Skype protocols. Source: https://github.com/EionRobb/skype4pidgin/tree/master/icons https://bugzilla.gnome.org/show_bug.cgi?id=778157
* Remove Facebook XMPP supportballogyor@gmail.com2017-02-034-301/+5
| | | | | | | The service is discontinued in 2015: https://developers.facebook.com/docs/chat https://bugzilla.gnome.org/show_bug.cgi?id=747623
* Fix translator commentsPiotr Drąg2017-01-261-4/+4
| | | | They need to be exactly one line above a string to show up in .po files.
* irc-network-chooser: fix missing button labeldjb2016-11-301-0/+2
| | | | | | ...by adding a missing chain-up to the parent GtkButton's constructed(). https://bugzilla.gnome.org/show_bug.cgi?id=738315
* Remove X11 dependencyPhilip Chimento2016-11-111-2/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=774176
* Use Unicode in translatable stringsPiotr Drąg2016-10-065-9/+9
| | | | See https://developer.gnome.org/hig/stable/typography.html
* account-widget: Hitting ENTER should also emit GtkDialog::responseDebarshi Ray2016-06-071-2/+10
| | | | | | | | | | | | | | | If the widget is inside a GtkDialog, then clicking one of the response buttons emits GtkDialog::response, as one would expect. However, just hitting ENTER inside a GtkEntry doesn't. This is an awkward inconsistency for applications using this widget. From now on, when TpawAccountWidget is inside a GtkDialog, it will emit GtkDialog::response followed by TpawAccountWidget::close when the widget has finished adding the account. Fall out from b838c54c673165a9d948b18f21580a0ca94f8cd5 https://bugzilla.gnome.org/show_bug.cgi?id=767295
* Use MIN instead of CLAMP for unsigned int types.Diane Trout2016-04-151-3/+3
| | | | | | | | | | CLAMP tested that the unsigned variable was > 0, which gcc 5.3.1 generates a warning pointing out that will always be true. Using MIN guarantees the variable will be in the range 0..G_MAXINT(31|64) https://bugzilla.gnome.org/show_bug.cgi?id=765022
* Fix XML from the previous commitMichael Catanzaro2016-03-311-2/+2
| | | | Ooops....
* Add the Rizon IRC networkDwarf2016-03-311-0/+5
| | | | | | | | | | | With over 22k users I felt like it would be nice to include it in the list. Rizon is currently not listed in the network chooser dropdown. Add the Rizon IRC network to the corresponding file. https://bugzilla.gnome.org/show_bug.cgi?id=764438
* account-settings: The minimum value of unsigned integers are 0Ting-Wei Lan2016-03-081-4/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=762735
* account-settings: Fix GSimpleAsyncResult leaksChristophe Fergeau2015-07-301-0/+3
| | | | | | | | | | | tpaw_account_setting_set_display_name_async() and tpaw_account_settings_set_icon_name_async() can return immediatly in an idle when they don't have work to do. However in that case, these methods don't drop the reference they own on the GSimpleAsyncResult used for the async operation. This commit adds the missing g_object_unref() calls. https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-settings: Fix 'account_req' leakChristophe Fergeau2015-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tpaw_account_settings_do_create_account() creates a TpAccountRequest using tp_account_request_new() but never release its ref when it no longer needs it. Adding the missing unref() fixes the following leak: ==21491== 848 (40 direct, 808 indirect) bytes in 1 blocks are definitely lost in loss record 18,879 of 19,643 ==21491== at 0x8792D3A: g_type_create_instance (gtype.c:1848) ==21491== by 0x8779AC5: g_object_new_internal (gobject.c:1774) ==21491== by 0x877A71A: g_object_new_valist (gobject.c:2033) ==21491== by 0x87796C5: g_object_new (gobject.c:1617) ==21491== by 0x567A173: tp_account_request_new (account-request.c:750) ==21491== by 0x4CBAF7F: tpaw_account_settings_do_create_account (tpaw-account-settings.c:1382) ==21491== by 0x4CBB270: tpaw_account_settings_apply_async (tpaw-account-settings.c:1464) ==21491== by 0x4CBE023: tpaw_account_widget_apply_and_log_in (tpaw-account-widget.c:1009) ==21491== by 0x4CBE042: account_widget_apply_clicked_cb (tpaw-account-widget.c:1017) ==21491== by 0x87741EA: g_cclosure_marshal_VOID__VOID (gmarshal.c:875) ==21491== by 0x8771238: g_closure_invoke (gclosure.c:801) ==21491== by 0x878E070: signal_emit_unlocked_R (gsignal.c:3581) ==21491== by 0x878D3A7: g_signal_emit_valist (gsignal.c:3337) ==21491== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==21491== by 0x7326A22: gtk_button_clicked (gtkbutton.c:1488) ==21491== by 0x7327943: gtk_button_do_release (gtkbutton.c:1899) ==21491== by 0x7327D22: gtk_real_button_released (gtkbutton.c:2017) ==21491== by 0x877427D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==21491== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==21491== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==21491== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==21491== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==21491== by 0x73244D2: multipress_released_cb (gtkbutton.c:613) ==21491== by 0x36E5A05DAF: ffi_call_unix64 (unix64.S:76) ==21491== by 0x36E5A05817: ffi_call (ffi64.c:525) ==21491== by 0x8772F7C: g_cclosure_marshal_generic_va (gclosure.c:1594) ==21491== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==21491== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==21491== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==21491== by 0x7421792: gtk_gesture_multi_press_end (gtkgesturemultipress.c:273) ==21491== by 0x8775B90: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1950) ==21491== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==21491== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==21491== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==21491== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==21491== by 0x741D17F: _gtk_gesture_set_recognized (gtkgesture.c:275) ==21491== by 0x741D28D: _gtk_gesture_check_recognized (gtkgesture.c:315) ==21491== by 0x741DBD6: gtk_gesture_handle_event (gtkgesture.c:623) ==21491== by 0x7423555: gtk_gesture_single_handle_event (gtkgesturesingle.c:220) ==21491== by 0x73DBD1E: gtk_event_controller_handle_event (gtkeventcontroller.c:224) = https://bugzilla.gnome.org/show_bug.cgi?id=752938
* avatar-chooser: Don't call clear_image() from ::init()Christophe Fergeau2015-07-301-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GtkButton currently has a bug where calling gtk_button_set_image() in the ::init() vfunc of a subclass will cause the GtkImage to be leaked. This bug does not happen if the image is set after the GtkButton has been constructed, so this commit moves the call to avatar_chooser_clear_image() (which calls gtk_button_set_image()) from ::init() to ::constructed(). See https://bugzilla.gnome.org/show_bug.cgi?id=753048 This fixes: ==388== 768 (304 direct, 464 indirect) bytes in 1 blocks are definitely lost in loss record 33,655 of 34, ==388== at 0x8792D9C: g_type_create_instance (gtype.c:1849) ==388== by 0x8779AC5: g_object_new_internal (gobject.c:1774) ==388== by 0x8779FD4: g_object_newv (gobject.c:1921) ==388== by 0x8779676: g_object_new (gobject.c:1614) ==388== by 0x7453142: gtk_image_new_from_icon_name (gtkimage.c:792) ==388== by 0x4CC2CEE: avatar_chooser_clear_image (tpaw-avatar-chooser.c:394) ==388== by 0x4CC45AA: tpaw_avatar_chooser_init (tpaw-avatar-chooser.c:1195) ==388== by 0x8792E7D: g_type_create_instance (gtype.c:1870) ==388== by 0x8779AC5: g_object_new_internal (gobject.c:1774) ==388== by 0x877A71A: g_object_new_valist (gobject.c:2033) ==388== by 0x87796C5: g_object_new (gobject.c:1617) ==388== by 0x4CC4673: tpaw_avatar_chooser_new (tpaw-avatar-chooser.c:1213) ==388== by 0x4CD41D2: tpaw_user_info_constructed (tpaw-user-info.c:543) ==388== by 0x8779C10: g_object_new_internal (gobject.c:1814) ==388== by 0x877A71A: g_object_new_valist (gobject.c:2033) ==388== by 0x87796C5: g_object_new (gobject.c:1617) ==388== by 0x4CD4826: tpaw_user_info_new (tpaw-user-info.c:663) ==388== by 0x4C97906: edit_personal_details (goatelepathyprovider.c:667) ==388== by 0x4C980A7: edit_personal_details_clicked_cb (goatelepathyprovider.c:859) ==388== by 0x877427D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==388== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==388== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==388== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==388== by 0x7326A22: gtk_button_clicked (gtkbutton.c:1488) ==388== by 0x7327943: gtk_button_do_release (gtkbutton.c:1899) ==388== by 0x7327D22: gtk_real_button_released (gtkbutton.c:2017) ==388== by 0x877427D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==388== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==388== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==388== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==388== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==388== by 0x73244D2: multipress_released_cb (gtkbutton.c:613) ==388== by 0x36E5A05DAF: ffi_call_unix64 (unix64.S:76) ==388== by 0x36E5A05817: ffi_call (ffi64.c:525) ==388== by 0x8772F7C: g_cclosure_marshal_generic_va (gclosure.c:1594) ==388== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==388== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==388== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==388== by 0x7421792: gtk_gesture_multi_press_end (gtkgesturemultipress.c:273) ==388== by 0x8775B90: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1950) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-settings: Always take ownership of variant in ::set()Christophe Fergeau2015-07-301-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In one codepath, tpaw_account_settings_set() takes ownership of the passed-in GVariant through g_variant_ref_sink, but in the other codepath, ownership is left to the caller, which is unusual with functions with GVariant parameters. This commit unconditionnally calls g_variant_sink_ref() on the GVariant arg rather than doing it in just one codepath, and then makes sure we unref() the passed in GVariant when we don't want to keep it around. This fixes a memory leak in tpaw_account_settings_set() This fixes ==26855== 507 (240 direct, 267 indirect) bytes in 6 blocks are definitely lost in loss record 32,940 of 3 ==26855== at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==26855== by 0x8A120AC: g_malloc (gmem.c:97) ==26855== by 0x8A2B0F7: g_slice_alloc (gslice.c:1007) ==26855== by 0x8A52C0B: g_variant_alloc (gvariant-core.c:476) ==26855== by 0x8A52C9B: g_variant_new_from_bytes (gvariant-core.c:512) ==26855== by 0x8A4A60F: g_variant_new_from_trusted (gvariant.c:295) ==26855== by 0x8A4BAF6: g_variant_new_string (gvariant.c:1232) ==26855== by 0x4CBBE2E: account_widget_entry_changed_common (tpaw-account-widget.c:281) ==26855== by 0x4CBBED8: account_widget_entry_changed_cb (tpaw-account-widget.c:299) ==26855== by 0x87741EA: g_cclosure_marshal_VOID__VOID (gmarshal.c:875) ==26855== by 0x8771238: g_closure_invoke (gclosure.c:801) ==26855== by 0x878E070: signal_emit_unlocked_R (gsignal.c:3581) ==26855== by 0x878D3A7: g_signal_emit_valist (gsignal.c:3337) ==26855== by 0x878DA56: g_signal_emit_by_name (gsignal.c:3433) ==26855== by 0x73C0612: end_change (gtkentry.c:2928) ==26855== by 0x73C5F0D: gtk_entry_real_insert_text (gtkentry.c:5360) ==26855== by 0x7495B9A: _gtk_marshal_VOID__STRING_INT_POINTER (gtkmarshalers.c:7351) ==26855== by 0x87719A3: g_type_iface_meta_marshal (gclosure.c:1045) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-widget: Fix 'login_id' leak in _get_default_display_name()Christophe Fergeau2015-07-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tpaw_account_get_default_display_name() returns early when login_id is non-NULL, and only tries to g_free() it in the codepath after this early return, which causes a leak. This commit moves the call to g_free (login_id) before the early return in the (login_id != NULL) case. This fixes: ==26855== 8 bytes in 1 blocks are definitely lost in loss record 13,180 of 34,041 ==26855== at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==26855== by 0x8A120AC: g_malloc (gmem.c:97) ==26855== by 0x8A123C5: g_malloc_n (gmem.c:336) ==26855== by 0x8A2DB9A: g_strdup (gstrfuncs.c:356) ==26855== by 0x8A4C05B: g_variant_dup_string (gvariant.c:1500) ==26855== by 0x4CB9B41: tpaw_account_settings_dup_string (tpaw-account-settings.c:843) ==26855== by 0x4CC0F8B: tpaw_account_widget_get_default_display_name (tpaw-account-widget.c:2155) ==26855== by 0x4CBDFE2: tpaw_account_widget_apply_and_log_in (tpaw-account-widget.c:999) ==26855== by 0x4CBE05C: account_widget_apply_clicked_cb (tpaw-account-widget.c:1017) ==26855== by 0x87741EA: g_cclosure_marshal_VOID__VOID (gmarshal.c:875) ==26855== by 0x8771238: g_closure_invoke (gclosure.c:801) ==26855== by 0x878E070: signal_emit_unlocked_R (gsignal.c:3581) ==26855== by 0x878D3A7: g_signal_emit_valist (gsignal.c:3337) ==26855== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==26855== by 0x7326A22: gtk_button_clicked (gtkbutton.c:1488) ==26855== by 0x7327943: gtk_button_do_release (gtkbutton.c:1899) ==26855== by 0x7327D22: gtk_real_button_released (gtkbutton.c:2017) ==26855== by 0x877427D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==26855== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==26855== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==26855== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==26855== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==26855== by 0x73244D2: multipress_released_cb (gtkbutton.c:613) ==26855== by 0x36E5A05DAF: ffi_call_unix64 (unix64.S:76) ==26855== by 0x36E5A05817: ffi_call (ffi64.c:525) ==26855== by 0x8772F7C: g_cclosure_marshal_generic_va (gclosure.c:1594) ==26855== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==26855== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) ==26855== by 0x878D8E9: g_signal_emit (gsignal.c:3393) ==26855== by 0x7421792: gtk_gesture_multi_press_end (gtkgesturemultipress.c:273) ==26855== by 0x8775B90: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1950) ==26855== by 0x877190F: g_type_class_meta_marshalv (gclosure.c:1021) ==26855== by 0x87714D1: _g_closure_invoke_va (gclosure.c:864) ==26855== by 0x878C771: g_signal_emit_valist (gsignal.c:3246) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-widget: Fix 'default_display_name' leakChristophe Fergeau2015-07-301-1/+3
| | | | | | | | | | | | | | | | | | | | | do_constructed() leaks the string returned by tpaw_account_widget_get_default_display_name(): ==15713== 21 bytes in 1 blocks are definitely lost in loss record 3,415 of 16,664 ==15713== at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==15713== by 0x36E2E76B57: vasprintf (vasprintf.c:76) ==15713== by 0x7F60DD2: g_vasprintf (gprintf.c:316) ==15713== by 0x7F30D70: g_strdup_vprintf (gstrfuncs.c:507) ==15713== by 0x7F30E15: g_strdup_printf (gstrfuncs.c:533) ==15713== by 0x4FAAD98: tpaw_account_widget_get_default_display_name (tpaw-account-widget.c:2192) ==15713== by 0x4FAA444: do_constructed (tpaw-account-widget.c:1960) ==15713== by 0x7C7CC10: g_object_new_internal (gobject.c:1814) ==15713== by 0x7C7D71A: g_object_new_valist (gobject.c:2033) ==15713== by 0x7C7C6C5: g_object_new (gobject.c:1617) ==15713== by 0x4FAABCC: tpaw_account_widget_new_for_protocol (tpaw-account-widget.c:2127) ==15713== by 0x4F81352: edit_connection_parameters (goatelepathyprovider.c:544) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* Properly fix tp_list_connection_managers_finish() leakChristophe Fergeau2015-07-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 103ed6232 attempted to fix a leak in tp_list_connection_managers_finish() but it was incomplete as it only freed the returned GList with g_list_free() while the list elements must be freed too. This commit addresses that using g_list_free_full() ==9013== at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==9013== by 0x7F150AC: g_malloc (gmem.c:97) ==9013== by 0x7F2E0F7: g_slice_alloc (gslice.c:1007) ==9013== by 0x7F091B7: g_list_copy_deep (glist.c:678) ==9013== by 0x7F09184: g_list_copy (glist.c:633) ==9013== by 0x370B157A64: _tp_g_list_copy_deep (util.c:2117) ==9013== by 0x4FB06C5: tpaw_connection_managers_listed_cb (tpaw-connection-managers.c:209) ==9013== by 0x7929107: g_simple_async_result_complete (gsimpleasyncresult.c:801) ==9013== by 0x7929153: complete_in_idle_cb (gsimpleasyncresult.c:813) ==9013== by 0x7F0F470: g_idle_dispatch (gmain.c:5397) ==9013== by 0x7F0CAB8: g_main_dispatch (gmain.c:3122) ==9013== by 0x7F0D8FC: g_main_context_dispatch (gmain.c:3737) ==9013== by 0x7F0DAE0: g_main_context_iterate (gmain.c:3808) ==9013== by 0x7F0DF06: g_main_loop_run (gmain.c:4002) ==9013== by 0x4F803F3: wait_for_account_settings_ready (goatelepathyprovider.c:102) ==9013== by 0x4F8127F: edit_connection_parameters (goatelepathyprovider.c:534) ==9013== by 0x4F81F16: edit_parameters_clicked_cb (goatelepathyprovider.c:835) ==9013== by 0x7C7727D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==9013== by 0x7C744D1: _g_closure_invoke_va (gclosure.c:864) ==9013== by 0x7C8F771: g_signal_emit_valist (gsignal.c:3246) ==9013== by 0x7C908E9: g_signal_emit (gsignal.c:3393) ==9013== by 0x6838A45: gtk_button_clicked (gtkbutton.c:1488) ==9013== by 0x6839966: gtk_button_do_release (gtkbutton.c:1899) ==9013== by 0x6839D45: gtk_real_button_released (gtkbutton.c:2017) ==9013== by 0x7C7727D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905) ==9013== by 0x7C7490F: g_type_class_meta_marshalv (gclosure.c:1021) ==9013== by 0x7C744D1: _g_closure_invoke_va (gclosure.c:864) ==9013== by 0x7C8F771: g_signal_emit_valist (gsignal.c:3246) ==9013== by 0x7C908E9: g_signal_emit (gsignal.c:3393) ==9013== by 0x68364F5: multipress_released_cb (gtkbutton.c:613) ==9013== by 0x36E5A05DAF: ffi_call_unix64 (unix64.S:76) ==9013== by 0x36E5A05817: ffi_call (ffi64.c:525) ==9013== by 0x7C75F7C: g_cclosure_marshal_generic_va (gclosure.c:1594) ==9013== by 0x7C744D1: _g_closure_invoke_va (gclosure.c:864) ==9013== by 0x7C8F771: g_signal_emit_valist (gsignal.c:3246) ==9013== by 0x7C908E9: g_signal_emit (gsignal.c:3393) ==9013== by 0x69303DB: gtk_gesture_multi_press_end (gtkgesturemultipress.c:273) ==9013== by 0x7C78B90: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1950) ==9013== by 0x7C7490F: g_type_class_meta_marshalv (gclosure.c:1021) ==9013== by 0x7C744D1: _g_closure_invoke_va (gclosure.c:864) https://bugzilla.gnome.org/show_bug.cgi?id=752938
* Fix GetProtocolsData leakChristophe Fergeau2015-07-281-3/+3
| | | | | | | | | | | | | | | | | | | A GetProtocolsData instance gets associated with a GSimpleAsyncResult in tpaw_protocol_get_all_async() using g_simple_async_result_set_op_res_gpointer(). A GDestroyNotify is set so that the GetProtocolsData instance is freed when the GSimpleAsyncResult is freed. However, this is not working as expected as the GetProtocolsData instance is keeping a reference on the GSimpleAsyncResult it's associated with, which creates a circular reference and causes the GetProtocolsData instance to never be freed. This commit drops the reference on the GSimpleAsyncResult instance owned by the GetProtocolsData instance as soon as it's no longer needed so that the GSimpleAsyncResult can be disposed, which triggers the destruction of the GetProtocolsData too. https://bugzilla.gnome.org/show_bug.cgi?id=752938
* Free GList returned by tp_list_connection_managers_finish()Christophe Fergeau2015-07-271-0/+1
| | | | | | Make sure it's not leaked in tpaw_connection_managers_listed_cb() https://bugzilla.gnome.org/show_bug.cgi?id=752938
* Free TpawProtocol::service_name in finalize()Christophe Fergeau2015-07-271-0/+1
| | | | | | It will be leaked otherwise. https://bugzilla.gnome.org/show_bug.cgi?id=752938
* account-widget: Make it work with dialogs using header barsDebarshi Ray2014-06-042-42/+50
| | | | | | | | | | | | | | The tpaw_account_widget_new_for_protocol API has been changed to take a pointer to a GtkDialog instead of a GtkBox. If one is passed, then buttons are added to it without directly touching the action area. This way things will work irrespective of whether a header bar is being used or not. If NULL is passed, a button box is created and used for packing the buttons inside the widget as was the case before. In other words, this only affects users of this API who used to pass an action area. Those who did not should not be affected. https://bugzilla.gnome.org/show_bug.cgi?id=730578
* remove tpaw_make_color_whiter()Guillaume Desmottes2014-01-082-12/+0
| | | | | | It's not used any more. https://bugzilla.gnome.org/show_bug.cgi?id=710252
* account-widget: use the "error" CSS class on wrong entriesGuillaume Desmottes2014-01-081-16/+6
| | | | | | | | | | That's the proper way to do as GTK+ defines this class for exactly this purpose. Our current code was pretty hacky anyway. This also has the nice side effect of fixing a bug making the text unreadable when selecting it from the entry. https://bugzilla.gnome.org/show_bug.cgi?id=710252
* Use "Remember password" everywhereGuillaume Desmottes2014-01-066-8/+8
| | | | | | It shouldn't be "Remember Password" according to the HIG. https://bugzilla.gnome.org/show_bug.cgi?id=719889
* protocol: skip Haze's IRC implementationDebarshi Ray2013-11-011-0/+5
| | | | | | | | | | | | Users should be using Idle for IRC, and not Haze. This is implicitly codified in the widgets array kept in tpaw-account-widget.c. Otherwise, if Idle is absent we would still be advertising IRC support in the UI, only to crash immediately afterwards. All said and done, it is saner to support one single implementation of a protocol. https://bugzilla.gnome.org/show_bug.cgi?id=711226
* stop using tp_account_is_prepared()Guillaume Desmottes2013-10-231-1/+1
| | | | It has been deprecated.
* include telepathy-glib-dbusGuillaume Desmottes2013-10-234-0/+5
| | | | Needed with 1.0
* wrap x11 specific codeArmin K2013-10-121-1/+7
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=708395
* prevent infinite loop if ContactInfo is not implementedGuillaume Desmottes2013-10-101-1/+10
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=709677
* Stop using libaccounts-glib deprecated functionsXavier Claessens2013-09-161-28/+25
|
* avatar-chooser: allow setting the pixel-size of button's imageDebarshi Ray2013-09-123-6/+48
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=707927
* builder: use the correct translation domainMarco Barisione2013-09-032-7/+22
| | | | | | | | | | | | tpaw_builder_get_*() functions always used GETTEXT_PACKAGE as translation domain, but that always meant the tpaw one so it broke empathy's translations. This commit adds tpaw_builder_get_*_with_domain() functions and replace the previous functions with macros that use the GETTEXT_PACKAGE defined in the .c file that includes tpaw-builder.h. https://bugzilla.gnome.org/show_bug.cgi?id=707208
* live-search: inherit from GtkBoxGuillaume Desmottes2013-09-022-3/+4
| | | | | | GtkHBox has been deprecated since a while. https://bugzilla.gnome.org/show_bug.cgi?id=707265
* build: add --disable-settings to avoid installing the GSettings schemaMarco Barisione2013-08-271-0/+12
| | | | | | | | This is needed to avoid multiple components shipping the same schema. It's just a temporary workaround that won't be needed when https://bugzilla.gnome.org/show_bug.cgi?id=706317 will be fixed. https://bugzilla.gnome.org/show_bug.cgi?id=706801
* avatar-chooser: make the file chooser dialog modalMarco Barisione2013-08-271-6/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=706881
* tpaw-account-widget: set the apply button's text to "Add"/"Apply"Marco Barisione2013-08-221-75/+13
| | | | | Before we set the text to "Log in" if the user was online and we were creating a new account and "Apply" in other cases.
* tpaw-user-info: explain that the details will be shared with other usersMarco Barisione2013-08-221-0/+16
|
* tpaw-contactinfo-utils: use title case for labelsMarco Barisione2013-08-221-6/+6
|
* tpaw-calendar-button: use the symbolic clear iconMarco Barisione2013-08-221-1/+1
|
* tpaw-account-widget: use the symbolic clear icon for password fieldsMarco Barisione2013-08-221-2/+2
|
* tpaw-account-widget: leave more space between username and passwordMarco Barisione2013-08-227-0/+14
|
* tpaw-account-widget: improve the size of the various fieldsMarco Barisione2013-08-2210-82/+161
| | | | | | | | | Fields in the main area now are at least 280px wide. This solves the problem with fields being too small. All the fields should expand to fix the available horizontal space. This solves the problem with fields leaving empty space on their side (in particular when the advanced section is expanded).
* tpaw-account-widget: remove the ability to register accountsMarco Barisione2013-08-222-92/+0
| | | | This feature was never used anyway and most servers don't support it.
* build: add --with-icondir to set a different install path for iconsMarco Barisione2013-08-221-0/+1
|
* user-info: prepare the connection's ContactInfo interfaceMarco Barisione2013-08-201-1/+28
|
* configure.ac: allow to overwrite where to install data filesMarco Barisione2013-08-201-2/+2
|
* irc-network-manager: rename the EMPATHY_SRC_DIR env variableMarco Barisione2013-08-201-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
* Save the UOA provider name in the pkg-config fileMarco Barisione2013-08-201-3/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=699492
View Lorry Controller Status