summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* [dev.garbage] all: merge dev.cc (81884b89bd88) into dev.garbageRuss Cox2014-12-051-2/+2
|\ | | | | | | | | | | TBR=rlh CC=golang-codereviews https://codereview.appspot.com/181100044
| * [dev.garbage] all: merge default (f38460037b72) into dev.garbageRuss Cox2014-11-142-5/+12
| |\ | | | | | | | | | | | | | | | | | | | | | | | | This is the revision that dev.cc is branched from. LGTM=austin R=austin CC=golang-codereviews https://codereview.appspot.com/169590043
| | * [dev.garbage] all: merge dev.power64 (5ad5e85cfb99) into dev.garbageRuss Cox2014-10-292-3/+10
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal here is to get the big-endian fixes so that in some upcoming code movement for write barriers I don't make them unmergeable. LGTM=rlh R=rlh CC=golang-codereviews https://codereview.appspot.com/166890043
| | * | [dev.garbage] lib/codereview: allow hg submit to commit new branch if CL ↵Russ Cox2014-09-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | description says so This means I won't have to edit the plugin when I create the next dev branch. LGTM=r, adg R=r, adg CC=golang-codereviews https://codereview.appspot.com/148950045
* | | | [dev.cc] all: merge default (8d42099cdc23) into dev.ccdev.ccRuss Cox2014-12-052-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | TBR=austin CC=golang-codereviews https://codereview.appspot.com/178700044
| * | | | lib/time: update to ICANN time zone database 2014jRob Pike2014-12-032-2/+2
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes issue 9189. LGTM=dsymonds R=golang-codereviews, dsymonds CC=golang-codereviews https://codereview.appspot.com/178660043
* | | | [dev.cc] all: merge dev.power64 (7667e41f3ced) into dev.ccRuss Cox2014-11-141-1/+2
|\ \ \ \ | |/ / / | | | / | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is to reduce the delta between dev.cc and dev.garbage to just garbage collector changes. These are the files that had merge conflicts and have been edited by hand: malloc.go mem_linux.go mgc.go os1_linux.go proc1.go panic1.go runtime1.go LGTM=austin R=austin CC=golang-codereviews https://codereview.appspot.com/174180043
| * | all: use golang.org/x/... import pathsAndrew Gerrand2014-11-101-1/+1
| | | | | | | | | | | | | | | | | | | | | LGTM=rsc, r R=r, rsc CC=golang-codereview, golang-codereviews https://codereview.appspot.com/168050043
| * | lib/codereview: fix with more recent hg revisions.Adam Langley2014-11-081-0/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've Mercurial version 3.2 and hg submit fails with: File "/home/agl/devel/go/lib/codereview/codereview.py", line 3567, in get_hg_status ret = hg_commands.status(fui, self.repo, *[], **{'rev': [rev], 'copies': True}) File "/usr/lib/python2.7/site-packages/mercurial/commands.py", line 5714, in status fm = ui.formatter('status', opts) File "/home/agl/devel/go/lib/codereview/codereview.py", line 3464, in formatter return plainformatter(self, topic, opts) File "/usr/lib/python2.7/site-packages/mercurial/formatter.py", line 57, in __init__ if ui.debugflag: AttributeError: 'FakeMercurialUI' object has no attribute 'debugflag' This change dumbly adds a boolean debugflag and that seems to work. LGTM=minux R=rsc, minux CC=golang-codereviews https://codereview.appspot.com/167410043
* | [dev.power64] build: merge default into dev.power64Austin Clements2014-10-222-3/+10
|/ | | | | | | LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/160200044
* codereview: do not hit upload_complete on first patchRuss Cox2014-08-061-1/+2
| | | | | | | | Causes server 500 error, so don't do it. TBR=minux CC=golang-codereviews https://codereview.appspot.com/125770043
* codereview: fix submit of merge + include branch prefix in submitted messageRuss Cox2014-08-061-8/+21
| | | | | | | | | | | | hg insists that we not list explicit files for a merge. for benefit of other tools reading logs, include branch prefix at start of every commit message. LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/124780044
* codereview: handle upload of mergeRuss Cox2014-08-061-3/+15
| | | | | | | LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/118690043
* codereview: preserve branch prefix in subject during hg mailRuss Cox2014-08-061-8/+10
| | | | | | | LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/124800043
* codereview: enable work and code reviews in development branchesRuss Cox2014-08-061-5/+17
| | | | | | | | | | This is an experiment. See mail on golang-dev (subject: "an experiment: development branches"). LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/117660043
* codereview: abort 'hg commit' before entering commit message.Shenghou Ma2014-07-181-4/+4
| | | | | | | | | | Hook pre-commit runs before 'hg commit' command whereas hook precommit runs after the user has entered commit message. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/106320043
* codereview: revive the tests.Shenghou Ma2014-07-182-14/+31
| | | | | | | LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/105500043
* codereview: update name of the a+c toolBrad Fitzpatrick2014-07-011-1/+1
| | | | | | | LGTM=rsc R=rsc, minux CC=golang-codereviews https://codereview.appspot.com/105480043
* lib/codereview: fix doc/go1.*.txt exceptionRuss Cox2014-06-121-1/+1
| | | | | | | LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/108950046
* codereview: no LGTM needed for doc/go1.x.txtRuss Cox2014-06-121-3/+13
| | | | | | | | | | Rob asked for this change to make maintaining go1.4.txt easier. If you are not sure of a change, it is still okay to send for review. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/109880044
* codereview: do not add defaultcc for private CLsRuss Cox2014-06-051-2/+2
| | | | | | | LGTM=r R=r, 0xjnml, bradfitz, iant CC=golang-codereviews https://codereview.appspot.com/103070046
* lib/timezone: update to IANA 2014dRob Pike2014-06-012-2/+2
| | | | | | | LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/102040045
* lib/time/zoneinfo.zip: update to IANA release 2014cRob Pike2014-05-162-2/+2
| | | | | | | LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://codereview.appspot.com/93420046
* lib/time: update time zone info to v.2014bRobert Hencke2014-04-292-4/+2
| | | | | | | | | | | Fixes issue 7412. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://codereview.appspot.com/92850043 Committer: Rob Pike <r@golang.org>
* codereview: remove unused upload_options.revisionPatrick M?zard2014-02-241-12/+9
| | | | | | | | | LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://codereview.appspot.com/60640052 Committer: Russ Cox <rsc@golang.org>
* codereview: fix for Mercurial 2.9Anthony Martin2014-02-141-1/+1
| | | | | | | | | | | | The branchtags method was removed but we should've been using branchmap all along. http://selenic.com/hg/rev/4274eda143cb LGTM=franciscossouza, r R=golang-codereviews, franciscossouza, r CC=golang-codereviews https://codereview.appspot.com/57500045
* codereview: warn about 'hg upload' not uploadingRuss Cox2014-02-131-0/+2
| | | | | | | | | | | | This seems to be what causes the 'chunk mismatch' errors. I don't know why the server tells us there's nothing to upload, but at the least we can warn that it did, so that the user will try again. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/62840043
* lib/codereview: allow addca CLs without LGTMRuss Cox2014-02-101-1/+6
| | | | | | | LGTM=gri R=golang-codereviews, gri CC=golang-codereviews https://codereview.appspot.com/61610043
* lib/codereview: add LGTM= line to commit messagesRuss Cox2014-01-231-5/+20
| | | | | | | | | | | The R= is populated by Rietveld, so it's basically anyone who replied to the CL. The LGTM= is meant to record who actually signed off on the CL. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/55390043
* codereview: switch defaultcc to golang-codereviewsRuss Cox2013-12-201-1/+1
| | | | | | | | | See this thread for background: https://groups.google.com/forum/#!topic/golang-dev/xG7vPi21r8g R=golang-codereviews, gobot, golang-dev, dsymonds CC=golang-codereviews, golang-dev https://codereview.appspot.com/44450043
* plan9: correct create permissions with union directoryJeff Sickel2013-10-231-1/+1
| | | | | | | | R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/15360045 Committer: Russ Cox <rsc@golang.org>
* lib/codereview: return an empty list when CONTRIBUTORS is not found instead ↵Francesc Campoy2013-10-101-1/+1
| | | | | | | | of None. R=adg, campoy, r CC=golang-dev https://codereview.appspot.com/14419059
* codereview: fix hg sync closing of CLs for subrepositoriesDominik Honnef2013-10-101-1/+1
| | | | | | | | | | | | The regexp for closing CLs that were sent by you but committed by someone else only matched messages for the main repository, because of the added &repo=... for subrepositories. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/14512045 Committer: Rob Pike <r@golang.org>
* lib/time: update time zone files to version 2013gRob Pike2013-10-082-2/+4
| | | | | | | | | | This dataset is current as of Sep 30, 2013. Fixes issue 6524 R=golang-dev, minux.ma CC=golang-dev https://codereview.appspot.com/14570044
* codereview: move dotfiles out of user home director to something sane.Jeff Sickel2013-10-071-0/+8
| | | | | | | | | | See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp R=golang-dev, r, rsc CC=aram.h, golang-dev https://codereview.appspot.com/14374045 Committer: Russ Cox <rsc@golang.org>
* codereview: update use of promptchoice for Mercurial 2.7Anthony Martin2013-09-061-1/+4
| | | | | | | | | | Fixes issue 6186. R=golang-dev, bradfitz, remyoudompheng, rsc CC=golang-dev https://codereview.appspot.com/13112043 Committer: Russ Cox <rsc@golang.org>
* cmd/godoc: delete from core repositoryAndrew Gerrand2013-08-0111-707/+0
| | | | | | | | The godoc command now lives at code.google.com/p/go.tools/cmd/godoc. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/12206044
* doc: don't block page load on JavaScript fetchAndrew Gerrand2013-07-302-62/+7
| | | | | | R=golang-dev, dsymonds CC=golang-dev https://codereview.appspot.com/12050045
* cmd/godoc: set up playground for examples that are already visibleAndrew Gerrand2013-07-021-9/+18
| | | | | | | | | | This fixes an issue where linking directly to an example makes it not runnable and visible only in a tiny window. To see the bug in action, visit this link: http://golang.org/pkg/strings/#example_Map R=golang-dev, r CC=golang-dev https://codereview.appspot.com/10679050
* codereview: force hg update after hg pull -u during hg syncRuss Cox2013-06-251-1/+32
| | | | | | | | | | | If you hg update your client to an earlier CL, then hg sync will move you back to tip if it pulls anything in, but it will leave you where you are if it doesn't pull anything in. That's confusing: make hg sync always update to tip. R=golang-dev, bradfitz, r, dsymonds CC=golang-dev https://codereview.appspot.com/10456044
* godoc: always use local jQuery scriptAndrew Gerrand2013-06-071-2/+1
| | | | | | | | Fixes issue 5075. R=golang-dev, dsymonds CC=golang-dev https://codereview.appspot.com/10084044
* codereview: don't warn about secret commitsAnthony Martin2013-06-041-2/+6
| | | | | | | | | | | | | | | | | | | | | Normally the codereview plugin disables adding new commits when not using the submit command. Unfortunately this makes it impossible to use the Mercurial Queues extension at the same time. A feature called "Phases" was introduced in Mercurial 2.1 that allows marking commits as being secret; this means they will never be pushed to the upstream repository. We can take advantage of this feature to allow the use of Mercurial Queues if the mq.secret option has been set in hgrc(5) and a recent version of Mercurial is used. R=golang-dev, rsc, minux.ma CC=golang-dev https://codereview.appspot.com/7398055 Committer: Brad Fitzpatrick <bradfitz@golang.org>
* codereview.py: improve error message when user is not a committerFrancesc Campoy2013-05-221-0/+3
| | | | | | R=adg, bradfitz, r CC=golang-dev https://codereview.appspot.com/9626045
* lib/time: update to IANA 2013cRob Pike2013-04-222-2/+2
| | | | | | | | | | | This should do it for the release. There was a new data set pushed out a couple of days ago. Fixes issue 4553. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8621044
* lib/time: update time zone to IANA version 2013bRob Pike2013-04-022-2/+2
| | | | | | | | Update issue 4553. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8293043
* cmd/godoc: don't linkify index entriesRobert Griesemer2013-04-021-12/+12
| | | | | | | | Fixes issue 5186. R=bradfitz CC=golang-dev https://codereview.appspot.com/8267044
* cmd/godoc: provide a link from notes to source locationRobert Griesemer2013-03-281-2/+2
| | | | | | R=golang-dev, r CC=golang-dev https://codereview.appspot.com/8122043
* cmd/godoc: cleanupsRobert Griesemer2013-03-281-8/+7
| | | | | | | | | | | - removed gratuitous empty lines that creeped into command line output - changed comment color to a dark green so that links don't visually melt into them - removed some TODOs - updated doc.go R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8108044
* godoc: pass *PageInfos instead of *token.FileSets in templatesRobert Griesemer2013-03-262-35/+35
| | | | | | | | | | | | | | | | - convert all formatters that require a *token.FileSet to consistenly use a *PageInfo as first argument instead - adjust templates correspondingly - fix outstanding bug from previous CL 8005044 Going forward, with this change the affected functions have access to the full page "context" (PageInfo), not just the respective file set. This will permit better context-dependent formatting in the future. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7860049
* lib/codereview/codereview.py: fix crash when hg gofmt has no filesRob Pike2013-03-261-1/+2
| | | | | | | | | The gofmt function was returning a string, which isn't the right type. Three cheers for dynamic typing. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7917044