summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* codereview: do not hit upload_complete on first patchRuss Cox2014-08-061-1/+2
| | | | | | | | Causes server 500 error, so don't do it. TBR=minux CC=golang-codereviews https://codereview.appspot.com/125770043
* codereview: fix submit of merge + include branch prefix in submitted messageRuss Cox2014-08-061-8/+21
| | | | | | | | | | | | hg insists that we not list explicit files for a merge. for benefit of other tools reading logs, include branch prefix at start of every commit message. LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/124780044
* codereview: handle upload of mergeRuss Cox2014-08-061-3/+15
| | | | | | | LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/118690043
* codereview: preserve branch prefix in subject during hg mailRuss Cox2014-08-061-8/+10
| | | | | | | LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/124800043
* codereview: enable work and code reviews in development branchesRuss Cox2014-08-061-5/+17
| | | | | | | | | | This is an experiment. See mail on golang-dev (subject: "an experiment: development branches"). LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/117660043
* codereview: abort 'hg commit' before entering commit message.Shenghou Ma2014-07-181-4/+4
| | | | | | | | | | Hook pre-commit runs before 'hg commit' command whereas hook precommit runs after the user has entered commit message. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/106320043
* codereview: revive the tests.Shenghou Ma2014-07-182-14/+31
| | | | | | | LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/105500043
* codereview: update name of the a+c toolBrad Fitzpatrick2014-07-011-1/+1
| | | | | | | LGTM=rsc R=rsc, minux CC=golang-codereviews https://codereview.appspot.com/105480043
* lib/codereview: fix doc/go1.*.txt exceptionRuss Cox2014-06-121-1/+1
| | | | | | | LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/108950046
* codereview: no LGTM needed for doc/go1.x.txtRuss Cox2014-06-121-3/+13
| | | | | | | | | | Rob asked for this change to make maintaining go1.4.txt easier. If you are not sure of a change, it is still okay to send for review. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/109880044
* codereview: do not add defaultcc for private CLsRuss Cox2014-06-051-2/+2
| | | | | | | LGTM=r R=r, 0xjnml, bradfitz, iant CC=golang-codereviews https://codereview.appspot.com/103070046
* lib/timezone: update to IANA 2014dRob Pike2014-06-012-2/+2
| | | | | | | LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/102040045
* lib/time/zoneinfo.zip: update to IANA release 2014cRob Pike2014-05-162-2/+2
| | | | | | | LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://codereview.appspot.com/93420046
* lib/time: update time zone info to v.2014bRobert Hencke2014-04-292-4/+2
| | | | | | | | | | | Fixes issue 7412. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://codereview.appspot.com/92850043 Committer: Rob Pike <r@golang.org>
* codereview: remove unused upload_options.revisionPatrick M?zard2014-02-241-12/+9
| | | | | | | | | LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://codereview.appspot.com/60640052 Committer: Russ Cox <rsc@golang.org>
* codereview: fix for Mercurial 2.9Anthony Martin2014-02-141-1/+1
| | | | | | | | | | | | The branchtags method was removed but we should've been using branchmap all along. http://selenic.com/hg/rev/4274eda143cb LGTM=franciscossouza, r R=golang-codereviews, franciscossouza, r CC=golang-codereviews https://codereview.appspot.com/57500045
* codereview: warn about 'hg upload' not uploadingRuss Cox2014-02-131-0/+2
| | | | | | | | | | | | This seems to be what causes the 'chunk mismatch' errors. I don't know why the server tells us there's nothing to upload, but at the least we can warn that it did, so that the user will try again. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/62840043
* lib/codereview: allow addca CLs without LGTMRuss Cox2014-02-101-1/+6
| | | | | | | LGTM=gri R=golang-codereviews, gri CC=golang-codereviews https://codereview.appspot.com/61610043
* lib/codereview: add LGTM= line to commit messagesRuss Cox2014-01-231-5/+20
| | | | | | | | | | | The R= is populated by Rietveld, so it's basically anyone who replied to the CL. The LGTM= is meant to record who actually signed off on the CL. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/55390043
* codereview: switch defaultcc to golang-codereviewsRuss Cox2013-12-201-1/+1
| | | | | | | | | See this thread for background: https://groups.google.com/forum/#!topic/golang-dev/xG7vPi21r8g R=golang-codereviews, gobot, golang-dev, dsymonds CC=golang-codereviews, golang-dev https://codereview.appspot.com/44450043
* plan9: correct create permissions with union directoryJeff Sickel2013-10-231-1/+1
| | | | | | | | R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/15360045 Committer: Russ Cox <rsc@golang.org>
* lib/codereview: return an empty list when CONTRIBUTORS is not found instead ↵Francesc Campoy2013-10-101-1/+1
| | | | | | | | of None. R=adg, campoy, r CC=golang-dev https://codereview.appspot.com/14419059
* codereview: fix hg sync closing of CLs for subrepositoriesDominik Honnef2013-10-101-1/+1
| | | | | | | | | | | | The regexp for closing CLs that were sent by you but committed by someone else only matched messages for the main repository, because of the added &repo=... for subrepositories. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/14512045 Committer: Rob Pike <r@golang.org>
* lib/time: update time zone files to version 2013gRob Pike2013-10-082-2/+4
| | | | | | | | | | This dataset is current as of Sep 30, 2013. Fixes issue 6524 R=golang-dev, minux.ma CC=golang-dev https://codereview.appspot.com/14570044
* codereview: move dotfiles out of user home director to something sane.Jeff Sickel2013-10-071-0/+8
| | | | | | | | | | See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp R=golang-dev, r, rsc CC=aram.h, golang-dev https://codereview.appspot.com/14374045 Committer: Russ Cox <rsc@golang.org>
* codereview: update use of promptchoice for Mercurial 2.7Anthony Martin2013-09-061-1/+4
| | | | | | | | | | Fixes issue 6186. R=golang-dev, bradfitz, remyoudompheng, rsc CC=golang-dev https://codereview.appspot.com/13112043 Committer: Russ Cox <rsc@golang.org>
* cmd/godoc: delete from core repositoryAndrew Gerrand2013-08-0111-707/+0
| | | | | | | | The godoc command now lives at code.google.com/p/go.tools/cmd/godoc. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/12206044
* doc: don't block page load on JavaScript fetchAndrew Gerrand2013-07-302-62/+7
| | | | | | R=golang-dev, dsymonds CC=golang-dev https://codereview.appspot.com/12050045
* cmd/godoc: set up playground for examples that are already visibleAndrew Gerrand2013-07-021-9/+18
| | | | | | | | | | This fixes an issue where linking directly to an example makes it not runnable and visible only in a tiny window. To see the bug in action, visit this link: http://golang.org/pkg/strings/#example_Map R=golang-dev, r CC=golang-dev https://codereview.appspot.com/10679050
* codereview: force hg update after hg pull -u during hg syncRuss Cox2013-06-251-1/+32
| | | | | | | | | | | If you hg update your client to an earlier CL, then hg sync will move you back to tip if it pulls anything in, but it will leave you where you are if it doesn't pull anything in. That's confusing: make hg sync always update to tip. R=golang-dev, bradfitz, r, dsymonds CC=golang-dev https://codereview.appspot.com/10456044
* godoc: always use local jQuery scriptAndrew Gerrand2013-06-071-2/+1
| | | | | | | | Fixes issue 5075. R=golang-dev, dsymonds CC=golang-dev https://codereview.appspot.com/10084044
* codereview: don't warn about secret commitsAnthony Martin2013-06-041-2/+6
| | | | | | | | | | | | | | | | | | | | | Normally the codereview plugin disables adding new commits when not using the submit command. Unfortunately this makes it impossible to use the Mercurial Queues extension at the same time. A feature called "Phases" was introduced in Mercurial 2.1 that allows marking commits as being secret; this means they will never be pushed to the upstream repository. We can take advantage of this feature to allow the use of Mercurial Queues if the mq.secret option has been set in hgrc(5) and a recent version of Mercurial is used. R=golang-dev, rsc, minux.ma CC=golang-dev https://codereview.appspot.com/7398055 Committer: Brad Fitzpatrick <bradfitz@golang.org>
* codereview.py: improve error message when user is not a committerFrancesc Campoy2013-05-221-0/+3
| | | | | | R=adg, bradfitz, r CC=golang-dev https://codereview.appspot.com/9626045
* lib/time: update to IANA 2013cRob Pike2013-04-222-2/+2
| | | | | | | | | | | This should do it for the release. There was a new data set pushed out a couple of days ago. Fixes issue 4553. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8621044
* lib/time: update time zone to IANA version 2013bRob Pike2013-04-022-2/+2
| | | | | | | | Update issue 4553. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8293043
* cmd/godoc: don't linkify index entriesRobert Griesemer2013-04-021-12/+12
| | | | | | | | Fixes issue 5186. R=bradfitz CC=golang-dev https://codereview.appspot.com/8267044
* cmd/godoc: provide a link from notes to source locationRobert Griesemer2013-03-281-2/+2
| | | | | | R=golang-dev, r CC=golang-dev https://codereview.appspot.com/8122043
* cmd/godoc: cleanupsRobert Griesemer2013-03-281-8/+7
| | | | | | | | | | | - removed gratuitous empty lines that creeped into command line output - changed comment color to a dark green so that links don't visually melt into them - removed some TODOs - updated doc.go R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8108044
* godoc: pass *PageInfos instead of *token.FileSets in templatesRobert Griesemer2013-03-262-35/+35
| | | | | | | | | | | | | | | | - convert all formatters that require a *token.FileSet to consistenly use a *PageInfo as first argument instead - adjust templates correspondingly - fix outstanding bug from previous CL 8005044 Going forward, with this change the affected functions have access to the full page "context" (PageInfo), not just the respective file set. This will permit better context-dependent formatting in the future. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7860049
* lib/codereview/codereview.py: fix crash when hg gofmt has no filesRob Pike2013-03-261-1/+2
| | | | | | | | | The gofmt function was returning a string, which isn't the right type. Three cheers for dynamic typing. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7917044
* go/doc, godoc: improved note readingRobert Griesemer2013-03-192-2/+4
| | | | | | | | | | | | | | | | | | | | | | - A note doesn't have to be in the first comment of a comment group anymore, and several notes may appear in the same comment group (e.g., it is fairly common to have a TODO(uid) note immediately following another comment). - Define a doc.Note type which also contains note uid and position info. - Better formatting in godoc output. The position information is not yet used, but could be used to locate the note in the source text if desired. Fixes issue 4843. R=r, cnicolaou CC=gobot, golang-dev https://codereview.appspot.com/7496048
* lib/godoc: convert indentation to tabs.Oling Cat2013-03-191-10/+10
| | | | | | | | R=golang-dev, dsymonds, rsc CC=golang-dev https://codereview.appspot.com/7497048 Committer: Russ Cox <rsc@golang.org>
* codereview: re-enable 15-second status printsRuss Cox2013-03-151-1/+3
| | | | | | | | | | | | Also print all status changes when using hg -v. The start_status_thread call was lost during the refactoring in https://codereview.appspot.com/5395044/diff/6006/lib/codereview/codereview.py Oops. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/7834044
* cmd/godoc: fix BUGS heading in text modeRuss Cox2013-03-131-1/+1
| | | | | | | | | | All the headings are CAPS not Title. Fixes issue 4843. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7792043
* cmd/godoc: only show package documentation for commandsRobert Griesemer2013-03-112-8/+11
| | | | | | | | | | | Fixed package.txt and adjusted package.html to match structure (swapped if branches). Fixes issue 4861. R=golang-dev, adg, rsc CC=golang-dev https://codereview.appspot.com/7714043
* lib/time: update link in README; draft now an RFCRuss Cox2013-03-111-1/+1
| | | | | | R=golang-dev, minux.ma, bradfitz CC=golang-dev https://codereview.appspot.com/7704043
* cmd/godoc: add support for display Notes parsed by pkg/go/docCosmos Nicolaou2013-02-252-20/+7
| | | | | | | | | | | pkg/go/doc: move BUG notes from Package.Bugs to the general Package.Notes field. Removing .Bugs would break existing code so it's left in for now. R=gri, gri, gary.burd, dsymonds, rsc, kevlar CC=golang-dev https://codereview.appspot.com/7341053 Committer: Robert Griesemer <gri@golang.org>
* cmd/godoc: show examples in text modeVolker Dobler2013-02-251-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added the command line flag -ex to godoc to print examples in text output. Samples from the generated output: $ godoc -ex strings Index ... func Index(s, sep string) int Index returns the index of the first instance of sep in s, or -1 if sep is not present in s. Example: fmt.Println(strings.Index("chicken", "ken")) fmt.Println(strings.Index("chicken", "dmr")) // Output: // 4 // -1 ... $ godoc -ex container/heap ... package heap import "container/heap" Package heap provides heap operations for any type that implements heap.Interface. A heap is a tree with the property that each node is the minimum-valued node in its subtree. Example: // This example demonstrates an integer heap built using the heap interface. package heap_test import ( "container/heap" "fmt" ... Example: // This example demonstrates a priority queue built using the heap interface. package heap_test import ( "container/heap" "fmt" ) ... Fixes issue 3587. R=golang-dev, minux.ma, adg, rsc, gri CC=golang-dev https://codereview.appspot.com/7356043 Committer: Andrew Gerrand <adg@golang.org>
* cmd/godoc: use go/build to determine package and example filesRobert Griesemer2013-02-192-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Also: - faster code for example extraction - simplify handling of command documentation: all "main" packages are treated as commands - various minor cleanups along the way For commands written in Go, any doc.go file containing documentation must now be part of package main (rather then package documentation), otherwise the documentation won't show up in godoc (it will still build, though). For commands written in C, documentation may still be in doc.go files defining package documentation, but the recommended way is to explicitly ignore those files with a +build ignore constraint to define package main. Fixes issue 4806. R=adg, rsc, dave, bradfitz CC=golang-dev https://codereview.appspot.com/7333046
* codereview: give up on http fetch after 30 secondsRuss Cox2013-02-191-0/+2
| | | | | | | | | | | | | | If Python blocks in the SSL handshake it seems to be completely uninterruptible, and I've been seeing it block for at least hours recently. I don't know if the problem is on the client side or the server side or somewhere in the network, but setting the timeout at least means you're guaranteed a new shell prompt (after printing some errors). R=golang-dev, bradfitz, minux.ma CC=golang-dev https://codereview.appspot.com/7337048
View Lorry Controller Status