diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 18:28:23 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 18:28:23 -0400 |
| commit | 1a61f70b5daed5996fff4738ce41101af943003b (patch) | |
| tree | 0ae61294117d507a76244909cfd5bef913c5b3b2 /contrib/motosend.c | |
| parent | 02ecef02e70fec0d07accea5e8a051d3d5e53469 (diff) | |
| download | gpsd-1a61f70b5daed5996fff4738ce41101af943003b.tar.gz | |
Write scan-build suppressions to it runs clean.
Promote scan-build to be onere of the stock pre-release checks.
Fix one minor cppcheck nit.
Diffstat (limited to 'contrib/motosend.c')
| -rw-r--r-- | contrib/motosend.c | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/contrib/motosend.c b/contrib/motosend.c index 05c73530..30731588 100644 --- a/contrib/motosend.c +++ b/contrib/motosend.c @@ -168,19 +168,21 @@ char *gpsd_hexdump(char *binbuf, size_t binbuflen) int gpsd_hexpack(char *src, char *dst, int len) { - int i, l, k; + int i, l; - l = (int)(strlen(src) / 2); - if ((l < 1) || (l > len)) - return -1; + l = (int)(strlen(src) / 2); + if ((l < 1) || (l > len)) + return -1; - bzero(dst, len); - for (i = 0; i < l; i++) - if ((k = hex2bin(src+i*2)) != -1) - dst[i] = (char)(k & 0xff); - else - return -1; - return l; + bzero(dst, len); + for (i = 0; i < l; i++) { + int k; + if ((k = hex2bin(src+i*2)) != -1) + dst[i] = (char)(k & 0xff); + else + return -1; + } + return l; } int hex2bin(char *s) |