Restrict usage scope of the fixbuffer private member.

Change the data management slightly so the fixbuffer private member
doesn't have to be exposed outside libgpsd_core.c any more.  Oddly,
this accidentally fixed a minor bug, shown by 5 regression tests in
which the pseudo-NMEA code should have been generating $GPGBS (because
ex/ey/ev show up in the TPV output) but weren't actually doing so.
Other than these virtuous additions, all regression tests pass.

1 files changed, 11 insertions, 0 deletions

diff --git a/test/daemon/bu303-stillfix.log.chk b/test/daemon/bu303-stillfix.log.chk
index 4621f637..72f89805 100644
--- a/test/daemon/bu303-stillfix.log.chk
+++ b/test/daemon/bu303-stillfix.log.chk
@@ -4,6 +4,7 @@ $GPGSV,2,2,08,10,50,304,37,04,16,199,36,02,34,241,43,27,71,076,43*71
 $GPGGA,143415,4629.8901,N,00734.0471,E,1,05,2.40,1349.51,M,48.183,M,,*71

 $GPRMC,143415,A,4629.8901,N,00734.0471,E,0.1776,10.379,090605,,*11

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143415,10.93,M,15.48,M,32.90,M*03

 {"class":"TPV","tag":"MID2","time":1118327655.280,"ept":0.005,"lat":46.498167579,"lon":7.567452213,"alt":1349.507,"epx":10.931,"epy":15.480,"epv":32.905,"track":10.3789,"speed":0.091,"climb":-0.085,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,43,29,13,273,00*70

 $GPGSV,2,2,08,10,50,304,36,04,16,199,36,02,34,241,44,27,71,076,43*77

@@ -11,6 +12,7 @@ $GPGSV,2,2,08,10,50,304,36,04,16,199,36,02,34,241,44,27,71,076,43*77
 $GPGGA,143416,4629.8905,N,00734.0473,E,1,05,2.40,1347.42,M,48.183,M,,*78

 $GPRMC,143416,A,4629.8905,N,00734.0473,E,0.1776,10.379,090605,,*14

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143416,10.98,M,15.45,M,32.72,M*0A

 {"class":"TPV","tag":"MID2","time":1118327656.280,"ept":0.005,"lat":46.498174322,"lon":7.567455643,"alt":1347.417,"epx":10.980,"epy":15.454,"epv":32.724,"track":10.3789,"speed":0.091,"climb":-0.085,"eps":30.93,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,44,29,13,273,00*77

 $GPGSV,2,2,08,10,50,304,38,04,16,199,35,02,34,241,44,27,71,076,42*7B

@@ -18,6 +20,7 @@ $GPGSV,2,2,08,10,50,304,38,04,16,199,35,02,34,241,44,27,71,076,42*7B
 $GPGGA,143417,4629.8908,N,00734.0474,E,1,05,2.40,1346.73,M,48.183,M,,*70

 $GPRMC,143417,A,4629.8908,N,00734.0474,E,0.0000,0.000,090605,,*24

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143417,10.98,M,15.45,M,32.72,M*0B

 {"class":"TPV","tag":"MID2","time":1118327657.280,"ept":0.005,"lat":46.498180789,"lon":7.567457358,"alt":1346.734,"epx":10.980,"epy":15.454,"epv":32.724,"track":0.0000,"speed":0.000,"climb":0.000,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,45,29,13,273,00*76

 $GPGSV,2,2,08,10,50,304,38,04,16,199,35,02,34,241,43,27,71,076,43*7D

@@ -25,6 +28,7 @@ $GPGSV,2,2,08,10,50,304,38,04,16,199,35,02,34,241,43,27,71,076,43*7D
 $GPGGA,143418,4629.8912,N,00734.0475,E,1,05,2.40,1346.05,M,48.183,M,,*74

 $GPRMC,143418,A,4629.8912,N,00734.0475,E,0.1776,10.379,090605,,*1A

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143418,10.98,M,15.45,M,32.72,M*04

 {"class":"TPV","tag":"MID2","time":1118327658.280,"ept":0.005,"lat":46.498187256,"lon":7.567459073,"alt":1346.052,"epx":10.980,"epy":15.454,"epv":32.724,"track":10.3789,"speed":0.091,"climb":-0.085,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,44,29,13,273,00*77

 $GPGSV,2,2,08,10,50,304,36,04,16,199,32,02,34,241,39,27,71,076,41*7B

@@ -32,6 +36,7 @@ $GPGSV,2,2,08,10,50,304,36,04,16,199,32,02,34,241,39,27,71,076,41*7B
 $GPGGA,143419,4629.8909,N,00734.0475,E,1,05,2.40,1345.33,M,48.183,M,,*79

 $GPRMC,143419,A,4629.8909,N,00734.0475,E,0.1776,10.379,090605,,*11

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143419,10.98,M,15.45,M,32.72,M*05

 {"class":"TPV","tag":"MID2","time":1118327659.280,"ept":0.005,"lat":46.498181065,"lon":7.567459073,"alt":1345.327,"epx":10.980,"epy":15.454,"epv":32.724,"track":10.3789,"speed":0.091,"climb":-0.085,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,46,29,13,273,00*75

 $GPGSV,2,2,08,10,50,304,38,04,16,199,34,02,34,241,41,27,71,076,41*7C

@@ -39,6 +44,7 @@ $GPGSV,2,2,08,10,50,304,38,04,16,199,34,02,34,241,41,27,71,076,41*7C
 $GPGGA,143420,4629.8913,N,00734.0476,E,1,05,2.40,1344.64,M,48.183,M,,*78

 $GPRMC,143420,A,4629.8913,N,00734.0476,E,0.1673,180.000,090605,,*22

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143420,10.98,M,15.45,M,32.72,M*0F

 {"class":"TPV","tag":"MID2","time":1118327660.280,"ept":0.005,"lat":46.498187532,"lon":7.567460788,"alt":1344.644,"epx":10.980,"epy":15.454,"epv":32.724,"track":180.0000,"speed":0.086,"climb":-0.091,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,46,29,13,273,00*75

 $GPGSV,2,2,08,10,50,304,37,04,16,199,36,02,34,241,43,27,71,076,41*73

@@ -46,6 +52,7 @@ $GPGSV,2,2,08,10,50,304,37,04,16,199,36,02,34,241,43,27,71,076,41*73
 $GPGGA,143421,4629.8916,N,00734.0478,E,1,05,2.40,1343.96,M,48.183,M,,*78

 $GPRMC,143421,A,4629.8916,N,00734.0478,E,0.1776,10.379,090605,,*19

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143421,10.98,M,15.45,M,32.72,M*0E

 {"class":"TPV","tag":"MID2","time":1118327661.280,"ept":0.005,"lat":46.498193999,"lon":7.567462504,"alt":1343.962,"epx":10.980,"epy":15.454,"epv":32.724,"track":10.3789,"speed":0.091,"climb":-0.085,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,45,29,13,273,00*76

 $GPGSV,2,2,08,10,50,304,38,04,16,199,36,02,34,241,42,27,71,076,42*7E

@@ -53,6 +60,7 @@ $GPGSV,2,2,08,10,50,304,38,04,16,199,36,02,34,241,42,27,71,076,42*7E
 $GPGGA,143422,4629.8916,N,00734.0478,E,1,05,2.40,1343.96,M,48.183,M,,*7B

 $GPRMC,143422,A,4629.8916,N,00734.0478,E,0.0000,0.000,090605,,*21

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143422,10.98,M,15.45,M,32.72,M*0D

 {"class":"TPV","tag":"MID2","time":1118327662.280,"ept":0.005,"lat":46.498193999,"lon":7.567462504,"alt":1343.962,"epx":10.980,"epy":15.454,"epv":32.724,"track":0.0000,"speed":0.000,"climb":0.000,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,45,29,13,273,00*76

 $GPGSV,2,2,08,10,50,304,37,04,16,199,36,02,34,241,42,27,71,076,43*70

@@ -60,6 +68,7 @@ $GPGSV,2,2,08,10,50,304,37,04,16,199,36,02,34,241,42,27,71,076,43*70
 $GPGGA,143423,4629.8917,N,00734.0470,E,1,05,2.40,1343.87,M,48.183,M,,*73

 $GPRMC,143423,A,4629.8917,N,00734.0470,E,0.0000,0.000,090605,,*29

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143423,10.98,M,15.45,M,32.72,M*0C

 {"class":"TPV","tag":"MID2","time":1118327663.280,"ept":0.005,"lat":46.498194858,"lon":7.567449593,"alt":1343.871,"epx":10.980,"epy":15.454,"epv":32.724,"track":0.0000,"speed":0.000,"climb":0.000,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,46,29,13,273,00*75

 $GPGSV,2,2,08,10,50,304,36,04,16,199,36,02,34,241,42,27,71,076,42*70

@@ -67,6 +76,7 @@ $GPGSV,2,2,08,10,50,304,36,04,16,199,36,02,34,241,42,27,71,076,42*70
 $GPGGA,143424,4629.8921,N,00734.0471,E,1,05,2.40,1343.19,M,48.183,M,,*77

 $GPRMC,143424,A,4629.8921,N,00734.0471,E,0.1776,10.379,090605,,*11

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143424,10.98,M,15.45,M,32.72,M*0B

 {"class":"TPV","tag":"MID2","time":1118327664.280,"ept":0.005,"lat":46.498201325,"lon":7.567451308,"alt":1343.189,"epx":10.980,"epy":15.454,"epv":32.724,"track":10.3788,"speed":0.091,"climb":-0.085,"eps":30.91,"mode":3}

 $GPGSV,2,1,08,23,06,084,00,28,07,160,00,08,65,189,46,29,13,273,00*75

 $GPGSV,2,2,08,10,50,304,36,04,16,199,37,02,34,241,42,27,71,076,42*71

@@ -74,4 +84,5 @@ $GPGSV,2,2,08,10,50,304,36,04,16,199,37,02,34,241,42,27,71,076,42*71
 $GPGGA,143425,4629.8921,N,00734.0471,E,1,05,2.40,1343.19,M,48.183,M,,*76

 $GPRMC,143425,A,4629.8921,N,00734.0471,E,0.1776,10.379,090605,,*10

 $GPGSA,A,3,08,10,04,02,27,,,,,,,,1.9,2.4,1.4*33

+$GPGBS,143425,10.98,M,15.45,M,32.72,M*0A

 {"class":"TPV","tag":"MID2","time":1118327665.280,"ept":0.005,"lat":46.498201325,"lon":7.567451308,"alt":1343.189,"epx":10.980,"epy":15.454,"epv":32.724,"track":10.3788,"speed":0.091,"climb":-0.085,"eps":30.91,"mode":3}