Restrict usage scope of the fixbuffer private member.

Change the data management slightly so the fixbuffer private member
doesn't have to be exposed outside libgpsd_core.c any more.  Oddly,
this accidentally fixed a minor bug, shown by 5 regression tests in
which the pseudo-NMEA code should have been generating $GPGBS (because
ex/ey/ev show up in the TPV output) but weren't actually doing so.
Other than these virtuous additions, all regression tests pass.

1 files changed, 22 insertions, 0 deletions

diff --git a/test/daemon/navcom.log.chk b/test/daemon/navcom.log.chk
index 154a7264..b01d6b4a 100644
--- a/test/daemon/navcom.log.chk
+++ b/test/daemon/navcom.log.chk
@@ -1,6 +1,7 @@
 $GPGGA,102009,3020.5010,N,01213.7241,E,2,09,1.00,627.59,M,31.479,M,,*40

 $GPRMC,102009,A,3020.5010,N,01213.7241,E,0.0019,90.000,150107,,*10

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102009,0.22,M,0.22,M,10.35,M*03

 {"class":"TPV","tag":"0xb1","time":1168856409.000,"ept":3.920,"lat":30.341683155,"lon":12.228735775,"alt":627.588,"epx":0.222,"epy":0.222,"epv":10.350,"track":90.0000,"speed":0.001,"climb":0.006,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -9,6 +10,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,34*7C
 $GPGGA,102010,3020.5010,N,01213.7241,E,2,09,1.00,627.58,M,31.479,M,,*49

 $GPRMC,102010,A,3020.5010,N,01213.7241,E,31847.9464,0.000,150107,,*2F

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102010,0.22,M,0.22,M,10.35,M*0B

 {"class":"TPV","tag":"0xb1","time":1168856410.000,"ept":3.920,"lat":30.341683205,"lon":12.228735818,"alt":627.577,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":16383.999,"climb":0.008,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -17,6 +19,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,32*7A
 $GPGGA,102011,3020.5010,N,01213.7242,E,2,09,1.00,627.56,M,31.479,M,,*45

 $GPRMC,102011,A,3020.5010,N,01213.7242,E,0.0019,90.000,150107,,*1A

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102011,0.22,M,0.22,M,10.35,M*0A

 {"class":"TPV","tag":"0xb1","time":1168856411.000,"ept":3.920,"lat":30.341683095,"lon":12.228735894,"alt":627.558,"epx":0.222,"epy":0.222,"epv":10.350,"track":90.0000,"speed":0.001,"climb":16383.996,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -25,6 +28,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,44*7B
 $GPGGA,102012,3020.5010,N,01213.7242,E,2,09,1.00,627.55,M,31.479,M,,*45

 $GPRMC,102012,A,3020.5010,N,01213.7242,E,0.0019,90.000,150107,,*19

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102012,0.22,M,0.22,M,10.35,M*09

 {"class":"TPV","tag":"0xb1","time":1168856412.000,"ept":3.920,"lat":30.341683146,"lon":12.228735886,"alt":627.552,"epx":0.222,"epy":0.222,"epv":10.350,"track":90.0000,"speed":0.001,"climb":0.001,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -33,6 +37,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,44*7B
 $GPGGA,102013,3020.5010,N,01213.7242,E,2,09,1.00,627.55,M,31.480,M,,*42

 $GPRMC,102013,A,3020.5010,N,01213.7242,E,0.0019,0.000,150107,,*21

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102013,0.22,M,0.22,M,10.35,M*08

 {"class":"TPV","tag":"0xb1","time":1168856413.000,"ept":3.920,"lat":30.341683214,"lon":12.228735860,"alt":627.552,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":0.001,"climb":0.000,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,34*7E

@@ -41,6 +46,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,44*7B
 $GPGGA,102014,3020.5010,N,01213.7242,E,2,09,1.00,627.54,M,31.479,M,,*42

 $GPRMC,102014,A,3020.5010,N,01213.7242,E,0.0019,0.000,150107,,*26

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102014,0.22,M,0.22,M,10.35,M*0F

 {"class":"TPV","tag":"0xb1","time":1168856414.000,"ept":3.920,"lat":30.341683205,"lon":12.228735860,"alt":627.538,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":0.001,"climb":0.001,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,34*7E

@@ -49,6 +55,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102015,3020.5010,N,01213.7242,E,2,09,1.00,627.55,M,31.479,M,,*42

 $GPRMC,102015,A,3020.5010,N,01213.7242,E,31847.9407,0.000,150107,,*2C

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102015,0.22,M,0.22,M,10.35,M*0E

 {"class":"TPV","tag":"0xb1","time":1168856415.000,"ept":3.920,"lat":30.341683138,"lon":12.228735911,"alt":627.551,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":16383.996,"climb":0.002,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,34*7E

@@ -57,6 +64,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102016,3020.5010,N,01213.7242,E,2,09,1.00,627.55,M,31.479,M,,*41

 $GPRMC,102016,A,3020.5010,N,01213.7242,E,0.0019,0.000,150107,,*24

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102016,0.22,M,0.22,M,10.35,M*0D

 {"class":"TPV","tag":"0xb1","time":1168856416.000,"ept":3.920,"lat":30.341683138,"lon":12.228735852,"alt":627.550,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":0.001,"climb":0.005,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -65,6 +73,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,01*7A
 $GPGGA,102017,3020.5010,N,01213.7242,E,2,09,1.00,627.56,M,31.479,M,,*43

 $GPRMC,102017,A,3020.5010,N,01213.7242,E,0.0000,0.000,150107,,*2D

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102017,0.22,M,0.22,M,10.35,M*0C

 {"class":"TPV","tag":"0xb1","time":1168856417.000,"ept":3.920,"lat":30.341683189,"lon":12.228735877,"alt":627.561,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":0.000,"climb":0.000,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -73,6 +82,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,33*7B
 $GPGGA,102018,3020.5010,N,01213.7241,E,2,09,1.00,627.56,M,31.479,M,,*4F

 $GPRMC,102018,A,3020.5010,N,01213.7241,E,0.0019,90.000,150107,,*10

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102018,0.22,M,0.22,M,10.35,M*03

 {"class":"TPV","tag":"0xb1","time":1168856418.000,"ept":3.920,"lat":30.341683180,"lon":12.228735826,"alt":627.560,"epx":0.222,"epy":0.222,"epv":10.350,"track":90.0000,"speed":0.001,"climb":0.006,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -81,6 +91,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102019,3020.5010,N,01213.7242,E,2,09,1.00,627.56,M,31.479,M,,*4D

 $GPRMC,102019,A,3020.5010,N,01213.7242,E,0.0060,71.565,150107,,*15

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102019,0.22,M,0.22,M,10.35,M*02

 {"class":"TPV","tag":"0xb1","time":1168856419.000,"ept":3.920,"lat":30.341683112,"lon":12.228735945,"alt":627.564,"epx":0.222,"epy":0.222,"epv":10.350,"track":71.5651,"speed":0.003,"climb":16383.997,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,34*7E

@@ -89,6 +100,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102020,3020.5010,N,01213.7242,E,2,09,1.00,627.56,M,31.479,M,,*47

 $GPRMC,102020,A,3020.5010,N,01213.7242,E,0.0019,0.000,150107,,*21

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102020,0.22,M,0.22,M,10.35,M*08

 {"class":"TPV","tag":"0xb1","time":1168856420.000,"ept":3.920,"lat":30.341683172,"lon":12.228735936,"alt":627.559,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":0.001,"climb":0.005,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,45,06,36,062,43,25,36,245,43*7E

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -97,6 +109,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102021,3020.5010,N,01213.7242,E,2,09,1.00,627.54,M,31.480,M,,*42

 $GPRMC,102021,A,3020.5010,N,01213.7242,E,31847.9445,0.000,150107,,*2D

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102021,0.22,M,0.22,M,10.35,M*09

 {"class":"TPV","tag":"0xb1","time":1168856421.000,"ept":3.920,"lat":30.341683180,"lon":12.228735886,"alt":627.543,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":16383.998,"climb":0.002,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -105,6 +118,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102022,3020.5010,N,01213.7242,E,2,09,1.00,627.52,M,31.479,M,,*41

 $GPRMC,102022,A,3020.5010,N,01213.7242,E,31847.9464,0.000,150107,,*2D

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102022,0.22,M,0.22,M,10.35,M*0A

 {"class":"TPV","tag":"0xb1","time":1168856422.000,"ept":3.920,"lat":30.341683256,"lon":12.228735869,"alt":627.515,"epx":0.222,"epy":0.222,"epv":10.350,"track":0.0000,"speed":16383.999,"climb":16383.999,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,34*7F

@@ -113,6 +127,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102023,3020.5010,N,01213.7242,E,2,09,1.00,627.54,M,31.479,M,,*46

 $GPRMC,102023,A,3020.5010,N,01213.7242,E,0.0027,45.000,150107,,*1E

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102023,0.22,M,0.22,M,10.35,M*0B

 {"class":"TPV","tag":"0xb1","time":1168856423.000,"ept":3.920,"lat":30.341683197,"lon":12.228735835,"alt":627.542,"epx":0.222,"epy":0.222,"epv":10.350,"track":45.0000,"speed":0.001,"climb":0.001,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,32*79

@@ -121,6 +136,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102024,3020.5010,N,01213.7242,E,2,09,1.00,627.52,M,31.479,M,,*47

 $GPRMC,102024,A,3020.5010,N,01213.7242,E,45039.7977,45.000,150107,,*19

 $GPGSA,A,3,03,06,07,16,18,21,25,30,31,,,,2.0,1.0,1.8*31

+$GPGBS,102024,0.22,M,0.22,M,10.35,M*0C

 {"class":"TPV","tag":"0xb1","time":1168856424.000,"ept":3.920,"lat":30.341683248,"lon":12.228735852,"alt":627.520,"epx":0.222,"epy":0.222,"epv":10.350,"track":45.0000,"speed":23170.474,"climb":0.000,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,39,03,10,284,35*7E

@@ -129,6 +145,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,35*7D
 $GPGGA,102025,3020.5010,N,01213.7242,E,2,08,1.10,627.55,M,31.479,M,,*41

 $GPRMC,102025,A,3020.5010,N,01213.7242,E,0.0057,90.000,150107,,*17

 $GPGSA,A,3,06,07,16,18,21,25,30,31,31,,,,2.3,1.1,2.1*38

+$GPGBS,102025,0.22,M,0.22,M,12.08,M*01

 {"class":"TPV","tag":"0xb1","time":1168856425.000,"ept":5.880,"lat":30.341683205,"lon":12.228735911,"alt":627.549,"epx":0.222,"epy":0.222,"epv":12.075,"track":90.0000,"speed":0.003,"climb":0.001,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,33*79

@@ -137,6 +154,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,34*7C
 $GPGGA,102026,3020.5010,N,01213.7242,E,2,08,1.10,627.54,M,31.479,M,,*43

 $GPRMC,102026,A,3020.5010,N,01213.7242,E,0.0042,26.565,150107,,*1B

 $GPGSA,A,3,06,07,16,18,21,25,30,31,31,,,,2.3,1.1,2.1*38

+$GPGBS,102026,0.22,M,0.22,M,12.08,M*02

 {"class":"TPV","tag":"0xb1","time":1168856426.000,"ept":5.880,"lat":30.341683256,"lon":12.228735936,"alt":627.539,"epx":0.222,"epy":0.222,"epv":12.075,"track":26.5651,"speed":0.002,"climb":0.003,"eps":0.44,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,32*78

@@ -145,6 +163,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,34*7C
 $GPGGA,102027,3020.5010,N,01213.7242,E,2,08,1.10,627.53,M,31.479,M,,*45

 $GPRMC,102027,A,3020.5010,N,01213.7242,E,31847.9464,90.000,150107,,*11

 $GPGSA,A,3,06,07,16,18,21,25,30,31,31,,,,2.3,1.1,2.1*38

+$GPGBS,102027,0.24,M,0.24,M,12.08,M*03

 {"class":"TPV","tag":"0xb1","time":1168856427.000,"ept":5.880,"lat":30.341683265,"lon":12.228735920,"alt":627.531,"epx":0.236,"epy":0.236,"epv":12.075,"track":90.0000,"speed":16383.999,"climb":16383.998,"eps":0.46,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,45,06,36,062,43,25,36,245,43*7E

 $GPGSV,3,2,10,30,26,132,37,16,40,321,42,18,31,140,38,03,10,284,32*77

@@ -153,6 +172,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,34*7C
 $GPGGA,102028,3020.5010,N,01213.7242,E,2,08,1.10,627.54,M,31.479,M,,*4D

 $GPRMC,102028,A,3020.5010,N,01213.7242,E,31847.9464,90.000,150107,,*1E

 $GPGSA,A,3,06,07,16,18,21,25,30,31,31,,,,2.3,1.1,2.1*38

+$GPGBS,102028,0.24,M,0.24,M,12.08,M*0C

 {"class":"TPV","tag":"0xb1","time":1168856428.000,"ept":5.880,"lat":30.341683239,"lon":12.228735920,"alt":627.541,"epx":0.236,"epy":0.236,"epv":12.075,"track":90.0000,"speed":16383.999,"climb":0.002,"eps":0.47,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,33*79

@@ -161,6 +181,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,34*7C
 $GPGGA,102029,3020.5010,N,01213.7242,E,2,08,1.10,627.56,M,31.479,M,,*4E

 $GPRMC,102029,A,3020.5010,N,01213.7242,E,31847.9445,0.000,150107,,*25

 $GPGSA,A,3,06,07,16,18,21,25,30,31,31,,,,2.3,1.1,2.1*38

+$GPGBS,102029,0.24,M,0.24,M,12.08,M*0D

 {"class":"TPV","tag":"0xb1","time":1168856429.000,"ept":5.880,"lat":30.341683214,"lon":12.228735936,"alt":627.555,"epx":0.236,"epy":0.236,"epv":12.075,"track":0.0000,"speed":16383.998,"climb":0.007,"eps":0.47,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,34*7E

@@ -169,6 +190,7 @@ $GPGSV,3,3,10,07,43,056,43,22,13,173,34*7C
 $GPGGA,102030,3020.5010,N,01213.7242,E,2,08,1.10,627.54,M,31.479,M,,*44

 $GPRMC,102030,A,3020.5010,N,01213.7242,E,31847.9464,90.000,150107,,*17

 $GPGSA,A,3,06,07,16,18,21,25,30,31,31,,,,2.3,1.1,2.1*38

+$GPGBS,102030,0.25,M,0.25,M,12.08,M*05

 {"class":"TPV","tag":"0xb1","time":1168856430.000,"ept":5.880,"lat":30.341683231,"lon":12.228735877,"alt":627.537,"epx":0.249,"epy":0.249,"epv":12.075,"track":90.0000,"speed":16383.999,"climb":0.000,"eps":0.49,"mode":3}

 $GPGSV,3,1,10,21,78,040,46,31,39,230,44,06,36,062,43,25,36,245,43*7F

 $GPGSV,3,2,10,30,26,132,38,16,40,321,42,18,31,140,38,03,10,284,34*7E