summaryrefslogtreecommitdiff
path: root/gst/gdp
diff options
context:
space:
mode:
authorVíctor Manuel Jáquez Leal <vjaquez@igalia.com>2018-01-29 12:50:36 +0100
committerVíctor Manuel Jáquez Leal <vjaquez@igalia.com>2018-01-31 14:03:36 +0100
commitf04b20e59e64cf1ebbc67484500892a5387dba9e (patch)
tree1bd92e8065768e8a0b0be4280ccaa5d57315ab52 /gst/gdp
parent538ccb60935cb93a7b711dde61f0cc40a854384b (diff)
downloadgstreamer-plugins-bad-f04b20e59e64cf1ebbc67484500892a5387dba9e.tar.gz
gdpdepay: don't allocation query if caps aren't fixed
When querying downstream for allocation, and the source caps hasn't set its caps, using ANY by default, it raises a critical message in console: CRITICAL **: gst_video_info_from_caps: assertion 'gst_caps_is_fixed (caps)' failed This patch bails out decide_allocation() if the caps aren't fixed. https://bugzilla.gnome.org/show_bug.cgi?id=789476
Diffstat (limited to 'gst/gdp')
-rw-r--r--gst/gdp/gstgdpdepay.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/gst/gdp/gstgdpdepay.c b/gst/gdp/gstgdpdepay.c
index 4d2093870..750571e6f 100644
--- a/gst/gdp/gstgdpdepay.c
+++ b/gst/gdp/gstgdpdepay.c
@@ -560,6 +560,11 @@ gst_gdp_depay_decide_allocation (GstGDPDepay * gdpdepay)
return;
}
+ if (!gst_caps_is_fixed (caps)) {
+ GST_LOG_OBJECT (gdpdepay, "Caps on src pad are not fixed. Not querying.");
+ return;
+ }
+
query = gst_query_new_allocation (caps, TRUE);
if (!gst_pad_peer_query (gdpdepay->srcpad, query)) {
GST_WARNING_OBJECT (gdpdepay, "Peer allocation query failed.");