diff options
author | Elliot Chen <elliot.chen@nxp.com> | 2023-03-02 18:09:54 +0800 |
---|---|---|
committer | Elliot Chen <elliot.chen@nxp.com> | 2023-05-17 15:24:29 +0800 |
commit | f722d9c428615db546248f449b5130a7f65a1439 (patch) | |
tree | fc18d37ae020a2efe5c393b47a177b126559a149 | |
parent | 289bc9c91d8451a62b8bc30bc16863c32b8fab8f (diff) | |
download | gstreamer-f722d9c428615db546248f449b5130a7f65a1439.tar.gz |
gstplay: avoid getting property of playbin2 if subtitle_sid is null
There is a probability of getting "current-text" property
when play with playbin3, and this property is available
only in playbin2.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4106>
-rw-r--r-- | subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c index f99bbe1bcd..c88d8e94c2 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c @@ -1762,9 +1762,11 @@ gst_play_subtitle_info_update (GstPlay * self, GstPlayStreamInfo * stream_info) g_object_get (G_OBJECT (self->playbin), "current-suburi", &suburi, NULL); if (suburi) { - if (self->use_playbin3 && self->subtitle_sid) { - if (g_str_equal (self->subtitle_sid, stream_info->stream_id)) + if (self->use_playbin3) { + if (self->subtitle_sid && + g_str_equal (self->subtitle_sid, stream_info->stream_id)) { info->language = g_path_get_basename (suburi); + } } else { g_object_get (G_OBJECT (self->playbin), "current-text", &text_index, NULL); |