summaryrefslogtreecommitdiff
path: root/issues
Commit message (Collapse)AuthorAgeFilesLines
* Remove main() from most tests.Victor Costan2022-01-033-15/+0
| | | | | | | | | | | | | | | This gives some flexibility to embedders. Currently, embedders have to build a binary for each test file. After this CL, embedders can still choose to have a binary for each test file, by linking each test file with a googletest target that includes main() (usually "gtest_main"). Embedders can also choose to build a single binary for almost all test files, and link with a googletest target that includes main(). The latter is more convenient for projects that have very few test binaries, like Chromium. PiperOrigin-RevId: 419470798
* Add some std:: qualifiers to types and functions.Victor Costan2020-04-291-1/+1
| | | | PiperOrigin-RevId: 309110431
* Internal change.leveldb Team2019-12-023-3/+3
| | | | PiperOrigin-RevId: 282373286
* Switch testing harness to googletest.Victor Costan2019-11-213-29/+36
| | | | PiperOrigin-RevId: 281815695
* Format all files IAW the Google C++ Style Guide.Chris Mumford2019-05-022-14/+8
| | | | | | Use clang-format to correct formatting to be in agreement with the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). Doing this simplifies the process of accepting changes. Also fixed a few warnings flagged by clang-tidy. PiperOrigin-RevId: 246350737
* Fixed missing std namespaces and make_unique.Chris Mumford2019-04-121-9/+11
| | | | | | | | cout/endl were missing the std namespace. Also std::make_unique was used inadvertently which is part of C++14 and only C++11 is currently supported. PiperOrigin-RevId: 243221310
* Simplify issue320_test.Chris Mumford2019-04-121-10/+3
| | | | | | Use std::unique_ptr to simplify issue320_test. PiperOrigin-RevId: 243190799
* Fix formatting of recent snapshot compaction fix.Chris Mumford2019-04-121-32/+26
| | | | | | | Fix variable names, line lengths, namespace use, and a few other minor issues to conform to Google C++ style guide. PiperOrigin-RevId: 243187729
* Merge pull request #339 from richcole-at-amazon:masterChris Mumford2019-04-121-0/+139
|\ | | | | | | PiperOrigin-RevId: 243156105
| * Fix snapshot compaction bugRichard Cole2019-04-011-0/+139
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes google/leveldb#320 During compaction it was possible that records from a block b1=(l1,u1) would be pushed down from level i to level i+1. If there is a block b2=(l2,u2) at level i with k1 = user_key(u1) = user_key(l2) then a subsequent search for k1 will yield the record l2 which has a smaller sequence number than u1 because the sort order for records sorts increasing by user key but decreaing by sequence number. This change add a call to a new function AddBoundaryInputs to SetupOtherInputs. AddBoundaryInputs searches for a block b2 matching the criteria above and adds it to the set of files to be compacted. Whenever AddBoundaryInputs is called it is important that the compaction fileset in level i+1 (known as c->inputs_[1] in the code) be recomputed. Each call to AddBoundaryInputs is followed by a call to GetOverlappingInputs. SetupOtherInputs is called on both manual and automated compaction passes. It is called for both level zero and for levels greater than 0. The original change posted in https://github.com/google/leveldb/pull/339 has been modified to also include changed made by Chris Mumford<cmumford@google.com> in https://github.com/cmumford/leveldb/commit/4b72cb14f8da2aab12451c24b8e205aff686e9dc 1. Releasing snapshots during test cleanup to avoid memory leak warnings. 2. Refactored test to use testutil.h to be in line with other issue tests and to create the test database in the correct temporary location. 3. Added copyright banner. Otherwise, just minor formatting and limiting character width to 80 characters. Additionally the change was rebased on top of current master and changes previously made to the Makefile were ported to the CMakeLists.txt. Testing Done: A test program (issue320_test) was constructed that performs mutations while snapshots are active. issue320_test fails without this bug fix after 64k writes. It passes with this bug fix. It was run with 200M writes and passed. Unit tests were written for the new function that was added to the code. Make test was run and seen to pass. Signed-off-by: Richard Cole <richcole@amazon.com>
* Release LevelDB 1.14v1.14David Grogan2013-09-191-0/+59
| | | | | | | | | | | Fix issues 200, 201 Also, * Fix link to bigtable paper in docs. * New sstables will have the file extension .ldb. .sst files will continue to be recognized. * When building for iOS, use xcrun to execute the compiler. This may affect issue 177.
* Release leveldb 1.12v1.12David Grogan2013-06-181-0/+4
| | | | | | Non-functional changes only: 1) Add Kevin Regan to the AUTHORS file 2) Add standard license header to issues/issue178_test.cc
* Release leveldb 1.11v1.11David Grogan2013-06-131-0/+88
Fixes issues 161 174 178 As well as the issue reported by edouarda14@gmail.com about MissingSSTFile unit test failing on windows.
View Lorry Controller Status