diff options
| author | Petr Pisar <ppisar@redhat.com> | 2011-05-12 13:13:56 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2011-05-16 17:39:33 +0200 |
| commit | 3ad0b3622cf92989584097787323f00bc7a36c48 (patch) | |
| tree | 60f203a986e4f36d5ae7723258cec91ab277ad0c /rquota_svc.c | |
| parent | c3a392437a2ec4793f2b1112058de0c3b459b6fe (diff) | |
| download | linuxquota-3ad0b3622cf92989584097787323f00bc7a36c48.tar.gz | |
Make global symbols static as possible
There are some calls (e.g. getpwnam(3)) that can lead to dlopening
other libraries that could jump to symbol with name clashing to one of
global quota symbols. (e.g. Name server switch plug-in nss_db calls
dirname(3) that's already defined in edquota.c and tht can cause
segmentation fault.)
Although it's not possible to solve all these problems, making as much
as possible global objects and functions static is the best thing we
can do to avoid name space polution.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'rquota_svc.c')
| -rw-r--r-- | rquota_svc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rquota_svc.c b/rquota_svc.c index 7ed8524..17a92f4 100644 --- a/rquota_svc.c +++ b/rquota_svc.c @@ -169,7 +169,7 @@ static void parse_options(int argc, char **argv) * good_client checks if an quota client should be allowed to * execute the requested rpc call. */ -int good_client(struct sockaddr_in *addr, ulong rq_proc) +static int good_client(struct sockaddr_in *addr, ulong rq_proc) { #ifdef HOSTS_ACCESS struct request_info req; |