summaryrefslogtreecommitdiff
path: root/clang/lib/CodeGen/CGException.cpp
diff options
context:
space:
mode:
authorJennifer Yu <jennifer.yu@intel.com>2023-05-10 15:01:52 -0700
committerJennifer Yu <jennifer.yu@intel.com>2023-05-17 14:42:39 -0700
commit691927c904ede183461610387402f5c19dbb3de0 (patch)
treecfbf912f081baf83d0507d98767aa2cb3ce8370f /clang/lib/CodeGen/CGException.cpp
parentfcf0a7bfd1c030ff45866f54415179d3ca5cbfc5 (diff)
downloadllvm-691927c904ede183461610387402f5c19dbb3de0.tar.gz
Fix assertion when try is used inside catch(...) block
Current assert wiht /EHa: A single unwind edge may only enter one EH pad invoke void @llvm.seh.try.begin() to label %invoke.cont1 unwind label %catch.dispatch2 Current IR: %1 = catchpad within %0 [ptr null, i32 0, ptr null] invoke void @llvm.seh.try.begin() to label %invoke.cont5 unwind label %catch.dispatch2 The problem is the invoke to llvm.seh.try.begin() missing "funclet" Accodring: https://llvm.org/docs/LangRef.html#ob-funclet If any "funclet" EH pads have been entered but not exited (per the description in the EH doc), it is undefined behavior to execute a call or invoke. To fix the problem, when emit seh_try_begin, call EmitSehTryScopeBegin, instead of calling EmitRuntimeCallOrInvoke for proper "funclet" gerenration. Differential Revision: https://reviews.llvm.org/D150340
Diffstat (limited to 'clang/lib/CodeGen/CGException.cpp')
-rw-r--r--clang/lib/CodeGen/CGException.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGException.cpp b/clang/lib/CodeGen/CGException.cpp
index 3707c8792491..8b0776b9a52b 100644
--- a/clang/lib/CodeGen/CGException.cpp
+++ b/clang/lib/CodeGen/CGException.cpp
@@ -646,7 +646,7 @@ void CodeGenFunction::EnterCXXTryStmt(const CXXTryStmt &S, bool IsFnTryBlock) {
// Under async exceptions, catch(...) need to catch HW exception too
// Mark scope with SehTryBegin as a SEH __try scope
if (getLangOpts().EHAsynch)
- EmitRuntimeCallOrInvoke(getSehTryBeginFn(CGM));
+ EmitSehTryScopeBegin();
}
}
}