summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2016-04-07 13:45:26 -0500
committerDavid Teigland <teigland@redhat.com>2016-04-11 15:20:52 -0500
commit5817420781c3633a38f5c11515a47ac36d157b4d (patch)
treeb2befa95392e3af060c967c1ce847868d1baaf63
parent8c2f4d00f4bf08c52f18e6373371b93940652cce (diff)
downloadlvm2-dev-dct-lvmetad-disabled-dups-11.tar.gz
toollib: remove unneeded call in process_each_pvdev-dct-lvmetad-disabled-dups-11
process_each_pv was doing: 1. lvmcache_seed_infos_from_lvmetad() sends pv_list request to lvmetad. 2. get_vgnameids() sends vg_list request to lvmetad. 3. _get_all_devices() first calls lvmcache_seed_infos_from_lvmetad(), which is a no-op if it's already been called. Because get_vgnameids() does not use the information from lvmcache_seed_infos_from_lvmetad(), it does not need to be called prior to get_all_devices where it is actually needed.
-rw-r--r--tools/toollib.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/toollib.c b/tools/toollib.c
index ea6f4bc39..af6054751 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3356,12 +3356,6 @@ int process_each_pv(struct cmd_context *cmd,
dev_cache_full_scan(cmd->full_filter);
}
- /*
- * Need pvid's set on all PVs before processing so that pvid's
- * can be compared to find duplicates while processing.
- */
- lvmcache_seed_infos_from_lvmetad(cmd);
-
if (!get_vgnameids(cmd, &all_vgnameids, only_this_vgname, 1)) {
stack;
return ret;