summaryrefslogtreecommitdiff
path: root/items.c
diff options
context:
space:
mode:
authordormando <dormando@rydia.net>2017-08-24 00:32:15 -0700
committerdormando <dormando@rydia.net>2017-08-24 00:32:15 -0700
commit6107b922d633c09d0de7f9b86bac209255a172ad (patch)
treec316f91e52069b69df00a9bdc7f9030a91bbc430 /items.c
parent67287ca792606093bdf53e176dfed3b9d1e92feb (diff)
downloadmemcached-6107b922d633c09d0de7f9b86bac209255a172ad.tar.gz
stats cachedump: always dump COLD LRU
was defaulting to HOT, but HOT can be empty pretty easily and this can be confusing.
Diffstat (limited to 'items.c')
-rw-r--r--items.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/items.c b/items.c
index ccde768..c339c3a 100644
--- a/items.c
+++ b/items.c
@@ -563,7 +563,6 @@ int do_item_replace(item *it, item *new_it, const uint32_t hv) {
* The data could possibly be overwritten, but this is only accessing the
* headers.
* It may not be the best idea to leave it like this, but for now it's safe.
- * FIXME: only dumps the hot LRU with the new LRU's.
*/
char *item_cachedump(const unsigned int slabs_clsid, const unsigned int limit, unsigned int *bytes) {
unsigned int memlimit = 2 * 1024 * 1024; /* 2MB max response size */
@@ -575,8 +574,7 @@ char *item_cachedump(const unsigned int slabs_clsid, const unsigned int limit, u
char key_temp[KEY_MAX_LENGTH + 1];
char temp[512];
unsigned int id = slabs_clsid;
- if (!settings.lru_segmented)
- id |= COLD_LRU;
+ id |= COLD_LRU;
pthread_mutex_lock(&lru_locks[id]);
it = heads[id];